@bugmole/cli 0.5.0 → 0.6.0

package/src/mcp/roles-and-review.test.ts

@@ -0,0 +1,111 @@
+import assert from "node:assert/strict";
+import fs from "node:fs/promises";
+import os from "node:os";
+import path from "node:path";
+import test from "node:test";
+import YAML from "yaml";
+import { callToolInternal, writeSpecFile } from "./server.js";
+import { startLocalRegistryStub } from "../runtime/local-registry-stub.js";
+
+async function project(files: Record<string, string> = {}) {
+  const directory = await fs.mkdtemp(path.join(os.tmpdir(), "bugmole-roles-mcp-"));
+  const specDir = path.join(directory, "spec");
+  await fs.mkdir(specDir, { recursive: true });
+  for (const [name, content] of Object.entries(files)) await fs.writeFile(path.join(specDir, name), content);
+  const cfg = {
+    project: { id: "demo" },
+    runtime: { spec_dir: specDir, artifacts_dir: directory },
+    storage: { provider: "local", localDirectory: directory },
+  };
+  return { directory, specDir, cfg };
+}
+
+/** Points the MCP's registry calls at a local stub for the duration of `run`. */
+async function withRegistry(reviewMode: "manual" | "auto" | "extreme", run: (origin: string) => Promise<void>) {
+  const directory = await fs.mkdtemp(path.join(os.tmpdir(), "bugmole-roles-registry-"));
+  const stub = await startLocalRegistryStub({ directory, reviewMode });
+  const saved = { url: process.env.BUGMOLE_REGISTRY_URL, key: process.env.BUGMOLE_API_KEY };
+  process.env.BUGMOLE_REGISTRY_URL = stub.origin;
+  process.env.BUGMOLE_API_KEY = "bm_test";
+  try {
+    await run(stub.origin);
+  } finally {
+    if (saved.url === undefined) delete process.env.BUGMOLE_REGISTRY_URL; else process.env.BUGMOLE_REGISTRY_URL = saved.url;
+    if (saved.key === undefined) delete process.env.BUGMOLE_API_KEY; else process.env.BUGMOLE_API_KEY = saved.key;
+    await stub.close();
+    await fs.rm(directory, { recursive: true, force: true });
+  }
+}
+
+test("bugmole_write_spec lets an agent suggest roles in roles.yaml, never confirm them", async () => {
+  const { specDir, cfg } = await project({ "roles.yaml": "roles:\n  - name: user\n    description: Signed in.\n" });
+  const result = writeSpecFile("roles.yaml", "roles:\n  - name: user\n  - name: admin\n    description: Admin.\n", cfg);
+  assert.deepEqual(result.suggestedRoles, ["admin"]);
+  assert.match(result.message, /person confirms/);
+  const written = YAML.parse(await fs.readFile(path.join(specDir, "roles.yaml"), "utf8"));
+  assert.equal(written.roles[0].status, undefined);
+  assert.equal(written.roles[1].status, "suggested");
+  assert.equal(writeSpecFile("blockers.yaml", "blockers: []\n", cfg).suggestedRoles, undefined, "other spec files are written as given");
+});
+
+test("bugmole_write_test_cases refuses a case set for a role nobody confirmed", async () => {
+  const graph = {
+    version: 2,
+    nodes: [{ id: "screen:/", title: "Home", kind: "screen", route: "/" }],
+    edges: [],
+    journeys: [{ id: "flow:home", name: "Home", actor: "user", nodeIds: ["screen:/"], edgeIds: [], revision: 1, status: "draft" }],
+  };
+  const { cfg } = await project({
+    "journeys.graph.json": JSON.stringify(graph),
+    "roles.yaml": "roles:\n  - name: user\n  - name: admin\n    status: suggested\n",
+  });
+  const caseSet = (actor: string) => ({
+    schemaVersion: 1, caseSetId: "home", journeyId: "flow:home", journeyRevision: 1, actor,
+    cases: [{ caseId: "TC-1", title: "Home loads", nodeId: "screen:/", intent: "Prove home renders", steps: ["Open /"], expected: ["Home renders"], confidence: "low" }],
+  });
+  await assert.rejects(callToolInternal("bugmole_write_test_cases", { caseSet: caseSet("admin") }, cfg), /only suggested/);
+  await assert.rejects(callToolInternal("bugmole_write_test_cases", { caseSet: caseSet("ghost") }, cfg), /not a confirmed role/);
+  const ok = await callToolInternal("bugmole_write_test_cases", { caseSet: caseSet("user") }, cfg);
+  assert.equal(ok.status, "success");
+});
+
+test("bugmole_role_propose sends a suggestion; bugmole_roles_list shows it waiting", async () => {
+  const { cfg } = await project({ "roles.yaml": "roles:\n  - name: user\n" });
+  await withRegistry("extreme", async () => {
+    await assert.rejects(callToolInternal("bugmole_role_propose", { name: "admin" }, cfg), /evidence/);
+    const proposed = await callToolInternal("bugmole_role_propose", {
+      name: "Admin", description: "Admin area.", source: "role_gated_route", evidence: "route /admin",
+    }, cfg);
+    assert.equal(proposed.role.name, "admin");
+    assert.equal(proposed.role.status, "suggested");
+    assert.match(proposed.message, /only after a person confirms/);
+
+    const listed = await callToolInternal("bugmole_roles_list", {}, cfg);
+    assert.deepEqual(listed.confirmed, ["user"]);
+    assert.deepEqual(listed.suggested, ["admin"]);
+    assert.match(listed.nextSteps[0], /Roles page/);
+  });
+});
+
+test("bugmole_task_update says when a completed task went to review, and the note comes back with it", async () => {
+  const { cfg } = await project();
+  await withRegistry("manual", async (origin) => {
+    const created = await callToolInternal("bugmole_task_create", { title: "Fix it", description: "Fix the header", taskType: "code", idempotencyKey: "fix-1" }, cfg);
+    const taskId = created.task.id;
+    const claimed = await callToolInternal("bugmole_task_next", { workerId: "agent-1" }, cfg);
+    assert.equal(claimed.task.id, taskId);
+
+    const done = await callToolInternal("bugmole_task_update", { taskId, workerId: "agent-1", status: "completed", completionSummary: "Fixed" }, cfg);
+    assert.equal(done.inReview, true);
+    assert.equal(done.task.status, "in_review");
+    assert.match(done.nextSteps[0], /not treat this work as accepted/);
+
+    const sent = await fetch(`${origin}/api/tasks/${taskId}/send-back`, {
+      method: "POST", headers: { "content-type": "application/json" }, body: JSON.stringify({ note: "Also fix the footer" }),
+    });
+    assert.equal(sent.status, 200);
+    const again = await callToolInternal("bugmole_task_next", { workerId: "agent-1" }, cfg);
+    assert.equal(again.task.id, taskId);
+    assert.match(again.message, /Also fix the footer/);
+  });
+});