@bugabinga/pi-ext-diff-review 0.1.0

package/README.md

@@ -0,0 +1,16 @@
+# diff-review
+
+Browser-based git diff review bridge for Pi.
+
+Opens a local browser UI for reviewing diffs and sending findings back to Pi.
+
+## Commands
+
+- `/diff-review`
+- `/diff-review-cancel`
+
+## Demo
+
+<!-- demo:workflow_suite:start -->
+![Workflow suite](assets/workflow_suite.gif)
+<!-- demo:workflow_suite:end -->

package/args.ts

@@ -0,0 +1,101 @@
+import type { ReviewSource } from "./types.js";
+
+export type DiffReviewArgs = {
+	staged: boolean;
+	base?: string;
+	files?: string[];
+};
+
+export function parseArgs(input: string): DiffReviewArgs {
+	const tokens = tokenize(input);
+	const args: DiffReviewArgs = { staged: false };
+
+	for (let i = 0; i < tokens.length; i++) {
+		const token = tokens[i];
+		if (token === "--staged") {
+			args.staged = true;
+			continue;
+		}
+		if (token === "--base") {
+			const value = tokens[++i];
+			if (!value) throw new Error("--base requires a ref");
+			args.base = value;
+			continue;
+		}
+		if (token.startsWith("--base=")) {
+			args.base = token.slice("--base=".length);
+			if (!args.base) throw new Error("--base requires a ref");
+			continue;
+		}
+		if (token === "--files") {
+			const value = tokens[++i];
+			if (!value) throw new Error("--files requires a comma-separated list");
+			args.files = parseFiles(value);
+			continue;
+		}
+		if (token.startsWith("--files=")) {
+			args.files = parseFiles(token.slice("--files=".length));
+			continue;
+		}
+		throw new Error(`Unknown argument: ${token}`);
+	}
+
+	if (args.staged && args.base) throw new Error("--staged and --base are mutually exclusive");
+	return args;
+}
+
+export function sourceFromArgs(args: DiffReviewArgs): ReviewSource {
+	if (args.base) return { kind: "base", base: args.base, ...(args.files && { files: args.files }) };
+	if (args.staged) return { kind: "staged", ...(args.files && { files: args.files }) };
+	return { kind: "working-tree", ...(args.files && { files: args.files }) };
+}
+
+function parseFiles(value: string): string[] {
+	const files = value.split(",").map((file) => file.trim()).filter(Boolean);
+	if (files.length === 0) throw new Error("--files requires at least one path");
+	for (const file of files) validatePathFilter(file);
+	return files;
+}
+
+function validatePathFilter(path: string) {
+	if (path.startsWith("/") || /^[a-zA-Z]:[\\/]/.test(path)) throw new Error(`Path must be relative: ${path}`);
+	if (path.split(/[\\/]+/).includes("..")) throw new Error(`Path cannot contain '..': ${path}`);
+	if (path.includes("\0")) throw new Error("Path cannot contain NUL");
+}
+
+function tokenize(input: string): string[] {
+	const tokens: string[] = [];
+	let current = "";
+	let quote: '"' | "'" | undefined;
+	let escaping = false;
+
+	for (const ch of input.trim()) {
+		if (escaping) {
+			current += ch;
+			escaping = false;
+			continue;
+		}
+		if (ch === "\\" && quote !== "'") {
+			escaping = true;
+			continue;
+		}
+		if ((ch === '"' || ch === "'") && !quote) {
+			quote = ch;
+			continue;
+		}
+		if (ch === quote) {
+			quote = undefined;
+			continue;
+		}
+		if (/\s/.test(ch) && !quote) {
+			if (current) tokens.push(current);
+			current = "";
+			continue;
+		}
+		current += ch;
+	}
+	if (escaping) current += "\\";
+	if (quote) throw new Error("Unclosed quote in arguments");
+	if (current) tokens.push(current);
+	return tokens;
+}

package/browser/assets/JetBrainsMonoNuguCode.LICENSE

@@ -0,0 +1,96 @@
+JetBrains Mono Nugu Code Font
+Copyright 2020 The JetBrains Mono Project Authors (https://github.com/JetBrains/JetBrainsMono)
+Portions Copyright 2014-2024 Ryan L McIntyre (Nerd Fonts, https://github.com/ryanoasis/nerd-fonts)
+
+This font is a patched derivative of JetBrains Mono with Nerd Font icon glyphs
+added, then subset to only the glyphs needed for code review display ("Nugu Code").
+
+Licensed under the SIL Open Font License, Version 1.1.
+See the full license text below.
+
+-----------------------------------------------------------
+SIL OPEN FONT LICENSE Version 1.1 - 26 February 2007
+-----------------------------------------------------------
+
+PREAMBLE
+The goals of the Open Font License (OFL) are to stimulate worldwide
+development of collaborative font projects, to support the font creation
+efforts of academic and linguistic communities, and to provide a free and
+open framework in which fonts may be shared and improved in partnership
+with others.
+
+The OFL allows the licensed fonts to be used, studied, modified and
+redistributed freely as long as they are not sold by themselves. The
+fonts, including any derivative works, can be bundled, embedded,
+redistributed and/or sold with any software provided that any reserved
+names are not used by derivative works. The fonts and derivatives,
+however, cannot be released under any other type of license. The
+requirement for fonts to remain under this license does not apply
+to any document created using the fonts or their derivatives.
+
+DEFINITIONS
+"Font Software" refers to the set of files released by the Copyright
+Holder(s) under this license and clearly marked as such. This may
+include source files, build scripts and documentation.
+
+"Reserved Font Name" refers to any names specified as such after the
+copyright statement(s).
+
+"Original Version" refers to the collection of Font Software components as
+distributed by the Copyright Holder(s).
+
+"Modified Version" refers to any derivative made by adding to, deleting,
+or substituting -- in part or in whole -- any of the components of the
+Original Version, by changing formats or by porting the Font Software to
+a new environment.
+
+"Author" refers to any designer, engineer, programmer, technical
+writer or other person who contributed to the Font Software.
+
+PERMISSION & CONDITIONS
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of the Font Software, to use, study, copy, merge, embed, modify,
+redistribute, and sell modified and unmodified copies of the Font
+Software, subject to the following conditions:
+
+1) Neither the Font Software nor any of its individual components,
+in Original or Modified Versions, may be sold by itself.
+
+2) Original or Modified Versions of the Font Software may be bundled,
+redistributed and/or sold with any software, provided that each copy
+contains the above copyright notice and this license. These can be
+included either as stand-alone text files, human-readable headers or
+in the appropriate machine-readable metadata fields within text or
+binary files as long as those fields can be easily viewed by the user.
+
+3) No Modified Version of the Font Software may use the Reserved Font
+Name(s) unless explicit written permission is granted by the corresponding
+Copyright Holder. This restriction only applies to the primary font name
+as presented to the users.
+
+4) The name(s) of the Copyright Holder(s) or the Author(s) of the
+Font Software shall not be used to promote, endorse or advertise any
+Modified Version, except to acknowledge the contribution(s) of the
+Copyright Holder(s) and the Author(s) or with their explicit written
+permission.
+
+5) The Font Software, modified or unmodified, in part or in whole,
+must be distributed entirely under this license, and must not be
+distributed under any other license. The requirement for fonts to
+remain under this license does not apply to any document created
+using the fonts or their derivatives.
+
+TERMINATION
+This license becomes null and void if any of the above conditions are
+not met.
+
+DISCLAIMER
+THE FONT SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT
+OF COPYRIGHT, PATENT, TRADEMARK, OR OTHER RIGHT. IN NO EVENT SHALL THE
+COPYRIGHT HOLDER BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+INCLUDING ANY GENERAL, SPECIAL, INDIRECT, INCIDENTAL, OR CONSEQUENTIAL
+DAMAGES, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+FROM, OUT OF THE USE OR INABILITY TO USE THE FONT SOFTWARE OR FROM
+OTHER DEALINGS IN THE FONT SOFTWARE.

package/browser/index.html

@@ -0,0 +1,119 @@
+<!doctype html>
+<html lang="en">
+<head>
+  <meta charset="utf-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1" />
+  <title>Pi Diff Review</title>
+  <link rel="icon" href="data:," />
+  <script>
+    (() => {
+      const mode = localStorage.getItem("diff-review-theme") || "system";
+      const systemLight = matchMedia("(prefers-color-scheme: light)").matches;
+      document.documentElement.dataset.themeMode = mode;
+      document.documentElement.dataset.theme = mode === "system" ? (systemLight ? "light" : "dark") : mode;
+    })();
+  </script>
+  <link rel="stylesheet" href="/static/app.css" />
+</head>
+<body>
+  <div id="app">
+    <aside id="sidebar">
+      <div class="brand">
+        <div>
+          <h1>Diff Review</h1>
+          <div class="subtitle">Pi × Pierre</div>
+        </div>
+        <label class="theme-label" aria-label="Theme mode">
+          <span class="theme-icon" aria-hidden="true">◐</span>
+          <select id="theme-mode" aria-label="Theme mode">
+            <option value="system" selected>system</option>
+            <option value="dark">dark</option>
+            <option value="light">light</option>
+          </select>
+        </label>
+      </div>
+      <div id="meta"></div>
+      <div id="tree"></div>
+    </aside>
+
+    <div id="left-splitter" class="splitter" role="separator" aria-label="Resize file tree" aria-orientation="vertical">
+      <button id="toggle-left" class="pane-toggle" type="button" aria-label="Collapse file tree">‹</button>
+    </div>
+
+    <main id="main">
+      <header id="topbar">
+        <div>
+          <div class="topbar-title">Review changed lines</div>
+          <div id="summary">Select a changed line to add a finding.</div>
+        </div>
+        <div class="topbar-actions">
+          <div id="search-wrap" class="search-wrap">
+            <input id="search" type="text" role="searchbox" placeholder="Search code…" autocomplete="off" spellcheck="false" aria-label="Search code in diff" />
+            <button id="search-clear" class="search-clear" type="button" aria-label="Clear code search">×</button>
+            <span id="search-badge" class="search-badge" hidden></span>
+            <div id="search-results" class="search-results" hidden></div>
+          </div>
+          <div id="finding-count" class="count-pill">0 findings</div>
+        </div>
+      </header>
+      <div id="diffs"></div>
+      <section id="inline-finding" class="inline-finding" aria-label="New finding" hidden>
+        <div class="inline-head">
+          <div>
+            <div class="inline-title">New finding</div>
+            <div id="selection" class="selection-empty">Click an added or deleted line.</div>
+          </div>
+          <button id="inline-cancel" class="inline-close" type="button" aria-label="Close finding input">×</button>
+        </div>
+        <div class="field-row">
+          <label>Severity
+            <select id="severity">
+              <option value="high">🔥 high</option>
+              <option value="medium" selected>😒 medium</option>
+              <option value="low">🦟 low</option>
+            </select>
+            <div class="field-subtitle" id="severity-sub">suspicious little gremlin</div>
+          </label>
+          <label>Category
+            <select id="category">
+              <option value="bug" selected>🐛 bug</option>
+              <option value="style">💅 style</option>
+              <option value="perf">🐌 perf</option>
+              <option value="question">🤨 question</option>
+            </select>
+            <div class="field-subtitle" id="category-sub">exquisite disaster</div>
+          </label>
+        </div>
+        <label>Finding
+          <textarea id="comment" rows="5" placeholder="Describe the issue or question for this line"></textarea>
+        </label>
+        <button id="add" disabled>Add finding</button>
+      </section>
+    </main>
+
+    <div id="right-splitter" class="splitter" role="separator" aria-label="Resize review panel" aria-orientation="vertical">
+      <button id="toggle-right" class="pane-toggle" type="button" aria-label="Collapse review panel">›</button>
+    </div>
+
+    <aside id="drawer">
+      <section class="card findings-card">
+        <div class="card-title findings-title"><span>Collected findings</span><span id="drawer-count">0</span></div>
+        <div id="findings" class="empty-list">No findings yet.</div>
+      </section>
+
+      <section class="card">
+        <div class="card-title">Review notes</div>
+        <textarea id="notes" rows="4" placeholder="Optional context for the whole review"></textarea>
+      </section>
+
+      <footer class="actions">
+        <button id="cancel">Cancel</button>
+        <button id="submit">Send to Pi</button>
+      </footer>
+    </aside>
+
+    <div id="status" role="status" aria-live="polite">Ready</div>
+  </div>
+  <script type="module" src="/static/app.js"></script>
+</body>
+</html>