@bufbuild/protoplugin 1.9.0 → 2.0.0-alpha.1

package/dist/esm/ecmascript/generated-file.js

@@ -11,11 +11,12 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-import { LongType, protoInt64, ScalarType } from "@bufbuild/protobuf";
+import { protoInt64 } from "@bufbuild/protobuf";
+import { LongType, ScalarType } from "@bufbuild/protobuf/reflect";
 import { createImportSymbol } from "./import-symbol.js";
 import { makeImportPathRelative } from "./import-path.js";
-import { createJsDocBlock } from "./jsdoc.js";
-export function createGeneratedFile(name, importPath, jsImportStyle, rewriteImportPath, createTypeImport, runtimeImports, createPreamble) {
+import { createJsDocTextFromDesc, formatJsDocBlock } from "./jsdoc.js";
+export function createGeneratedFile(name, importPath, jsImportStyle, rewriteImport, resolveDescImport, resolveShapeImport, createPreamble, runtime) {
     let preamble;
     const el = [];
     return {
@@ -36,38 +37,51 @@ export function createGeneratedFile(name, importPath, jsImportStyle, rewriteImpo
                         ? [printableOrFragments, ...rest]
                         : rest;
             }
-            printableToEl(printables, el, createTypeImport, runtimeImports);
+            printableToEl({
+                el,
+                runtime,
+                resolveDescImport,
+                resolveShapeImport,
+            }, printables);
             el.push("\n");
         },
-        export(name) {
-            return createImportSymbol(name, importPath);
-        },
         exportDecl(declaration, name) {
             return {
-                kind: "es_export_decl",
-                declaration,
+                kind: "es_export_stmt",
                 name,
+                declaration,
             };
         },
         string(string) {
-            // We do not use LiteralString, which was added later, to maintain backwards compatibility
-            return escapeString(string);
+            return {
+                kind: "es_string",
+                value: string,
+            };
         },
         jsDoc(textOrDesc, indentation) {
-            return createJsDocBlock(textOrDesc, indentation);
+            return {
+                kind: "es_jsdoc",
+                text: typeof textOrDesc == "string"
+                    ? textOrDesc
+                    : createJsDocTextFromDesc(textOrDesc),
+                indentation,
+            };
         },
-        import(typeOrName, from) {
-            if (typeof typeOrName == "string") {
-                // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
-                return createImportSymbol(typeOrName, from);
-            }
-            return createTypeImport(typeOrName);
+        importDesc(desc, typeOnly = false) {
+            return resolveDescImport(desc, typeOnly);
+        },
+        importShape(desc) {
+            return resolveShapeImport(desc);
+        },
+        import(name, from) {
+            return createImportSymbol(name, from);
         },
         jsImportStyle,
+        runtime,
         getFileInfo() {
             return {
                 name,
-                content: elToContent(el, importPath, rewriteImportPath, jsImportStyle == "legacy_commonjs"),
+                content: elToContent(el, importPath, rewriteImport, jsImportStyle == "legacy_commonjs"),
                 preamble,
             };
         },
@@ -142,10 +156,11 @@ function elToContent(el, importerPath, rewriteImportPath, legacyCommonJs) {
     }
     return c.join("");
 }
-function printableToEl(printables, el, createTypeImport, runtimeImports) {
+function printableToEl(opt, printables) {
+    const { el } = opt;
     for (const p of printables) {
         if (Array.isArray(p)) {
-            printableToEl(p, el, createTypeImport, runtimeImports);
+            printableToEl(opt, p);
         }
         else {
             switch (typeof p) {
@@ -153,52 +168,88 @@ function printableToEl(printables, el, createTypeImport, runtimeImports) {
                     el.push(p);
                     break;
                 case "number":
-                    elNumber(el, p, runtimeImports);
+                    if (Number.isNaN(p)) {
+                        el.push("globalThis.NaN");
+                    }
+                    else if (p === Number.POSITIVE_INFINITY) {
+                        el.push("globalThis.Infinity");
+                    }
+                    else if (p === Number.NEGATIVE_INFINITY) {
+                        el.push("-globalThis.Infinity");
+                    }
+                    else {
+                        el.push(p.toString(10));
+                    }
                     break;
                 case "boolean":
                     el.push(p.toString());
                     break;
                 case "bigint":
-                    elBigint(el, p, runtimeImports);
+                    if (p == protoInt64.zero) {
+                        // Loose comparison will match between 0n and 0.
+                        el.push(opt.runtime.protoInt64, ".zero");
+                    }
+                    else {
+                        el.push(opt.runtime.protoInt64, p > 0 ? ".uParse(" : ".parse(", escapeString(p.toString()), ")");
+                    }
                     break;
                 case "object":
                     if (p instanceof Uint8Array) {
-                        elUint8Array(el, p);
+                        if (p.length === 0) {
+                            el.push("new Uint8Array(0)");
+                        }
+                        else {
+                            el.push("new Uint8Array([");
+                            const strings = [];
+                            for (const n of p) {
+                                strings.push("0x" + n.toString(16).toUpperCase().padStart(2, "0"));
+                            }
+                            el.push(strings.join(", "));
+                            el.push("])");
+                        }
                         break;
                     }
                     switch (p.kind) {
                         case "es_symbol":
+                        case "es_export_stmt":
                             el.push(p);
                             break;
+                        case "es_desc_ref":
+                            el.push(opt.resolveDescImport(p.desc, p.typeOnly));
+                            break;
+                        case "es_shape_ref":
+                            el.push(opt.resolveShapeImport(p.desc));
+                            break;
                         case "es_jsdoc":
-                            el.push(p.toString());
+                            el.push(formatJsDocBlock(p.text, p.indentation));
                             break;
                         case "es_string":
                             el.push(escapeString(p.value));
                             break;
                         case "es_proto_int64":
-                            elProtoInt64(el, p, runtimeImports);
-                            break;
-                        case "es_export_decl":
-                            el.push({
-                                kind: "es_export_stmt",
-                                declaration: p.declaration,
-                                name: typeof p.name == "string"
-                                    ? p.name
-                                    : createTypeImport(p.name).name,
-                            });
-                            break;
-                        case "es_ref_message":
-                        case "es_ref_enum":
-                            el.push(p.typeOnly
-                                ? createTypeImport(p.type).toTypeOnly()
-                                : createTypeImport(p.type));
-                            break;
-                        case "message":
-                        case "extension":
-                        case "enum":
-                            el.push(createTypeImport(p));
+                            switch (p.longType) {
+                                case LongType.STRING:
+                                    el.push(escapeString(p.value.toString()));
+                                    break;
+                                case LongType.BIGINT:
+                                    if (p.value == protoInt64.zero) {
+                                        // Loose comparison will match between 0n and 0.
+                                        el.push(opt.runtime.protoInt64, ".zero");
+                                        break;
+                                    }
+                                    switch (p.type) {
+                                        case ScalarType.UINT64:
+                                        case ScalarType.FIXED64:
+                                            el.push(opt.runtime.protoInt64, ".uParse(", escapeString(p.value.toString()), ")");
+                                            break;
+                                        default:
+                                            el.push(opt.runtime.protoInt64, ".parse(", escapeString(p.value.toString()), ")");
+                                            break;
+                                    }
+                            }
                             break;
+                        default:
+                            throw `cannot print ${typeof p}`;
                     }
                     break;
                 default:
@@ -323,70 +374,6 @@ function processImports(el, importerPath, rewriteImportPath, makeImportStatement
     }
     return symbolToIdentifier;
 }
-function elBigint(el, value, runtimeImports) {
-    if (value == protoInt64.zero) {
-        // Loose comparison will match between 0n and 0.
-        el.push(runtimeImports.protoInt64, ".zero");
-    }
-    else {
-        el.push(runtimeImports.protoInt64, value > 0 ? ".uParse(" : ".parse(", escapeString(value.toString()), ")");
-    }
-}
-function elNumber(el, value, runtimeImports) {
-    if (Number.isNaN(value)) {
-        el.push(runtimeImports.protoDouble, ".NaN");
-    }
-    else if (value === Number.POSITIVE_INFINITY) {
-        el.push(runtimeImports.protoDouble, ".POSITIVE_INFINITY");
-    }
-    else if (value === Number.NEGATIVE_INFINITY) {
-        el.push(runtimeImports.protoDouble, ".NEGATIVE_INFINITY");
-    }
-    else {
-        el.push(value.toString(10));
-    }
-}
-function elUint8Array(el, value) {
-    if (value.length === 0) {
-        el.push("new Uint8Array(0)");
-        return;
-    }
-    el.push("new Uint8Array([");
-    const strings = [];
-    for (const n of value) {
-        strings.push("0x" + n.toString(16).toUpperCase().padStart(2, "0"));
-    }
-    el.push(strings.join(", "));
-    el.push("])");
-}
-function elProtoInt64(el, literal, runtimeImports) {
-    switch (literal.longType) {
-        case LongType.STRING:
-            el.push(escapeString(literal.value.toString()));
-            break;
-        case LongType.BIGINT:
-            if (literal.value == protoInt64.zero) {
-                // Loose comparison will match between 0n and 0.
-                el.push(runtimeImports.protoInt64, ".zero");
-                break;
-            }
-            switch (literal.type) {
-                case ScalarType.UINT64:
-                case ScalarType.FIXED64:
-                    el.push(runtimeImports.protoInt64);
-                    el.push(".uParse(");
-                    el.push(escapeString(literal.value.toString()));
-                    el.push(")");
-                    break;
-                default:
-                    el.push(runtimeImports.protoInt64);
-                    el.push(".parse(");
-                    el.push(escapeString(literal.value.toString()));
-                    el.push(")");
-                    break;
-            }
-    }
-}
 function escapeString(value) {
     return ('"' +
         value

package/dist/esm/ecmascript/import-path.d.ts

@@ -1,4 +1,3 @@
-import type { DescFile } from "@bufbuild/protobuf";
 /**
  * A configuration for rewriting import paths, a feature mainly used for
  * remote code generation in the BSR npm registry, which makes it possible
@@ -44,11 +43,6 @@ export type RewriteImports = {
  * to the given import extension.
  */
 export declare function rewriteImportPath(importPath: string, rewriteImports: RewriteImports, importExtension: string): string;
-/**
- * Returns the import path for files generated by the base type generator
- * protoc-gen-es.
- */
-export declare function makeImportPath(file: DescFile, bootstrapWkt: boolean, filesToGenerate: DescFile[]): string;
 export declare const relativePathRE: RegExp;
 /**
  * Derives an ECMAScript module import path from a file path. For example,

package/dist/esm/ecmascript/import-path.js

@@ -11,7 +11,6 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-import { codegenInfo } from "@bufbuild/protobuf";
 const cache = new WeakMap();
 /**
  * Apply import rewrites to the given import path, and change all .js extensions
@@ -81,25 +80,6 @@ function starToRegExp(star) {
     r.push("$");
     return new RegExp(r.join(""));
 }
-/**
- * Returns the import path for files generated by the base type generator
- * protoc-gen-es.
- */
-export function makeImportPath(file, bootstrapWkt, filesToGenerate) {
-    // Well-known types are published with the runtime package. We usually want
-    // the generated code to import them from the runtime package, with the
-    // following exceptions:
-    // 1. We are bootstrapping the runtime package via the plugin option
-    //    "bootstrap_wkt". In that case, we cannot refer to the runtime package
-    //    itself.
-    // 2. We were explicitly asked to generate the well-known type.
-    if (!bootstrapWkt &&
-        !filesToGenerate.includes(file) &&
-        codegenInfo.wktSourceFiles.includes(file.name + ".proto")) {
-        return codegenInfo.packageName;
-    }
-    return "./" + file.name + "_pb.js";
-}
 export const relativePathRE = /^\.{1,2}\//;
 /**
  * Derives an ECMAScript module import path from a file path. For example,

package/dist/esm/ecmascript/import-symbol.d.ts

@@ -29,11 +29,9 @@ export type ImportSymbol = {
     /**
      * The unique ID based on name and from, disregarding typeOnly.
      */
-    readonly id: EsSymbolId;
+    readonly id: `import("${string}").${string}`;
 };
 /**
  * Create a new import symbol.
  */
 export declare function createImportSymbol(name: string, from: string, typeOnly?: boolean): ImportSymbol;
-type EsSymbolId = string;
-export {};

package/dist/esm/ecmascript/import-symbol.js

@@ -15,16 +15,14 @@
  * Create a new import symbol.
  */
 export function createImportSymbol(name, from, typeOnly) {
-    const id = `import("${from}").${name}`;
-    const s = {
+    return {
         kind: "es_symbol",
         name,
         from,
-        typeOnly: false,
-        id,
+        typeOnly: typeOnly !== null && typeOnly !== void 0 ? typeOnly : false,
+        id: `import("${from}").${name}`,
         toTypeOnly() {
             return Object.assign(Object.assign({}, this), { typeOnly: true });
         },
     };
-    return typeOnly === true ? s.toTypeOnly() : s;
 }

package/dist/esm/ecmascript/index.d.ts

@@ -1,20 +1,7 @@
-import type { AnyDesc, DescExtension, DescFile } from "@bufbuild/protobuf";
-import type { Printable } from "./generated-file.js";
-export { reifyWkt } from "./reify-wkt.js";
 export type { Target } from "./target.js";
 export type { Schema } from "./schema.js";
-export type { RuntimeImports } from "./runtime-imports.js";
-export type { GeneratedFile, FileInfo, Printable } from "./generated-file.js";
+export type { GeneratedFile, FileInfo } from "./generated-file.js";
 export type { ImportSymbol } from "./import-symbol.js";
 export { createImportSymbol } from "./import-symbol.js";
-export declare const localName: (desc: import("@bufbuild/protobuf").DescEnum | import("@bufbuild/protobuf").DescMessage | import("@bufbuild/protobuf").DescService | DescExtension | import("@bufbuild/protobuf").DescEnumValue | import("@bufbuild/protobuf").DescField | import("@bufbuild/protobuf").DescOneof | import("@bufbuild/protobuf").DescMethod) => string;
-export { getFieldExplicitDefaultValue, getFieldIntrinsicDefaultValue, getFieldTyping, literalString, } from "./legacy-gencommon.js";
-export { findCustomScalarOption, findCustomMessageOption, findCustomEnumOption, } from "./legacy-custom-options.js";
-/**
- * @deprecated Please use GeneratedFile.jsDoc() instead
- */
-export declare function makeJsDoc(desc: Exclude<AnyDesc, DescFile | DescExtension>, indentation?: string): Printable;
-/**
- * @deprecated Please use GeneratedFile.jsDoc() instead
- */
-export declare function createJsDocBlock(text: string, indentation?: string): Printable;
+export type { Printable } from "./printable.js";
+export { safeIdentifier } from "./safe-identifier.js";

package/dist/esm/ecmascript/index.js

@@ -11,22 +11,5 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-import { codegenInfo } from "@bufbuild/protobuf";
-import { createJsDocBlock as createJsDocBlockInternal } from "./jsdoc.js";
-export { reifyWkt } from "./reify-wkt.js";
 export { createImportSymbol } from "./import-symbol.js";
-export const { localName } = codegenInfo;
-export { getFieldExplicitDefaultValue, getFieldIntrinsicDefaultValue, getFieldTyping, literalString, } from "./legacy-gencommon.js";
-export { findCustomScalarOption, findCustomMessageOption, findCustomEnumOption, } from "./legacy-custom-options.js";
-/**
- * @deprecated Please use GeneratedFile.jsDoc() instead
- */
-export function makeJsDoc(desc, indentation = "") {
-    return createJsDocBlockInternal(desc, indentation).toString();
-}
-/**
- * @deprecated Please use GeneratedFile.jsDoc() instead
- */
-export function createJsDocBlock(text, indentation = "") {
-    return createJsDocBlockInternal(text, indentation).toString();
-}
+export { safeIdentifier } from "./safe-identifier.js";

package/dist/esm/ecmascript/jsdoc.d.ts

@@ -1,14 +1,3 @@
 import type { AnyDesc, DescFile } from "@bufbuild/protobuf";
-export type JSDocBlock = {
-    readonly kind: "es_jsdoc";
-    /**
-     * @deprecated In a future release, we will make this property optional.
-     */
-    text: string;
-    indentation?: string;
-    /**
-     * @deprecated In a future release, we will remove this method.
-     */
-    toString(): string;
-};
-export declare function createJsDocBlock(textOrDesc: string | Exclude<AnyDesc, DescFile>, indentation?: string): JSDocBlock;
+export declare function createJsDocTextFromDesc(desc: Exclude<AnyDesc, DescFile>): string;
+export declare function formatJsDocBlock(text: string, indentation: string | undefined): string;

package/dist/esm/ecmascript/jsdoc.js

@@ -11,31 +11,9 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
-// TODO simplify type JSDocBlock to bring it in line with others in opaque-printables.ts
-export function createJsDocBlock(textOrDesc, indentation) {
-    const text = typeof textOrDesc == "string" ? textOrDesc : createTextForDesc(textOrDesc);
-    return {
-        kind: "es_jsdoc",
-        text,
-        indentation,
-        toString() {
-            if (text.trim().length == 0) {
-                return "";
-            }
-            let lines = text.split("\n");
-            if (lines.length === 0) {
-                return "";
-            }
-            lines = lines.map((l) => l.split("*/").join("*\\/"));
-            lines = lines.map((l) => (l.length > 0 ? " " + l : l));
-            const i = indentation !== null && indentation !== void 0 ? indentation : "";
-            return [`${i}/**\n`, ...lines.map((l) => `${i} *${l}\n`), `${i} */`].join("");
-        },
-    };
-}
-function createTextForDesc(desc) {
-    var _a, _b;
-    const comments = desc.getComments();
+import { getComments, getDeclarationString } from "../source-code-info.js";
+export function createJsDocTextFromDesc(desc) {
+    const comments = getComments(desc);
     let text = "";
     if (comments.leading !== undefined) {
         text += comments.leading;
@@ -61,13 +39,13 @@ function createTextForDesc(desc) {
         .join("\n");
     switch (desc.kind) {
         case "enum_value":
-            text += `@generated from enum value: ${desc.declarationString()};`;
+            text += `@generated from enum value: ${getDeclarationString(desc)};`;
             break;
         case "field":
-            text += `@generated from field: ${desc.declarationString()};`;
+            text += `@generated from field: ${getDeclarationString(desc)};`;
             break;
         case "extension":
-            text += `@generated from extension: ${desc.declarationString()};`;
+            text += `@generated from extension: ${getDeclarationString(desc)};`;
             break;
         default:
             text += `@generated from ${desc.toString()}`;
@@ -78,7 +56,7 @@ function createTextForDesc(desc) {
         case "enum":
         case "message":
         case "service":
-            deprecated = deprecated || ((_b = (_a = desc.file.proto.options) === null || _a === void 0 ? void 0 : _a.deprecated) !== null && _b !== void 0 ? _b : false);
+            deprecated = deprecated || desc.file.deprecated;
             break;
         default:
             break;
@@ -88,3 +66,16 @@ function createTextForDesc(desc) {
     }
     return text;
 }
+export function formatJsDocBlock(text, indentation) {
+    if (text.trim().length == 0) {
+        return "";
+    }
+    let lines = text.split("\n");
+    if (lines.length === 0) {
+        return "";
+    }
+    lines = lines.map((l) => l.split("*/").join("*\\/"));
+    lines = lines.map((l) => (l.length > 0 ? " " + l : l));
+    const i = indentation !== null && indentation !== void 0 ? indentation : "";
+    return [`${i}/**\n`, ...lines.map((l) => `${i} *${l}\n`), `${i} */`].join("");
+}

package/dist/esm/ecmascript/names.d.ts

@@ -0,0 +1,4 @@
+import type { DescEnum, DescExtension, DescFile, DescMessage, DescService } from "@bufbuild/protobuf";
+export declare function generateFilePath(file: DescFile, bootstrapWkt: boolean, filesToGenerate: DescFile[]): string;
+export declare function localDescName(desc: DescFile | DescEnum | DescMessage | DescExtension | DescService): string;
+export declare function localShapeName(desc: DescEnum | DescMessage): string;

package/dist/esm/ecmascript/names.js

@@ -0,0 +1,113 @@
+// Copyright 2021-2024 Buf Technologies, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+import { wktPublicImportPaths } from "@bufbuild/protobuf/codegenv1";
+import { nestedTypes } from "@bufbuild/protobuf/reflect";
+import { safeIdentifier } from "./safe-identifier.js";
+export function generateFilePath(file, bootstrapWkt, filesToGenerate) {
+    // Well-known types are published with the runtime package. We usually want
+    // the generated code to import them from the runtime package, with the
+    // following exceptions:
+    // 1. We are bootstrapping the runtime package via the plugin option
+    //    "bootstrap_wkt". In that case, we cannot refer to the runtime package
+    //    itself.
+    // 2. We were explicitly asked to generate the well-known type.
+    const wktFrom = wktPublicImportPaths[file.proto.name];
+    if (wktFrom !== undefined &&
+        !bootstrapWkt &&
+        !filesToGenerate.find((f) => f.name === file.name)) {
+        return wktFrom;
+    }
+    return "./" + file.name + "_pb.js";
+}
+export function localDescName(desc) {
+    const file = desc.kind == "file" ? desc : desc.file;
+    const { descNames } = allNames(file);
+    const name = descNames.get(desc);
+    if (name === undefined) {
+        throw new Error(`unable to determine unique identifier for ${desc.toString()}`);
+    }
+    return name;
+}
+export function localShapeName(desc) {
+    const { shapeNames } = allNames(desc.file);
+    const name = shapeNames.get(desc);
+    if (name === undefined) {
+        throw new Error(`unable to determine unique identifier for ${desc.toString()}`);
+    }
+    return name;
+}
+function idealDescName(desc, i) {
+    const escape = i === 0 ? "" : i === 1 ? "$" : `$${i - 1}`;
+    switch (desc.kind) {
+        case "file":
+            return (safeIdentifier("fileDesc_" + desc.name.replace(/[^a-zA-Z0-9_]+/g, "_")) + escape);
+        case "enum":
+            return baseName(desc) + "Desc" + escape;
+        case "message":
+            return baseName(desc) + "Desc" + escape;
+        case "extension":
+            return baseName(desc) + escape;
+        case "service":
+            return baseName(desc) + escape;
+    }
+}
+function idealShapeName(desc, i) {
+    const escape = i === 0 ? "" : i === 1 ? "$" : `$${i - 1}`;
+    return baseName(desc) + escape;
+}
+function baseName(desc) {
+    const pkg = desc.file.proto.package;
+    const offset = pkg.length > 0 ? pkg.length + 1 : 0;
+    const name = desc.typeName.substring(offset).replace(/\./g, "_");
+    return safeIdentifier(name);
+}
+function allNames(file) {
+    const taken = new Set();
+    const shapeNames = new Map();
+    const descNames = new Map();
+    for (const desc of [file, ...nestedTypes(file)]) {
+        switch (desc.kind) {
+            case "enum":
+            case "message": {
+                let descName;
+                let shapeName;
+                for (let i = 0;; i++) {
+                    descName = idealDescName(desc, i);
+                    shapeName = idealShapeName(desc, i);
+                    if (!taken.has(descName) && !taken.has(shapeName)) {
+                        break;
+                    }
+                }
+                taken.add(descName);
+                taken.add(shapeName);
+                descNames.set(desc, descName);
+                shapeNames.set(desc, shapeName);
+                break;
+            }
+            default: {
+                let descName;
+                for (let i = 0;; i++) {
+                    descName = idealDescName(desc, i);
+                    if (!taken.has(descName)) {
+                        break;
+                    }
+                }
+                taken.add(descName);
+                descNames.set(desc, descName);
+                break;
+            }
+        }
+    }
+    return { shapeNames, descNames };
+}

package/dist/esm/ecmascript/parameter.d.ts

@@ -10,4 +10,4 @@ export interface ParsedParameter {
     jsImportStyle: "module" | "legacy_commonjs";
     sanitizedParameter: string;
 }
-export declare function parseParameter(parameter: string | undefined, parseExtraOption: ((key: string, value: string) => void) | undefined): ParsedParameter;
+export declare function parseParameter(parameter: string, parseExtraOption: ((key: string, value: string) => void) | undefined): ParsedParameter;

package/dist/esm/ecmascript/parameter.js

@@ -14,7 +14,7 @@
 import { PluginOptionError } from "../error.js";
 export function parseParameter(parameter, parseExtraOption) {
     let targets = ["js", "dts"];
-    let tsNocheck = true;
+    let tsNocheck = false;
     let bootstrapWkt = false;
     let keepEmptyFiles = false;
     const rewriteImports = [];
@@ -143,7 +143,7 @@ export function parseParameter(parameter, parseExtraOption) {
     };
 }
 function splitParameter(parameter) {
-    if (parameter == undefined) {
+    if (parameter.length == 0) {
         return [];
     }
     return parameter.split(",").map((raw) => {