@budibase/worker 3.21.0 → 3.21.1

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@budibase/worker",
   "email": "hi@budibase.com",
-  "version": "3.21.0",
+  "version": "3.21.1",
   "description": "Budibase background service",
   "main": "src/index.ts",
   "repository": {
@@ -110,5 +110,5 @@
       }
     }
   },
-  "gitHead": "89497e01938534167c4ffbe74cdd4090e3e7c3a5"
+  "gitHead": "f418556d9428cc85c6d0ca8176d92904d57d3266"
 }

package/src/api/routes/global/tests/scim.spec.ts

@@ -1210,6 +1210,61 @@ describe("scim", () => {
           const persistedGroup = await config.api.scimGroupsAPI.find(group.id)
           expect(persistedGroup).toEqual(expectedScimGroup)
         })
+
+        it("succeeds when removing a member that no longer exists", async () => {
+          const userToRemove = users[6]
+
+          // ensure the user is a member first
+          await patchScimGroup({
+            id: group.id,
+            body: {
+              schemas: ["urn:ietf:params:scim:api:messages:2.0:PatchOp"],
+              Operations: [
+                {
+                  op: "Add",
+                  path: "members",
+                  value: [
+                    {
+                      $ref: null,
+                      value: userToRemove.id,
+                    },
+                  ],
+                },
+              ],
+            },
+          })
+
+          // deleting the user simulates Azure holding on to a stale reference
+          await config.api.users.deleteUser(userToRemove.id)
+
+          const groupBeforeRemoval = await config.api.scimGroupsAPI.find(
+            group.id
+          )
+
+          const response = await patchScimGroup({
+            id: group.id,
+            body: {
+              schemas: ["urn:ietf:params:scim:api:messages:2.0:PatchOp"],
+              Operations: [
+                {
+                  op: "Remove",
+                  path: "members",
+                  value: [
+                    {
+                      $ref: null,
+                      value: userToRemove.id,
+                    },
+                  ],
+                },
+              ],
+            },
+          })
+
+          expect(response).toEqual(groupBeforeRemoval)
+
+          const persistedGroup = await config.api.scimGroupsAPI.find(group.id)
+          expect(persistedGroup).toEqual(groupBeforeRemoval)
+        })
       })
     })
   })