@budibase/worker 3.13.18 → 3.13.20

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@budibase/worker",
   "email": "hi@budibase.com",
-  "version": "3.13.18",
+  "version": "3.13.20",
   "description": "Budibase background service",
   "main": "src/index.ts",
   "repository": {
@@ -114,5 +114,5 @@
       }
     }
   },
-  "gitHead": "6d3c3c8002c3ba2682b5bfb2299b4457195fda82"
+  "gitHead": "6d7096e4d28a12b872d1aa83cee09a3ac431a9ae"
 }

package/src/api/routes/global/tests/groups.spec.ts

@@ -349,4 +349,101 @@ describe("/api/global/groups", () => {
       })
     })
   })
+
+  describe("bulk add users via CSV", () => {
+    let groupId: string
+    let existingUsers: { _id: string; email: string }[] = []
+
+    beforeAll(async () => {
+      groupId = (
+        await config.api.groups.saveGroup(structures.groups.UserGroup())
+      ).body._id
+
+      await Promise.all(
+        Array.from({ length: 5 }).map(async (_, i) => {
+          const email = `bulkuser${i}+${generator.guid()}@example.com`
+          const user = await config.api.users.saveUser({
+            ...structures.users.user(),
+            email,
+          })
+          existingUsers.push({ _id: user.body._id, email })
+        })
+      )
+    })
+
+    it("should add existing users to group via CSV with email column", async () => {
+      const csvContent = [
+        "email",
+        existingUsers[0].email,
+        existingUsers[1].email,
+      ].join("\n")
+
+      const result = await config.api.groups.bulkAddUsers(groupId, csvContent)
+
+      expect(result.body).toEqual({
+        added: expect.arrayContaining([
+          expect.objectContaining({ email: existingUsers[0].email }),
+          expect.objectContaining({ email: existingUsers[1].email }),
+        ]),
+        skipped: [],
+      })
+    })
+
+    it("should skip non-existent users", async () => {
+      const csvContent = [
+        "email",
+        existingUsers[2].email,
+        "nonexistent@example.com",
+      ].join("\n")
+
+      const result = await config.api.groups.bulkAddUsers(groupId, csvContent)
+
+      expect(result.body.added).toHaveLength(1)
+      expect(result.body.added[0].email).toBe(existingUsers[2].email)
+      expect(result.body.skipped).toEqual([
+        { email: "nonexistent@example.com", reason: "User not found" },
+      ])
+    })
+
+    it("should handle CSV with different column names", async () => {
+      const csvContent = ["Email Address", existingUsers[3].email].join("\n")
+
+      const result = await config.api.groups.bulkAddUsers(groupId, csvContent)
+
+      expect(result.body.added).toHaveLength(1)
+      expect(result.body.added[0].email).toBe(existingUsers[3].email)
+    })
+
+    it("should handle CSV with multiple columns", async () => {
+      const csvContent = [
+        "name,email,department",
+        `User Name,${existingUsers[4].email},Engineering`,
+      ].join("\n")
+
+      const result = await config.api.groups.bulkAddUsers(groupId, csvContent)
+
+      expect(result.body.added).toHaveLength(1)
+      expect(result.body.added[0].email).toBe(existingUsers[4].email)
+    })
+
+    it("should return error for invalid CSV", async () => {
+      const csvContent = "invalid csv content without headers"
+
+      await config.api.groups.bulkAddUsers(groupId, csvContent, { expect: 400 })
+    })
+
+    it("should return error for CSV without email column", async () => {
+      const csvContent = ["name,department", "John Doe,Engineering"].join("\n")
+
+      await config.api.groups.bulkAddUsers(groupId, csvContent, { expect: 400 })
+    })
+
+    it("should return error for non-existent group", async () => {
+      const csvContent = ["email", existingUsers[0].email].join("\n")
+
+      await config.api.groups.bulkAddUsers("invalid_group_id", csvContent, {
+        expect: 404,
+      })
+    })
+  })
 })

package/src/tests/api/groups.ts

@@ -81,4 +81,17 @@ export class GroupsAPI extends TestAPI {
       .expect("Content-Type", /json/)
       .expect(expect)
   }
+
+  bulkAddUsers = (
+    id: string,
+    csvContent: string,
+    { expect } = { expect: 200 }
+  ) => {
+    return this.request
+      .post(`/api/global/groups/${id}/users/bulk`)
+      .send({ csvContent })
+      .set(this.config.defaultHeaders())
+      .expect("Content-Type", /json/)
+      .expect(expect)
+  }
 }