@budibase/server 2.4.42-alpha.4 → 2.4.42

package/dist/utilities/global.js

@@ -45,33 +45,26 @@ function updateAppRole(user, { appId } = {}) {
     return user;
 }
 exports.updateAppRole = updateAppRole;
-function checkGroupRoles(user, opts = {}) {
+function checkGroupRoles(user, { appId } = {}) {
     return __awaiter(this, void 0, void 0, function* () {
         if (user.roleId && user.roleId !== backend_core_1.roles.BUILTIN_ROLE_IDS.PUBLIC) {
             return user;
         }
-        if (opts.appId) {
-            user.roleId = yield pro_1.groups.getGroupRoleId(user, opts.appId, {
-                groups: opts.groups,
-            });
-        }
-        // final fallback, simply couldn't find a role - user must be public
-        if (!user.roleId) {
-            user.roleId = backend_core_1.roles.BUILTIN_ROLE_IDS.PUBLIC;
+        if (appId) {
+            user.roleId = yield pro_1.groups.getGroupRoleId(user, appId);
         }
         return user;
     });
 }
-function processUser(user, opts = {}) {
+function processUser(user, { appId } = {}) {
     var _a;
     return __awaiter(this, void 0, void 0, function* () {
         if (user) {
             delete user.password;
         }
-        const appId = opts.appId || backend_core_1.context.getAppId();
-        user = updateAppRole(user, { appId });
+        user = yield updateAppRole(user, { appId });
         if (!user.roleId && ((_a = user === null || user === void 0 ? void 0 : user.userGroups) === null || _a === void 0 ? void 0 : _a.length)) {
-            user = yield checkGroupRoles(user, { appId, groups: opts === null || opts === void 0 ? void 0 : opts.groups });
+            user = yield checkGroupRoles(user, { appId });
         }
         return user;
     });
@@ -105,7 +98,6 @@ function getGlobalUsers(users) {
     return __awaiter(this, void 0, void 0, function* () {
         const appId = backend_core_1.context.getAppId();
         const db = backend_core_1.tenancy.getGlobalDB();
-        const allGroups = yield pro_1.groups.fetch();
         let globalUsers;
         if (users) {
             const globalIds = users.map(user => (0, utils_1.getGlobalIDFromUserMetadataID)(user._id));
@@ -126,9 +118,7 @@ function getGlobalUsers(users) {
         if (!appId) {
             return globalUsers;
         }
-        // pass in the groups, meaning we don't actually need to retrieve them for
-        // each user individually
-        return Promise.all(globalUsers.map(user => processUser(user, { groups: allGroups })));
+        return globalUsers.map(user => updateAppRole(user));
     });
 }
 exports.getGlobalUsers = getGlobalUsers;

package/jest.config.ts

@@ -43,7 +43,6 @@ const config: Config.InitialOptions = {
     "../backend-core/src/**/*.{js,ts}",
     // The use of coverage with couchdb view functions breaks tests
     "!src/db/views/staticViews.*",
-    "!src/**/*.spec.{js,ts}",
   ],
   coverageReporters: ["lcov", "json", "clover"],
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@budibase/server",
   "email": "hi@budibase.com",
-  "version": "2.4.42-alpha.4",
+  "version": "2.4.42",
   "description": "Budibase Web Server",
   "main": "src/index.ts",
   "repository": {
@@ -14,8 +14,7 @@
     "build:dev": "yarn prebuild && tsc --build --watch --preserveWatchOutput",
     "debug": "yarn build && node --expose-gc --inspect=9222 dist/index.js",
     "postbuild": "copyfiles -u 1 src/**/*.svelte dist/ && copyfiles -u 1 src/**/*.hbs dist/ && copyfiles -u 1 src/**/*.json dist/",
-    "test": "NODE_OPTIONS=\"--max-old-space-size=4096\" bash scripts/test.sh",
-    "test:memory": "jest --maxWorkers=2 --logHeapUsage --forceExit",
+    "test": "bash scripts/test.sh",
     "test:watch": "jest --watch",
     "predocker": "copyfiles -f ../client/dist/budibase-client.js ../client/manifest.json client",
     "build:docker": "yarn run predocker && docker build . -t app-service --label version=$BUDIBASE_RELEASE_VERSION",
@@ -44,12 +43,12 @@
   "license": "GPL-3.0",
   "dependencies": {
     "@apidevtools/swagger-parser": "10.0.3",
-    "@budibase/backend-core": "2.4.42-alpha.4",
-    "@budibase/client": "2.4.42-alpha.4",
-    "@budibase/pro": "2.4.42-alpha.2",
-    "@budibase/shared-core": "2.4.42-alpha.4",
-    "@budibase/string-templates": "2.4.42-alpha.4",
-    "@budibase/types": "2.4.42-alpha.4",
+    "@budibase/backend-core": "^2.4.42",
+    "@budibase/client": "^2.4.42",
+    "@budibase/pro": "2.4.41",
+    "@budibase/shared-core": "^2.4.42",
+    "@budibase/string-templates": "^2.4.42",
+    "@budibase/types": "^2.4.42",
     "@bull-board/api": "3.7.0",
     "@bull-board/koa": "3.9.4",
     "@elastic/elasticsearch": "7.10.0",
@@ -126,7 +125,7 @@
     "@babel/core": "7.17.4",
     "@babel/preset-env": "7.16.11",
     "@budibase/standard-components": "^0.9.139",
-    "@jest/test-sequencer": "29.5.0",
+    "@jest/test-sequencer": "24.9.0",
     "@swc/core": "^1.3.25",
     "@swc/jest": "^0.2.24",
     "@trendyol/jest-testcontainers": "^2.1.1",
@@ -135,7 +134,7 @@
     "@types/global-agent": "2.1.1",
     "@types/google-spreadsheet": "3.1.5",
     "@types/ioredis": "4.28.10",
-    "@types/jest": "29.5.0",
+    "@types/jest": "27.5.1",
     "@types/koa": "2.13.4",
     "@types/koa__router": "8.0.8",
     "@types/lodash": "4.14.180",
@@ -155,7 +154,7 @@
     "eslint": "6.8.0",
     "ioredis-mock": "7.2.0",
     "is-wsl": "2.2.0",
-    "jest": "29.5.0",
+    "jest": "28.1.1",
     "jest-openapi": "0.14.2",
     "jest-serial-runner": "^1.2.1",
     "nodemon": "2.0.15",
@@ -167,7 +166,7 @@
     "supertest": "6.2.2",
     "swagger-jsdoc": "6.1.0",
     "timekeeper": "2.2.0",
-    "ts-jest": "29.0.5",
+    "ts-jest": "28.0.4",
     "ts-node": "10.8.1",
     "tsconfig-paths": "4.0.0",
     "typescript": "4.7.3",
@@ -176,5 +175,5 @@
   "optionalDependencies": {
     "oracledb": "5.3.0"
   },
-  "gitHead": "08cf82288300f22ebb730b1f1c68bc9a67691efc"
+  "gitHead": "6cff785e5ac488eafb8b9a4c3ccd7558f2f332cf"
 }

package/scripts/test.sh

@@ -3,10 +3,10 @@
 if [[ -n $CI ]]
 then
   # --runInBand performs better in ci where resources are limited
-  echo "jest --coverage --runInBand --forceExit"
-  jest --coverage --runInBand --forceExit
+  echo "jest --coverage --runInBand"
+  jest --coverage --runInBand
 else
   # --maxWorkers performs better in development
   echo "jest --coverage --maxWorkers=2"
   jest --coverage --maxWorkers=2
-fi
+fi

package/specs/openapi.json

@@ -115,15 +115,6 @@
           ]
         }
       },
-      "deploymentOutput": {
-        "value": {
-          "data": {
-            "_id": "ef12381f934b4f129675cdbb76eff3c2",
-            "status": "SUCCESS",
-            "appUrl": "/app-url"
-          }
-        }
-      },
       "inputRow": {
         "value": {
           "_id": "ro_ta_5b1649e42a5b41dea4ef7742a36a7a70_e6dc7e38cf1343b2b56760265201cda4",
@@ -422,9 +413,6 @@
             }
           ]
         }
-      },
-      "metrics": {
-        "value": "# HELP budibase_os_uptime Time in seconds that the host operating system has been up.\n# TYPE budibase_os_uptime counter\nbudibase_os_uptime 54958\n# HELP budibase_os_free_mem Bytes of memory free for usage on the host operating system.\n# TYPE budibase_os_free_mem gauge\nbudibase_os_free_mem 804507648\n# HELP budibase_os_total_mem Total bytes of memory on the host operating system.\n# TYPE budibase_os_total_mem gauge\nbudibase_os_total_mem 16742404096\n# HELP budibase_os_used_mem Total bytes of memory in use on the host operating system.\n# TYPE budibase_os_used_mem gauge\nbudibase_os_used_mem 15937896448\n# HELP budibase_os_load1 Host operating system load average.\n# TYPE budibase_os_load1 gauge\nbudibase_os_load1 1.91\n# HELP budibase_os_load5 Host operating system load average.\n# TYPE budibase_os_load5 gauge\nbudibase_os_load5 1.75\n# HELP budibase_os_load15 Host operating system load average.\n# TYPE budibase_os_load15 gauge\nbudibase_os_load15 1.56\n# HELP budibase_tenant_user_count The number of users created.\n# TYPE budibase_tenant_user_count gauge\nbudibase_tenant_user_count 1\n# HELP budibase_tenant_app_count The number of apps created by a user.\n# TYPE budibase_tenant_app_count gauge\nbudibase_tenant_app_count 2\n# HELP budibase_tenant_production_app_count The number of apps a user has published.\n# TYPE budibase_tenant_production_app_count gauge\nbudibase_tenant_production_app_count 1\n# HELP budibase_tenant_dev_app_count The number of apps a user has unpublished in development.\n# TYPE budibase_tenant_dev_app_count gauge\nbudibase_tenant_dev_app_count 1\n# HELP budibase_tenant_db_count The number of couchdb databases including global tables such as _users.\n# TYPE budibase_tenant_db_count gauge\nbudibase_tenant_db_count 3\n# HELP budibase_quota_usage_apps The number of apps created.\n# TYPE budibase_quota_usage_apps gauge\nbudibase_quota_usage_apps 1\n# HELP budibase_quota_limit_apps The limit on the number of apps that can be created.\n# TYPE budibase_quota_limit_apps gauge\nbudibase_quota_limit_apps 9007199254740991\n# HELP budibase_quota_usage_rows The number of database rows used from the quota.\n# TYPE budibase_quota_usage_rows gauge\nbudibase_quota_usage_rows 0\n# HELP budibase_quota_limit_rows The limit on the number of rows that can be created.\n# TYPE budibase_quota_limit_rows gauge\nbudibase_quota_limit_rows 9007199254740991\n# HELP budibase_quota_usage_plugins The number of plugins in use.\n# TYPE budibase_quota_usage_plugins gauge\nbudibase_quota_usage_plugins 0\n# HELP budibase_quota_limit_plugins The limit on the number of plugins that can be created.\n# TYPE budibase_quota_limit_plugins gauge\nbudibase_quota_limit_plugins 9007199254740991\n# HELP budibase_quota_usage_user_groups The number of user groups created.\n# TYPE budibase_quota_usage_user_groups gauge\nbudibase_quota_usage_user_groups 0\n# HELP budibase_quota_limit_user_groups The limit on the number of user groups that can be created.\n# TYPE budibase_quota_limit_user_groups gauge\nbudibase_quota_limit_user_groups 9007199254740991\n# HELP budibase_quota_usage_queries The number of queries used in the current month.\n# TYPE budibase_quota_usage_queries gauge\nbudibase_quota_usage_queries 0\n# HELP budibase_quota_limit_queries The limit on the number of queries for the current month.\n# TYPE budibase_quota_limit_queries gauge\nbudibase_quota_limit_queries 9007199254740991\n# HELP budibase_quota_usage_automations The number of automations used in the current month.\n# TYPE budibase_quota_usage_automations gauge\nbudibase_quota_usage_automations 0\n# HELP budibase_quota_limit_automations The limit on the number of automations that can be created.\n# TYPE budibase_quota_limit_automations gauge\nbudibase_quota_limit_automations 9007199254740991\n"
       }
     },
     "securitySchemes": {
@@ -2066,33 +2054,6 @@
         }
       }
     },
-    "/metrics": {
-      "get": {
-        "operationId": "metricsGet",
-        "summary": "Retrieve Budibase tenant metrics",
-        "description": "Output metrics in OpenMetrics format compatible with Prometheus",
-        "tags": [
-          "metrics"
-        ],
-        "responses": {
-          "200": {
-            "description": "Returns tenant metrics.",
-            "content": {
-              "text/plain": {
-                "schema": {
-                  "type": "string"
-                },
-                "examples": {
-                  "metrics": {
-                    "$ref": "#/components/examples/metrics"
-                  }
-                }
-              }
-            }
-          }
-        }
-      }
-    },
     "/queries/{queryId}": {
       "post": {
         "operationId": "queryExecute",

package/specs/openapi.yaml

@@ -85,12 +85,6 @@ components:
             updatedAt: 2022-02-22T13:00:54.035Z
             createdAt: 2022-02-11T18:02:26.961Z
             status: development
-    deploymentOutput:
-      value:
-        data:
-          _id: ef12381f934b4f129675cdbb76eff3c2
-          status: SUCCESS
-          appUrl: /app-url
     inputRow:
       value:
         _id: ro_ta_5b1649e42a5b41dea4ef7742a36a7a70_e6dc7e38cf1343b2b56760265201cda4
@@ -296,152 +290,6 @@ components:
               name: Admin
               permissionId: admin
               inherits: POWER
-    metrics:
-      value: >
-        # HELP budibase_os_uptime Time in seconds that the host operating system
-        has been up.
-
-        # TYPE budibase_os_uptime counter
-
-        budibase_os_uptime 54958
-
-        # HELP budibase_os_free_mem Bytes of memory free for usage on the host operating system.
-
-        # TYPE budibase_os_free_mem gauge
-
-        budibase_os_free_mem 804507648
-
-        # HELP budibase_os_total_mem Total bytes of memory on the host operating system.
-
-        # TYPE budibase_os_total_mem gauge
-
-        budibase_os_total_mem 16742404096
-
-        # HELP budibase_os_used_mem Total bytes of memory in use on the host operating system.
-
-        # TYPE budibase_os_used_mem gauge
-
-        budibase_os_used_mem 15937896448
-
-        # HELP budibase_os_load1 Host operating system load average.
-
-        # TYPE budibase_os_load1 gauge
-
-        budibase_os_load1 1.91
-
-        # HELP budibase_os_load5 Host operating system load average.
-
-        # TYPE budibase_os_load5 gauge
-
-        budibase_os_load5 1.75
-
-        # HELP budibase_os_load15 Host operating system load average.
-
-        # TYPE budibase_os_load15 gauge
-
-        budibase_os_load15 1.56
-
-        # HELP budibase_tenant_user_count The number of users created.
-
-        # TYPE budibase_tenant_user_count gauge
-
-        budibase_tenant_user_count 1
-
-        # HELP budibase_tenant_app_count The number of apps created by a user.
-
-        # TYPE budibase_tenant_app_count gauge
-
-        budibase_tenant_app_count 2
-
-        # HELP budibase_tenant_production_app_count The number of apps a user has published.
-
-        # TYPE budibase_tenant_production_app_count gauge
-
-        budibase_tenant_production_app_count 1
-
-        # HELP budibase_tenant_dev_app_count The number of apps a user has unpublished in development.
-
-        # TYPE budibase_tenant_dev_app_count gauge
-
-        budibase_tenant_dev_app_count 1
-
-        # HELP budibase_tenant_db_count The number of couchdb databases including global tables such as _users.
-
-        # TYPE budibase_tenant_db_count gauge
-
-        budibase_tenant_db_count 3
-
-        # HELP budibase_quota_usage_apps The number of apps created.
-
-        # TYPE budibase_quota_usage_apps gauge
-
-        budibase_quota_usage_apps 1
-
-        # HELP budibase_quota_limit_apps The limit on the number of apps that can be created.
-
-        # TYPE budibase_quota_limit_apps gauge
-
-        budibase_quota_limit_apps 9007199254740991
-
-        # HELP budibase_quota_usage_rows The number of database rows used from the quota.
-
-        # TYPE budibase_quota_usage_rows gauge
-
-        budibase_quota_usage_rows 0
-
-        # HELP budibase_quota_limit_rows The limit on the number of rows that can be created.
-
-        # TYPE budibase_quota_limit_rows gauge
-
-        budibase_quota_limit_rows 9007199254740991
-
-        # HELP budibase_quota_usage_plugins The number of plugins in use.
-
-        # TYPE budibase_quota_usage_plugins gauge
-
-        budibase_quota_usage_plugins 0
-
-        # HELP budibase_quota_limit_plugins The limit on the number of plugins that can be created.
-
-        # TYPE budibase_quota_limit_plugins gauge
-
-        budibase_quota_limit_plugins 9007199254740991
-
-        # HELP budibase_quota_usage_user_groups The number of user groups created.
-
-        # TYPE budibase_quota_usage_user_groups gauge
-
-        budibase_quota_usage_user_groups 0
-
-        # HELP budibase_quota_limit_user_groups The limit on the number of user groups that can be created.
-
-        # TYPE budibase_quota_limit_user_groups gauge
-
-        budibase_quota_limit_user_groups 9007199254740991
-
-        # HELP budibase_quota_usage_queries The number of queries used in the current month.
-
-        # TYPE budibase_quota_usage_queries gauge
-
-        budibase_quota_usage_queries 0
-
-        # HELP budibase_quota_limit_queries The limit on the number of queries for the current month.
-
-        # TYPE budibase_quota_limit_queries gauge
-
-        budibase_quota_limit_queries 9007199254740991
-
-        # HELP budibase_quota_usage_automations The number of automations used in the current month.
-
-        # TYPE budibase_quota_usage_automations gauge
-
-        budibase_quota_usage_automations 0
-
-        # HELP budibase_quota_limit_automations The limit on the number of automations that can be created.
-
-        # TYPE budibase_quota_limit_automations gauge
-
-        budibase_quota_limit_automations 9007199254740991
   securitySchemes:
     ApiKeyAuth:
       type: apiKey
@@ -1683,23 +1531,6 @@ paths:
               examples:
                 applications:
                   $ref: "#/components/examples/applications"
-  /metrics:
-    get:
-      operationId: metricsGet
-      summary: Retrieve Budibase tenant metrics
-      description: Output metrics in OpenMetrics format compatible with Prometheus
-      tags:
-        - metrics
-      responses:
-        "200":
-          description: Returns tenant metrics.
-          content:
-            text/plain:
-              schema:
-                type: string
-              examples:
-                metrics:
-                  $ref: "#/components/examples/metrics"
   "/queries/{queryId}":
     post:
       operationId: queryExecute

package/specs/resources/application.ts

@@ -15,12 +15,6 @@ const application = {
   lockedBy: userResource.getExamples().user.value.user,
 }
 
-const deployment = {
-  _id: "ef12381f934b4f129675cdbb76eff3c2",
-  status: "SUCCESS",
-  appUrl: "/app-url",
-}
-
 const base = {
   name: {
     description: "The name of the app.",
@@ -114,11 +108,6 @@ export default new Resource()
         data: [application],
       },
     },
-    deploymentOutput: {
-      value: {
-        data: deployment,
-      },
-    },
   })
   .setSchemas({
     application: applicationSchema,

package/specs/resources/index.ts

@@ -3,7 +3,6 @@ import row from "./row"
 import table from "./table"
 import query from "./query"
 import user from "./user"
-import metrics from "./metrics"
 import misc from "./misc"
 
 export const examples = {
@@ -13,7 +12,6 @@ export const examples = {
   ...query.getExamples(),
   ...user.getExamples(),
   ...misc.getExamples(),
-  ...metrics.getExamples(),
 }
 
 export const schemas = {

package/src/api/controllers/application.ts

@@ -20,10 +20,10 @@ import {
   cache,
   tenancy,
   context,
+  errors,
   events,
   migrations,
   objectStore,
-  ErrorCode,
 } from "@budibase/backend-core"
 import { USERS_TABLE_SCHEMA } from "../../constants"
 import { buildDefaultDocs } from "../../db/defaultData/datasource_bb_default"
@@ -44,6 +44,7 @@ import {
   Layout,
   Screen,
   MigrationType,
+  BBContext,
   Database,
   UserCtx,
 } from "@budibase/types"
@@ -73,14 +74,14 @@ async function getScreens() {
   ).rows.map((row: any) => row.doc)
 }
 
-function getUserRoleId(ctx: UserCtx) {
+function getUserRoleId(ctx: BBContext) {
   return !ctx.user?.role || !ctx.user.role._id
     ? roles.BUILTIN_ROLE_IDS.PUBLIC
     : ctx.user.role._id
 }
 
 function checkAppUrl(
-  ctx: UserCtx,
+  ctx: BBContext,
   apps: App[],
   url: string,
   currentAppId?: string
@@ -94,7 +95,7 @@ function checkAppUrl(
 }
 
 function checkAppName(
-  ctx: UserCtx,
+  ctx: BBContext,
   apps: App[],
   name: string,
   currentAppId?: string
@@ -159,7 +160,7 @@ async function addDefaultTables(db: Database) {
   await db.bulkDocs([...defaultDbDocs])
 }
 
-export async function fetch(ctx: UserCtx) {
+export async function fetch(ctx: BBContext) {
   const dev = ctx.query && ctx.query.status === AppStatus.DEV
   const all = ctx.query && ctx.query.status === AppStatus.ALL
   const apps = (await dbCore.getAllApps({ dev, all })) as App[]
@@ -184,7 +185,7 @@ export async function fetch(ctx: UserCtx) {
   ctx.body = await checkAppMetadata(apps)
 }
 
-export async function fetchAppDefinition(ctx: UserCtx) {
+export async function fetchAppDefinition(ctx: BBContext) {
   const layouts = await getLayouts()
   const userRoleId = getUserRoleId(ctx)
   const accessController = new roles.AccessController()
@@ -230,7 +231,7 @@ export async function fetchAppPackage(ctx: UserCtx) {
   }
 }
 
-async function performAppCreate(ctx: UserCtx) {
+async function performAppCreate(ctx: BBContext) {
   const apps = (await dbCore.getAllApps({ dev: true })) as App[]
   const name = ctx.request.body.name,
     possibleUrl = ctx.request.body.url
@@ -359,7 +360,7 @@ async function creationEvents(request: any, app: App) {
   }
 }
 
-async function appPostCreate(ctx: UserCtx, app: App) {
+async function appPostCreate(ctx: BBContext, app: App) {
   const tenantId = tenancy.getTenantId()
   await migrations.backPopulateMigrations({
     type: MigrationType.APP,
@@ -377,7 +378,7 @@ async function appPostCreate(ctx: UserCtx, app: App) {
           return quotas.addRows(rowCount)
         })
       } catch (err: any) {
-        if (err.code && err.code === ErrorCode.USAGE_LIMIT_EXCEEDED) {
+        if (err.code && err.code === errors.codes.USAGE_LIMIT_EXCEEDED) {
           // this import resulted in row usage exceeding the quota
           // delete the app
           // skip pre and post-steps as no rows have been added to quotas yet
@@ -390,7 +391,7 @@ async function appPostCreate(ctx: UserCtx, app: App) {
   }
 }
 
-export async function create(ctx: UserCtx) {
+export async function create(ctx: BBContext) {
   const newApplication = await quotas.addApp(() => performAppCreate(ctx))
   await appPostCreate(ctx, newApplication)
   await cache.bustCache(cache.CacheKey.CHECKLIST)
@@ -400,7 +401,7 @@ export async function create(ctx: UserCtx) {
 
 // This endpoint currently operates as a PATCH rather than a PUT
 // Thus name and url fields are handled only if present
-export async function update(ctx: UserCtx) {
+export async function update(ctx: BBContext) {
   const apps = (await dbCore.getAllApps({ dev: true })) as App[]
   // validation
   const name = ctx.request.body.name,
@@ -420,7 +421,7 @@ export async function update(ctx: UserCtx) {
   ctx.body = app
 }
 
-export async function updateClient(ctx: UserCtx) {
+export async function updateClient(ctx: BBContext) {
   // Get current app version
   const db = context.getAppDB()
   const application = await db.get(DocumentType.APP_METADATA)
@@ -444,7 +445,7 @@ export async function updateClient(ctx: UserCtx) {
   ctx.body = app
 }
 
-export async function revertClient(ctx: UserCtx) {
+export async function revertClient(ctx: BBContext) {
   // Check app can be reverted
   const db = context.getAppDB()
   const application = await db.get(DocumentType.APP_METADATA)
@@ -470,7 +471,7 @@ export async function revertClient(ctx: UserCtx) {
   ctx.body = app
 }
 
-async function unpublishApp(ctx: UserCtx) {
+const unpublishApp = async (ctx: any) => {
   let appId = ctx.params.appId
   appId = dbCore.getProdAppID(appId)
 
@@ -486,7 +487,7 @@ async function unpublishApp(ctx: UserCtx) {
   return result
 }
 
-async function destroyApp(ctx: UserCtx) {
+async function destroyApp(ctx: BBContext) {
   let appId = ctx.params.appId
   appId = dbCore.getProdAppID(appId)
   const devAppId = dbCore.getDevAppID(appId)
@@ -514,12 +515,12 @@ async function destroyApp(ctx: UserCtx) {
   return result
 }
 
-async function preDestroyApp(ctx: UserCtx) {
+async function preDestroyApp(ctx: BBContext) {
   const { rows } = await getUniqueRows([ctx.params.appId])
   ctx.rowCount = rows.length
 }
 
-async function postDestroyApp(ctx: UserCtx) {
+async function postDestroyApp(ctx: BBContext) {
   const rowCount = ctx.rowCount
   await groups.cleanupApp(ctx.params.appId)
   if (rowCount) {
@@ -527,7 +528,7 @@ async function postDestroyApp(ctx: UserCtx) {
   }
 }
 
-export async function destroy(ctx: UserCtx) {
+export async function destroy(ctx: BBContext) {
   await preDestroyApp(ctx)
   const result = await destroyApp(ctx)
   await postDestroyApp(ctx)
@@ -535,7 +536,7 @@ export async function destroy(ctx: UserCtx) {
   ctx.body = result
 }
 
-export async function unpublish(ctx: UserCtx) {
+export const unpublish = async (ctx: BBContext) => {
   const prodAppId = dbCore.getProdAppID(ctx.params.appId)
   const dbExists = await dbCore.dbExists(prodAppId)
 
@@ -550,7 +551,7 @@ export async function unpublish(ctx: UserCtx) {
   ctx.status = 204
 }
 
-export async function sync(ctx: UserCtx) {
+export async function sync(ctx: BBContext) {
   const appId = ctx.params.appId
   try {
     ctx.body = await sdk.applications.syncApp(appId)

package/src/api/controllers/row/external.ts

@@ -56,13 +56,6 @@ export async function patch(ctx: UserCtx) {
   const id = inputs._id
   // don't save the ID to db
   delete inputs._id
-  const validateResult = await utils.validate({
-    row: inputs,
-    tableId,
-  })
-  if (!validateResult.valid) {
-    throw { validation: validateResult.errors }
-  }
   return handleRequest(Operation.UPDATE, tableId, {
     id: breakRowIdField(id),
     row: inputs,
@@ -73,13 +66,6 @@ export async function patch(ctx: UserCtx) {
 export async function save(ctx: UserCtx) {
   const inputs = ctx.request.body
   const tableId = ctx.params.tableId
-  const validateResult = await utils.validate({
-    row: inputs,
-    tableId,
-  })
-  if (!validateResult.valid) {
-    throw { validation: validateResult.errors }
-  }
   return handleRequest(Operation.CREATE, tableId, {
     row: inputs,
     includeSqlRelationships: IncludeRelationship.EXCLUDE,

package/src/api/controllers/row/utils.ts

@@ -62,11 +62,10 @@ export async function validate({
   }
   const errors: any = {}
   for (let fieldName of Object.keys(fetchedTable.schema)) {
-    const column = fetchedTable.schema[fieldName]
-    const constraints = cloneDeep(column.constraints)
-    const type = column.type
+    const constraints = cloneDeep(fetchedTable.schema[fieldName].constraints)
+    const type = fetchedTable.schema[fieldName].type
     // formulas shouldn't validated, data will be deleted anyway
-    if (type === FieldTypes.FORMULA || column.autocolumn) {
+    if (type === FieldTypes.FORMULA) {
       continue
     }
     // special case for options, need to always allow unselected (null)