npm - @budibase/server - Versions diffs - 2.1.40-alpha.4 → 2.1.41 - Mend

@budibase/server 2.1.40-alpha.4 → 2.1.41

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (787) hide show

package/coverage/lcov-report/{src/api/controllers/permission.ts.html → api/controllers/permission.js.html} RENAMED Viewed

@@ -3,15 +3,15 @@
 <html lang="en">
 <head>
-    <title>Code coverage report for src/api/controllers/permission.ts</title>
+    <title>Code coverage report for api/controllers/permission.js</title>
     <meta charset="utf-8" />
-    <link rel="stylesheet" href="../../../prettify.css" />
-    <link rel="stylesheet" href="../../../base.css" />
-    <link rel="shortcut icon" type="image/x-icon" href="../../../favicon.png" />
+    <link rel="stylesheet" href="../../prettify.css" />
+    <link rel="stylesheet" href="../../base.css" />
+    <link rel="shortcut icon" type="image/x-icon" href="../../favicon.png" />
     <meta name="viewport" content="width=device-width, initial-scale=1" />
     <style type='text/css'>
         .coverage-summary .sorter {
-            background-image: url(../../../sort-arrow-sprite.png);
+            background-image: url(../../sort-arrow-sprite.png);
         }
     </style>
 </head>
@@ -19,20 +19,20 @@
 <body>
 <div class='wrapper'>
     <div class='pad1'>
-        <h1><a href="../../../index.html">All files</a> / <a href="index.html">src/api/controllers</a> permission.ts</h1>
+        <h1><a href="../../index.html">All files</a> / <a href="index.html">api/controllers</a> permission.js</h1>
         <div class='clearfix'>
             <div class='fl pad1y space-right2'>
-                <span class="strong">97.56% </span>
+                <span class="strong">98.78% </span>
                 <span class="quiet">Statements</span>
-                <span class='fraction'>80/82</span>
+                <span class='fraction'>81/82</span>
             </div>
             <div class='fl pad1y space-right2'>
-                <span class="strong">80.76% </span>
+                <span class="strong">90.62% </span>
                 <span class="quiet">Branches</span>
-                <span class='fraction'>21/26</span>
+                <span class='fraction'>29/32</span>
             </div>
@@ -44,9 +44,9 @@
             <div class='fl pad1y space-right2'>
-                <span class="strong">97.43% </span>
+                <span class="strong">98.71% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>76/78</span>
+                <span class='fraction'>77/78</span>
             </div>
@@ -238,29 +238,28 @@
 <a name='L173'></a><a href='#L173'>173</a>
 <a name='L174'></a><a href='#L174'>174</a>
 <a name='L175'></a><a href='#L175'>175</a>
-<a name='L176'></a><a href='#L176'>176</a>
-<a name='L177'></a><a href='#L177'>177</a>
-<a name='L178'></a><a href='#L178'>178</a>
-<a name='L179'></a><a href='#L179'>179</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">44x</span>
-<span class="cline-any cline-yes">44x</span>
-<span class="cline-any cline-yes">44x</span>
+<a name='L176'></a><a href='#L176'>176</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">44x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">44x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">44x</span>
 <span class="cline-any cline-yes">44x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">44x</span>
+<span class="cline-any cline-yes">44x</span>
+<span class="cline-any cline-yes">44x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">44x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">12x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">44x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -269,6 +268,7 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">12x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -357,9 +357,6 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">2x</span>
 <span class="cline-any cline-yes">2x</span>
-<span class="cline-any cline-no">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">2x</span>
 <span class="cline-any cline-yes">2x</span>
 <span class="cline-any cline-yes">2x</span>
 <span class="cline-any cline-yes">2x</span>
@@ -389,9 +386,6 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">9x</span>
 <span class="cline-any cline-yes">12x</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">12x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -419,14 +413,21 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import { permissions, roles, context } from "@budibase/backend-core"
-import { getRoleParams } from "../../db/utils"
-import {
+<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">const { getBuiltinPermissions } = require("@budibase/backend-core/permissions")
+const {
+  isBuiltin,
+  getDBRoleID,
+  getExternalRoleID,
+  getBuiltinRoles,
+  checkForRoleResourceArray,
+} = require("@budibase/backend-core/roles")
+const { getRoleParams } = require("../../db/utils")
+const {
   CURRENTLY_SUPPORTED_LEVELS,
   getBasePermissions,
-} from "../../utilities/security"
-import { removeFromArray } from "../../utilities"
-import { BBContext, Database, Role } from "@budibase/types"
+} = require("../../utilities/security")
+const { removeFromArray } = require("../../utilities")
+const { getAppDB } = require("@budibase/backend-core/context")
 &nbsp;
 const PermissionUpdateType = {
   REMOVE: "remove",
@@ -436,7 +437,7 @@ const PermissionUpdateType = {
 const SUPPORTED_LEVELS = CURRENTLY_SUPPORTED_LEVELS
 &nbsp;
 // utility function to stop this repetition - permissions always stored under roles
-async function getAllDBRoles(db: Database) {
+async function getAllDBRoles(db) {
   const body = await db.allDocs(
     getRoleParams(null, {
       include_docs: true,
@@ -446,25 +447,21 @@ async function getAllDBRoles(db: Database) {
 }
 &nbsp;
 async function updatePermissionOnRole(
-  appId: string,
-  {
-    roleId,
-    resourceId,
-    level,
-  }: { roleId: string; resourceId: string; level: string },
-  updateType: string
+  appId,
+  { roleId, resourceId, level },
+  updateType
 ) {
-  const db = context.getAppDB()
+  const db = getAppDB()
   const remove = updateType === PermissionUpdateType.REMOVE
-  const isABuiltin = roles.isBuiltin(roleId)
-  const dbRoleId = roles.getDBRoleID(roleId)
+  const isABuiltin = isBuiltin(roleId)
+  const dbRoleId = getDBRoleID(roleId)
   const dbRoles = await getAllDBRoles(db)
   const docUpdates = []
 &nbsp;
   // the permission is for a built in, make sure it exists
   if (isABuiltin &amp;&amp; !dbRoles.some(role =&gt; role._id === dbRoleId)) {
-    const builtin = roles.getBuiltinRoles()[roleId]
-    builtin._id = roles.getDBRoleID(builtin._id)
+    const builtin = getBuiltinRoles()[roleId]
+    builtin._id = getDBRoleID(builtin._id)
     dbRoles.push(builtin)
   }
 &nbsp;
@@ -472,7 +469,7 @@ async function updatePermissionOnRole(
   // resource from another role and then adding to the new role
   for (let role of dbRoles) {
     let updated = false
-    const rolePermissions = role.permissions ? role.permissions : <span class="branch-1 cbranch-no" title="branch not covered" >{}</span>
+    const rolePermissions = role.permissions ? role.permissions : {}
     // make sure its an array, also handle migrating
     if (
       !rolePermissions[resourceId] ||
@@ -508,44 +505,41 @@ async function updatePermissionOnRole(
   }
 &nbsp;
   const response = await db.bulkDocs(docUpdates)
-  return response.map((resp: any) =&gt; {
-    resp._id = roles.getExternalRoleID(resp.id)
+  return response.map(resp =&gt; {
+    resp._id = getExternalRoleID(resp.id)
     delete resp.id
     return resp
   })
 }
 &nbsp;
-export function fetchBuiltin(ctx: BBContext) {
-  ctx.body = Object.values(permissions.getBuiltinPermissions())
+exports.fetchBuiltin = function (ctx) {
+  ctx.body = Object.values(getBuiltinPermissions())
 }
 &nbsp;
-export function fetchLevels(ctx: BBContext) {
+exports.fetchLevels = function (ctx) {
   // for now only provide the read/write perms externally
   ctx.body = SUPPORTED_LEVELS
 }
 &nbsp;
-export async function fetch(ctx: BBContext) {
-  const db = context.getAppDB()
-  const dbRoles: Role[] = await getAllDBRoles(db)
-  let permissions: any = {}
+exports.fetch = async function (ctx) {
+  const db = getAppDB()
+  const roles = await getAllDBRoles(db)
+  let permissions = {}
   // create an object with structure role ID -&gt; resource ID -&gt; level
-  for (let role of dbRoles) {
+  for (let role of roles) {
     <span class="missing-if-branch" title="if path not taken" >I</span>if (!role.permissions) {
 <span class="cstat-no" title="statement not covered" >      continue</span>
     }
-    const roleId = roles.getExternalRoleID(role._id)
-    <span class="missing-if-branch" title="if path not taken" >I</span>if (!roleId) {
-<span class="cstat-no" title="statement not covered" >      ctx.throw(400, "Unable to retrieve role")</span>
-    }
+    const roleId = getExternalRoleID(role._id)
     for (let [resource, levelArr] of Object.entries(role.permissions)) {
-      const levels: string[] = Array.isArray(levelArr) ? levelArr : <span class="branch-1 cbranch-no" title="branch not covered" >[levelArr]</span>
-      const perms: Record&lt;string, string&gt; = {}
-      levels.forEach(level =&gt; (perms[level] = roleId!))
+      const levels = Array.isArray(levelArr) ? [levelArr] : <span class="branch-1 cbranch-no" title="branch not covered" >levelArr</span>
+      const perms = {}
+      levels.forEach(level =&gt; (perms[level] = roleId))
       permissions[resource] = perms
     }
   }
   // apply the base permissions
-  const finalPermissions: Record&lt;string, Record&lt;string, string&gt;&gt; = {}
+  const finalPermissions = {}
   for (let [resource, permission] of Object.entries(permissions)) {
     const basePerms = getBasePermissions(resource)
     finalPermissions[resource] = Object.assign(basePerms, permission)
@@ -553,36 +547,33 @@ export async function fetch(ctx: BBContext) {
   ctx.body = finalPermissions
 }
 &nbsp;
-export async function getResourcePerms(ctx: BBContext) {
+exports.getResourcePerms = async function (ctx) {
   const resourceId = ctx.params.resourceId
-  const db = context.getAppDB()
+  const db = getAppDB()
   const body = await db.allDocs(
     getRoleParams(null, {
       include_docs: true,
     })
   )
-  const rolesList = body.rows.map(row =&gt; row.doc)
-  let permissions: Record&lt;string, string&gt; = {}
+  const roles = body.rows.map(row =&gt; row.doc)
+  let permissions = {}
   for (let level of SUPPORTED_LEVELS) {
     // update the various roleIds in the resource permissions
-    for (let role of rolesList) {
-      const rolePerms = roles.checkForRoleResourceArray(
-        role.permissions,
-        resourceId
-      )
+    for (let role of roles) {
+      const rolePerms = checkForRoleResourceArray(role.permissions, resourceId)
       if (
         rolePerms &amp;&amp;
         rolePerms[resourceId] &amp;&amp;
         rolePerms[resourceId].indexOf(level) !== -1
       ) {
-        permissions[level] = roles.getExternalRoleID(role._id)!
+        permissions[level] = getExternalRoleID(role._id)
       }
     }
   }
   ctx.body = Object.assign(getBasePermissions(resourceId), permissions)
 }
 &nbsp;
-export async function addPermission(ctx: BBContext) {
+exports.addPermission = async function (ctx) {
   ctx.body = await updatePermissionOnRole(
     ctx.appId,
     ctx.params,
@@ -590,7 +581,7 @@ export async function addPermission(ctx: BBContext) {
   )
 }
 &nbsp;
-export async function removePermission(ctx: BBContext) {
+exports.removePermission = async function (ctx) {
   ctx.body = await updatePermissionOnRole(
     ctx.appId,
     ctx.params,
@@ -604,16 +595,16 @@ export async function removePermission(ctx: BBContext) {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Nov 29 2022 22:23:34 GMT+0000 (Coordinated Universal Time)
+                at Wed Nov 30 2022 09:49:44 GMT+0000 (Coordinated Universal Time)
             </div>
-        <script src="../../../prettify.js"></script>
+        <script src="../../prettify.js"></script>
         <script>
             window.onload = function () {
                 prettyPrint();
             };
         </script>
-        <script src="../../../sorter.js"></script>
-        <script src="../../../block-navigation.js"></script>
+        <script src="../../sorter.js"></script>
+        <script src="../../block-navigation.js"></script>
     </body>
 </html>

package/coverage/lcov-report/{src/utilities/routing → api/controllers/query}/index.html RENAMED Viewed

@@ -3,7 +3,7 @@
 <html lang="en">
 <head>
-    <title>Code coverage report for src/utilities/routing</title>
+    <title>Code coverage report for api/controllers/query</title>
     <meta charset="utf-8" />
     <link rel="stylesheet" href="../../../prettify.css" />
     <link rel="stylesheet" href="../../../base.css" />
@@ -19,7 +19,7 @@
 <body>
 <div class='wrapper'>
     <div class='pad1'>
-        <h1><a href="../../../index.html">All files</a> src/utilities/routing</h1>
+        <h1><a href="../../../index.html">All files</a> api/controllers/query</h1>
         <div class='clearfix'>
             <div class='fl pad1y space-right2'>
@@ -39,14 +39,14 @@
             <div class='fl pad1y space-right2'>
                 <span class="strong">100% </span>
                 <span class="quiet">Functions</span>
-                <span class='fraction'>2/2</span>
+                <span class='fraction'>3/3</span>
             </div>
             <div class='fl pad1y space-right2'>
                 <span class="strong">100% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>8/8</span>
+                <span class='fraction'>9/9</span>
             </div>
@@ -79,7 +79,7 @@
 </tr>
 </thead>
 <tbody><tr>
-	<td class="file high" data-value="index.ts"><a href="index.ts.html">index.ts</a></td>
+	<td class="file high" data-value="validation.js"><a href="validation.js.html">validation.js</a></td>
 	<td data-value="100" class="pic high">
 	<div class="chart"><div class="cover-fill cover-full" style="width: 100%"></div><div class="cover-empty" style="width: 0%"></div></div>
 	</td>
@@ -88,9 +88,9 @@
 	<td data-value="100" class="pct high">100%</td>
 	<td data-value="0" class="abs high">0/0</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="2" class="abs high">2/2</td>
+	<td data-value="3" class="abs high">3/3</td>
 	<td data-value="100" class="pct high">100%</td>
-	<td data-value="8" class="abs high">8/8</td>
+	<td data-value="9" class="abs high">9/9</td>
 	</tr>
 </tbody>
@@ -101,7 +101,7 @@
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Nov 29 2022 22:23:34 GMT+0000 (Coordinated Universal Time)
+                at Wed Nov 30 2022 09:49:44 GMT+0000 (Coordinated Universal Time)
             </div>
         <script src="../../../prettify.js"></script>
         <script>

package/coverage/lcov-report/{src/api/controllers/query/validation.ts.html → api/controllers/query/validation.js.html} RENAMED Viewed

@@ -3,15 +3,15 @@
 <html lang="en">
 <head>
-    <title>Code coverage report for src/api/controllers/query/validation.ts</title>
+    <title>Code coverage report for api/controllers/query/validation.js</title>
     <meta charset="utf-8" />
-    <link rel="stylesheet" href="../../../../prettify.css" />
-    <link rel="stylesheet" href="../../../../base.css" />
-    <link rel="shortcut icon" type="image/x-icon" href="../../../../favicon.png" />
+    <link rel="stylesheet" href="../../../prettify.css" />
+    <link rel="stylesheet" href="../../../base.css" />
+    <link rel="shortcut icon" type="image/x-icon" href="../../../favicon.png" />
     <meta name="viewport" content="width=device-width, initial-scale=1" />
     <style type='text/css'>
         .coverage-summary .sorter {
-            background-image: url(../../../../sort-arrow-sprite.png);
+            background-image: url(../../../sort-arrow-sprite.png);
         }
     </style>
 </head>
@@ -19,7 +19,7 @@
 <body>
 <div class='wrapper'>
     <div class='pad1'>
-        <h1><a href="../../../../index.html">All files</a> / <a href="index.html">src/api/controllers/query</a> validation.ts</h1>
+        <h1><a href="../../../index.html">All files</a> / <a href="index.html">api/controllers/query</a> validation.js</h1>
         <div class='clearfix'>
             <div class='fl pad1y space-right2'>
@@ -163,12 +163,12 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import { auth } from "@budibase/backend-core"
-import Joi from "joi"
+<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">const { joiValidator } = require("@budibase/backend-core/auth")
+const Joi = require("joi")
 &nbsp;
 const OPTIONAL_STRING = Joi.string().optional().allow(null).allow("")
 &nbsp;
-export function queryValidation() {
+exports.queryValidation = () =&gt; {
   return Joi.object({
     _id: Joi.string(),
     _rev: Joi.string(),
@@ -190,14 +190,14 @@ export function queryValidation() {
   }).unknown(true)
 }
 &nbsp;
-export function generateQueryValidation() {
+exports.generateQueryValidation = () =&gt; {
   // prettier-ignore
-  return auth.joiValidator.body(queryValidation())
+  return joiValidator.body(exports.queryValidation())
 }
 &nbsp;
-export function generateQueryPreviewValidation() {
+exports.generateQueryPreviewValidation = () =&gt; {
   // prettier-ignore
-  return auth.joiValidator.body(Joi.object({
+  return joiValidator.body(Joi.object({
     _id: OPTIONAL_STRING,
     _rev: OPTIONAL_STRING,
     readable: Joi.boolean().optional(),
@@ -220,16 +220,16 @@ export function generateQueryPreviewValidation() {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Tue Nov 29 2022 22:23:34 GMT+0000 (Coordinated Universal Time)
+                at Wed Nov 30 2022 09:49:44 GMT+0000 (Coordinated Universal Time)
             </div>
-        <script src="../../../../prettify.js"></script>
+        <script src="../../../prettify.js"></script>
         <script>
             window.onload = function () {
                 prettyPrint();
             };
         </script>
-        <script src="../../../../sorter.js"></script>
-        <script src="../../../../block-navigation.js"></script>
+        <script src="../../../sorter.js"></script>
+        <script src="../../../block-navigation.js"></script>
     </body>
 </html>