npm - @budibase/server - Versions diffs - 2.1.32-alpha.7 → 2.1.32 - Mend

@budibase/server 2.1.32-alpha.7 → 2.1.32

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (663) hide show

package/coverage/lcov-report/{src/api/controllers/table/bulkFormula.ts.html → api/controllers/table/bulkFormula.js.html} RENAMED Viewed

@@ -3,15 +3,15 @@
 <html lang="en">
 <head>
-    <title>Code coverage report for src/api/controllers/table/bulkFormula.ts</title>
+    <title>Code coverage report for api/controllers/table/bulkFormula.js</title>
     <meta charset="utf-8" />
-    <link rel="stylesheet" href="../../../../prettify.css" />
-    <link rel="stylesheet" href="../../../../base.css" />
-    <link rel="shortcut icon" type="image/x-icon" href="../../../../favicon.png" />
+    <link rel="stylesheet" href="../../../prettify.css" />
+    <link rel="stylesheet" href="../../../base.css" />
+    <link rel="shortcut icon" type="image/x-icon" href="../../../favicon.png" />
     <meta name="viewport" content="width=device-width, initial-scale=1" />
     <style type='text/css'>
         .coverage-summary .sorter {
-            background-image: url(../../../../sort-arrow-sprite.png);
+            background-image: url(../../../sort-arrow-sprite.png);
         }
     </style>
 </head>
@@ -19,20 +19,20 @@
 <body>
 <div class='wrapper'>
     <div class='pad1'>
-        <h1><a href="../../../../index.html">All files</a> / <a href="index.html">src/api/controllers/table</a> bulkFormula.ts</h1>
+        <h1><a href="../../../index.html">All files</a> / <a href="index.html">api/controllers/table</a> bulkFormula.js</h1>
         <div class='clearfix'>
             <div class='fl pad1y space-right2'>
-                <span class="strong">69.51% </span>
+                <span class="strong">69.62% </span>
                 <span class="quiet">Statements</span>
-                <span class='fraction'>57/82</span>
+                <span class='fraction'>55/79</span>
             </div>
             <div class='fl pad1y space-right2'>
-                <span class="strong">36.73% </span>
+                <span class="strong">42.1% </span>
                 <span class="quiet">Branches</span>
-                <span class='fraction'>18/49</span>
+                <span class='fraction'>24/57</span>
             </div>
@@ -44,9 +44,9 @@
             <div class='fl pad1y space-right2'>
-                <span class="strong">69.62% </span>
+                <span class="strong">69.73% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>55/79</span>
+                <span class='fraction'>53/76</span>
             </div>
@@ -237,28 +237,13 @@
 <a name='L172'></a><a href='#L172'>172</a>
 <a name='L173'></a><a href='#L173'>173</a>
 <a name='L174'></a><a href='#L174'>174</a>
-<a name='L175'></a><a href='#L175'>175</a>
-<a name='L176'></a><a href='#L176'>176</a>
-<a name='L177'></a><a href='#L177'>177</a>
-<a name='L178'></a><a href='#L178'>178</a>
-<a name='L179'></a><a href='#L179'>179</a>
-<a name='L180'></a><a href='#L180'>180</a>
-<a name='L181'></a><a href='#L181'>181</a>
-<a name='L182'></a><a href='#L182'>182</a>
-<a name='L183'></a><a href='#L183'>183</a>
-<a name='L184'></a><a href='#L184'>184</a>
-<a name='L185'></a><a href='#L185'>185</a>
-<a name='L186'></a><a href='#L186'>186</a>
-<a name='L187'></a><a href='#L187'>187</a>
-<a name='L188'></a><a href='#L188'>188</a>
-<a name='L189'></a><a href='#L189'>189</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">45x</span>
+<a name='L175'></a><a href='#L175'>175</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">45x</span>
 <span class="cline-any cline-yes">45x</span>
 <span class="cline-any cline-yes">45x</span>
 <span class="cline-any cline-yes">45x</span>
 <span class="cline-any cline-yes">45x</span>
 <span class="cline-any cline-yes">45x</span>
 <span class="cline-any cline-yes">45x</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">45x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -294,9 +279,6 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">133x</span>
 <span class="cline-any cline-yes">308x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -312,9 +294,6 @@
 <span class="cline-any cline-yes">2x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">287x</span>
-<span class="cline-any cline-no">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">287x</span>
 <span class="cline-any cline-yes">287x</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -359,7 +338,6 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">133x</span>
-<span class="cline-any cline-yes">133x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">133x</span>
 <span class="cline-any cline-yes">308x</span>
@@ -413,9 +391,6 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">130x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">318x</span>
@@ -430,26 +405,22 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">45x</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">133x</span>
 <span class="cline-any cline-yes">133x</span>
 <span class="cline-any cline-yes">133x</span>
 <span class="cline-any cline-yes">130x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import { FieldTypes, FormulaTypes } from "../../../constants"
-import { clearColumns } from "./utils"
-import { doesContainStrings } from "@budibase/string-templates"
-import { cloneDeep } from "lodash/fp"
-import { isEqual, uniq } from "lodash"
-import { updateAllFormulasInTable } from "../row/staticFormula"
-import { context } from "@budibase/backend-core"
-import { FieldSchema, Table } from "@budibase/types"
-import sdk from "../../../sdk"
+<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">const { FieldTypes, FormulaTypes } = require("../../../constants")
+const { clearColumns } = require("./utils")
+const { doesContainStrings } = require("@budibase/string-templates")
+const { cloneDeep } = require("lodash/fp")
+const { isEqual, uniq } = require("lodash")
+const { updateAllFormulasInTable } = require("../row/staticFormula")
+const { getAppDB } = require("@budibase/backend-core/context")
+const sdk = require("../../../sdk")
 &nbsp;
-function isStaticFormula(column: FieldSchema) {
+function isStaticFormula(column) {
   return (
     column.type === FieldTypes.FORMULA &amp;&amp;
 <span class="branch-1 cbranch-no" title="branch not covered" >    column.formulaType === FormulaTypes.STATIC</span>
@@ -460,15 +431,15 @@ function isStaticFormula(column: FieldSchema) {
  * This retrieves the formula columns from a table schema that use a specified column name
  * in the formula.
  */
-function getFormulaThatUseColumn(table: Table, columnNames: string[] | string) {
-  let formula: string[] = []
+function getFormulaThatUseColumn(table, columnNames) {
+  let formula = []
   columnNames = Array.isArray(columnNames) ? <span class="branch-0 cbranch-no" title="branch not covered" >columnNames </span>: [columnNames]
   for (let column of Object.values(table.schema)) {
     // not a static formula, or doesn't contain a relationship
-    if (!isStaticFormula(column)) {
+    <span class="missing-if-branch" title="else path not taken" >E</span>if (!isStaticFormula(column)) {
       continue
     }
-<span class="cstat-no" title="statement not covered" >    <span class="missing-if-branch" title="if path not taken" >I</span>if (!doesContainStrings(column?.formula ?? "", columnNames)) {</span>
+<span class="cstat-no" title="statement not covered" >    if (!doesContainStrings(column?.formula ?? "", columnNames)) {</span>
 <span class="cstat-no" title="statement not covered" >      continue</span>
     }
 <span class="cstat-no" title="statement not covered" >    formula.push(column.name)</span>
@@ -480,10 +451,7 @@ function getFormulaThatUseColumn(table: Table, columnNames: string[] | string) {
  * This functions checks for when a related table, column or related column is deleted, if any
  * tables need to have the formula column removed.
  */
-async function checkIfFormulaNeedsCleared(
-  table: Table,
-  { oldTable, deletion }: { oldTable?: Table; deletion?: boolean }
-) {
+async function checkIfFormulaNeedsCleared(table, { oldTable, deletion }) {
   // start by retrieving all tables, remove the current table from the list
   const tables = (await sdk.tables.getAllInternalTables()).filter(
     tbl =&gt; tbl._id !== table._id
@@ -494,41 +462,38 @@ async function checkIfFormulaNeedsCleared(
   )
   // remove any formula columns that used related columns
   for (let removed of removedColumns) {
-    let tableToUse: Table | undefined = table
+    let tableToUse = table
     // if relationship, get the related table
     if (removed.type === FieldTypes.LINK) {
       tableToUse = tables.find(table =&gt; table._id === removed.tableId)
     }
-    <span class="missing-if-branch" title="if path not taken" >I</span>if (!tableToUse) {
-<span class="cstat-no" title="statement not covered" >      continue</span>
-    }
     const columnsToDelete = getFormulaThatUseColumn(tableToUse, removed.name)
     <span class="missing-if-branch" title="if path not taken" >I</span>if (columnsToDelete.length &gt; 0) {
 <span class="cstat-no" title="statement not covered" >      await clearColumns(table, columnsToDelete)</span>
     }
     // need a special case, where a column has been removed from this table, but was used
     // in a different, related tables formula
-    if (!table.relatedFormula) {
+    <span class="missing-if-branch" title="else path not taken" >E</span>if (!table.relatedFormula) {
       continue
     }
 <span class="cstat-no" title="statement not covered" >    for (let relatedTableId of table.relatedFormula) {</span>
       const relatedColumns = <span class="cstat-no" title="statement not covered" >Object.values(table.schema).filter(</span>
-<span class="fstat-no" title="function not covered" >        column </span>=&gt; <span class="cstat-no" title="statement not covered" >column.tableId === relatedTableId</span>
+<span class="fstat-no" title="function not covered" >        co</span>lumn =&gt; <span class="cstat-no" title="statement not covered" >column.tableId === relatedTableId</span>
       )
-      const relatedTable = <span class="cstat-no" title="statement not covered" >tables.find(<span class="fstat-no" title="function not covered" >table </span>=&gt; <span class="cstat-no" title="statement not covered" >table._id === relatedTableId)</span></span>
+      const relatedTable = <span class="cstat-no" title="statement not covered" >tables.find(<span class="fstat-no" title="function not covered" >ta</span>ble =&gt; <span class="cstat-no" title="statement not covered" >table._id === relatedTableId)</span></span>
       // look to see if the column was used in a relationship formula,
       // relationships won't be used for this
-<span class="cstat-no" title="statement not covered" >      <span class="missing-if-branch" title="if path not taken" >I</span>if (relatedTable &amp;&amp; relatedColumns &amp;&amp; removed.type !== FieldTypes.LINK) {</span>
-        let relatedFormulaToRemove: string[] = <span class="cstat-no" title="statement not covered" >[]</span>
+<span class="cstat-no" title="statement not covered" >      if (relatedTable &amp;&amp; relatedColumns &amp;&amp; removed.type !== FieldTypes.LINK) {</span>
+        let relatedFormulaToRemove = <span class="cstat-no" title="statement not covered" >[]</span>
 <span class="cstat-no" title="statement not covered" >        for (let column of relatedColumns) {</span>
 <span class="cstat-no" title="statement not covered" >          relatedFormulaToRemove = relatedFormulaToRemove.concat(</span>
             getFormulaThatUseColumn(relatedTable, [
-              column.fieldName!,
+              column.fieldName,
               removed.name,
             ])
           )
         }
-<span class="cstat-no" title="statement not covered" >        <span class="missing-if-branch" title="if path not taken" >I</span>if (relatedFormulaToRemove.length &gt; 0) {</span>
+<span class="cstat-no" title="statement not covered" >        if (relatedFormulaToRemove.length &gt; 0) {</span>
 <span class="cstat-no" title="statement not covered" >          await clearColumns(relatedTable, uniq(relatedFormulaToRemove))</span>
         }
       }
@@ -543,14 +508,13 @@ async function checkIfFormulaNeedsCleared(
  * specifically only for static formula.
  */
 async function updateRelatedFormulaLinksOnTables(
-  table: Table,
-  { deletion }: { deletion?: boolean } = <span class="branch-0 cbranch-no" title="branch not covered" >{}</span>
+  table,
+  { deletion } = <span class="branch-0 cbranch-no" title="branch not covered" >{ deletion: false }</span>
 ) {
-  const tableId: string = table._id!
-  const db = context.getAppDB()
+  const db = getAppDB()
   // start by retrieving all tables, remove the current table from the list
   const tables = (await sdk.tables.getAllInternalTables()).filter(
-    tbl =&gt; tbl._id !== tableId
+    tbl =&gt; tbl._id !== table._id
   )
   // clone the tables, so we can compare at end
   const initialTables = cloneDeep(tables)
@@ -560,11 +524,11 @@ async function updateRelatedFormulaLinksOnTables(
   )
   // we start by removing the formula field from all tables
   for (let otherTable of tables) {
-    if (!otherTable.relatedFormula) {
+    <span class="missing-if-branch" title="else path not taken" >E</span>if (!otherTable.relatedFormula) {
       continue
     }
-    const index = <span class="cstat-no" title="statement not covered" >otherTable.relatedFormula.indexOf(tableId)</span>
-<span class="cstat-no" title="statement not covered" >    <span class="missing-if-branch" title="if path not taken" >I</span>if (index !== -1) {</span>
+    const index = <span class="cstat-no" title="statement not covered" >otherTable.relatedFormula.indexOf(table._id)</span>
+<span class="cstat-no" title="statement not covered" >    if (index !== -1) {</span>
 <span class="cstat-no" title="statement not covered" >      otherTable.relatedFormula.splice(index, 1)</span>
     }
   }
@@ -572,21 +536,21 @@ async function updateRelatedFormulaLinksOnTables(
   if (!deletion) {
     for (let relatedCol of relatedColumns) {
       let columns = getFormulaThatUseColumn(table, relatedCol.name)
-      if (!columns || columns.length === 0) {
+      <span class="missing-if-branch" title="else path not taken" >E</span>if (!columns || columns.length === 0) {
         continue
       }
       const relatedTable = <span class="cstat-no" title="statement not covered" >tables.find(</span>
-<span class="fstat-no" title="function not covered" >        related </span>=&gt; <span class="cstat-no" title="statement not covered" >related._id === relatedCol.tableId</span>
+<span class="fstat-no" title="function not covered" >        re</span>lated =&gt; <span class="cstat-no" title="statement not covered" >related._id === relatedCol.tableId</span>
       )
       // check if the table is already in the list of related formula, if it isn't, then add it
-<span class="cstat-no" title="statement not covered" >      <span class="missing-if-branch" title="if path not taken" >I</span>if (</span>
+<span class="cstat-no" title="statement not covered" >      if (</span>
         relatedTable &amp;&amp;
         (!relatedTable.relatedFormula ||
-          !relatedTable.relatedFormula.includes(tableId))
+          !relatedTable.relatedFormula.includes(table._id))
       ) {
 <span class="cstat-no" title="statement not covered" >        relatedTable.relatedFormula = relatedTable.relatedFormula</span>
-          ? [...relatedTable.relatedFormula, tableId]
-          : [tableId]
+          ? [...relatedTable.relatedFormula, table._id]
+          : [table._id]
       }
     }
   }
@@ -599,10 +563,7 @@ async function updateRelatedFormulaLinksOnTables(
   }
 }
 &nbsp;
-async function checkIfFormulaUpdated(
-  table: Table,
-  { oldTable }: { oldTable?: Table }
-) {
+async function checkIfFormulaUpdated(table, { oldTable }) {
   // look to see if any formula values have changed
   const shouldUpdate = Object.values(table.schema).find(
     column =&gt;
@@ -617,10 +578,7 @@ async function checkIfFormulaUpdated(
   }
 }
 &nbsp;
-export async function runStaticFormulaChecks(
-  table: Table,
-  { oldTable, deletion }: { oldTable?: Table; deletion?: boolean }
-) {
+exports.runStaticFormulaChecks = async (table, { oldTable, deletion }) =&gt; {
   await updateRelatedFormulaLinksOnTables(table, { deletion })
   await checkIfFormulaNeedsCleared(table, { oldTable, deletion })
   if (!deletion) {
@@ -634,16 +592,16 @@ export async function runStaticFormulaChecks(
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
-                at Wed Nov 23 2022 15:12:32 GMT+0000 (Coordinated Universal Time)
+                at Thu Nov 24 2022 12:17:01 GMT+0000 (Coordinated Universal Time)
             </div>
-        <script src="../../../../prettify.js"></script>
+        <script src="../../../prettify.js"></script>
         <script>
             window.onload = function () {
                 prettyPrint();
             };
         </script>
-        <script src="../../../../sorter.js"></script>
-        <script src="../../../../block-navigation.js"></script>
+        <script src="../../../sorter.js"></script>
+        <script src="../../../block-navigation.js"></script>
     </body>
 </html>