@budibase/server 1.2.49 → 1.2.52

package/dist/utilities/fileSystem/index.js

@@ -250,14 +250,16 @@ exports.getComponentLibraryManifest = (library) => __awaiter(void 0, void 0, voi
         return require(path);
     }
     let resp;
+    let path;
     try {
         // Try to load the manifest from the new file location
-        const path = join(appId, filename);
+        path = join(appId, filename);
         resp = yield retrieve(ObjectStoreBuckets.APPS, path);
     }
     catch (error) {
+        console.error(`component-manifest-objectstore=failed appId=${appId} path=${path}`, error);
         // Fallback to loading it from the old location for old apps
-        const path = join(appId, "node_modules", library, "package", filename);
+        path = join(appId, "node_modules", library, "package", filename);
         resp = yield retrieve(ObjectStoreBuckets.APPS, path);
     }
     if (typeof resp !== "string") {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@budibase/server",
   "email": "hi@budibase.com",
-  "version": "1.2.49",
+  "version": "1.2.52",
   "description": "Budibase Web Server",
   "main": "src/index.ts",
   "repository": {
@@ -77,11 +77,11 @@
   "license": "GPL-3.0",
   "dependencies": {
     "@apidevtools/swagger-parser": "10.0.3",
-    "@budibase/backend-core": "^1.2.49",
-    "@budibase/client": "^1.2.49",
-    "@budibase/pro": "1.2.48",
-    "@budibase/string-templates": "^1.2.49",
-    "@budibase/types": "^1.2.49",
+    "@budibase/backend-core": "^1.2.52",
+    "@budibase/client": "^1.2.52",
+    "@budibase/pro": "1.2.51",
+    "@budibase/string-templates": "^1.2.52",
+    "@budibase/types": "^1.2.52",
     "@bull-board/api": "3.7.0",
     "@bull-board/koa": "3.9.4",
     "@elastic/elasticsearch": "7.10.0",
@@ -195,5 +195,5 @@
   "optionalDependencies": {
     "oracledb": "5.3.0"
   },
-  "gitHead": "279e3878011f8c1fdb7c1502bc7f19a9efd4bd90"
+  "gitHead": "00e10574fc82b720a1213f7e651c482b5d884b3a"
 }

package/src/api/controllers/component.js

@@ -3,32 +3,36 @@ const { getComponentLibraryManifest } = require("../../utilities/fileSystem")
 const { getAppDB } = require("@budibase/backend-core/context")
 
 exports.fetchAppComponentDefinitions = async function (ctx) {
-  const db = getAppDB()
-  const app = await db.get(DocumentType.APP_METADATA)
+  try {
+    const db = getAppDB()
+    const app = await db.get(DocumentType.APP_METADATA)
 
-  let componentManifests = await Promise.all(
-    app.componentLibraries.map(async library => {
-      let manifest = await getComponentLibraryManifest(library)
+    let componentManifests = await Promise.all(
+      app.componentLibraries.map(async library => {
+        let manifest = await getComponentLibraryManifest(library)
 
-      return {
-        manifest,
-        library,
-      }
-    })
-  )
-  const definitions = {}
-  for (let { manifest, library } of componentManifests) {
-    for (let key of Object.keys(manifest)) {
-      if (key === "features") {
-        definitions[key] = manifest[key]
-      } else {
-        const fullComponentName = `${library}/${key}`.toLowerCase()
-        definitions[fullComponentName] = {
-          component: fullComponentName,
-          ...manifest[key],
+        return {
+          manifest,
+          library,
+        }
+      })
+    )
+    const definitions = {}
+    for (let { manifest, library } of componentManifests) {
+      for (let key of Object.keys(manifest)) {
+        if (key === "features") {
+          definitions[key] = manifest[key]
+        } else {
+          const fullComponentName = `${library}/${key}`.toLowerCase()
+          definitions[fullComponentName] = {
+            component: fullComponentName,
+            ...manifest[key],
+          }
         }
       }
     }
+    ctx.body = definitions
+  } catch (err) {
+    console.error(`component-definitions=failed`, err)
   }
-  ctx.body = definitions
 }

package/src/api/controllers/row/index.ts

@@ -35,9 +35,8 @@ export async function patch(ctx: any): Promise<any> {
       pickApi(tableId).patch(ctx)
     )
     ctx.status = 200
-    if (!ctx.disableEmit && ctx.eventEmitter) {
+    ctx.eventEmitter &&
       ctx.eventEmitter.emitRow(`row:update`, appId, row, table)
-    }
     ctx.message = `${table.name} updated successfully.`
     ctx.body = row
   } catch (err) {

package/src/automations/steps/updateRow.js

@@ -1,7 +1,6 @@
 const rowController = require("../../api/controllers/row")
 const automationUtils = require("../automationUtils")
 const { buildCtx } = require("./utils")
-const env = require("../../environment")
 
 exports.definition = {
   name: "Update Row",
@@ -84,7 +83,6 @@ exports.run = async function ({ inputs, appId, emitter }) {
       rowId: inputs.rowId,
       tableId: tableId,
     },
-    disableEmit: !env.SELF_HOSTED,
   })
 
   try {

package/src/db/dynamoClient.js

@@ -103,11 +103,9 @@ class Table {
 
 exports.init = endpoint => {
   let AWS = require("aws-sdk")
-  AWS.config.update({
-    region: AWS_REGION,
-  })
   let docClientParams = {
     correctClockSkew: true,
+    region: AWS_REGION,
   }
   if (endpoint) {
     docClientParams.endpoint = endpoint

package/src/events/AutomationEmitter.js

@@ -1,8 +1,10 @@
 const { rowEmission, tableEmission } = require("./utils")
 const mainEmitter = require("./index")
+const env = require("../environment")
 
 // max number of automations that can chain on top of each other
-const MAX_AUTOMATION_CHAIN = 5
+// TODO: in future make this configurable at the automation level
+const MAX_AUTOMATION_CHAIN = env.SELF_HOSTED ? 5 : 0
 
 /**
  * Special emitter which takes the count of automation runs which have occurred and blocks an

package/src/integrations/dynamodb.ts

@@ -13,7 +13,8 @@ module DynamoModule {
     region: string
     accessKeyId: string
     secretAccessKey: string
-    endpoint: string
+    endpoint?: string
+    currentClockSkew?: boolean
   }
 
   const SCHEMA: Integration = {
@@ -132,31 +133,20 @@ module DynamoModule {
 
     constructor(config: DynamoDBConfig) {
       this.config = config
-      if (this.config.endpoint && !this.config.endpoint.includes("localhost")) {
-        this.connect()
-      }
-      let options = {
-        correctClockSkew: true,
-        region: this.config.region || AWS_REGION,
-        endpoint: config.endpoint ? config.endpoint : undefined,
-      }
-      this.client = new AWS.DynamoDB.DocumentClient(options)
-    }
-
-    end() {
-      this.disconnect()
-    }
 
-    connect() {
-      AWS.config.update(this.config)
-    }
+      // User is using a local dynamoDB endpoint, don't auth with remote
+      if (this.config?.endpoint?.includes("localhost")) {
+        // @ts-ignore
+        this.config = {}
+      }
 
-    disconnect() {
-      AWS.config.update({
-        secretAccessKey: undefined,
-        accessKeyId: undefined,
-        region: AWS_REGION,
-      })
+      this.config = {
+        ...this.config,
+        currentClockSkew: true,
+        region: config.region || AWS_REGION,
+        endpoint: config.endpoint || undefined,
+      }
+      this.client = new AWS.DynamoDB.DocumentClient(this.config)
     }
 
     async create(query: { table: string; json: object }) {
@@ -197,7 +187,7 @@ module DynamoModule {
       const params = {
         TableName: query.table,
       }
-      return new AWS.DynamoDB().describeTable(params).promise()
+      return new AWS.DynamoDB(this.config).describeTable(params).promise()
     }
 
     async get(query: { table: string; json: object }) {

package/src/integrations/tests/dynamodb.spec.js

@@ -100,4 +100,52 @@ describe("DynamoDB Integration", () => {
       Name: "John"
     })
   })
+
+  it("configures the dynamoDB constructor based on an empty endpoint parameter", async () => {
+    const config = {
+      region: "us-east-1",
+      accessKeyId: "test",
+      secretAccessKeyId: "test"
+    }
+
+    const integration = new DynamoDBIntegration.integration(config)
+
+    expect(integration.config).toEqual({
+      currentClockSkew: true,
+      ...config
+    })
+  })
+
+  it("configures the dynamoDB constructor based on a localhost endpoint parameter", async () => {
+    const config = {
+      region: "us-east-1",
+      accessKeyId: "test",
+      secretAccessKeyId: "test",
+      endpoint: "localhost:8080"
+    }
+
+    const integration = new DynamoDBIntegration.integration(config)
+
+    expect(integration.config).toEqual({
+      region: "us-east-1",
+      currentClockSkew: true,
+      endpoint: "localhost:8080"
+    })
+  })
+
+  it("configures the dynamoDB constructor based on a remote endpoint parameter", async () => {
+    const config = {
+      region: "us-east-1",
+      accessKeyId: "test",
+      secretAccessKeyId: "test",
+      endpoint: "dynamodb.aws.foo.net"
+    }
+
+    const integration = new DynamoDBIntegration.integration(config)
+
+    expect(integration.config).toEqual({
+      currentClockSkew: true,
+      ...config
+    })
+  })
 })

package/src/utilities/fileSystem/index.js

@@ -286,13 +286,18 @@ exports.getComponentLibraryManifest = async library => {
   }
 
   let resp
+  let path
   try {
     // Try to load the manifest from the new file location
-    const path = join(appId, filename)
+    path = join(appId, filename)
     resp = await retrieve(ObjectStoreBuckets.APPS, path)
   } catch (error) {
+    console.error(
+      `component-manifest-objectstore=failed appId=${appId} path=${path}`,
+      error
+    )
     // Fallback to loading it from the old location for old apps
-    const path = join(appId, "node_modules", library, "package", filename)
+    path = join(appId, "node_modules", library, "package", filename)
     resp = await retrieve(ObjectStoreBuckets.APPS, path)
   }
   if (typeof resp !== "string") {