@budibase/server 1.0.49-alpha.4 → 1.0.49-alpha.8

package/coverage/lcov-report/api/controllers/table/internal.js.html

@@ -23,30 +23,30 @@
         <div class='clearfix'>
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">77.14% </span>
+                <span class="strong">72.46% </span>
                 <span class="quiet">Statements</span>
-                <span class='fraction'>54/70</span>
+                <span class='fraction'>50/69</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">71.87% </span>
+                <span class="strong">67.64% </span>
                 <span class="quiet">Branches</span>
-                <span class='fraction'>23/32</span>
+                <span class='fraction'>23/34</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">60% </span>
+                <span class="strong">40% </span>
                 <span class="quiet">Functions</span>
-                <span class='fraction'>3/5</span>
+                <span class='fraction'>2/5</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">80.59% </span>
+                <span class="strong">75.75% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>54/67</span>
+                <span class='fraction'>50/66</span>
             </div>
         
             
@@ -213,11 +213,7 @@
 <a name='L154'></a><a href='#L154'>154</a>
 <a name='L155'></a><a href='#L155'>155</a>
 <a name='L156'></a><a href='#L156'>156</a>
-<a name='L157'></a><a href='#L157'>157</a>
-<a name='L158'></a><a href='#L158'>158</a>
-<a name='L159'></a><a href='#L159'>159</a>
-<a name='L160'></a><a href='#L160'>160</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">39x</span>
-<span class="cline-any cline-yes">39x</span>
+<a name='L157'></a><a href='#L157'>157</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -229,12 +225,13 @@
 <span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-yes">39x</span>
+<span class="cline-any cline-yes">39x</span>
+<span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-yes">101x</span>
-<span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -258,7 +255,6 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -306,7 +302,6 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-yes">4x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -332,7 +327,6 @@
 <span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-yes">2x</span>
 <span class="cline-any cline-yes">2x</span>
-<span class="cline-any cline-yes">2x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">2x</span>
@@ -350,19 +344,20 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">2x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">2x</span>
-<span class="cline-any cline-yes">2x</span>
-<span class="cline-any cline-yes">2x</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">2x</span>
+<span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">2x</span>
 <span class="cline-any cline-yes">2x</span>
 <span class="cline-any cline-yes">2x</span>
@@ -373,10 +368,8 @@
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
-<span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">const CouchDB = require("../../../db")
-const linkRows = require("../../../db/linkedRows")
+<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">const linkRows = require("../../../db/linkedRows")
 const { getRowParams, generateTableID } = require("../../../db/utils")
 const { FieldTypes } = require("../../../constants")
 const {
@@ -386,12 +379,13 @@ const {
   handleDataImport,
 } = require("./utils")
 const usageQuota = require("../../../utilities/usageQuota")
+const { getAppDB } = require("@budibase/backend-core/context")
+const env = require("../../../environment")
 const { cleanupAttachments } = require("../../../utilities/rowProcessor")
 const { runStaticFormulaChecks } = require("./bulkFormula")
 &nbsp;
 exports.save = async function (ctx) {
-  const appId = ctx.appId
-  const db = new CouchDB(appId)
+  const db = getAppDB()
   const { dataImport, ...rest } = ctx.request.body
   let tableToSave = {
     type: "table",
@@ -413,8 +407,7 @@ exports.save = async function (ctx) {
   // saving a table is a complex operation, involving many different steps, this
   // has been broken out into a utility to make it more obvious/easier to manipulate
   const tableSaveFunctions = new TableSaveFunctions({
-    db,
-    ctx,
+    user: ctx.user,
     oldTable,
     dataImport,
   })
@@ -459,7 +452,6 @@ exports.save = async function (ctx) {
   // update linked rows
   try {
     const linkResp = await linkRows.updateLinks({
-      appId,
       eventType: oldTable
         ? linkRows.EventType.TABLE_UPDATED
         : linkRows.EventType.TABLE_SAVE,
@@ -484,13 +476,12 @@ exports.save = async function (ctx) {
 &nbsp;
   tableToSave = await tableSaveFunctions.after(tableToSave)
   // has to run after, make sure it has _id
-  await runStaticFormulaChecks(appId, tableToSave, { oldTable })
+  await runStaticFormulaChecks(tableToSave, { oldTable })
   return tableToSave
 }
 &nbsp;
 exports.destroy = async function (ctx) {
-  const appId = ctx.appId
-  const db = new CouchDB(appId)
+  const db = getAppDB()
   const tableToDelete = await db.get(ctx.params.tableId)
 &nbsp;
   // Delete all rows for that table
@@ -504,7 +495,6 @@ exports.destroy = async function (ctx) {
 &nbsp;
   // update linked rows
   await linkRows.updateLinks({
-    appId,
     eventType: linkRows.EventType.TABLE_DELETE,
     table: tableToDelete,
   })
@@ -513,25 +503,26 @@ exports.destroy = async function (ctx) {
   await db.remove(tableToDelete)
 &nbsp;
   // remove table search index
-  const currentIndexes = await db.getIndexes()
-  const existingIndex = currentIndexes.indexes.find(
-    existing =&gt; existing.name === `search:${ctx.params.tableId}`
-  )
-  <span class="missing-if-branch" title="if path not taken" >I</span>if (existingIndex) {
-<span class="cstat-no" title="statement not covered" >    await db.deleteIndex(existingIndex)</span>
+  <span class="missing-if-branch" title="if path not taken" >I</span>if (!env.isTest()) {
+    const currentIndexes = <span class="cstat-no" title="statement not covered" >await db.getIndexes()</span>
+    const existingIndex = <span class="cstat-no" title="statement not covered" >currentIndexes.indexes.find(</span>
+<span class="fstat-no" title="function not covered" >      ex</span>isting =&gt; <span class="cstat-no" title="statement not covered" >existing.name === `search:${ctx.params.tableId}`</span>
+    )
+<span class="cstat-no" title="statement not covered" >    if (existingIndex) {</span>
+<span class="cstat-no" title="statement not covered" >      await db.deleteIndex(existingIndex)</span>
+    }
   }
 &nbsp;
   // has to run after, make sure it has _id
-  await runStaticFormulaChecks(appId, tableToDelete, { deletion: true })
-  await cleanupAttachments(appId, tableToDelete, { rows })
+  await runStaticFormulaChecks(tableToDelete, { deletion: true })
+  await cleanupAttachments(tableToDelete, { rows })
   return tableToDelete
 }
 &nbsp;
 exports.bulkImport = <span class="fstat-no" title="function not covered" >as</span>ync function (ctx) {
-  const appId = <span class="cstat-no" title="statement not covered" >ctx.appId</span>
-  const table = <span class="cstat-no" title="statement not covered" >await getTable(appId, ctx.params.tableId)</span>
+  const table = <span class="cstat-no" title="statement not covered" >await getTable(ctx.params.tableId)</span>
   const { dataImport } = <span class="cstat-no" title="statement not covered" >ctx.request.body</span>
-<span class="cstat-no" title="statement not covered" >  await handleDataImport(appId, ctx.user, table, dataImport)</span>
+<span class="cstat-no" title="statement not covered" >  await handleDataImport(ctx.user, table, dataImport)</span>
 <span class="cstat-no" title="statement not covered" >  return table</span>
 }
 &nbsp;</pre></td></tr></table></pre>
@@ -541,7 +532,7 @@ exports.bulkImport = <span class="fstat-no" title="function not covered" >as</sp
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Mon Jan 31 2022 19:12:04 GMT+0000 (Coordinated Universal Time)
+                at Wed Feb 02 2022 10:59:03 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../../prettify.js"></script>

package/coverage/lcov-report/api/controllers/table/utils.js.html

@@ -23,16 +23,16 @@
         <div class='clearfix'>
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">64.07% </span>
+                <span class="strong">63.9% </span>
                 <span class="quiet">Statements</span>
-                <span class='fraction'>132/206</span>
+                <span class='fraction'>131/205</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">41.41% </span>
+                <span class="strong">40% </span>
                 <span class="quiet">Branches</span>
-                <span class='fraction'>41/99</span>
+                <span class='fraction'>38/95</span>
             </div>
         
             
@@ -44,9 +44,9 @@
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">64.5% </span>
+                <span class="strong">64.32% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>129/200</span>
+                <span class='fraction'>128/199</span>
             </div>
         
             
@@ -474,20 +474,7 @@
 <a name='L415'></a><a href='#L415'>415</a>
 <a name='L416'></a><a href='#L416'>416</a>
 <a name='L417'></a><a href='#L417'>417</a>
-<a name='L418'></a><a href='#L418'>418</a>
-<a name='L419'></a><a href='#L419'>419</a>
-<a name='L420'></a><a href='#L420'>420</a>
-<a name='L421'></a><a href='#L421'>421</a>
-<a name='L422'></a><a href='#L422'>422</a>
-<a name='L423'></a><a href='#L423'>423</a>
-<a name='L424'></a><a href='#L424'>424</a>
-<a name='L425'></a><a href='#L425'>425</a>
-<a name='L426'></a><a href='#L426'>426</a>
-<a name='L427'></a><a href='#L427'>427</a>
-<a name='L428'></a><a href='#L428'>428</a>
-<a name='L429'></a><a href='#L429'>429</a>
-<a name='L430'></a><a href='#L430'>430</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">39x</span>
-<span class="cline-any cline-yes">39x</span>
+<a name='L418'></a><a href='#L418'>418</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -515,6 +502,7 @@
 <span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-yes">39x</span>
+<span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">39x</span>
 <span class="cline-any cline-no">&nbsp;</span>
@@ -536,6 +524,7 @@
 <span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-yes">101x</span>
+<span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-yes">4x</span>
 <span class="cline-any cline-yes">11x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -705,9 +694,6 @@
 <span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">101x</span>
-<span class="cline-any cline-yes">101x</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -722,11 +708,6 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">101x</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -735,11 +716,6 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-yes">101x</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">101x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -915,8 +891,7 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">39x</span>
-<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">const CouchDB = require("../../../db")
-const csvParser = require("../../../utilities/csvParser")
+<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">const csvParser = require("../../../utilities/csvParser")
 const {
   getRowParams,
   generateRowID,
@@ -943,10 +918,11 @@ const {
 const { getViews, saveView } = require("../view/utils")
 const viewTemplate = require("../view/viewBuilder")
 const usageQuota = require("../../../utilities/usageQuota")
+const { getAppDB } = require("@budibase/backend-core/context")
 const { cloneDeep } = require("lodash/fp")
 &nbsp;
-exports.clearColumns = <span class="fstat-no" title="function not covered" >as</span>ync (appId, table, columnNames) =&gt; {
-  const db = <span class="cstat-no" title="statement not covered" >new CouchDB(appId)</span>
+exports.clearColumns = <span class="fstat-no" title="function not covered" >as</span>ync (table, columnNames) =&gt; {
+  const db = <span class="cstat-no" title="statement not covered" >getAppDB()</span>
   const rows = <span class="cstat-no" title="statement not covered" >await db.allDocs(</span>
     getRowParams(table._id, null, {
       include_docs: true,
@@ -960,7 +936,8 @@ exports.clearColumns = <span class="fstat-no" title="function not covered" >as</
   )
 }
 &nbsp;
-exports.checkForColumnUpdates = async (appId, db, oldTable, updatedTable) =&gt; {
+exports.checkForColumnUpdates = async (oldTable, updatedTable) =&gt; {
+  const db = getAppDB()
   let updatedRows = []
   const rename = updatedTable._rename
   let deletedColumns = []
@@ -990,9 +967,9 @@ exports.checkForColumnUpdates = async (appId, db, oldTable, updatedTable) =&gt;
     })
 &nbsp;
     // cleanup any attachments from object storage for deleted attachment columns
-    await cleanupAttachments(appId, updatedTable, { oldTable, rows: rawRows })
+    await cleanupAttachments(updatedTable, { oldTable, rows: rawRows })
     // Update views
-    await exports.checkForViewUpdates(db, updatedTable, rename, deletedColumns)
+    await exports.checkForViewUpdates(updatedTable, rename, deletedColumns)
     delete updatedTable._rename
   }
   return { rows: updatedRows, table: updatedTable }
@@ -1019,12 +996,12 @@ exports.makeSureTableUpToDate = (table, tableToSave) =&gt; {
   return tableToSave
 }
 &nbsp;
-exports.handleDataImport = async (appId, user, table, dataImport) =&gt; {
+exports.handleDataImport = async (user, table, dataImport) =&gt; {
   if (!dataImport || !dataImport.csvString) {
     return table
   }
 &nbsp;
-  const db = new CouchDB(appId)
+  const db = getAppDB()
   // Populate the table with rows imported from CSV in a bulk update
   const data = await csvParser.transform({
     ...dataImport,
@@ -1069,8 +1046,8 @@ exports.handleDataImport = async (appId, user, table, dataImport) =&gt; {
   return table
 }
 &nbsp;
-exports.handleSearchIndexes = async (appId, table) =&gt; {
-  const db = new CouchDB(appId)
+exports.handleSearchIndexes = async table =&gt; {
+  const db = getAppDB()
   // create relevant search indexes
   if (table.indexes &amp;&amp; table.indexes.length &gt; 0) {
     const currentIndexes = await db.getIndexes()
@@ -1127,12 +1104,9 @@ exports.checkStaticTables = table =&gt; {
 }
 &nbsp;
 class TableSaveFunctions {
-  constructor({ db, ctx, oldTable, dataImport }) {
-    this.db = db
-    this.ctx = ctx
-    if (this.ctx &amp;&amp; this.ctx.user) {
-      this.appId = this.ctx.appId
-    }
+  constructor({ user, oldTable, dataImport }) {
+    this.db = getAppDB()
+    this.user = user
     this.oldTable = oldTable
     this.dataImport = dataImport
     // any rows that need updated
@@ -1150,25 +1124,15 @@ class TableSaveFunctions {
 &nbsp;
   // when confirmed valid
   async mid(table) {
-    let response = await exports.checkForColumnUpdates(
-      this.appId,
-      this.db,
-      this.oldTable,
-      table
-    )
+    let response = await exports.checkForColumnUpdates(this.oldTable, table)
     this.rows = this.rows.concat(response.rows)
     return table
   }
 &nbsp;
   // after saving
   async after(table) {
-    table = await exports.handleSearchIndexes(this.appId, table)
-    table = await exports.handleDataImport(
-      this.appId,
-      this.ctx.user,
-      table,
-      this.dataImport
-    )
+    table = await exports.handleSearchIndexes(table)
+    table = await exports.handleDataImport(this.user, table, this.dataImport)
     return table
   }
 &nbsp;
@@ -1177,8 +1141,8 @@ class TableSaveFunctions {
   }
 }
 &nbsp;
-exports.getAllInternalTables = async appId =&gt; {
-  const db = new CouchDB(appId)
+exports.getAllInternalTables = async () =&gt; {
+  const db = getAppDB()
   const internalTables = await db.allDocs(
     getTableParams(null, {
       include_docs: true,
@@ -1191,8 +1155,8 @@ exports.getAllInternalTables = async appId =&gt; {
   }))
 }
 &nbsp;
-exports.getAllExternalTables = <span class="fstat-no" title="function not covered" >as</span>ync (appId, datasourceId) =&gt; {
-  const db = <span class="cstat-no" title="statement not covered" >new CouchDB(appId)</span>
+exports.getAllExternalTables = <span class="fstat-no" title="function not covered" >as</span>ync datasourceId =&gt; {
+  const db = <span class="cstat-no" title="statement not covered" >getAppDB()</span>
   const datasource = <span class="cstat-no" title="statement not covered" >await db.get(datasourceId)</span>
 <span class="cstat-no" title="statement not covered" >  if (!datasource || !datasource.entities) {</span>
 <span class="cstat-no" title="statement not covered" >    throw "Datasource is not configured fully."</span>
@@ -1200,25 +1164,25 @@ exports.getAllExternalTables = <span class="fstat-no" title="function not covere
 <span class="cstat-no" title="statement not covered" >  return datasource.entities</span>
 }
 &nbsp;
-exports.getExternalTable = <span class="fstat-no" title="function not covered" >as</span>ync (appId, datasourceId, tableName) =&gt; {
-  const entities = <span class="cstat-no" title="statement not covered" >await exports.getAllExternalTables(appId, datasourceId)</span>
+exports.getExternalTable = <span class="fstat-no" title="function not covered" >as</span>ync (datasourceId, tableName) =&gt; {
+  const entities = <span class="cstat-no" title="statement not covered" >await exports.getAllExternalTables(datasourceId)</span>
 <span class="cstat-no" title="statement not covered" >  return entities[tableName]</span>
 }
 &nbsp;
-exports.getTable = async (appId, tableId) =&gt; {
-  const db = new CouchDB(appId)
+exports.getTable = async tableId =&gt; {
+  const db = getAppDB()
   <span class="missing-if-branch" title="if path not taken" >I</span>if (isExternalTable(tableId)) {
     let { datasourceId, tableName } = <span class="cstat-no" title="statement not covered" >breakExternalTableId(tableId)</span>
     const datasource = <span class="cstat-no" title="statement not covered" >await db.get(datasourceId)</span>
-    const table = <span class="cstat-no" title="statement not covered" >await exports.getExternalTable(appId, datasourceId, tableName)</span>
+    const table = <span class="cstat-no" title="statement not covered" >await exports.getExternalTable(datasourceId, tableName)</span>
 <span class="cstat-no" title="statement not covered" >    return { ...table, sql: isSQL(datasource) }</span>
   } else {
     return db.get(tableId)
   }
 }
 &nbsp;
-exports.checkForViewUpdates = async (db, table, rename, deletedColumns) =&gt; {
-  const views = await getViews(db)
+exports.checkForViewUpdates = async (table, rename, deletedColumns) =&gt; {
+  const views = await getViews()
   const tableViews = views.filter(<span class="fstat-no" title="function not covered" >vi</span>ew =&gt; <span class="cstat-no" title="statement not covered" >view.meta.tableId === table._id)</span>
 &nbsp;
   // Check each table view to see if impacted by this table action
@@ -1280,7 +1244,7 @@ exports.checkForViewUpdates = async (db, table, rename, deletedColumns) =&gt; {
     // Update view if required
 <span class="cstat-no" title="statement not covered" >    if (needsUpdated) {</span>
       const newViewTemplate = <span class="cstat-no" title="statement not covered" >viewTemplate(view.meta)</span>
-<span class="cstat-no" title="statement not covered" >      await saveView(db, null, view.name, newViewTemplate)</span>
+<span class="cstat-no" title="statement not covered" >      await saveView(null, view.name, newViewTemplate)</span>
 <span class="cstat-no" title="statement not covered" >      if (!newViewTemplate.meta.schema) {</span>
 <span class="cstat-no" title="statement not covered" >        newViewTemplate.meta.schema = table.schema</span>
       }
@@ -1351,7 +1315,7 @@ exports.TableSaveFunctions = TableSaveFunctions
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Mon Jan 31 2022 19:12:04 GMT+0000 (Coordinated Universal Time)
+                at Wed Feb 02 2022 10:59:03 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../../prettify.js"></script>

package/coverage/lcov-report/api/controllers/templates.js.html

@@ -181,7 +181,7 @@ exports.downloadTemplate = async function (ctx) {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Mon Jan 31 2022 19:12:04 GMT+0000 (Coordinated Universal Time)
+                at Wed Feb 02 2022 10:59:03 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../prettify.js"></script>