@budibase/server 1.0.220-alpha.2 → 1.0.220-alpha.3

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@budibase/server",
   "email": "hi@budibase.com",
-  "version": "1.0.220-alpha.2",
+  "version": "1.0.220-alpha.3",
   "description": "Budibase Web Server",
   "main": "src/index.ts",
   "repository": {
@@ -77,10 +77,10 @@
   "license": "GPL-3.0",
   "dependencies": {
     "@apidevtools/swagger-parser": "10.0.3",
-    "@budibase/backend-core": "^1.0.220-alpha.2",
-    "@budibase/client": "^1.0.220-alpha.2",
-    "@budibase/pro": "1.0.220-alpha.1",
-    "@budibase/string-templates": "^1.0.220-alpha.2",
+    "@budibase/backend-core": "^1.0.220-alpha.3",
+    "@budibase/client": "^1.0.220-alpha.3",
+    "@budibase/pro": "1.0.220-alpha.2",
+    "@budibase/string-templates": "^1.0.220-alpha.3",
     "@bull-board/api": "3.7.0",
     "@bull-board/koa": "3.9.4",
     "@elastic/elasticsearch": "7.10.0",
@@ -151,7 +151,7 @@
     "@babel/core": "7.17.4",
     "@babel/preset-env": "7.16.11",
     "@budibase/standard-components": "^0.9.139",
-    "@budibase/types": "^1.0.220-alpha.2",
+    "@budibase/types": "^1.0.220-alpha.3",
     "@jest/test-sequencer": "24.9.0",
     "@types/apidoc": "0.50.0",
     "@types/bson": "4.2.0",
@@ -195,5 +195,5 @@
   "optionalDependencies": {
     "oracledb": "5.3.0"
   },
-  "gitHead": "80b7a2da2fba39ff25622873c95598fa931ea6ed"
+  "gitHead": "52fce58f07a3a1c6fba0d7861ca3a868b4ee5325"
 }

package/src/api/controllers/application.ts

@@ -276,16 +276,26 @@ const performAppCreate = async (ctx: any) => {
     updatedAt: new Date().toISOString(),
     createdAt: new Date().toISOString(),
     status: AppStatus.DEV,
+    navigation: {
+      navigation: "Top",
+      title: name,
+      navWidth: "Large",
+      navBackground: "var(--spectrum-global-color-gray-100)",
+      links: [
+        {
+          url: "/home",
+          text: "Home",
+        },
+      ],
+    },
+    theme: "spectrum--light",
+    customTheme: {
+      buttonBorderRadius: "16px",
+    },
   }
   const response = await db.put(newApplication, { force: true })
   newApplication._rev = response.rev
 
-  // Only create the default home screens and layout if we aren't importing
-  // an app
-  if (useTemplate !== "true") {
-    await createEmptyAppPackage(ctx, newApplication)
-  }
-
   /* istanbul ignore next */
   if (!env.isTest()) {
     await createApp(appId)
@@ -565,15 +575,3 @@ const updateAppPackage = async (appPackage: any, appId: any) => {
     return newAppPackage
   })
 }
-
-const createEmptyAppPackage = async (ctx: any, app: any) => {
-  const db = getAppDB()
-
-  let screensAndLayouts = []
-  for (let layout of BASE_LAYOUTS) {
-    const cloned = cloneDeep(layout)
-    screensAndLayouts.push(await processObject(cloned, app))
-  }
-
-  await db.bulkDocs(screensAndLayouts)
-}

package/src/api/controllers/layout.js

@@ -1,7 +1,4 @@
-const {
-  EMPTY_LAYOUT,
-  BASE_LAYOUT_PROP_IDS,
-} = require("../../constants/layouts")
+const { EMPTY_LAYOUT } = require("../../constants/layouts")
 const { generateLayoutID, getScreenParams } = require("../../db/utils")
 const { getAppDB } = require("@budibase/backend-core/context")
 const { events } = require("@budibase/backend-core")
@@ -32,19 +29,15 @@ exports.destroy = async function (ctx) {
   const layoutId = ctx.params.layoutId,
     layoutRev = ctx.params.layoutRev
 
-  if (Object.values(BASE_LAYOUT_PROP_IDS).includes(layoutId)) {
-    ctx.throw(400, "Cannot delete a built-in layout")
-  } else {
-    const layoutsUsedByScreens = (
-      await db.allDocs(
-        getScreenParams(null, {
-          include_docs: true,
-        })
-      )
-    ).rows.map(element => element.doc.layoutId)
-    if (layoutsUsedByScreens.includes(layoutId)) {
-      ctx.throw(400, "Cannot delete a layout that's being used by a screen")
-    }
+  const layoutsUsedByScreens = (
+    await db.allDocs(
+      getScreenParams(null, {
+        include_docs: true,
+      })
+    )
+  ).rows.map(element => element.doc.layoutId)
+  if (layoutsUsedByScreens.includes(layoutId)) {
+    ctx.throw(400, "Cannot delete a layout that's being used by a screen")
   }
 
   await db.remove(layoutId, layoutRev)

package/src/api/routes/tests/application.spec.js

@@ -59,14 +59,13 @@ describe("/applications", () => {
       expect(events.app.templateImported).toBeCalledTimes(1)
     })
 
-
     it("creates app from file", async () => {
       const res = await request
         .post("/api/applications")
         .field("name", "My App")
         .field("useTemplate", "true")
         .set(config.defaultHeaders())
-        .attach('templateFile', 'src/api/routes/tests/data/export.txt')
+        .attach("templateFile", "src/api/routes/tests/data/export.txt")
         .expect("Content-Type", /json/)
         .expect(200)
       expect(res.body._id).toBeDefined()
@@ -107,8 +106,7 @@ describe("/applications", () => {
         .set(config.defaultHeaders())
         .expect("Content-Type", /json/)
         .expect(200)
-      // should have empty packages
-      expect(res.body.layouts.length).toEqual(2)
+      expect(res.body.libraries.length).toEqual(1)
     })
   })
 
@@ -120,7 +118,7 @@ describe("/applications", () => {
         .expect("Content-Type", /json/)
         .expect(200)
       expect(res.body.application).toBeDefined()
-      expect(res.body.layouts.length).toEqual(2)
+      expect(res.body.application.appId).toEqual(config.getAppId())
     })
   })
 
@@ -171,7 +169,7 @@ describe("/applications", () => {
         .set(config.defaultHeaders())
         .expect("Content-Type", /json/)
         .expect(200)
-        expect(events.app.versionUpdated).toBeCalledTimes(1)
+      expect(events.app.versionUpdated).toBeCalledTimes(1)
     })
     it("should be able to revert the app client library version", async () => {
       // We need to first update the version so that we can then revert
@@ -185,7 +183,7 @@ describe("/applications", () => {
         .set(config.defaultHeaders())
         .expect("Content-Type", /json/)
         .expect(200)
-        expect(events.app.versionReverted).toBeCalledTimes(1)
+      expect(events.app.versionReverted).toBeCalledTimes(1)
     })
   })
 

package/src/api/routes/utils/validators.js

@@ -9,6 +9,7 @@ const Joi = require("joi")
 
 const OPTIONAL_STRING = Joi.string().optional().allow(null).allow("")
 const OPTIONAL_NUMBER = Joi.number().optional().allow(null)
+const OPTIONAL_BOOLEAN = Joi.boolean().optional().allow(null)
 
 exports.tableValidator = () => {
   // prettier-ignore
@@ -160,9 +161,12 @@ exports.screenValidator = () => {
   // prettier-ignore
   return joiValidator.body(Joi.object({
     name: Joi.string().required(),
+    showNavigation: OPTIONAL_BOOLEAN,
+    width: OPTIONAL_STRING,
     routing: Joi.object({
       route: Joi.string().required(),
       roleId: Joi.string().required().allow(""),
+      homeScreen: OPTIONAL_BOOLEAN,
     }).required().unknown(true),
     props: Joi.object({
       _id: Joi.string().required(),

package/src/middleware/currentapp.js

@@ -74,6 +74,10 @@ module.exports = async (ctx, next) => {
       try {
         await getRole(roleHeader)
         roleId = roleHeader
+
+        // Delete admin and builder flags so that the specified role is honoured
+        delete ctx.user.builder
+        delete ctx.user.admin
       } catch (error) {
         // Swallow error and do nothing
       }