@budibase/server 0.9.185-alpha.0 → 0.9.185-alpha.12

package/coverage/lcov-report/api/controllers/table/index.js.html

@@ -23,30 +23,30 @@
         <div class='clearfix'>
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">91.3% </span>
+                <span class="strong">81.81% </span>
                 <span class="quiet">Statements</span>
-                <span class='fraction'>42/46</span>
+                <span class='fraction'>45/55</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">78.95% </span>
+                <span class="strong">73.91% </span>
                 <span class="quiet">Branches</span>
-                <span class='fraction'>15/19</span>
+                <span class='fraction'>17/23</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">77.78% </span>
+                <span class="strong">70% </span>
                 <span class="quiet">Functions</span>
-                <span class='fraction'>7/9</span>
+                <span class='fraction'>7/10</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">93.18% </span>
+                <span class="strong">83.01% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>41/44</span>
+                <span class='fraction'>44/53</span>
             </div>
         
             
@@ -145,7 +145,25 @@
 <a name='L86'></a><a href='#L86'>86</a>
 <a name='L87'></a><a href='#L87'>87</a>
 <a name='L88'></a><a href='#L88'>88</a>
-<a name='L89'></a><a href='#L89'>89</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">34x</span>
+<a name='L89'></a><a href='#L89'>89</a>
+<a name='L90'></a><a href='#L90'>90</a>
+<a name='L91'></a><a href='#L91'>91</a>
+<a name='L92'></a><a href='#L92'>92</a>
+<a name='L93'></a><a href='#L93'>93</a>
+<a name='L94'></a><a href='#L94'>94</a>
+<a name='L95'></a><a href='#L95'>95</a>
+<a name='L96'></a><a href='#L96'>96</a>
+<a name='L97'></a><a href='#L97'>97</a>
+<a name='L98'></a><a href='#L98'>98</a>
+<a name='L99'></a><a href='#L99'>99</a>
+<a name='L100'></a><a href='#L100'>100</a>
+<a name='L101'></a><a href='#L101'>101</a>
+<a name='L102'></a><a href='#L102'>102</a>
+<a name='L103'></a><a href='#L103'>103</a>
+<a name='L104'></a><a href='#L104'>104</a>
+<a name='L105'></a><a href='#L105'>105</a>
+<a name='L106'></a><a href='#L106'>106</a>
+<a name='L107'></a><a href='#L107'>107</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-yes">34x</span>
@@ -229,9 +247,27 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">34x</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">34x</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1x</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">1x</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">const CouchDB = require("../../../db")
 const internal = require("./internal")
@@ -316,9 +352,27 @@ exports.destroy = async function (ctx) {
   ctx.body = { message: `Table ${tableId} deleted.` }
 }
 &nbsp;
+exports.bulkImport = <span class="fstat-no" title="function not covered" >as</span>ync function (ctx) {
+  const tableId = <span class="cstat-no" title="statement not covered" >ctx.params.tableId</span>
+<span class="cstat-no" title="statement not covered" >  await pickApi({ tableId }).bulkImport(ctx)</span>
+  // right now we don't trigger anything for bulk import because it
+  // can only be done in the builder, but in the future we may need to
+  // think about events for bulk items
+<span class="cstat-no" title="statement not covered" >  ctx.status = 200</span>
+<span class="cstat-no" title="statement not covered" >  ctx.body = { message: `Bulk rows created.` }</span>
+}
+&nbsp;
 exports.validateCSVSchema = async function (ctx) {
-  const { csvString, schema = {} } = ctx.request.body
-  const result = await csvParser.parse(csvString, schema)
+  // tableId being specified means its an import to an existing table
+  const { csvString, schema = {}, tableId } = ctx.request.body
+  let existingTable
+  <span class="missing-if-branch" title="if path not taken" >I</span>if (tableId) {
+<span class="cstat-no" title="statement not covered" >    existingTable = await getTable(ctx.appId, tableId)</span>
+  }
+  let result = await csvParser.parse(csvString, schema)
+  <span class="missing-if-branch" title="if path not taken" >I</span>if (existingTable) {
+<span class="cstat-no" title="statement not covered" >    result = csvParser.updateSchema({ schema: result, existingTable })</span>
+  }
   ctx.body = { schema: result }
 }
 &nbsp;</pre></td></tr></table></pre>
@@ -328,7 +382,7 @@ exports.validateCSVSchema = async function (ctx) {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Thu Nov 11 2021 13:56:13 GMT+0000 (Coordinated Universal Time)
+                at Mon Nov 22 2021 10:51:12 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../../prettify.js"></script>

package/coverage/lcov-report/api/controllers/table/internal.js.html

@@ -23,9 +23,9 @@
         <div class='clearfix'>
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">80% </span>
+                <span class="strong">74.24% </span>
                 <span class="quiet">Statements</span>
-                <span class='fraction'>48/60</span>
+                <span class='fraction'>49/66</span>
             </div>
         
             
@@ -37,16 +37,16 @@
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">75% </span>
+                <span class="strong">60% </span>
                 <span class="quiet">Functions</span>
-                <span class='fraction'>3/4</span>
+                <span class='fraction'>3/5</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">84.21% </span>
+                <span class="strong">77.77% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>48/57</span>
+                <span class='fraction'>49/63</span>
             </div>
         
             
@@ -55,7 +55,7 @@
             Press <em>n</em> or <em>j</em> to go to the next uncovered block, <em>b</em>, <em>p</em> or <em>k</em> for the previous block.
         </p>
     </div>
-    <div class='status-line high'></div>
+    <div class='status-line medium'></div>
     <pre><table class="coverage">
 <tr><td class="line-count quiet"><a name='L1'></a><a href='#L1'>1</a>
 <a name='L2'></a><a href='#L2'>2</a>
@@ -199,10 +199,28 @@
 <a name='L140'></a><a href='#L140'>140</a>
 <a name='L141'></a><a href='#L141'>141</a>
 <a name='L142'></a><a href='#L142'>142</a>
-<a name='L143'></a><a href='#L143'>143</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">34x</span>
+<a name='L143'></a><a href='#L143'>143</a>
+<a name='L144'></a><a href='#L144'>144</a>
+<a name='L145'></a><a href='#L145'>145</a>
+<a name='L146'></a><a href='#L146'>146</a>
+<a name='L147'></a><a href='#L147'>147</a>
+<a name='L148'></a><a href='#L148'>148</a>
+<a name='L149'></a><a href='#L149'>149</a>
+<a name='L150'></a><a href='#L150'>150</a>
+<a name='L151'></a><a href='#L151'>151</a>
+<a name='L152'></a><a href='#L152'>152</a>
+<a name='L153'></a><a href='#L153'>153</a>
+<a name='L154'></a><a href='#L154'>154</a>
+<a name='L155'></a><a href='#L155'>155</a>
+<a name='L156'></a><a href='#L156'>156</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-yes">34x</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">34x</span>
@@ -341,11 +359,24 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">2x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">34x</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">const CouchDB = require("../../../db")
 const linkRows = require("../../../db/linkedRows")
 const { getRowParams, generateTableID } = require("../../../db/utils")
 const { FieldTypes } = require("../../../constants")
-const { TableSaveFunctions, hasTypeChanged } = require("./utils")
+const {
+  TableSaveFunctions,
+  hasTypeChanged,
+  getTable,
+  handleDataImport,
+} = require("./utils")
 &nbsp;
 exports.save = async function (ctx) {
   const appId = ctx.appId
@@ -483,6 +514,14 @@ exports.destroy = async function (ctx) {
 &nbsp;
   return tableToDelete
 }
+&nbsp;
+exports.bulkImport = <span class="fstat-no" title="function not covered" >as</span>ync function (ctx) {
+  const appId = <span class="cstat-no" title="statement not covered" >ctx.appId</span>
+  const table = <span class="cstat-no" title="statement not covered" >await getTable(appId, ctx.params.tableId)</span>
+  const { dataImport } = <span class="cstat-no" title="statement not covered" >ctx.request.body</span>
+<span class="cstat-no" title="statement not covered" >  await handleDataImport(appId, ctx.user, table, dataImport)</span>
+<span class="cstat-no" title="statement not covered" >  return table</span>
+}
 &nbsp;</pre></td></tr></table></pre>
 
                 <div class='push'></div><!-- for sticky footer -->
@@ -490,7 +529,7 @@ exports.destroy = async function (ctx) {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Thu Nov 11 2021 13:56:13 GMT+0000 (Coordinated Universal Time)
+                at Mon Nov 22 2021 10:51:12 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../../prettify.js"></script>

package/coverage/lcov-report/api/controllers/table/utils.js.html

@@ -23,14 +23,14 @@
         <div class='clearfix'>
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">66.67% </span>
+                <span class="strong">66.85% </span>
                 <span class="quiet">Statements</span>
-                <span class='fraction'>116/174</span>
+                <span class='fraction'>117/175</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">45.56% </span>
+                <span class="strong">45.55% </span>
                 <span class="quiet">Branches</span>
                 <span class='fraction'>41/90</span>
             </div>
@@ -44,9 +44,9 @@
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">67.25% </span>
+                <span class="strong">67.44% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>115/171</span>
+                <span class='fraction'>116/172</span>
             </div>
         
             
@@ -412,7 +412,11 @@
 <a name='L353'></a><a href='#L353'>353</a>
 <a name='L354'></a><a href='#L354'>354</a>
 <a name='L355'></a><a href='#L355'>355</a>
-<a name='L356'></a><a href='#L356'>356</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">34x</span>
+<a name='L356'></a><a href='#L356'>356</a>
+<a name='L357'></a><a href='#L357'>357</a>
+<a name='L358'></a><a href='#L358'>358</a>
+<a name='L359'></a><a href='#L359'>359</a>
+<a name='L360'></a><a href='#L360'>360</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -487,11 +491,16 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-yes">100x</span>
-<span class="cline-any cline-yes">100x</span>
+<span class="cline-any cline-yes">99x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">1x</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
@@ -522,8 +531,7 @@
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-yes">1x</span>
-<span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-yes">100x</span>
+<span class="cline-any cline-yes">1x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">34x</span>
@@ -803,10 +811,10 @@ exports.checkForColumnUpdates = async (db, oldTable, updatedTable) =&gt; {
       })
     )
     updatedRows = rows.rows.map(({ doc }) =&gt; {
-      <span class="missing-if-branch" title="else path not taken" >E</span>if (rename) {
+      if (rename) {
         doc[rename.updated] = doc[rename.old]
         delete doc[rename.old]
-      } else <span class="cstat-no" title="statement not covered" >if (deletedColumns.length !== 0) {</span>
+      } else <span class="cstat-no" title="statement not covered" ><span class="missing-if-branch" title="else path not taken" >E</span>if (deletedColumns.length !== 0) {</span>
 <span class="cstat-no" title="statement not covered" >        deletedColumns.forEach(<span class="fstat-no" title="function not covered" >co</span>lName =&gt; <span class="cstat-no" title="statement not covered" >delete doc[colName])</span></span>
       }
       return doc
@@ -841,43 +849,47 @@ exports.makeSureTableUpToDate = (table, tableToSave) =&gt; {
 }
 &nbsp;
 exports.handleDataImport = async (appId, user, table, dataImport) =&gt; {
+  if (!dataImport || !dataImport.csvString) {
+    return table
+  }
   const db = new CouchDB(appId)
-  if (dataImport &amp;&amp; dataImport.csvString) {
-    // Populate the table with rows imported from CSV in a bulk update
-    const data = await csvParser.transform(dataImport)
+  // Populate the table with rows imported from CSV in a bulk update
+  const data = await csvParser.transform({
+    ...dataImport,
+    existingTable: table,
+  })
 &nbsp;
-    let finalData = []
-    for (let i = 0; i &lt; data.length; i++) {
-      let row = data[i]
-      row._id = generateRowID(table._id)
-      row.tableId = table._id
-      const processed = inputProcessing(user, table, row, {
-        noAutoRelationships: true,
-      })
-      table = processed.table
-      row = processed.row
+  let finalData = []
+  for (let i = 0; i &lt; data.length; i++) {
+    let row = data[i]
+    row._id = generateRowID(table._id)
+    row.tableId = table._id
+    const processed = inputProcessing(user, table, row, {
+      noAutoRelationships: true,
+    })
+    table = processed.table
+    row = processed.row
 &nbsp;
-      for (let [fieldName, schema] of Object.entries(table.schema)) {
-        // check whether the options need to be updated for inclusion as part of the data import
-        <span class="missing-if-branch" title="if path not taken" >I</span>if (
-          schema.type === FieldTypes.OPTIONS &amp;&amp;
-          (<span class="branch-1 cbranch-no" title="branch not covered" >!schema.constraints.inclusion </span>||
-<span class="branch-2 cbranch-no" title="branch not covered" >            schema.constraints.inclusion.indexOf(row[fieldName]) === -1)</span>
-        ) {
-<span class="cstat-no" title="statement not covered" >          schema.constraints.inclusion = [</span>
-            ...schema.constraints.inclusion,
-            row[fieldName],
-          ]
-        }
+    for (let [fieldName, schema] of Object.entries(table.schema)) {
+      // check whether the options need to be updated for inclusion as part of the data import
+      <span class="missing-if-branch" title="if path not taken" >I</span>if (
+        schema.type === FieldTypes.OPTIONS &amp;&amp;
+        (<span class="branch-1 cbranch-no" title="branch not covered" >!schema.constraints.inclusion </span>||
+<span class="branch-2 cbranch-no" title="branch not covered" >          schema.constraints.inclusion.indexOf(row[fieldName]) === -1)</span>
+      ) {
+<span class="cstat-no" title="statement not covered" >        schema.constraints.inclusion = [</span>
+          ...schema.constraints.inclusion,
+          row[fieldName],
+        ]
       }
-&nbsp;
-      finalData.push(row)
     }
 &nbsp;
-    await db.bulkDocs(finalData)
-    let response = await db.put(table)
-    table._rev = response._rev
+    finalData.push(row)
   }
+&nbsp;
+  await db.bulkDocs(finalData)
+  let response = await db.put(table)
+  table._rev = response._rev
   return table
 }
 &nbsp;
@@ -898,7 +910,7 @@ exports.handleSearchIndexes = async (appId, table) =&gt; {
       )
 &nbsp;
       // if index fields have changed, delete the original index
-      <span class="missing-if-branch" title="else path not taken" >E</span>if (!isEqual(currentFields, table.indexes)) {
+      if (!isEqual(currentFields, table.indexes)) {
         await db.deleteIndex(existingIndex)
         // create/recreate the index with fields
         await db.createIndex({
@@ -930,7 +942,7 @@ exports.checkStaticTables = table =&gt; {
   if (table._id === InternalTables.USER_METADATA) {
     for (let [key, schema] of Object.entries(USERS_TABLE_SCHEMA.schema)) {
       // check if the schema exists on the table to be created/updated
-      <span class="missing-if-branch" title="else path not taken" >E</span>if (table.schema[key] == null) {
+      if (table.schema[key] == null) {
         table.schema[key] = schema
       }
     }
@@ -942,7 +954,7 @@ class TableSaveFunctions {
   constructor({ db, ctx, oldTable, dataImport }) {
     this.db = db
     this.ctx = ctx
-    <span class="missing-if-branch" title="else path not taken" >E</span>if (this.ctx &amp;&amp; this.ctx.user) {
+    if (this.ctx &amp;&amp; this.ctx.user) {
       this.appId = this.ctx.appId
     }
     this.oldTable = oldTable
@@ -1129,7 +1141,7 @@ exports.TableSaveFunctions = TableSaveFunctions
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Thu Nov 11 2021 13:56:13 GMT+0000 (Coordinated Universal Time)
+                at Mon Nov 22 2021 10:51:12 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../../prettify.js"></script>

package/coverage/lcov-report/api/controllers/templates.js.html

@@ -30,7 +30,7 @@
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">71.43% </span>
+                <span class="strong">71.42% </span>
                 <span class="quiet">Branches</span>
                 <span class='fraction'>5/7</span>
             </div>
@@ -155,10 +155,10 @@ exports.fetch = async function (ctx) {
 <span class="cstat-no" title="statement not covered" >    error = true</span>
   }
   // if there is an error, simply return no templates
-  <span class="missing-if-branch" title="else path not taken" >E</span>if (!error &amp;&amp; response) {
+  if (!error &amp;&amp; response) {
     const json = await response.json()
     ctx.body = Object.values(json.templates[type])
-  } else {
+  } else <span class="missing-if-branch" title="else path not taken" >E</span>{
 <span class="cstat-no" title="statement not covered" >    ctx.body = []</span>
   }
 }
@@ -181,7 +181,7 @@ exports.downloadTemplate = async function (ctx) {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Thu Nov 11 2021 13:56:13 GMT+0000 (Coordinated Universal Time)
+                at Mon Nov 22 2021 10:51:12 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../prettify.js"></script>

package/coverage/lcov-report/api/controllers/user.js.html

@@ -23,16 +23,16 @@
         <div class='clearfix'>
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">38.14% </span>
+                <span class="strong">37.37% </span>
                 <span class="quiet">Statements</span>
-                <span class='fraction'>37/97</span>
+                <span class='fraction'>37/99</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
                 <span class="strong">0% </span>
                 <span class="quiet">Branches</span>
-                <span class='fraction'>0/27</span>
+                <span class='fraction'>0/31</span>
             </div>
         
             
@@ -44,9 +44,9 @@
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">38.54% </span>
+                <span class="strong">37.75% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>37/96</span>
+                <span class='fraction'>37/98</span>
             </div>
         
             
@@ -249,7 +249,12 @@
 <a name='L190'></a><a href='#L190'>190</a>
 <a name='L191'></a><a href='#L191'>191</a>
 <a name='L192'></a><a href='#L192'>192</a>
-<a name='L193'></a><a href='#L193'>193</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">34x</span>
+<a name='L193'></a><a href='#L193'>193</a>
+<a name='L194'></a><a href='#L194'>194</a>
+<a name='L195'></a><a href='#L195'>195</a>
+<a name='L196'></a><a href='#L196'>196</a>
+<a name='L197'></a><a href='#L197'>197</a>
+<a name='L198'></a><a href='#L198'>198</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
@@ -352,6 +357,7 @@
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
@@ -370,13 +376,17 @@
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
-<span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
@@ -540,6 +550,7 @@ exports.syncUser = <span class="fstat-no" title="function not covered" >as</span
       .map(<span class="fstat-no" title="function not covered" >([</span>appId]) =&gt; <span class="cstat-no" title="statement not covered" >appId)</span>
   }
 <span class="cstat-no" title="statement not covered" >  for (let prodAppId of prodAppIds) {</span>
+    const roleId = <span class="cstat-no" title="statement not covered" >roles[prodAppId]</span>
     const devAppId = <span class="cstat-no" title="statement not covered" >getDevelopmentAppID(prodAppId)</span>
 <span class="cstat-no" title="statement not covered" >    for (let appId of [prodAppId, devAppId]) {</span>
 <span class="cstat-no" title="statement not covered" >      if (!(await doesDatabaseExist(appId))) {</span>
@@ -558,17 +569,21 @@ exports.syncUser = <span class="fstat-no" title="function not covered" >as</span
           tableId: InternalTables.USER_METADATA,
         }
       }
-      let combined
-<span class="cstat-no" title="statement not covered" >      if (deleting) {</span>
-<span class="cstat-no" title="statement not covered" >        combined = {</span>
-          ...metadata,
-          status: UserStatus.INACTIVE,
-          metadata: BUILTIN_ROLE_IDS.PUBLIC,
-        }
-      } else {
-<span class="cstat-no" title="statement not covered" >        combined = combineMetadataAndUser(user, metadata)</span>
+      // assign the roleId for the metadata doc
+<span class="cstat-no" title="statement not covered" >      if (roleId) {</span>
+<span class="cstat-no" title="statement not covered" >        metadata.roleId = roleId</span>
+      }
+      let combined = <span class="cstat-no" title="statement not covered" >!deleting</span>
+        ? combineMetadataAndUser(user, metadata)
+        : {
+            ...metadata,
+            status: UserStatus.INACTIVE,
+            metadata: BUILTIN_ROLE_IDS.PUBLIC,
+          }
+      // if its null then there was no updates required
+<span class="cstat-no" title="statement not covered" >      if (combined) {</span>
+<span class="cstat-no" title="statement not covered" >        await db.put(combined)</span>
       }
-<span class="cstat-no" title="statement not covered" >      await db.put(combined)</span>
     }
   }
 <span class="cstat-no" title="statement not covered" >  ctx.body = {</span>
@@ -640,7 +655,7 @@ exports.findMetadata = async function (ctx) {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Thu Nov 11 2021 13:56:13 GMT+0000 (Coordinated Universal Time)
+                at Mon Nov 22 2021 10:51:12 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../prettify.js"></script>

package/coverage/lcov-report/api/controllers/view/exporters.js.html

@@ -118,7 +118,7 @@ exports.json = function (headers, rows) {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Thu Nov 11 2021 13:56:13 GMT+0000 (Coordinated Universal Time)
+                at Mon Nov 22 2021 10:51:12 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../../prettify.js"></script>