@budibase/server 0.9.167-alpha.0 → 0.9.167-alpha.12

package/dist/api/controllers/dev.js

@@ -16,11 +16,11 @@ const { request } = require("../../utilities/workerRequests");
 const { clearLock } = require("../../utilities/redis");
 const { Replication } = require("@budibase/auth").db;
 const { DocumentTypes } = require("../../db/utils");
-function redirect(ctx, method) {
+function redirect(ctx, method, path = "global") {
     return __awaiter(this, void 0, void 0, function* () {
         const { devPath } = ctx.params;
         const queryString = ctx.originalUrl.split("?")[1] || "";
-        const response = yield fetch(checkSlashesInUrl(`${env.WORKER_URL}/api/global/${devPath}?${queryString}`), request(ctx, {
+        const response = yield fetch(checkSlashesInUrl(`${env.WORKER_URL}/api/${path}/${devPath}?${queryString}`), request(ctx, {
             method,
             body: ctx.request.body,
         }, true));
@@ -45,15 +45,21 @@ function redirect(ctx, method) {
         ctx.cookies;
     });
 }
-exports.redirectGet = (ctx) => __awaiter(void 0, void 0, void 0, function* () {
-    yield redirect(ctx, "GET");
-});
-exports.redirectPost = (ctx) => __awaiter(void 0, void 0, void 0, function* () {
-    yield redirect(ctx, "POST");
-});
-exports.redirectDelete = (ctx) => __awaiter(void 0, void 0, void 0, function* () {
-    yield redirect(ctx, "DELETE");
-});
+exports.buildRedirectGet = path => {
+    return (ctx) => __awaiter(void 0, void 0, void 0, function* () {
+        yield redirect(ctx, "GET", path);
+    });
+};
+exports.buildRedirectPost = path => {
+    return (ctx) => __awaiter(void 0, void 0, void 0, function* () {
+        yield redirect(ctx, "POST", path);
+    });
+};
+exports.buildRedirectDelete = path => {
+    return (ctx) => __awaiter(void 0, void 0, void 0, function* () {
+        yield redirect(ctx, "DELETE", path);
+    });
+};
 exports.clearLock = (ctx) => __awaiter(void 0, void 0, void 0, function* () {
     const { appId } = ctx.params;
     try {

package/dist/api/controllers/query.js

@@ -14,6 +14,7 @@ const { generateQueryID, getQueryParams } = require("../../db/utils");
 const { integrations } = require("../../integrations");
 const { BaseQueryVerbs } = require("../../constants");
 const env = require("../../environment");
+const ScriptRunner = require("../../utilities/scriptRunner");
 // simple function to append "readable" to all read queries
 function enrichQueries(input) {
     const wasArray = Array.isArray(input);
@@ -35,11 +36,29 @@ function formatResponse(resp) {
             resp = { response: resp };
         }
     }
-    if (!Array.isArray(resp)) {
-        resp = [resp];
-    }
     return resp;
 }
+function runAndTransform(integration, queryVerb, enrichedQuery, transformer) {
+    return __awaiter(this, void 0, void 0, function* () {
+        let rows = formatResponse(yield integration[queryVerb](enrichedQuery));
+        // transform as required
+        if (transformer) {
+            const runner = new ScriptRunner(transformer, { data: rows });
+            rows = runner.execute();
+        }
+        // needs to an array for next step
+        if (!Array.isArray(rows)) {
+            rows = [rows];
+        }
+        // map into JSON if just raw primitive here
+        if (rows.find(row => typeof row !== "object")) {
+            rows = rows.map(value => ({ value }));
+        }
+        // get all the potential fields in the schema
+        let keys = rows.flatMap(Object.keys);
+        return { rows, keys };
+    });
+}
 exports.fetch = function (ctx) {
     return __awaiter(this, void 0, void 0, function* () {
         const db = new CouchDB(ctx.appId);
@@ -119,12 +138,10 @@ exports.preview = function (ctx) {
         if (!Integration) {
             ctx.throw(400, "Integration type does not exist.");
         }
-        const { fields, parameters, queryVerb } = ctx.request.body;
+        const { fields, parameters, queryVerb, transformer } = ctx.request.body;
         const enrichedQuery = yield enrichQueryFields(fields, parameters);
         const integration = new Integration(datasource.config);
-        const rows = formatResponse(yield integration[queryVerb](enrichedQuery));
-        // get all the potential fields in the schema
-        const keys = rows.flatMap(Object.keys);
+        const { rows, keys } = yield runAndTransform(integration, queryVerb, enrichedQuery, transformer);
         ctx.body = {
             rows,
             schemaFields: [...new Set(keys)],
@@ -147,7 +164,8 @@ exports.execute = function (ctx) {
         const enrichedQuery = yield enrichQueryFields(query.fields, ctx.request.body.parameters);
         const integration = new Integration(datasource.config);
         // call the relevant CRUD method on the integration class
-        ctx.body = formatResponse(yield integration[query.queryVerb](enrichedQuery));
+        const { rows } = yield runAndTransform(integration, query.queryVerb, enrichedQuery, query.transformer);
+        ctx.body = rows;
         // cleanup
         if (integration.end) {
             integration.end();

package/dist/api/controllers/script.js

@@ -8,24 +8,12 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
         step((generator = generator.apply(thisArg, _arguments || [])).next());
     });
 };
-const fetch = require("node-fetch");
-const vm = require("vm");
-class ScriptExecutor {
-    constructor(body) {
-        const code = `let fn = () => {\n${body.script}\n}; out = fn();`;
-        this.script = new vm.Script(code);
-        this.context = vm.createContext(body.context);
-        this.context.fetch = fetch;
-    }
-    execute() {
-        this.script.runInContext(this.context);
-        return this.context.out;
-    }
-}
+const ScriptRunner = require("../../utilities/scriptRunner");
 exports.execute = function (ctx) {
     return __awaiter(this, void 0, void 0, function* () {
-        const executor = new ScriptExecutor(ctx.request.body);
-        ctx.body = executor.execute();
+        const { script, context } = ctx.request.body;
+        const runner = new ScriptRunner(script, context);
+        ctx.body = runner.execute();
     });
 };
 exports.save = function (ctx) {

package/dist/api/controllers/table/index.js

@@ -81,6 +81,9 @@ exports.save = function (ctx) {
             for (let propKey of Object.keys(tableToSave.schema)) {
                 let column = tableToSave.schema[propKey];
                 let oldColumn = oldTable.schema[propKey];
+                if (oldColumn && oldColumn.type === "internal") {
+                    oldColumn.type = "auto";
+                }
                 if (oldColumn && oldColumn.type !== column.type) {
                     ctx.throw(400, "Cannot change the type of a column");
                 }

package/dist/api/controllers/table/utils.js

@@ -9,7 +9,6 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 const CouchDB = require("../../../db");
-const linkRows = require("../../../db/linkedRows");
 const csvParser = require("../../../utilities/csvParser");
 const { getRowParams, generateRowID, InternalTables, } = require("../../../db/utils");
 const { isEqual } = require("lodash/fp");
@@ -86,16 +85,9 @@ exports.handleDataImport = (appId, user, table, dataImport) => __awaiter(void 0,
                     ];
                 }
             }
-            // make sure link rows are up to date
-            finalData.push(linkRows.updateLinks({
-                appId,
-                eventType: linkRows.EventType.ROW_SAVE,
-                row,
-                tableId: row.tableId,
-                table,
-            }));
+            finalData.push(row);
         }
-        yield db.bulkDocs(yield Promise.all(finalData));
+        yield db.bulkDocs(finalData);
         let response = yield db.put(table);
         table._rev = response._rev;
     }

package/dist/api/controllers/templates.js

@@ -15,9 +15,24 @@ const DEFAULT_TEMPLATES_BUCKET = "prod-budi-templates.s3-eu-west-1.amazonaws.com
 exports.fetch = function (ctx) {
     return __awaiter(this, void 0, void 0, function* () {
         const { type = "app" } = ctx.query;
-        const response = yield fetch(`https://${DEFAULT_TEMPLATES_BUCKET}/manifest.json`);
-        const json = yield response.json();
-        ctx.body = Object.values(json.templates[type]);
+        let response, error = false;
+        try {
+            response = yield fetch(`https://${DEFAULT_TEMPLATES_BUCKET}/manifest.json`);
+            if (response.status !== 200) {
+                error = true;
+            }
+        }
+        catch (err) {
+            error = true;
+        }
+        // if there is an error, simply return no templates
+        if (!error && response) {
+            const json = yield response.json();
+            ctx.body = Object.values(json.templates[type]);
+        }
+        else {
+            ctx.body = [];
+        }
     });
 };
 // can't currently test this, have to ignore from coverage

package/dist/api/routes/dev.js

@@ -5,11 +5,15 @@ const env = require("../../environment");
 const authorized = require("../../middleware/authorized");
 const { BUILDER } = require("@budibase/auth/permissions");
 const router = Router();
-if (env.isDev() || env.isTest()) {
+function redirectPath(path) {
     router
-        .get("/api/global/:devPath(.*)", controller.redirectGet)
-        .post("/api/global/:devPath(.*)", controller.redirectPost)
-        .delete("/api/global/:devPath(.*)", controller.redirectDelete);
+        .get(`/api/${path}/:devPath(.*)`, controller.buildRedirectGet(path))
+        .post(`/api/${path}/:devPath(.*)`, controller.buildRedirectPost(path))
+        .delete(`/api/${path}/:devPath(.*)`, controller.buildRedirectDelete(path));
+}
+if (env.isDev() || env.isTest()) {
+    redirectPath("global");
+    redirectPath("system");
 }
 router
     .get("/api/dev/version", authorized(BUILDER), controller.getBudibaseVersion)

package/dist/api/routes/query.js

@@ -22,7 +22,8 @@ function generateQueryValidation() {
         })),
         queryVerb: Joi.string().allow().required(),
         extra: Joi.object().optional(),
-        schema: Joi.object({}).required().unknown(true)
+        schema: Joi.object({}).required().unknown(true),
+        transformer: Joi.string().optional(),
     }));
 }
 function generateQueryPreviewValidation() {
@@ -32,6 +33,7 @@ function generateQueryPreviewValidation() {
         queryVerb: Joi.string().allow().required(),
         extra: Joi.object().optional(),
         datasourceId: Joi.string().required(),
+        transformer: Joi.string().optional(),
         parameters: Joi.object({}).required().unknown(true)
     }));
 }

package/dist/automations/actions.js

@@ -13,7 +13,6 @@ const createRow = require("./steps/createRow");
 const updateRow = require("./steps/updateRow");
 const deleteRow = require("./steps/deleteRow");
 const executeScript = require("./steps/executeScript");
-const bash = require("./steps/bash");
 const executeQuery = require("./steps/executeQuery");
 const outgoingWebhook = require("./steps/outgoingWebhook");
 const serverLog = require("./steps/serverLog");
@@ -24,6 +23,7 @@ const integromat = require("./steps/integromat");
 let filter = require("./steps/filter");
 let delay = require("./steps/delay");
 let queryRow = require("./steps/queryRows");
+const env = require("../environment");
 const ACTION_IMPLS = {
     SEND_EMAIL_SMTP: sendSmtpEmail.run,
     CREATE_ROW: createRow.run,
@@ -31,7 +31,6 @@ const ACTION_IMPLS = {
     DELETE_ROW: deleteRow.run,
     OUTGOING_WEBHOOK: outgoingWebhook.run,
     EXECUTE_SCRIPT: executeScript.run,
-    EXECUTE_BASH: bash.run,
     EXECUTE_QUERY: executeQuery.run,
     SERVER_LOG: serverLog.run,
     DELAY: delay.run,
@@ -51,7 +50,6 @@ const ACTION_DEFINITIONS = {
     OUTGOING_WEBHOOK: outgoingWebhook.definition,
     EXECUTE_SCRIPT: executeScript.definition,
     EXECUTE_QUERY: executeQuery.definition,
-    EXECUTE_BASH: bash.definition,
     SERVER_LOG: serverLog.definition,
     DELAY: delay.definition,
     FILTER: filter.definition,
@@ -62,6 +60,14 @@ const ACTION_DEFINITIONS = {
     zapier: zapier.definition,
     integromat: integromat.definition,
 };
+// don't add the bash script/definitions unless in self host
+// the fact this isn't included in any definitions means it cannot be
+// ran at all
+if (env.SELF_HOSTED) {
+    const bash = require("./steps/bash");
+    ACTION_IMPLS["EXECUTE_BASH"] = bash.run;
+    ACTION_DEFINITIONS["EXECUTE_BASH"] = bash.definition;
+}
 /* istanbul ignore next */
 exports.getAction = function (actionName) {
     return __awaiter(this, void 0, void 0, function* () {

package/dist/automations/thread.js

@@ -19,6 +19,7 @@ const { doInTenant } = require("@budibase/auth/tenancy");
 const env = require("../environment");
 const usage = require("../utilities/usageQuota");
 const FILTER_STEP_ID = actions.ACTION_DEFINITIONS.FILTER.stepId;
+const STOPPED_STATUS = { success: false, status: "STOPPED" };
 /**
  * The automation orchestrator is a class responsible for executing automations.
  * It handles the context of the automation and makes sure each step gets the correct
@@ -77,7 +78,13 @@ class Orchestrator {
         return __awaiter(this, void 0, void 0, function* () {
             let automation = this._automation;
             const app = yield this.getApp();
+            let stopped = false;
             for (let step of automation.definition.steps) {
+                // execution stopped, record state for that
+                if (stopped) {
+                    this.updateExecutionOutput(step.id, step.stepId, {}, STOPPED_STATUS);
+                    continue;
+                }
                 let stepFn = yield this.getStepFunctionality(step.stepId);
                 step.inputs = yield processObject(step.inputs, this._context);
                 step.inputs = automationUtils.cleanInputValues(step.inputs, step.schema.inputs);
@@ -92,10 +99,14 @@ class Orchestrator {
                             context: this._context,
                         });
                     });
+                    this._context.steps.push(outputs);
+                    // if filter causes us to stop execution don't break the loop, set a var
+                    // so that we can finish iterating through the steps and record that it stopped
                     if (step.stepId === FILTER_STEP_ID && !outputs.success) {
-                        break;
+                        stopped = true;
+                        this.updateExecutionOutput(step.id, step.stepId, step.inputs, Object.assign(Object.assign({}, outputs), STOPPED_STATUS));
+                        continue;
                     }
-                    this._context.steps.push(outputs);
                     this.updateExecutionOutput(step.id, step.stepId, step.inputs, outputs);
                 }
                 catch (err) {
@@ -105,7 +116,7 @@ class Orchestrator {
             }
             // Increment quota for automation runs
             if (!env.SELF_HOSTED && !isDevAppID(this._appId)) {
-                usage.update(usage.Properties.AUTOMATION, 1);
+                yield usage.update(usage.Properties.AUTOMATION, 1);
             }
             return this.executionOutput;
         });

package/dist/constants/index.js

@@ -39,6 +39,7 @@ exports.FieldTypes = {
     FORMULA: "formula",
     AUTO: "auto",
     JSON: "json",
+    INTERNAL: "internal",
 };
 exports.RelationshipTypes = {
     ONE_TO_MANY: "one-to-many",

package/dist/integrations/base/sql.js

@@ -80,7 +80,7 @@ function addFilters(tableName, query, filters) {
     }
     return query;
 }
-function addRelationships(query, fromTable, relationships) {
+function addRelationships(knex, query, fields, fromTable, relationships) {
     if (!relationships) {
         return query;
     }
@@ -88,7 +88,7 @@ function addRelationships(query, fromTable, relationships) {
         const from = relationship.from, to = relationship.to, toTable = relationship.tableName;
         if (!relationship.through) {
             // @ts-ignore
-            query = query.leftJoin(toTable, `${fromTable}.${from}`, `${relationship.tableName}.${to}`);
+            query = query.leftJoin(toTable, `${fromTable}.${from}`, `${toTable}.${to}`);
         }
         else {
             const throughTable = relationship.through;
@@ -100,7 +100,7 @@ function addRelationships(query, fromTable, relationships) {
                 .leftJoin(toTable, `${toTable}.${toPrimary}`, `${throughTable}.${to}`);
         }
     }
-    return query;
+    return query.limit(BASE_LIMIT);
 }
 function buildCreate(knex, json, opts) {
     const { endpoint, body } = json;
@@ -165,7 +165,7 @@ function buildRead(knex, json, limit) {
         [tableName]: query,
     }).select(selectStatement);
     // handle joins
-    return addRelationships(preQuery, tableName, relationships);
+    return addRelationships(knex, preQuery, selectStatement, tableName, relationships);
 }
 function buildUpdate(knex, json, opts) {
     const { endpoint, body, filters } = json;

package/dist/middleware/currentapp.js

@@ -53,7 +53,7 @@ module.exports = (ctx, next) => __awaiter(void 0, void 0, void 0, function* () {
         const globalUser = yield getCachedSelf(ctx, requestAppId);
         appId = requestAppId;
         // retrieving global user gets the right role
-        roleId = globalUser.roleId || BUILTIN_ROLE_IDS.BASIC;
+        roleId = globalUser.roleId || roleId;
     }
     // nothing more to do
     if (!appId) {

package/dist/package.json

@@ -1,7 +1,7 @@
 {
     "name": "@budibase/server",
     "email": "hi@budibase.com",
-    "version": "0.9.166",
+    "version": "0.9.167-alpha.11",
     "description": "Budibase Web Server",
     "main": "src/index.js",
     "repository": {
@@ -68,9 +68,9 @@
     "author": "Budibase",
     "license": "AGPL-3.0-or-later",
     "dependencies": {
-        "@budibase/auth": "^0.9.166",
-        "@budibase/client": "^0.9.166",
-        "@budibase/string-templates": "^0.9.166",
+        "@budibase/auth": "^0.9.167-alpha.11",
+        "@budibase/client": "^0.9.167-alpha.11",
+        "@budibase/string-templates": "^0.9.167-alpha.11",
         "@elastic/elasticsearch": "7.10.0",
         "@koa/router": "8.0.0",
         "@sendgrid/mail": "7.1.1",
@@ -119,6 +119,7 @@
         "to-json-schema": "0.2.5",
         "uuid": "3.3.2",
         "validate.js": "0.13.1",
+        "vm2": "^3.9.3",
         "yargs": "13.2.4",
         "zlib": "1.0.5"
     },