@budibase/server 0.9.148-alpha.9 → 0.9.149-alpha.2

package/coverage/lcov-report/utilities/queue/index.html

@@ -95,7 +95,7 @@
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Fri Oct 01 2021 14:08:07 GMT+0000 (Coordinated Universal Time)
+                at Fri Oct 01 2021 15:07:38 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../prettify.js"></script>

package/coverage/lcov-report/utilities/routing/index.html

@@ -95,7 +95,7 @@
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Fri Oct 01 2021 14:08:07 GMT+0000 (Coordinated Universal Time)
+                at Fri Oct 01 2021 15:07:38 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../prettify.js"></script>

package/coverage/lcov-report/utilities/routing/index.js.html

@@ -139,7 +139,7 @@ exports.createRoutingView = createRoutingView
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Fri Oct 01 2021 14:08:07 GMT+0000 (Coordinated Universal Time)
+                at Fri Oct 01 2021 15:07:38 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../prettify.js"></script>

package/coverage/lcov-report/utilities/rowProcessor/index.html

@@ -23,16 +23,16 @@
         <div class='clearfix'>
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">76.92% </span>
+                <span class="strong">77.17% </span>
                 <span class="quiet">Statements</span>
-                <span class='fraction'>70/91</span>
+                <span class='fraction'>71/92</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">59.09% </span>
+                <span class="strong">58.57% </span>
                 <span class="quiet">Branches</span>
-                <span class='fraction'>39/66</span>
+                <span class='fraction'>41/70</span>
             </div>
         
             
@@ -44,9 +44,9 @@
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">77.53% </span>
+                <span class="strong">77.78% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>69/89</span>
+                <span class='fraction'>70/90</span>
             </div>
         
             
@@ -74,17 +74,17 @@
 </thead>
 <tbody><tr>
 	<td class="file medium" data-value="index.js"><a href="index.js.html">index.js</a></td>
-	<td data-value="75.95" class="pic medium">
-	<div class="chart"><div class="cover-fill" style="width: 75%"></div><div class="cover-empty" style="width: 25%"></div></div>
+	<td data-value="76.25" class="pic medium">
+	<div class="chart"><div class="cover-fill" style="width: 76%"></div><div class="cover-empty" style="width: 24%"></div></div>
 	</td>
-	<td data-value="75.95" class="pct medium">75.95%</td>
-	<td data-value="79" class="abs medium">60/79</td>
-	<td data-value="56.67" class="pct medium">56.67%</td>
-	<td data-value="60" class="abs medium">34/60</td>
+	<td data-value="76.25" class="pct medium">76.25%</td>
+	<td data-value="80" class="abs medium">61/80</td>
+	<td data-value="56.25" class="pct medium">56.25%</td>
+	<td data-value="64" class="abs medium">36/64</td>
 	<td data-value="90" class="pct high">90%</td>
 	<td data-value="10" class="abs high">9/10</td>
-	<td data-value="75.64" class="pct medium">75.64%</td>
-	<td data-value="78" class="abs medium">59/78</td>
+	<td data-value="75.95" class="pct medium">75.95%</td>
+	<td data-value="79" class="abs medium">60/79</td>
 	</tr>
 
 <tr>
@@ -110,7 +110,7 @@
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Fri Oct 01 2021 14:08:07 GMT+0000 (Coordinated Universal Time)
+                at Fri Oct 01 2021 15:07:38 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../prettify.js"></script>

package/coverage/lcov-report/utilities/rowProcessor/index.js.html

@@ -23,16 +23,16 @@
         <div class='clearfix'>
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">75.95% </span>
+                <span class="strong">76.25% </span>
                 <span class="quiet">Statements</span>
-                <span class='fraction'>60/79</span>
+                <span class='fraction'>61/80</span>
             </div>
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">56.67% </span>
+                <span class="strong">56.25% </span>
                 <span class="quiet">Branches</span>
-                <span class='fraction'>34/60</span>
+                <span class='fraction'>36/64</span>
             </div>
         
             
@@ -44,9 +44,9 @@
         
             
             <div class='fl pad1y space-right2'>
-                <span class="strong">75.64% </span>
+                <span class="strong">75.95% </span>
                 <span class="quiet">Lines</span>
-                <span class='fraction'>59/78</span>
+                <span class='fraction'>60/79</span>
             </div>
         
             
@@ -303,7 +303,13 @@
 <a name='L244'></a><a href='#L244'>244</a>
 <a name='L245'></a><a href='#L245'>245</a>
 <a name='L246'></a><a href='#L246'>246</a>
-<a name='L247'></a><a href='#L247'>247</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">34x</span>
+<a name='L247'></a><a href='#L247'>247</a>
+<a name='L248'></a><a href='#L248'>248</a>
+<a name='L249'></a><a href='#L249'>249</a>
+<a name='L250'></a><a href='#L250'>250</a>
+<a name='L251'></a><a href='#L251'>251</a>
+<a name='L252'></a><a href='#L252'>252</a>
+<a name='L253'></a><a href='#L253'>253</a></td><td class="line-coverage quiet"><span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-yes">34x</span>
 <span class="cline-any cline-yes">34x</span>
@@ -405,6 +411,7 @@
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">73x</span>
+<span class="cline-any cline-yes">73x</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-yes">73x</span>
 <span class="cline-any cline-yes">73x</span>
@@ -414,6 +421,11 @@
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
+<span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
 <span class="cline-any cline-neutral">&nbsp;</span>
 <span class="cline-any cline-no">&nbsp;</span>
@@ -650,6 +662,7 @@ function processAutoColumn(
   row,
   opts = <span class="branch-0 cbranch-no" title="branch not covered" >{ reprocessing: false, noAutoRelationships: false }</span>
 ) {
+  let noUser = !user || !user.userId
   let now = new Date().toISOString()
   // if a row doesn't have a revision then it doesn't exist yet
   const creating = !row._rev
@@ -659,7 +672,12 @@ function processAutoColumn(
     }
 <span class="cstat-no" title="statement not covered" >    switch (schema.subtype) {</span>
       case AutoFieldSubTypes.CREATED_BY:
-<span class="cstat-no" title="statement not covered" >        if (creating &amp;&amp; !opts.reprocessing &amp;&amp; !opts.noAutoRelationships) {</span>
+<span class="cstat-no" title="statement not covered" >        if (</span>
+          creating &amp;&amp;
+          !opts.reprocessing &amp;&amp;
+          !opts.noAutoRelationships &amp;&amp;
+          !noUser
+        ) {
 <span class="cstat-no" title="statement not covered" >          row[key] = [user.userId]</span>
         }
 <span class="cstat-no" title="statement not covered" >        break</span>
@@ -669,7 +687,7 @@ function processAutoColumn(
         }
 <span class="cstat-no" title="statement not covered" >        break</span>
       case AutoFieldSubTypes.UPDATED_BY:
-<span class="cstat-no" title="statement not covered" >        if (!opts.reprocessing &amp;&amp; !opts.noAutoRelationships) {</span>
+<span class="cstat-no" title="statement not covered" >        if (!opts.reprocessing &amp;&amp; !opts.noAutoRelationships &amp;&amp; !noUser) {</span>
 <span class="cstat-no" title="statement not covered" >          row[key] = [user.userId]</span>
         }
 <span class="cstat-no" title="statement not covered" >        break</span>
@@ -802,7 +820,7 @@ exports.outputProcessing = async (
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Fri Oct 01 2021 14:08:07 GMT+0000 (Coordinated Universal Time)
+                at Fri Oct 01 2021 15:07:38 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../prettify.js"></script>

package/coverage/lcov-report/utilities/rowProcessor/utils.js.html

@@ -133,7 +133,7 @@ exports.processFormulas = (table, rows) => {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Fri Oct 01 2021 14:08:07 GMT+0000 (Coordinated Universal Time)
+                at Fri Oct 01 2021 15:07:38 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../../prettify.js"></script>

package/coverage/lcov-report/utilities/security.js.html

@@ -265,7 +265,7 @@ exports.CURRENTLY_SUPPORTED_LEVELS = CURRENTLY_SUPPORTED_LEVELS
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Fri Oct 01 2021 14:08:07 GMT+0000 (Coordinated Universal Time)
+                at Fri Oct 01 2021 15:07:38 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../prettify.js"></script>

package/coverage/lcov-report/utilities/statusCodes.js.html

@@ -85,7 +85,7 @@
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Fri Oct 01 2021 14:08:07 GMT+0000 (Coordinated Universal Time)
+                at Fri Oct 01 2021 15:07:38 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../prettify.js"></script>

package/coverage/lcov-report/utilities/users.js.html

@@ -136,7 +136,7 @@ exports.getFullUser = async (ctx, userId) => {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Fri Oct 01 2021 14:08:07 GMT+0000 (Coordinated Universal Time)
+                at Fri Oct 01 2021 15:07:38 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../prettify.js"></script>

package/coverage/lcov-report/utilities/workerRequests.js.html

@@ -499,7 +499,7 @@ exports.removeAppFromUserRoles = async (ctx, appId) => {
             <div class='footer quiet pad2 space-top1 center small'>
                 Code coverage generated by
                 <a href="https://istanbul.js.org/" target="_blank">istanbul</a>
-                at Fri Oct 01 2021 14:08:07 GMT+0000 (Coordinated Universal Time)
+                at Fri Oct 01 2021 15:07:38 GMT+0000 (Coordinated Universal Time)
             </div>
         </div>
         <script src="../prettify.js"></script>

package/coverage/lcov.info

@@ -67,9 +67,11 @@ DA:10,23
 DA:11,1
 DA:16,23
 DA:17,0
-DA:19,0
+DA:18,0
+DA:21,0
 DA:24,0
-LF:10
+DA:29,0
+LF:12
 LH:6
 BRDA:6,0,0,0
 BRDA:6,0,1,23
@@ -80,8 +82,8 @@ BRDA:12,2,0,1
 BRDA:12,2,1,0
 BRDA:17,3,0,0
 BRDA:17,3,1,0
-BRDA:20,4,0,0
-BRDA:20,4,1,0
+BRDA:25,4,0,0
+BRDA:25,4,1,0
 BRF:11
 BRH:4
 end_of_record
@@ -3485,10 +3487,9 @@ DA:1,23
 DA:2,23
 DA:4,23
 DA:6,23
-DA:7,23
-DA:9,23
-LF:6
-LH:6
+DA:10,23
+LF:5
+LH:5
 BRF:0
 BRH:0
 end_of_record
@@ -7271,10 +7272,10 @@ FN:56,(anonymous_2)
 FN:62,(anonymous_3)
 FN:82,(anonymous_4)
 FN:96,processAutoColumn
-FN:146,(anonymous_6)
-FN:166,(anonymous_7)
-FN:207,(anonymous_8)
-FN:232,(anonymous_9)
+FN:152,(anonymous_6)
+FN:172,(anonymous_7)
+FN:213,(anonymous_8)
+FN:238,(anonymous_9)
 FNF:10
 FNH:9
 FNDA:11,(anonymous_0)
@@ -7305,68 +7306,69 @@ DA:64,1
 DA:66,1
 DA:82,0
 DA:102,73
-DA:104,73
+DA:103,73
 DA:105,73
-DA:106,206
+DA:106,73
 DA:107,206
-DA:109,0
-DA:111,0
+DA:108,206
+DA:110,0
 DA:112,0
-DA:114,0
-DA:116,0
-DA:117,0
-DA:119,0
-DA:121,0
+DA:118,0
+DA:120,0
 DA:122,0
-DA:124,0
-DA:126,0
+DA:123,0
+DA:125,0
 DA:127,0
-DA:129,0
+DA:128,0
 DA:130,0
-DA:131,0
+DA:132,0
 DA:133,0
-DA:136,73
-DA:138,34
-DA:146,34
-DA:148,174
-DA:149,16
-DA:150,158
-DA:151,22
-DA:154,136
-DA:166,34
-DA:172,73
-DA:174,73
-DA:175,73
-DA:176,73
-DA:177,332
-DA:179,332
-DA:180,159
-DA:181,3
-DA:183,159
-DA:187,173
-DA:188,0
-DA:190,173
-DA:194,73
-DA:207,34
-DA:213,100
-DA:214,100
-DA:215,100
-DA:216,87
-DA:217,87
+DA:135,0
+DA:136,0
+DA:137,0
+DA:139,0
+DA:142,73
+DA:144,34
+DA:152,34
+DA:154,174
+DA:155,16
+DA:156,158
+DA:157,22
+DA:160,136
+DA:172,34
+DA:178,73
+DA:180,73
+DA:181,73
+DA:182,73
+DA:183,332
+DA:185,332
+DA:186,159
+DA:187,3
+DA:189,159
+DA:193,173
+DA:194,0
+DA:196,173
+DA:200,73
+DA:213,34
+DA:219,100
 DA:220,100
-DA:223,100
+DA:221,100
+DA:222,87
+DA:223,87
 DA:226,100
-DA:227,296
-DA:228,8
-DA:229,8
-DA:230,6
-DA:232,2
-DA:233,2
-DA:238,100
-DA:239,26
-DA:245,100
-LF:78
-LH:59
+DA:229,100
+DA:232,100
+DA:233,296
+DA:234,8
+DA:235,8
+DA:236,6
+DA:238,2
+DA:239,2
+DA:244,100
+DA:245,26
+DA:251,100
+LF:79
+LH:60
 BRDA:18,0,0,2
 BRDA:18,0,1,9
 BRDA:18,1,0,11
@@ -7380,55 +7382,59 @@ BRDA:21,4,1,9
 BRDA:63,5,0,1
 BRDA:63,5,1,1
 BRDA:100,6,0,0
-BRDA:106,7,0,206
-BRDA:106,7,1,0
-BRDA:109,8,0,0
-BRDA:109,8,1,0
-BRDA:109,8,2,0
-BRDA:109,8,3,0
-BRDA:109,8,4,0
-BRDA:111,9,0,0
-BRDA:111,9,1,0
-BRDA:111,10,0,0
-BRDA:111,10,1,0
-BRDA:111,10,2,0
-BRDA:116,11,0,0
-BRDA:116,11,1,0
-BRDA:121,12,0,0
-BRDA:121,12,1,0
-BRDA:121,13,0,0
-BRDA:121,13,1,0
-BRDA:129,14,0,0
-BRDA:129,14,1,0
-BRDA:130,15,0,0
-BRDA:130,15,1,0
-BRDA:148,16,0,16
-BRDA:148,16,1,158
-BRDA:150,17,0,22
-BRDA:150,17,1,136
-BRDA:167,18,0,0
-BRDA:170,19,0,72
-BRDA:179,20,0,159
-BRDA:179,20,1,173
-BRDA:180,21,0,3
-BRDA:180,21,1,156
-BRDA:187,22,0,0
-BRDA:187,22,1,173
-BRDA:211,23,0,26
-BRDA:215,24,0,87
-BRDA:215,24,1,13
-BRDA:227,25,0,8
-BRDA:227,25,1,288
-BRDA:229,26,0,6
-BRDA:229,26,1,2
-BRDA:229,27,0,8
-BRDA:229,27,1,6
-BRDA:238,28,0,26
-BRDA:238,28,1,74
-BRDA:245,29,0,13
-BRDA:245,29,1,87
-BRF:60
-BRH:34
+BRDA:102,7,0,73
+BRDA:102,7,1,73
+BRDA:107,8,0,206
+BRDA:107,8,1,0
+BRDA:110,9,0,0
+BRDA:110,9,1,0
+BRDA:110,9,2,0
+BRDA:110,9,3,0
+BRDA:110,9,4,0
+BRDA:112,10,0,0
+BRDA:112,10,1,0
+BRDA:113,11,0,0
+BRDA:113,11,1,0
+BRDA:113,11,2,0
+BRDA:113,11,3,0
+BRDA:122,12,0,0
+BRDA:122,12,1,0
+BRDA:127,13,0,0
+BRDA:127,13,1,0
+BRDA:127,14,0,0
+BRDA:127,14,1,0
+BRDA:127,14,2,0
+BRDA:135,15,0,0
+BRDA:135,15,1,0
+BRDA:136,16,0,0
+BRDA:136,16,1,0
+BRDA:154,17,0,16
+BRDA:154,17,1,158
+BRDA:156,18,0,22
+BRDA:156,18,1,136
+BRDA:173,19,0,0
+BRDA:176,20,0,72
+BRDA:185,21,0,159
+BRDA:185,21,1,173
+BRDA:186,22,0,3
+BRDA:186,22,1,156
+BRDA:193,23,0,0
+BRDA:193,23,1,173
+BRDA:217,24,0,26
+BRDA:221,25,0,87
+BRDA:221,25,1,13
+BRDA:233,26,0,8
+BRDA:233,26,1,288
+BRDA:235,27,0,6
+BRDA:235,27,1,2
+BRDA:235,28,0,8
+BRDA:235,28,1,6
+BRDA:244,29,0,26
+BRDA:244,29,1,74
+BRDA:251,30,0,13
+BRDA:251,30,1,87
+BRF:64
+BRH:36
 end_of_record
 TN:
 SF:src/utilities/rowProcessor/utils.js

package/dist/api/controllers/analytics.js

@@ -14,16 +14,18 @@ let posthogClient;
 if (env.POSTHOG_TOKEN && env.ENABLE_ANALYTICS && !env.SELF_HOSTED) {
     posthogClient = new PostHog(env.POSTHOG_TOKEN);
 }
-exports.isEnabled = function (ctx) {
-    return __awaiter(this, void 0, void 0, function* () {
+exports.isEnabled = (ctx) => __awaiter(void 0, void 0, void 0, function* () {
+    ctx.body = {
+        enabled: !env.SELF_HOSTED && env.ENABLE_ANALYTICS === "true",
+    };
+});
+exports.endUserPing = (ctx) => __awaiter(void 0, void 0, void 0, function* () {
+    if (!posthogClient) {
         ctx.body = {
-            enabled: !env.SELF_HOSTED && env.ENABLE_ANALYTICS === "true",
+            ping: false,
         };
-    });
-};
-exports.endUserPing = (ctx, next) => __awaiter(void 0, void 0, void 0, function* () {
-    if (!posthogClient)
-        return next();
+        return;
+    }
     posthogClient.capture("budibase:end_user_ping", {
         userId: ctx.user && ctx.user._id,
         appId: ctx.appId,

package/dist/api/controllers/deploy/index.js

@@ -62,15 +62,21 @@ function storeDeploymentHistory(deployment) {
 function initDeployedApp(prodAppId) {
     return __awaiter(this, void 0, void 0, function* () {
         const db = new CouchDB(prodAppId);
+        console.log("Reading automation docs");
         const automations = (yield db.allDocs(getAutomationParams(null, {
             include_docs: true,
         }))).rows.map(row => row.doc);
+        console.log("You have " + automations.length + " automations");
         const promises = [];
+        console.log("Disabling prod crons..");
         yield disableAllCrons(prodAppId);
+        console.log("Prod Cron triggers disabled..");
+        console.log("Enabling cron triggers for deployed app..");
         for (let automation of automations) {
             promises.push(enableCronTrigger(prodAppId, automation));
         }
         yield Promise.all(promises);
+        console.log("Enabled cron triggers for deployed app..");
     });
 }
 function deployApp(deployment) {
@@ -81,12 +87,16 @@ function deployApp(deployment) {
                 source: deployment.appId,
                 target: productionAppId,
             });
+            console.log("Replication object created");
             yield replication.replicate();
+            console.log("replication complete.. replacing app meta doc");
             const db = new CouchDB(productionAppId);
             const appDoc = yield db.get(DocumentTypes.APP_METADATA);
             appDoc.appId = productionAppId;
             appDoc.instance._id = productionAppId;
             yield db.put(appDoc);
+            console.log("New app doc written successfully.");
+            console.log("Setting up live repl between dev and prod");
             // Set up live sync between the live and dev instances
             const liveReplication = new Replication({
                 source: productionAppId,
@@ -97,7 +107,10 @@ function deployApp(deployment) {
                     return doc._id !== DocumentTypes.APP_METADATA;
                 },
             });
+            console.log("Set up live repl between dev and prod");
+            console.log("Initialising deployed app");
             yield initDeployedApp(productionAppId);
+            console.log("Init complete, setting deployment to successful");
             deployment.setStatus(DeploymentStatus.SUCCESS);
             yield storeDeploymentHistory(deployment);
         }
@@ -141,8 +154,12 @@ exports.deploymentProgress = function (ctx) {
 exports.deployApp = function (ctx) {
     return __awaiter(this, void 0, void 0, function* () {
         let deployment = new Deployment(ctx.appId);
+        console.log("Deployment object created");
         deployment.setStatus(DeploymentStatus.PENDING);
+        console.log("Deployment object set to pending");
         deployment = yield storeDeploymentHistory(deployment);
+        console.log("Stored deployment history");
+        console.log("Deploying app...");
         yield deployApp(deployment);
         ctx.body = deployment;
     });

package/dist/api/routes/analytics.js

@@ -2,6 +2,7 @@
 const Router = require("@koa/router");
 const controller = require("../controllers/analytics");
 const router = Router();
-router.get("/api/analytics", controller.isEnabled);
-router.post("/api/analytics/ping", controller.endUserPing);
+router
+    .get("/api/analytics", controller.isEnabled)
+    .post("/api/analytics/ping", controller.endUserPing);
 module.exports = router;