@budibase/frontend-core 2.26.1 → 2.26.2

package/package.json

@@ -1,18 +1,18 @@
 {
   "name": "@budibase/frontend-core",
-  "version": "2.26.1",
+  "version": "2.26.2",
   "description": "Budibase frontend core libraries used in builder and client",
   "author": "Budibase",
   "license": "MPL-2.0",
   "svelte": "src/index.js",
   "dependencies": {
-    "@budibase/bbui": "2.26.1",
-    "@budibase/shared-core": "2.26.1",
-    "@budibase/types": "2.26.1",
+    "@budibase/bbui": "2.26.2",
+    "@budibase/shared-core": "2.26.2",
+    "@budibase/types": "2.26.2",
     "dayjs": "^1.10.8",
     "lodash": "4.17.21",
     "shortid": "2.2.15",
     "socket.io-client": "^4.6.1"
   },
-  "gitHead": "0d8b8b6ef7b4abe1339858e09319faec032fd263"
+  "gitHead": "3d3bff09f82a7994168af6c475616750c0e9163a"
 }

package/src/components/grid/cells/GutterCell.svelte

@@ -16,6 +16,8 @@
   const { config, dispatch, selectedRows } = getContext("grid")
   const svelteDispatch = createEventDispatcher()
 
+  $: selectionEnabled = $config.canSelectRows || $config.canDeleteRows
+
   const select = e => {
     e.stopPropagation()
     svelteDispatch("select")
@@ -52,7 +54,7 @@
       <div
         on:click={select}
         class="checkbox"
-        class:visible={$config.canDeleteRows &&
+        class:visible={selectionEnabled &&
           (disableNumber || rowSelected || rowHovered || rowFocused)}
       >
         <Checkbox value={rowSelected} {disabled} />
@@ -60,7 +62,7 @@
       {#if !disableNumber}
         <div
           class="number"
-          class:visible={!$config.canDeleteRows ||
+          class:visible={!selectionEnabled ||
             !(rowSelected || rowHovered || rowFocused)}
         >
           {row.__idx + 1}
@@ -117,19 +119,11 @@
   .expand {
     margin-right: 4px;
   }
-  .expand {
+  .expand:not(.visible),
+  .expand:not(.visible) :global(*) {
     opacity: 0;
+    pointer-events: none !important;
   }
-  .expand :global(.spectrum-Icon) {
-    pointer-events: none;
-  }
-  .expand.visible {
-    opacity: 1;
-  }
-  .expand.visible :global(.spectrum-Icon) {
-    pointer-events: all;
-  }
-
   .delete:hover {
     cursor: pointer;
   }

package/src/components/grid/layout/Grid.svelte

@@ -41,6 +41,7 @@
   export let canDeleteRows = true
   export let canEditColumns = true
   export let canSaveSchema = true
+  export let canSelectRows = false
   export let stripeRows = false
   export let quiet = false
   export let collaboration = true
@@ -94,6 +95,7 @@
     canDeleteRows,
     canEditColumns,
     canSaveSchema,
+    canSelectRows,
     stripeRows,
     quiet,
     collaboration,

package/src/components/grid/lib/utils.js

@@ -5,11 +5,11 @@ import { TypeIconMap } from "../../../constants"
 // using something very unusual to avoid this problem
 const JOINING_CHARACTER = "‽‽"
 
-export const parseCellID = rowId => {
-  if (!rowId) {
-    return undefined
+export const parseCellID = cellId => {
+  if (!cellId) {
+    return { id: undefined, field: undefined }
   }
-  const parts = rowId.split(JOINING_CHARACTER)
+  const parts = cellId.split(JOINING_CHARACTER)
   const field = parts.pop()
   return { id: parts.join(JOINING_CHARACTER), field }
 }

package/src/components/grid/stores/ui.js

@@ -110,12 +110,11 @@ export const deriveStores = context => {
 }
 
 export const createActions = context => {
-  const { focusedCellId, selectedRows, hoveredRowId } = context
+  const { focusedCellId, hoveredRowId } = context
 
   // Callback when leaving the grid, deselecting all focussed or selected items
   const blur = () => {
     focusedCellId.set(null)
-    selectedRows.set({})
     hoveredRowId.set(null)
   }