@btst/stack 3.0.0-rc.2 → 3.0.0-rc.4

package/src/plugins/ai-chat/__tests__/hooks.test.tsx

@@ -1,10 +1,17 @@
 // @vitest-environment jsdom
-import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
+import { QueryClient } from "@tanstack/react-query";
 import { act } from "react";
 import { createRoot, type Root } from "react-dom/client";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import { StackProvider } from "@btst/stack/context";
-import { useRenameConversationForm } from "../client/hooks/chat-hooks";
+import { createClientStack } from "@btst/stack/client";
+import { buildQueryKey } from "@btst/stack/plugins/client";
+import {
+	useDeleteConversation,
+	useRenameConversationForm,
+} from "../client/hooks/chat-hooks";
+import { aiChatClientPlugin } from "../client/plugin";
+import { aiChatResources } from "../query-keys";
 import type { SerializedConversation } from "../types";
 
 (globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
@@ -52,7 +59,26 @@ function jsonResponse(body: unknown, status = 200) {
 	});
 }
 
-async function renderProbe() {
+function createTestStack() {
+	return createClientStack({
+		api: { baseURL: "http://app.local", basePath: "/api/data" },
+		site: { baseURL: "http://test.local", basePath: "/pages" },
+		queryClient,
+		plugins: { aiChat: aiChatClientPlugin() },
+		endpoints: {
+			aiChat: {
+				api: {
+					baseURL: "https://chat.example.com",
+					basePath: "/btst",
+					browserHeaders: { "x-chat-test": "forwarded" },
+					credentials: "omit",
+				},
+			},
+		},
+	});
+}
+
+async function renderRenameProbe() {
 	let captured: ReturnType<typeof useRenameConversationForm>;
 	function Probe() {
 		captured = useRenameConversationForm({ conversation });
@@ -61,21 +87,35 @@ async function renderProbe() {
 
 	await act(async () => {
 		root.render(
-			<QueryClientProvider client={queryClient}>
-				<StackProvider
-					basePath="/pages"
-					api={{ baseURL: "http://test.local", basePath: "/api/data" }}
-					router={{ refresh }}
-					overrides={{
-						"ai-chat": {
-							headers: { "x-chat-test": "forwarded" },
-						},
-					}}
-					notify={notify}
-				>
-					<Probe />
-				</StackProvider>
-			</QueryClientProvider>,
+			<StackProvider
+				stack={createTestStack()}
+				router={{ refresh }}
+				notify={notify}
+			>
+				<Probe />
+			</StackProvider>,
+		);
+	});
+
+	return () => captured!;
+}
+
+async function renderDeleteProbe() {
+	let captured: ReturnType<typeof useDeleteConversation>;
+	function Probe() {
+		captured = useDeleteConversation();
+		return null;
+	}
+
+	await act(async () => {
+		root.render(
+			<StackProvider
+				stack={createTestStack()}
+				router={{ refresh }}
+				notify={notify}
+			>
+				<Probe />
+			</StackProvider>,
 		);
 	});
 
@@ -83,23 +123,34 @@ async function renderProbe() {
 }
 
 describe("useRenameConversationForm", () => {
-	it("trims the title, forwards headers, refreshes, and notifies on success", async () => {
+	it("trims the title, forwards headers, refreshes current identity data, and notifies on success", async () => {
 		fetchMock.mockResolvedValue(
 			jsonResponse({ ...conversation, title: "Renamed" }),
 		);
-		const getForm = await renderProbe();
+		const invalidateQueries = vi.spyOn(queryClient, "invalidateQueries");
+		const getForm = await renderRenameProbe();
 
 		await act(async () => {
 			await getForm().submit({ title: "  Renamed  " });
 		});
 
 		const [url, init] = fetchMock.mock.calls[0] as [unknown, RequestInit];
-		expect(String(url)).toContain("/api/data/chat/conversations/conv-1");
+		expect(String(url)).toContain(
+			"https://chat.example.com/btst/chat/conversations/conv-1",
+		);
 		expect(init.method).toBe("PUT");
+		expect(init.credentials).toBe("omit");
 		expect(JSON.parse(String(init.body))).toEqual({ title: "Renamed" });
 		expect(new Headers(init.headers).get("x-chat-test")).toBe("forwarded");
 		expect(notify.success).toHaveBeenCalledWith("Conversation renamed");
-		expect(refresh).toHaveBeenCalledTimes(1);
+		expect(invalidateQueries).toHaveBeenCalledTimes(1);
+		expect(invalidateQueries).toHaveBeenCalledWith(
+			expect.objectContaining({
+				queryKey: ["conversations"],
+				refetchType: "all",
+			}),
+		);
+		expect(refresh).not.toHaveBeenCalled();
 	});
 
 	it("keeps server validation errors on the title field without an error toast", async () => {
@@ -113,7 +164,7 @@ describe("useRenameConversationForm", () => {
 				400,
 			),
 		);
-		const getForm = await renderProbe();
+		const getForm = await renderRenameProbe();
 
 		await act(async () => {
 			await getForm().submit({ title: "   " });
@@ -124,3 +175,60 @@ describe("useRenameConversationForm", () => {
 		expect(refresh).not.toHaveBeenCalled();
 	});
 });
+
+describe("useDeleteConversation", () => {
+	it("refreshes the list and evicts only the deleted detail in the starting identity partition", async () => {
+		const identityPartition = "anonymous" as const;
+		const otherConversation = { ...conversation, id: "conv-2", title: "Other" };
+		const otherIdentity = { id: "other-user", role: "user" } as const;
+		const listKey = buildQueryKey(
+			"conversations",
+			"list",
+			aiChatResources.conversations.queries.list,
+			[identityPartition],
+		);
+		const deletedDetailKey = buildQueryKey(
+			"conversations",
+			"detail",
+			aiChatResources.conversations.queries.detail,
+			[conversation.id, identityPartition],
+		);
+		const otherDetailKey = buildQueryKey(
+			"conversations",
+			"detail",
+			aiChatResources.conversations.queries.detail,
+			[otherConversation.id, identityPartition],
+		);
+		const otherIdentityDetailKey = buildQueryKey(
+			"conversations",
+			"detail",
+			aiChatResources.conversations.queries.detail,
+			[conversation.id, otherIdentity],
+		);
+		let listFetches = 0;
+		await queryClient.fetchQuery({
+			queryKey: listKey,
+			queryFn: async () => {
+				listFetches += 1;
+				return [conversation, otherConversation];
+			},
+		});
+		listFetches = 0;
+		queryClient.setQueryData(deletedDetailKey, conversation);
+		queryClient.setQueryData(otherDetailKey, otherConversation);
+		queryClient.setQueryData(otherIdentityDetailKey, conversation);
+		fetchMock.mockResolvedValue(jsonResponse({ success: true }));
+		const getMutation = await renderDeleteProbe();
+
+		await act(async () => {
+			await getMutation().mutateAsync({ id: conversation.id });
+		});
+
+		expect(listFetches).toBe(1);
+		expect(queryClient.getQueryData(deletedDetailKey)).toBeUndefined();
+		expect(queryClient.getQueryData(otherDetailKey)).toEqual(otherConversation);
+		expect(queryClient.getQueryData(otherIdentityDetailKey)).toEqual(
+			conversation,
+		);
+	});
+});

package/src/plugins/ai-chat/api/getters.ts

@@ -9,7 +9,7 @@ import type { Conversation, ConversationWithMessages, Message } from "../types";
  * @param userId - Optional user ID to filter conversations by owner
  */
 export async function getAllConversations(
-	adapter: Adapter,
+	adapter: Pick<Adapter, "findMany">,
 	userId?: string,
 ): Promise<Conversation[]> {
 	const whereConditions: Array<{
@@ -42,7 +42,7 @@ export async function getAllConversations(
  * @param id - The conversation ID
  */
 export async function getConversationById(
-	adapter: Adapter,
+	adapter: Pick<Adapter, "findMany">,
 	id: string,
 ): Promise<(Conversation & { messages: Message[] }) | null> {
 	const conversations = await adapter.findMany<ConversationWithMessages>({

package/src/plugins/ai-chat/api/index.ts

@@ -1,7 +1,12 @@
 export * from "./plugin";
 export { getAllConversations, getConversationById } from "./getters";
-export { aiChatResources, createAiChatQueryKeys } from "../query-keys";
+export {
+	aiChatIdentityKey,
+	aiChatResources,
+	createAiChatQueryKeys,
+} from "../query-keys";
 export type {
+	AiChatIdentityPartition,
 	AiChatQueryKeys,
 	ConversationWithMessages,
 	CreateConversationInput,

package/src/plugins/ai-chat/api/lifecycle-migrations.ts

@@ -0,0 +1,20 @@
+/**
+ * Removed AI Chat lifecycle names and their canonical v3 replacements.
+ *
+ * This structured inventory is the source for migration documentation and
+ * repository guards. Names absent from this map did not change.
+ */
+export const AI_CHAT_LIFECYCLE_HOOK_MIGRATIONS = Object.freeze({
+	onBeforeToolsActivated: "onBeforeActivateTools",
+	onConversationsRead: "onAfterListConversations",
+	onConversationRead: "onAfterGetConversation",
+	onConversationCreated: "onAfterCreateConversation",
+	onConversationUpdated: "onAfterUpdateConversation",
+	onConversationDeleted: "onAfterDeleteConversation",
+	onChatError: "onErrorChat",
+	onListConversationsError: "onErrorListConversations",
+	onGetConversationError: "onErrorGetConversation",
+	onCreateConversationError: "onErrorCreateConversation",
+	onUpdateConversationError: "onErrorUpdateConversation",
+	onDeleteConversationError: "onErrorDeleteConversation",
+} as const);