@btc-vision/transaction 1.8.8 → 1.8.9

package/src/epoch/validator/EpochValidator.ts

@@ -115,7 +115,7 @@ export class EpochValidator {
     public static verifySolution(
         challenge: IChallengeSolution,
         log: boolean = false,
-        useHashedPreimage: boolean = false,
+        useConcatenatedPreimage: boolean = false,
     ): boolean {
         try {
             const verification = challenge.verification;
@@ -123,7 +123,7 @@ export class EpochValidator {
                 verification.targetChecksum,
                 challenge.publicKey.toBuffer(),
                 challenge.salt,
-                useHashedPreimage,
+                useConcatenatedPreimage,
             );
 
             const computedSolution = this.sha1(calculatedPreimage);
@@ -168,7 +168,7 @@ export class EpochValidator {
      */
     public static validateEpochWinner(
         epochData: RawChallenge,
-        useHashedPreimage: boolean = false,
+        useConcatenatedPreimage: boolean = false,
     ): boolean {
         try {
             const epochNumber = BigInt(epochData.epochNumber);
@@ -194,7 +194,7 @@ export class EpochValidator {
                 verification.targetChecksum,
                 publicKey.toBuffer(),
                 salt,
-                useHashedPreimage,
+                useConcatenatedPreimage,
             );
 
             const computedSolution = this.sha1(calculatedPreimage);
@@ -226,9 +226,9 @@ export class EpochValidator {
      */
     public static validateChallengeSolution(
         challenge: IChallengeSolution,
-        useHashedPreimage: boolean = false,
+        useConcatenatedPreimage: boolean = false,
     ): boolean {
-        return this.verifySolution(challenge, false, useHashedPreimage);
+        return this.verifySolution(challenge, false, useConcatenatedPreimage);
     }
 
     /**
@@ -242,13 +242,13 @@ export class EpochValidator {
         targetChecksum: Uint8Array,
         publicKey: Uint8Array,
         salt: Uint8Array,
-        useHashedPreimage: boolean = false,
+        useConcatenatedPreimage: boolean = false,
     ): Uint8Array {
         const preimage = this.calculatePreimage(
             targetChecksum,
             publicKey,
             salt,
-            useHashedPreimage,
+            useConcatenatedPreimage,
         );
         return this.sha1(preimage);
     }

package/src/transaction/builders/TransactionBuilder.ts

@@ -983,8 +983,25 @@ export abstract class TransactionBuilder<T extends TransactionType> extends Twea
         const mldsaSigner = this.mldsaSigner;
         const legacySignature = this.generateLegacySignature();
 
+        // Reveal by default. The legacy Schnorr signature only proves ownership of
+        // the Bitcoin key being linked; it says nothing about the claimed
+        // hashedPublicKey. Without the ML-DSA public key and a signature over it,
+        // a link request carries no proof that the sender knows a preimage for
+        // that hash, so a node cannot safely create a NEW identity from it.
+        //
+        // Defaulting to false made every caller responsible for remembering, and
+        // callers do forget: opwallet never set this anywhere, and its deployment
+        // screen calls signDeployment() directly, bypassing any controller-level
+        // fix. Revealing when it was not needed only costs bytes (ML-DSA-44:
+        // 1312-byte key + 2420-byte signature); not revealing when it was needed
+        // gets the transaction rejected.
+        //
+        // Callers that KNOW the key is already linked on-chain should pass false
+        // explicitly to avoid paying for the reveal on every interaction.
+        const shouldReveal = parameters.revealMLDSAPublicKey ?? true;
+
         let mldsaSignature: Uint8Array | null = null;
-        if (parameters.revealMLDSAPublicKey) {
+        if (shouldReveal) {
             mldsaSignature = this.generateMLDSASignature();
         }
 
@@ -992,7 +1009,7 @@ export abstract class TransactionBuilder<T extends TransactionType> extends Twea
             priority: FeaturePriority.MLDSA_LINK_PUBKEY,
             opcode: Features.MLDSA_LINK_PUBKEY,
             data: {
-                verifyRequest: !!parameters.revealMLDSAPublicKey,
+                verifyRequest: shouldReveal,
                 publicKey: mldsaSigner.publicKey,
                 hashedPublicKey: this.hashedPublicKey,
                 level: getLevelFromPublicKeyLength(mldsaSigner.publicKey.length),