@btc-vision/transaction 1.0.101 → 1.0.102

package/src/transaction/builders/MultiSignTransaction.ts

@@ -139,7 +139,7 @@ export class MultiSignTransaction extends TransactionBuilder<TransactionType.MUL
     public static verifyIfSigned(psbt: Psbt, signerPubKey: Buffer): boolean {
         let alreadySigned: boolean = false;
         for (let i = 1; i < psbt.data.inputs.length; i++) {
-            let input: PsbtInput = psbt.data.inputs[i];
+            const input: PsbtInput = psbt.data.inputs[i];
             if (!input.finalScriptWitness) {
                 continue;
             }
@@ -183,12 +183,12 @@ export class MultiSignTransaction extends TransactionBuilder<TransactionType.MUL
         let final: boolean = true;
 
         for (let i = originalInputCount; i < psbt.data.inputs.length; i++) {
-            let input: PsbtInput = psbt.data.inputs[i];
+            const input: PsbtInput = psbt.data.inputs[i];
             if (!input.tapInternalKey) {
                 input.tapInternalKey = toXOnly(MultiSignTransaction.numsPoint);
             }
 
-            let partialSignatures: TapScriptSig[] = [];
+            const partialSignatures: TapScriptSig[] = [];
             if (input.finalScriptWitness) {
                 const decoded = TransactionBuilder.readScriptWitnessToWitnessStack(
                     input.finalScriptWitness,
@@ -278,9 +278,9 @@ export class MultiSignTransaction extends TransactionBuilder<TransactionType.MUL
                 .flat();
         } else {
             /** We must order the signatures and the pub keys. */
-            for (let pubKey of orderedPubKeys) {
+            for (const pubKey of orderedPubKeys) {
                 let found = false;
-                for (let sig of input.tapScriptSig) {
+                for (const sig of input.tapScriptSig) {
                     if (sig.pubkey.equals(toXOnly(pubKey))) {
                         scriptSolution.push(sig.signature);
                         found = true;
@@ -349,13 +349,13 @@ export class MultiSignTransaction extends TransactionBuilder<TransactionType.MUL
         let finalizedInputs = 0;
         for (let i = startIndex; i < psbt.data.inputs.length; i++) {
             try {
-                let input = psbt.data.inputs[i];
+                const input = psbt.data.inputs[i];
 
                 if (!input.tapInternalKey) {
                     input.tapInternalKey = toXOnly(MultiSignTransaction.numsPoint);
                 }
 
-                let partialSignatures: TapScriptSig[] = [];
+                const partialSignatures: TapScriptSig[] = [];
                 if (input.finalScriptWitness) {
                     const decoded = TransactionBuilder.readScriptWitnessToWitnessStack(
                         input.finalScriptWitness,
@@ -451,6 +451,7 @@ export class MultiSignTransaction extends TransactionBuilder<TransactionType.MUL
      * @throws {Error} If the left over funds script redeem version is required
      * @throws {Error} If the left over funds script redeem output is required
      */
+    // eslint-disable-next-line @typescript-eslint/require-await
     protected override async buildTransaction(): Promise<void> {
         const selectedRedeem = this.targetScriptRedeem;
         if (!selectedRedeem) {

package/src/transaction/builders/SharedInteractionTransaction.ts

@@ -136,7 +136,7 @@ export abstract class SharedInteractionTransaction<
     protected override async buildTransaction(): Promise<void> {
         if (!this.to) throw new Error('To address is required');
 
-        const selectedRedeem = !!this.scriptSigner
+        const selectedRedeem = this.scriptSigner
             ? this.targetScriptRedeem
             : this.leftOverFundsScriptRedeem;
 
@@ -186,7 +186,7 @@ export abstract class SharedInteractionTransaction<
         }
 
         for (let i = 0; i < transaction.data.inputs.length; i++) {
-            let input: PsbtInput = transaction.data.inputs[i];
+            const input: PsbtInput = transaction.data.inputs[i];
             let finalized: boolean = false;
             let signed: boolean = false;
 
@@ -235,7 +235,7 @@ export abstract class SharedInteractionTransaction<
     }
 
     protected override generateTapData(): Payment {
-        const selectedRedeem = !!this.scriptSigner
+        const selectedRedeem = this.scriptSigner
             ? this.targetScriptRedeem
             : this.leftOverFundsScriptRedeem;
 

package/src/transaction/builders/TransactionBuilder.ts

@@ -446,7 +446,7 @@ export abstract class TransactionBuilder<T extends TransactionType> extends Twea
             );
         }
 
-        for (let output of this.outputs) {
+        for (const output of this.outputs) {
             if ('address' in output && output.address === this.to) {
                 output.value += Number(value);
                 return;
@@ -476,7 +476,7 @@ export abstract class TransactionBuilder<T extends TransactionType> extends Twea
      */
     protected calculateTotalUTXOAmount(): bigint {
         let total: bigint = 0n;
-        for (let utxo of this.utxos) {
+        for (const utxo of this.utxos) {
             total += utxo.value;
         }
 
@@ -490,7 +490,7 @@ export abstract class TransactionBuilder<T extends TransactionType> extends Twea
      */
     protected calculateTotalVOutAmount(): bigint {
         let total: bigint = 0n;
-        for (let utxo of this.utxos) {
+        for (const utxo of this.utxos) {
             total += utxo.value;
         }
 
@@ -583,7 +583,7 @@ export abstract class TransactionBuilder<T extends TransactionType> extends Twea
      * @protected
      */
     protected verifyUTXOValidity(): void {
-        for (let utxo of this.utxos) {
+        for (const utxo of this.utxos) {
             if (!utxo.scriptPubKey) {
                 throw new Error('Address is required');
             }
@@ -599,7 +599,7 @@ export abstract class TransactionBuilder<T extends TransactionType> extends Twea
     protected async setFeeOutput(output: PsbtOutputExtended): Promise<void> {
         const initialValue = output.value;
 
-        let fee = await this.estimateTransactionFees();
+        const fee = await this.estimateTransactionFees();
         output.value = initialValue - Number(fee);
 
         if (output.value < TransactionBuilder.MINIMUM_DUST) {
@@ -613,7 +613,7 @@ export abstract class TransactionBuilder<T extends TransactionType> extends Twea
         } else {
             this.feeOutput = output;
 
-            let fee = await this.estimateTransactionFees();
+            const fee = await this.estimateTransactionFees();
             if (fee > BigInt(initialValue)) {
                 throw new Error(
                     `estimateTransactionFees: Insufficient funds to pay the fees. Fee: ${fee} > Value: ${initialValue}. Total input: ${this.totalInputAmount} sat`,

package/src/transaction/builders/UnwrapTransaction.ts

@@ -188,7 +188,7 @@ export class UnwrapTransaction extends SharedInteractionTransaction<TransactionT
     public getRefund(): bigint {
         let losses: bigint = -currentConsensusConfig.UNWRAP_CONSOLIDATION_PREPAID_FEES_SAT;
 
-        for (let vault of this.vaultUTXOs) {
+        for (const vault of this.vaultUTXOs) {
             for (let i = 0; i < vault.utxos.length; i++) {
                 losses += currentConsensusConfig.UNWRAP_CONSOLIDATION_PREPAID_FEES_SAT;
             }
@@ -206,7 +206,7 @@ export class UnwrapTransaction extends SharedInteractionTransaction<TransactionT
      * @returns {bigint} - The estimated fee loss or refund
      */
     public getFeeLossOrRefund(): bigint {
-        let refund: bigint = this.getRefund();
+        const refund: bigint = this.getRefund();
 
         return refund - this.estimatedFeeLoss;
     }
@@ -219,7 +219,7 @@ export class UnwrapTransaction extends SharedInteractionTransaction<TransactionT
         const totalInputAmount: bigint = this.getVaultTotalOutputAmount(this.vaultUTXOs);
 
         let refund: bigint = this.getRefund();
-        let outputLeftAmount = totalInputAmount - refund - this.amount;
+        const outputLeftAmount = totalInputAmount - refund - this.amount;
 
         if (outputLeftAmount === currentConsensusConfig.UNWRAP_CONSOLIDATION_PREPAID_FEES_SAT) {
             refund += currentConsensusConfig.UNWRAP_CONSOLIDATION_PREPAID_FEES_SAT;
@@ -235,7 +235,7 @@ export class UnwrapTransaction extends SharedInteractionTransaction<TransactionT
             throw new Error('No vaults provided');
         }
 
-        let hasConsolidation: boolean =
+        const hasConsolidation: boolean =
             outputLeftAmount > currentConsensusConfig.VAULT_MINIMUM_AMOUNT &&
             outputLeftAmount - currentConsensusConfig.UNWRAP_CONSOLIDATION_PREPAID_FEES_SAT !== 0n;
 

package/src/transaction/builders/WrapTransaction.ts

@@ -223,7 +223,7 @@ export class WrapTransaction extends SharedInteractionTransaction<TransactionTyp
     protected override async buildTransaction(): Promise<void> {
         if (!this.to) throw new Error('To address is required');
 
-        const selectedRedeem = !!this.scriptSigner
+        const selectedRedeem = this.scriptSigner
             ? this.targetScriptRedeem
             : this.leftOverFundsScriptRedeem;
 

package/src/transaction/processor/PsbtTransaction.ts

@@ -1,7 +1,7 @@
+import { Address } from '@btc-vision/bsi-binary';
 import { Network, Psbt, Signer, Transaction } from 'bitcoinjs-lib';
-import { ITweakedTransactionData, TweakedTransaction } from '../shared/TweakedTransaction.js';
 import { PsbtInputExtended, PsbtOutputExtended } from '../interfaces/Tap.js';
-import { Address } from '@btc-vision/bsi-binary';
+import { ITweakedTransactionData, TweakedTransaction } from '../shared/TweakedTransaction.js';
 
 export interface PsbtTransactionData extends ITweakedTransactionData {
     readonly psbt: Psbt;
@@ -141,7 +141,7 @@ export class PsbtTransaction extends TweakedTransaction {
         try {
             const inputs = this.transaction.data.inputs;
             for (let i = n; i < inputs.length; i++) {
-                let input = inputs[i];
+                const input = inputs[i];
                 if (input.finalScriptWitness) {
                     this.transaction.finalizeTaprootInput(i, input.finalScriptWitness);
                 } else {
@@ -151,7 +151,7 @@ export class PsbtTransaction extends TweakedTransaction {
 
             return true;
         } catch (e) {
-            this.warn((e as Error).stack);
+            this.warn((e as Error).stack || "Couldn't finalize inputs");
             return false;
         }
     }

package/src/transaction/shared/TweakedTransaction.ts

@@ -210,7 +210,7 @@ export abstract class TweakedTransaction extends Logger {
         }
 
         let signHash: number = 0;
-        for (let sighashType of sighashTypes) {
+        for (const sighashType of sighashTypes) {
             signHash |= sighashType;
         }
 
@@ -262,7 +262,7 @@ export abstract class TweakedTransaction extends Logger {
 
         this.sequence = TransactionSequence.FINAL;
 
-        for (let input of this.inputs) {
+        for (const input of this.inputs) {
             input.sequence = TransactionSequence.FINAL;
         }
     }
@@ -379,21 +379,25 @@ export abstract class TweakedTransaction extends Logger {
 
                 try {
                     if ('signTaprootInput' in signer) {
-                        // @ts-ignore
-                        return await signer.signTaprootInput(transaction, i, signHash);
+                        // @ts-expect-error - we know it's a taproot signer
+                        return await (signer.signTaprootInput(
+                            transaction,
+                            i,
+                            signHash,
+                        ) as Promise<void>);
                     } else {
                         transaction.signTaprootInput(i, tweakedSigner, undefined, signHash);
                     }
 
                     return;
-                } catch (e) {}
+                } catch {}
             }
         }
 
         try {
             if ('signInput' in signer) {
-                // @ts-ignore
-                return await signer.signInput(transaction, i, signHash);
+                // @ts-expect-error - we know it's a signer
+                return await (signer.signInput(transaction, i, signHash) as Promise<void>);
             } else {
                 transaction.signInput(i, signer, signHash);
             }
@@ -402,8 +406,12 @@ export abstract class TweakedTransaction extends Logger {
                 // and we try again taproot...
 
                 if ('signTaprootInput' in signer) {
-                    // @ts-ignore
-                    return await signer.signTaprootInput(transaction, i, signHash);
+                    // @ts-expect-error - we know it's a taproot signer
+                    return await (signer.signTaprootInput(
+                        transaction,
+                        i,
+                        signHash,
+                    ) as Promise<void>);
                 } else if (this.tweakedSigner) {
                     transaction.signTaprootInput(i, this.tweakedSigner, undefined, signHash);
                 } else {
@@ -421,7 +429,7 @@ export abstract class TweakedTransaction extends Logger {
      */
     protected async signInputs(transaction: Psbt): Promise<void> {
         for (let i = 0; i < transaction.data.inputs.length; i++) {
-            let input: PsbtInput = transaction.data.inputs[i];
+            const input: PsbtInput = transaction.data.inputs[i];
 
             try {
                 await this.signInput(transaction, input, i);
@@ -489,7 +497,7 @@ export abstract class TweakedTransaction extends Logger {
             return;
         }
 
-        return TweakedSigner.tweakSigner(signer as unknown as ECPairInterface, settings) as Signer;
+        return TweakedSigner.tweakSigner(signer as unknown as ECPairInterface, settings);
     }
 
     /**

package/src/utils/BitcoinUtils.ts

@@ -8,9 +8,9 @@ export class BitcoinUtils {
     /**
      * Converts satoshi to BTC
      * @param {number} btc - The amount in BTC
-     * @returns {BigInt} The amount in satoshi
+     * @returns {bigint} The amount in satoshi
      */
-    public static btcToSatoshi(btc: number): BigInt {
+    public static btcToSatoshi(btc: number): bigint {
         return BigInt(btc * 100000000);
     }
 
@@ -82,7 +82,7 @@ export class BitcoinUtils {
 
         let mostPublicKeys: number = 0;
         let vault: VaultUTXOs | undefined;
-        for (let v of vaults) {
+        for (const v of vaults) {
             if (v.publicKeys.length > mostPublicKeys) {
                 mostPublicKeys = v.publicKeys.length;
                 vault = v;

package/src/utxo/OPNetLimitedProvider.ts

@@ -1,10 +1,15 @@
-import { FetchUTXOParams, FetchUTXOParamsMultiAddress, RawUTXOResponse, UTXO } from './interfaces/IUTXO.js';
-import { WrappedGeneration } from '../wbtc/WrappedGenerationParameters.js';
-import { UnwrappedGenerationParameters, WrappedGenerationParameters } from '../wbtc/Generate.js';
-import { BroadcastResponse } from './interfaces/BroadcastResponse.js';
 import { Address } from '@btc-vision/bsi-binary';
-import { UnwrapGeneration } from '../wbtc/UnwrapGeneration.js';
 import { currentConsensusConfig } from '../consensus/ConsensusConfig.js';
+import { UnwrappedGenerationParameters, WrappedGenerationParameters } from '../wbtc/Generate.js';
+import { UnwrapGeneration } from '../wbtc/UnwrapGeneration.js';
+import { WrappedGeneration } from '../wbtc/WrappedGenerationParameters.js';
+import { BroadcastResponse } from './interfaces/BroadcastResponse.js';
+import {
+    FetchUTXOParams,
+    FetchUTXOParamsMultiAddress,
+    RawUTXOResponse,
+    UTXO,
+} from './interfaces/IUTXO.js';
 
 /**
  * Allows to fetch UTXO data from any OPNET node
@@ -36,7 +41,7 @@ export class OPNetLimitedProvider {
             throw new Error(`Failed to fetch UTXO data: ${resp.statusText}`);
         }
 
-        const fetchedData: RawUTXOResponse[] = await resp.json();
+        const fetchedData: RawUTXOResponse[] = (await resp.json()) as RawUTXOResponse[];
         if (fetchedData.length === 0) {
             throw new Error('No UTXO found');
         }
@@ -49,7 +54,7 @@ export class OPNetLimitedProvider {
             throw new Error('No UTXO found (minAmount)');
         }
 
-        let finalUTXOs: UTXO[] = [];
+        const finalUTXOs: UTXO[] = [];
         let currentAmount: bigint = 0n;
 
         const amountRequested: bigint = settings.requestedAmount;
@@ -86,7 +91,7 @@ export class OPNetLimitedProvider {
     public async fetchUTXOMultiAddr(settings: FetchUTXOParamsMultiAddress): Promise<UTXO[]> {
         const promises: Promise<UTXO[]>[] = [];
 
-        for (let address of settings.addresses) {
+        for (const address of settings.addresses) {
             const params: FetchUTXOParams = {
                 address: address,
                 minAmount: settings.minAmount,
@@ -107,7 +112,7 @@ export class OPNetLimitedProvider {
         const finalUTXOs: UTXO[] = [];
         let currentAmount = 0n;
         for (let i = 0; i < all.length; i++) {
-            let utxo = all[i];
+            const utxo = all[i];
 
             if (currentAmount >= settings.requestedAmount) {
                 break;
@@ -168,7 +173,11 @@ export class OPNetLimitedProvider {
             throw new Error(`Failed to fetch to rpc: ${resp.statusText}`);
         }
 
-        const fetchedData = await resp.json();
+        const fetchedData = (await resp.json()) as {
+            result: {
+                error?: string;
+            };
+        };
         if (!fetchedData) {
             throw new Error('No data fetched');
         }

package/webpack.config.js

@@ -2,6 +2,7 @@ import webpack from 'webpack';
 
 export default {
     mode: 'production',
+    target: 'web',
     entry: {
         index: {
             import: './src/index.ts',

package/LICENSE.md

@@ -1,62 +0,0 @@
-# Custom Software License Agreement
-
-## 1. Definitions
-
-- **"Licensor"** refers to the owner(s) and creator(s) of the software. The owner of the github organization "
-  btc-vision", "BlobMaster41".
-- **"User"** refers to any person or entity that accesses or uses the software.
-- **"Software"** refers to the source code, binaries, and documentation, whether in electronic or printed format, made
-  available by Licensor.
-
-## 2. Grant of License
-
-This License permits User to view the Software via the repository hosting the Software ("Hosting Service"). Except as
-provided in this Section, no other use of the Software is permitted. The User may not modify, copy, reproduce,
-republish, upload, post, transmit, or distribute the Software in any way.
-
-## 3. Restrictions
-
-- **Modification and Distribution**: User is prohibited from modifying, merging, distributing, sublicensing, and/or
-  selling copies of the Software.
-- **Commercial Use**: User is prohibited from using the Software for any commercial purposes.
-- **Reverse Engineering**: User is prohibited from reverse engineering, decompiling, or disassembling the Software.
-
-## 4. Termination
-
-This License is effective until terminated by the Licensor. It will terminate immediately without notice from the
-Licensor if User fails to comply with any provision of this License. Upon termination, User must destroy all copies of
-the Software.
-
-## 5. Release to Public
-
-This License restricts the above rights until the Software is officially released to the public by the Licensor. Upon
-such release, the terms of this License may be modified by the Licensor to allow broader use rights.
-
-## 6. Governing Law
-
-This License shall be governed by and construed in accordance with the laws of [Toronto, Canada]. Any legal action or
-proceeding arising under this License will be brought exclusively in the courts located in [Toronto], and the parties
-hereby consent to personal jurisdiction and venue therein.
-
-## 7. Limitation of Liability
-
-In no event will the Licensor be liable for any damages, including, without limitation, indirect, incidental, special,
-consequential, or punitive damages arising out of the use of or inability to use the Software.
-
-## 8. Indemnification
-
-User agrees to indemnify, defend, and hold harmless the Licensor and its affiliates, officers, agents, employees, and
-partners from any claim or demand, including reasonable attorneys' fees, made by any third party due to or arising out
-of User's use of the Software, User's violation of this License, or User's violation of any rights of another.
-
-## 9. Breach of License
-
-Any breach of this License will result in immediate termination of User's rights under this License. Additionally, the
-Licensor reserves the right to pursue any legal action against the User in the event of a breach of this License.
-
-## 10. Acknowledgment
-
-User acknowledges that they have read this License, understand it, and agree to be bound by its terms and conditions.
-User also agrees that this License is the complete and exclusive statement of the agreement between the Licensor and the
-User and supersedes all proposals or prior agreements, oral or written, and any other communications between the
-Licensor and the User relating to the subject matter of this License.