@btc-vision/cli 1.0.0 → 1.0.2

package/src/lib/binary.ts

@@ -184,28 +184,21 @@ export function verifyChecksum(parsed: IParsedPluginFile): boolean {
  * Build a .opnet binary file
  *
  * @param options - Build options
- * @returns The assembled binary
+ * @returns The assembled binary and the checksum that was signed
  */
 export function buildOpnetBinary(options: {
     mldsaLevel: CLIMldsaLevel;
     publicKey: Buffer;
-    signature: Buffer;
     metadata: IPluginMetadata;
     bytecode: Buffer;
     proto?: Buffer;
-}): Buffer {
-    const {
-        mldsaLevel,
-        publicKey,
-        signature,
-        metadata,
-        bytecode,
-        proto = Buffer.alloc(0),
-    } = options;
+    signFn?: (checksum: Buffer) => Buffer;
+}): { binary: Buffer; checksum: Buffer } {
+    const { mldsaLevel, publicKey, metadata, bytecode, proto = Buffer.alloc(0), signFn } = options;
 
     const sdkLevel = cliLevelToMLDSALevel(mldsaLevel);
 
-    // Validate sizes
+    // Validate public key size
     const expectedPkSize = MLDSA_PUBLIC_KEY_SIZES[sdkLevel];
     const expectedSigSize = MLDSA_SIGNATURE_SIZES[sdkLevel];
 
@@ -215,19 +208,28 @@ export function buildOpnetBinary(options: {
         );
     }
 
+    // First pass: compute checksum without the checksum field set
+    const tempMetadata = { ...metadata, checksum: '' };
+    const tempMetadataBytes = Buffer.from(JSON.stringify(tempMetadata), 'utf-8');
+    const checksum = computeChecksum(tempMetadataBytes, bytecode, proto);
+    const checksumHex = `sha256:${checksum.toString('hex')}`;
+
+    // Second pass: serialize metadata with checksum included
+    const finalMetadata = { ...metadata, checksum: checksumHex };
+    const metadataBytes = Buffer.from(JSON.stringify(finalMetadata), 'utf-8');
+
+    // Recompute checksum with the final metadata (includes checksum field)
+    const finalChecksum = computeChecksum(metadataBytes, bytecode, proto);
+
+    // Sign the final checksum (this is what gets verified)
+    const signature = signFn ? signFn(finalChecksum) : Buffer.alloc(expectedSigSize);
+
     if (signature.length !== expectedSigSize) {
         throw new Error(
             `Signature size mismatch: expected ${expectedSigSize}, got ${signature.length}`,
         );
     }
 
-    // Serialize metadata
-    const metadataStr = JSON.stringify(metadata);
-    const metadataBytes = Buffer.from(metadataStr, 'utf-8');
-
-    // Compute checksum
-    const checksum = computeChecksum(metadataBytes, bytecode, proto);
-
     // Calculate total size
     const totalSize =
         8 + // magic
@@ -291,10 +293,10 @@ export function buildOpnetBinary(options: {
     proto.copy(buffer, offset);
     offset += proto.length;
 
-    // Checksum
-    checksum.copy(buffer, offset);
+    // Checksum (use finalChecksum which was computed with metadata containing checksum hex)
+    finalChecksum.copy(buffer, offset);
 
-    return buffer;
+    return { binary: buffer, checksum: finalChecksum };
 }
 
 /**

package/src/lib/config.ts

@@ -10,7 +10,6 @@ import * as fs from 'fs';
 import * as path from 'path';
 import * as os from 'os';
 import { CLIConfig, CLIMldsaLevel, NetworkName } from '../types/index.js';
-import { Address } from '@btc-vision/transaction';
 
 /** Default configuration directory */
 const CONFIG_DIR = path.join(os.homedir(), '.opnet');
@@ -38,9 +37,9 @@ const DEFAULT_CONFIG: CLIConfig = {
     ipfsPinningApiKey: '',
     ipfsPinningAuthHeader: 'Authorization',
     registryAddresses: {
-        mainnet: Address.dead().toHex(), // TODO: Set once deployed
-        testnet: Address.dead().toHex(), // TODO: Set once deployed
-        regtest: Address.dead().toHex(), // TODO: Set once deployed
+        mainnet: '', // TODO: Set once deployed
+        testnet: '', // TODO: Set once deployed
+        regtest: '', // TODO: Set once deployed
     },
     defaultMldsaLevel: 44,
     indexerUrl: 'https://indexer.opnet.org',

package/src/lib/ipfs.ts

@@ -243,7 +243,6 @@ export async function fetchFromIPFS(cid: string): Promise<FetchResult> {
         } catch (error) {
             lastError = error instanceof Error ? error : new Error(String(error));
             // Try next gateway
-            continue;
         }
     }
 

package/src/lib/manifest.ts

@@ -89,6 +89,10 @@ export function validatePermissions(permissions: IPluginPermissions): string[] {
 /**
  * Load and validate a plugin manifest from file
  *
+ * Note: This performs basic validation suitable for source manifests.
+ * The SDK's strict validation requires fields like 'checksum' which
+ * are only computed during compilation, not in source plugin.json.
+ *
  * @param manifestPath - Path to plugin.json
  * @returns The loaded manifest or throws with validation errors
  */
@@ -107,13 +111,33 @@ export function loadManifest(manifestPath: string): IPluginMetadata {
         throw new Error(`Failed to parse manifest: ${e instanceof Error ? e.message : String(e)}`);
     }
 
-    const result = validateManifest(manifest);
-    if (!result.valid) {
-        const errorList = result.errors.map((e) => `  - ${e.path}: ${e.message}`).join('\n');
-        throw new Error(`Invalid manifest:\n${errorList}`);
+    // Basic validation for source manifests (checksum is computed during compilation)
+    const errors: string[] = [];
+    if (!manifest.name || typeof manifest.name !== 'string') {
+        errors.push('name is required');
+    }
+    if (!manifest.version || typeof manifest.version !== 'string') {
+        errors.push('version is required');
+    }
+    if (!manifest.author || typeof manifest.author !== 'object') {
+        errors.push('author is required');
+    }
+    if (!manifest.pluginType || !['standalone', 'library'].includes(manifest.pluginType)) {
+        errors.push('pluginType must be "standalone" or "library"');
+    }
+
+    if (errors.length > 0) {
+        throw new Error(`Invalid manifest:\n${errors.map((e) => `  - ${e}`).join('\n')}`);
+    }
+
+    // Set default checksum for compilation (will be computed)
+    // Cast to mutable to allow setting checksum
+    const result = manifest as { -readonly [K in keyof IPluginMetadata]: IPluginMetadata[K] };
+    if (!result.checksum) {
+        result.checksum = '';
     }
 
-    return manifest as IPluginMetadata;
+    return result as IPluginMetadata;
 }
 
 /**
@@ -139,15 +163,14 @@ export function createManifest(options: {
     email?: string;
     description?: string;
     pluginType: 'standalone' | 'library';
-}): IPluginMetadata {
+}): Omit<IPluginMetadata, 'checksum'> {
     return {
         name: options.name,
         version: '1.0.0',
-        opnetVersion: '^1.0.0',
+        opnetVersion: '>=0.0.1',
         main: 'dist/index.jsc',
         target: 'bytenode',
         type: 'plugin',
-        checksum: '',
         author: {
             name: options.author,
             email: options.email,