@bsv/wallet-toolbox 2.13.0 → 2.13.2

package/out/src/storage/StorageKnex.js

@@ -74,9 +74,15 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
         this.querySpans.delete(query.__knexQueryUid);
         span.end(error == null ? {} : { status: 'error', error });
     }
-    supportsActionBatchPersistence() { return true; }
-    supportsNoSendExpiryPersistence() { return true; }
-    requiresActionBatchCleanupBeforeCreateAction() { return false; }
+    supportsActionBatchPersistence() {
+        return true;
+    }
+    supportsNoSendExpiryPersistence() {
+        return true;
+    }
+    requiresActionBatchCleanupBeforeCreateAction() {
+        return false;
+    }
     async makeAvailable() {
         const settings = await super.makeAvailable();
         this.startPreparedBeefBackfill();
@@ -104,7 +110,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
                 .select('rawTx', 'inputBEEF'));
             if (reqRawTx != null) {
                 r.rawTx = Array.from(reqRawTx.rawTx);
-                r.inputBEEF = Array.from(reqRawTx.inputBEEF);
+                r.inputBEEF = reqRawTx.inputBEEF == null ? undefined : Array.from(reqRawTx.inputBEEF);
             }
         }
         return r;
@@ -162,10 +168,10 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
         const unique = [...new Set(rootTxids)];
         if (unique.length === 0)
             return 0;
-        const row = await this.knex('prepared_beefs')
+        const row = (await this.knex('prepared_beefs')
             .where({ userId, state: 'ready', formatVersion: preparedBeef_1.PREPARED_BEEF_FORMAT_VERSION })
             .whereIn('rootTxid', unique)
-            .first({ byteLength: this.knex.raw('coalesce(sum(length(??)), 0)', ['beef']) });
+            .first({ byteLength: this.knex.raw('coalesce(sum(length(??)), 0)', ['beef']) }));
         return Number(row?.byteLength ?? 0);
     }
     async readPreparedBeefProofEpoch(trx) {
@@ -183,21 +189,22 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
      */
     async readPreparedBeefSourceByteLength(rootTxid) {
         const byteLength = (...columns) => this.knex.raw(columns.map(() => 'coalesce(length(??), 0)').join(' + '), columns);
-        const proven = await this.knex('proven_txs')
+        const proven = (await this.knex('proven_txs')
             .where({ txid: rootTxid })
-            .first({ byteLength: byteLength('rawTx', 'merklePath') });
+            .first({ byteLength: byteLength('rawTx', 'merklePath') }));
         if (proven != null)
             return Number(proven.byteLength);
-        const request = await this.knex('proven_tx_reqs')
+        const request = (await this.knex('proven_tx_reqs')
             .where({ txid: rootTxid })
             .whereIn('status', ['unsent', 'unmined', 'unconfirmed', 'sending', 'nosend', 'completed'])
-            .first({ byteLength: byteLength('rawTx', 'inputBEEF') });
+            .first({ byteLength: byteLength('rawTx', 'inputBEEF') }));
         return request == null ? undefined : Number(request.byteLength);
     }
     async upsertPreparedBeef(artifact, expectedProofEpoch) {
         return await this.transaction(async (trx) => {
-            let epochQuery = this.toDb(trx)('prepared_beef_metadata')
-                .where({ preparedBeefMetadataId: 1 });
+            let epochQuery = this.toDb(trx)('prepared_beef_metadata').where({
+                preparedBeefMetadataId: 1
+            });
             // Serialize a worker commit with proof invalidation across MySQL server
             // processes. SQLite serializes the subsequent write transaction.
             if (this.dbtype === 'MySQL')
@@ -226,7 +233,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
         });
     }
     async findPreparedBeefBackfillRoots(limit, formatVersion) {
-        const rows = await this.knex('outputs as o')
+        const rows = (await this.knex('outputs as o')
             .join('transactions as t', function () {
             this.on('t.transactionId', '=', 'o.transactionId').andOn('t.userId', '=', 'o.userId');
         })
@@ -253,7 +260,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
             .select('o.userId', 'o.txid as rootTxid')
             .groupBy('o.userId', 'o.txid')
             .orderByRaw('MIN(o.outputId)')
-            .limit(limit);
+            .limit(limit));
         return rows;
     }
     async invalidatePreparedBeefs(trx) {
@@ -323,18 +330,14 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
     async stopPreparedBeefTasks() {
         await this.preparedBeefCoordinator.stop();
     }
-    rawTxSliceExpression(offset, length) {
-        const sql = this.dbtype === 'MySQL'
-            ? 'substring(?? from ? for ?)'
-            : 'substr(??, ?, ?)';
+    rawTxSliceExpression(offset, length, dbtype) {
+        const sql = dbtype === 'MySQL' ? 'substring(?? from ? for ?)' : 'substr(??, ?, ?)';
         return this.knex.raw(sql, ['rawTx', offset + 1, length]);
     }
-    async getRawTxSlice(txid, offset, length, trx) {
+    async getRawTxSlice(txid, offset, length, dbtype, trx) {
         const k = this.toDb(trx);
-        const slice = this.rawTxSliceExpression(offset, length);
-        const proven = (0, utilityHelpers_1.verifyOneOrNone)(await k('proven_txs')
-            .select({ rawTx: slice })
-            .where({ txid }));
+        const slice = this.rawTxSliceExpression(offset, length, dbtype);
+        const proven = (0, utilityHelpers_1.verifyOneOrNone)(await k('proven_txs').select({ rawTx: slice }).where({ txid }));
         if (proven?.rawTx != null)
             return Array.from(proven.rawTx);
         const req = (0, utilityHelpers_1.verifyOneOrNone)(await k('proven_tx_reqs')
@@ -351,18 +354,27 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
         if (hasOffset !== hasLength) {
             throw new WERR_errors_1.WERR_INVALID_PARAMETER('offset and length', 'both defined or both undefined');
         }
-        if (hasOffset && (!/^[0-9a-f]{64}$/i.test(txid) ||
-            !Number.isSafeInteger(offset) ||
-            !Number.isSafeInteger(length) ||
-            offset < 0 ||
-            length < 0 ||
-            !Number.isSafeInteger(offset + length))) {
+        if (hasOffset &&
+            (!/^[0-9a-f]{64}$/i.test(txid) ||
+                !Number.isSafeInteger(offset) ||
+                !Number.isSafeInteger(length) ||
+                offset < 0 ||
+                length < 0 ||
+                !Number.isSafeInteger(offset + length))) {
             throw new WERR_errors_1.WERR_INVALID_PARAMETER('txid, offset and length', 'a hexadecimal transaction id and non-negative safe slice integers with a safe sum');
         }
-        if (!this.isAvailable())
-            await this.makeAvailable();
+        // A cold caller may already own SQLite's only connection. Read settings
+        // through that transaction without caching uncommitted state or starting
+        // the background backfill before the caller commits.
+        let settings;
+        if (this.isAvailable())
+            settings = this.getSettings();
+        else if (trx != null)
+            settings = await this.readSettings(trx);
+        else
+            settings = await this.makeAvailable();
         if (hasOffset) {
-            return await this.getRawTxSlice(txid, offset, length, trx);
+            return await this.getRawTxSlice(txid, offset, length, settings.dbtype, trx);
         }
         const r = await this.getProvenOrRawTx(txid, trx);
         return r.proven != null ? r.proven.rawTx : r.rawTx;
@@ -373,7 +385,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
             void this.whereExists(k
                 .select('*')
                 .from('transactions')
-                .whereRaw(`proven_txs.provenTxId = transactions.provenTxId and transactions.userId = ${args.userId}`));
+                .whereRaw('proven_txs.provenTxId = transactions.provenTxId and transactions.userId = ?', [args.userId]));
         });
         if (args.paged != null) {
             q = q.limit(args.paged.limit);
@@ -394,7 +406,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
             void this.whereExists(k
                 .select('*')
                 .from('transactions')
-                .whereRaw(`proven_tx_reqs.txid = transactions.txid and transactions.userId = ${args.userId}`));
+                .whereRaw('proven_tx_reqs.txid = transactions.txid and transactions.userId = ?', [args.userId]));
         });
         if (args.paged != null) {
             q = q.limit(args.paged.limit);
@@ -414,7 +426,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
         let q = k('tx_labels_map').whereExists(k
             .select('*')
             .from('tx_labels')
-            .whereRaw(`tx_labels.txLabelId = tx_labels_map.txLabelId and tx_labels.userId = ${args.userId}`));
+            .whereRaw('tx_labels.txLabelId = tx_labels_map.txLabelId and tx_labels.userId = ?', [args.userId]));
         if (args.since != null)
             q = q.where('updated_at', '>=', this.validateDateForWhere(args.since));
         if (args.paged != null) {
@@ -433,7 +445,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
         let q = k('output_tags_map').whereExists(k
             .select('*')
             .from('output_tags')
-            .whereRaw(`output_tags.outputTagId = output_tags_map.outputTagId and output_tags.userId = ${args.userId}`));
+            .whereRaw('output_tags.outputTagId = output_tags_map.outputTagId and output_tags.userId = ?', [args.userId]));
         if (args.since != null)
             q = q.where('updated_at', '>=', this.validateDateForWhere(args.since));
         if (args.paged != null) {
@@ -517,10 +529,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
         return row == null ? undefined : this.validateEntity(row, ['expiresAt', 'hardExpiresAt']);
     }
     async findActionBatchForUpdate(userId, batchId, trx) {
-        const row = await this.toDb(trx)('action_batches')
-            .where({ userId, batchId })
-            .forUpdate()
-            .first();
+        const row = await this.toDb(trx)('action_batches').where({ userId, batchId }).forUpdate().first();
         return row == null ? undefined : this.validateEntity(row, ['expiresAt', 'hardExpiresAt']);
     }
     async findExpiredActionBatches(now, trx) {
@@ -596,9 +605,9 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
         const rows = [];
         const uniqueDigests = [...new Set(digests)];
         for (let offset = 0; offset < uniqueDigests.length; offset += ACTION_BATCH_BLOB_SQL_CHUNK) {
-            rows.push(...await this.toDb(trx)('action_batch_blobs')
+            rows.push(...(await this.toDb(trx)('action_batch_blobs')
                 .where({ actionBatchId })
-                .whereIn('digest', uniqueDigests.slice(offset, offset + ACTION_BATCH_BLOB_SQL_CHUNK)));
+                .whereIn('digest', uniqueDigests.slice(offset, offset + ACTION_BATCH_BLOB_SQL_CHUNK))));
         }
         for (const row of rows) {
             if (Buffer.isBuffer(row.bytes)) {
@@ -644,7 +653,8 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
         return user.userId;
     }
     async insertCertificateAuth(auth, certificate) {
-        if (auth.userId == null || (certificate.userId != null && certificate.userId !== 0 && certificate.userId !== auth.userId))
+        if (auth.userId == null ||
+            (certificate.userId != null && certificate.userId !== 0 && certificate.userId !== auth.userId))
             throw new WERR_errors_1.WERR_UNAUTHORIZED();
         certificate.userId = auth.userId;
         return await this.insertCertificate(certificate);
@@ -940,9 +950,9 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
     }
     findCertificatesQuery(args) {
         const q = this.setupQuery('certificates', args);
-        if ((args.certifiers != null) && args.certifiers.length > 0)
+        if (args.certifiers != null && args.certifiers.length > 0)
             void q.whereIn('certifier', args.certifiers);
-        if ((args.types != null) && args.types.length > 0)
+        if (args.types != null && args.types.length > 0)
             void q.whereIn('type', args.types);
         return q;
     }
@@ -960,10 +970,30 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
             throw new WERR_errors_1.WERR_INVALID_PARAMETER('args.partial.lockingScript', 'undefined. Outputs may not be found by lockingScript value.');
         }
         const q = this.setupQuery('outputs', args);
-        if ((args.txStatus != null) && args.txStatus.length > 0) {
-            void q.whereRaw(`(select status from transactions where transactions.transactionId = outputs.transactionId) in (${args.txStatus.map(s => "'" + s + "'").join(',')})`);
+        if (args.txStatus != null && args.txStatus.length > 0) {
+            const allowedStatuses = new Set([
+                'completed',
+                'failed',
+                'unprocessed',
+                'sending',
+                'unproven',
+                'unsigned',
+                'nosend',
+                'nonfinal',
+                'unfail'
+            ]);
+            if (args.txStatus.some(status => !allowedStatuses.has(status))) {
+                throw new WERR_errors_1.WERR_INVALID_PARAMETER('args.txStatus', 'supported transaction statuses');
+            }
+            const statuses = [...new Set(args.txStatus)];
+            void q.whereExists(function () {
+                void this.select(1)
+                    .from('transactions')
+                    .whereRaw('?? = ??', ['transactions.transactionId', 'outputs.transactionId'])
+                    .whereIn('transactions.status', statuses);
+            });
         }
-        if ((args.noScript === true) && count !== true) {
+        if (args.noScript === true && count !== true) {
             const columns = tables_1.outputColumnsWithoutLockingScript.map(c => `outputs.${c}`);
             void q.select(columns);
         }
@@ -971,7 +1001,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
     }
     findOutputTagMapsQuery(args) {
         const q = this.setupQuery('output_tags_map', args);
-        if ((args.tagIds != null) && args.tagIds.length > 0)
+        if (args.tagIds != null && args.tagIds.length > 0)
             void q.whereIn('outputTagId', args.tagIds);
         return q;
     }
@@ -986,7 +1016,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
             throw new WERR_errors_1.WERR_INVALID_PARAMETER('args.partial.inputBEEF', 'undefined. ProvenTxReqs may not be found by inputBEEF value.');
         }
         const q = this.setupQuery('proven_tx_reqs', args);
-        if ((args.status != null) && args.status.length > 0)
+        if (args.status != null && args.status.length > 0)
             void q.whereIn('status', args.status);
         if (args.txids != null) {
             const txids = args.txids.filter(txid => txid !== undefined);
@@ -1029,13 +1059,13 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
             throw new WERR_errors_1.WERR_INVALID_PARAMETER('args.partial.inputBEEF', 'undefined. Transactions may not be found by inputBEEF value.');
         }
         const q = this.setupQuery('transactions', args);
-        if ((args.status != null) && args.status.length > 0)
+        if (args.status != null && args.status.length > 0)
             void q.whereIn('status', args.status);
         if (args.from != null)
             void q.where('created_at', '>=', this.validateDateForWhere(args.from));
         if (args.to != null)
             void q.where('created_at', '<', this.validateDateForWhere(args.to));
-        if ((args.noRawTx === true) && count !== true) {
+        if (args.noRawTx === true && count !== true) {
             const columns = tables_1.transactionColumnsWithoutRawTx.map(c => `transactions.${c}`);
             void q.select(columns);
         }
@@ -1043,7 +1073,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
     }
     findTxLabelMapsQuery(args) {
         const q = this.setupQuery('tx_labels_map', args);
-        if ((args.labelIds != null) && args.labelIds.length > 0)
+        if (args.labelIds != null && args.labelIds.length > 0)
             void q.whereIn('txLabelId', args.labelIds);
         return q;
     }
@@ -1057,19 +1087,32 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
         return this.setupQuery('monitor_events', args);
     }
     async findCertificatesAuth(auth, args) {
-        if (auth.userId == null || (args.partial.userId != null && args.partial.userId !== 0 && args.partial.userId !== auth.userId))
+        if (auth.userId == null ||
+            (args.partial.userId != null && args.partial.userId !== 0 && args.partial.userId !== auth.userId))
             throw new WERR_errors_1.WERR_UNAUTHORIZED();
         args.partial.userId = auth.userId;
         return await this.findCertificates(args);
     }
+    async findProvenTxReqsAuth(auth, args) {
+        const userId = (0, utilityHelpers_1.verifyId)(auth.userId);
+        const k = this.toDb(args.trx);
+        const q = this.findProvenTxReqsQuery(args).whereExists(k
+            .select(1)
+            .from('transactions')
+            .whereRaw('proven_tx_reqs.txid = transactions.txid')
+            .where('transactions.userId', userId));
+        return this.validateEntities(await q, undefined, ['notified', 'wasBroadcast']);
+    }
     async findOutputBasketsAuth(auth, args) {
-        if (auth.userId == null || (args.partial.userId != null && args.partial.userId !== 0 && args.partial.userId !== auth.userId))
+        if (auth.userId == null ||
+            (args.partial.userId != null && args.partial.userId !== 0 && args.partial.userId !== auth.userId))
             throw new WERR_errors_1.WERR_UNAUTHORIZED();
         args.partial.userId = auth.userId;
         return await this.findOutputBaskets(args);
     }
     async findOutputsAuth(auth, args) {
-        if (auth.userId == null || (args.partial.userId != null && args.partial.userId !== 0 && args.partial.userId !== auth.userId))
+        if (auth.userId == null ||
+            (args.partial.userId != null && args.partial.userId !== 0 && args.partial.userId !== auth.userId))
             throw new WERR_errors_1.WERR_UNAUTHORIZED();
         args.partial.userId = auth.userId;
         return await this.findOutputs(args);
@@ -1139,7 +1182,9 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
     async findSyncStates(args) {
         const q = this.findSyncStatesQuery(args);
         // Serialize sync checkpoint reads with the page transaction on MySQL too.
-        if (args.trx != null && this.dbtype === 'MySQL' && args.partial.userId != null &&
+        if (args.trx != null &&
+            this.dbtype === 'MySQL' &&
+            args.partial.userId != null &&
             (args.partial.syncStateId != null || args.partial.storageIdentityKey != null))
             q.forUpdate();
         const r = await q;
@@ -1253,24 +1298,32 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
         // Check if this is a SQLite database by looking at the Knex client config
         const clientName = this.knex.client.config?.client ?? '';
         const isSQLite = clientName.includes('sqlite');
-        // For SQLite, disable transactions during migrations and turn off foreign keys.
-        // PRAGMA foreign_keys is silently ignored inside transactions, so we must
-        // disable transactions for the migration to allow the PRAGMA to take effect.
-        // See: https://github.com/knex/knex/issues/4155
+        // For SQLite, turn foreign keys off for the duration of the migration.
+        // PRAGMA foreign_keys is silently ignored *when executed inside* a
+        // transaction (https://github.com/knex/knex/issues/4155), so it is issued
+        // here, outside migrate.latest(). SQLite's single-connection pool means
+        // knex's per-migration transaction runs on this same connection and
+        // inherits the setting, and knex's own SQLite alter-table rebuild leaves an
+        // ambient pragma alone while transacting (sqlite3/schema/ddl.js: alter()
+        // uses `enforceForeignCheck = this.client.transacting ? null : false`).
         if (isSQLite) {
             await this.knex.raw('PRAGMA foreign_keys = OFF;');
         }
-        const config = {
-            migrationSource: new KnexMigrations_1.KnexMigrations(this.chain, storageName, storageIdentityKey, 1024),
-            disableTransactions: isSQLite
-        };
-        await this.knex.migrate.latest(config);
-        const version = await this.knex.migrate.currentVersion(config);
-        // Re-enable foreign key checks for SQLite
-        if (isSQLite) {
-            await this.knex.raw('PRAGMA foreign_keys = ON;');
+        try {
+            const config = {
+                migrationSource: new KnexMigrations_1.KnexMigrations(this.chain, storageName, storageIdentityKey, 1024),
+                // Keep DDL and its migration journal entry in the same transaction.
+                disableTransactions: false
+            };
+            await this.knex.migrate.latest(config);
+            return await this.knex.migrate.currentVersion(config);
+        }
+        finally {
+            // Leaving foreign-key enforcement disabled after a failed migration would
+            // weaken every subsequent write on this connection.
+            if (isSQLite)
+                await this.knex.raw('PRAGMA foreign_keys = ON;');
         }
-        return version;
     }
     async dropAllData() {
         // Only using migrations to migrate down, don't need valid properties for settings table.
@@ -1292,24 +1345,22 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
         if (isSQLite) {
             await this.knex.raw('PRAGMA foreign_keys = OFF;');
         }
-        for (let i = 0; i < count; i++) {
-            try {
-                const r = await this.knex.migrate.down(config);
-                if (r == null) {
-                    console.error('Migration returned falsy result await this.knex.migrate.down(config)');
-                    break;
-                }
+        try {
+            for (let i = 0; i < count; i++) {
+                const version = await this.knex.migrate.currentVersion(config);
+                if (version === 'none')
+                    return;
+                const result = await this.knex.migrate.down(config);
+                if (result == null)
+                    throw new WERR_errors_1.WERR_INTERNAL('database migration rollback returned no result');
             }
-            catch (migrationError) {
-                // migrate.down throws when there are no more migrations to roll back — this is
-                // the expected terminal condition, so we stop iterating rather than propagating.
-                console.debug('migrate.down stopped (no more migrations or error):', migrationError);
-                break;
+            if ((await this.knex.migrate.currentVersion(config)) !== 'none') {
+                throw new WERR_errors_1.WERR_INTERNAL('database migration rollback did not reach the empty schema');
             }
         }
-        // Re-enable foreign key checks for SQLite
-        if (isSQLite) {
-            await this.knex.raw('PRAGMA foreign_keys = ON;');
+        finally {
+            if (isSQLite)
+                await this.knex.raw('PRAGMA foreign_keys = ON;');
         }
     }
     async transaction(scope, trx) {
@@ -1327,7 +1378,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
     toDb(trx) {
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        const db = (trx == null) ? this.knex : trx;
+        const db = trx == null ? this.knex : trx;
         this.whenLastAccess = new Date();
         return db;
     }
@@ -1744,7 +1795,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
             .whereIn('t.status', status)
             .sum({ totalSatoshis: 'o.satoshis' })
             .first();
-        const total = (row != null) ? row.totalSatoshis : undefined;
+        const total = row != null ? row.totalSatoshis : undefined;
         return Number(total ?? 0);
     }
     /**
@@ -1774,9 +1825,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
                 .whereNot('o.derivationSuffix', '')
                 .whereNull('o.spentBy')
                 .whereNotExists(function () {
-                void this.select(1)
-                    .from('action_batch_outputs as abo')
-                    .whereRaw('abo.outputId = o.outputId');
+                void this.select(1).from('action_batch_outputs as abo').whereRaw('abo.outputId = o.outputId');
             })
                 .whereIn('t.status', status)
                 .select('o.*')
@@ -1854,7 +1903,8 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
             for (const df of booleanFields) {
                 // eslint-disable-next-line @typescript-eslint/no-explicit-any
                 if (entity[df] !== undefined)
-                    entity[df] = entity[df] !== 0 && entity[df] != null && entity[df] !== false;
+                    entity[df] =
+                        entity[df] !== 0 && entity[df] != null && entity[df] !== false;
             }
         }
         this.deserialiseFromKnex(entity);
@@ -1879,7 +1929,7 @@ class StorageKnex extends StorageProvider_1.StorageProvider {
             orderDescending: true,
             paged: { limit: 1 }
         }));
-        const monitorStats = (monitorEvent != null) ? JSON.parse(monitorEvent.details) : undefined;
+        const monitorStats = monitorEvent != null ? JSON.parse(monitorEvent.details) : undefined;
         const servicesStats = this.getServices().getServicesCallHistory(true);
         const oneDayAgo = new Date(Date.now() - 24 * 60 * 60 * 1000).toISOString();
         const oneWeekAgo = new Date(Date.now() - 7 * 24 * 60 * 60 * 1000).toISOString();