@bsv/wallet-toolbox-mobile 2.3.2 → 2.4.0

package/out/src/services/providers/Arcade.js

@@ -0,0 +1,299 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.Arcade = void 0;
+const sdk_1 = require("@bsv/sdk");
+const utilityHelpers_1 = require("../../utility/utilityHelpers");
+const WalletError_1 = require("../../sdk/WalletError");
+// Shared wire-contract types only (no behavior coupling): Arcade is ARC-compatible on the
+// configuration and `getTxData` response shape, so it reuses those interfaces.
+const ARC_1 = require("./ARC");
+function defaultDeploymentId() {
+    return `ts-sdk-${sdk_1.Utils.toHex((0, sdk_1.Random)(16))}`;
+}
+/**
+ * Broadcaster for bsv-blockchain/arcade — the Teranode-native, ARC-compatible broadcaster.
+ *
+ * Arcade is intentionally a separate, self-contained class (not a subclass of {@link ARC}) so
+ * the audited ARC transport is never altered. It is ARC-compatible on headers, configuration and
+ * the `getTxData` response shape — but differs where it must:
+ *
+ *  - Endpoints are served at the root: `/tx` and `/tx/{txid}` (no `/v1` prefix).
+ *  - A submit returns HTTP 202; HTTP 400 is a terminal validation failure (REJECTED) and is
+ *    surfaced as an invalid-transaction status error rather than a transient service error.
+ *  - Submission encoding is Extended Format (EF), not BEEF: Arcade's `/tx` parser rejects BEEF
+ *    ("failed to parse transaction") and runs fee/script validation that needs per-input source
+ *    data, which EF carries inline.
+ */
+class Arcade {
+    name;
+    URL;
+    apiKey;
+    deploymentId;
+    callbackUrl;
+    callbackToken;
+    headers;
+    httpClient;
+    constructor(URL, config, name) {
+        this.name = name ?? 'arcade';
+        this.URL = URL;
+        if (typeof config === 'string') {
+            this.apiKey = config;
+            this.httpClient = (0, sdk_1.defaultHttpClient)();
+            this.deploymentId = defaultDeploymentId();
+            this.callbackToken = undefined;
+            this.callbackUrl = undefined;
+        }
+        else {
+            const configObj = config ?? {};
+            const { apiKey, deploymentId, httpClient, callbackToken, callbackUrl, headers } = configObj;
+            this.apiKey = apiKey;
+            this.httpClient = httpClient ?? (0, sdk_1.defaultHttpClient)();
+            this.deploymentId = deploymentId ?? defaultDeploymentId();
+            this.callbackToken = callbackToken;
+            this.callbackUrl = callbackUrl;
+            this.headers = headers;
+        }
+    }
+    /** Constructs a dictionary of the default & supplied request headers. */
+    requestHeaders() {
+        const headers = {
+            'Content-Type': 'application/json',
+            'XDeployment-ID': this.deploymentId
+        };
+        if (this.apiKey != null && this.apiKey !== '') {
+            headers.Authorization = `Bearer ${this.apiKey}`;
+        }
+        if (this.callbackUrl != null && this.callbackUrl !== '') {
+            headers['X-CallbackUrl'] = this.callbackUrl;
+        }
+        if (this.callbackToken != null && this.callbackToken !== '') {
+            headers['X-CallbackToken'] = this.callbackToken;
+        }
+        if (this.headers != null) {
+            for (const key in this.headers) {
+                headers[key] = this.headers[key];
+            }
+        }
+        return headers;
+    }
+    /**
+     * Submit a single transaction to Arcade's `POST /tx` endpoint.
+     *
+     * `rawTx` must be a single (raw or Extended Format) transaction hex — NOT BEEF. The canonical
+     * txid is taken from `txids` when supplied (Arcade derives the same txid from the parsed tx).
+     */
+    async postRawTx(rawTx, txids) {
+        let txid = sdk_1.Utils.toHex((0, utilityHelpers_1.doubleSha256BE)(sdk_1.Utils.toArray(rawTx, 'hex')));
+        if (txids == null) {
+            txids = [txid];
+        }
+        else {
+            txid = txids.at(-1);
+        }
+        const requestOptions = {
+            method: 'POST',
+            headers: this.requestHeaders(),
+            data: { rawTx },
+            signal: AbortSignal.timeout(1000 * 30) // 30 seconds timeout, error.code will be 'ABORT_ERR'
+        };
+        const r = {
+            txid,
+            status: 'success',
+            notes: []
+        };
+        const url = `${this.URL}/tx`;
+        const nn = () => ({ name: this.name, when: new Date().toISOString() });
+        const nne = () => ({ ...nn(), rawTx, txids: txids.join(','), url });
+        try {
+            const response = await this.httpClient.request(url, requestOptions);
+            const { txid, extraInfo, txStatus, competingTxs } = response.data;
+            const nnr = () => ({
+                txid,
+                extraInfo,
+                txStatus,
+                competingTxs: competingTxs?.join(',')
+            });
+            if (response.ok) {
+                // Arcade's 202 submit response omits extraInfo; avoid a trailing 'undefined'.
+                r.data = extraInfo != null && extraInfo !== '' ? `${txStatus} ${extraInfo}` : `${txStatus}`;
+                if (r.txid !== txid)
+                    r.data += ` txid altered from ${r.txid} to ${txid}`;
+                r.txid = txid;
+                if ((0, ARC_1.isArcDoubleSpendTxStatus)(txStatus)) {
+                    r.status = 'error';
+                    r.doubleSpend = true;
+                    r.competingTxs = competingTxs;
+                    r.notes.push({ ...nne(), ...nnr(), what: 'postRawTxDoubleSpend' });
+                }
+                else {
+                    r.notes.push({ ...nn(), ...nnr(), what: 'postRawTxSuccess' });
+                }
+            }
+            else if (typeof response === 'string') {
+                r.notes.push({ ...nne(), what: 'postRawTxString', response });
+                r.status = 'error';
+                // response is not normally a string
+                r.serviceError = true;
+            }
+            else {
+                r.status = 'error';
+                // Arcade returns HTTP 400 for terminal validation errors — surface those as
+                // invalid-transaction status errors while keeping rate limits, batch limits,
+                // 5xx/backpressure and unknown failures as service errors.
+                const n = {
+                    ...nn(),
+                    ...nne(),
+                    ...nnr(),
+                    what: 'postRawTxError'
+                };
+                const ed = {};
+                r.data = ed;
+                const st = typeof response.status;
+                let status;
+                if (st === 'number' || st === 'string') {
+                    n.status = response.status;
+                    ed.status = response.status.toString();
+                    if (typeof response.status === 'number')
+                        status = response.status;
+                    else {
+                        const parsed = Number(response.status);
+                        if (Number.isFinite(parsed))
+                            status = parsed;
+                    }
+                }
+                else {
+                    n.status = st;
+                    ed.status = 'ERR_UNKNOWN';
+                }
+                const d = response.data;
+                if (d && typeof d === 'string') {
+                    n.data = response.data.slice(0, 128);
+                }
+                else if (d && typeof d === 'object') {
+                    ed.more = d;
+                    ed.detail = d.detail;
+                    if (typeof ed.detail !== 'string')
+                        ed.detail = undefined;
+                    if (ed.detail) {
+                        n.detail = ed.detail;
+                    }
+                }
+                r.serviceError = (0, ARC_1.isArcServiceErrorStatus)(status, ed.detail);
+                r.notes.push(n);
+            }
+        }
+        catch (error_) {
+            const e = WalletError_1.WalletError.fromUnknown(error_);
+            r.status = 'error';
+            r.serviceError = true;
+            r.data = `${e.code} ${e.message}`;
+            r.notes.push({
+                ...nne(),
+                what: 'postRawTxCatch',
+                code: e.code,
+                description: e.description
+            });
+        }
+        return r;
+    }
+    /**
+     * Post each tx of interest as Extended Format (EF).
+     *
+     * EF needs each input's source output (satoshis + locking script). For a BEEF that carries every
+     * direct parent transaction in full (e.g. the atomic BEEF produced by createAction), that data is
+     * present and {@link Transaction.fromBEEF} can reconstruct EF. A BEEF is NOT guaranteed to contain
+     * it, however: BEEF V2 `txidOnly` entries (or an otherwise pruned BEEF) can reference a direct
+     * parent without its bytes, leaving no source output to embed — so BEEF -> EF is not always
+     * possible. When EF cannot be built for a txid, it is recorded as a (non-terminal) service error
+     * so cross-provider aggregation falls through to a BEEF-capable broadcaster, which can still
+     * broadcast the (valid) transaction.
+     */
+    async postBeef(beef, txids) {
+        const r = {
+            name: this.name,
+            status: 'success',
+            txidResults: [],
+            notes: []
+        };
+        const nn = () => ({ name: this.name, when: new Date().toISOString() });
+        const beefBin = beef.toBinary();
+        for (const txid of txids) {
+            let efHex;
+            try {
+                efHex = sdk_1.Transaction.fromBEEF(beefBin, txid).toHexEF();
+            }
+            catch (error_) {
+                const e = WalletError_1.WalletError.fromUnknown(error_);
+                r.status = 'error';
+                const tr = {
+                    txid,
+                    status: 'error',
+                    serviceError: true,
+                    notes: [{ ...nn(), what: 'arcadeEfBuildFailed', txid, code: e.code, description: e.description }]
+                };
+                r.txidResults.push(tr);
+                continue;
+            }
+            const prtr = await this.postRawTx(efHex, [txid]);
+            r.txidResults.push(prtr);
+            if (prtr.status === 'error')
+                r.status = 'error';
+        }
+        return r;
+    }
+    /** Look up a transaction's current status (and merkle path once mined) via `GET /tx/{txid}`. */
+    async getTxData(txid) {
+        const requestOptions = {
+            method: 'GET',
+            headers: this.requestHeaders()
+        };
+        const response = await this.httpClient.request(`${this.URL}/tx/${txid}`, requestOptions);
+        return response.data;
+    }
+    /**
+     * `getMerklePath` provider: obtain a BUMP merkle proof for a mined transaction from Arcade.
+     *
+     * Arcade only has a proof for transactions it tracked (i.e. broadcast through it) that have
+     * been mined while tracked; for anything else `GET /tx/{txid}` reports a non-mined status (or
+     * 404) and this returns no `merklePath`, so {@link Services.getMerklePath} falls through to the
+     * other providers (WhatsOnChain/Bitails).
+     *
+     * The proof is NOT trusted blindly: the canonical block header is resolved from the wallet's
+     * own chaintracker via `services.hashToHeader(blockHash)` (which only knows real, mined blocks),
+     * and the BUMP's computed merkle root must equal that header's `merkleRoot`. Only then is the
+     * proof returned, with the canonical `header` that downstream proof completion requires.
+     */
+    async getMerklePath(txid, services) {
+        const r = { name: this.name, notes: [] };
+        const nn = () => ({ name: this.name, when: new Date().toISOString() });
+        try {
+            const data = await this.getTxData(txid);
+            const mined = data.txStatus === 'MINED' || data.txStatus === 'IMMUTABLE';
+            if (!mined || data.merklePath == null || data.merklePath === '' || data.blockHash == null || data.blockHash === '') {
+                // No proof from Arcade yet (not mined / untracked / 404) — fall through to other providers.
+                r.notes.push({ ...nn(), what: 'getMerklePathArcadeNoProof', txid, txStatus: data.txStatus });
+                return r;
+            }
+            const merklePath = sdk_1.MerklePath.fromHex(data.merklePath);
+            // Resolve the canonical header from our own chaintracker; throws if the block is unknown.
+            const header = await services.hashToHeader(data.blockHash);
+            const computedRoot = merklePath.computeRoot(txid);
+            if (computedRoot !== header.merkleRoot) {
+                // Arcade's BUMP does not reconcile with the canonical block — reject and fall through.
+                r.notes.push({ ...nn(), what: 'getMerklePathArcadeRootMismatch', txid, computedRoot, headerRoot: header.merkleRoot, blockHash: data.blockHash });
+                return r;
+            }
+            r.merklePath = merklePath;
+            r.header = header;
+            r.notes.push({ ...nn(), what: 'getMerklePathArcadeSuccess', txid, height: header.height, blockHash: header.hash });
+        }
+        catch (error_) {
+            const e = WalletError_1.WalletError.fromUnknown(error_);
+            r.error = e;
+            r.notes.push({ ...nn(), what: 'getMerklePathArcadeError', txid, code: e.code, description: e.description });
+        }
+        return r;
+    }
+}
+exports.Arcade = Arcade;
+//# sourceMappingURL=Arcade.js.map

package/out/src/services/providers/Arcade.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"Arcade.js","sourceRoot":"","sources":["../../../../../src/services/providers/Arcade.ts"],"names":[],"mappings":";;;AAAA,kCAUiB;AAQjB,iEAA6D;AAE7D,uDAAmD;AACnD,0FAA0F;AAC1F,+EAA+E;AAC/E,+BAAuG;AAEvG,SAAS,mBAAmB;IAC1B,OAAO,UAAU,WAAK,CAAC,KAAK,CAAC,IAAA,YAAM,EAAC,EAAE,CAAC,CAAC,EAAE,CAAA;AAC5C,CAAC;AAED;;;;;;;;;;;;;GAaG;AACH,MAAa,MAAM;IACR,IAAI,CAAQ;IACZ,GAAG,CAAQ;IACX,MAAM,CAAoB;IAC1B,YAAY,CAAQ;IACpB,WAAW,CAAoB;IAC/B,aAAa,CAAoB;IACjC,OAAO,CAAoC;IACnC,UAAU,CAAY;IAQvC,YAAa,GAAW,EAAE,MAA2B,EAAE,IAAa;QAClE,IAAI,CAAC,IAAI,GAAG,IAAI,IAAI,QAAQ,CAAA;QAC5B,IAAI,CAAC,GAAG,GAAG,GAAG,CAAA;QACd,IAAI,OAAO,MAAM,KAAK,QAAQ,EAAE,CAAC;YAC/B,IAAI,CAAC,MAAM,GAAG,MAAM,CAAA;YACpB,IAAI,CAAC,UAAU,GAAG,IAAA,uBAAiB,GAAE,CAAA;YACrC,IAAI,CAAC,YAAY,GAAG,mBAAmB,EAAE,CAAA;YACzC,IAAI,CAAC,aAAa,GAAG,SAAS,CAAA;YAC9B,IAAI,CAAC,WAAW,GAAG,SAAS,CAAA;QAC9B,CAAC;aAAM,CAAC;YACN,MAAM,SAAS,GAAc,MAAM,IAAI,EAAE,CAAA;YACzC,MAAM,EAAE,MAAM,EAAE,YAAY,EAAE,UAAU,EAAE,aAAa,EAAE,WAAW,EAAE,OAAO,EAAE,GAAG,SAAS,CAAA;YAC3F,IAAI,CAAC,MAAM,GAAG,MAAM,CAAA;YACpB,IAAI,CAAC,UAAU,GAAG,UAAU,IAAI,IAAA,uBAAiB,GAAE,CAAA;YACnD,IAAI,CAAC,YAAY,GAAG,YAAY,IAAI,mBAAmB,EAAE,CAAA;YACzD,IAAI,CAAC,aAAa,GAAG,aAAa,CAAA;YAClC,IAAI,CAAC,WAAW,GAAG,WAAW,CAAA;YAC9B,IAAI,CAAC,OAAO,GAAG,OAAO,CAAA;QACxB,CAAC;IACH,CAAC;IAED,yEAAyE;IACjE,cAAc;QACpB,MAAM,OAAO,GAA2B;YACtC,cAAc,EAAE,kBAAkB;YAClC,gBAAgB,EAAE,IAAI,CAAC,YAAY;SACpC,CAAA;QAED,IAAI,IAAI,CAAC,MAAM,IAAI,IAAI,IAAI,IAAI,CAAC,MAAM,KAAK,EAAE,EAAE,CAAC;YAC9C,OAAO,CAAC,aAAa,GAAG,UAAU,IAAI,CAAC,MAAM,EAAE,CAAA;QACjD,CAAC;QAED,IAAI,IAAI,CAAC,WAAW,IAAI,IAAI,IAAI,IAAI,CAAC,WAAW,KAAK,EAAE,EAAE,CAAC;YACxD,OAAO,CAAC,eAAe,CAAC,GAAG,IAAI,CAAC,WAAW,CAAA;QAC7C,CAAC;QAED,IAAI,IAAI,CAAC,aAAa,IAAI,IAAI,IAAI,IAAI,CAAC,aAAa,KAAK,EAAE,EAAE,CAAC;YAC5D,OAAO,CAAC,iBAAiB,CAAC,GAAG,IAAI,CAAC,aAAa,CAAA;QACjD,CAAC;QAED,IAAI,IAAI,CAAC,OAAO,IAAI,IAAI,EAAE,CAAC;YACzB,KAAK,MAAM,GAAG,IAAI,IAAI,CAAC,OAAO,EAAE,CAAC;gBAC/B,OAAO,CAAC,GAAG,CAAC,GAAG,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAA;YAClC,CAAC;QACH,CAAC;QAED,OAAO,OAAO,CAAA;IAChB,CAAC;IAED;;;;;OAKG;IACH,KAAK,CAAC,SAAS,CAAE,KAAgB,EAAE,KAAgB;QACjD,IAAI,IAAI,GAAG,WAAK,CAAC,KAAK,CAAC,IAAA,+BAAc,EAAC,WAAK,CAAC,OAAO,CAAC,KAAK,EAAE,KAAK,CAAC,CAAC,CAAC,CAAA;QACnE,IAAI,KAAK,IAAI,IAAI,EAAE,CAAC;YAClB,KAAK,GAAG,CAAC,IAAI,CAAC,CAAA;QAChB,CAAC;aAAM,CAAC;YACN,IAAI,GAAG,KAAK,CAAC,EAAE,CAAC,CAAC,CAAC,CAAE,CAAA;QACtB,CAAC;QAED,MAAM,cAAc,GAA6B;YAC/C,MAAM,EAAE,MAAM;YACd,OAAO,EAAE,IAAI,CAAC,cAAc,EAAE;YAC9B,IAAI,EAAE,EAAE,KAAK,EAAE;YACf,MAAM,EAAE,WAAW,CAAC,OAAO,CAAC,IAAI,GAAG,EAAE,CAAC,CAAC,qDAAqD;SAC7F,CAAA;QAED,MAAM,CAAC,GAAwB;YAC7B,IAAI;YACJ,MAAM,EAAE,SAAS;YACjB,KAAK,EAAE,EAAE;SACV,CAAA;QAED,MAAM,GAAG,GAAG,GAAG,IAAI,CAAC,GAAG,KAAK,CAAA;QAC5B,MAAM,EAAE,GAAG,GAAG,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,IAAI,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE,CAAC,CAAA;QACtE,MAAM,GAAG,GAAG,GAAG,EAAE,CAAC,CAAC,EAAE,GAAG,EAAE,EAAE,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,EAAE,GAAG,EAAE,CAAC,CAAA;QAEnE,IAAI,CAAC;YACH,MAAM,QAAQ,GAAG,MAAM,IAAI,CAAC,UAAU,CAAC,OAAO,CAAiB,GAAG,EAAE,cAAc,CAAC,CAAA;YAEnF,MAAM,EAAE,IAAI,EAAE,SAAS,EAAE,QAAQ,EAAE,YAAY,EAAE,GAAG,QAAQ,CAAC,IAAI,CAAA;YACjE,MAAM,GAAG,GAAG,GAAG,EAAE,CAAC,CAAC;gBACjB,IAAI;gBACJ,SAAS;gBACT,QAAQ;gBACR,YAAY,EAAE,YAAY,EAAE,IAAI,CAAC,GAAG,CAAC;aACtC,CAAC,CAAA;YAEF,IAAI,QAAQ,CAAC,EAAE,EAAE,CAAC;gBAChB,8EAA8E;gBAC9E,CAAC,CAAC,IAAI,GAAG,SAAS,IAAI,IAAI,IAAI,SAAS,KAAK,EAAE,CAAC,CAAC,CAAC,GAAG,QAAQ,IAAI,SAAS,EAAE,CAAC,CAAC,CAAC,GAAG,QAAQ,EAAE,CAAA;gBAC3F,IAAI,CAAC,CAAC,IAAI,KAAK,IAAI;oBAAE,CAAC,CAAC,IAAI,IAAI,sBAAsB,CAAC,CAAC,IAAI,OAAO,IAAI,EAAE,CAAA;gBACxE,CAAC,CAAC,IAAI,GAAG,IAAI,CAAA;gBACb,IAAI,IAAA,8BAAwB,EAAC,QAAQ,CAAC,EAAE,CAAC;oBACvC,CAAC,CAAC,MAAM,GAAG,OAAO,CAAA;oBAClB,CAAC,CAAC,WAAW,GAAG,IAAI,CAAA;oBACpB,CAAC,CAAC,YAAY,GAAG,YAAY,CAAA;oBAC7B,CAAC,CAAC,KAAM,CAAC,IAAI,CAAC,EAAE,GAAG,GAAG,EAAE,EAAE,GAAG,GAAG,EAAE,EAAE,IAAI,EAAE,sBAAsB,EAAE,CAAC,CAAA;gBACrE,CAAC;qBAAM,CAAC;oBACN,CAAC,CAAC,KAAM,CAAC,IAAI,CAAC,EAAE,GAAG,EAAE,EAAE,EAAE,GAAG,GAAG,EAAE,EAAE,IAAI,EAAE,kBAAkB,EAAE,CAAC,CAAA;gBAChE,CAAC;YACH,CAAC;iBAAM,IAAI,OAAO,QAAQ,KAAK,QAAQ,EAAE,CAAC;gBACxC,CAAC,CAAC,KAAM,CAAC,IAAI,CAAC,EAAE,GAAG,GAAG,EAAE,EAAE,IAAI,EAAE,iBAAiB,EAAE,QAAQ,EAAE,CAAC,CAAA;gBAC9D,CAAC,CAAC,MAAM,GAAG,OAAO,CAAA;gBAClB,oCAAoC;gBACpC,CAAC,CAAC,YAAY,GAAG,IAAI,CAAA;YACvB,CAAC;iBAAM,CAAC;gBACN,CAAC,CAAC,MAAM,GAAG,OAAO,CAAA;gBAClB,4EAA4E;gBAC5E,6EAA6E;gBAC7E,2DAA2D;gBAC3D,MAAM,CAAC,GAAmB;oBACxB,GAAG,EAAE,EAAE;oBACP,GAAG,GAAG,EAAE;oBACR,GAAG,GAAG,EAAE;oBACR,IAAI,EAAE,gBAAgB;iBACvB,CAAA;gBACD,MAAM,EAAE,GAA6B,EAAE,CAAA;gBACvC,CAAC,CAAC,IAAI,GAAG,EAAE,CAAA;gBACX,MAAM,EAAE,GAAG,OAAO,QAAQ,CAAC,MAAM,CAAA;gBACjC,IAAI,MAA0B,CAAA;gBAC9B,IAAI,EAAE,KAAK,QAAQ,IAAI,EAAE,KAAK,QAAQ,EAAE,CAAC;oBACvC,CAAC,CAAC,MAAM,GAAG,QAAQ,CAAC,MAAM,CAAA;oBAC1B,EAAE,CAAC,MAAM,GAAG,QAAQ,CAAC,MAAM,CAAC,QAAQ,EAAE,CAAA;oBACtC,IAAI,OAAO,QAAQ,CAAC,MAAM,KAAK,QAAQ;wBAAE,MAAM,GAAG,QAAQ,CAAC,MAAM,CAAA;yBAC5D,CAAC;wBACJ,MAAM,MAAM,GAAG,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAA;wBACtC,IAAI,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC;4BAAE,MAAM,GAAG,MAAM,CAAA;oBAC9C,CAAC;gBACH,CAAC;qBAAM,CAAC;oBACN,CAAC,CAAC,MAAM,GAAG,EAAE,CAAA;oBACb,EAAE,CAAC,MAAM,GAAG,aAAa,CAAA;gBAC3B,CAAC;gBAED,MAAM,CAAC,GAAG,QAAQ,CAAC,IAAI,CAAA;gBACvB,IAAI,CAAC,IAAI,OAAO,CAAC,KAAK,QAAQ,EAAE,CAAC;oBAC/B,CAAC,CAAC,IAAI,GAAI,QAAQ,CAAC,IAAe,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC,CAAA;gBAClD,CAAC;qBAAM,IAAI,CAAC,IAAI,OAAO,CAAC,KAAK,QAAQ,EAAE,CAAC;oBACtC,EAAE,CAAC,IAAI,GAAG,CAAC,CAAA;oBACX,EAAE,CAAC,MAAM,GAAI,CAA0B,CAAC,MAA4B,CAAA;oBACpE,IAAI,OAAO,EAAE,CAAC,MAAM,KAAK,QAAQ;wBAAE,EAAE,CAAC,MAAM,GAAG,SAAS,CAAA;oBACxD,IAAI,EAAE,CAAC,MAAM,EAAE,CAAC;wBACd,CAAC,CAAC,MAAM,GAAG,EAAE,CAAC,MAAM,CAAA;oBACtB,CAAC;gBACH,CAAC;gBACD,CAAC,CAAC,YAAY,GAAG,IAAA,6BAAuB,EAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,CAAA;gBAC3D,CAAC,CAAC,KAAM,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;YAClB,CAAC;QACH,CAAC;QAAC,OAAO,MAAe,EAAE,CAAC;YACzB,MAAM,CAAC,GAAG,yBAAW,CAAC,WAAW,CAAC,MAAM,CAAC,CAAA;YACzC,CAAC,CAAC,MAAM,GAAG,OAAO,CAAA;YAClB,CAAC,CAAC,YAAY,GAAG,IAAI,CAAA;YACrB,CAAC,CAAC,IAAI,GAAG,GAAG,CAAC,CAAC,IAAI,IAAI,CAAC,CAAC,OAAO,EAAE,CAAA;YACjC,CAAC,CAAC,KAAM,CAAC,IAAI,CAAC;gBACZ,GAAG,GAAG,EAAE;gBACR,IAAI,EAAE,gBAAgB;gBACtB,IAAI,EAAE,CAAC,CAAC,IAAI;gBACZ,WAAW,EAAE,CAAC,CAAC,WAAW;aAC3B,CAAC,CAAA;QACJ,CAAC;QAED,OAAO,CAAC,CAAA;IACV,CAAC;IAED;;;;;;;;;;;OAWG;IACH,KAAK,CAAC,QAAQ,CAAE,IAAU,EAAE,KAAe;QACzC,MAAM,CAAC,GAAmB;YACxB,IAAI,EAAE,IAAI,CAAC,IAAI;YACf,MAAM,EAAE,SAAS;YACjB,WAAW,EAAE,EAAE;YACf,KAAK,EAAE,EAAE;SACV,CAAA;QACD,MAAM,EAAE,GAAG,GAAG,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,IAAI,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE,CAAC,CAAA;QACtE,MAAM,OAAO,GAAG,IAAI,CAAC,QAAQ,EAAE,CAAA;QAE/B,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;YACzB,IAAI,KAAa,CAAA;YACjB,IAAI,CAAC;gBACH,KAAK,GAAG,iBAAW,CAAC,QAAQ,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC,OAAO,EAAE,CAAA;YACvD,CAAC;YAAC,OAAO,MAAe,EAAE,CAAC;gBACzB,MAAM,CAAC,GAAG,yBAAW,CAAC,WAAW,CAAC,MAAM,CAAC,CAAA;gBACzC,CAAC,CAAC,MAAM,GAAG,OAAO,CAAA;gBAClB,MAAM,EAAE,GAAwB;oBAC9B,IAAI;oBACJ,MAAM,EAAE,OAAO;oBACf,YAAY,EAAE,IAAI;oBAClB,KAAK,EAAE,CAAC,EAAE,GAAG,EAAE,EAAE,EAAE,IAAI,EAAE,qBAAqB,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,WAAW,EAAE,CAAC,CAAC,WAAW,EAAE,CAAC;iBAClG,CAAA;gBACD,CAAC,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;gBACtB,SAAQ;YACV,CAAC;YAED,MAAM,IAAI,GAAG,MAAM,IAAI,CAAC,SAAS,CAAC,KAAK,EAAE,CAAC,IAAI,CAAC,CAAC,CAAA;YAChD,CAAC,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;YACxB,IAAI,IAAI,CAAC,MAAM,KAAK,OAAO;gBAAE,CAAC,CAAC,MAAM,GAAG,OAAO,CAAA;QACjD,CAAC;QAED,OAAO,CAAC,CAAA;IACV,CAAC;IAED,gGAAgG;IAChG,KAAK,CAAC,SAAS,CAAE,IAAY;QAC3B,MAAM,cAAc,GAA6B;YAC/C,MAAM,EAAE,KAAK;YACb,OAAO,EAAE,IAAI,CAAC,cAAc,EAAE;SAC/B,CAAA;QAED,MAAM,QAAQ,GAAG,MAAM,IAAI,CAAC,UAAU,CAAC,OAAO,CAAoB,GAAG,IAAI,CAAC,GAAG,OAAO,IAAI,EAAE,EAAE,cAAc,CAAC,CAAA;QAE3G,OAAO,QAAQ,CAAC,IAAI,CAAA;IACtB,CAAC;IAED;;;;;;;;;;;;OAYG;IACH,KAAK,CAAC,aAAa,CAAE,IAAY,EAAE,QAAwB;QACzD,MAAM,CAAC,GAAwB,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE,EAAE,CAAA;QAC7D,MAAM,EAAE,GAAG,GAAmC,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,IAAI,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE,EAAE,CAAC,CAAA;QAEtG,IAAI,CAAC;YACH,MAAM,IAAI,GAAG,MAAM,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAA;YACvC,MAAM,KAAK,GAAG,IAAI,CAAC,QAAQ,KAAK,OAAO,IAAI,IAAI,CAAC,QAAQ,KAAK,WAAW,CAAA;YACxE,IAAI,CAAC,KAAK,IAAI,IAAI,CAAC,UAAU,IAAI,IAAI,IAAI,IAAI,CAAC,UAAU,KAAK,EAAE,IAAI,IAAI,CAAC,SAAS,IAAI,IAAI,IAAI,IAAI,CAAC,SAAS,KAAK,EAAE,EAAE,CAAC;gBACnH,4FAA4F;gBAC5F,CAAC,CAAC,KAAM,CAAC,IAAI,CAAC,EAAE,GAAG,EAAE,EAAE,EAAE,IAAI,EAAE,4BAA4B,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,CAAC,QAAQ,EAAE,CAAC,CAAA;gBAC7F,OAAO,CAAC,CAAA;YACV,CAAC;YAED,MAAM,UAAU,GAAG,gBAAU,CAAC,OAAO,CAAC,IAAI,CAAC,UAAU,CAAC,CAAA;YACtD,0FAA0F;YAC1F,MAAM,MAAM,GAAG,MAAM,QAAQ,CAAC,YAAY,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;YAC1D,MAAM,YAAY,GAAG,UAAU,CAAC,WAAW,CAAC,IAAI,CAAC,CAAA;YACjD,IAAI,YAAY,KAAK,MAAM,CAAC,UAAU,EAAE,CAAC;gBACvC,uFAAuF;gBACvF,CAAC,CAAC,KAAM,CAAC,IAAI,CAAC,EAAE,GAAG,EAAE,EAAE,EAAE,IAAI,EAAE,iCAAiC,EAAE,IAAI,EAAE,YAAY,EAAE,UAAU,EAAE,MAAM,CAAC,UAAU,EAAE,SAAS,EAAE,IAAI,CAAC,SAAS,EAAE,CAAC,CAAA;gBACjJ,OAAO,CAAC,CAAA;YACV,CAAC;YAED,CAAC,CAAC,UAAU,GAAG,UAAU,CAAA;YACzB,CAAC,CAAC,MAAM,GAAG,MAAM,CAAA;YACjB,CAAC,CAAC,KAAM,CAAC,IAAI,CAAC,EAAE,GAAG,EAAE,EAAE,EAAE,IAAI,EAAE,4BAA4B,EAAE,IAAI,EAAE,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,EAAE,MAAM,CAAC,IAAI,EAAE,CAAC,CAAA;QACrH,CAAC;QAAC,OAAO,MAAe,EAAE,CAAC;YACzB,MAAM,CAAC,GAAG,yBAAW,CAAC,WAAW,CAAC,MAAM,CAAC,CAAA;YACzC,CAAC,CAAC,KAAK,GAAG,CAAC,CAAA;YACX,CAAC,CAAC,KAAM,CAAC,IAAI,CAAC,EAAE,GAAG,EAAE,EAAE,EAAE,IAAI,EAAE,0BAA0B,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC,IAAI,EAAE,WAAW,EAAE,CAAC,CAAC,WAAW,EAAE,CAAC,CAAA;QAC9G,CAAC;QAED,OAAO,CAAC,CAAA;IACV,CAAC;CACF;AAjSD,wBAiSC"}

package/out/src/signer/methods/buildSignableTransaction.d.ts

@@ -8,6 +8,60 @@ export declare function buildSignableTransaction(dctr: StorageCreateActionResult
     pdi: PendingStorageInput[];
     log: string;
 };
+/**
+ * Verify that the outputs returned by storage for caller-specified outputs match
+ * exactly what the caller requested in `args.outputs`.
+ *
+ * The storage response (`StorageCreateActionResult.outputs`) is ordered, by
+ * contract, as: the caller's `args.outputs` in their original order, followed by
+ * the optional commission output, followed by storage-provided change outputs.
+ * Only the `vout` field is randomized when `randomizeOutputs` is set; the array
+ * order is stable. Therefore array index `i` (for `i < args.outputs.length`)
+ * corresponds to `args.outputs[i]`.
+ *
+ * Because the locking script that is ultimately signed is taken from the storage
+ * response, an untrusted storage provider must not be allowed to alter the
+ * recipient script (or amount) of a caller-specified output. Any mismatch is a
+ * hard error. (GHSA-36f9-7rg5-cpf8)
+ *
+ * @throws WERR_INVALID_PARAMETER if storage omitted, reclassified, or modified
+ *   any caller-specified output.
+ */
+export declare function verifyRequestedOutputsUnchanged(storageOutputs: StorageCreateTransactionSdkOutput[], args: Validation.ValidCreateActionArgs): void;
+/**
+ * Default ceiling for a storage-provided commission (service-charge) output, in
+ * satoshis. The commission is the one output whose locking script is taken
+ * verbatim from storage and cannot be re-derived or verified client-side, so a
+ * malicious storage operator could point it at an attacker address. Capping it
+ * bounds the worst-case loss from that single output; honest commissions are far
+ * below this. (GHSA-36f9-7rg5-cpf8)
+ */
+export declare const MAX_STORAGE_COMMISSION_SATOSHIS = 500000;
+/**
+ * Verify that every storage output beyond the caller's requested outputs is
+ * either a change output or the (single, bounded) commission output.
+ *
+ * The storage response is ordered `[caller outputs][commission?][change...]`;
+ * `verifyRequestedOutputsUnchanged` already validates the caller region (indices
+ * `< args.outputs.length`). This checks the remainder.
+ *
+ * Change outputs (`providedBy: 'storage', purpose: 'change'`) are safe at any
+ * amount: `buildSignableTransaction` ignores the storage-supplied script and
+ * re-derives it client-side (`makeChangeLock` / BRC-29 under the client's own
+ * change key), so a change output can only ever pay the client. A change output
+ * mislabeled by storage is therefore harmless.
+ *
+ * The commission output's script, by contrast, is taken verbatim from storage
+ * and cannot be verified client-side. A malicious storage could inject an extra
+ * output — or relabel one as commission — to redirect funds to an attacker while
+ * the caller/UI only sees the requested recipients. To bound that, at most one
+ * commission output is allowed and its amount must not exceed `maxCommission`.
+ * Any other unrecognized output is rejected outright.
+ *
+ * @throws WERR_INVALID_PARAMETER if storage returned an unrecognized output, more
+ *   than one commission output, or a commission exceeding `maxCommission`.
+ */
+export declare function verifyUnrequestedOutputsAreChangeOrCommission(storageOutputs: StorageCreateTransactionSdkOutput[], args: Validation.ValidCreateActionArgs, maxCommission?: number): void;
 /**
  * Derive a change output locking script
  */

package/out/src/signer/methods/buildSignableTransaction.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"buildSignableTransaction.d.ts","sourceRoot":"","sources":["../../../../../src/signer/methods/buildSignableTransaction.ts"],"names":[],"mappings":"AAAA,OAAO,EAAQ,MAAM,EAAE,WAAW,EAAuC,UAAU,EAAE,MAAM,UAAU,CAAA;AACrG,OAAO,EAAE,MAAM,EAAE,mBAAmB,EAAE,MAAM,cAAc,CAAA;AAC1D,OAAO,EACL,yBAAyB,EAEzB,iCAAiC,EAClC,MAAM,oCAAoC,CAAA;AAG3C,OAAO,EAAE,OAAO,EAAE,MAAM,iBAAiB,CAAA;AAGzC,wBAAgB,wBAAwB,CACtC,IAAI,EAAE,yBAAyB,EAC/B,IAAI,EAAE,UAAU,CAAC,qBAAqB,EACtC,MAAM,EAAE,MAAM,GACb;IACC,EAAE,EAAE,WAAW,CAAA;IACf,MAAM,EAAE,MAAM,CAAA;IACd,GAAG,EAAE,mBAAmB,EAAE,CAAA;IAC1B,GAAG,EAAE,MAAM,CAAA;CACZ,CA8IF;AAED;;GAEG;AACH,wBAAgB,cAAc,CAC5B,GAAG,EAAE,iCAAiC,EACtC,IAAI,EAAE,yBAAyB,EAC/B,IAAI,EAAE,UAAU,CAAC,qBAAqB,EACtC,UAAU,EAAE,OAAO,EACnB,MAAM,EAAE,MAAM,GACb,MAAM,CAUR"}
+{"version":3,"file":"buildSignableTransaction.d.ts","sourceRoot":"","sources":["../../../../../src/signer/methods/buildSignableTransaction.ts"],"names":[],"mappings":"AAAA,OAAO,EAAQ,MAAM,EAAE,WAAW,EAAuC,UAAU,EAAE,MAAM,UAAU,CAAA;AACrG,OAAO,EAAE,MAAM,EAAE,mBAAmB,EAAE,MAAM,cAAc,CAAA;AAC1D,OAAO,EACL,yBAAyB,EAEzB,iCAAiC,EAClC,MAAM,oCAAoC,CAAA;AAG3C,OAAO,EAAE,OAAO,EAAE,MAAM,iBAAiB,CAAA;AAGzC,wBAAgB,wBAAwB,CACtC,IAAI,EAAE,yBAAyB,EAC/B,IAAI,EAAE,UAAU,CAAC,qBAAqB,EACtC,MAAM,EAAE,MAAM,GACb;IACC,EAAE,EAAE,WAAW,CAAA;IACf,MAAM,EAAE,MAAM,CAAA;IACd,GAAG,EAAE,mBAAmB,EAAE,CAAA;IAC1B,GAAG,EAAE,MAAM,CAAA;CACZ,CA+JF;AAED;;;;;;;;;;;;;;;;;;GAkBG;AACH,wBAAgB,+BAA+B,CAC7C,cAAc,EAAE,iCAAiC,EAAE,EACnD,IAAI,EAAE,UAAU,CAAC,qBAAqB,GACrC,IAAI,CAsCN;AAED;;;;;;;GAOG;AACH,eAAO,MAAM,+BAA+B,SAAS,CAAA;AAErD;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,wBAAgB,6CAA6C,CAC3D,cAAc,EAAE,iCAAiC,EAAE,EACnD,IAAI,EAAE,UAAU,CAAC,qBAAqB,EACtC,aAAa,GAAE,MAAwC,GACtD,IAAI,CAkCN;AAED;;GAEG;AACH,wBAAgB,cAAc,CAC5B,GAAG,EAAE,iCAAiC,EACtC,IAAI,EAAE,yBAAyB,EAC/B,IAAI,EAAE,UAAU,CAAC,qBAAqB,EACtC,UAAU,EAAE,OAAO,EACnB,MAAM,EAAE,MAAM,GACb,MAAM,CAUR"}

package/out/src/signer/methods/buildSignableTransaction.js

@@ -1,6 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.MAX_STORAGE_COMMISSION_SATOSHIS = void 0;
 exports.buildSignableTransaction = buildSignableTransaction;
+exports.verifyRequestedOutputsUnchanged = verifyRequestedOutputsUnchanged;
+exports.verifyUnrequestedOutputsAreChangeOrCommission = verifyUnrequestedOutputsAreChangeOrCommission;
 exports.makeChangeLock = makeChangeLock;
 const sdk_1 = require("@bsv/sdk");
 const WERR_errors_1 = require("../../sdk/WERR_errors");
@@ -10,6 +13,21 @@ function buildSignableTransaction(dctr, args, wallet) {
     const changeKeys = wallet.getClientChangeKeyPair();
     const inputBeef = (args.inputBEEF != null) ? sdk_1.Beef.fromBinary(args.inputBEEF) : undefined;
     const { inputs: storageInputs, outputs: storageOutputs } = dctr;
+    // SECURITY (GHSA-36f9-7rg5-cpf8): The locking scripts used to build and sign
+    // the transaction are taken from the storage response. When storage is remote
+    // (StorageClient, the default configuration), a malicious or compromised
+    // storage operator could return a different recipient script than the caller
+    // requested; it would be signed and broadcast while the calling app/UI still
+    // shows the originally requested recipient. Verify that every caller-specified
+    // output is echoed back by storage unchanged before anything is signed.
+    verifyRequestedOutputsUnchanged(storageOutputs, args);
+    // SECURITY (GHSA-36f9-7rg5-cpf8): verifyRequestedOutputsUnchanged only protects
+    // the caller's own outputs. Storage could instead inject an ADDITIONAL output
+    // paying an attacker (funded by reducing change), which the loop below signs
+    // verbatim. Every output beyond the caller's must be either a change output
+    // (script re-derived client-side, so it can only pay the client) or the single
+    // bounded commission output. Anything else is rejected before signing.
+    verifyUnrequestedOutputsAreChangeOrCommission(storageOutputs, args);
     const tx = new sdk_1.Transaction(args.version, [], [], args.lockTime);
     // The order of outputs in storageOutputs is always:
     // CreateActionArgs.outputs in the original order
@@ -79,8 +97,7 @@ function buildSignableTransaction(dctr, args, wallet) {
         if (argsInput != null) {
             // Type 1: User supplied input, with or without an explicit unlockingScript.
             // If without, signAction must be used to provide the actual unlockScript.
-            const hasUnlock = typeof argsInput.unlockingScript === 'string';
-            const unlock = hasUnlock ? (0, utilityHelpers_1.asBsvSdkScript)(argsInput.unlockingScript) : new sdk_1.Script();
+            const unlock = typeof argsInput.unlockingScript === 'string' ? (0, utilityHelpers_1.asBsvSdkScript)(argsInput.unlockingScript) : new sdk_1.Script();
             const sourceTransaction = args.isSignAction ? inputBeef?.findTxid(argsInput.outpoint.txid)?.tx : undefined;
             const inputToAdd = {
                 sourceTXID: argsInput.outpoint.txid,
@@ -132,6 +149,105 @@ function buildSignableTransaction(dctr, args, wallet) {
         log: ''
     };
 }
+/**
+ * Verify that the outputs returned by storage for caller-specified outputs match
+ * exactly what the caller requested in `args.outputs`.
+ *
+ * The storage response (`StorageCreateActionResult.outputs`) is ordered, by
+ * contract, as: the caller's `args.outputs` in their original order, followed by
+ * the optional commission output, followed by storage-provided change outputs.
+ * Only the `vout` field is randomized when `randomizeOutputs` is set; the array
+ * order is stable. Therefore array index `i` (for `i < args.outputs.length`)
+ * corresponds to `args.outputs[i]`.
+ *
+ * Because the locking script that is ultimately signed is taken from the storage
+ * response, an untrusted storage provider must not be allowed to alter the
+ * recipient script (or amount) of a caller-specified output. Any mismatch is a
+ * hard error. (GHSA-36f9-7rg5-cpf8)
+ *
+ * @throws WERR_INVALID_PARAMETER if storage omitted, reclassified, or modified
+ *   any caller-specified output.
+ */
+function verifyRequestedOutputsUnchanged(storageOutputs, args) {
+    for (let i = 0; i < args.outputs.length; i++) {
+        const requested = args.outputs[i];
+        const provided = storageOutputs[i];
+        if (provided == null) {
+            throw new WERR_errors_1.WERR_INVALID_PARAMETER('storage outputs', `present for every requested output. Storage did not return an output for requested output index ${i}.`);
+        }
+        // A caller-specified output must never be reclassified by storage as change
+        // or as storage-provided; doing so would route it through makeChangeLock and
+        // bypass the script comparison below.
+        if (provided.purpose === 'change' || provided.providedBy === 'storage') {
+            throw new WERR_errors_1.WERR_INVALID_PARAMETER('output.providedBy', `consistent with the request. Storage reclassified requested output ${i} as providedBy='${provided.providedBy}' purpose='${provided.purpose ?? ''}'.`);
+        }
+        const requestedScript = (requested.lockingScript ?? '').toLowerCase();
+        const providedScript = (typeof provided.lockingScript === 'string' ? provided.lockingScript : '').toLowerCase();
+        if (requestedScript.length === 0 || requestedScript !== providedScript) {
+            throw new WERR_errors_1.WERR_INVALID_PARAMETER('output.lockingScript', `equal to the caller-requested locking script. Storage returned a different locking script for output index ${i}; the recipient may have been substituted.`);
+        }
+        if (provided.satoshis !== requested.satoshis) {
+            throw new WERR_errors_1.WERR_INVALID_PARAMETER('output.satoshis', `equal to the caller-requested satoshis. Storage returned ${provided.satoshis} for output index ${i}, caller requested ${requested.satoshis}.`);
+        }
+    }
+}
+/**
+ * Default ceiling for a storage-provided commission (service-charge) output, in
+ * satoshis. The commission is the one output whose locking script is taken
+ * verbatim from storage and cannot be re-derived or verified client-side, so a
+ * malicious storage operator could point it at an attacker address. Capping it
+ * bounds the worst-case loss from that single output; honest commissions are far
+ * below this. (GHSA-36f9-7rg5-cpf8)
+ */
+exports.MAX_STORAGE_COMMISSION_SATOSHIS = 500000;
+/**
+ * Verify that every storage output beyond the caller's requested outputs is
+ * either a change output or the (single, bounded) commission output.
+ *
+ * The storage response is ordered `[caller outputs][commission?][change...]`;
+ * `verifyRequestedOutputsUnchanged` already validates the caller region (indices
+ * `< args.outputs.length`). This checks the remainder.
+ *
+ * Change outputs (`providedBy: 'storage', purpose: 'change'`) are safe at any
+ * amount: `buildSignableTransaction` ignores the storage-supplied script and
+ * re-derives it client-side (`makeChangeLock` / BRC-29 under the client's own
+ * change key), so a change output can only ever pay the client. A change output
+ * mislabeled by storage is therefore harmless.
+ *
+ * The commission output's script, by contrast, is taken verbatim from storage
+ * and cannot be verified client-side. A malicious storage could inject an extra
+ * output — or relabel one as commission — to redirect funds to an attacker while
+ * the caller/UI only sees the requested recipients. To bound that, at most one
+ * commission output is allowed and its amount must not exceed `maxCommission`.
+ * Any other unrecognized output is rejected outright.
+ *
+ * @throws WERR_INVALID_PARAMETER if storage returned an unrecognized output, more
+ *   than one commission output, or a commission exceeding `maxCommission`.
+ */
+function verifyUnrequestedOutputsAreChangeOrCommission(storageOutputs, args, maxCommission = exports.MAX_STORAGE_COMMISSION_SATOSHIS) {
+    let commissionCount = 0;
+    for (let i = args.outputs.length; i < storageOutputs.length; i++) {
+        const out = storageOutputs[i];
+        const isChange = out.providedBy === 'storage' && out.purpose === 'change';
+        if (isChange)
+            continue;
+        // Honest storage remaps a service-charge to purpose 'storage-commission';
+        // accept the pre-remap label too so the check is robust across versions.
+        const isCommission = out.providedBy === 'storage' && (out.purpose === 'storage-commission' || out.purpose === 'service-charge');
+        if (isCommission) {
+            commissionCount++;
+            if (commissionCount > 1) {
+                throw new WERR_errors_1.WERR_INVALID_PARAMETER('storage outputs', `at most one commission output. Storage returned an extra commission output at index ${i}.`);
+            }
+            if (out.satoshis > maxCommission) {
+                throw new WERR_errors_1.WERR_INVALID_PARAMETER('output.satoshis', `a commission no greater than ${maxCommission}. Storage returned a commission of ${out.satoshis} at index ${i}; funds could be redirected to an attacker.`);
+            }
+            continue;
+        }
+        throw new WERR_errors_1.WERR_INVALID_PARAMETER('storage outputs', 'only change or commission beyond the requested outputs. Storage returned an unrecognized output ' +
+            `(providedBy='${out.providedBy}' purpose='${out.purpose ?? ''}') at index ${i}; funds could be redirected to an attacker.`);
+    }
+}
 /**
  * Derive a change output locking script
  */

package/out/src/signer/methods/buildSignableTransaction.js.map

@@ -1 +1 @@
-{"version":3,"file":"buildSignableTransaction.js","sourceRoot":"","sources":["../../../../../src/signer/methods/buildSignableTransaction.ts"],"names":[],"mappings":";;AAYA,4DAuJC;AAKD,wCAgBC;AAxLD,kCAAqG;AAOrG,uDAA8D;AAC9D,iEAA2E;AAE3E,2EAAuE;AAEvE,SAAgB,wBAAwB,CACtC,IAA+B,EAC/B,IAAsC,EACtC,MAAc;IAOd,MAAM,UAAU,GAAG,MAAM,CAAC,sBAAsB,EAAE,CAAA;IAElD,MAAM,SAAS,GAAG,CAAC,IAAI,CAAC,SAAS,IAAI,IAAI,CAAC,CAAC,CAAC,CAAC,UAAI,CAAC,UAAU,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,SAAS,CAAA;IAExF,MAAM,EAAE,MAAM,EAAE,aAAa,EAAE,OAAO,EAAE,cAAc,EAAE,GAAG,IAAI,CAAA;IAE/D,MAAM,EAAE,GAAG,IAAI,iBAAW,CAAC,IAAI,CAAC,OAAO,EAAE,EAAE,EAAE,EAAE,EAAE,IAAI,CAAC,QAAQ,CAAC,CAAA;IAE/D,oDAAoD;IACpD,iDAAiD;IACjD,oBAAoB;IACpB,iBAAiB;IACjB,gGAAgG;IAChG,MAAM,WAAW,GAAG,IAAI,KAAK,CAAS,cAAc,CAAC,MAAM,CAAC,CAAA;IAC5D,KAAK,IAAI,IAAI,GAAG,CAAC,EAAE,IAAI,GAAG,cAAc,CAAC,MAAM,EAAE,IAAI,EAAE,EAAE,CAAC;QACxD,MAAM,CAAC,GAAG,cAAc,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,IAAI,CAAC,CAAA;QACxD,IAAI,CAAC,GAAG,CAAC;YAAE,MAAM,IAAI,oCAAsB,CAAC,aAAa,EAAE,eAAe,IAAI,aAAa,CAAC,CAAA;QAC5F,WAAW,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;IACvB,CAAC;IAED,eAAe;IACf,cAAc;IACd,cAAc;IACd,KAAK,IAAI,IAAI,GAAG,CAAC,EAAE,IAAI,GAAG,cAAc,CAAC,MAAM,EAAE,IAAI,EAAE,EAAE,CAAC;QACxD,MAAM,CAAC,GAAG,WAAW,CAAC,IAAI,CAAC,CAAA;QAC3B,MAAM,GAAG,GAAG,cAAc,CAAC,CAAC,CAAC,CAAA;QAC7B,IAAI,IAAI,KAAK,GAAG,CAAC,IAAI,EAAE,CAAC;YAAC,MAAM,IAAI,oCAAsB,CAAC,aAAa,EAAE,yBAAyB,GAAG,CAAC,IAAI,QAAQ,IAAI,EAAE,CAAC,CAAA;QAAC,CAAC;QAE3H,MAAM,MAAM,GAAG,GAAG,CAAC,UAAU,KAAK,SAAS,IAAI,GAAG,CAAC,OAAO,KAAK,QAAQ,CAAA;QAEvE,MAAM,aAAa,GAAG,MAAM;YAC1B,CAAC,CAAC,cAAc,CAAC,GAAG,EAAE,IAAI,EAAE,IAAI,EAAE,UAAU,EAAE,MAAM,CAAC;YACrD,CAAC,CAAC,IAAA,+BAAc,EAAC,GAAG,CAAC,aAAa,CAAC,CAAA;QAErC,MAAM,MAAM,GAAsB;YAChC,QAAQ,EAAE,GAAG,CAAC,QAAQ;YACtB,aAAa;YACb,MAAM;SACP,CAAA;QACD,EAAE,CAAC,SAAS,CAAC,MAAM,CAAC,CAAA;IACtB,CAAC;IAED,IAAI,cAAc,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAChC,yFAAyF;QACzF,MAAM,MAAM,GAAsB;YAChC,QAAQ,EAAE,CAAC;YACX,aAAa,EAAE,YAAM,CAAC,OAAO,CAAC,uBAAuB,CAAC;YACtD,MAAM,EAAE,KAAK;SACd,CAAA;QACD,EAAE,CAAC,SAAS,CAAC,MAAM,CAAC,CAAA;IACtB,CAAC;IAED,eAAe;IACf,2CAA2C;IAC3C,cAAc;IACd,MAAM,MAAM,GAGP,EAAE,CAAA;IACP,KAAK,MAAM,YAAY,IAAI,aAAa,EAAE,CAAC;QACzC,MAAM,SAAS,GACb,YAAY,CAAC,GAAG,KAAK,SAAS,IAAI,YAAY,CAAC,GAAG,GAAG,IAAI,CAAC,MAAM,CAAC,MAAM;YACrE,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,YAAY,CAAC,GAAG,CAAC;YAC/B,CAAC,CAAC,SAAS,CAAA;QACf,MAAM,CAAC,IAAI,CAAC,EAAE,SAAS,EAAE,YAAY,EAAE,CAAC,CAAA;IAC1C,CAAC;IACD,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE;QACnB,IAAI,CAAC,CAAC,YAAY,CAAC,GAAG,GAAG,CAAC,CAAC,YAAY,CAAC,GAAG;YAAE,OAAO,CAAC,CAAC,CAAA;QACtD,IAAI,CAAC,CAAC,YAAY,CAAC,GAAG,KAAK,CAAC,CAAC,YAAY,CAAC,GAAG;YAAE,OAAO,CAAC,CAAA;QACvD,OAAO,CAAC,CAAA;IACV,CAAC,CAAC,CAAA;IAEF,MAAM,oBAAoB,GAA0B,EAAE,CAAA;IAEtD,eAAe;IACf,aAAa;IACb,cAAc;IACd,IAAI,iBAAiB,GAAG,CAAC,CAAA;IACzB,KAAK,MAAM,EAAE,YAAY,EAAE,SAAS,EAAE,IAAI,MAAM,EAAE,CAAC;QACjD,2HAA2H;QAC3H,IAAI,SAAS,IAAI,IAAI,EAAE,CAAC;YACtB,4EAA4E;YAC5E,0EAA0E;YAC1E,MAAM,SAAS,GAAG,OAAO,SAAS,CAAC,eAAe,KAAK,QAAQ,CAAA;YAC/D,MAAM,MAAM,GAAG,SAAS,CAAC,CAAC,CAAC,IAAA,+BAAc,EAAC,SAAS,CAAC,eAAgB,CAAC,CAAC,CAAC,CAAC,IAAI,YAAM,EAAE,CAAA;YACpF,MAAM,iBAAiB,GAAG,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC,SAAS,EAAE,QAAQ,CAAC,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,SAAS,CAAA;YAC1G,MAAM,UAAU,GAAqB;gBACnC,UAAU,EAAE,SAAS,CAAC,QAAQ,CAAC,IAAI;gBACnC,iBAAiB,EAAE,SAAS,CAAC,QAAQ,CAAC,IAAI;gBAC1C,6HAA6H;gBAC7H,sGAAsG;gBACtG,iBAAiB;gBACjB,eAAe,EAAE,MAAM;gBACvB,QAAQ,EAAE,SAAS,CAAC,cAAc;aACnC,CAAA;YACD,EAAE,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAA;QACzB,CAAC;aAAM,CAAC;YACN,4EAA4E;YAC5E,IAAI,YAAY,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;gBAClC,MAAM,IAAI,oCAAsB,CAC9B,MAAM,EACN,OAAO,YAAY,CAAC,GAAG,MAAM,YAAY,CAAC,IAAI,6CAA6C,CAC5F,CAAA;YACH,CAAC;YAED,oBAAoB,CAAC,IAAI,CAAC;gBACxB,GAAG,EAAE,EAAE,CAAC,MAAM,CAAC,MAAM;gBACrB,gBAAgB,EAAE,IAAA,6BAAY,EAAC,YAAY,CAAC,gBAAgB,CAAC;gBAC7D,gBAAgB,EAAE,IAAA,6BAAY,EAAC,YAAY,CAAC,gBAAgB,CAAC;gBAC7D,cAAc,EAAE,YAAY,CAAC,iBAAiB;gBAC9C,cAAc,EAAE,YAAY,CAAC,cAAc;gBAC3C,aAAa,EAAE,YAAY,CAAC,mBAAmB;aAChD,CAAC,CAAA;YAEF,MAAM,UAAU,GAAqB;gBACnC,UAAU,EAAE,YAAY,CAAC,UAAU;gBACnC,iBAAiB,EAAE,YAAY,CAAC,UAAU;gBAC1C,iBAAiB,EAAE,CAAC,YAAY,CAAC,iBAAiB,IAAI,IAAI,CAAC;oBACzD,CAAC,CAAC,iBAAW,CAAC,UAAU,CAAC,YAAY,CAAC,iBAAiB,CAAC;oBACxD,CAAC,CAAC,SAAS;gBACb,eAAe,EAAE,IAAI,YAAM,EAAE;gBAC7B,QAAQ,EAAE,UAAU;aACrB,CAAA;YACD,EAAE,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAA;YACvB,iBAAiB,IAAI,gBAAU,CAAC,gBAAgB,CAAC,YAAY,CAAC,cAAc,EAAE,6BAA6B,CAAC,CAAA;QAC9G,CAAC;IACH,CAAC;IAED,qEAAqE;IACrE,8FAA8F;IAC9F,MAAM,kBAAkB,GAAG,cAAc;SACtC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,KAAK,QAAQ,CAAC;SACnC,MAAM,CAAC,CAAC,GAAG,EAAE,EAAE,EAAE,EAAE,CAAC,GAAG,GAAG,EAAE,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAA;IAC5C,MAAM,MAAM,GAAG,iBAAiB,GAAG,kBAAkB,CAAA;IAErD,OAAO;QACL,EAAE;QACF,MAAM;QACN,GAAG,EAAE,oBAAoB;QACzB,GAAG,EAAE,EAAE;KACR,CAAA;AACH,CAAC;AAED;;GAEG;AACH,SAAgB,cAAc,CAC5B,GAAsC,EACtC,IAA+B,EAC/B,IAAsC,EACtC,UAAmB,EACnB,MAAc;IAEd,MAAM,gBAAgB,GAAG,IAAI,CAAC,gBAAgB,CAAA;IAC9C,MAAM,gBAAgB,GAAG,IAAA,6BAAY,EAAC,GAAG,CAAC,gBAAgB,CAAC,CAAA;IAC3D,MAAM,MAAM,GAAG,IAAI,yCAAmB,CAAC;QACrC,gBAAgB;QAChB,gBAAgB;QAChB,UAAU,EAAE,MAAM,CAAC,UAAU;KAC9B,CAAC,CAAA;IACF,MAAM,aAAa,GAAG,MAAM,CAAC,IAAI,CAAC,UAAU,CAAC,UAAU,EAAE,UAAU,CAAC,SAAS,CAAC,CAAA;IAC9E,OAAO,aAAa,CAAA;AACtB,CAAC"}
+{"version":3,"file":"buildSignableTransaction.js","sourceRoot":"","sources":["../../../../../src/signer/methods/buildSignableTransaction.ts"],"names":[],"mappings":";;;AAYA,4DAwKC;AAqBD,0EAyCC;AAoCD,sGAsCC;AAKD,wCAgBC;AAjVD,kCAAqG;AAOrG,uDAA8D;AAC9D,iEAA2E;AAE3E,2EAAuE;AAEvE,SAAgB,wBAAwB,CACtC,IAA+B,EAC/B,IAAsC,EACtC,MAAc;IAOd,MAAM,UAAU,GAAG,MAAM,CAAC,sBAAsB,EAAE,CAAA;IAElD,MAAM,SAAS,GAAG,CAAC,IAAI,CAAC,SAAS,IAAI,IAAI,CAAC,CAAC,CAAC,CAAC,UAAI,CAAC,UAAU,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,SAAS,CAAA;IAExF,MAAM,EAAE,MAAM,EAAE,aAAa,EAAE,OAAO,EAAE,cAAc,EAAE,GAAG,IAAI,CAAA;IAE/D,6EAA6E;IAC7E,8EAA8E;IAC9E,yEAAyE;IACzE,6EAA6E;IAC7E,6EAA6E;IAC7E,+EAA+E;IAC/E,wEAAwE;IACxE,+BAA+B,CAAC,cAAc,EAAE,IAAI,CAAC,CAAA;IAErD,gFAAgF;IAChF,8EAA8E;IAC9E,6EAA6E;IAC7E,4EAA4E;IAC5E,+EAA+E;IAC/E,uEAAuE;IACvE,6CAA6C,CAAC,cAAc,EAAE,IAAI,CAAC,CAAA;IAEnE,MAAM,EAAE,GAAG,IAAI,iBAAW,CAAC,IAAI,CAAC,OAAO,EAAE,EAAE,EAAE,EAAE,EAAE,IAAI,CAAC,QAAQ,CAAC,CAAA;IAE/D,oDAAoD;IACpD,iDAAiD;IACjD,oBAAoB;IACpB,iBAAiB;IACjB,gGAAgG;IAChG,MAAM,WAAW,GAAG,IAAI,KAAK,CAAS,cAAc,CAAC,MAAM,CAAC,CAAA;IAC5D,KAAK,IAAI,IAAI,GAAG,CAAC,EAAE,IAAI,GAAG,cAAc,CAAC,MAAM,EAAE,IAAI,EAAE,EAAE,CAAC;QACxD,MAAM,CAAC,GAAG,cAAc,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,IAAI,CAAC,CAAA;QACxD,IAAI,CAAC,GAAG,CAAC;YAAE,MAAM,IAAI,oCAAsB,CAAC,aAAa,EAAE,eAAe,IAAI,aAAa,CAAC,CAAA;QAC5F,WAAW,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;IACvB,CAAC;IAED,eAAe;IACf,cAAc;IACd,cAAc;IACd,KAAK,IAAI,IAAI,GAAG,CAAC,EAAE,IAAI,GAAG,cAAc,CAAC,MAAM,EAAE,IAAI,EAAE,EAAE,CAAC;QACxD,MAAM,CAAC,GAAG,WAAW,CAAC,IAAI,CAAC,CAAA;QAC3B,MAAM,GAAG,GAAG,cAAc,CAAC,CAAC,CAAC,CAAA;QAC7B,IAAI,IAAI,KAAK,GAAG,CAAC,IAAI,EAAE,CAAC;YAAC,MAAM,IAAI,oCAAsB,CAAC,aAAa,EAAE,yBAAyB,GAAG,CAAC,IAAI,QAAQ,IAAI,EAAE,CAAC,CAAA;QAAC,CAAC;QAE3H,MAAM,MAAM,GAAG,GAAG,CAAC,UAAU,KAAK,SAAS,IAAI,GAAG,CAAC,OAAO,KAAK,QAAQ,CAAA;QAEvE,MAAM,aAAa,GAAG,MAAM;YAC1B,CAAC,CAAC,cAAc,CAAC,GAAG,EAAE,IAAI,EAAE,IAAI,EAAE,UAAU,EAAE,MAAM,CAAC;YACrD,CAAC,CAAC,IAAA,+BAAc,EAAC,GAAG,CAAC,aAAa,CAAC,CAAA;QAErC,MAAM,MAAM,GAAsB;YAChC,QAAQ,EAAE,GAAG,CAAC,QAAQ;YACtB,aAAa;YACb,MAAM;SACP,CAAA;QACD,EAAE,CAAC,SAAS,CAAC,MAAM,CAAC,CAAA;IACtB,CAAC;IAED,IAAI,cAAc,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAChC,yFAAyF;QACzF,MAAM,MAAM,GAAsB;YAChC,QAAQ,EAAE,CAAC;YACX,aAAa,EAAE,YAAM,CAAC,OAAO,CAAC,uBAAuB,CAAC;YACtD,MAAM,EAAE,KAAK;SACd,CAAA;QACD,EAAE,CAAC,SAAS,CAAC,MAAM,CAAC,CAAA;IACtB,CAAC;IAED,eAAe;IACf,2CAA2C;IAC3C,cAAc;IACd,MAAM,MAAM,GAGP,EAAE,CAAA;IACP,KAAK,MAAM,YAAY,IAAI,aAAa,EAAE,CAAC;QACzC,MAAM,SAAS,GACb,YAAY,CAAC,GAAG,KAAK,SAAS,IAAI,YAAY,CAAC,GAAG,GAAG,IAAI,CAAC,MAAM,CAAC,MAAM;YACrE,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,YAAY,CAAC,GAAG,CAAC;YAC/B,CAAC,CAAC,SAAS,CAAA;QACf,MAAM,CAAC,IAAI,CAAC,EAAE,SAAS,EAAE,YAAY,EAAE,CAAC,CAAA;IAC1C,CAAC;IACD,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE;QACnB,IAAI,CAAC,CAAC,YAAY,CAAC,GAAG,GAAG,CAAC,CAAC,YAAY,CAAC,GAAG;YAAE,OAAO,CAAC,CAAC,CAAA;QACtD,IAAI,CAAC,CAAC,YAAY,CAAC,GAAG,KAAK,CAAC,CAAC,YAAY,CAAC,GAAG;YAAE,OAAO,CAAC,CAAA;QACvD,OAAO,CAAC,CAAA;IACV,CAAC,CAAC,CAAA;IAEF,MAAM,oBAAoB,GAA0B,EAAE,CAAA;IAEtD,eAAe;IACf,aAAa;IACb,cAAc;IACd,IAAI,iBAAiB,GAAG,CAAC,CAAA;IACzB,KAAK,MAAM,EAAE,YAAY,EAAE,SAAS,EAAE,IAAI,MAAM,EAAE,CAAC;QACjD,2HAA2H;QAC3H,IAAI,SAAS,IAAI,IAAI,EAAE,CAAC;YACtB,4EAA4E;YAC5E,0EAA0E;YAC1E,MAAM,MAAM,GACV,OAAO,SAAS,CAAC,eAAe,KAAK,QAAQ,CAAC,CAAC,CAAC,IAAA,+BAAc,EAAC,SAAS,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC,IAAI,YAAM,EAAE,CAAA;YAC1G,MAAM,iBAAiB,GAAG,IAAI,CAAC,YAAY,CAAC,CAAC,CAAC,SAAS,EAAE,QAAQ,CAAC,SAAS,CAAC,QAAQ,CAAC,IAAI,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,SAAS,CAAA;YAC1G,MAAM,UAAU,GAAqB;gBACnC,UAAU,EAAE,SAAS,CAAC,QAAQ,CAAC,IAAI;gBACnC,iBAAiB,EAAE,SAAS,CAAC,QAAQ,CAAC,IAAI;gBAC1C,6HAA6H;gBAC7H,sGAAsG;gBACtG,iBAAiB;gBACjB,eAAe,EAAE,MAAM;gBACvB,QAAQ,EAAE,SAAS,CAAC,cAAc;aACnC,CAAA;YACD,EAAE,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAA;QACzB,CAAC;aAAM,CAAC;YACN,4EAA4E;YAC5E,IAAI,YAAY,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;gBAClC,MAAM,IAAI,oCAAsB,CAC9B,MAAM,EACN,OAAO,YAAY,CAAC,GAAG,MAAM,YAAY,CAAC,IAAI,6CAA6C,CAC5F,CAAA;YACH,CAAC;YAED,oBAAoB,CAAC,IAAI,CAAC;gBACxB,GAAG,EAAE,EAAE,CAAC,MAAM,CAAC,MAAM;gBACrB,gBAAgB,EAAE,IAAA,6BAAY,EAAC,YAAY,CAAC,gBAAgB,CAAC;gBAC7D,gBAAgB,EAAE,IAAA,6BAAY,EAAC,YAAY,CAAC,gBAAgB,CAAC;gBAC7D,cAAc,EAAE,YAAY,CAAC,iBAAiB;gBAC9C,cAAc,EAAE,YAAY,CAAC,cAAc;gBAC3C,aAAa,EAAE,YAAY,CAAC,mBAAmB;aAChD,CAAC,CAAA;YAEF,MAAM,UAAU,GAAqB;gBACnC,UAAU,EAAE,YAAY,CAAC,UAAU;gBACnC,iBAAiB,EAAE,YAAY,CAAC,UAAU;gBAC1C,iBAAiB,EAAE,CAAC,YAAY,CAAC,iBAAiB,IAAI,IAAI,CAAC;oBACzD,CAAC,CAAC,iBAAW,CAAC,UAAU,CAAC,YAAY,CAAC,iBAAiB,CAAC;oBACxD,CAAC,CAAC,SAAS;gBACb,eAAe,EAAE,IAAI,YAAM,EAAE;gBAC7B,QAAQ,EAAE,UAAU;aACrB,CAAA;YACD,EAAE,CAAC,QAAQ,CAAC,UAAU,CAAC,CAAA;YACvB,iBAAiB,IAAI,gBAAU,CAAC,gBAAgB,CAAC,YAAY,CAAC,cAAc,EAAE,6BAA6B,CAAC,CAAA;QAC9G,CAAC;IACH,CAAC;IAED,qEAAqE;IACrE,8FAA8F;IAC9F,MAAM,kBAAkB,GAAG,cAAc;SACtC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,OAAO,KAAK,QAAQ,CAAC;SACnC,MAAM,CAAC,CAAC,GAAG,EAAE,EAAE,EAAE,EAAE,CAAC,GAAG,GAAG,EAAE,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAA;IAC5C,MAAM,MAAM,GAAG,iBAAiB,GAAG,kBAAkB,CAAA;IAErD,OAAO;QACL,EAAE;QACF,MAAM;QACN,GAAG,EAAE,oBAAoB;QACzB,GAAG,EAAE,EAAE;KACR,CAAA;AACH,CAAC;AAED;;;;;;;;;;;;;;;;;;GAkBG;AACH,SAAgB,+BAA+B,CAC7C,cAAmD,EACnD,IAAsC;IAEtC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QAC7C,MAAM,SAAS,GAAG,IAAI,CAAC,OAAO,CAAC,CAAC,CAAC,CAAA;QACjC,MAAM,QAAQ,GAAG,cAAc,CAAC,CAAC,CAAC,CAAA;QAElC,IAAI,QAAQ,IAAI,IAAI,EAAE,CAAC;YACrB,MAAM,IAAI,oCAAsB,CAC9B,iBAAiB,EACjB,mGAAmG,CAAC,GAAG,CACxG,CAAA;QACH,CAAC;QAED,4EAA4E;QAC5E,6EAA6E;QAC7E,sCAAsC;QACtC,IAAI,QAAQ,CAAC,OAAO,KAAK,QAAQ,IAAI,QAAQ,CAAC,UAAU,KAAK,SAAS,EAAE,CAAC;YACvE,MAAM,IAAI,oCAAsB,CAC9B,mBAAmB,EACnB,sEAAsE,CAAC,mBAAmB,QAAQ,CAAC,UAAU,cAAc,QAAQ,CAAC,OAAO,IAAI,EAAE,IAAI,CACtJ,CAAA;QACH,CAAC;QAED,MAAM,eAAe,GAAG,CAAC,SAAS,CAAC,aAAa,IAAI,EAAE,CAAC,CAAC,WAAW,EAAE,CAAA;QACrE,MAAM,cAAc,GAAG,CAAC,OAAO,QAAQ,CAAC,aAAa,KAAK,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,aAAa,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,WAAW,EAAE,CAAA;QAC/G,IAAI,eAAe,CAAC,MAAM,KAAK,CAAC,IAAI,eAAe,KAAK,cAAc,EAAE,CAAC;YACvE,MAAM,IAAI,oCAAsB,CAC9B,sBAAsB,EACtB,8GAA8G,CAAC,4CAA4C,CAC5J,CAAA;QACH,CAAC;QAED,IAAI,QAAQ,CAAC,QAAQ,KAAK,SAAS,CAAC,QAAQ,EAAE,CAAC;YAC7C,MAAM,IAAI,oCAAsB,CAC9B,iBAAiB,EACjB,4DAA4D,QAAQ,CAAC,QAAQ,qBAAqB,CAAC,sBAAsB,SAAS,CAAC,QAAQ,GAAG,CAC/I,CAAA;QACH,CAAC;IACH,CAAC;AACH,CAAC;AAED;;;;;;;GAOG;AACU,QAAA,+BAA+B,GAAG,MAAM,CAAA;AAErD;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,SAAgB,6CAA6C,CAC3D,cAAmD,EACnD,IAAsC,EACtC,gBAAwB,uCAA+B;IAEvD,IAAI,eAAe,GAAG,CAAC,CAAA;IACvB,KAAK,IAAI,CAAC,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,CAAC,GAAG,cAAc,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QACjE,MAAM,GAAG,GAAG,cAAc,CAAC,CAAC,CAAC,CAAA;QAC7B,MAAM,QAAQ,GAAG,GAAG,CAAC,UAAU,KAAK,SAAS,IAAI,GAAG,CAAC,OAAO,KAAK,QAAQ,CAAA;QACzE,IAAI,QAAQ;YAAE,SAAQ;QAEtB,0EAA0E;QAC1E,yEAAyE;QACzE,MAAM,YAAY,GAChB,GAAG,CAAC,UAAU,KAAK,SAAS,IAAI,CAAC,GAAG,CAAC,OAAO,KAAK,oBAAoB,IAAI,GAAG,CAAC,OAAO,KAAK,gBAAgB,CAAC,CAAA;QAC5G,IAAI,YAAY,EAAE,CAAC;YACjB,eAAe,EAAE,CAAA;YACjB,IAAI,eAAe,GAAG,CAAC,EAAE,CAAC;gBACxB,MAAM,IAAI,oCAAsB,CAC9B,iBAAiB,EACjB,uFAAuF,CAAC,GAAG,CAC5F,CAAA;YACH,CAAC;YACD,IAAI,GAAG,CAAC,QAAQ,GAAG,aAAa,EAAE,CAAC;gBACjC,MAAM,IAAI,oCAAsB,CAC9B,iBAAiB,EACjB,gCAAgC,aAAa,sCAAsC,GAAG,CAAC,QAAQ,aAAa,CAAC,6CAA6C,CAC3J,CAAA;YACH,CAAC;YACD,SAAQ;QACV,CAAC;QAED,MAAM,IAAI,oCAAsB,CAC9B,iBAAiB,EACjB,kGAAkG;YAChG,gBAAgB,GAAG,CAAC,UAAU,cAAc,GAAG,CAAC,OAAO,IAAI,EAAE,eAAe,CAAC,6CAA6C,CAC7H,CAAA;IACH,CAAC;AACH,CAAC;AAED;;GAEG;AACH,SAAgB,cAAc,CAC5B,GAAsC,EACtC,IAA+B,EAC/B,IAAsC,EACtC,UAAmB,EACnB,MAAc;IAEd,MAAM,gBAAgB,GAAG,IAAI,CAAC,gBAAgB,CAAA;IAC9C,MAAM,gBAAgB,GAAG,IAAA,6BAAY,EAAC,GAAG,CAAC,gBAAgB,CAAC,CAAA;IAC3D,MAAM,MAAM,GAAG,IAAI,yCAAmB,CAAC;QACrC,gBAAgB;QAChB,gBAAgB;QAChB,UAAU,EAAE,MAAM,CAAC,UAAU;KAC9B,CAAC,CAAA;IACF,MAAM,aAAa,GAAG,MAAM,CAAC,IAAI,CAAC,UAAU,CAAC,UAAU,EAAE,UAAU,CAAC,SAAS,CAAC,CAAA;IAC9E,OAAO,aAAa,CAAA;AACtB,CAAC"}

package/out/src/storage/methods/processAction.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"processAction.d.ts","sourceRoot":"","sources":["../../../../../src/storage/methods/processAction.ts"],"names":[],"mappings":"AACA,OAAO,EACL,IAAI,EAEJ,cAAc,EAEd,qBAAqB,EACtB,MAAM,UAAU,CAAA;AAEjB,OAAO,EAAE,eAAe,EAAE,MAAM,oBAAoB,CAAA;AACpD,OAAO,EACL,MAAM,EACN,kBAAkB,EAClB,wBAAwB,EACxB,2BAA2B,EAC5B,MAAM,oCAAoC,CAAA;AAU3C,OAAO,EAAE,iBAAiB,EAAE,MAAM,sCAAsC,CAAA;AAExE,OAAO,EAAE,gBAAgB,EAAE,MAAM,mCAAmC,CAAA;AACpE,OAAO,EAAE,aAAa,EAAE,MAAM,gCAAgC,CAAA;AAQ9D,wBAAsB,aAAa,CACjC,OAAO,EAAE,eAAe,EACxB,IAAI,EAAE,MAAM,EACZ,IAAI,EAAE,wBAAwB,GAC7B,OAAO,CAAC,2BAA2B,CAAC,CA0CtC;AAED,MAAM,WAAW,oBAAoB;IACnC,IAAI,EAAE,MAAM,CAAA;IACZ,GAAG,CAAC,EAAE,gBAAgB,CAAA;IACtB,MAAM,CAAC,EAAE,aAAa,CAAA;IACtB,MAAM,EAAE,aAAa,GAAG,aAAa,GAAG,OAAO,GAAG,SAAS,CAAA;IAC3D,KAAK,CAAC,EAAE,MAAM,CAAA;CACf;AAED,MAAM,WAAW,oBAAoB;IACnC,IAAI,EAAE,IAAI,CAAA;IACV,OAAO,EAAE,oBAAoB,EAAE,CAAA;CAChC;AAED,MAAM,WAAW,wBAAwB;IACvC,IAAI,EAAE,MAAM,CAAA;IAEZ;;OAEG;IACH,MAAM,EAAE,SAAS,GAAG,OAAO,CAAA;IAE3B;;;;OAIG;IACH,YAAY,CAAC,EAAE,OAAO,CAAA;IAEtB,SAAS,CAAC,EAAE,MAAM,CAAA;IAClB,WAAW,CAAC,EAAE,MAAM,CAAA;IACpB,UAAU,CAAC,EAAE,MAAM,CAAA;CACpB;AA6CD,wBAAsB,kBAAkB,CACtC,OAAO,EAAE,eAAe,EACxB,MAAM,EAAE,MAAM,EACd,KAAK,EAAE,MAAM,EAAE,EACf,SAAS,EAAE,OAAO,EAClB,CAAC,CAAC,EAAE,oBAAoB,EACxB,MAAM,CAAC,EAAE,qBAAqB,GAC7B,OAAO,CAAC;IAAE,GAAG,EAAE,cAAc,EAAE,CAAC;IAAC,GAAG,EAAE,kBAAkB,EAAE,GAAG,SAAS,CAAA;CAAE,CAAC,CAuC3E;AAwLD,MAAM,WAAW,kBAAkB;IACjC,GAAG,EAAE,iBAAiB,CAAA;IACtB,GAAG,CAAC,EAAE,MAAM,CAAA;CACb"}
+{"version":3,"file":"processAction.d.ts","sourceRoot":"","sources":["../../../../../src/storage/methods/processAction.ts"],"names":[],"mappings":"AACA,OAAO,EACL,IAAI,EAEJ,cAAc,EAEd,qBAAqB,EACtB,MAAM,UAAU,CAAA;AAEjB,OAAO,EAAE,eAAe,EAAE,MAAM,oBAAoB,CAAA;AACpD,OAAO,EACL,MAAM,EACN,kBAAkB,EAClB,wBAAwB,EACxB,2BAA2B,EAC5B,MAAM,oCAAoC,CAAA;AAU3C,OAAO,EAAE,iBAAiB,EAAE,MAAM,sCAAsC,CAAA;AAExE,OAAO,EAAE,gBAAgB,EAAE,MAAM,mCAAmC,CAAA;AACpE,OAAO,EAAE,aAAa,EAAE,MAAM,gCAAgC,CAAA;AAU9D,wBAAsB,aAAa,CACjC,OAAO,EAAE,eAAe,EACxB,IAAI,EAAE,MAAM,EACZ,IAAI,EAAE,wBAAwB,GAC7B,OAAO,CAAC,2BAA2B,CAAC,CA0CtC;AAED,MAAM,WAAW,oBAAoB;IACnC,IAAI,EAAE,MAAM,CAAA;IACZ,GAAG,CAAC,EAAE,gBAAgB,CAAA;IACtB,MAAM,CAAC,EAAE,aAAa,CAAA;IACtB,MAAM,EAAE,aAAa,GAAG,aAAa,GAAG,OAAO,GAAG,SAAS,CAAA;IAC3D,KAAK,CAAC,EAAE,MAAM,CAAA;CACf;AAED,MAAM,WAAW,oBAAoB;IACnC,IAAI,EAAE,IAAI,CAAA;IACV,OAAO,EAAE,oBAAoB,EAAE,CAAA;CAChC;AAED,MAAM,WAAW,wBAAwB;IACvC,IAAI,EAAE,MAAM,CAAA;IAEZ;;OAEG;IACH,MAAM,EAAE,SAAS,GAAG,OAAO,CAAA;IAE3B;;;;OAIG;IACH,YAAY,CAAC,EAAE,OAAO,CAAA;IAEtB,SAAS,CAAC,EAAE,MAAM,CAAA;IAClB,WAAW,CAAC,EAAE,MAAM,CAAA;IACpB,UAAU,CAAC,EAAE,MAAM,CAAA;CACpB;AAmFD,wBAAsB,kBAAkB,CACtC,OAAO,EAAE,eAAe,EACxB,MAAM,EAAE,MAAM,EACd,KAAK,EAAE,MAAM,EAAE,EACf,SAAS,EAAE,OAAO,EAClB,CAAC,CAAC,EAAE,oBAAoB,EACxB,MAAM,CAAC,EAAE,qBAAqB,GAC7B,OAAO,CAAC;IAAE,GAAG,EAAE,cAAc,EAAE,CAAC;IAAC,GAAG,EAAE,kBAAkB,EAAE,GAAG,SAAS,CAAA;CAAE,CAAC,CAyC3E;AAwLD,MAAM,WAAW,kBAAkB;IACjC,GAAG,EAAE,iBAAiB,CAAA;IACtB,GAAG,CAAC,EAAE,MAAM,CAAA;CACb"}

package/out/src/storage/methods/processAction.js

@@ -11,6 +11,8 @@ const EntityProvenTxReq_1 = require("../schema/entities/EntityProvenTxReq");
 const WERR_errors_1 = require("../../sdk/WERR_errors");
 const parseTxScriptOffsets_1 = require("../../utility/parseTxScriptOffsets");
 const utilityHelpers_noBuffer_1 = require("../../utility/utilityHelpers.noBuffer");
+const WalletError_1 = require("../../sdk/WalletError");
+const storageProviderHelpers_1 = require("../storageProviderHelpers");
 async function processAction(storage, auth, args) {
     const logger = args.logger;
     logger?.group('storage processAction');
@@ -76,12 +78,47 @@ async function verifyMergedBeef(storage, r, readyToSendReqs, logger) {
     }
     logger?.log('beef is valid');
 }
+async function getReqDetailsForDelayedShare(storage, txids) {
+    const r = {
+        beef: new sdk_1.Beef(),
+        details: []
+    };
+    for (const txid of txids) {
+        const d = {
+            txid,
+            status: 'unknown'
+        };
+        r.details.push(d);
+        try {
+            d.proven = (0, utilityHelpers_1.verifyOneOrNone)(await storage.findProvenTxs({ partial: { txid } }));
+            if (d.proven != null) {
+                d.status = 'alreadySent';
+                continue;
+            }
+            d.req = (0, utilityHelpers_1.verifyOneOrNone)(await storage.findProvenTxReqs({ partial: { txid } }));
+            if (d.req == null) {
+                d.status = 'error';
+                d.error = `ERR_UNKNOWN_TXID: ${txid} was not found.`;
+            }
+            else {
+                (0, storageProviderHelpers_1.classifyReqStatus)(d, d.req);
+            }
+        }
+        catch (error_) {
+            const e = WalletError_1.WalletError.fromUnknown(error_);
+            d.error = `${e.name}: ${e.message}`;
+        }
+    }
+    return r;
+}
 async function shareReqsWithWorld(storage, userId, txids, isDelayed, r, logger) {
     const swr = [];
     const ndr = undefined;
     if ((r == null) && txids.length < 1)
         return { swr, ndr };
-    r ||= await storage.getReqsAndBeefToShareWithWorld(txids, []);
+    r ||= isDelayed
+        ? await getReqDetailsForDelayedShare(storage, txids)
+        : await storage.getReqsAndBeefToShareWithWorld(txids, []);
     const readyToSendReqs = [];
     classifyReqDetails(r.details, swr, readyToSendReqs);
     const readyToSendReqIds = readyToSendReqs.map(r => r.id);