@bsv/sdk 2.1.3 → 2.1.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bsv/sdk",
-  "version": "2.1.3",
+  "version": "2.1.4",
   "type": "module",
   "description": "BSV Blockchain Software Development Kit",
   "main": "dist/cjs/mod.js",
@@ -237,23 +237,23 @@
   },
   "homepage": "https://github.com/bsv-blockchain/ts-stack/tree/main/packages/sdk#readme",
   "devDependencies": {
-    "@eslint/js": "^9.39.1",
-    "@jest/globals": "^30.3.0",
-    "@rspack/cli": "^2.0.0",
-    "@rspack/core": "^1.6.1",
+    "@eslint/js": "^10.0.1",
+    "@jest/globals": "^30.4.1",
+    "@rspack/cli": "^2.0.4",
+    "@rspack/core": "^2.0.4",
     "@types/jest": "^30.0.0",
-    "@types/node": "^24.10.1",
-    "eslint": "^9.39.1",
-    "globals": "^16.5.0",
-    "jest": "^30.3.0",
-    "jest-environment-jsdom": "^30.3.0",
-    "ts-jest": "^29.4.9",
+    "@types/node": "^25.9.1",
+    "eslint": "^10.4.0",
+    "globals": "^17.6.0",
+    "jest": "^30.4.2",
+    "jest-environment-jsdom": "^30.4.1",
+    "ts-jest": "^29.4.11",
     "ts-loader": "^9.5.4",
     "ts-standard": "^12.0.2",
     "ts2md": "^0.2.8",
     "tsconfig-to-dual-package": "^1.2.0",
-    "typescript": "^5.9.3",
-    "typescript-eslint": "^8.46.4"
+    "typescript": "^6.0.3",
+    "typescript-eslint": "^8.60.0"
   },
   "ts-standard": {
     "project": "tsconfig.eslint.json",

package/src/compat/Mnemonic.ts

@@ -125,9 +125,22 @@ export default class Mnemonic {
    * Sets the mnemonic for the instance from a string.
    * @param {string} mnemonic - The mnemonic phrase as a string.
    * @returns {this} The Mnemonic instance with the set mnemonic.
+   * @throws {Error} If the mnemonic does not pass BIP-39 validation
+   * (unknown words, invalid length, or bad checksum).
    */
   public fromString (mnemonic: string): this {
     this.mnemonic = mnemonic
+    let valid = false
+    try {
+      valid = this.check()
+    } catch {
+      valid = false
+    }
+    if (!valid) {
+      throw new Error(
+        'Mnemonic does not pass the check - was the mnemonic typed incorrectly? Are there extra spaces?'
+      )
+    }
     return this
   }
 

package/src/compat/__tests/Mnemonic.test.ts

@@ -49,15 +49,21 @@ describe('Mnemonic', function () {
     mnemonic = m.mnemonic
 
     // mnemonics with extra whitespace do not pass the check
-    m = new Mnemonic().fromString(mnemonic + ' ')
-    expect(m.check()).toEqual(false)
+    const trailingSpace = mnemonic + ' '
+    const trailing = new Mnemonic()
+    trailing.mnemonic = trailingSpace
+    expect(trailing.check()).toEqual(false)
+    expect(() => new Mnemonic().fromString(trailingSpace)).toThrow()
 
     // mnemonics with a word replaced do not pass the check
     const words = mnemonic.split(' ')
     expect(words[words.length - 1]).not.toEqual('zoo')
     words[words.length - 1] = 'zoo'
-    mnemonic = words.join(' ')
-    expect(new Mnemonic().fromString(mnemonic).check()).toEqual(false)
+    const badWord = words.join(' ')
+    const replaced = new Mnemonic()
+    replaced.mnemonic = badWord
+    expect(replaced.check()).toEqual(false)
+    expect(() => new Mnemonic().fromString(badWord)).toThrow()
   })
 
   describe('#toBinary', () => {
@@ -132,13 +138,51 @@ describe('Mnemonic', function () {
   })
 
   describe('#fromString', () => {
-    it('should throw an error in invalid mnemonic', () => {
+    it('should throw an error on invalid mnemonic when toSeed is called', () => {
       expect(() => {
         new Mnemonic().fromString('invalid mnemonic').toSeed()
       }).toThrow(
         'Mnemonic does not pass the check - was the mnemonic typed incorrectly? Are there extra spaces?'
       )
     })
+
+    it('should throw immediately on nonsense input', () => {
+      expect(() => {
+        Mnemonic.fromString('this is not a real bip39 mnemonic phrase at all')
+      }).toThrow(
+        'Mnemonic does not pass the check - was the mnemonic typed incorrectly? Are there extra spaces?'
+      )
+    })
+
+    it('should throw on garbage string', () => {
+      expect(() => {
+        Mnemonic.fromString('asdfghjkl qwertyuiop zxcvbnm')
+      }).toThrow()
+    })
+
+    it('should throw on empty string', () => {
+      expect(() => {
+        Mnemonic.fromString('')
+      }).toThrow()
+    })
+
+    it('should throw on valid words but wrong checksum', () => {
+      // 12 valid wordlist entries but checksum will not match
+      expect(() => {
+        Mnemonic.fromString(
+          'abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon'
+        )
+      }).toThrow()
+    })
+
+    it('should accept a known-valid BIP-39 phrase', () => {
+      const m = Mnemonic.fromString(
+        'abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about'
+      )
+      expect(m.mnemonic).toEqual(
+        'abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about'
+      )
+    })
   })
 
   describe('@isValid', () => {