@bsv/sdk 2.0.16 → 2.1.1

package/docs/reference/kvstore.md

@@ -249,8 +249,7 @@ Links: [API](#api), [Interfaces](#interfaces), [Classes](#classes), [Functions](
 ### Interface: KVStoreQuery
 
 Query parameters for KVStore lookups from overlay services.
-Must include at least one selector: key, controller, protocolID, or non-empty tags.
-Pagination and ordering fields only refine selector-based lookups.
+Used when searching for existing key-value pairs in the network.
 
 ```ts
 export interface KVStoreQuery {

package/docs/reference/primitives.md

@@ -4948,7 +4948,6 @@ export default class TransactionSignature extends Signature {
     static formatBip143(params: TransactionSignatureFormatParams): Uint8Array 
     static format(params: TransactionSignatureFormatParams): number[] 
     static formatBytes(params: TransactionSignatureFormatParams): Uint8Array 
-    static usesOtdaSingleBug(params: TransactionSignatureFormatParams): boolean
     static fromChecksigFormat(buf: number[]): TransactionSignature 
     constructor(r: BigNumber, s: BigNumber, scope: number) 
     public hasLowS(): boolean 

package/docs/reference/script.md

@@ -45,7 +45,6 @@ A representation of a chunk of a script, which includes an opcode. For push oper
 export default interface ScriptChunk {
     op: number;
     data?: number[];
-    invalidLength?: boolean;
 }
 ```
 
@@ -805,14 +804,10 @@ export default class Spend {
     stack: number[][];
     altStack: number[][];
     ifStack: boolean[];
-    elseStack: boolean[];
     memoryLimit: number;
     stackMem: number;
     altStackMem: number;
     isRelaxedOverride: boolean;
-    verifyFlags?: Set<string>;
-    executedOpCount: number;
-    returningFromConditional: boolean;
     constructor(params: {
         sourceTXID: string;
         sourceOutputIndex: number;
@@ -827,7 +822,6 @@ export default class Spend {
         lockTime: number;
         memoryLimit?: number;
         isRelaxed?: boolean;
-        verifyFlags?: string | string[];
     }) 
     reset(): void 
     step(): boolean 
@@ -854,7 +848,6 @@ constructor(params: {
     lockTime: number;
     memoryLimit?: number;
     isRelaxed?: boolean;
-    verifyFlags?: string | string[];
 }) 
 ```
 See also: [LockingScript](./script.md#class-lockingscript), [TransactionInput](./transaction.md#interface-transactioninput), [TransactionOutput](./transaction.md#interface-transactionoutput), [UnlockingScript](./script.md#class-unlockingscript)

package/docs/reference/transaction.md

@@ -2455,8 +2455,8 @@ Links: [API](#api), [Interfaces](#interfaces), [Classes](#classes), [Functions](
 ### Function: defaultHttpClient
 
 Returns a default HttpClient implementation based on the environment that it is run on.
-This method will attempt to use `window.fetch` if available (in browser environments),
-then `globalThis.fetch` (service workers, Deno, Node 18+), then the Node `https` module.
+This method will attempt to use `window.fetch` if available (in browser environments).
+If running in a Node environment, it falls back to using the Node `https` module
 
 ```ts
 export function defaultHttpClient(): HttpClient 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bsv/sdk",
-  "version": "2.0.16",
+  "version": "2.1.1",
   "type": "module",
   "description": "BSV Blockchain Software Development Kit",
   "main": "dist/cjs/mod.js",
@@ -218,24 +218,10 @@
       "import": "./dist/umd/bundle.js"
     }
   },
-  "scripts": {
-    "test": "npm run build && jest",
-    "test:watch": "npm run build && jest --watch",
-    "test:coverage": "npm run build && jest --coverage",
-    "lint:ci": "ts-standard src/**/*.ts",
-    "lint": "ts-standard --fix src/**/*.ts",
-    "build": "npm run build:ts && npm run build:umd",
-    "build:ts": "tsc -b && tsconfig-to-dual-package tsconfig.cjs.json",
-    "build:umd": "rspack --config rspack.config.js",
-    "dev": "tsc -b -w",
-    "prepublish": "npm run build",
-    "doc": "ts2md",
-    "docs:serve": "mkdocs serve",
-    "docs:build": "mkdocs build"
-  },
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/bsv-blockchain/ts-sdk.git"
+    "url": "git+https://github.com/bsv-blockchain/ts-stack.git",
+    "directory": "packages/sdk"
   },
   "keywords": [
     "BSV",
@@ -247,32 +233,47 @@
   "author": "BSV Blockchain Association",
   "license": "SEE LICENSE IN LICENSE.txt",
   "bugs": {
-    "url": "https://github.com/bsv-blockchain/ts-sdk/issues"
+    "url": "https://github.com/bsv-blockchain/ts-stack/issues"
   },
-  "homepage": "https://github.com/bsv-blockchain/ts-sdk#readme",
+  "homepage": "https://github.com/bsv-blockchain/ts-stack/tree/main/packages/sdk#readme",
   "devDependencies": {
-    "@eslint/js": "^10.0.1",
+    "@eslint/js": "^9.39.1",
     "@jest/globals": "^30.3.0",
     "@rspack/cli": "^2.0.0",
-    "@rspack/core": "^2.0.0",
+    "@rspack/core": "^1.6.1",
     "@types/jest": "^30.0.0",
-    "@types/node": "^25.6.0",
-    "eslint": "^10.2.1",
-    "globals": "^17.5.0",
+    "@types/node": "^24.10.1",
+    "eslint": "^9.39.1",
+    "globals": "^16.5.0",
     "jest": "^30.3.0",
     "jest-environment-jsdom": "^30.3.0",
     "ts-jest": "^29.4.9",
-    "ts-loader": "^9.5.7",
+    "ts-loader": "^9.5.4",
     "ts-standard": "^12.0.2",
     "ts2md": "^0.2.8",
     "tsconfig-to-dual-package": "^1.2.0",
-    "typescript": "^6.0.3",
-    "typescript-eslint": "^8.59.0"
+    "typescript": "^5.9.3",
+    "typescript-eslint": "^8.46.4"
   },
   "ts-standard": {
     "project": "tsconfig.eslint.json",
     "ignore": [
       "dist"
     ]
+  },
+  "scripts": {
+    "test": "npm run build && jest",
+    "test:watch": "npm run build && jest --watch",
+    "test:coverage": "npm run build && jest --coverage --watchman=false",
+    "lint:ci": "ts-standard src/**/*.ts",
+    "lint": "ts-standard --fix src/**/*.ts",
+    "build": "npm run build:ts && npm run build:umd",
+    "build:ts": "tsc -b && tsconfig-to-dual-package tsconfig.cjs.json",
+    "build:umd": "rspack --config rspack.config.js",
+    "dev": "tsc -b -w",
+    "prepublish": "npm run build",
+    "doc": "ts2md",
+    "docs:serve": "mkdocs serve",
+    "docs:build": "mkdocs build"
   }
-}
+}

package/src/auth/Peer.ts

@@ -18,7 +18,7 @@ import { OriginatorDomainNameStringUnder250Bytes, WalletInterface } from '../wal
 
 const AUTH_VERSION = '0.1'
 const BufferCtor =
-  typeof globalThis !== 'undefined' ? (globalThis as any).Buffer : undefined
+  typeof globalThis === 'undefined' ? undefined : (globalThis as any).Buffer
 
 /**
  * Represents a peer capable of performing mutual authentication.
@@ -73,6 +73,24 @@ export class Peer {
   private readonly originator?: OriginatorDomainNameStringUnder250Bytes
   private identityPublicKey?: string
 
+  /**
+   * Resolves when the transport's `onData` listener has been registered and
+   * the peer is ready to send and receive messages.  Await this after
+   * construction before calling `toPeer` or any other method that requires
+   * the transport to be listening.
+   *
+   * @example
+   * const peer = new Peer(wallet, transport)
+   * await peer.ready
+   * await peer.toPeer(payload)
+   */
+  /*
+   * Listener must register synchronously so paired-peer mocks/transports see
+   * onDataCallback set immediately. The returned Promise resolves once registration
+   * is fully acknowledged. A lazy getter pattern would break paired-peer test mocks.
+   */
+  readonly ready: Promise<void>
+
   /**
    * Creates a new Peer instance
    *
@@ -81,6 +99,7 @@ export class Peer {
    * @param {RequestedCertificateSet} [certificatesToRequest] - Optional set of certificates to request from a peer during the initial handshake.
    * @param {SessionManager} [sessionManager] - Optional SessionManager to be used for managing peer sessions.
    * @param {boolean} [autoPersistLastSession] - Whether to auto-persist the session with the last-interacted-with peer. Defaults to true.
+   * @param {OriginatorDomainNameStringUnder250Bytes} [originator] - Optional originator domain name.
    */
   constructor (
     wallet: WalletInterface,
@@ -97,11 +116,9 @@ export class Peer {
       certifiers: [],
       types: {}
     }
-    this.transport.onData(this.handleIncomingMessage.bind(this)).catch(e => {
-      throw e
-    })
+    this.ready = this.transport.onData(this.handleIncomingMessage.bind(this)) // NOSONAR(typescript:S7059): listener must register synchronously — see ready field comment
     this.sessionManager =
-      sessionManager != null ? sessionManager : new SessionManager()
+      sessionManager ?? new SessionManager()
     if (autoPersistLastSession === false) {
       this.autoPersistLastSession = false
     } else {
@@ -249,12 +266,12 @@ export class Peer {
     }
 
     // If that session doesn't exist or isn't authenticated, initiate handshake
-    if ((peerSession == null) || !peerSession.isAuthenticated) {
+    if (peerSession?.isAuthenticated !== true) {
       // This will create a brand-new session
       const sessionNonce = await this.initiateHandshake(identityKey)
       // Now retrieve it by the sessionNonce
       peerSession = this.sessionManager.getSession(sessionNonce)
-      if ((peerSession == null) || !peerSession.isAuthenticated) {
+      if (peerSession?.isAuthenticated !== true) {
         throw new Error('Unable to establish mutual authentication with peer!')
       }
     }
@@ -423,9 +440,7 @@ export class Peer {
       if (peerIdentityKey != null) {
         const existingDetails = (error as any).details
         if (existingDetails != null && typeof existingDetails === 'object') {
-          if (existingDetails.peerIdentityKey == null) {
-            existingDetails.peerIdentityKey = peerIdentityKey
-          }
+          existingDetails.peerIdentityKey ??= peerIdentityKey
         } else {
           (error as any).details = { peerIdentityKey }
         }
@@ -548,9 +563,7 @@ export class Peer {
       signature
     }
 
-    if (this.lastInteractedWithPeer === undefined) {
-      this.lastInteractedWithPeer = message.identityKey
-    }
+    this.lastInteractedWithPeer ??= message.identityKey
 
     await this.transport.send(initialResponseMessage)
   }

package/src/auth/SessionManager.ts

@@ -31,7 +31,7 @@ export class SessionManager {
    */
   addSession (session: PeerSession): void {
     if (typeof session.sessionNonce !== 'string') {
-      throw new Error(
+      throw new TypeError(
         'Invalid session: sessionNonce is required to add a session.'
       )
     }
@@ -97,11 +97,8 @@ export class SessionManager {
       // We can prefer authenticated sessions
       if (best == null) {
         best = s
-      } else {
-        // If we want the "most recently updated" AND isAuthenticated
-        if ((s.lastUpdate ?? 0) > (best.lastUpdate ?? 0)) {
-          best = s
-        }
+      } else if ((s.lastUpdate ?? 0) > (best.lastUpdate ?? 0)) {
+        best = s
       }
     }
     // Optionally, you could also filter out isAuthenticated===false if you only want
@@ -140,6 +137,6 @@ export class SessionManager {
     if (direct) return true
     // if not directly a nonce, interpret as identityKey
     const nonces = this.identityKeyToNonces.get(identifier)
-    return !(nonces == null) && nonces.size > 0
+    return (nonces != null) && nonces.size > 0
   }
 }

package/src/auth/certificates/MasterCertificate.ts

@@ -157,7 +157,7 @@ export class MasterCertificate extends Certificate {
     privilegedReason?: string
   ): Promise<Record<CertificateFieldNameUnder50Bytes, string>> {
     if (!Array.isArray(fieldsToReveal)) {
-      throw new Error('fieldsToReveal must be an array of strings')
+      throw new TypeError('fieldsToReveal must be an array of strings')
     }
     const fieldRevelationKeyring = {}
     for (const fieldName of fieldsToReveal) {

package/src/auth/certificates/__tests/CompletedProtoWallet.ts

@@ -44,7 +44,7 @@ export class CompletedProtoWallet
     ) {
       this.keyDeriver = new CachedKeyDeriver(rootKeyOrKeyDeriver)
     } else {
-      throw new Error('Invalid key deriver provided')
+      throw new TypeError('Invalid key deriver provided')
     }
   }
 

package/src/auth/clients/AuthFetch.ts

@@ -117,11 +117,13 @@ export class AuthFetch {
 
         // Create a new transport for this base url if needed
         let peerToUse: AuthPeer
-        if (typeof this.peers[baseURL] === 'undefined') {
+        if (this.peers[baseURL] === undefined) {
           // Create a peer for the request
           const newTransport = new SimplifiedFetchTransport(baseURL)
+          const newPeer = new Peer(this.wallet, newTransport, this.requestedCertificates, this.sessionManager, undefined, this.originator)
+          await newPeer.ready
           peerToUse = {
-            peer: new Peer(this.wallet, newTransport, this.requestedCertificates, this.sessionManager, undefined, this.originator),
+            peer: newPeer,
             pendingCertificateRequests: []
           }
           this.peers[baseURL] = peerToUse
@@ -315,20 +317,20 @@ export class AuthFetch {
     const baseURL = parsedUrl.origin
 
     let peerToUse: { peer: Peer; identityKey?: string }
-    if (typeof this.peers[baseURL] !== 'undefined') {
-      peerToUse = { peer: this.peers[baseURL].peer }
-    } else {
+    if (this.peers[baseURL] === undefined) {
       const newTransport = new SimplifiedFetchTransport(baseURL)
-      peerToUse = {
-        peer: new Peer(
-          this.wallet,
-          newTransport,
-          this.requestedCertificates,
-          this.sessionManager,
-          this.originator
-        )
-      }
+      const newPeer = new Peer(
+        this.wallet,
+        newTransport,
+        this.requestedCertificates,
+        this.sessionManager,
+        this.originator
+      )
+      await newPeer.ready
+      peerToUse = { peer: newPeer }
       this.peers[baseURL] = peerToUse
+    } else {
+      peerToUse = { peer: this.peers[baseURL].peer }
     }
 
     // Return a promise that resolves when certificates are received
@@ -451,14 +453,14 @@ export class AuthFetch {
 
     // nHeaders
     writer.writeVarIntNum(includedHeaders.length)
-    for (let i = 0; i < includedHeaders.length; i++) {
+    for (const [headerKey, headerValue] of includedHeaders) {
       // headerKeyLength
-      const headerKeyAsArray = Utils.toArray(includedHeaders[i][0], 'utf8')
+      const headerKeyAsArray = Utils.toArray(headerKey, 'utf8')
       writer.writeVarIntNum(headerKeyAsArray.length)
       // headerKey
       writer.write(headerKeyAsArray)
       // headerValueLength
-      const headerValueAsArray = Utils.toArray(includedHeaders[i][1], 'utf8')
+      const headerValueAsArray = Utils.toArray(headerValue, 'utf8')
       writer.writeVarIntNum(headerValueAsArray.length)
       // headerValue
       writer.write(headerValueAsArray)
@@ -470,7 +472,7 @@ export class AuthFetch {
     if (methodsThatTypicallyHaveBody.includes(method.toUpperCase()) && body === undefined) {
       // Check if content-type is application/json
       const contentTypeHeader = includedHeaders.find(([k]) => k === 'content-type')
-      if (contentTypeHeader && contentTypeHeader[1].includes('application/json')) {
+      if (contentTypeHeader?.[1].includes('application/json') === true) {
         body = '{}'
       } else {
         body = ''
@@ -525,14 +527,14 @@ export class AuthFetch {
     if (!satoshisRequiredHeader) {
       throw new Error('Missing x-bsv-payment-satoshis-required response header.')
     }
-    const satoshisRequired = parseInt(satoshisRequiredHeader)
-    if (isNaN(satoshisRequired) || satoshisRequired <= 0) {
+    const satoshisRequired = Number.parseInt(satoshisRequiredHeader)
+    if (Number.isNaN(satoshisRequired) || satoshisRequired <= 0) {
       throw new Error('Invalid x-bsv-payment-satoshis-required response header value.')
     }
 
     const serverIdentityKey = originalResponse.headers.get('x-bsv-auth-identity-key')
     if (typeof serverIdentityKey !== 'string') {
-      throw new Error('Missing x-bsv-auth-identity-key response header.')
+      throw new TypeError('Missing x-bsv-auth-identity-key response header.')
     }
 
     const derivationPrefix = originalResponse.headers.get('x-bsv-payment-derivation-prefix')
@@ -541,7 +543,15 @@ export class AuthFetch {
     }
 
     let paymentContext = config.paymentContext
-    if (paymentContext != null) {
+    if (paymentContext == null) {
+      paymentContext = await this.createPaymentContext(
+        url,
+        config,
+        satoshisRequired,
+        serverIdentityKey,
+        derivationPrefix
+      )
+    } else {
       const requirementsChanged = !this.isPaymentContextCompatible(
         paymentContext,
         satoshisRequired,
@@ -558,14 +568,6 @@ export class AuthFetch {
           derivationPrefix
         )
       }
-    } else {
-      paymentContext = await this.createPaymentContext(
-        url,
-        config,
-        satoshisRequired,
-        serverIdentityKey,
-        derivationPrefix
-      )
     }
 
     if (paymentContext.attempts >= paymentContext.maxAttempts) {
@@ -573,7 +575,7 @@ export class AuthFetch {
     }
 
     const headersWithPayment: Record<string, string> = {
-      ...(config.headers ?? {})
+      ...config.headers
     }
     headersWithPayment['x-bsv-payment'] = JSON.stringify({
       derivationPrefix: paymentContext.derivationPrefix,
@@ -692,7 +694,7 @@ export class AuthFetch {
     url: string,
     config: SimplifiedFetchRequestOptions
   ): PaymentRetryContext['requestSummary'] {
-    const headers = { ...(config.headers ?? {}) }
+    const headers = { ...config.headers }
     const method = typeof config.method === 'string' ? config.method.toUpperCase() : 'GET'
     const bodySummary = this.describeRequestBodyForLogging(config.body)
 
@@ -727,7 +729,7 @@ export class AuthFetch {
 
     if (typeof ArrayBuffer !== 'undefined' && ArrayBuffer.isView(body)) {
       return {
-        type: body.constructor != null ? body.constructor.name : 'TypedArray',
+        type: body.constructor == null ? 'TypedArray' : body.constructor.name,
         byteLength: body.byteLength
       }
     }
@@ -754,8 +756,8 @@ export class AuthFetch {
       if (typeof serialized === 'string') {
         return { type: 'object', byteLength: Utils.toArray(serialized, 'utf8').length }
       }
-    } catch (_) {
-      // Ignore JSON serialization issues for logging purposes.
+    } catch (_jsonSerializationError) {
+      // Ignore JSON serialization issues for logging purposes only
     }
 
     return { type: typeof body, byteLength: 0 }
@@ -791,12 +793,10 @@ export class AuthFetch {
       console.error(`${prefix} ${message}`, details)
     } else if (level === 'warn') {
       console.warn(`${prefix} ${message}`, details)
+    } else if (typeof console.info === 'function') {
+      console.info(`${prefix} ${message}`, details)
     } else {
-      if (typeof console.info === 'function') {
-        console.info(`${prefix} ${message}`, details)
-      } else {
-        console.log(`${prefix} ${message}`, details)
-      }
+      console.log(`${prefix} ${message}`, details)
     }
   }
 
@@ -915,7 +915,7 @@ export class AuthFetch {
 
     // 8. ReadableStream
     if (body instanceof ReadableStream) {
-      throw new Error('ReadableStream cannot be directly converted to number[].')
+      throw new TypeError('ReadableStream cannot be directly converted to number[].')
     }
 
     // 9. Fallback

package/src/auth/transports/SimplifiedFetchTransport.ts

@@ -24,7 +24,7 @@ export class SimplifiedFetchTransport implements Transport {
    */
   constructor(baseUrl: string, fetchClient = defaultFetch) {
     if (typeof fetchClient !== 'function') {
-      throw new Error(
+      throw new TypeError(
         'SimplifiedFetchTransport requires a fetch implementation. ' +
         'In environments without fetch, provide a polyfill or custom implementation.'
       )
@@ -192,14 +192,14 @@ export class SimplifiedFetchTransport implements Transport {
 
       // nHeaders
       payloadWriter.writeVarIntNum(includedHeaders.length)
-      for (let i = 0; i < includedHeaders.length; i++) {
+      for (const [headerKey, headerValue] of includedHeaders) {
         // headerKeyLength
-        const headerKeyAsArray = Utils.toArray(includedHeaders[i][0], 'utf8')
+        const headerKeyAsArray = Utils.toArray(headerKey, 'utf8')
         payloadWriter.writeVarIntNum(headerKeyAsArray.length)
         // headerKey
         payloadWriter.write(headerKeyAsArray)
         // headerValueLength
-        const headerValueAsArray = Utils.toArray(includedHeaders[i][1], 'utf8')
+        const headerValueAsArray = Utils.toArray(headerValue, 'utf8')
         payloadWriter.writeVarIntNum(headerValueAsArray.length)
         // headerValue
         payloadWriter.write(headerValueAsArray)