@bsv/sdk 2.0.14 → 2.0.16

package/docs/reference/kvstore.md

@@ -249,7 +249,8 @@ Links: [API](#api), [Interfaces](#interfaces), [Classes](#classes), [Functions](
 ### Interface: KVStoreQuery
 
 Query parameters for KVStore lookups from overlay services.
-Used when searching for existing key-value pairs in the network.
+Must include at least one selector: key, controller, protocolID, or non-empty tags.
+Pagination and ordering fields only refine selector-based lookups.
 
 ```ts
 export interface KVStoreQuery {

package/docs/reference/primitives.md

@@ -4948,6 +4948,7 @@ export default class TransactionSignature extends Signature {
     static formatBip143(params: TransactionSignatureFormatParams): Uint8Array 
     static format(params: TransactionSignatureFormatParams): number[] 
     static formatBytes(params: TransactionSignatureFormatParams): Uint8Array 
+    static usesOtdaSingleBug(params: TransactionSignatureFormatParams): boolean
     static fromChecksigFormat(buf: number[]): TransactionSignature 
     constructor(r: BigNumber, s: BigNumber, scope: number) 
     public hasLowS(): boolean 

package/docs/reference/script.md

@@ -45,6 +45,7 @@ A representation of a chunk of a script, which includes an opcode. For push oper
 export default interface ScriptChunk {
     op: number;
     data?: number[];
+    invalidLength?: boolean;
 }
 ```
 
@@ -804,10 +805,14 @@ export default class Spend {
     stack: number[][];
     altStack: number[][];
     ifStack: boolean[];
+    elseStack: boolean[];
     memoryLimit: number;
     stackMem: number;
     altStackMem: number;
     isRelaxedOverride: boolean;
+    verifyFlags?: Set<string>;
+    executedOpCount: number;
+    returningFromConditional: boolean;
     constructor(params: {
         sourceTXID: string;
         sourceOutputIndex: number;
@@ -822,6 +827,7 @@ export default class Spend {
         lockTime: number;
         memoryLimit?: number;
         isRelaxed?: boolean;
+        verifyFlags?: string | string[];
     }) 
     reset(): void 
     step(): boolean 
@@ -848,6 +854,7 @@ constructor(params: {
     lockTime: number;
     memoryLimit?: number;
     isRelaxed?: boolean;
+    verifyFlags?: string | string[];
 }) 
 ```
 See also: [LockingScript](./script.md#class-lockingscript), [TransactionInput](./transaction.md#interface-transactioninput), [TransactionOutput](./transaction.md#interface-transactionoutput), [UnlockingScript](./script.md#class-unlockingscript)

package/docs/reference/transaction.md

@@ -2455,8 +2455,8 @@ Links: [API](#api), [Interfaces](#interfaces), [Classes](#classes), [Functions](
 ### Function: defaultHttpClient
 
 Returns a default HttpClient implementation based on the environment that it is run on.
-This method will attempt to use `window.fetch` if available (in browser environments).
-If running in a Node environment, it falls back to using the Node `https` module
+This method will attempt to use `window.fetch` if available (in browser environments),
+then `globalThis.fetch` (service workers, Deno, Node 18+), then the Node `https` module.
 
 ```ts
 export function defaultHttpClient(): HttpClient 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bsv/sdk",
-  "version": "2.0.14",
+  "version": "2.0.16",
   "type": "module",
   "description": "BSV Blockchain Software Development Kit",
   "main": "dist/cjs/mod.js",
@@ -251,23 +251,23 @@
   },
   "homepage": "https://github.com/bsv-blockchain/ts-sdk#readme",
   "devDependencies": {
-    "@eslint/js": "^9.39.1",
-    "@jest/globals": "^30.2.0",
-    "@rspack/cli": "^1.6.1",
-    "@rspack/core": "^1.6.1",
+    "@eslint/js": "^10.0.1",
+    "@jest/globals": "^30.3.0",
+    "@rspack/cli": "^2.0.0",
+    "@rspack/core": "^2.0.0",
     "@types/jest": "^30.0.0",
-    "@types/node": "^24.10.1",
-    "eslint": "^9.39.1",
-    "globals": "^16.5.0",
-    "jest": "^30.2.0",
-    "jest-environment-jsdom": "^30.2.0",
-    "ts-jest": "^29.4.5",
-    "ts-loader": "^9.5.4",
+    "@types/node": "^25.6.0",
+    "eslint": "^10.2.1",
+    "globals": "^17.5.0",
+    "jest": "^30.3.0",
+    "jest-environment-jsdom": "^30.3.0",
+    "ts-jest": "^29.4.9",
+    "ts-loader": "^9.5.7",
     "ts-standard": "^12.0.2",
     "ts2md": "^0.2.8",
     "tsconfig-to-dual-package": "^1.2.0",
-    "typescript": "^5.9.3",
-    "typescript-eslint": "^8.46.4"
+    "typescript": "^6.0.3",
+    "typescript-eslint": "^8.59.0"
   },
   "ts-standard": {
     "project": "tsconfig.eslint.json",

package/src/kvstore/GlobalKVStore.ts

@@ -106,9 +106,7 @@ export class GlobalKVStore {
    * @returns {Promise<KVStoreEntry | KVStoreEntry[] | undefined>} Single entry for key+controller queries, array for all other queries
    */
   async get (query: KVStoreQuery, options: KVStoreGetOptions = {}): Promise<KVStoreEntry | KVStoreEntry[] | undefined> {
-    if (Object.keys(query).length === 0) {
-      throw new Error('Must specify either key, controller, or protocolID')
-    }
+    this.validateQuerySelectors(query)
     if (query.key != null && query.controller != null) {
       // Specific key+controller query - return single entry
       const entries = await this.queryOverlay(query, options)
@@ -117,6 +115,24 @@ export class GlobalKVStore {
     return await this.queryOverlay(query, options)
   }
 
+  /**
+   * Ensures lookup pagination and ordering options are only used with a real KV selector.
+   *
+   * @param {KVStoreQuery} query - Query parameters sent to overlay.
+   * @throws {Error} If the query does not include a valid selector.
+   */
+  private validateQuerySelectors (query: KVStoreQuery): void {
+    const hasSelector =
+      (typeof query.key === 'string' && query.key.length > 0) ||
+      (typeof query.controller === 'string' && query.controller.length > 0) ||
+      (Array.isArray(query.protocolID) && query.protocolID.length === 2) ||
+      (Array.isArray(query.tags) && query.tags.length > 0)
+
+    if (!hasSelector) {
+      throw new Error('Must specify at least one selector: key, controller, protocolID, or tags')
+    }
+  }
+
   /**
    * Sets a key-value pair. The current user (wallet identity) becomes the controller.
    *

package/src/kvstore/__tests/GlobalKVStore.test.ts

@@ -577,7 +577,30 @@ describe('GlobalKVStore', () => {
 
     describe('sad paths', () => {
       it('rejects when no query parameters provided', async () => {
-        await expect(kvStore.get({})).rejects.toThrow('Must specify either key, controller, or protocolID')
+        await expect(kvStore.get({})).rejects.toThrow(
+          'Must specify at least one selector: key, controller, protocolID, or tags'
+        )
+      })
+
+      it('rejects pagination-only queries before resolving overlay hosts', async () => {
+        await expect(kvStore.get({ limit: 10 })).rejects.toThrow(
+          'Must specify at least one selector: key, controller, protocolID, or tags'
+        )
+        expect(mockResolver.query).not.toHaveBeenCalled()
+      })
+
+      it('rejects ordering-only queries before resolving overlay hosts', async () => {
+        await expect(kvStore.get({ sortOrder: 'desc' })).rejects.toThrow(
+          'Must specify at least one selector: key, controller, protocolID, or tags'
+        )
+        expect(mockResolver.query).not.toHaveBeenCalled()
+      })
+
+      it('rejects empty tag selector queries before resolving overlay hosts', async () => {
+        await expect(kvStore.get({ tags: [] })).rejects.toThrow(
+          'Must specify at least one selector: key, controller, protocolID, or tags'
+        )
+        expect(mockResolver.query).not.toHaveBeenCalled()
       })
 
       it('propagates overlay errors', async () => {

package/src/kvstore/types.ts

@@ -37,7 +37,8 @@ export interface KVStoreConfig {
 
 /**
  * Query parameters for KVStore lookups from overlay services.
- * Used when searching for existing key-value pairs in the network.
+ * Must include at least one selector: key, controller, protocolID, or non-empty tags.
+ * Pagination and ordering fields only refine selector-based lookups.
  */
 export interface KVStoreQuery {
   key?: string

package/src/primitives/Hash.ts

@@ -327,7 +327,7 @@ function zero8 (word: string): string {
 
 function bytesToHex (data: Uint8Array): string {
   let res = ''
-  for (const b of data) res += (b.toString(16).padStart(2, '0') as string)
+  for (const b of data) res += (b.toString(16).padStart(2, '0'))
   return res
 }
 

package/src/primitives/TransactionSignature.ts

@@ -3,7 +3,6 @@ import BigNumber from './BigNumber.js'
 import * as Hash from './Hash.js'
 import { toArray, Writer } from './utils.js'
 import Script from '../script/Script.js'
-import OP from '../script/OP.js'
 import TransactionInput from '../transaction/TransactionInput.js'
 import TransactionOutput from '../transaction/TransactionOutput.js'
 
@@ -56,8 +55,8 @@ export default class TransactionSignature extends Signature {
     const isNone = (params.scope & 31) === TransactionSignature.SIGHASH_NONE
     const isAll = (params.scope & 31) === TransactionSignature.SIGHASH_ALL || (!isSingle && !isNone)
 
-    const subscript = new Script([...params.subscript.chunks])
-    subscript.findAndDelete(new Script().writeOpCode(OP.OP_CODESEPARATOR))
+    const subscript = Script.fromBinary(params.subscript.toBinary())
+    subscript.removeCodeseparators()
 
     const currentInput = {
       sourceTXID: params.sourceTXID,
@@ -332,6 +331,15 @@ export default class TransactionSignature extends Signature {
     return new Uint8Array(0)
   }
 
+  static usesOtdaSingleBug (params: TransactionSignatureFormatParams): boolean {
+    const hasForkId = (params.scope & TransactionSignature.SIGHASH_FORKID) !== 0
+    const hasChronicle = params.ignoreChronicle !== true && (params.scope & TransactionSignature.SIGHASH_CHRONICLE) !== 0
+    const usesOtda = !hasForkId || (hasForkId && hasChronicle)
+    return usesOtda &&
+      (params.scope & 31) === TransactionSignature.SIGHASH_SINGLE &&
+      params.inputIndex >= params.outputs.length
+  }
+
   // The format used in a tx
   static fromChecksigFormat (buf: number[]): TransactionSignature {
     if (buf.length === 0) {

package/src/script/Script.ts

@@ -335,14 +335,11 @@ export default class Script {
    * @returns This script instance for chaining.
    */
   removeCodeseparators (): Script {
-    this.invalidateSerializationCaches()
-    const chunks: ScriptChunk[] = []
-    for (let i = 0; i < this.chunks.length; i++) {
-      if (this.chunks[i].op !== OP.OP_CODESEPARATOR) {
-        chunks.push(this.chunks[i])
-      }
-    }
-    this.chunks = chunks
+    const bytes = this.toUint8Array()
+    this.rawBytesCache = Uint8Array.from(Script.removeOpcodeBytes(bytes, OP.OP_CODESEPARATOR))
+    this.hexCache = undefined
+    this._chunks = []
+    this.parsed = false
     return this
   }
 
@@ -585,18 +582,22 @@ export default class Script {
         const end = Math.min(pos + len, length)
         chunks.push({
           data: Script.copyRange(bytes, pos, end),
-          op
+          op,
+          invalidLength: end - pos !== len
         })
         pos = end
       } else if (op === OP.OP_PUSHDATA1) {
-        const len = pos < length ? bytes[pos++] ?? 0 : 0
+        const hasLength = pos < length
+        const len = hasLength ? bytes[pos++] ?? 0 : 0
         const end = Math.min(pos + len, length)
         chunks.push({
           data: Script.copyRange(bytes, pos, end),
-          op
+          op,
+          invalidLength: !hasLength || end - pos !== len
         })
         pos = end
       } else if (op === OP.OP_PUSHDATA2) {
+        const hasLength = pos + 1 < length
         const b0 = bytes[pos] ?? 0
         const b1 = bytes[pos + 1] ?? 0
         const len = b0 | (b1 << 8)
@@ -604,10 +605,12 @@ export default class Script {
         const end = Math.min(pos + len, length)
         chunks.push({
           data: Script.copyRange(bytes, pos, end),
-          op
+          op,
+          invalidLength: !hasLength || end - pos !== len
         })
         pos = end
       } else if (op === OP.OP_PUSHDATA4) {
+        const hasLength = pos + 3 < length
         const len =
           ((bytes[pos] ?? 0) |
             ((bytes[pos + 1] ?? 0) << 8) |
@@ -618,7 +621,8 @@ export default class Script {
         const end = Math.min(pos + len, length)
         chunks.push({
           data: Script.copyRange(bytes, pos, end),
-          op
+          op,
+          invalidLength: !hasLength || end - pos !== len
         })
         pos = end
       } else {
@@ -629,6 +633,48 @@ export default class Script {
     return chunks
   }
 
+  private static removeOpcodeBytes (bytes: ArrayLike<number>, opcode: number): number[] {
+    const out: number[] = []
+    const length = bytes.length
+    let pos = 0
+
+    while (pos < length) {
+      const start = pos
+      const op = bytes[pos++] ?? 0
+      let dataStart = pos
+      let dataLength = 0
+
+      if (op > 0 && op < OP.OP_PUSHDATA1) {
+        dataLength = op
+      } else if (op === OP.OP_PUSHDATA1) {
+        if (pos < length) dataLength = bytes[pos++] ?? 0
+        dataStart = pos
+      } else if (op === OP.OP_PUSHDATA2) {
+        if (pos + 1 < length) dataLength = (bytes[pos] ?? 0) | ((bytes[pos + 1] ?? 0) << 8)
+        pos = Math.min(pos + 2, length)
+        dataStart = pos
+      } else if (op === OP.OP_PUSHDATA4) {
+        if (pos + 3 < length) {
+          dataLength =
+            ((bytes[pos] ?? 0) |
+              ((bytes[pos + 1] ?? 0) << 8) |
+              ((bytes[pos + 2] ?? 0) << 16) |
+              ((bytes[pos + 3] ?? 0) << 24)) >>> 0
+        }
+        pos = Math.min(pos + 4, length)
+        dataStart = pos
+      }
+
+      const end = Math.min(dataStart + dataLength, length)
+      if (op !== opcode) {
+        for (let i = start; i < end; i++) out.push(bytes[i] ?? 0)
+      }
+      pos = end
+    }
+
+    return out
+  }
+
   private static copyRange (
     bytes: ArrayLike<number>,
     start: number,

package/src/script/ScriptChunk.ts

@@ -4,4 +4,5 @@
 export default interface ScriptChunk {
   op: number
   data?: number[]
+  invalidLength?: boolean
 }