@bsv/sdk 1.5.2 → 1.6.0

package/dist/cjs/src/script/Spend.js

@@ -35,13 +35,104 @@ const TransactionSignature_js_1 = __importDefault(require("../primitives/Transac
 const PublicKey_js_1 = __importDefault(require("../primitives/PublicKey.js"));
 const ECDSA_js_1 = require("../primitives/ECDSA.js");
 // These constants control the current behavior of the interpreter.
-// In the future, all of them will go away.
 const maxScriptElementSize = 1024 * 1024 * 1024;
 const maxMultisigKeyCount = Math.pow(2, 31) - 1;
 const requireMinimalPush = true;
 const requirePushOnlyUnlockingScripts = true;
 const requireLowSSignatures = true;
 const requireCleanStack = true;
+// --- Optimization: Pre-computed script numbers ---
+const SCRIPTNUM_NEG_1 = Object.freeze(new BigNumber_js_1.default(-1).toScriptNum());
+const SCRIPTNUMS_0_TO_16 = Object.freeze(Array.from({ length: 17 }, (_, i) => Object.freeze(new BigNumber_js_1.default(i).toScriptNum())));
+// --- Helper functions ---
+function compareNumberArrays(a, b) {
+    if (a.length !== b.length)
+        return false;
+    for (let i = 0; i < a.length; i++) {
+        if (a[i] !== b[i])
+            return false;
+    }
+    return true;
+}
+function isMinimallyEncodedHelper(buf, maxNumSize = Number.MAX_SAFE_INTEGER) {
+    if (buf.length > maxNumSize) {
+        return false;
+    }
+    if (buf.length > 0) {
+        if ((buf[buf.length - 1] & 0x7f) === 0) {
+            if (buf.length <= 1 || (buf[buf.length - 2] & 0x80) === 0) {
+                return false;
+            }
+        }
+    }
+    return true;
+}
+function isChecksigFormatHelper(buf) {
+    // This is a simplified check. The full DER check is more complex and typically
+    // done by TransactionSignature.fromChecksigFormat which can throw.
+    // This helper is mostly for early bailout or non-throwing checks if needed.
+    if (buf.length < 9 || buf.length > 73)
+        return false;
+    if (buf[0] !== 0x30)
+        return false; // DER SEQUENCE
+    if (buf[1] !== buf.length - 3)
+        return false; // Total length (excluding type and length byte for sequence, and hash type)
+    const rMarker = buf[2];
+    const rLen = buf[3];
+    if (rMarker !== 0x02)
+        return false; // DER INTEGER
+    if (rLen === 0)
+        return false; // R length is zero
+    if (5 + rLen >= buf.length)
+        return false; // S length misplaced or R too long
+    const sMarkerOffset = 4 + rLen;
+    const sMarker = buf[sMarkerOffset];
+    const sLen = buf[sMarkerOffset + 1];
+    if (sMarker !== 0x02)
+        return false; // DER INTEGER
+    if (sLen === 0)
+        return false; // S length is zero
+    // Check R value negative or excessively padded
+    if ((buf[4] & 0x80) !== 0)
+        return false; // R value negative
+    if (rLen > 1 && buf[4] === 0x00 && (buf[5] & 0x80) === 0)
+        return false; // R value excessively padded
+    // Check S value negative or excessively padded
+    const sValueOffset = sMarkerOffset + 2;
+    if ((buf[sValueOffset] & 0x80) !== 0)
+        return false; // S value negative
+    if (sLen > 1 && buf[sValueOffset] === 0x00 && (buf[sValueOffset + 1] & 0x80) === 0)
+        return false; // S value excessively padded
+    if (rLen + sLen + 7 !== buf.length)
+        return false; // Final length check including hash type
+    return true;
+}
+function isOpcodeDisabledHelper(op) {
+    return (op === OP_js_1.default.OP_2MUL ||
+        op === OP_js_1.default.OP_2DIV ||
+        op === OP_js_1.default.OP_VERIF ||
+        op === OP_js_1.default.OP_VERNOTIF ||
+        op === OP_js_1.default.OP_VER);
+}
+function isChunkMinimalPushHelper(chunk) {
+    const data = chunk.data;
+    const op = chunk.op;
+    if (!Array.isArray(data))
+        return true;
+    if (data.length === 0)
+        return op === OP_js_1.default.OP_0;
+    if (data.length === 1 && data[0] >= 1 && data[0] <= 16)
+        return op === OP_js_1.default.OP_1 + (data[0] - 1);
+    if (data.length === 1 && data[0] === 0x81)
+        return op === OP_js_1.default.OP_1NEGATE;
+    if (data.length <= 75)
+        return op === data.length;
+    if (data.length <= 255)
+        return op === OP_js_1.default.OP_PUSHDATA1;
+    if (data.length <= 65535)
+        return op === OP_js_1.default.OP_PUSHDATA2;
+    return true;
+}
 /**
  * The Spend class represents a spend action within a Bitcoin SV transaction.
  * It encapsulates all the necessary data required for spending a UTXO (Unspent Transaction Output)
@@ -107,7 +198,10 @@ class Spend {
         this.unlockingScript = params.unlockingScript;
         this.inputSequence = params.inputSequence;
         this.lockTime = params.lockTime;
-        this.memoryLimit = (_a = params.memoryLimit) !== null && _a !== void 0 ? _a : 100000; // 100 MB is going to be processed by most miners by policy, but the default should protect apps against memory attacks.
+        this.memoryLimit = (_a = params.memoryLimit) !== null && _a !== void 0 ? _a : 32000000;
+        this.stack = [];
+        this.altStack = [];
+        this.ifStack = [];
         this.stackMem = 0;
         this.altStackMem = 0;
         this.reset();
@@ -122,280 +216,182 @@ class Spend {
         this.stackMem = 0;
         this.altStackMem = 0;
     }
-    step() {
-        var _a, _b, _c, _d;
-        let poppedValue;
-        // If the stack (or alt stack) is over the memory limit, evaluation has failed.
-        if (this.stackMem > this.memoryLimit) {
+    ensureStackMem(additional) {
+        if (this.stackMem + additional > this.memoryLimit) {
             this.scriptEvaluationError('Stack memory usage has exceeded ' + String(this.memoryLimit) + ' bytes');
-            return false;
         }
-        if (this.altStackMem > this.memoryLimit) {
+    }
+    ensureAltStackMem(additional) {
+        if (this.altStackMem + additional > this.memoryLimit) {
             this.scriptEvaluationError('Alt stack memory usage has exceeded ' + String(this.memoryLimit) + ' bytes');
-            return false;
         }
-        // Clear popped values after use to free memory
-        const clearPoppedValue = () => {
-            poppedValue = undefined;
-        };
-        // If the context is UnlockingScript and we have reached the end,
-        // set the context to LockingScript and zero the program counter
-        if (this.context === 'UnlockingScript' &&
-            this.programCounter >= this.unlockingScript.chunks.length) {
-            this.context = 'LockingScript';
-            this.programCounter = 0;
+    }
+    pushStack(item) {
+        this.ensureStackMem(item.length);
+        this.stack.push(item);
+        this.stackMem += item.length;
+    }
+    pushStackCopy(item) {
+        this.ensureStackMem(item.length);
+        const copy = item.slice();
+        this.stack.push(copy);
+        this.stackMem += copy.length;
+    }
+    popStack() {
+        if (this.stack.length === 0) {
+            this.scriptEvaluationError('Attempted to pop from an empty stack.');
         }
-        let operation;
-        if (this.context === 'UnlockingScript') {
-            operation = this.unlockingScript.chunks[this.programCounter];
+        const item = this.stack.pop();
+        this.stackMem -= item.length;
+        return item;
+    }
+    stackTop(index = -1) {
+        // index = -1 for top, -2 for second top, etc.
+        // stack.length + index provides 0-based index from start
+        if (this.stack.length === 0 || this.stack.length < Math.abs(index) || (index >= 0 && index >= this.stack.length)) {
+            this.scriptEvaluationError(`Stack underflow accessing element at index ${index}. Stack length is ${this.stack.length}.`);
         }
-        else {
-            operation = this.lockingScript.chunks[this.programCounter];
+        return this.stack[this.stack.length + index];
+    }
+    pushAltStack(item) {
+        this.ensureAltStackMem(item.length);
+        this.altStack.push(item);
+        this.altStackMem += item.length;
+    }
+    popAltStack() {
+        if (this.altStack.length === 0) {
+            this.scriptEvaluationError('Attempted to pop from an empty alt stack.');
         }
-        const isOpcodeDisabled = (op) => {
-            return (op === OP_js_1.default.OP_2MUL ||
-                op === OP_js_1.default.OP_2DIV ||
-                op === OP_js_1.default.OP_VERIF ||
-                op === OP_js_1.default.OP_VERNOTIF ||
-                op === OP_js_1.default.OP_VER);
-        };
-        const isChunkMinimal = (chunk) => {
-            const data = chunk.data;
-            const op = chunk.op;
-            if (!Array.isArray(data)) {
-                return true;
-            }
-            if (data.length === 0) {
-                // Could have used OP_0.
-                return op === OP_js_1.default.OP_0;
-            }
-            else if (data.length === 1 && data[0] >= 1 && data[0] <= 16) {
-                // Could have used OP_1 .. OP_16.
-                return op === OP_js_1.default.OP_1 + (data[0] - 1);
-            }
-            else if (data.length === 1 && data[0] === 0x81) {
-                // Could have used OP_1NEGATE.
-                return op === OP_js_1.default.OP_1NEGATE;
-            }
-            else if (data.length <= 75) {
-                // Could have used a direct push (opCode indicating number of bytes pushed + those bytes).
-                return op === data.length;
-            }
-            else if (data.length <= 255) {
-                // Could have used OP_PUSHDATA.
-                return op === OP_js_1.default.OP_PUSHDATA1;
-            }
-            else if (data.length <= 65535) {
-                // Could have used OP_PUSHDATA2.
-                return op === OP_js_1.default.OP_PUSHDATA2;
-            }
-            return true;
-        };
-        // Following example from sCrypt now using Number.MAX_SAFE_INTEGER (bsv/lib/transaction/input/input).
-        const isMinimallyEncoded = (buf, maxNumSize = Number.MAX_SAFE_INTEGER) => {
-            if (buf.length > maxNumSize) {
-                return false;
-            }
-            if (buf.length > 0) {
-                // Check that the number is encoded with the minimum possible number
-                // of bytes.
-                //
-                // If the most-significant-byte - excluding the sign bit - is zero
-                // then we're not minimal. Note how this test also rejects the
-                // negative-zero encoding, 0x80.
-                if ((buf[buf.length - 1] & 0x7f) === 0) {
-                    // One exception: if there's more than one byte and the most
-                    // significant bit of the second-most-significant-byte is set it
-                    // would conflict with the sign bit. An example of this case is
-                    // +-255, which encode to 0xff00 and 0xff80 respectively.
-                    // (big-endian).
-                    if (buf.length <= 1 || (buf[buf.length - 2] & 0x80) === 0) {
-                        return false;
-                    }
-                }
-            }
-            return true;
-        };
-        const padDataToSize = (buf, len) => {
-            const b = buf;
-            while (b.length < len) {
-                b.unshift(0);
-            }
-            return b;
-        };
-        /**
-         * This function is translated from bitcoind's IsDERSignature and is used in
-         * the script interpreter.  This "DER" format actually includes an extra byte,
-         * the nHashType, at the end. It is really the tx format, not DER format.
-         *
-         * A canonical signature exists of: [30] [total len] [02] [len R] [R] [02] [len S] [S] [hashtype]
-         * Where R and S are not negative (their first byte has its highest bit not set), and not
-         * excessively padded (do not start with a 0 byte, unless an otherwise negative number follows,
-         * in which case a single 0 byte is necessary and even required).
-         *
-         * See https://bitcointalk.org/index.php?topic=8392.msg127623#msg127623
-         */
-        const isChecksigFormat = (buf) => {
-            if (buf.length < 9) {
-                //  Non-canonical signature: too short
-                return false;
-            }
-            if (buf.length > 73) {
-                // Non-canonical signature: too long
-                return false;
-            }
-            if (buf[0] !== 0x30) {
-                //  Non-canonical signature: wrong type
-                return false;
-            }
-            if (buf[1] !== buf.length - 3) {
-                //  Non-canonical signature: wrong length marker
-                return false;
-            }
-            const nLEnR = buf[3];
-            if (5 + nLEnR >= buf.length) {
-                //  Non-canonical signature: S length misplaced
-                return false;
-            }
-            const nLEnS = buf[5 + nLEnR];
-            if (nLEnR + nLEnS + 7 !== buf.length) {
-                //  Non-canonical signature: R+S length mismatch
-                return false;
-            }
-            const R = buf.slice(4);
-            if (buf[4 - 2] !== 0x02) {
-                //  Non-canonical signature: R value type mismatch
-                return false;
-            }
-            if (buf[4 - 1] !== nLEnR) {
-                //  Non-canonical signature: R length mismatch
-                return false;
-            }
-            if (nLEnR === 0) {
-                //  Non-canonical signature: R length is zero
-                return false;
-            }
-            if ((R[0] & 0x80) !== 0) {
-                //  Non-canonical signature: R value negative
-                return false;
-            }
-            if (nLEnR > 1 && R[0] === 0x00 && (R[1] & 0x80) === 0) {
-                //  Non-canonical signature: R value excessively padded
-                return false;
-            }
-            const S = buf.slice(6 + nLEnR);
-            if (buf[6 + nLEnR - 2] !== 0x02) {
-                //  Non-canonical signature: S value type mismatch
-                return false;
-            }
-            if (buf[6 + nLEnR - 1] !== nLEnS) {
-                //  Non-canonical signature: S length mismatch
-                return false;
-            }
-            if (nLEnS === 0) {
-                //  Non-canonical signature: S length is zero
-                return false;
-            }
-            if ((S[0] & 0x80) !== 0) {
-                //  Non-canonical signature: S value negative
-                return false;
-            }
-            if (nLEnS > 1 && S[0] === 0x00 && (S[1] & 0x80) === 0) {
-                //  Non-canonical signature: S value excessively padded
-                return false;
-            }
+        const item = this.altStack.pop();
+        this.altStackMem -= item.length;
+        return item;
+    }
+    checkSignatureEncoding(buf) {
+        if (buf.length === 0)
             return true;
-        };
-        const checkSignatureEncoding = (buf) => {
-            // Empty signature. Not strictly DER encoded, but allowed to provide a
-            // compact way to provide an invalid signature for use with CHECK(MULTI)SIG
-            if (buf.length === 0) {
-                return true;
-            }
-            if (!isChecksigFormat(buf)) {
-                this.scriptEvaluationError('The signature format is invalid.');
-            }
-            const sig = TransactionSignature_js_1.default.fromChecksigFormat(buf);
+        if (!isChecksigFormatHelper(buf)) {
+            this.scriptEvaluationError('The signature format is invalid.'); // Generic message like original
+            return false;
+        }
+        try {
+            const sig = TransactionSignature_js_1.default.fromChecksigFormat(buf); // This can throw for stricter DER rules
             if (requireLowSSignatures && !sig.hasLowS()) {
                 this.scriptEvaluationError('The signature must have a low S value.');
+                return false;
             }
             if ((sig.scope & TransactionSignature_js_1.default.SIGHASH_FORKID) === 0) {
                 this.scriptEvaluationError('The signature must use SIGHASH_FORKID.');
                 return false;
             }
-            return true;
-        };
-        const checkPublicKeyEncoding = (buf) => {
-            if (buf.length < 33) {
-                this.scriptEvaluationError('The public key is too short, it must be at least 33 bytes.');
-            }
-            if (buf[0] === 0x04) {
-                if (buf.length !== 65) {
-                    this.scriptEvaluationError('The non-compressed public key must be 65 bytes.');
-                }
-            }
-            else if (buf[0] === 0x02 || buf[0] === 0x03) {
-                if (buf.length !== 33) {
-                    this.scriptEvaluationError('The compressed public key must be 33 bytes.');
-                }
+        }
+        catch (e) {
+            this.scriptEvaluationError('The signature format is invalid.');
+            return false;
+        }
+        return true;
+    }
+    checkPublicKeyEncoding(buf) {
+        if (buf.length === 0) {
+            this.scriptEvaluationError('Public key is empty.');
+            return false;
+        }
+        if (buf.length < 33) {
+            this.scriptEvaluationError('The public key is too short, it must be at least 33 bytes.');
+            return false;
+        }
+        if (buf[0] === 0x04) {
+            if (buf.length !== 65) {
+                this.scriptEvaluationError('The non-compressed public key must be 65 bytes.');
+                return false;
             }
-            else {
-                this.scriptEvaluationError('The public key is in an unknown format.');
+        }
+        else if (buf[0] === 0x02 || buf[0] === 0x03) {
+            if (buf.length !== 33) {
+                this.scriptEvaluationError('The compressed public key must be 33 bytes.');
+                return false;
             }
-            return true;
-        };
-        const verifySignature = (sig, pubkey, subscript) => {
-            const preimage = TransactionSignature_js_1.default.format({
-                sourceTXID: this.sourceTXID,
-                sourceOutputIndex: this.sourceOutputIndex,
-                sourceSatoshis: this.sourceSatoshis,
-                transactionVersion: this.transactionVersion,
-                otherInputs: this.otherInputs,
-                outputs: this.outputs,
-                inputIndex: this.inputIndex,
-                subscript,
-                inputSequence: this.inputSequence,
-                lockTime: this.lockTime,
-                scope: sig.scope
-            });
-            const hash = new BigNumber_js_1.default(Hash.hash256(preimage));
-            return (0, ECDSA_js_1.verify)(hash, sig, pubkey);
-        };
-        const isScriptExecuting = !this.ifStack.includes(false);
-        let buf, buf1, buf2, buf3, spliced, n, size, rawnum, num, signbit, x1, x2, x3, bn, bn1, bn2, bn3, bufSig, bufPubkey, subscript;
-        let sig, pubkey, i, fOk, nKeysCount, ikey, ikey2, nSigsCount, isig;
-        let fValue, fEqual, fSuccess;
-        // Read instruction
+        }
+        else {
+            this.scriptEvaluationError('The public key is in an unknown format.');
+            return false;
+        }
+        try {
+            PublicKey_js_1.default.fromDER(buf); // This can throw for stricter DER rules
+        }
+        catch (e) {
+            this.scriptEvaluationError('The public key is in an unknown format.');
+            return false;
+        }
+        return true;
+    }
+    verifySignature(sig, pubkey, subscript) {
+        const preimage = TransactionSignature_js_1.default.format({
+            sourceTXID: this.sourceTXID,
+            sourceOutputIndex: this.sourceOutputIndex,
+            sourceSatoshis: this.sourceSatoshis,
+            transactionVersion: this.transactionVersion,
+            otherInputs: this.otherInputs,
+            outputs: this.outputs,
+            inputIndex: this.inputIndex,
+            subscript,
+            inputSequence: this.inputSequence,
+            lockTime: this.lockTime,
+            scope: sig.scope
+        });
+        const hash = new BigNumber_js_1.default(Hash.hash256(preimage));
+        return (0, ECDSA_js_1.verify)(hash, sig, pubkey);
+    }
+    step() {
+        if (this.stackMem > this.memoryLimit) {
+            this.scriptEvaluationError('Stack memory usage has exceeded ' + String(this.memoryLimit) + ' bytes');
+            return false; // Error thrown
+        }
+        if (this.altStackMem > this.memoryLimit) {
+            this.scriptEvaluationError('Alt stack memory usage has exceeded ' + String(this.memoryLimit) + ' bytes');
+            return false; // Error thrown
+        }
+        if (this.context === 'UnlockingScript' &&
+            this.programCounter >= this.unlockingScript.chunks.length) {
+            this.context = 'LockingScript';
+            this.programCounter = 0;
+        }
+        const currentScript = this.context === 'UnlockingScript' ? this.unlockingScript : this.lockingScript;
+        if (this.programCounter >= currentScript.chunks.length) {
+            return false;
+        }
+        const operation = currentScript.chunks[this.programCounter];
         const currentOpcode = operation.op;
         if (typeof currentOpcode === 'undefined') {
-            this.scriptEvaluationError(`An opcode is missing in this chunk of the ${this.context}!`);
+            this.scriptEvaluationError(`Missing opcode in ${this.context} at pc=${this.programCounter}.`); // Error thrown
         }
-        if (Array.isArray(operation.data) &&
-            operation.data.length > maxScriptElementSize) {
-            this.scriptEvaluationError(`It's not currently possible to push data larger than ${maxScriptElementSize} bytes.`);
+        if (Array.isArray(operation.data) && operation.data.length > maxScriptElementSize) {
+            this.scriptEvaluationError(`Data push > ${maxScriptElementSize} bytes (pc=${this.programCounter}).`); // Error thrown
         }
-        if (isScriptExecuting && isOpcodeDisabled(currentOpcode)) {
-            this.scriptEvaluationError('This opcode is currently disabled.');
+        const isScriptExecuting = !this.ifStack.includes(false);
+        if (isScriptExecuting && isOpcodeDisabledHelper(currentOpcode)) {
+            this.scriptEvaluationError(`This opcode is currently disabled. (Opcode: ${OP_js_1.default[currentOpcode]}, PC: ${this.programCounter})`); // Error thrown
         }
-        if (isScriptExecuting &&
-            currentOpcode >= 0 &&
-            currentOpcode <= OP_js_1.default.OP_PUSHDATA4) {
-            if (requireMinimalPush && !isChunkMinimal(operation)) {
-                this.scriptEvaluationError('This data is not minimally-encoded.');
-            }
-            if (!Array.isArray(operation.data)) {
-                this.stack.push([]);
-                this.stackMem += 0;
-            }
-            else {
-                this.stack.push(operation.data);
-                this.stackMem += operation.data.length;
+        if (isScriptExecuting && currentOpcode >= 0 && currentOpcode <= OP_js_1.default.OP_PUSHDATA4) {
+            if (requireMinimalPush && !isChunkMinimalPushHelper(operation)) {
+                this.scriptEvaluationError(`This data is not minimally-encoded. (PC: ${this.programCounter})`); // Error thrown
             }
+            this.pushStack(Array.isArray(operation.data) ? operation.data : []);
         }
-        else if (isScriptExecuting ||
-            (OP_js_1.default.OP_IF <= currentOpcode && currentOpcode <= OP_js_1.default.OP_ENDIF)) {
+        else if (isScriptExecuting || (currentOpcode >= OP_js_1.default.OP_IF && currentOpcode <= OP_js_1.default.OP_ENDIF)) {
+            let buf, buf1, buf2, buf3;
+            let x1, x2, x3;
+            let bn, bn1, bn2, bn3;
+            let n, size, fValue, fSuccess, subscript;
+            let bufSig, bufPubkey;
+            let sig, pubkey;
+            let i, ikey, isig, nKeysCount, nSigsCount, fOk;
             switch (currentOpcode) {
                 case OP_js_1.default.OP_1NEGATE:
+                    this.pushStackCopy(SCRIPTNUM_NEG_1);
+                    break;
+                case OP_js_1.default.OP_0:
+                    this.pushStackCopy(SCRIPTNUMS_0_TO_16[0]);
+                    break;
                 case OP_js_1.default.OP_1:
                 case OP_js_1.default.OP_2:
                 case OP_js_1.default.OP_3:
@@ -413,13 +409,11 @@ class Spend {
                 case OP_js_1.default.OP_15:
                 case OP_js_1.default.OP_16:
                     n = currentOpcode - (OP_js_1.default.OP_1 - 1);
-                    buf = new BigNumber_js_1.default(n).toScriptNum();
-                    this.stack.push(buf);
-                    this.stackMem += buf.length;
+                    this.pushStackCopy(SCRIPTNUMS_0_TO_16[n]);
                     break;
                 case OP_js_1.default.OP_NOP:
-                case OP_js_1.default.OP_NOP2:
-                case OP_js_1.default.OP_NOP3:
+                case OP_js_1.default.OP_NOP2: // Formerly CHECKLOCKTIMEVERIFY
+                case OP_js_1.default.OP_NOP3: // Formerly CHECKSEQUENCEVERIFY
                 case OP_js_1.default.OP_NOP1:
                 case OP_js_1.default.OP_NOP4:
                 case OP_js_1.default.OP_NOP5:
@@ -428,6 +422,9 @@ class Spend {
                 case OP_js_1.default.OP_NOP8:
                 case OP_js_1.default.OP_NOP9:
                 case OP_js_1.default.OP_NOP10:
+                /* falls through */
+                // eslint-disable-next-line no-fallthrough
+                // eslint-disable-next-line no-fallthrough
                 case OP_js_1.default.OP_NOP11:
                 case OP_js_1.default.OP_NOP12:
                 case OP_js_1.default.OP_NOP13:
@@ -497,377 +494,267 @@ class Spend {
                 case OP_js_1.default.OP_NOTIF:
                     fValue = false;
                     if (isScriptExecuting) {
-                        if (this.stack.length < 1) {
+                        if (this.stack.length < 1)
                             this.scriptEvaluationError('OP_IF and OP_NOTIF require at least one item on the stack when they are used!');
-                        }
-                        buf = this.stacktop(-1);
+                        buf = this.popStack();
                         fValue = this.castToBool(buf);
-                        if (currentOpcode === OP_js_1.default.OP_NOTIF) {
+                        if (currentOpcode === OP_js_1.default.OP_NOTIF)
                             fValue = !fValue;
-                        }
-                        poppedValue = this.stack.pop();
-                        if (poppedValue != null) {
-                            this.stackMem -= poppedValue.length;
-                        }
-                        clearPoppedValue();
                     }
                     this.ifStack.push(fValue);
                     break;
                 case OP_js_1.default.OP_ELSE:
-                    if (this.ifStack.length === 0) {
+                    if (this.ifStack.length === 0)
                         this.scriptEvaluationError('OP_ELSE requires a preceeding OP_IF.');
-                    }
-                    this.ifStack[this.ifStack.length - 1] =
-                        !this.ifStack[this.ifStack.length - 1];
+                    this.ifStack[this.ifStack.length - 1] = !this.ifStack[this.ifStack.length - 1];
                     break;
                 case OP_js_1.default.OP_ENDIF:
-                    if (this.ifStack.length === 0) {
+                    if (this.ifStack.length === 0)
                         this.scriptEvaluationError('OP_ENDIF requires a preceeding OP_IF.');
-                    }
                     this.ifStack.pop();
                     break;
                 case OP_js_1.default.OP_VERIFY:
-                    if (this.stack.length < 1) {
+                    if (this.stack.length < 1)
                         this.scriptEvaluationError('OP_VERIFY requires at least one item to be on the stack.');
-                    }
-                    buf = this.stacktop(-1);
-                    fValue = this.castToBool(buf);
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    if (!fValue) {
+                    buf1 = this.stackTop();
+                    fValue = this.castToBool(buf1);
+                    if (!fValue)
                         this.scriptEvaluationError('OP_VERIFY requires the top stack value to be truthy.');
-                    }
+                    this.popStack();
                     break;
                 case OP_js_1.default.OP_RETURN:
-                    if (this.context === 'UnlockingScript') {
+                    if (this.context === 'UnlockingScript')
                         this.programCounter = this.unlockingScript.chunks.length;
-                    }
-                    else {
+                    else
                         this.programCounter = this.lockingScript.chunks.length;
-                    }
                     this.ifStack = [];
+                    this.programCounter--; // To counteract the final increment and ensure loop termination
                     break;
                 case OP_js_1.default.OP_TOALTSTACK:
-                    if (this.stack.length < 1) {
+                    if (this.stack.length < 1)
                         this.scriptEvaluationError('OP_TOALTSTACK requires at oeast one item to be on the stack.');
-                    }
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.altStack.push(poppedValue);
-                        this.altStackMem += poppedValue.length;
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
+                    this.pushAltStack(this.popStack());
                     break;
                 case OP_js_1.default.OP_FROMALTSTACK:
-                    if (this.altStack.length < 1) {
-                        this.scriptEvaluationError('OP_FROMALTSTACK requires at least one item to be on the stack.');
-                    }
-                    poppedValue = this.altStack.pop();
-                    if (poppedValue != null) {
-                        this.stack.push(poppedValue);
-                        this.stackMem += poppedValue.length;
-                        this.altStackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
+                    if (this.altStack.length < 1)
+                        this.scriptEvaluationError('OP_FROMALTSTACK requires at least one item to be on the stack.'); // "stack" here means altstack
+                    this.pushStack(this.popAltStack());
                     break;
                 case OP_js_1.default.OP_2DROP:
-                    if (this.stack.length < 2) {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError('OP_2DROP requires at least two items to be on the stack.');
-                    }
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
+                    this.popStack();
+                    this.popStack();
                     break;
                 case OP_js_1.default.OP_2DUP:
-                    if (this.stack.length < 2) {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError('OP_2DUP requires at least two items to be on the stack.');
-                    }
-                    buf1 = this.stacktop(-2);
-                    buf2 = this.stacktop(-1);
-                    this.stack.push([...buf1]);
-                    this.stackMem += buf1.length;
-                    this.stack.push([...buf2]);
-                    this.stackMem += buf2.length;
+                    buf1 = this.stackTop(-2);
+                    buf2 = this.stackTop(-1);
+                    this.pushStackCopy(buf1);
+                    this.pushStackCopy(buf2);
                     break;
                 case OP_js_1.default.OP_3DUP:
-                    if (this.stack.length < 3) {
+                    if (this.stack.length < 3)
                         this.scriptEvaluationError('OP_3DUP requires at least three items to be on the stack.');
-                    }
-                    buf1 = this.stacktop(-3);
-                    buf2 = this.stacktop(-2);
-                    buf3 = this.stacktop(-1);
-                    this.stack.push([...buf1]);
-                    this.stackMem += buf1.length;
-                    this.stack.push([...buf2]);
-                    this.stackMem += buf2.length;
-                    this.stack.push([...buf3]);
-                    this.stackMem += buf3.length;
+                    buf1 = this.stackTop(-3);
+                    buf2 = this.stackTop(-2);
+                    buf3 = this.stackTop(-1);
+                    this.pushStackCopy(buf1);
+                    this.pushStackCopy(buf2);
+                    this.pushStackCopy(buf3);
                     break;
                 case OP_js_1.default.OP_2OVER:
-                    if (this.stack.length < 4) {
+                    if (this.stack.length < 4)
                         this.scriptEvaluationError('OP_2OVER requires at least four items to be on the stack.');
-                    }
-                    buf1 = this.stacktop(-4);
-                    buf2 = this.stacktop(-3);
-                    this.stack.push([...buf1]);
-                    this.stackMem += buf1.length;
-                    this.stack.push([...buf2]);
-                    this.stackMem += buf2.length;
+                    buf1 = this.stackTop(-4);
+                    buf2 = this.stackTop(-3);
+                    this.pushStackCopy(buf1);
+                    this.pushStackCopy(buf2);
                     break;
-                case OP_js_1.default.OP_2ROT:
-                    if (this.stack.length < 6) {
+                case OP_js_1.default.OP_2ROT: {
+                    if (this.stack.length < 6)
                         this.scriptEvaluationError('OP_2ROT requires at least six items to be on the stack.');
-                    }
-                    spliced = this.stack.splice(this.stack.length - 6, 2);
-                    this.stack.push(spliced[0]);
-                    this.stackMem += spliced[0].length;
-                    this.stack.push(spliced[1]);
-                    this.stackMem += spliced[1].length;
+                    const rot6 = this.popStack();
+                    const rot5 = this.popStack();
+                    const rot4 = this.popStack();
+                    const rot3 = this.popStack();
+                    const rot2 = this.popStack();
+                    const rot1 = this.popStack();
+                    this.pushStack(rot3);
+                    this.pushStack(rot4);
+                    this.pushStack(rot5);
+                    this.pushStack(rot6);
+                    this.pushStack(rot1);
+                    this.pushStack(rot2);
                     break;
-                case OP_js_1.default.OP_2SWAP:
-                    if (this.stack.length < 4) {
+                }
+                case OP_js_1.default.OP_2SWAP: {
+                    if (this.stack.length < 4)
                         this.scriptEvaluationError('OP_2SWAP requires at least four items to be on the stack.');
-                    }
-                    spliced = this.stack.splice(this.stack.length - 4, 2);
-                    this.stack.push(spliced[0]);
-                    this.stackMem += spliced[0].length;
-                    this.stack.push(spliced[1]);
-                    this.stackMem += spliced[1].length;
+                    const swap4 = this.popStack();
+                    const swap3 = this.popStack();
+                    const swap2 = this.popStack();
+                    const swap1 = this.popStack();
+                    this.pushStack(swap3);
+                    this.pushStack(swap4);
+                    this.pushStack(swap1);
+                    this.pushStack(swap2);
                     break;
+                }
                 case OP_js_1.default.OP_IFDUP:
-                    if (this.stack.length < 1) {
+                    if (this.stack.length < 1)
                         this.scriptEvaluationError('OP_IFDUP requires at least one item to be on the stack.');
-                    }
-                    buf = this.stacktop(-1);
-                    fValue = this.castToBool(buf);
-                    if (fValue) {
-                        this.stack.push([...buf]);
-                        this.stackMem += buf.length;
+                    buf1 = this.stackTop();
+                    if (this.castToBool(buf1)) {
+                        this.pushStackCopy(buf1);
                     }
                     break;
                 case OP_js_1.default.OP_DEPTH:
-                    buf = new BigNumber_js_1.default(this.stack.length).toScriptNum();
-                    this.stack.push(buf);
-                    this.stackMem += buf.length;
+                    this.pushStack(new BigNumber_js_1.default(this.stack.length).toScriptNum());
                     break;
                 case OP_js_1.default.OP_DROP:
-                    if (this.stack.length < 1) {
+                    if (this.stack.length < 1)
                         this.scriptEvaluationError('OP_DROP requires at least one item to be on the stack.');
-                    }
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
+                    this.popStack();
                     break;
                 case OP_js_1.default.OP_DUP:
-                    if (this.stack.length < 1) {
+                    if (this.stack.length < 1)
                         this.scriptEvaluationError('OP_DUP requires at least one item to be on the stack.');
-                    }
-                    this.stack.push([...this.stacktop(-1)]);
-                    this.stackMem += this.stacktop(-1).length;
+                    this.pushStackCopy(this.stackTop());
                     break;
                 case OP_js_1.default.OP_NIP:
-                    if (this.stack.length < 2) {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError('OP_NIP requires at least two items to be on the stack.');
-                    }
-                    this.stack.splice(this.stack.length - 2, 1);
-                    this.stackMem -= this.stacktop(-1).length;
+                    buf2 = this.popStack();
+                    this.popStack();
+                    this.pushStack(buf2);
                     break;
                 case OP_js_1.default.OP_OVER:
-                    if (this.stack.length < 2) {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError('OP_OVER requires at least two items to be on the stack.');
-                    }
-                    this.stack.push([...this.stacktop(-2)]);
-                    this.stackMem += this.stacktop(-2).length;
+                    this.pushStackCopy(this.stackTop(-2));
                     break;
                 case OP_js_1.default.OP_PICK:
-                case OP_js_1.default.OP_ROLL:
-                    if (this.stack.length < 2) {
+                case OP_js_1.default.OP_ROLL: {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires at least two items to be on the stack.`);
-                    }
-                    buf = this.stacktop(-1);
-                    bn = BigNumber_js_1.default.fromScriptNum(buf, requireMinimalPush);
+                    bn = BigNumber_js_1.default.fromScriptNum(this.popStack(), requireMinimalPush);
                     n = bn.toNumber();
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
                     if (n < 0 || n >= this.stack.length) {
                         this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires the top stack element to be 0 or a positive number less than the current size of the stack.`);
                     }
-                    buf = this.stacktop(-n - 1);
+                    const itemToMoveOrCopy = this.stack[this.stack.length - 1 - n];
                     if (currentOpcode === OP_js_1.default.OP_ROLL) {
-                        this.stack.splice(this.stack.length - n - 1, 1);
-                        this.stackMem -= buf.length;
+                        this.stack.splice(this.stack.length - 1 - n, 1);
+                        this.stackMem -= itemToMoveOrCopy.length;
+                        this.pushStack(itemToMoveOrCopy);
+                    }
+                    else { // OP_PICK
+                        this.pushStackCopy(itemToMoveOrCopy);
                     }
-                    this.stack.push([...buf]);
-                    this.stackMem += buf.length;
                     break;
+                }
                 case OP_js_1.default.OP_ROT:
-                    if (this.stack.length < 3) {
+                    if (this.stack.length < 3)
                         this.scriptEvaluationError('OP_ROT requires at least three items to be on the stack.');
-                    }
-                    x1 = this.stacktop(-3);
-                    x2 = this.stacktop(-2);
-                    x3 = this.stacktop(-1);
-                    this.stack[this.stack.length - 3] = x2;
-                    this.stack[this.stack.length - 2] = x3;
-                    this.stack[this.stack.length - 1] = x1;
+                    x3 = this.popStack();
+                    x2 = this.popStack();
+                    x1 = this.popStack();
+                    this.pushStack(x2);
+                    this.pushStack(x3);
+                    this.pushStack(x1);
                     break;
                 case OP_js_1.default.OP_SWAP:
-                    if (this.stack.length < 2) {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError('OP_SWAP requires at least two items to be on the stack.');
-                    }
-                    x1 = this.stacktop(-2);
-                    x2 = this.stacktop(-1);
-                    this.stack[this.stack.length - 2] = x2;
-                    this.stack[this.stack.length - 1] = x1;
+                    x2 = this.popStack();
+                    x1 = this.popStack();
+                    this.pushStack(x2);
+                    this.pushStack(x1);
                     break;
                 case OP_js_1.default.OP_TUCK:
-                    if (this.stack.length < 2) {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError('OP_TUCK requires at least two items to be on the stack.');
-                    }
-                    this.stack.splice(this.stack.length - 2, 0, [...this.stacktop(-1)]);
-                    this.stackMem += this.stacktop(-1).length;
+                    buf1 = this.stackTop(-1); // Top element (x2)
+                    // stack is [... rest, x1, x2]
+                    // We want [... rest, x2_copy, x1, x2]
+                    this.ensureStackMem(buf1.length);
+                    this.stack.splice(this.stack.length - 2, 0, buf1.slice()); // Insert copy of x2 before x1
+                    this.stackMem += buf1.length; // Account for the new copy
                     break;
                 case OP_js_1.default.OP_SIZE:
-                    if (this.stack.length < 1) {
+                    if (this.stack.length < 1)
                         this.scriptEvaluationError('OP_SIZE requires at least one item to be on the stack.');
-                    }
-                    bn = new BigNumber_js_1.default(this.stacktop(-1).length);
-                    this.stack.push(bn.toScriptNum());
-                    this.stackMem += bn.toScriptNum().length;
+                    this.pushStack(new BigNumber_js_1.default(this.stackTop().length).toScriptNum());
                     break;
                 case OP_js_1.default.OP_AND:
                 case OP_js_1.default.OP_OR:
-                case OP_js_1.default.OP_XOR:
-                    if (this.stack.length < 2) {
-                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires at least one item to be on the stack.`);
-                    }
-                    buf1 = this.stacktop(-2);
-                    buf2 = this.stacktop(-1);
-                    if (buf1.length !== buf2.length) {
+                case OP_js_1.default.OP_XOR: {
+                    if (this.stack.length < 2)
+                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires at least two items on the stack.`);
+                    buf2 = this.popStack();
+                    buf1 = this.popStack();
+                    if (buf1.length !== buf2.length)
                         this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires the top two stack items to be the same size.`);
-                    }
-                    switch (currentOpcode) {
-                        case OP_js_1.default.OP_AND:
-                            for (let i = 0; i < buf1.length; i++) {
-                                buf1[i] &= buf2[i];
-                            }
-                            break;
-                        case OP_js_1.default.OP_OR:
-                            for (let i = 0; i < buf1.length; i++) {
-                                buf1[i] |= buf2[i];
-                            }
-                            break;
-                        case OP_js_1.default.OP_XOR:
-                            for (let i = 0; i < buf1.length; i++) {
-                                buf1[i] ^= buf2[i];
-                            }
-                            break;
-                    }
-                    // And pop vch2.
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
+                    const resultBufBitwiseOp = new Array(buf1.length);
+                    for (let k = 0; k < buf1.length; k++) {
+                        if (currentOpcode === OP_js_1.default.OP_AND)
+                            resultBufBitwiseOp[k] = buf1[k] & buf2[k];
+                        else if (currentOpcode === OP_js_1.default.OP_OR)
+                            resultBufBitwiseOp[k] = buf1[k] | buf2[k];
+                        else
+                            resultBufBitwiseOp[k] = buf1[k] ^ buf2[k];
+                    }
+                    this.pushStack(resultBufBitwiseOp);
                     break;
-                case OP_js_1.default.OP_INVERT:
-                    if (this.stack.length < 1) {
+                }
+                case OP_js_1.default.OP_INVERT: {
+                    if (this.stack.length < 1)
                         this.scriptEvaluationError('OP_INVERT requires at least one item to be on the stack.');
+                    buf = this.popStack();
+                    const invertedBufOp = new Array(buf.length);
+                    for (let k = 0; k < buf.length; k++) {
+                        invertedBufOp[k] = (~buf[k]) & 0xff;
                     }
-                    buf = this.stacktop(-1);
-                    for (let i = 0; i < buf.length; i++) {
-                        buf[i] = ~buf[i];
-                    }
+                    this.pushStack(invertedBufOp);
                     break;
+                }
                 case OP_js_1.default.OP_LSHIFT:
-                case OP_js_1.default.OP_RSHIFT:
-                    if (this.stack.length < 2) {
+                case OP_js_1.default.OP_RSHIFT: {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires at least two items to be on the stack.`);
-                    }
-                    buf1 = this.stacktop(-2);
+                    bn2 = BigNumber_js_1.default.fromScriptNum(this.popStack(), requireMinimalPush); // n (shift amount)
+                    buf1 = this.popStack(); // value to shift
+                    n = bn2.toNumber();
+                    if (n < 0)
+                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires the top item on the stack not to be negative.`);
                     if (buf1.length === 0) {
-                        poppedValue = this.stack.pop();
-                        if (poppedValue != null) {
-                            this.stackMem -= poppedValue.length;
-                        }
-                        clearPoppedValue();
-                    }
-                    else {
-                        bn1 = new BigNumber_js_1.default(buf1);
-                        bn2 = BigNumber_js_1.default.fromScriptNum(this.stacktop(-1), requireMinimalPush);
-                        n = bn2.toNumber();
-                        if (n < 0) {
-                            this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires the top item on the stack not to be negative.`);
-                        }
-                        poppedValue = this.stack.pop();
-                        if (poppedValue != null) {
-                            this.stackMem -= poppedValue.length;
-                        }
-                        clearPoppedValue();
-                        poppedValue = this.stack.pop();
-                        if (poppedValue != null) {
-                            this.stackMem -= poppedValue.length;
-                        }
-                        clearPoppedValue();
-                        let shifted;
-                        if (currentOpcode === OP_js_1.default.OP_LSHIFT) {
-                            shifted = bn1.ushln(n);
-                        }
-                        if (currentOpcode === OP_js_1.default.OP_RSHIFT) {
-                            shifted = bn1.ushrn(n);
-                        }
-                        const bufShifted = padDataToSize(shifted.toArray().slice(buf1.length * -1), buf1.length);
-                        this.stack.push(bufShifted);
-                        this.stackMem += bufShifted.length;
+                        this.pushStack([]);
+                        break;
                     }
+                    bn1 = new BigNumber_js_1.default(buf1);
+                    let shiftedBn;
+                    if (currentOpcode === OP_js_1.default.OP_LSHIFT)
+                        shiftedBn = bn1.ushln(n);
+                    else
+                        shiftedBn = bn1.ushrn(n);
+                    const shiftedArr = shiftedBn.toArray('le', buf1.length);
+                    this.pushStack(shiftedArr);
                     break;
+                }
                 case OP_js_1.default.OP_EQUAL:
                 case OP_js_1.default.OP_EQUALVERIFY:
-                    if (this.stack.length < 2) {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires at least two items to be on the stack.`);
-                    }
-                    buf1 = this.stacktop(-2);
-                    buf2 = this.stacktop(-1);
-                    fEqual = (0, utils_js_1.toHex)(buf1) === (0, utils_js_1.toHex)(buf2);
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    this.stack.push(fEqual ? [1] : []);
-                    this.stackMem += (fEqual ? 1 : 0);
+                    buf2 = this.popStack();
+                    buf1 = this.popStack();
+                    fValue = compareNumberArrays(buf1, buf2);
+                    this.pushStack(fValue ? [1] : []);
                     if (currentOpcode === OP_js_1.default.OP_EQUALVERIFY) {
-                        if (this.castToBool(this.stacktop(-1))) {
-                            poppedValue = this.stack.pop();
-                            if (poppedValue != null) {
-                                this.stackMem -= poppedValue.length;
-                            }
-                            clearPoppedValue();
-                        }
-                        else {
+                        if (!fValue)
                             this.scriptEvaluationError('OP_EQUALVERIFY requires the top two stack items to be equal.');
-                        }
+                        this.popStack();
                     }
                     break;
                 case OP_js_1.default.OP_1ADD:
@@ -876,46 +763,37 @@ class Spend {
                 case OP_js_1.default.OP_ABS:
                 case OP_js_1.default.OP_NOT:
                 case OP_js_1.default.OP_0NOTEQUAL:
-                    if (this.stack.length < 1) {
-                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires at least one items to be on the stack.`);
-                    }
-                    buf = this.stacktop(-1);
-                    bn = BigNumber_js_1.default.fromScriptNum(buf, requireMinimalPush);
+                    if (this.stack.length < 1)
+                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires at least one item to be on the stack.`);
+                    bn = BigNumber_js_1.default.fromScriptNum(this.popStack(), requireMinimalPush);
                     switch (currentOpcode) {
                         case OP_js_1.default.OP_1ADD:
-                            bn = bn.addn(1);
+                            bn = bn.add(new BigNumber_js_1.default(1));
                             break;
                         case OP_js_1.default.OP_1SUB:
-                            bn = bn.subn(1);
+                            bn = bn.sub(new BigNumber_js_1.default(1));
                             break;
                         case OP_js_1.default.OP_NEGATE:
                             bn = bn.neg();
                             break;
                         case OP_js_1.default.OP_ABS:
-                            if (bn.cmpn(0) < 0) {
+                            if (bn.isNeg())
                                 bn = bn.neg();
-                            }
                             break;
                         case OP_js_1.default.OP_NOT:
-                            bn = new BigNumber_js_1.default(bn.cmpn(0) === 0 ? 1 : 0 + 0);
+                            bn = new BigNumber_js_1.default(bn.cmpn(0) === 0 ? 1 : 0);
                             break;
                         case OP_js_1.default.OP_0NOTEQUAL:
-                            bn = new BigNumber_js_1.default(bn.cmpn(0) !== 0 ? 1 : 0 + 0);
+                            bn = new BigNumber_js_1.default(bn.cmpn(0) !== 0 ? 1 : 0);
                             break;
                     }
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    this.stack.push(bn.toScriptNum());
-                    this.stackMem += bn.toScriptNum().length;
+                    this.pushStack(bn.toScriptNum());
                     break;
                 case OP_js_1.default.OP_ADD:
                 case OP_js_1.default.OP_SUB:
                 case OP_js_1.default.OP_MUL:
-                case OP_js_1.default.OP_MOD:
                 case OP_js_1.default.OP_DIV:
+                case OP_js_1.default.OP_MOD:
                 case OP_js_1.default.OP_BOOLAND:
                 case OP_js_1.default.OP_BOOLOR:
                 case OP_js_1.default.OP_NUMEQUAL:
@@ -926,276 +804,208 @@ class Spend {
                 case OP_js_1.default.OP_LESSTHANOREQUAL:
                 case OP_js_1.default.OP_GREATERTHANOREQUAL:
                 case OP_js_1.default.OP_MIN:
-                case OP_js_1.default.OP_MAX:
-                    if (this.stack.length < 2) {
+                case OP_js_1.default.OP_MAX: {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires at least two items to be on the stack.`);
+                    buf2 = this.popStack();
+                    buf1 = this.popStack();
+                    bn2 = BigNumber_js_1.default.fromScriptNum(buf2, requireMinimalPush);
+                    bn1 = BigNumber_js_1.default.fromScriptNum(buf1, requireMinimalPush);
+                    let predictedLen = 0;
+                    switch (currentOpcode) {
+                        case OP_js_1.default.OP_MUL:
+                            predictedLen = bn1.byteLength() + bn2.byteLength();
+                            break;
+                        case OP_js_1.default.OP_ADD:
+                        case OP_js_1.default.OP_SUB:
+                            predictedLen = Math.max(bn1.byteLength(), bn2.byteLength()) + 1;
+                            break;
+                        default:
+                            predictedLen = Math.max(bn1.byteLength(), bn2.byteLength());
                     }
-                    bn1 = BigNumber_js_1.default.fromScriptNum(this.stacktop(-2), requireMinimalPush);
-                    bn2 = BigNumber_js_1.default.fromScriptNum(this.stacktop(-1), requireMinimalPush);
-                    bn = new BigNumber_js_1.default(0);
+                    this.ensureStackMem(predictedLen);
+                    let resultBnArithmetic = new BigNumber_js_1.default(0);
                     switch (currentOpcode) {
                         case OP_js_1.default.OP_ADD:
-                            bn = bn1.add(bn2);
+                            resultBnArithmetic = bn1.add(bn2);
                             break;
                         case OP_js_1.default.OP_SUB:
-                            bn = bn1.sub(bn2);
+                            resultBnArithmetic = bn1.sub(bn2);
                             break;
                         case OP_js_1.default.OP_MUL:
-                            bn = bn1.mul(bn2);
+                            resultBnArithmetic = bn1.mul(bn2);
                             break;
                         case OP_js_1.default.OP_DIV:
-                            if (bn2.cmpn(0) === 0) {
+                            if (bn2.cmpn(0) === 0)
                                 this.scriptEvaluationError('OP_DIV cannot divide by zero!');
-                            }
-                            bn = bn1.div(bn2);
+                            resultBnArithmetic = bn1.div(bn2);
                             break;
                         case OP_js_1.default.OP_MOD:
-                            if (bn2.cmpn(0) === 0) {
+                            if (bn2.cmpn(0) === 0)
                                 this.scriptEvaluationError('OP_MOD cannot divide by zero!');
-                            }
-                            bn = bn1.mod(bn2);
+                            resultBnArithmetic = bn1.mod(bn2);
                             break;
                         case OP_js_1.default.OP_BOOLAND:
-                            bn = new BigNumber_js_1.default(bn1.cmpn(0) !== 0 && bn2.cmpn(0) !== 0 ? 1 : 0 + 0);
+                            resultBnArithmetic = new BigNumber_js_1.default((bn1.cmpn(0) !== 0 && bn2.cmpn(0) !== 0) ? 1 : 0);
                             break;
                         case OP_js_1.default.OP_BOOLOR:
-                            bn = new BigNumber_js_1.default(bn1.cmpn(0) !== 0 || bn2.cmpn(0) !== 0 ? 1 : 0 + 0);
+                            resultBnArithmetic = new BigNumber_js_1.default((bn1.cmpn(0) !== 0 || bn2.cmpn(0) !== 0) ? 1 : 0);
                             break;
                         case OP_js_1.default.OP_NUMEQUAL:
-                            bn = new BigNumber_js_1.default(bn1.cmp(bn2) === 0 ? 1 : 0 + 0);
+                            resultBnArithmetic = new BigNumber_js_1.default(bn1.cmp(bn2) === 0 ? 1 : 0);
                             break;
                         case OP_js_1.default.OP_NUMEQUALVERIFY:
-                            bn = new BigNumber_js_1.default(bn1.cmp(bn2) === 0 ? 1 : 0 + 0);
+                            resultBnArithmetic = new BigNumber_js_1.default(bn1.cmp(bn2) === 0 ? 1 : 0);
                             break;
                         case OP_js_1.default.OP_NUMNOTEQUAL:
-                            bn = new BigNumber_js_1.default(bn1.cmp(bn2) !== 0 ? 1 : 0 + 0);
+                            resultBnArithmetic = new BigNumber_js_1.default(bn1.cmp(bn2) !== 0 ? 1 : 0);
                             break;
                         case OP_js_1.default.OP_LESSTHAN:
-                            bn = new BigNumber_js_1.default(bn1.cmp(bn2) < 0 ? 1 : 0 + 0);
+                            resultBnArithmetic = new BigNumber_js_1.default(bn1.cmp(bn2) < 0 ? 1 : 0);
                             break;
                         case OP_js_1.default.OP_GREATERTHAN:
-                            bn = new BigNumber_js_1.default(bn1.cmp(bn2) > 0 ? 1 : 0 + 0);
+                            resultBnArithmetic = new BigNumber_js_1.default(bn1.cmp(bn2) > 0 ? 1 : 0);
                             break;
                         case OP_js_1.default.OP_LESSTHANOREQUAL:
-                            bn = new BigNumber_js_1.default(bn1.cmp(bn2) <= 0 ? 1 : 0 + 0);
+                            resultBnArithmetic = new BigNumber_js_1.default(bn1.cmp(bn2) <= 0 ? 1 : 0);
                             break;
                         case OP_js_1.default.OP_GREATERTHANOREQUAL:
-                            bn = new BigNumber_js_1.default(bn1.cmp(bn2) >= 0 ? 1 : 0 + 0);
+                            resultBnArithmetic = new BigNumber_js_1.default(bn1.cmp(bn2) >= 0 ? 1 : 0);
                             break;
                         case OP_js_1.default.OP_MIN:
-                            bn = bn1.cmp(bn2) < 0 ? bn1 : bn2;
+                            resultBnArithmetic = bn1.cmp(bn2) < 0 ? bn1 : bn2;
                             break;
                         case OP_js_1.default.OP_MAX:
-                            bn = bn1.cmp(bn2) > 0 ? bn1 : bn2;
+                            resultBnArithmetic = bn1.cmp(bn2) > 0 ? bn1 : bn2;
                             break;
                     }
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    this.stack.push(bn.toScriptNum());
-                    this.stackMem += bn.toScriptNum().length;
+                    this.pushStack(resultBnArithmetic.toScriptNum());
                     if (currentOpcode === OP_js_1.default.OP_NUMEQUALVERIFY) {
-                        if (this.castToBool(this.stacktop(-1))) {
-                            poppedValue = this.stack.pop();
-                            if (poppedValue != null) {
-                                this.stackMem -= poppedValue.length;
-                            }
-                            clearPoppedValue();
-                        }
-                        else {
+                        if (!this.castToBool(this.stackTop()))
                             this.scriptEvaluationError('OP_NUMEQUALVERIFY requires the top stack item to be truthy.');
-                        }
+                        this.popStack();
                     }
                     break;
+                }
                 case OP_js_1.default.OP_WITHIN:
-                    if (this.stack.length < 3) {
+                    if (this.stack.length < 3)
                         this.scriptEvaluationError('OP_WITHIN requires at least three items to be on the stack.');
-                    }
-                    bn1 = BigNumber_js_1.default.fromScriptNum(this.stacktop(-3), requireMinimalPush);
-                    bn2 = BigNumber_js_1.default.fromScriptNum(this.stacktop(-2), requireMinimalPush);
-                    bn3 = BigNumber_js_1.default.fromScriptNum(this.stacktop(-1), requireMinimalPush);
-                    fValue = bn2.cmp(bn1) <= 0 && bn1.cmp(bn3) < 0;
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    this.stack.push(fValue ? [1] : []);
-                    this.stackMem += (fValue ? 1 : 0);
+                    bn3 = BigNumber_js_1.default.fromScriptNum(this.popStack(), requireMinimalPush); // max
+                    bn2 = BigNumber_js_1.default.fromScriptNum(this.popStack(), requireMinimalPush); // min
+                    bn1 = BigNumber_js_1.default.fromScriptNum(this.popStack(), requireMinimalPush); // x
+                    fValue = bn1.cmp(bn2) >= 0 && bn1.cmp(bn3) < 0;
+                    this.pushStack(fValue ? [1] : []);
                     break;
                 case OP_js_1.default.OP_RIPEMD160:
                 case OP_js_1.default.OP_SHA1:
                 case OP_js_1.default.OP_SHA256:
                 case OP_js_1.default.OP_HASH160:
                 case OP_js_1.default.OP_HASH256: {
-                    if (this.stack.length < 1) {
+                    if (this.stack.length < 1)
                         this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires at least one item to be on the stack.`);
-                    }
-                    let bufHash = []; // Initialize bufHash to an empty array
-                    buf = this.stacktop(-1);
-                    if (currentOpcode === OP_js_1.default.OP_RIPEMD160) {
-                        bufHash = Hash.ripemd160(buf);
-                    }
-                    else if (currentOpcode === OP_js_1.default.OP_SHA1) {
-                        bufHash = Hash.sha1(buf);
-                    }
-                    else if (currentOpcode === OP_js_1.default.OP_SHA256) {
-                        bufHash = Hash.sha256(buf);
-                    }
-                    else if (currentOpcode === OP_js_1.default.OP_HASH160) {
-                        bufHash = Hash.hash160(buf);
-                    }
-                    else if (currentOpcode === OP_js_1.default.OP_HASH256) {
-                        bufHash = Hash.hash256(buf);
-                    }
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    this.stack.push(bufHash);
-                    this.stackMem += bufHash.length;
+                    buf = this.popStack();
+                    let hashResult = []; // Initialize to empty, to satisfy TS compiler
+                    if (currentOpcode === OP_js_1.default.OP_RIPEMD160)
+                        hashResult = Hash.ripemd160(buf);
+                    else if (currentOpcode === OP_js_1.default.OP_SHA1)
+                        hashResult = Hash.sha1(buf);
+                    else if (currentOpcode === OP_js_1.default.OP_SHA256)
+                        hashResult = Hash.sha256(buf);
+                    else if (currentOpcode === OP_js_1.default.OP_HASH160)
+                        hashResult = Hash.hash160(buf);
+                    else if (currentOpcode === OP_js_1.default.OP_HASH256)
+                        hashResult = Hash.hash256(buf);
+                    this.pushStack(hashResult);
                     break;
                 }
                 case OP_js_1.default.OP_CODESEPARATOR:
                     this.lastCodeSeparator = this.programCounter;
                     break;
                 case OP_js_1.default.OP_CHECKSIG:
-                case OP_js_1.default.OP_CHECKSIGVERIFY:
-                    if (this.stack.length < 2) {
+                case OP_js_1.default.OP_CHECKSIGVERIFY: {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires at least two items to be on the stack.`);
-                    }
-                    bufSig = this.stacktop(-2);
-                    bufPubkey = this.stacktop(-1);
-                    if (!checkSignatureEncoding(bufSig) ||
-                        !checkPublicKeyEncoding(bufPubkey)) {
-                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires correct encoding for the public key and signature.`);
-                    }
-                    // Subset of script starting at the most recent codeseparator
-                    // CScript scriptCode(pbegincodehash, pend);
-                    if (this.context === 'UnlockingScript') {
-                        subscript = new Script_js_1.default(this.unlockingScript.chunks.slice((_a = this.lastCodeSeparator) !== null && _a !== void 0 ? _a : 0));
-                    }
-                    else {
-                        subscript = new Script_js_1.default(this.lockingScript.chunks.slice((_b = this.lastCodeSeparator) !== null && _b !== void 0 ? _b : 0));
-                    }
-                    // Drop the signature, since there's no way for a signature to sign itself
+                    bufPubkey = this.popStack();
+                    bufSig = this.popStack();
+                    if (!this.checkSignatureEncoding(bufSig) || !this.checkPublicKeyEncoding(bufPubkey)) {
+                        // Error already thrown by helpers
+                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires correct encoding for the public key and signature.`); // Fallback, should be unreachable
+                    }
+                    const scriptForChecksig = this.context === 'UnlockingScript' ? this.unlockingScript : this.lockingScript;
+                    const scriptCodeChunks = scriptForChecksig.chunks.slice(this.lastCodeSeparator === null ? 0 : this.lastCodeSeparator + 1);
+                    subscript = new Script_js_1.default(scriptCodeChunks);
                     subscript.findAndDelete(new Script_js_1.default().writeBin(bufSig));
-                    try {
-                        sig = TransactionSignature_js_1.default.fromChecksigFormat(bufSig);
-                        pubkey = PublicKey_js_1.default.fromDER(bufPubkey);
-                        fSuccess = verifySignature(sig, pubkey, subscript);
-                    }
-                    catch (e) {
-                        // invalid sig or pubkey
-                        fSuccess = false;
-                    }
-                    if (!fSuccess && bufSig.length > 0) {
-                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} failed to verify the signature, and requires an empty signature when verification fails.`);
-                    }
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
+                    fSuccess = false;
+                    if (bufSig.length > 0) {
+                        try {
+                            sig = TransactionSignature_js_1.default.fromChecksigFormat(bufSig);
+                            pubkey = PublicKey_js_1.default.fromDER(bufPubkey);
+                            fSuccess = this.verifySignature(sig, pubkey, subscript);
+                        }
+                        catch (e) {
+                            fSuccess = false;
+                        }
                     }
-                    clearPoppedValue();
-                    // stack.push_back(fSuccess ? vchTrue : vchFalse);
-                    this.stack.push(fSuccess ? [1] : []);
-                    this.stackMem += (fSuccess ? 1 : 0);
+                    this.pushStack(fSuccess ? [1] : []);
                     if (currentOpcode === OP_js_1.default.OP_CHECKSIGVERIFY) {
-                        if (fSuccess) {
-                            poppedValue = this.stack.pop();
-                            if (poppedValue != null) {
-                                this.stackMem -= poppedValue.length;
-                            }
-                            clearPoppedValue();
-                        }
-                        else {
+                        if (!fSuccess)
                             this.scriptEvaluationError('OP_CHECKSIGVERIFY requires that a valid signature is provided.');
-                        }
+                        this.popStack();
                     }
                     break;
+                }
                 case OP_js_1.default.OP_CHECKMULTISIG:
-                case OP_js_1.default.OP_CHECKMULTISIGVERIFY:
+                case OP_js_1.default.OP_CHECKMULTISIGVERIFY: {
                     i = 1;
                     if (this.stack.length < i) {
-                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires at least 1 item to be on the stack.`);
+                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires at least 1 item for nKeys.`);
                     }
-                    nKeysCount = BigNumber_js_1.default.fromScriptNum(this.stacktop(-i), requireMinimalPush).toNumber();
-                    // TODO: Keys and opcount are parameterized in client. No magic numbers!
+                    nKeysCount = BigNumber_js_1.default.fromScriptNum(this.stackTop(-i), requireMinimalPush).toNumber();
                     if (nKeysCount < 0 || nKeysCount > maxMultisigKeyCount) {
                         this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires a key count between 0 and ${maxMultisigKeyCount}.`);
                     }
                     ikey = ++i;
                     i += nKeysCount;
-                    // ikey2 is the position of last non-signature item in
-                    // the stack. Top stack item = 1. With
-                    // SCRIPT_VERIFY_NULLFAIL, this is used for cleanup if
-                    // operation fails.
-                    ikey2 = nKeysCount + 2;
                     if (this.stack.length < i) {
-                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires the number of stack items not to be less than the number of keys used.`);
+                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} stack too small for nKeys and keys. Need ${i}, have ${this.stack.length}.`);
                     }
-                    nSigsCount = BigNumber_js_1.default.fromScriptNum(this.stacktop(-i), requireMinimalPush).toNumber();
+                    nSigsCount = BigNumber_js_1.default.fromScriptNum(this.stackTop(-i), requireMinimalPush).toNumber();
                     if (nSigsCount < 0 || nSigsCount > nKeysCount) {
                         this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires the number of signatures to be no greater than the number of keys.`);
                     }
                     isig = ++i;
                     i += nSigsCount;
                     if (this.stack.length < i) {
-                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires the number of stack items not to be less than the number of signatures provided.`);
+                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} stack too small for N, keys, M, sigs, and dummy. Need ${i}, have ${this.stack.length}.`);
                     }
-                    // Subset of script starting at the most recent codeseparator
-                    if (this.context === 'UnlockingScript') {
-                        subscript = new Script_js_1.default(this.unlockingScript.chunks.slice((_c = this.lastCodeSeparator) !== null && _c !== void 0 ? _c : 0));
-                    }
-                    else {
-                        subscript = new Script_js_1.default(this.lockingScript.chunks.slice((_d = this.lastCodeSeparator) !== null && _d !== void 0 ? _d : 0));
-                    }
-                    // Drop the signatures, since there's no way for a signature to sign itself
+                    const baseScriptCMS = this.context === 'UnlockingScript' ? this.unlockingScript : this.lockingScript;
+                    const subscriptChunksCMS = baseScriptCMS.chunks.slice(this.lastCodeSeparator === null ? 0 : this.lastCodeSeparator + 1);
+                    subscript = new Script_js_1.default(subscriptChunksCMS);
                     for (let k = 0; k < nSigsCount; k++) {
-                        bufSig = this.stacktop(-isig - k);
+                        bufSig = this.stackTop(-isig - k); // Sigs are closer to top than keys
                         subscript.findAndDelete(new Script_js_1.default().writeBin(bufSig));
                     }
                     fSuccess = true;
                     while (fSuccess && nSigsCount > 0) {
-                        // valtype& vchSig  = this.stacktop(-isig);
-                        bufSig = this.stacktop(-isig);
-                        // valtype& vchPubKey = this.stacktop(-ikey);
-                        bufPubkey = this.stacktop(-ikey);
-                        if (!checkSignatureEncoding(bufSig) ||
-                            !checkPublicKeyEncoding(bufPubkey)) {
-                            this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires correct encoding for the public key and signature.`);
+                        if (nKeysCount === 0) { // No more keys to check against but still sigs left
+                            fSuccess = false;
+                            break;
                         }
-                        try {
-                            sig = TransactionSignature_js_1.default.fromChecksigFormat(bufSig);
-                            pubkey = PublicKey_js_1.default.fromString((0, utils_js_1.toHex)(bufPubkey));
-                            fOk = verifySignature(sig, pubkey, subscript);
+                        bufSig = this.stackTop(-isig);
+                        bufPubkey = this.stackTop(-ikey);
+                        if (!this.checkSignatureEncoding(bufSig) || !this.checkPublicKeyEncoding(bufPubkey)) {
+                            this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires correct encoding for the public key and signature.`);
                         }
-                        catch (e) {
-                            // invalid sig or pubkey
-                            fOk = false;
+                        fOk = false;
+                        if (bufSig.length > 0) {
+                            try {
+                                sig = TransactionSignature_js_1.default.fromChecksigFormat(bufSig);
+                                pubkey = PublicKey_js_1.default.fromDER(bufPubkey);
+                                fOk = this.verifySignature(sig, pubkey, subscript);
+                            }
+                            catch (e) {
+                                fOk = false;
+                            }
                         }
                         if (fOk) {
                             isig++;
@@ -1203,163 +1013,109 @@ class Spend {
                         }
                         ikey++;
                         nKeysCount--;
-                        // If there are more signatures left than keys left,
-                        // then too many signatures have failed
                         if (nSigsCount > nKeysCount) {
                             fSuccess = false;
                         }
                     }
-                    // Clean up stack of actual arguments
-                    while (i-- > 1) {
-                        if (!fSuccess && ikey2 === 0 && this.stacktop(-1).length > 0) {
-                            this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} failed to verify a signature, and requires an empty signature when verification fails.`);
-                        }
-                        if (ikey2 > 0) {
-                            ikey2--;
-                        }
-                        poppedValue = this.stack.pop();
-                        if (poppedValue != null) {
-                            this.stackMem -= poppedValue.length;
-                        }
-                        clearPoppedValue();
-                    }
-                    // A bug causes CHECKMULTISIG to consume one extra argument
-                    // whose contents were not checked in any way.
-                    //
-                    // Unfortunately this is a potential source of mutability,
-                    // so optionally verify it is exactly equal to zero prior
-                    // to removing it from the stack.
+                    // Correct total items consumed by op (N_val, keys, M_val, sigs, dummy)
+                    const itemsConsumedByOp = 1 + // N_val
+                        BigNumber_js_1.default.fromScriptNum(this.stackTop(-1), false).toNumber() + // keys
+                        1 + // M_val
+                        BigNumber_js_1.default.fromScriptNum(this.stackTop(-(1 + BigNumber_js_1.default.fromScriptNum(this.stackTop(-1), false).toNumber() + 1)), false).toNumber() + // sigs
+                        1; // dummy
+                    let popCount = itemsConsumedByOp - 1; // Pop all except dummy
+                    while (popCount > 0) {
+                        this.popStack();
+                        popCount--;
+                    }
+                    // Check and pop dummy
                     if (this.stack.length < 1) {
-                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires an extra item to be on the stack.`);
+                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires an extra item (dummy) to be on the stack.`);
                     }
-                    if (this.stacktop(-1).length > 0) {
-                        // NOTE: Is this necessary? We don't care about malleability.
-                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires the extra stack item to be empty.`);
+                    const dummyBuf = this.popStack();
+                    if (dummyBuf.length > 0) { // SCRIPT_VERIFY_NULLDUMMY
+                        this.scriptEvaluationError(`${OP_js_1.default[currentOpcode]} requires the extra stack item (dummy) to be empty.`);
                     }
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    this.stack.push(fSuccess ? [1] : []);
-                    this.stackMem += (fSuccess ? 1 : 0);
+                    this.pushStack(fSuccess ? [1] : []);
                     if (currentOpcode === OP_js_1.default.OP_CHECKMULTISIGVERIFY) {
-                        if (fSuccess) {
-                            poppedValue = this.stack.pop();
-                            if (poppedValue != null) {
-                                this.stackMem -= poppedValue.length;
-                            }
-                            clearPoppedValue();
-                        }
-                        else {
+                        if (!fSuccess)
                             this.scriptEvaluationError('OP_CHECKMULTISIGVERIFY requires that a sufficient number of valid signatures are provided.');
-                        }
+                        this.popStack();
                     }
                     break;
-                case OP_js_1.default.OP_CAT:
-                    if (this.stack.length < 2) {
+                }
+                case OP_js_1.default.OP_CAT: {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError('OP_CAT requires at least two items to be on the stack.');
-                    }
-                    buf1 = this.stacktop(-2);
-                    buf2 = this.stacktop(-1);
-                    if (buf1.length + buf2.length > maxScriptElementSize) {
+                    buf2 = this.popStack();
+                    buf1 = this.popStack();
+                    const catResult = (buf1).concat(buf2);
+                    if (catResult.length > maxScriptElementSize)
                         this.scriptEvaluationError(`It's not currently possible to push data larger than ${maxScriptElementSize} bytes.`);
-                    }
-                    this.stack[this.stack.length - 2] = [...buf1, ...buf2];
-                    this.stackMem -= buf1.length;
-                    this.stackMem -= buf2.length;
-                    this.stackMem += buf1.length + buf2.length;
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
+                    this.pushStack(catResult);
                     break;
-                case OP_js_1.default.OP_SPLIT:
-                    if (this.stack.length < 2) {
+                }
+                case OP_js_1.default.OP_SPLIT: {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError('OP_SPLIT requires at least two items to be on the stack.');
-                    }
-                    buf1 = this.stacktop(-2);
-                    // Make sure the split point is apropriate.
-                    n = BigNumber_js_1.default.fromScriptNum(this.stacktop(-1), requireMinimalPush).toNumber();
-                    if (n < 0 || n > buf1.length) {
+                    const posBuf = this.popStack();
+                    const dataToSplit = this.popStack();
+                    n = BigNumber_js_1.default.fromScriptNum(posBuf, requireMinimalPush).toNumber();
+                    if (n < 0 || n > dataToSplit.length) {
                         this.scriptEvaluationError('OP_SPLIT requires the first stack item to be a non-negative number less than or equal to the size of the second-from-top stack item.');
                     }
-                    // Prepare the results in their own buffer as `data`
-                    // will be invalidated.
-                    // Copy buffer data, to slice it before
-                    buf2 = [...buf1];
-                    // Replace existing stack values by the new values.
-                    this.stack[this.stack.length - 2] = buf2.slice(0, n);
-                    this.stackMem -= buf1.length;
-                    this.stackMem += n;
-                    this.stack[this.stack.length - 1] = buf2.slice(n);
-                    this.stackMem += buf1.length - n;
+                    this.pushStack(dataToSplit.slice(0, n));
+                    this.pushStack(dataToSplit.slice(n));
                     break;
-                case OP_js_1.default.OP_NUM2BIN:
-                    if (this.stack.length < 2) {
+                }
+                case OP_js_1.default.OP_NUM2BIN: {
+                    if (this.stack.length < 2)
                         this.scriptEvaluationError('OP_NUM2BIN requires at least two items to be on the stack.');
+                    size = BigNumber_js_1.default.fromScriptNum(this.popStack(), requireMinimalPush).toNumber();
+                    if (size > maxScriptElementSize || size < 0) { // size can be 0
+                        this.scriptEvaluationError(`It's not currently possible to push data larger than ${maxScriptElementSize} bytes or negative size.`);
                     }
-                    size = BigNumber_js_1.default.fromScriptNum(this.stacktop(-1), requireMinimalPush).toNumber();
-                    if (size > maxScriptElementSize) {
-                        this.scriptEvaluationError(`It's not currently possible to push data larger than ${maxScriptElementSize} bytes.`);
-                    }
-                    poppedValue = this.stack.pop();
-                    if (poppedValue != null) {
-                        this.stackMem -= poppedValue.length;
-                    }
-                    clearPoppedValue();
-                    rawnum = this.stacktop(-1);
-                    // Try to see if we can fit that number in the number of
-                    // byte requested.
-                    rawnum = (0, utils_js_1.minimallyEncode)(rawnum);
+                    let rawnum = this.popStack(); // This is the number to convert
+                    rawnum = (0, utils_js_1.minimallyEncode)(rawnum); // Get its minimal scriptnum form
                     if (rawnum.length > size) {
                         this.scriptEvaluationError('OP_NUM2BIN requires that the size expressed in the top stack item is large enough to hold the value expressed in the second-from-top stack item.');
                     }
-                    // We already have an element of the right size, we
-                    // don't need to do anything.
                     if (rawnum.length === size) {
-                        this.stack[this.stack.length - 1] = rawnum;
+                        this.pushStack(rawnum);
                         break;
                     }
-                    signbit = 0x00;
+                    const resultN2B = new Array(size).fill(0x00);
+                    let signbit = 0x00;
                     if (rawnum.length > 0) {
-                        signbit = rawnum[rawnum.length - 1] & 0x80;
-                        rawnum[rawnum.length - 1] &= 0x7f;
+                        signbit = rawnum[rawnum.length - 1] & 0x80; // Store sign bit
+                        rawnum[rawnum.length - 1] &= 0x7f; // Remove sign bit for padding
                     }
-                    num = new Array(size);
-                    num.fill(0);
-                    for (n = 0; n < size; n++) {
-                        num[n] = rawnum[n];
+                    // Copy rawnum (now positive magnitude) into the result
+                    for (let k = 0; k < rawnum.length; k++) {
+                        resultN2B[k] = rawnum[k];
                     }
-                    n = rawnum.length - 1;
-                    while (n++ < size - 2) {
-                        num[n] = 0x00;
+                    // If the original number was negative, the sign bit must be set on the new MSB
+                    if (signbit !== 0) {
+                        resultN2B[size - 1] |= 0x80;
                     }
-                    num[n] = signbit;
-                    this.stack[this.stack.length - 1] = num;
-                    this.stackMem -= rawnum.length;
-                    this.stackMem += size;
+                    this.pushStack(resultN2B);
                     break;
-                case OP_js_1.default.OP_BIN2NUM:
-                    if (this.stack.length < 1) {
+                }
+                case OP_js_1.default.OP_BIN2NUM: {
+                    if (this.stack.length < 1)
                         this.scriptEvaluationError('OP_BIN2NUM requires at least one item to be on the stack.');
-                    }
-                    buf1 = this.stacktop(-1);
-                    buf2 = (0, utils_js_1.minimallyEncode)(buf1);
-                    this.stack[this.stack.length - 1] = buf2;
-                    this.stackMem -= buf1.length;
-                    this.stackMem += buf2.length;
-                    // The resulting number must be a valid number.
-                    if (!isMinimallyEncoded(buf2)) {
+                    buf1 = this.popStack();
+                    const b2nResult = (0, utils_js_1.minimallyEncode)(buf1);
+                    if (!isMinimallyEncodedHelper(b2nResult)) {
                         this.scriptEvaluationError('OP_BIN2NUM requires that the resulting number is valid.');
                     }
+                    this.pushStack(b2nResult);
                     break;
+                }
                 default:
-                    this.scriptEvaluationError('Invalid opcode!');
+                    this.scriptEvaluationError(`Invalid opcode ${currentOpcode} (pc=${this.programCounter}).`);
             }
         }
-        // Finally, increment the program counter
         this.programCounter++;
         return true;
     }
@@ -1385,35 +1141,39 @@ class Spend {
             }
         }
         if (this.ifStack.length > 0) {
-            this.scriptEvaluationError('Every OP_IF must be terminated prior to the end of the script.');
+            this.scriptEvaluationError('Every OP_IF, OP_NOTIF, or OP_ELSE must be terminated with OP_ENDIF prior to the end of the script.');
         }
         if (requireCleanStack) {
             if (this.stack.length !== 1) {
-                this.scriptEvaluationError('The clean stack rule requires exactly one item to be on the stack after script execution.');
+                this.scriptEvaluationError(`The clean stack rule requires exactly one item to be on the stack after script execution, found ${this.stack.length}.`);
             }
         }
-        if (!this.castToBool(this.stacktop(-1))) {
+        if (this.stack.length === 0) {
+            this.scriptEvaluationError('The top stack element must be truthy after script evaluation (stack is empty).');
+        }
+        else if (!this.castToBool(this.stackTop())) {
             this.scriptEvaluationError('The top stack element must be truthy after script evaluation.');
         }
         return true;
     }
-    stacktop(i) {
-        return this.stack[this.stack.length + i];
-    }
     castToBool(val) {
+        if (val.length === 0)
+            return false;
         for (let i = 0; i < val.length; i++) {
             if (val[i] !== 0) {
-                // can be negative zero
-                if (i === val.length - 1 && val[i] === 0x80) {
-                    return false;
-                }
-                return true;
+                return !(i === val.length - 1 && val[i] === 0x80);
             }
         }
         return false;
     }
     scriptEvaluationError(str) {
-        throw new Error(`Script evaluation error: ${str}\n\nSource TXID: ${this.sourceTXID}\nSource output index: ${this.sourceOutputIndex}\nContext: ${this.context}\nProgram counter: ${this.programCounter}\nStack size: ${this.stack.length}\nAlt stack size: ${this.altStack.length}`);
+        const pcInfo = `Context: ${this.context}, PC: ${this.programCounter}`;
+        const stackHex = this.stack.map(s => (s != null && typeof s.length !== 'undefined') ? (0, utils_js_1.toHex)(s) : (s === null || s === undefined ? 'null/undef' : 'INVALID_STACK_ITEM')).join(', ');
+        const altStackHex = this.altStack.map(s => (s != null && typeof s.length !== 'undefined') ? (0, utils_js_1.toHex)(s) : (s === null || s === undefined ? 'null/undef' : 'INVALID_STACK_ITEM')).join(', ');
+        const stackInfo = `Stack: [${stackHex}] (len: ${this.stack.length}, mem: ${this.stackMem})`;
+        const altStackInfo = `AltStack: [${altStackHex}] (len: ${this.altStack.length}, mem: ${this.altStackMem})`;
+        const ifStackInfo = `IfStack: [${this.ifStack.join(', ')}]`;
+        throw new Error(`Script evaluation error: ${str}\nTXID: ${this.sourceTXID}, OutputIdx: ${this.sourceOutputIndex}\n${pcInfo}\n${stackInfo}\n${altStackInfo}\n${ifStackInfo}`);
     }
 }
 exports.default = Spend;