@bsv/sdk 1.2.0 → 1.2.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bsv/sdk",
-  "version": "1.2.0",
+  "version": "1.2.2",
   "type": "module",
   "description": "BSV Blockchain Software Development Kit",
   "main": "dist/cjs/mod.js",
@@ -214,7 +214,7 @@
     "ts-jest": "^29.1.1",
     "ts-loader": "^9.5.1",
     "ts-standard": "^12.0.2",
-    "ts2md": "^0.2.0",
+    "ts2md": "^0.2.4",
     "tsconfig-to-dual-package": "^1.2.0",
     "typescript": "^5.2.2",
     "webpack": "^5.95.0",

package/src/overlay-tools/SHIPBroadcaster.ts

@@ -116,8 +116,8 @@ export default class SHIPCast implements Broadcaster {
     } = config ?? {} as SHIPBroadcasterConfig
     this.facilitator = facilitator ?? new HTTPSOverlayBroadcastFacilitator()
     this.resolver = resolver ?? new LookupResolver()
-    this.requireAcknowledgmentFromAllHostsForTopics = requireAcknowledgmentFromAllHostsForTopics ?? 'all'
-    this.requireAcknowledgmentFromAnyHostForTopics = requireAcknowledgmentFromAnyHostForTopics ?? []
+    this.requireAcknowledgmentFromAllHostsForTopics = requireAcknowledgmentFromAllHostsForTopics ?? []
+    this.requireAcknowledgmentFromAnyHostForTopics = requireAcknowledgmentFromAnyHostForTopics ?? 'all'
     this.requireAcknowledgmentFromSpecificHostsForTopics = requireAcknowledgmentFromSpecificHostsForTopics ?? {}
   }
 
@@ -178,6 +178,7 @@ export default class SHIPCast implements Broadcaster {
       for (const [topic, instructions] of Object.entries(steak)) {
         const outputsToAdmit = instructions.outputsToAdmit
         const coinsToRetain = instructions.coinsToRetain
+        // TODO: Account for coins removed property on STEAK
         if ((outputsToAdmit && outputsToAdmit.length > 0) || (coinsToRetain && coinsToRetain.length > 0)) {
           acknowledgedTopics.add(topic)
         }

package/src/overlay-tools/__tests/SHIPBroadcaster.test.ts

@@ -401,7 +401,7 @@ describe('SHIPCast', () => {
     expect(mockFacilitator.send).toHaveBeenCalledTimes(2)
   })
 
-  it('should fail when a host does not acknowledge all topics (default behavior)', async () => {
+  it('should fail if at least one host does not acknowledge every topic (default behavior)', async () => {
     const shipHostKey1 = new PrivateKey(42)
     const shipWallet1 = new ProtoWallet(shipHostKey1)
     const shipLib1 = new OverlayAdminTokenTemplate(shipWallet1)
@@ -434,7 +434,7 @@ describe('SHIPCast', () => {
       const steak = {}
       for (const topic of topics) {
         steak[topic] = {
-          outputsToAdmit: [0],
+          outputsToAdmit: [],
           coinsToRetain: []
         }
       }
@@ -462,8 +462,8 @@ describe('SHIPCast', () => {
 
     expect(response).toEqual({
       status: 'error',
-      code: 'ERR_REQUIRE_ACK_FROM_ALL_HOSTS_FAILED',
-      description: 'Not all hosts acknowledged the required topics.'
+      code: 'ERR_REQUIRE_ACK_FROM_ANY_HOST_FAILED',
+      description: 'No host acknowledged the required topics.'
     })
   })