@bsv/sdk 1.1.13 → 1.1.15

package/src/primitives/PrivateKey.ts

@@ -6,7 +6,58 @@ import Curve from './Curve.js'
 import { sign, verify } from './ECDSA.js'
 import { sha256, sha256hmac } from './Hash.js'
 import Random from './Random.js'
-import { fromBase58Check, toArray, toBase58Check } from './utils.js'
+import { fromBase58Check, toArray, toBase58, toBase58Check } from './utils.js'
+import Polynomial, { PointInFiniteField } from './Polynomial.js'
+
+/**
+ * @class KeyShares
+ *
+ * This class is used to store the shares of a private key.
+ *
+ * @param shares - An array of shares
+ * @param threshold - The number of shares required to recombine the private key
+ *
+ * @returns KeyShares
+ *
+ * @example
+ * const key = PrivateKey.fromShares(shares)
+ *
+ */
+
+export class KeyShares {
+  points: PointInFiniteField[]
+  threshold: number
+  integrity: string
+
+  constructor (points: PointInFiniteField[], threshold: number, integrity: string) {
+    this.points = points
+    this.threshold = threshold
+    this.integrity = integrity
+  }
+
+  static fromBackupFormat (shares: string[]): KeyShares {
+    let threshold = 0
+    let integrity = ''
+    const points = shares.map((share, idx) => {
+      const shareParts = share.split('.')
+      if (shareParts.length !== 4) throw Error('Invalid share format in share ' + idx + '. Expected format: "x.y.t.i" - received ' + share)
+      const [x, y, t, i] = shareParts
+      if (!t) throw Error('Threshold not found in share ' + idx)
+      if (!i) throw Error('Integrity not found in share ' + idx)
+      const tInt = parseInt(t)
+      if (idx !== 0 && threshold !== tInt) throw Error('Threshold mismatch in share ' + idx)
+      if (idx !== 0 && integrity !== i) throw Error('Integrity mismatch in share ' + idx)
+      threshold = tInt
+      integrity = i
+      return PointInFiniteField.fromString([x, y].join('.'))
+    })
+    return new KeyShares(points, threshold, integrity)
+  }
+
+  toBackupFormat () {
+    return this.points.map(share => share.toString() + '.' + this.threshold + '.' + this.integrity)
+  }
+}
 
 /**
  * Represents a Private Key, which is a secret that can be used to generate signatures in a cryptographic system.
@@ -256,4 +307,99 @@ export default class PrivateKey extends BigNumber {
     const curve = new Curve()
     return new PrivateKey(this.add(new BigNumber(hmac)).mod(curve.n).toArray())
   }
+
+  /**
+   * Splits the private key into shares using Shamir's Secret Sharing Scheme.
+   *
+   * @param threshold The minimum number of shares required to reconstruct the private key.
+   * @param totalShares The total number of shares to generate.
+   * @param prime The prime number to be used in Shamir's Secret Sharing Scheme.
+   * @returns An array of shares.
+   *
+   * @example
+   * const key = PrivateKey.fromRandom()
+   * const shares = key.toKeyShares(2, 5)
+   */
+  toKeyShares (threshold: number, totalShares: number): KeyShares {
+    if (typeof threshold !== 'number' || typeof totalShares !== 'number') throw new Error('threshold and totalShares must be numbers')
+    if (threshold < 2) throw new Error('threshold must be at least 2')
+    if (totalShares < 2) throw new Error('totalShares must be at least 2')
+    if (threshold > totalShares) throw new Error('threshold should be less than or equal to totalShares')
+
+    const poly = Polynomial.fromPrivateKey(this, threshold)
+
+    const points = []
+    for (let i = 0; i < totalShares; i++) {
+      const x = new BigNumber(PrivateKey.fromRandom().toArray())
+      const y = poly.valueAt(x)
+      points.push(new PointInFiniteField(x, y))
+    }
+
+    const integrity = (this.toPublicKey().toHash('hex') as string).slice(0, 8)
+
+    return new KeyShares(points, threshold, integrity)
+  }
+
+  /**
+   * @method toBackupShares
+   *
+   * Creates a backup of the private key by splitting it into shares.
+   *
+   *
+   * @param threshold The number of shares which will be required to reconstruct the private key.
+   * @param totalShares The number of shares to generate for distribution.
+   * @returns
+   */
+  toBackupShares (threshold: number, totalShares: number): string[] {
+    return this.toKeyShares(threshold, totalShares).toBackupFormat()
+  }
+
+  /**
+   *
+   * @method fromBackupShares
+   *
+   * Creates a private key from backup shares.
+   *
+   * @param shares
+   * @returns PrivateKey
+   */
+  static fromBackupShares (shares: string[]): PrivateKey {
+    return PrivateKey.fromKeyShares(KeyShares.fromBackupFormat(shares))
+  }
+
+  /**
+   * Combines shares to reconstruct the private key.
+   *
+   * @param shares An array of points (shares) to be used to reconstruct the private key.
+   * @param threshold The minimum number of shares required to reconstruct the private key.
+   *
+   * @returns The reconstructed private key.
+   *
+   * @example
+   * const share1 = '2NWeap6SDBTL5jVnvk9yUxyfLqNrDs2Bw85KNDfLJwRT.4yLtSm327NApsbuP7QXVW3CWDuBRgmS6rRiFkAkTukic'
+   * const share2 = '7NbgGA8iAsxg2s6mBLkLFtGKQrnc4aCbooHJJV31cWs4.GUgXtudthawE3Eevc1waT3Atr1Ft7j1XxdUguVo3B7x3'
+   * const reconstructedKey = PrivateKey.fromKeyShares({ shares: [share1, share2], threshold: 2, integrity: '23409547' })
+   *
+   **/
+  static fromKeyShares (keyShares: KeyShares): PrivateKey {
+    const { points, threshold, integrity } = keyShares
+    if (threshold < 2 || threshold > 99) throw new Error('threshold should be between 2 and 99')
+    if (points.length < threshold) throw new Error(`At least ${threshold} shares are required to reconstruct the private key`)
+    // check to see if two points have the same x value
+    for (let i = 0; i < threshold; i++) {
+      for (let j = i + 1; j < threshold; j++) {
+        if (points[i].x.eq(points[j].x)) {
+          throw new Error('Duplicate share detected, each must be unique.')
+        }
+      }
+    }
+    const poly = new Polynomial(points, threshold)
+    const privateKey = new PrivateKey(poly.valueAt(new BigNumber(0)).toArray())
+    const integrityHash = privateKey.toPublicKey().toHash('hex').slice(0, 8)
+    if (integrityHash !== integrity) {
+      throw new Error('Integrity hash mismatch')
+    }
+
+    return privateKey
+  }
 }

package/src/primitives/PublicKey.ts

@@ -51,6 +51,21 @@ export default class PublicKey extends Point {
     return new PublicKey(p.x, p.y)
   }
 
+  /**
+   * Static factory method to create a PublicKey instance from a number array.
+   *
+   * @param bytes - A number array representing a public key.
+   *
+   * @returns Returns the PublicKey created from the number array.
+   *
+   * @example
+   * const myPubKey = PublicKey.fromString("03....")
+   */
+  static fromDER (bytes: number[]): PublicKey {
+    const p = Point.fromDER(bytes)
+    return new PublicKey(p.x, p.y)
+  }
+
   /**
    * @constructor
    * @param x - A point or the x-coordinate of the point. May be a number, a BigNumber, a string (which will be interpreted as hex), a number array, or null. If null, an "Infinity" point is constructed.
@@ -121,8 +136,8 @@ export default class PublicKey extends Point {
    * @example
    * const derPublicKey = myPubKey.toDER()
    */
-  toDER (): string {
-    return this.encode(true, 'hex') as string
+  toDER (enc?: 'hex' | undefined): string {
+    return this.encode(true, enc) as string
   }
 
   /**

package/src/primitives/__tests/AESGCM.test.ts

@@ -61,7 +61,7 @@ describe('AESGCM', () => {
   it('should encrypt: Test Case 3', () => {
     const output = AESGCM(toArray('d9313225f88406e5a55909c5aff5269a86a7a9531534f7da2e4c303d8a318a721c3c0c95956' +
       '809532fcf0e2449a6b525b16aedf5aa0de657ba637b391aafd255', 'hex'), [], toArray('cafebabefacedbaddecaf888', 'hex'),
-      toArray('feffe9928665731c6d6a8f9467308308', 'hex'))
+    toArray('feffe9928665731c6d6a8f9467308308', 'hex'))
 
     expect(toArray('42831ec2217774244b7221b784d0d49ce3aa212f2c02a4e035c17e2329aca12e21d514b25466931c7d8' +
       'f6a5aac84aa051ba30b396a0aac973d58e091473f5985', 'hex')).toEqual(output.result)
@@ -71,7 +71,7 @@ describe('AESGCM', () => {
   it('should encrypt: Test Case 4', () => {
     const output = AESGCM(toArray('d9313225f88406e5a55909c5aff5269a86a7a9531534f7da2e4c303d8a318a721c3c0c95956' +
       '809532fcf0e2449a6b525b16aedf5aa0de657ba637b39', 'hex'), toArray('feedfacedeadbeeffeedfacedeadbeefabaddad2', 'hex'),
-      toArray('cafebabefacedbaddecaf888', 'hex'), toArray('feffe9928665731c6d6a8f9467308308', 'hex'))
+    toArray('cafebabefacedbaddecaf888', 'hex'), toArray('feffe9928665731c6d6a8f9467308308', 'hex'))
     expect(toArray('42831ec2217774244b7221b784d0d49ce3aa212f2c02a4e035c17e2329aca12e21d514b25466931c7d8' +
       'f6a5aac84aa051ba30b396a0aac973d58e091', 'hex')).toEqual(output.result)
     expect(toArray('5bc94fbc3221a5db94fae95ae7121a47', 'hex')).toEqual(output.authenticationTag)
@@ -80,7 +80,7 @@ describe('AESGCM', () => {
   it('should encrypt: Test Case 5', () => {
     const output = AESGCM(toArray('d9313225f88406e5a55909c5aff5269a86a7a9531534f7da2e4c303d8a318a721c3c0c95956' +
       '809532fcf0e2449a6b525b16aedf5aa0de657ba637b39', 'hex'), toArray('feedfacedeadbeeffeedfacedeadbeefabaddad2', 'hex'),
-      toArray('cafebabefacedbad', 'hex'), toArray('feffe9928665731c6d6a8f9467308308', 'hex'))
+    toArray('cafebabefacedbad', 'hex'), toArray('feffe9928665731c6d6a8f9467308308', 'hex'))
 
     expect(toArray('61353b4c2806934a777ff51fa22a4755699b2a714fcdc6f83766e5f97b6c742373806900e49f24b22b0' +
       '97544d4896b424989b5e1ebac0f07c23f4598', 'hex')).toEqual(output.result)
@@ -90,7 +90,7 @@ describe('AESGCM', () => {
   it('should encrypt: Test Case 6', () => {
     const output = AESGCM(toArray('d9313225f88406e5a55909c5aff5269a86a7a9531534f7da2e4c303d8a318a721c3c0c95956' +
       '809532fcf0e2449a6b525b16aedf5aa0de657ba637b39', 'hex'), toArray('feedfacedeadbeeffeedfacedeadbeefabaddad2', 'hex'),
-      toArray('9313225df88406e555909c5aff5269aa6a7a9538534f7da1e4c303d2a318a728c3c0c95156809539fcf0e2429a6b525416' +
+    toArray('9313225df88406e555909c5aff5269aa6a7a9538534f7da1e4c303d2a318a728c3c0c95156809539fcf0e2429a6b525416' +
         'aedbf5a0de6a57a637b39b', 'hex'), toArray('feffe9928665731c6d6a8f9467308308', 'hex'))
 
     expect(toArray('8ce24998625615b603a033aca13fb894be9112a5c3a211a8ba262a3cca7e2ca701e4a9a4fba43c90ccd' +
@@ -117,7 +117,7 @@ describe('AESGCM', () => {
   it('should encrypt: Test Case 9', () => {
     const output = AESGCM(toArray('d9313225f88406e5a55909c5aff5269a86a7a9531534f7da2e4c303d8a318a721c3c0c95956' +
       '809532fcf0e2449a6b525b16aedf5aa0de657ba637b391aafd255', 'hex'), [], toArray('cafebabefacedbaddecaf888', 'hex'),
-      toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c', 'hex'))
+    toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c', 'hex'))
 
     expect(toArray('3980ca0b3c00e841eb06fac4872a2757859e1ceaa6efd984628593b40ca1e19c7d773d00c144c525ac6' +
       '19d18c84a3f4718e2448b2fe324d9ccda2710acade256', 'hex')).toEqual(output.result)
@@ -127,7 +127,7 @@ describe('AESGCM', () => {
   it('should encrypt: Test Case 10', () => {
     const output = AESGCM(toArray('d9313225f88406e5a55909c5aff5269a86a7a9531534f7da2e4c303d8a318a721c3c0c95956' +
       '809532fcf0e2449a6b525b16aedf5aa0de657ba637b39', 'hex'), toArray('feedfacedeadbeeffeedfacedeadbeefabaddad2', 'hex'),
-      toArray('cafebabefacedbaddecaf888', 'hex'), toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c', 'hex'))
+    toArray('cafebabefacedbaddecaf888', 'hex'), toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c', 'hex'))
 
     expect(toArray('3980ca0b3c00e841eb06fac4872a2757859e1ceaa6efd984628593b40ca1e19c7d773d00c144c525ac6' +
       '19d18c84a3f4718e2448b2fe324d9ccda2710', 'hex')).toEqual(output.result)
@@ -137,7 +137,7 @@ describe('AESGCM', () => {
   it('should encrypt: Test Case 11', () => {
     const output = AESGCM(toArray('d9313225f88406e5a55909c5aff5269a86a7a9531534f7da2e4c303d8a318a721c3c0c95956' +
       '809532fcf0e2449a6b525b16aedf5aa0de657ba637b39', 'hex'), toArray('feedfacedeadbeeffeedfacedeadbeefabaddad2', 'hex'),
-      toArray('cafebabefacedbad', 'hex'), toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c', 'hex'))
+    toArray('cafebabefacedbad', 'hex'), toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c', 'hex'))
 
     expect(toArray('0f10f599ae14a154ed24b36e25324db8c566632ef2bbb34f8347280fc4507057fddc29df9a471f75c66' +
       '541d4d4dad1c9e93a19a58e8b473fa0f062f7', 'hex')).toEqual(output.result)
@@ -147,7 +147,7 @@ describe('AESGCM', () => {
   it('should encrypt: Test Case 12', () => {
     const output = AESGCM(toArray('d9313225f88406e5a55909c5aff5269a86a7a9531534f7da2e4c303d8a318a721c3c0c95956' +
       '809532fcf0e2449a6b525b16aedf5aa0de657ba637b39', 'hex'), toArray('feedfacedeadbeeffeedfacedeadbeefabaddad2', 'hex'),
-      toArray('9313225df88406e555909c5aff5269aa6a7a9538534f7da1e4c303d2a318a728c3c0c95156809539fcf0e2429a6b5254' +
+    toArray('9313225df88406e555909c5aff5269aa6a7a9538534f7da1e4c303d2a318a728c3c0c95156809539fcf0e2429a6b5254' +
         '16aedbf5a0de6a57a637b39b', 'hex'), toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c', 'hex'))
 
     expect(toArray('d27e88681ce3243c4830165a8fdcf9ff1de9a1d8e6b447ef6ef7b79828666e4581e79012af34ddd9e2f' +
@@ -175,8 +175,8 @@ describe('AESGCM', () => {
   it('should encrypt: Test Case 15', () => {
     const output = AESGCM(toArray('d9313225f88406e5a55909c5aff5269a86a7a9531534f7da2e4c303d8a318a721c3c0c95956' +
       '809532fcf0e2449a6b525b16aedf5aa0de657ba637b391aafd255', 'hex'), [],
-      toArray('cafebabefacedbaddecaf888', 'hex'),
-      toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c6d6a8f9467308308', 'hex'))
+    toArray('cafebabefacedbaddecaf888', 'hex'),
+    toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c6d6a8f9467308308', 'hex'))
 
     expect(toArray('522dc1f099567d07f47f37a32a84427d643a8cdcbfe5c0c97598a2bd2555d1aa8cb08e48590dbb3da7b' +
       '08b1056828838c5f61e6393ba7a0abcc9f662898015ad', 'hex')).toEqual(output.result)
@@ -186,8 +186,8 @@ describe('AESGCM', () => {
   it('should encrypt: Test Case 16', () => {
     const output = AESGCM(toArray('d9313225f88406e5a55909c5aff5269a86a7a9531534f7da2e4c303d8a318a721c3c0c95956' +
       '809532fcf0e2449a6b525b16aedf5aa0de657ba637b39', 'hex'), toArray('feedfacedeadbeeffeedfacedeadbeefabaddad2', 'hex'),
-      toArray('cafebabefacedbaddecaf888', 'hex'),
-      toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c6d6a8f9467308308', 'hex'))
+    toArray('cafebabefacedbaddecaf888', 'hex'),
+    toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c6d6a8f9467308308', 'hex'))
 
     expect(toArray('522dc1f099567d07f47f37a32a84427d643a8cdcbfe5c0c97598a2bd2555d1aa8cb08e48590dbb3da7b' +
       '08b1056828838c5f61e6393ba7a0abcc9f662', 'hex')).toEqual(output.result)
@@ -197,9 +197,9 @@ describe('AESGCM', () => {
   it('should encrypt: Test Case 17', () => {
     const output = AESGCM(toArray('d9313225f88406e5a55909c5aff5269a86a7a9531534f7da2e4c303d8a318a721c3c0c95956' +
       '809532fcf0e2449a6b525b16aedf5aa0de657ba637b39', 'hex'),
-      toArray('feedfacedeadbeeffeedfacedeadbeefabaddad2', 'hex'),
-      toArray('cafebabefacedbad', 'hex'),
-      toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c6d6a8f9467308308', 'hex'))
+    toArray('feedfacedeadbeeffeedfacedeadbeefabaddad2', 'hex'),
+    toArray('cafebabefacedbad', 'hex'),
+    toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c6d6a8f9467308308', 'hex'))
 
     expect(toArray('c3762df1ca787d32ae47c13bf19844cbaf1ae14d0b976afac52ff7d79bba9de0feb582d33934a4f0954' +
       'cc2363bc73f7862ac430e64abe499f47c9b1f', 'hex')).toEqual(output.result)
@@ -209,10 +209,10 @@ describe('AESGCM', () => {
   it('should encrypt: Test Case 18', () => {
     const output = AESGCM(toArray('d9313225f88406e5a55909c5aff5269a86a7a9531534f7da2e4c303d8a318a721c3c0c95956' +
       '809532fcf0e2449a6b525b16aedf5aa0de657ba637b39', 'hex'),
-      toArray('feedfacedeadbeeffeedfacedeadbeefabaddad2', 'hex'),
-      toArray('9313225df88406e555909c5aff5269aa6a7a9538534f7da1e4c303d2a318a728c3c0c95156809539fcf0e2429a6b525416' +
+    toArray('feedfacedeadbeeffeedfacedeadbeefabaddad2', 'hex'),
+    toArray('9313225df88406e555909c5aff5269aa6a7a9538534f7da1e4c303d2a318a728c3c0c95156809539fcf0e2429a6b525416' +
         'aedbf5a0de6a57a637b39b', 'hex'),
-      toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c6d6a8f9467308308', 'hex'))
+    toArray('feffe9928665731c6d6a8f9467308308feffe9928665731c6d6a8f9467308308', 'hex'))
 
     expect(toArray('5a8def2f0c9e53f1f75d7853659e2a20eeb2b22aafde6419a058ab4f6f746bf40fc0c3b780f244452da' +
       '3ebf1c5d82cdea2418997200ef82e44ae7e3f', 'hex')).toEqual(output.result)
@@ -248,8 +248,8 @@ describe('multiply', () => {
   it('should commutatively multiply', () => {
     expect(multiply(toArray('48692853686179295b477565726f6e5d', 'hex'),
       toArray('7b5b54657374566563746f725d53475d', 'hex'))).toEqual(
-        multiply(toArray('7b5b54657374566563746f725d53475d', 'hex'),
-          toArray('48692853686179295b477565726f6e5d', 'hex')))
+      multiply(toArray('7b5b54657374566563746f725d53475d', 'hex'),
+        toArray('48692853686179295b477565726f6e5d', 'hex')))
   })
 })
 

package/src/primitives/__tests/Hash.test.ts

@@ -5,7 +5,7 @@ import PBKDF2Vectors from './PBKDF2.vectors'
 import { toArray, toHex } from '../../../dist/cjs/src/primitives/utils'
 
 describe('Hash', function () {
-  function test(Hash, cases): void {
+  function test (Hash, cases): void {
     for (let i = 0; i < cases.length; i++) {
       const msg = cases[i][0]
       const res = cases[i][1]
@@ -92,7 +92,7 @@ describe('Hash', function () {
 
   describe('PBKDF2 vectors', () => {
     for (let i = 0; i < PBKDF2Vectors.length; i++) {
-      let v = PBKDF2Vectors[i]
+      const v = PBKDF2Vectors[i]
       let key, salt
       if (v.keyUint8Array) {
         key = v.keyUint8Array

package/src/primitives/__tests/PBKDF2.vectors.ts

@@ -1,119 +1,119 @@
 export default [{
-    "key": "password",
-    "salt": "salt",
-    "iterations": 1,
-    "dkLen": 32,
-    "results": {
-        "sha512": "867f70cf1ade02cff3752599a3a53dc4af34c7a669815ae5d513554e1c8cf252"
-    }
+  key: 'password',
+  salt: 'salt',
+  iterations: 1,
+  dkLen: 32,
+  results: {
+    sha512: '867f70cf1ade02cff3752599a3a53dc4af34c7a669815ae5d513554e1c8cf252'
+  }
 },
 {
-    "key": "password",
-    "salt": "salt",
-    "iterations": 2,
-    "dkLen": 32,
-    "results": {
-        "sha512": "e1d9c16aa681708a45f5c7c4e215ceb66e011a2e9f0040713f18aefdb866d53c"
-    }
+  key: 'password',
+  salt: 'salt',
+  iterations: 2,
+  dkLen: 32,
+  results: {
+    sha512: 'e1d9c16aa681708a45f5c7c4e215ceb66e011a2e9f0040713f18aefdb866d53c'
+  }
 },
 {
-    "key": "password",
-    "salt": "salt",
-    "iterations": 1,
-    "dkLen": 64,
-    "results": {
-        "sha512": "867f70cf1ade02cff3752599a3a53dc4af34c7a669815ae5d513554e1c8cf252c02d470a285a0501bad999bfe943c08f050235d7d68b1da55e63f73b60a57fce"
-    }
+  key: 'password',
+  salt: 'salt',
+  iterations: 1,
+  dkLen: 64,
+  results: {
+    sha512: '867f70cf1ade02cff3752599a3a53dc4af34c7a669815ae5d513554e1c8cf252c02d470a285a0501bad999bfe943c08f050235d7d68b1da55e63f73b60a57fce'
+  }
 },
 {
-    "key": "password",
-    "salt": "salt",
-    "iterations": 2,
-    "dkLen": 64,
-    "results": {
-        "sha512": "e1d9c16aa681708a45f5c7c4e215ceb66e011a2e9f0040713f18aefdb866d53cf76cab2868a39b9f7840edce4fef5a82be67335c77a6068e04112754f27ccf4e"
-    }
+  key: 'password',
+  salt: 'salt',
+  iterations: 2,
+  dkLen: 64,
+  results: {
+    sha512: 'e1d9c16aa681708a45f5c7c4e215ceb66e011a2e9f0040713f18aefdb866d53cf76cab2868a39b9f7840edce4fef5a82be67335c77a6068e04112754f27ccf4e'
+  }
 },
 {
-    "key": "password",
-    "salt": "salt",
-    "iterations": 4096,
-    "dkLen": 32,
-    "results": {
-        "sha512": "d197b1b33db0143e018b12f3d1d1479e6cdebdcc97c5c0f87f6902e072f457b5"
-    }
+  key: 'password',
+  salt: 'salt',
+  iterations: 4096,
+  dkLen: 32,
+  results: {
+    sha512: 'd197b1b33db0143e018b12f3d1d1479e6cdebdcc97c5c0f87f6902e072f457b5'
+  }
 },
 {
-    "key": "passwordPASSWORDpassword",
-    "salt": "saltSALTsaltSALTsaltSALTsaltSALTsalt",
-    "iterations": 4096,
-    "dkLen": 40,
-    "results": {
-        "sha512": "8c0511f4c6e597c6ac6315d8f0362e225f3c501495ba23b868c005174dc4ee71115b59f9e60cd953"
-    }
+  key: 'passwordPASSWORDpassword',
+  salt: 'saltSALTsaltSALTsaltSALTsaltSALTsalt',
+  iterations: 4096,
+  dkLen: 40,
+  results: {
+    sha512: '8c0511f4c6e597c6ac6315d8f0362e225f3c501495ba23b868c005174dc4ee71115b59f9e60cd953'
+  }
 },
 {
-    "key": "pass\u00000word",
-    "salt": "sa\u00000lt",
-    "iterations": 4096,
-    "dkLen": 16,
-    "results": {
-        "sha512": "336d14366099e8aac2c46c94a8f178d2"
-    }
+  key: 'pass\u00000word',
+  salt: 'sa\u00000lt',
+  iterations: 4096,
+  dkLen: 16,
+  results: {
+    sha512: '336d14366099e8aac2c46c94a8f178d2'
+  }
 },
 {
-    "keyHex": "63ffeeddccbbaa",
-    "salt": "salt",
-    "iterations": 1,
-    "dkLen": 32,
-    "results": {
-        "sha512": "f69de451247225a7b30cc47632899572bb980f500d7c606ac9b1c04f928a3488"
-    }
+  keyHex: '63ffeeddccbbaa',
+  salt: 'salt',
+  iterations: 1,
+  dkLen: 32,
+  results: {
+    sha512: 'f69de451247225a7b30cc47632899572bb980f500d7c606ac9b1c04f928a3488'
+  }
 },
 {
-    "description": "Unicode salt, no truncation due to hex",
-    "key": "abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about",
-    "saltHex": "6d6e656d6f6e6963e383a1e383bce38388e383abe382abe38299e3838fe38299e382a6e38299e382a1e381afe3829ae381afe38299e3818fe38299e3829de38299e381a1e381a1e38299e58d81e4babae58d81e889b2",
-    "iterations": 2048,
-    "dkLen": 64,
-    "results": {
-        "sha512": "ba553eedefe76e67e2602dc20184c564010859faada929a090dd2c57aacb204ceefd15404ab50ef3e8dbeae5195aeae64b0def4d2eead1cdc728a33ced520ffd"
-    }
+  description: 'Unicode salt, no truncation due to hex',
+  key: 'abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about',
+  saltHex: '6d6e656d6f6e6963e383a1e383bce38388e383abe382abe38299e3838fe38299e382a6e38299e382a1e381afe3829ae381afe38299e3818fe38299e3829de38299e381a1e381a1e38299e58d81e4babae58d81e889b2',
+  iterations: 2048,
+  dkLen: 64,
+  results: {
+    sha512: 'ba553eedefe76e67e2602dc20184c564010859faada929a090dd2c57aacb204ceefd15404ab50ef3e8dbeae5195aeae64b0def4d2eead1cdc728a33ced520ffd'
+  }
 },
 {
-    "key": "password",
-    "salt": "salt",
-    "iterations": 1,
-    "dkLen": 10,
-    "results": {
-        "sha512": "867f70cf1ade02cff375"
-    }
+  key: 'password',
+  salt: 'salt',
+  iterations: 1,
+  dkLen: 10,
+  results: {
+    sha512: '867f70cf1ade02cff375'
+  }
 },
 {
-    "key": "password",
-    "salt": "salt",
-    "iterations": 1,
-    "dkLen": 100,
-    "results": {
-        "sha512": "867f70cf1ade02cff3752599a3a53dc4af34c7a669815ae5d513554e1c8cf252c02d470a285a0501bad999bfe943c08f050235d7d68b1da55e63f73b60a57fce7b532e206c2967d4c7d2ffa460539fc4d4e5eec70125d74c6c7cf86d25284f297907fcea"
-    }
+  key: 'password',
+  salt: 'salt',
+  iterations: 1,
+  dkLen: 100,
+  results: {
+    sha512: '867f70cf1ade02cff3752599a3a53dc4af34c7a669815ae5d513554e1c8cf252c02d470a285a0501bad999bfe943c08f050235d7d68b1da55e63f73b60a57fce7b532e206c2967d4c7d2ffa460539fc4d4e5eec70125d74c6c7cf86d25284f297907fcea'
+  }
 },
 {
-    "keyUint8Array": [112, 97, 115, 115, 119, 111, 114, 100],
-    "salt": "salt",
-    "iterations": 1,
-    "dkLen": 32,
-    "results": {
-        "sha512": "867f70cf1ade02cff3752599a3a53dc4af34c7a669815ae5d513554e1c8cf252"
-    }
+  keyUint8Array: [112, 97, 115, 115, 119, 111, 114, 100],
+  salt: 'salt',
+  iterations: 1,
+  dkLen: 32,
+  results: {
+    sha512: '867f70cf1ade02cff3752599a3a53dc4af34c7a669815ae5d513554e1c8cf252'
+  }
 },
 {
-    "key": "password",
-    "saltUint8Array": [115, 97, 108, 116],
-    "iterations": 1,
-    "dkLen": 32,
-    "results": {
-        "sha512": "867f70cf1ade02cff3752599a3a53dc4af34c7a669815ae5d513554e1c8cf252"
-    }
+  key: 'password',
+  saltUint8Array: [115, 97, 108, 116],
+  iterations: 1,
+  dkLen: 32,
+  results: {
+    sha512: '867f70cf1ade02cff3752599a3a53dc4af34c7a669815ae5d513554e1c8cf252'
+  }
 }
-]
+]

package/src/primitives/__tests/PrivateKey.split.test.ts

@@ -0,0 +1,70 @@
+import PrivateKey, { KeyShares } from '../../../dist/cjs/src/primitives/PrivateKey'
+import { PointInFiniteField } from '../../../dist/cjs/src/primitives/Polynomial'
+
+describe('PrivateKey', () => {
+  it('should split the private key into shares correctly', () => {
+    const privateKey = PrivateKey.fromRandom()
+    const threshold = 2
+    const totalShares = 5
+
+    // Split the private key
+    const shares = privateKey.toKeyShares(threshold, totalShares)
+    const backup = shares.toBackupFormat()
+
+    // Check the number of shares
+    expect(backup.length).toBe(totalShares)
+
+    // Check that each share is a BigNumber
+    shares.points.forEach(share => {
+      expect(share).toBeInstanceOf(PointInFiniteField)
+    })
+    expect(shares.threshold).toBe(threshold)
+  })
+
+  it('should recombine the shares into a private key correctly', () => {
+    let x = 0
+    while (x < 3) {
+      const key = PrivateKey.fromRandom()
+      const allShares = key.toKeyShares(3, 5)
+      const backup = allShares.toBackupFormat()
+      const someShares = KeyShares.fromBackupFormat(backup.slice(0,3))
+      const rebuiltKey = PrivateKey.fromKeyShares(someShares)
+      expect(rebuiltKey.toWif()).toBe(key.toWif())
+      x++
+    }
+  })
+
+  it('should throw an error for invalid threshold or totalShares', () => {
+    const k = PrivateKey.fromRandom()
+    expect(() => k.toKeyShares('12', 14)).toThrow('threshold and totalShares must be numbers')
+    expect(() => k.toKeyShares(4, '5')).toThrow('threshold and totalShares must be numbers')
+  })
+
+  it('should throw an error for invalid threshold', () => {
+    const k = PrivateKey.fromRandom()
+    expect(() => k.toKeyShares(1, 2)).toThrow('threshold must be at least 2')
+  })
+
+  it('should throw an error for invalid totalShares', () => {
+    const k = PrivateKey.fromRandom()
+    expect(() => k.toKeyShares(2, -4)).toThrow('totalShares must be at least 2')
+  })
+
+  it('should throw an error for totalShares being less than threshold', () => {
+    const k = PrivateKey.fromRandom()
+    expect(() => k.toKeyShares(3, 2)).toThrow('threshold should be less than or equal to totalShares')
+  })
+
+  it('should throw an error if the same share is included twice during recovery', () => {
+    const backup = [ '45s4vLL2hFvqmxrarvbRT2vZoQYGZGocsmaEksZ64o5M.A7nZrGux15nEsQGNZ1mbfnMKugNnS6SYYEQwfhfbDZG8.3.2f804d43', '7aPzkiGZgvU4Jira5PN9Qf9o7FEg6uwy1zcxd17NBhh3.CCt7NH1sPFgceb6phTRkfviim2WvmUycJCQd2BxauxP9.3.2f804d43', '9GaS2Tw5sXqqbuigdjwGPwPsQuEFqzqUXo5MAQhdK3es.8MLh2wyE3huyq6hiBXjSkJRucgyKh4jVY6ESq5jNtXRE.3.2f804d43', 'GBmoNRbsMVsLmEK5A6G28fktUNonZkn9mDrJJ58FXgsf.HDBRkzVUCtZ38ApEu36fvZtDoDSQTv3TWmbnxwwR7kto.3.2f804d43', '2gHebXBgPd7daZbsj6w9TPDta3vQzqvbkLtJG596rdN1.E7ZaHyyHNDCwR6qxZvKkPPWWXzFCiKQFentJtvSSH5Bi.3.2f804d43' ]
+    const recovery = KeyShares.fromBackupFormat([backup[0], backup[1], backup[1]])
+    expect(() => PrivateKey.fromKeyShares(recovery)).toThrow('Duplicate share detected, each must be unique.')
+  })
+
+  it('should be able to create a backup array from a private key, and recover the same key back from the backup', () => {
+    const key = PrivateKey.fromRandom()
+    const backup = key.toBackupShares(3, 5)
+    const recoveredKey = PrivateKey.fromBackupShares(backup.slice(0, 3))
+    expect(recoveredKey.toWif()).toBe(key.toWif())
+  })
+})

package/src/primitives/__tests/PublicKey.test.ts

@@ -47,10 +47,23 @@ describe('PublicKey', () => {
     })
 
     test('toDER should return DER encoded string of public key', () => {
-      const derString = publicKey.toDER()
+      const derString = publicKey.toString()
       expect(typeof derString).toBe('string')
       expect(derString.length).toBe(66)
     })
+
+    test('toDER should return DER encoded number[] of public key', () => {
+      const der = publicKey.toDER()
+      expect(typeof der).toBe('object')
+      expect(der.length).toBe(33)
+    })
+
+    test('fromDER and fromString should result in the same public key', () => {
+      const key = PrivateKey.fromRandom()
+      const original = key.toPublicKey()
+      const backAndForth = PublicKey.fromString(PublicKey.fromDER(original.toDER()).toString())
+      expect(backAndForth.toString()).toEqual(original.toString())
+    })
   })
   describe('BRC42 vectors', () => {
     for (let i = 0; i < BRC42Public.length; i++) {