@bsv/sdk 1.0.39 → 1.1.1

package/src/compat/Utxo.ts

@@ -0,0 +1,55 @@
+import Transaction from '../transaction/Transaction.js'
+import TransactionInput from '../transaction/TransactionInput.js'
+import LockingScript from '../script/LockingScript.js'
+import UnlockingScript from '../script/UnlockingScript.js'
+
+type jsonUtxo = {
+    txid: string
+    vout: number
+    satoshis: number
+    script: string
+}
+/**
+ * @method fromUtxo
+ * 
+ * @description
+ * This function creates a transaction input from a utxo json object
+ * The idea being old code that uses utxos rather than sourceTranactions can convert using this.
+ * 
+ * @deprecated
+ * This approach is made available for compatibility only. It is deprecated in favor of using sourceTransactions 
+ * directly. It's recommended that wallets general keep transactions which store unspent outputs in their entirety, 
+ * along with corresonding Merkle paths. The reason you would keep the whole transaction is such that you can prove 
+ * the txid, and therefore its inclusion within a specific block.
+ * 
+ * @example
+ * const i = fromUtxo({
+ *   txid: '434555433eaca96dff6e71a4d02febd0dd3832e5ca4e5734623ca914522e17d5',
+ *   vout: 0,
+ *   script: '51',
+ *   satoshis: 1234
+ * }, new P2PKH().unlock(p))
+ * 
+ * tx.addInput(i)
+ * 
+ * @param utxo: jsonUtxo
+ * @param unlockingScriptTemplate: { sign: (tx: Transaction, inputIndex: number) => Promise<UnlockingScript>, estimateLength: (tx: Transaction, inputIndex: number) => Promise<number> }
+ * @returns 
+ */
+export default function fromUtxo(utxo: jsonUtxo, unlockingScriptTemplate: {
+    sign: (tx: Transaction, inputIndex: number) => Promise<UnlockingScript>
+    estimateLength: (tx: Transaction, inputIndex: number) => Promise<number>
+  }): TransactionInput {
+    const sourceTransaction = new Transaction(0, [], [], 0)
+    sourceTransaction.outputs = Array(utxo.vout + 1).fill(null)
+    sourceTransaction.outputs[utxo.vout] = {
+        satoshis: utxo.satoshis,
+        lockingScript: LockingScript.fromHex(utxo.script)
+    }
+    return {
+        sourceTransaction,
+        sourceOutputIndex: utxo.vout,
+        unlockingScriptTemplate,
+        sequence: 0xFFFFFFFF
+    }
+}

package/src/compat/index.ts

@@ -2,3 +2,4 @@ export * as BSM from './BSM.js'
 export { default as HD } from './HD.js'
 export { default as Mnemonic } from './Mnemonic.js'
 export { default as ECIES } from './ECIES.js'
+export { default as fromUtxo } from './Utxo.js'

package/src/script/templates/P2PKH.ts

@@ -91,7 +91,6 @@ export default class P2PKH implements ScriptTemplate {
           )
         }
         sourceSatoshis ||= input.sourceTransaction?.outputs[input.sourceOutputIndex].satoshis
-        sourceSatoshis ||= input.sourceSatoshis
         if (!sourceSatoshis) {
           throw new Error(
             'The sourceSatoshis or input sourceTransaction is required for transaction signing.'

package/src/transaction/Transaction.ts

@@ -62,7 +62,7 @@ export default class Transaction {
    * @param beef A binary representation of a transaction in BEEF format.
    * @returns An anchored transaction, linked to its associated inputs populated with merkle paths.
    */
-  static fromBEEF (beef: number[]): Transaction {
+  static fromBEEF(beef: number[]): Transaction {
     const reader = new Reader(beef)
     // Read the version
     const version = reader.readUInt32LE()
@@ -122,6 +122,59 @@ export default class Transaction {
     return transactions[lastTXID].tx
   }
 
+
+  /**
+   * Creates a new transaction, linked to its inputs and their associated merkle paths, from a EF (BRC-30) structure.
+   * @param ef A binary representation of a transaction in EF format.
+   * @returns An extended transaction, linked to its associated inputs by locking script and satoshis amounts only.
+   */
+  static fromEF(ef: number[]): Transaction {
+    const br = new Reader(ef)
+    const version = br.readUInt32LE()
+    if (toHex(br.read(6)) !== '0000000000ef') throw new Error('Invalid EF marker')
+    const inputsLength = br.readVarIntNum()
+    const inputs: TransactionInput[] = []
+    for (let i = 0; i < inputsLength; i++) {
+      const sourceTXID = toHex(br.readReverse(32))
+      const sourceOutputIndex = br.readUInt32LE()
+      const scriptLength = br.readVarIntNum()
+      const scriptBin = br.read(scriptLength)
+      const unlockingScript = UnlockingScript.fromBinary(scriptBin)
+      const sequence = br.readUInt32LE()
+      const satoshis = br.readUInt64LEBn().toNumber()
+      const lockingScriptLength = br.readVarIntNum()
+      const lockingScriptBin = br.read(lockingScriptLength)
+      const lockingScript = LockingScript.fromBinary(lockingScriptBin)
+      const sourceTransaction = new Transaction(null, [], [], null)
+      sourceTransaction.outputs = Array(sourceOutputIndex + 1).fill(null)
+      sourceTransaction.outputs[sourceOutputIndex] = {
+        satoshis,
+        lockingScript
+      }
+      inputs.push({
+        sourceTransaction,
+        sourceTXID,
+        sourceOutputIndex,
+        unlockingScript,
+        sequence
+      })
+    }
+    const outputsLength = br.readVarIntNum()
+    const outputs: TransactionOutput[] = []
+    for (let i = 0; i < outputsLength; i++) {
+      const satoshis = br.readUInt64LEBn().toNumber()
+      const scriptLength = br.readVarIntNum()
+      const scriptBin = br.read(scriptLength)
+      const lockingScript = LockingScript.fromBinary(scriptBin)
+      outputs.push({
+        satoshis,
+        lockingScript
+      })
+    }
+    const lockTime = br.readUInt32LE()
+    return new Transaction(version, inputs, outputs, lockTime)
+  }
+
   /**
    * Since the validation of blockchain data is atomically transaction data validation,
    * any application seeking to validate data in output scripts must store the entire transaction as well.
@@ -137,7 +190,7 @@ export default class Transaction {
    *   outputs: { vout: number, offset: number, length: number }[]
    * }
    */
-  static parseScriptOffsets (bin: number[]): {
+  static parseScriptOffsets(bin: number[]): {
     inputs: Array<{ vin: number, offset: number, length: number }>
     outputs: Array<{ vout: number, offset: number, length: number }>
   } {
@@ -163,7 +216,7 @@ export default class Transaction {
     return { inputs, outputs }
   }
 
-  private static fromReader (br: Reader): Transaction {
+  private static fromReader(br: Reader): Transaction {
     const version = br.readUInt32LE()
     const inputsLength = br.readVarIntNum()
     const inputs: TransactionInput[] = []
@@ -204,7 +257,7 @@ export default class Transaction {
    * @param {number[]} bin - The binary array representation of the transaction.
    * @returns {Transaction} - A new Transaction instance.
    */
-  static fromBinary (bin: number[]): Transaction {
+  static fromBinary(bin: number[]): Transaction {
     const br = new Reader(bin)
     return Transaction.fromReader(br)
   }
@@ -216,10 +269,21 @@ export default class Transaction {
    * @param {string} hex - The hexadecimal string representation of the transaction.
    * @returns {Transaction} - A new Transaction instance.
    */
-  static fromHex (hex: string): Transaction {
+  static fromHex(hex: string): Transaction {
     return Transaction.fromBinary(toArray(hex, 'hex'))
   }
 
+  /**
+   * Creates a Transaction instance from a hexadecimal string encoded EF.
+   *
+   * @static
+   * @param {string} hex - The hexadecimal string representation of the transaction EF.
+   * @returns {Transaction} - A new Transaction instance.
+   */
+  static fromHexEF(hex: string): Transaction {
+    return Transaction.fromEF(toArray(hex, 'hex'))
+  }
+
   /**
    * Creates a Transaction instance from a hexadecimal string encoded BEEF.
    *
@@ -227,11 +291,11 @@ export default class Transaction {
    * @param {string} hex - The hexadecimal string representation of the transaction BEEF.
    * @returns {Transaction} - A new Transaction instance.
    */
-  static fromHexBEEF (hex: string): Transaction {
+  static fromHexBEEF(hex: string): Transaction {
     return Transaction.fromBEEF(toArray(hex, 'hex'))
   }
 
-  constructor (
+  constructor(
     version: number = 1,
     inputs: TransactionInput[] = [],
     outputs: TransactionOutput[] = [],
@@ -253,7 +317,7 @@ export default class Transaction {
    * @param {TransactionInput} input - The TransactionInput object to add to the transaction.
    * @throws {Error} - If the input does not have a sourceTXID or sourceTransaction defined.
    */
-  addInput (input: TransactionInput): void {
+  addInput(input: TransactionInput): void {
     if (
       typeof input.sourceTXID === 'undefined' &&
       typeof input.sourceTransaction === 'undefined'
@@ -273,7 +337,7 @@ export default class Transaction {
    *
    * @param {TransactionOutput} output - The TransactionOutput object to add to the transaction.
    */
-  addOutput (output: TransactionOutput): void {
+  addOutput(output: TransactionOutput): void {
     this.cachedHash = undefined
     this.outputs.push(output)
   }
@@ -283,7 +347,7 @@ export default class Transaction {
    *
    * @param {Record<string, any>} metadata - The metadata object to merge into the existing metadata.
    */
-  updateMetadata (metadata: Record<string, any>): void {
+  updateMetadata(metadata: Record<string, any>): void {
     this.metadata = {
       ...this.metadata,
       ...metadata
@@ -301,7 +365,7 @@ export default class Transaction {
    *
    * TODO: Benford's law change distribution.
    */
-  async fee (modelOrFee?: FeeModel | number, changeDistribution: 'equal' | 'random' = 'equal'): Promise<void> {
+  async fee(modelOrFee?: FeeModel | number, changeDistribution: 'equal' | 'random' = 'equal'): Promise<void> {
     this.cachedHash = undefined
     if (typeof modelOrFee === 'undefined') {
       modelOrFee = new SatoshisPerKilobyte(10)
@@ -316,12 +380,10 @@ export default class Transaction {
     // change = inputs - fee - non-change outputs
     let change = 0
     for (const input of this.inputs) {
-      if (typeof input.sourceTransaction !== 'object' && typeof input.sourceSatoshis !== 'number') {
-        throw new Error('Source transactions or sourceSatoshis are required for all inputs during fee computation')
+      if (typeof input.sourceTransaction !== 'object') {
+        throw new Error('Source transactions are required for all inputs during fee computation')
       }
-      change += input.sourceTransaction
-        ? input.sourceTransaction.outputs[input.sourceOutputIndex].satoshis
-        : input.sourceSatoshis
+      change += input.sourceTransaction.outputs[input.sourceOutputIndex].satoshis
     }
     change -= fee
     let changeCount = 0
@@ -364,15 +426,13 @@ export default class Transaction {
    *
    * @returns The current transaction fee
    */
-  getFee (): number {
+  getFee(): number {
     let totalIn = 0
     for (const input of this.inputs) {
-      if (typeof input.sourceTransaction !== 'object' && typeof input.sourceSatoshis !== 'number') {
+      if (typeof input.sourceTransaction !== 'object') {
         throw new Error('Source transactions or sourceSatoshis are required for all inputs to calculate fee')
       }
-      totalIn += input.sourceTransaction
-        ? input.sourceTransaction.outputs[input.sourceOutputIndex].satoshis
-        : input.sourceSatoshis || 0
+      totalIn += input.sourceTransaction.outputs[input.sourceOutputIndex].satoshis
     }
     let totalOut = 0
     for (const output of this.outputs) {
@@ -384,7 +444,7 @@ export default class Transaction {
   /**
    * Signs a transaction, hydrating all its unlocking scripts based on the provided script templates where they are available.
    */
-  async sign (): Promise<void> {
+  async sign(): Promise<void> {
     this.cachedHash = undefined
     for (const out of this.outputs) {
       if (typeof out.satoshis === 'undefined') {
@@ -415,7 +475,7 @@ export default class Transaction {
    * @param broadcaster The Broadcaster instance wwhere the transaction will be sent
    * @returns A BroadcastResponse or BroadcastFailure from the Broadcaster
    */
-  async broadcast (broadcaster: Broadcaster = defaultBroadcaster()): Promise<BroadcastResponse | BroadcastFailure> {
+  async broadcast(broadcaster: Broadcaster = defaultBroadcaster()): Promise<BroadcastResponse | BroadcastFailure> {
     return await broadcaster.broadcast(this)
   }
 
@@ -424,7 +484,7 @@ export default class Transaction {
    *
    * @returns {number[]} - The binary array representation of the transaction.
    */
-  toBinary (): number[] {
+  toBinary(): number[] {
     const writer = new Writer()
     writer.writeUInt32LE(this.version)
     writer.writeVarIntNum(this.inputs.length)
@@ -456,7 +516,7 @@ export default class Transaction {
    *
    * @returns {number[]} - The BRC-30 EF representation of the transaction.
    */
-  toEF (): number[] {
+  toEF(): number[] {
     const writer = new Writer()
     writer.writeUInt32LE(this.version)
     writer.write([0, 0, 0, 0, 0, 0xef])
@@ -465,7 +525,11 @@ export default class Transaction {
       if (typeof i.sourceTransaction === 'undefined') {
         throw new Error('All inputs must have source transactions when serializing to EF format')
       }
-      writer.write(i.sourceTransaction.hash() as number[])
+      if (typeof i.sourceTXID === 'undefined') {
+        writer.write(i.sourceTransaction.hash() as number[])
+      } else {
+        writer.write(toArray(i.sourceTXID, 'hex').reverse() as number[])
+      }
       writer.writeUInt32LE(i.sourceOutputIndex)
       const scriptBin = i.unlockingScript.toBinary()
       writer.writeVarIntNum(scriptBin.length)
@@ -492,7 +556,7 @@ export default class Transaction {
    *
    * @returns {string} - The hexadecimal string representation of the transaction EF.
    */
-  toHexEF (): string {
+  toHexEF(): string {
     return toHex(this.toEF())
   }
 
@@ -501,7 +565,7 @@ export default class Transaction {
    *
    * @returns {string} - The hexadecimal string representation of the transaction.
    */
-  toHex (): string {
+  toHex(): string {
     return toHex(this.toBinary())
   }
 
@@ -510,7 +574,7 @@ export default class Transaction {
    *
    * @returns {string} - The hexadecimal string representation of the transaction BEEF.
    */
-  toHexBEEF (): string {
+  toHexBEEF(): string {
     return toHex(this.toBEEF())
   }
 
@@ -520,7 +584,7 @@ export default class Transaction {
    * @param {'hex' | undefined} enc - The encoding to use for the hash. If 'hex', returns a hexadecimal string; otherwise returns a binary array.
    * @returns {string | number[]} - The hash of the transaction in the specified format.
    */
-  hash (enc?: 'hex'): number[] | string {
+  hash(enc?: 'hex'): number[] | string {
     let hash
     if (this.cachedHash) {
       hash = this.cachedHash
@@ -540,21 +604,21 @@ export default class Transaction {
    *
    * @returns {number[]} - The ID of the transaction in the binary array format.
    */
-  id (): number[]
+  id(): number[]
   /**
    * Calculates the transaction's ID in hexadecimal format.
    *
    * @param {'hex'} enc - The encoding to use for the ID. If 'hex', returns a hexadecimal string.
    * @returns {string} - The ID of the transaction in the hex format.
    */
-  id (enc: 'hex'): string
+  id(enc: 'hex'): string
   /**
    * Calculates the transaction's ID.
    *
    * @param {'hex' | undefined} enc - The encoding to use for the ID. If 'hex', returns a hexadecimal string; otherwise returns a binary array.
    * @returns {string | number[]} - The ID of the transaction in the specified format.
    */
-  id (enc?: 'hex'): number[] | string {
+  id(enc?: 'hex'): number[] | string {
     const id = [...this.hash() as number[]]
     id.reverse()
     if (enc === 'hex') {
@@ -570,7 +634,7 @@ export default class Transaction {
    *
    * @returns Whether the transaction is valid according to the rules of SPV.
    */
-  async verify (chainTracker: ChainTracker | 'scripts only' = defaultChainTracker()): Promise<boolean> {
+  async verify(chainTracker: ChainTracker | 'scripts only' = defaultChainTracker()): Promise<boolean> {
     // If the transaction has a valid merkle path, verification is complete.
     if (typeof this.merklePath === 'object' && chainTracker !== 'scripts only') {
       const proofValid = await this.merklePath.verify(
@@ -638,7 +702,7 @@ export default class Transaction {
    *
    * @returns The serialized BEEF structure
    */
-  toBEEF (): number[] {
+  toBEEF(): number[] {
     const writer = new Writer()
     writer.writeUInt32LE(4022206465)
     const BUMPs: MerklePath[] = []
@@ -676,7 +740,10 @@ export default class Transaction {
           BUMPs.push(tx.merklePath)
         }
       }
-      txs.unshift(obj)
+      const duplicate = txs.some(x => x.tx.id('hex') === tx.id('hex'))
+      if (!duplicate) {
+        txs.unshift(obj)
+      }
       if (!hasProof) {
         for (let i = 0; i < tx.inputs.length; i++) {
           const input = tx.inputs[i]

package/src/transaction/TransactionInput.ts

@@ -16,9 +16,6 @@ import Transaction from './Transaction.js'
  * @property {number} sourceOutputIndex - The index of the output in the source transaction
  *           that this input is spending. It is zero-based, indicating the position of the
  *           output in the array of outputs of the source transaction.
- * @property {number} [sourceSatoshis] - The amount of satoshis of the source transaction
- *           output that this input is spending, used for fee calculation and signing when
- *           source transaction is not present
  * @property {UnlockingScript} [unlockingScript] - Optional. The script that 'unlocks' the
  *           source output for spending. This script typically contains signatures and
  *           public keys that evidence the ownership of the output.
@@ -57,7 +54,6 @@ export default interface TransactionInput {
   sourceTransaction?: Transaction
   sourceTXID?: string
   sourceOutputIndex: number
-  sourceSatoshis?: number
   unlockingScript?: UnlockingScript
   unlockingScriptTemplate?: {
     sign: (tx: Transaction, inputIndex: number) => Promise<UnlockingScript>

package/src/transaction/__tests/Transaction.test.ts

@@ -9,6 +9,7 @@ import { hash256, hash160 } from '../../../dist/cjs/src/primitives/Hash'
 import PrivateKey from '../../../dist/cjs/src/primitives/PrivateKey'
 import Curve from '../../../dist/cjs/src/primitives/Curve'
 import P2PKH from '../../../dist/cjs/src/script/templates/P2PKH'
+import fromUtxo from '../../../dist/cjs/src/compat/Utxo'
 
 import sighashVectors from '../../primitives/__tests/sighash.vectors'
 import invalidTransactions from './tx.invalid.vectors'
@@ -85,23 +86,23 @@ describe('Transaction', () => {
   })
 
   describe('#parseScriptOffsets', () => {
-      it('should match sliced scripts to parsed scripts', async () => {
-        const tx = Transaction.fromBinary(tx2buf)
-        expect(tx.id("hex")).toBe(tx2idhex)
-        const r = Transaction.parseScriptOffsets(tx2buf)
-        expect(r.inputs.length).toBe(2)
-        expect(r.outputs.length).toBe(2)
-        for (let vin = 0; vin < 2; vin++) {
-            const i = r.inputs[vin]
-            const script = tx2buf.slice(i.offset, i.length + i.offset)
-            expect(script).toEqual(tx.inputs[vin].unlockingScript?.toBinary())
-        }
-        for (let vout = 0; vout < 2; vout++) {
-            const o = r.outputs[vout]
-            const script = tx2buf.slice(o.offset, o.length + o.offset)
-            expect(script).toEqual(tx.outputs[vout].lockingScript?.toBinary())
-        }
-      })
+    it('should match sliced scripts to parsed scripts', async () => {
+      const tx = Transaction.fromBinary(tx2buf)
+      expect(tx.id("hex")).toBe(tx2idhex)
+      const r = Transaction.parseScriptOffsets(tx2buf)
+      expect(r.inputs.length).toBe(2)
+      expect(r.outputs.length).toBe(2)
+      for (let vin = 0; vin < 2; vin++) {
+        const i = r.inputs[vin]
+        const script = tx2buf.slice(i.offset, i.length + i.offset)
+        expect(script).toEqual(tx.inputs[vin].unlockingScript?.toBinary())
+      }
+      for (let vout = 0; vout < 2; vout++) {
+        const o = r.outputs[vout]
+        const script = tx2buf.slice(o.offset, o.length + o.offset)
+        expect(script).toEqual(tx.outputs[vout].lockingScript?.toBinary())
+      }
+    })
   })
 
   describe('#toHex', () => {
@@ -396,14 +397,13 @@ describe('Transaction', () => {
       const priv = PrivateKey.fromRandom()
       const tx = new Transaction()
       utxos.forEach(utxo => {
-        const script = new P2PKH().lock(priv.toPublicKey().toHash())
-        tx.addInput({
-          sourceTXID: utxo.tx_hash,
-          sourceOutputIndex: utxo.tx_pos,
-          sourceSatoshis: utxo.value,
-          unlockingScriptTemplate: new P2PKH()
-            .unlock(priv, 'all', false, utxo.value, script)
-        })
+        const u = {
+          txid: utxo.tx_hash,
+          vout: utxo.tx_pos,
+          script: new P2PKH().lock(priv.toPublicKey().toHash()).toHex(),
+          satoshis: utxo.value
+        }
+        tx.addInput(fromUtxo(u, new P2PKH().unlock(priv)))
       })
       tx.addOutput({
         lockingScript: new P2PKH().lock(priv.toAddress()),
@@ -417,7 +417,7 @@ describe('Transaction', () => {
 
   describe('Broadcast', () => {
     it('Broadcasts with the default Broadcaster instance', async () => {
-      const mockedFetch =  jest.fn().mockResolvedValue({
+      const mockedFetch = jest.fn().mockResolvedValue({
         ok: true,
         status: 200,
         statusText: 'OK',
@@ -430,12 +430,12 @@ describe('Transaction', () => {
         },
         json: async () => ({
           txid: 'mocked_txid',
-            txStatus: 'success',
-            extraInfo: 'received'
+          txStatus: 'success',
+          extraInfo: 'received'
         })
       });
 
-      (global as any).window = {fetch: mockedFetch} as any
+      (global as any).window = { fetch: mockedFetch } as any
 
       const tx = new Transaction()
       const rv = await tx.broadcast()
@@ -468,6 +468,13 @@ describe('Transaction', () => {
       const beef = toHex(tx.toBEEF())
       expect(beef).toEqual(BRC62Hex)
     })
+    it('Does not double-encode transactions', () => {
+      // Source: https://github.com/bitcoin-sv/ts-sdk/issues/77
+      const correct = '0100beef01fe76eb0c000e02c402deff5437203e0b5cb22646cbada24a60349bf45c8b280ffb755868f2955c3111c500f4076b7f48031fc467f87d5e99d9c3c0b59e4dca5e3049f58b735c59b413a8b6016300bad9c2d948e8a2ca647fdb50f2fd36641c4adf937b41134405a3e7f734b8beb201300053604a579558b5f7030e618d5c726a19229e0ff677f6edf109f41c5cfdafc93e0119005f8465c2a8d1558afbfa80c2395f3f8866a2fa5015e54fab778b0149da58376c010d00cd452b4e74f57d199cdb81b8a0e4a62dcdaf89504d6c63a5a65d5b866912b8c0010700d2ae7e2ce76da560509172066f1a1cf81faf81d73f9c0f6fd5af0904973dcfb10102006e5e077bcaa35c0240d61c1f3bba8d789223711ec035ef88b0911fc569d2b95a010000c961038959b9d404297a180c066816562dd2a34986c0960121a87ba91a51262f010100a50e381b4e8812479ea561e5bab7dcaa80078652b1b39ee5410966c515a3442b010100383ce8891ca7bf1ddefa5e0d8a1ba9ab01cb4e18046e9d7d0d438b5aaecc38b2010100c694be322b4e74acca8a5ef7703afedb708281321fd674f1221eebc743b0e01c0101000f3cc61f2b3d762cfecdd977ba768a5cbb0a4b402ad4f0d1bd3a98a582794c35010100094ad56eeea3b47edb2b298775f2efabe48172612cb3419962632251d8cdb78e010100de84bf9dd8873f37decbda1b5188e24ead978b147a63c809691702d19c47e8cb030200000001b67f1b6a6c3e70742a39b82ba45d51c983f598963ebf237101cc372da1144b83020000006b483045022100d14c3eb0c1438747c124f099bc664bf945cd27cbd96915027057e508bbc9e03302203c73f79d4e00f8018783e1008ce0fbb8e8c58bff6bd8042ab7e3966a66c8788c41210356762156ee9347c3e2ceca17d13713028d5446f453e9cbcb0ea170b4ca7fab52ffffffff037c660000000000001976a91417c85798ff61f7ec8af257f672d973b6ec6d88fd88ac75330100000000001976a914eb645f9ea7e4e232e54b9651474c100026698c3088acf2458005000000001976a914802737e30c85b6fe86e26fb28e03140058aca65e88ac0000000001000100000001deff5437203e0b5cb22646cbada24a60349bf45c8b280ffb755868f2955c3111000000006a473044022076da9f61380c208f43652587c219b4452a7b803a0407c2c7c0f3bc27612c4e88022021a9eb02da5529873a5986933f9c35965aa78537b9e2aef9382de33cfb1ab4bb41210314793e1758db3caa7d2bce97b347ae3ced2f8a402b797ed986be63473d4644a0ffffffff023c330000000000001976a91417c85798ff61f7ec8af257f672d973b6ec6d88fd88ac3c330000000000001976a91417c85798ff61f7ec8af257f672d973b6ec6d88fd88ac000000000001000000022e7f69f3e1e17e22cfb8818577b3c83a4fbbbc1bab55c70ffcdd994ae30ea48b000000006b483045022100d9a2d1efea4896b36b2eb5af42cf52009982c7c31b446213fe37f26835d9d72202203e4dee0ceb068a4936e79b0bf69f72203906a00a4256cb1a7b30a40764616e8441210314793e1758db3caa7d2bce97b347ae3ced2f8a402b797ed986be63473d4644a0ffffffff2e7f69f3e1e17e22cfb8818577b3c83a4fbbbc1bab55c70ffcdd994ae30ea48b010000006b483045022100b57a09145c57b7b5efb4b546f1b0bfb7adbc5e64d35d9d6989345d4c60c483940220280998a210a49a6efaacda6fb73670001bb7269d069be80eb14ea2227a73e82241210314793e1758db3caa7d2bce97b347ae3ced2f8a402b797ed986be63473d4644a0ffffffff0174660000000000001976a91417c85798ff61f7ec8af257f672d973b6ec6d88fd88ac0000000000'
+      const incorrect = '0100beef01fe77eb0c000e02fdd8140017899f90c0513b78b832ea9b25596cdd5132c570addd0f4cf40d23030243b36afdd914022e7f69f3e1e17e22cfb8818577b3c83a4fbbbc1bab55c70ffcdd994ae30ea48b01fd6d0a0004307f45c624b6f19e6f85ce0e9b56931aae58affef11a225bb564aa5f785bc101fd370500952937347592ef6df9d578da0d04c889193e7a3c807638549b49c697098596de01fd9a020035c7831b6f5088ca905b169ff33814284f6a27aa7362db5b7f0de517c3853fa901fd4c01004123b25530fe6a11b16cb3725e0b1ffff109e3ed8993116ff025a97b2cbcd46601a700adefed13a8d2a1a091b9b1807c1434611a5403845b6fa78bbb5d660af4e81602015200d0967c10ee6fd2b74e8989dc7e36eeb3ae13fe6cae0dcbb39ca79782ec729bbf0128003ff7aeff8cdb8ffecc82465ec67d64a29bbf81f725cf1da2911e9741e1667e1c011500d0e20a1598a95a7df7b54ac2e82325b0f5ae7924ce8f4b55520b42547c4dc1b1010b003642e6fd39340cf8626cff5aefb8dffb7483d0936ca241b4cef7cd819813b2820104000589e88fae5f2d465f2e7a5edaef98ebcd7d0b39f848fba1e86f0f3a93d4898b010300a161114db7317b74e1f535b8dc0bccd3c7c64c2812d6efbd7dbcdd5d5fc55012010000726acffff2f3cb821c418c81c6329360ea7a88c37d2bf8eba01bd4eb9ca32210010100bc8e959a21ffe2c6fcc64f292d8023557c1b4d52ff4ff829840ca5091d00c31b020100000001deff5437203e0b5cb22646cbada24a60349bf45c8b280ffb755868f2955c3111000000006a473044022076da9f61380c208f43652587c219b4452a7b803a0407c2c7c0f3bc27612c4e88022021a9eb02da5529873a5986933f9c35965aa78537b9e2aef9382de33cfb1ab4bb41210314793e1758db3caa7d2bce97b347ae3ced2f8a402b797ed986be63473d4644a0ffffffff023c330000000000001976a91417c85798ff61f7ec8af257f672d973b6ec6d88fd88ac3c330000000000001976a91417c85798ff61f7ec8af257f672d973b6ec6d88fd88ac00000000010001000000012e7f69f3e1e17e22cfb8818577b3c83a4fbbbc1bab55c70ffcdd994ae30ea48b000000006b483045022100fbfd5d1969c455d0a8d8c5a78809b9fe4a98531d2ebaafc84b0d3411b577573f02204f8e945b76495ad46e57db3d09e8284d7859e8b6f7595808c56fef29356e313c41210314793e1758db3caa7d2bce97b347ae3ced2f8a402b797ed986be63473d4644a0ffffffff013a330000000000001976a91417c85798ff61f7ec8af257f672d973b6ec6d88fd88ac0000000000'
+      const tx1 = Transaction.fromHexBEEF(correct)
+      expect(tx1.toHexBEEF()).toEqual(correct)
+    })
   })
 
   describe('EF', () => {
@@ -489,7 +496,7 @@ describe('Transaction', () => {
     })
 
     it('Verifies the transaction from the BEEF spec with a default chain tracker', async () => {
-      const mockFetch =  jest.fn().mockResolvedValue({
+      const mockFetch = jest.fn().mockResolvedValue({
         ok: true,
         status: 200,
         statusText: 'OK',
@@ -504,7 +511,7 @@ describe('Transaction', () => {
           merkleroot: MerkleRootFromBEEF,
         })
       });
-      (global as any).window = {fetch: mockFetch}
+      (global as any).window = { fetch: mockFetch }
 
 
       const tx = Transaction.fromHexBEEF(BRC62Hex)