@bsuite/page-builder 1.0.2 → 1.0.3

package/dist/autoHeight.d.ts

@@ -44,6 +44,40 @@ export interface ComputeAutoHeightRowsOptions {
  * time. Ceiling always over-allocates rather than under-allocates, trading
  * a few pixels of empty card padding for a guarantee that content is never
  * cut off.
+ *
+ * THE MARGIN IS *BETWEEN* ROWS, NOT INSIDE EVERY ROW. This is the correction
+ * that this file existed for a month without.
+ *
+ * react-grid-layout allocates an item of `n` rows exactly:
+ *
+ *     px(n) = n * rowHeight + (n - 1) * marginY
+ *
+ * so `n` rows are worth `n * (rowHeight + marginY) - marginY` pixels — one
+ * margin LESS than the row unit suggests. Dividing the needed height by the
+ * bare row unit therefore credits every item with `marginY` pixels it does
+ * not get, and `Math.ceil` cannot rescue that: the shortfall is inside the
+ * rounding, not beyond it.
+ *
+ * Inverting the real formula for the smallest `n` that fits:
+ *
+ *     n * rowHeight + (n - 1) * marginY  >=  needed
+ *     n                                  >= (needed + marginY) / (rowHeight + marginY)
+ *
+ * MEASURED ON PRODUCTION, 2026-08-20, crm7 /clients/create at 1366x768. The
+ * card holding the form's Create/Cancel row measured 32px tall around a 36px
+ * button, with `overflow-hidden`, so the button was cut off and a neighbouring
+ * card's helper text was painted over what remained — `elementFromPoint` at the
+ * button's centre returned a `<p>`, not the button. The form could not be
+ * submitted by a person. rowHeight 32 + marginY 6: 36px of content came to
+ * `ceil((36 + 2) / 38) = 1` row, and one row is 32 pixels.
+ *
+ * The old form clips whenever the needed height lands 1..marginY pixels above a
+ * row boundary — 6 of every 38 possible heights, about one card in six.
+ *
+ * It survived because the tests asserted the ARITHMETIC rather than the
+ * OUTCOME: they checked the division, never whether the resulting row count
+ * buys enough pixels. Three of them encoded a clipping case as the expected
+ * answer. They now assert against react-grid-layout's own formula instead.
  */
 export declare function computeAutoHeightRows({ contentPx, cardChromePx, rowHeightPx, marginYPx, minRows, }: ComputeAutoHeightRowsOptions): number;
 //# sourceMappingURL=autoHeight.d.ts.map

package/dist/autoHeight.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"autoHeight.d.ts","sourceRoot":"","sources":["../src/autoHeight.ts"],"names":[],"mappings":"AAAA,MAAM,WAAW,4BAA4B;IAC3C;;;;;;;;;;;OAWG;IACH,SAAS,EAAE,MAAM,CAAC;IAClB;;;;;OAKG;IACH,YAAY,EAAE,MAAM,CAAC;IACrB;;;OAGG;IACH,WAAW,EAAE,MAAM,CAAC;IACpB;;;;OAIG;IACH,SAAS,EAAE,MAAM,CAAC;IAClB;;;OAGG;IACH,OAAO,CAAC,EAAE,MAAM,CAAC;CAClB;AAED;;;;;;;;GAQG;AACH,wBAAgB,qBAAqB,CAAC,EACpC,SAAS,EACT,YAAY,EACZ,WAAW,EACX,SAAS,EACT,OAAW,GACZ,EAAE,4BAA4B,GAAG,MAAM,CAKvC"}
+{"version":3,"file":"autoHeight.d.ts","sourceRoot":"","sources":["../src/autoHeight.ts"],"names":[],"mappings":"AAAA,MAAM,WAAW,4BAA4B;IAC3C;;;;;;;;;;;OAWG;IACH,SAAS,EAAE,MAAM,CAAC;IAClB;;;;;OAKG;IACH,YAAY,EAAE,MAAM,CAAC;IACrB;;;OAGG;IACH,WAAW,EAAE,MAAM,CAAC;IACpB;;;;OAIG;IACH,SAAS,EAAE,MAAM,CAAC;IAClB;;;OAGG;IACH,OAAO,CAAC,EAAE,MAAM,CAAC;CAClB;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA0CG;AACH,wBAAgB,qBAAqB,CAAC,EACpC,SAAS,EACT,YAAY,EACZ,WAAW,EACX,SAAS,EACT,OAAW,GACZ,EAAE,4BAA4B,GAAG,MAAM,CAOvC"}

package/dist/autoHeight.js

@@ -6,11 +6,47 @@
  * time. Ceiling always over-allocates rather than under-allocates, trading
  * a few pixels of empty card padding for a guarantee that content is never
  * cut off.
+ *
+ * THE MARGIN IS *BETWEEN* ROWS, NOT INSIDE EVERY ROW. This is the correction
+ * that this file existed for a month without.
+ *
+ * react-grid-layout allocates an item of `n` rows exactly:
+ *
+ *     px(n) = n * rowHeight + (n - 1) * marginY
+ *
+ * so `n` rows are worth `n * (rowHeight + marginY) - marginY` pixels — one
+ * margin LESS than the row unit suggests. Dividing the needed height by the
+ * bare row unit therefore credits every item with `marginY` pixels it does
+ * not get, and `Math.ceil` cannot rescue that: the shortfall is inside the
+ * rounding, not beyond it.
+ *
+ * Inverting the real formula for the smallest `n` that fits:
+ *
+ *     n * rowHeight + (n - 1) * marginY  >=  needed
+ *     n                                  >= (needed + marginY) / (rowHeight + marginY)
+ *
+ * MEASURED ON PRODUCTION, 2026-08-20, crm7 /clients/create at 1366x768. The
+ * card holding the form's Create/Cancel row measured 32px tall around a 36px
+ * button, with `overflow-hidden`, so the button was cut off and a neighbouring
+ * card's helper text was painted over what remained — `elementFromPoint` at the
+ * button's centre returned a `<p>`, not the button. The form could not be
+ * submitted by a person. rowHeight 32 + marginY 6: 36px of content came to
+ * `ceil((36 + 2) / 38) = 1` row, and one row is 32 pixels.
+ *
+ * The old form clips whenever the needed height lands 1..marginY pixels above a
+ * row boundary — 6 of every 38 possible heights, about one card in six.
+ *
+ * It survived because the tests asserted the ARITHMETIC rather than the
+ * OUTCOME: they checked the division, never whether the resulting row count
+ * buys enough pixels. Three of them encoded a clipping case as the expected
+ * answer. They now assert against react-grid-layout's own formula instead.
  */
 export function computeAutoHeightRows({ contentPx, cardChromePx, rowHeightPx, marginYPx, minRows = 1, }) {
     const rowUnitPx = rowHeightPx + marginYPx;
     if (rowUnitPx <= 0)
         return minRows;
-    const raw = Math.ceil((contentPx + cardChromePx) / rowUnitPx);
+    // `+ marginYPx` inverts px(n) = n*rowHeight + (n-1)*marginY. Without it every
+    // item is credited with one margin it never receives. See the docblock.
+    const raw = Math.ceil((contentPx + cardChromePx + marginYPx) / rowUnitPx);
     return Math.max(minRows, raw);
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bsuite/page-builder",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "Shared BSuite responsive page-builder grid and layout persistence primitives",
   "type": "module",
   "license": "UNLICENSED",