@bsuite/page-builder 0.6.0 → 0.6.2

package/dist/PageGridLayout.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"PageGridLayout.d.ts","sourceRoot":"","sources":["../src/PageGridLayout.tsx"],"names":[],"mappings":"AACA,OAAO,KAA6E,MAAM,OAAO,CAAC;AAGlG,OAAO,kCAAkC,CAAC;AAC1C,OAAO,gCAAgC,CAAC;AAKxC,OAAO,KAAK,EAAe,mBAAmB,EAAE,MAAM,YAAY,CAAC;AA0QnE,wBAAgB,cAAc,CAAC,EAC7B,OAAO,EACP,cAAc,EACd,WAAW,EACX,aAAa,EACb,WAAW,EACX,gBAAgB,EAChB,iBAAiB,EACjB,OAAO,EACP,UAAU,EACV,SAAS,EAMT,WAAkB,EAClB,aAAsC,EACtC,yBAAiE,EACjE,kBAAkB,EAClB,sBAAsB,GACvB,EAAE,mBAAmB,qBAwpBrB"}
+{"version":3,"file":"PageGridLayout.d.ts","sourceRoot":"","sources":["../src/PageGridLayout.tsx"],"names":[],"mappings":"AACA,OAAO,KAA6E,MAAM,OAAO,CAAC;AAGlG,OAAO,kCAAkC,CAAC;AAC1C,OAAO,gCAAgC,CAAC;AAKxC,OAAO,KAAK,EAAe,mBAAmB,EAAE,MAAM,YAAY,CAAC;AA0QnE,wBAAgB,cAAc,CAAC,EAC7B,OAAO,EACP,cAAc,EACd,WAAW,EACX,aAAa,EACb,WAAW,EACX,gBAAgB,EAChB,iBAAiB,EACjB,OAAO,EACP,UAAU,EACV,SAAS,EAMT,WAAkB,EAClB,aAAsC,EACtC,yBAAiE,EACjE,kBAAkB,EAClB,sBAAsB,GACvB,EAAE,mBAAmB,qBAirBrB"}

package/dist/PageGridLayout.js

@@ -276,12 +276,35 @@ isResizable = true, resizeHandles = DEFAULT_RESIZE_HANDLES, addEntityWidgetEvent
                 .map((item) => {
                 if (!item.autoHeight)
                     return item;
+                // HEAL a persisted `isResizable: false`.
+                //
+                // 0.5.2 set this at the render layer, and it leaked out through
+                // `onLayoutChange` into the SAVED layout. Removing the override in
+                // 0.6.0 was therefore not enough: react-grid-layout resolves
+                //
+                //   typeof l.isResizable === 'boolean' ? l.isResizable
+                //                                      : !l.static && gridResizable
+                //
+                // so an explicit persisted `false` beats the grid default forever.
+                // Every user who ever loaded an affected page has it stored.
+                //
+                // Confirmed in a real signed-in browser 2026-07-31: the saved
+                // preference for /financial/invoicing/:id held
+                // `"isResizable":false` on all 6 cards; clearing it by hand did not
+                // help, because it was re-persisted on the next load.
+                //
+                // A per-item `false` on an autoHeight item cannot be a user choice —
+                // nothing in the UI sets it, and page-level opt-out uses the
+                // `isResizable` PROP, not per-item layout. So it can only have come
+                // from the 0.5.2 bug, and dropping it is safe.
+                const { isResizable: persisted, ...rest } = item;
+                const healed = persisted === false ? rest : item;
                 const measuredRows = autoHeightRows[item.i];
                 if (measuredRows === undefined)
-                    return item;
+                    return healed;
                 return {
-                    ...item,
-                    h: Math.max(item.h ?? 0, measuredRows),
+                    ...healed,
+                    h: Math.max(healed.h ?? 0, measuredRows),
                     minH: measuredRows,
                 };
             });

package/dist/usePageGridLayout.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"usePageGridLayout.d.ts","sourceRoot":"","sources":["../src/usePageGridLayout.ts"],"names":[],"mappings":"AAaA,OAAO,KAAK,EAGV,wBAAwB,EACxB,uBAAuB,EACxB,MAAM,YAAY,CAAC;AAEpB,eAAO,MAAM,0BAA0B,2IAM7B,CAAC;AAEX;;;;;;;;GAQG;AACH,eAAO,MAAM,uBAAuB,6BAA6B,CAAC;AAElE,MAAM,WAAW,0BAA0B;IACzC,OAAO,EAAE,MAAM,CAAC;IAChB,OAAO,EAAE,OAAO,CAAC;CAClB;AAED,wBAAgB,iBAAiB,CAAC,EAChC,OAAO,EACP,cAAc,EACd,WAAgB,EAChB,aAAiB,EACjB,WAAkB,EAClB,gBAA6C,EAC7C,iBAA4C,GAC7C,EAAE,wBAAwB,GAAG,uBAAuB,CA2cpD"}
+{"version":3,"file":"usePageGridLayout.d.ts","sourceRoot":"","sources":["../src/usePageGridLayout.ts"],"names":[],"mappings":"AAaA,OAAO,KAAK,EAGV,wBAAwB,EACxB,uBAAuB,EACxB,MAAM,YAAY,CAAC;AAEpB,eAAO,MAAM,0BAA0B,2IAM7B,CAAC;AAEX;;;;;;;;GAQG;AACH,eAAO,MAAM,uBAAuB,6BAA6B,CAAC;AAElE,MAAM,WAAW,0BAA0B;IACzC,OAAO,EAAE,MAAM,CAAC;IAChB,OAAO,EAAE,OAAO,CAAC;CAClB;AAED,wBAAgB,iBAAiB,CAAC,EAChC,OAAO,EACP,cAAc,EACd,WAAgB,EAChB,aAAiB,EACjB,WAAkB,EAClB,gBAA6C,EAC7C,iBAA4C,GAC7C,EAAE,wBAAwB,GAAG,uBAAuB,CA+fpD"}

package/dist/usePageGridLayout.js

@@ -190,23 +190,50 @@ export function usePageGridLayout({ pageKey, defaultLayouts, defaultCols = 12, l
     const pendingLayoutRef = useRef(null);
     const layoutCommitFrameRef = useRef(null);
     /**
-     * Strips DERIVED measured heights out of a layout before it reaches the
-     * preference adapter. react-grid-layout is rendered with `autoHeightRows`
-     * merged over the saved layout (see `applyAutoHeightRows`), so the layouts
-     * it echoes back through `onLayoutChange` carry the MEASURED `h` for
-     * autoHeight items — persisting that verbatim would smuggle measured
-     * heights into user_preferences through the drag/resize path and drop the
+     * Strips a DERIVED measured height out of a layout before it reaches the
+     * preference adapter — but only when the incoming `h` is nothing more than
+     * an ECHO of the render-layer merge, not a real user gesture.
+     *
+     * react-grid-layout is rendered with `autoHeightRows` merged over the saved
+     * layout (see `applyAutoHeightRows` / `activeLayouts` in
+     * `PageGridLayout.tsx`: `h = max(saved, measured)`), so the layouts it
+     * echoes back through `onLayoutChange` carry that MERGED `h` for every
+     * autoHeight item, on every commit — including commits that never touched
+     * this particular item (e.g. a re-measurement of a sibling card, or a
+     * column-count change, while mid-edit). Persisting that verbatim would
+     * smuggle a measured height into user_preferences and drop the
      * `autoHeight` flag (react-grid-layout does not round-trip custom item
-     * props). Restore `h`/`minH`/`autoHeight` from the un-merged base layout;
-     * user-driven `x`/`y`/`w` (and `h` for non-autoHeight items) pass through
-     * untouched. Reads the base via a ref so the trailing-rAF commit below
-     * never closes over a stale snapshot.
+     * props).
+     *
+     * crm7#744 (2026-07-31): the previous version of this function restored
+     * `h`/`minH` from the un-merged base layout UNCONDITIONALLY for every
+     * autoHeight item, on every call — which discarded a genuine SE-handle
+     * resize just as thoroughly as it discarded a measurement echo, because
+     * both arrive as "an `h` that differs from the base." Confirmed in a real
+     * signed-in browser: width (never touched by this function) persisted
+     * correctly across a resize; height always snapped back to its pre-drag
+     * value, deterministically, regardless of drag distance.
+     *
+     * Fix: only treat the incoming `h` as an echo — and revert it — when it
+     * exactly equals what react-grid-layout was actually RENDERED with
+     * (`max(baseItem.h, measuredRows)`). Anything else is a deliberate user
+     * resize (larger OR smaller) and must persist, still floored by the
+     * measured content height so nothing can clip. `x`/`y`/`w` (and `h` for
+     * non-autoHeight items) pass through untouched either way.
+     *
+     * Reads both the base layout and the measured rows via refs so the
+     * trailing-rAF commit below never closes over a stale snapshot, and so
+     * this callback's identity stays stable across every ResizeObserver tick
+     * (avoids recreating `onLayoutChange` — and therefore the `<Responsive>`
+     * prop identity react-grid-layout sees — on every measurement).
      */
     const currentLayoutsForStripRef = useRef(null);
+    const autoHeightRowsForStripRef = useRef({});
     const stripAutoHeightRows = useCallback((layouts) => {
         const base = currentLayoutsForStripRef.current;
         if (!base)
             return layouts;
+        const measured = autoHeightRowsForStripRef.current;
         const result = { lg: [] };
         for (const bp of Object.keys(layouts)) {
             const baseItems = base[bp] ?? base.lg ?? [];
@@ -215,7 +242,22 @@ export function usePageGridLayout({ pageKey, defaultLayouts, defaultCols = 12, l
                 const baseItem = baseByKey.get(item.i);
                 if (!baseItem?.autoHeight)
                     return item;
-                return { ...item, autoHeight: true, h: baseItem.h, minH: baseItem.minH };
+                const measuredRows = measured[item.i];
+                const renderedFloorH = measuredRows === undefined ? baseItem.h : Math.max(baseItem.h ?? 0, measuredRows);
+                if (item.h === renderedFloorH) {
+                    // Echo of the render-layer merge (or genuinely unchanged) — not a
+                    // user gesture on THIS item. Restore the un-merged base so a
+                    // measured bump never persists.
+                    return { ...item, autoHeight: true, h: baseItem.h, minH: baseItem.minH };
+                }
+                // A deliberate resize (bigger or smaller than the base) — keep it,
+                // still floored by the measured content height.
+                return {
+                    ...item,
+                    autoHeight: true,
+                    h: measuredRows === undefined ? item.h : Math.max(item.h, measuredRows),
+                    minH: measuredRows ?? baseItem.minH,
+                };
             });
         }
         return result;
@@ -357,16 +399,24 @@ export function usePageGridLayout({ pageKey, defaultLayouts, defaultCols = 12, l
      *   producing the layouts handed to react-grid-layout (see
      *   `PageGridLayout`'s `activeLayouts` memo), so read-only users get
      *   full-height cards too.
-     * - NEVER persisted — not even while editing. Measurements re-derive on
-     *   every mount; writing them to the preference adapter would be redundant
-     *   AND would turn mere viewing (e.g. Radix tab switches inside a card,
-     *   which unmount/remount panel content and fire the ResizeObserver) into
-     *   storage upserts for any authenticated viewer.
+     * - NEVER persisted from passive viewing. Measurements re-derive on every
+     *   mount; writing them to the preference adapter on their own would be
+     *   redundant AND would turn mere viewing (e.g. Radix tab switches inside a
+     *   card, which unmount/remount panel content and fire the ResizeObserver)
+     *   into storage upserts for any authenticated viewer — see the CRITICAL #2
+     *   integration test. The one exception (crm7#744) is `minH` on a card the
+     *   user is ACTIVELY, deliberately resizing right now: `stripAutoHeightRows`
+     *   floors that card's persisted `minH` to the live measured value so the
+     *   floor invariant survives the same commit as the resize, which is a
+     *   user-driven write, not a passive one.
      * - Updated FUNCTIONALLY in one combined state update per flush, so two
      *   cards settling in the same animation frame can never last-writer-wins
      *   each other through a stale closure.
      */
     const [autoHeightRows, setAutoHeightRows] = useState({});
+    useEffect(() => {
+        autoHeightRowsForStripRef.current = autoHeightRows;
+    }, [autoHeightRows]);
     const applyAutoHeightRows = useCallback((rowsByWidget) => {
         setAutoHeightRows((previous) => {
             let changed = false;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bsuite/page-builder",
-  "version": "0.6.0",
+  "version": "0.6.2",
   "description": "Shared BSuite responsive page-builder grid and layout persistence primitives",
   "type": "module",
   "license": "UNLICENSED",