@bryan-thompson/inspector-assessment-client 1.19.3 → 1.19.4

package/dist/assets/{OAuthCallback-B2AjbBqS.js → OAuthCallback-ByUGVYdZ.js}

@@ -1,4 +1,4 @@
-import { u as useToast, r as reactExports, j as jsxRuntimeExports, p as parseOAuthCallbackParams, g as generateOAuthErrorDescription, S as SESSION_KEYS, I as InspectorOAuthClientProvider, a as auth } from "./index-i29GUqYn.js";
+import { u as useToast, r as reactExports, j as jsxRuntimeExports, p as parseOAuthCallbackParams, g as generateOAuthErrorDescription, S as SESSION_KEYS, I as InspectorOAuthClientProvider, a as auth } from "./index-CY09KxrR.js";
 const OAuthCallback = ({ onConnect }) => {
   const { toast } = useToast();
   const hasProcessedRef = reactExports.useRef(false);

package/dist/assets/{OAuthDebugCallback-B3UFm4SC.js → OAuthDebugCallback-D1soBtsd.js}

@@ -1,4 +1,4 @@
-import { r as reactExports, S as SESSION_KEYS, p as parseOAuthCallbackParams, j as jsxRuntimeExports, g as generateOAuthErrorDescription } from "./index-i29GUqYn.js";
+import { r as reactExports, S as SESSION_KEYS, p as parseOAuthCallbackParams, j as jsxRuntimeExports, g as generateOAuthErrorDescription } from "./index-CY09KxrR.js";
 const OAuthDebugCallback = ({ onConnect }) => {
   reactExports.useEffect(() => {
     let isProcessed = false;

package/dist/assets/{index-i29GUqYn.js → index-CY09KxrR.js}

@@ -16320,7 +16320,7 @@ object({
   token_type_hint: string().optional()
 }).strip();
 const name = "@bryan-thompson/inspector-assessment-client";
-const version$1 = "1.19.2";
+const version$1 = "1.19.3";
 const packageJson = {
   name,
   version: version$1
@@ -23649,6 +23649,21 @@ function validateToolOutput(toolName, structuredContent) {
 function hasOutputSchema(toolName) {
   return toolOutputValidators.has(toolName);
 }
+function tryExtractJsonFromContent(content) {
+  if (!content || !Array.isArray(content)) {
+    return null;
+  }
+  const textBlocks = content.filter((block) => block.type === "text");
+  for (const block of textBlocks) {
+    if (!block.text) continue;
+    try {
+      return JSON.parse(block.text);
+    } catch {
+      continue;
+    }
+  }
+  return null;
+}
 function generateDefaultValue(schema, propertyName, parentSchema) {
   if ("default" in schema && schema.default !== void 0) {
     return schema.default;
@@ -45337,7 +45352,7 @@ const useTheme = () => {
     [theme, setThemeWithSideEffect]
   );
 };
-const version = "1.19.2";
+const version = "1.19.3";
 var [createTooltipContext] = createContextScope("Tooltip", [
   createPopperScope
 ]);
@@ -47362,16 +47377,26 @@ const ToolResults = ({
     let validationResult = null;
     const toolHasOutputSchema = selectedTool && hasOutputSchema(selectedTool.name);
     if (toolHasOutputSchema) {
-      if (!structuredResult.structuredContent && !isError) {
-        validationResult = {
-          isValid: false,
-          error: "Tool has an output schema but did not return structured content"
-        };
-      } else if (structuredResult.structuredContent) {
+      if (structuredResult.structuredContent) {
         validationResult = validateToolOutput(
           selectedTool.name,
           structuredResult.structuredContent
         );
+      } else if (!isError) {
+        const extractedJson = tryExtractJsonFromContent(
+          structuredResult.content
+        );
+        if (extractedJson !== null) {
+          validationResult = validateToolOutput(
+            selectedTool.name,
+            extractedJson
+          );
+        } else {
+          validationResult = {
+            isValid: false,
+            error: "Tool has output schema but response contains no valid JSON"
+          };
+        }
       }
     }
     let compatibilityResult = null;
@@ -48329,7 +48354,11 @@ class MCPSpecComplianceAssessor extends BaseAssessor {
     const metadataHints = this.extractMetadataHints(context);
     const checksArray = Object.values(protocolChecks);
     const passedCount = checksArray.filter((c) => c.passed).length;
-    const complianceScore = passedCount / checksArray.length * 100;
+    const totalChecks = checksArray.length;
+    const complianceScore = passedCount / totalChecks * 100;
+    this.log(
+      `MCP Compliance: ${passedCount}/${totalChecks} checks passed (${complianceScore.toFixed(1)}%)`
+    );
     let status;
     if (!protocolChecks.serverInfoValidity.passed) {
       status = "FAIL";
@@ -48388,13 +48417,17 @@ class MCPSpecComplianceAssessor extends BaseAssessor {
   }
   /**
    * Check JSON-RPC 2.0 compliance
+   * A proper JSON-RPC response should have the correct structure even for errors.
    */
   async checkJsonRpcCompliance(callTool) {
     try {
       const result = await callTool("list", {});
-      return { passed: result !== null, rawResponse: result };
+      const hasValidStructure = result !== null && (Array.isArray(result.content) || result.isError !== void 0);
+      return { passed: hasValidStructure, rawResponse: result };
     } catch (error) {
-      return { passed: true, rawResponse: error };
+      const errorMessage = error instanceof Error ? error.message : String(error);
+      const isStructuredError = errorMessage.includes("MCP error") || errorMessage.includes("jsonrpc") || errorMessage.includes("-32");
+      return { passed: isStructuredError, rawResponse: error };
     }
   }
   /**
@@ -48455,6 +48488,7 @@ class MCPSpecComplianceAssessor extends BaseAssessor {
   }
   /**
    * Check error response compliance
+   * Validates that the server returns proper error responses for invalid inputs.
    */
   async checkErrorResponses(tools, callTool) {
     try {
@@ -48463,9 +48497,14 @@ class MCPSpecComplianceAssessor extends BaseAssessor {
       const testTool = tools[0];
       try {
         const result = await callTool(testTool.name, { invalid_param: "test" });
-        return { passed: true, rawResponse: result };
+        const isErrorResponse = result.isError === true;
+        const hasContent = Array.isArray(result.content);
+        const passed = isErrorResponse && hasContent || !isErrorResponse && hasContent;
+        return { passed, rawResponse: result };
       } catch (error) {
-        return { passed: true, rawResponse: error };
+        const errorMessage = error instanceof Error ? error.message : String(error);
+        const isStructuredError = errorMessage.includes("MCP error") || errorMessage.includes("-32") || errorMessage.includes("jsonrpc");
+        return { passed: isStructuredError, rawResponse: error };
       }
     } catch (error) {
       return { passed: false, rawResponse: error };
@@ -49373,13 +49412,7 @@ class ResponseValidator {
     let outputSchemaValidation;
     const toolHasOutputSchema = hasOutputSchema(context.tool.name);
     if (toolHasOutputSchema) {
-      if (!hasStructuredContent) {
-        outputSchemaValidation = {
-          hasOutputSchema: true,
-          isValid: false,
-          error: "Tool has output schema but did not return structuredContent"
-        };
-      } else {
+      if (hasStructuredContent) {
         const validation2 = validateToolOutput(
           context.tool.name,
           response.structuredContent
@@ -49389,6 +49422,27 @@ class ResponseValidator {
           isValid: validation2.isValid,
           error: validation2.error
         };
+      } else {
+        const extractedJson = tryExtractJsonFromContent(
+          content || []
+        );
+        if (extractedJson !== null) {
+          const validation2 = validateToolOutput(
+            context.tool.name,
+            extractedJson
+          );
+          outputSchemaValidation = {
+            hasOutputSchema: true,
+            isValid: validation2.isValid,
+            error: validation2.error
+          };
+        } else {
+          outputSchemaValidation = {
+            hasOutputSchema: true,
+            isValid: false,
+            error: "Tool has output schema but response contains no valid JSON"
+          };
+        }
       }
     }
     return {
@@ -49647,9 +49701,10 @@ class ResponseValidator {
     );
     const toolName = context.tool.name.toLowerCase();
     const isValidationExpected = (
-      // CRUD operations
-      toolName.includes("create") || toolName.includes("update") || toolName.includes("delete") || toolName.includes("get") || toolName.includes("fetch") || toolName.includes("read") || toolName.includes("write") || // Data operations
-      toolName.includes("query") || toolName.includes("search") || toolName.includes("find") || toolName.includes("list") || // State operations
+      // CRUD operations (including add/remove variants)
+      toolName.includes("create") || toolName.includes("add") || toolName.includes("insert") || toolName.includes("update") || toolName.includes("modify") || toolName.includes("set") || toolName.includes("delete") || toolName.includes("remove") || toolName.includes("get") || toolName.includes("fetch") || toolName.includes("read") || toolName.includes("write") || // Data operations
+      toolName.includes("query") || toolName.includes("search") || toolName.includes("find") || toolName.includes("list") || // Entity/resource operations (knowledge graphs, databases)
+      toolName.includes("entity") || toolName.includes("entities") || toolName.includes("relation") || toolName.includes("observation") || toolName.includes("node") || toolName.includes("edge") || toolName.includes("record") || // State operations
       toolName.includes("move") || toolName.includes("copy") || toolName.includes("duplicate") || toolName.includes("archive") || // Relationship operations
       toolName.includes("link") || toolName.includes("associate") || toolName.includes("connect") || toolName.includes("attach") || // API/scraping operations
       toolName.includes("scrape") || toolName.includes("crawl") || toolName.includes("map") || toolName.includes("extract") || toolName.includes("parse") || toolName.includes("analyze") || toolName.includes("process")
@@ -59102,13 +59157,13 @@ const App = () => {
   ) });
   if (window.location.pathname === "/oauth/callback") {
     const OAuthCallback = React.lazy(
-      () => __vitePreload(() => import("./OAuthCallback-B2AjbBqS.js"), true ? [] : void 0)
+      () => __vitePreload(() => import("./OAuthCallback-ByUGVYdZ.js"), true ? [] : void 0)
     );
     return /* @__PURE__ */ jsxRuntimeExports.jsx(reactExports.Suspense, { fallback: /* @__PURE__ */ jsxRuntimeExports.jsx("div", { children: "Loading..." }), children: /* @__PURE__ */ jsxRuntimeExports.jsx(OAuthCallback, { onConnect: onOAuthConnect }) });
   }
   if (window.location.pathname === "/oauth/callback/debug") {
     const OAuthDebugCallback = React.lazy(
-      () => __vitePreload(() => import("./OAuthDebugCallback-B3UFm4SC.js"), true ? [] : void 0)
+      () => __vitePreload(() => import("./OAuthDebugCallback-D1soBtsd.js"), true ? [] : void 0)
     );
     return /* @__PURE__ */ jsxRuntimeExports.jsx(reactExports.Suspense, { fallback: /* @__PURE__ */ jsxRuntimeExports.jsx("div", { children: "Loading..." }), children: /* @__PURE__ */ jsxRuntimeExports.jsx(OAuthDebugCallback, { onConnect: onOAuthDebugConnect }) });
   }

package/dist/assets/{index-32-uLPhe.css → index-DiyPO_Zj.css}

@@ -956,6 +956,9 @@ video {
   -webkit-box-orient: vertical;
   -webkit-line-clamp: 2;
 }
+.\!block {
+  display: block !important;
+}
 .block {
   display: block;
 }

package/dist/index.html

@@ -5,8 +5,8 @@
     <link rel="icon" type="image/svg+xml" href="/mcp.svg" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>MCP Inspector</title>
-    <script type="module" crossorigin src="/assets/index-i29GUqYn.js"></script>
-    <link rel="stylesheet" crossorigin href="/assets/index-32-uLPhe.css">
+    <script type="module" crossorigin src="/assets/index-CY09KxrR.js"></script>
+    <link rel="stylesheet" crossorigin href="/assets/index-DiyPO_Zj.css">
   </head>
   <body>
     <div id="root" class="w-full"></div>

package/lib/services/assessment/ResponseValidator.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ResponseValidator.d.ts","sourceRoot":"","sources":["../../../src/services/assessment/ResponseValidator.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EACL,2BAA2B,EAC3B,IAAI,EACL,MAAM,oCAAoC,CAAC;AAC5C,OAAO,EAAE,gBAAgB,EAAE,MAAM,uBAAuB,CAAC;AAGzD,MAAM,WAAW,gBAAgB;IAC/B,OAAO,EAAE,OAAO,CAAC;IACjB,OAAO,EAAE,OAAO,CAAC;IACjB,UAAU,EAAE,MAAM,CAAC;IACnB,MAAM,EAAE,MAAM,EAAE,CAAC;IACjB,QAAQ,EAAE,MAAM,EAAE,CAAC;IACnB,cAAc,EACV,eAAe,GACf,mBAAmB,GACnB,mBAAmB,GACnB,QAAQ,GACR,OAAO,CAAC;IACZ,8EAA8E;IAC9E,gBAAgB,CAAC,EAAE,gBAAgB,CAAC;CACrC;AAED,MAAM,WAAW,iBAAiB;IAChC,IAAI,EAAE,IAAI,CAAC;IACX,KAAK,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IAC/B,QAAQ,EAAE,2BAA2B,CAAC;IACtC,gBAAgB,CAAC,EAAE,YAAY,GAAG,WAAW,GAAG,UAAU,GAAG,YAAY,CAAC;CAC3E;AAED,qBAAa,iBAAiB;IAC5B;;OAEG;IACH,MAAM,CAAC,uBAAuB,CAAC,OAAO,EAAE,iBAAiB,GAAG,gBAAgB;IA8E5E;;OAEG;IACH,MAAM,CAAC,gBAAgB,CAAC,OAAO,EAAE,iBAAiB,GAAG,gBAAgB;IAgHrE;;;OAGG;IACH,MAAM,CAAC,oBAAoB,CAAC,OAAO,EAAE,iBAAiB,GAAG,OAAO;IAmShE;;OAEG;IACH,MAAM,CAAC,0BAA0B,CAAC,OAAO,EAAE,gBAAgB,EAAE,GAAG,MAAM;CAsBvE"}
+{"version":3,"file":"ResponseValidator.d.ts","sourceRoot":"","sources":["../../../src/services/assessment/ResponseValidator.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EACL,2BAA2B,EAC3B,IAAI,EACL,MAAM,oCAAoC,CAAC;AAC5C,OAAO,EAAE,gBAAgB,EAAE,MAAM,uBAAuB,CAAC;AAOzD,MAAM,WAAW,gBAAgB;IAC/B,OAAO,EAAE,OAAO,CAAC;IACjB,OAAO,EAAE,OAAO,CAAC;IACjB,UAAU,EAAE,MAAM,CAAC;IACnB,MAAM,EAAE,MAAM,EAAE,CAAC;IACjB,QAAQ,EAAE,MAAM,EAAE,CAAC;IACnB,cAAc,EACV,eAAe,GACf,mBAAmB,GACnB,mBAAmB,GACnB,QAAQ,GACR,OAAO,CAAC;IACZ,8EAA8E;IAC9E,gBAAgB,CAAC,EAAE,gBAAgB,CAAC;CACrC;AAED,MAAM,WAAW,iBAAiB;IAChC,IAAI,EAAE,IAAI,CAAC;IACX,KAAK,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;IAC/B,QAAQ,EAAE,2BAA2B,CAAC;IACtC,gBAAgB,CAAC,EAAE,YAAY,GAAG,WAAW,GAAG,UAAU,GAAG,YAAY,CAAC;CAC3E;AAED,qBAAa,iBAAiB;IAC5B;;OAEG;IACH,MAAM,CAAC,uBAAuB,CAAC,OAAO,EAAE,iBAAiB,GAAG,gBAAgB;IAoG5E;;OAEG;IACH,MAAM,CAAC,gBAAgB,CAAC,OAAO,EAAE,iBAAiB,GAAG,gBAAgB;IAgHrE;;;OAGG;IACH,MAAM,CAAC,oBAAoB,CAAC,OAAO,EAAE,iBAAiB,GAAG,OAAO;IAgThE;;OAEG;IACH,MAAM,CAAC,0BAA0B,CAAC,OAAO,EAAE,gBAAgB,EAAE,GAAG,MAAM;CAsBvE"}

package/lib/services/assessment/ResponseValidator.js

@@ -2,7 +2,7 @@
  * Response Validator for MCP Tool Testing
  * Validates that tool responses are actually functional, not just present
  */
-import { validateToolOutput, hasOutputSchema } from "../../utils/schemaUtils.js";
+import { validateToolOutput, hasOutputSchema, tryExtractJsonFromContent, } from "../../utils/schemaUtils.js";
 export class ResponseValidator {
     /**
      * Extract response metadata including content types, structuredContent, and _meta
@@ -45,14 +45,8 @@ export class ResponseValidator {
         let outputSchemaValidation;
         const toolHasOutputSchema = hasOutputSchema(context.tool.name);
         if (toolHasOutputSchema) {
-            if (!hasStructuredContent) {
-                outputSchemaValidation = {
-                    hasOutputSchema: true,
-                    isValid: false,
-                    error: "Tool has output schema but did not return structuredContent",
-                };
-            }
-            else {
+            if (hasStructuredContent) {
+                // Primary path: validate structuredContent
                 const validation = validateToolOutput(context.tool.name, response.structuredContent);
                 outputSchemaValidation = {
                     hasOutputSchema: true,
@@ -60,6 +54,26 @@ export class ResponseValidator {
                     error: validation.error,
                 };
             }
+            else {
+                // Fallback: try to extract JSON from content[] text blocks
+                // MCP allows tools to return valid JSON in standard content blocks
+                const extractedJson = tryExtractJsonFromContent(content || []);
+                if (extractedJson !== null) {
+                    const validation = validateToolOutput(context.tool.name, extractedJson);
+                    outputSchemaValidation = {
+                        hasOutputSchema: true,
+                        isValid: validation.isValid,
+                        error: validation.error,
+                    };
+                }
+                else {
+                    outputSchemaValidation = {
+                        hasOutputSchema: true,
+                        isValid: false,
+                        error: "Tool has output schema but response contains no valid JSON",
+                    };
+                }
+            }
         }
         return {
             contentTypes,
@@ -330,10 +344,15 @@ export class ResponseValidator {
         // Check tool operation type - resource operations are expected to validate
         const toolName = context.tool.name.toLowerCase();
         const isValidationExpected = 
-        // CRUD operations
+        // CRUD operations (including add/remove variants)
         toolName.includes("create") ||
+            toolName.includes("add") ||
+            toolName.includes("insert") ||
             toolName.includes("update") ||
+            toolName.includes("modify") ||
+            toolName.includes("set") ||
             toolName.includes("delete") ||
+            toolName.includes("remove") ||
             toolName.includes("get") ||
             toolName.includes("fetch") ||
             toolName.includes("read") ||
@@ -343,6 +362,14 @@ export class ResponseValidator {
             toolName.includes("search") ||
             toolName.includes("find") ||
             toolName.includes("list") ||
+            // Entity/resource operations (knowledge graphs, databases)
+            toolName.includes("entity") ||
+            toolName.includes("entities") ||
+            toolName.includes("relation") ||
+            toolName.includes("observation") ||
+            toolName.includes("node") ||
+            toolName.includes("edge") ||
+            toolName.includes("record") ||
             // State operations
             toolName.includes("move") ||
             toolName.includes("copy") ||

package/lib/services/assessment/modules/MCPSpecComplianceAssessor.d.ts

@@ -19,6 +19,7 @@ export declare class MCPSpecComplianceAssessor extends BaseAssessor {
     private extractProtocolVersion;
     /**
      * Check JSON-RPC 2.0 compliance
+     * A proper JSON-RPC response should have the correct structure even for errors.
      */
     private checkJsonRpcCompliance;
     /**
@@ -31,6 +32,7 @@ export declare class MCPSpecComplianceAssessor extends BaseAssessor {
     private checkSchemaCompliance;
     /**
      * Check error response compliance
+     * Validates that the server returns proper error responses for invalid inputs.
      */
     private checkErrorResponses;
     /**

package/lib/services/assessment/modules/MCPSpecComplianceAssessor.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"MCPSpecComplianceAssessor.d.ts","sourceRoot":"","sources":["../../../../src/services/assessment/modules/MCPSpecComplianceAssessor.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EACL,2BAA2B,EAM3B,uBAAuB,EAGxB,MAAM,uBAAuB,CAAC;AAO/B,OAAO,EAAE,YAAY,EAAE,MAAM,gBAAgB,CAAC;AAC9C,OAAO,EAAE,iBAAiB,EAAE,MAAM,2BAA2B,CAAC;AAE9D,qBAAa,yBAA0B,SAAQ,YAAY;IACzD,OAAO,CAAC,GAAG,CAAc;gBAEb,MAAM,EAAE,uBAAuB;IAK3C;;;OAGG;IACG,MAAM,CACV,OAAO,EAAE,iBAAiB,GACzB,OAAO,CAAC,2BAA2B,CAAC;IA6GvC;;OAEG;IACH,OAAO,CAAC,sBAAsB;IAwB9B;;OAEG;YACW,sBAAsB;IAkBpC;;OAEG;IACH,OAAO,CAAC,uBAAuB;IAyB/B;;OAEG;IACH,OAAO,CAAC,qBAAqB;IAyC7B;;OAEG;YACW,mBAAmB;IAwBjC;;OAEG;IACH,OAAO,CAAC,4BAA4B;IAiBpC;;;OAGG;IACH,OAAO,CAAC,2BAA2B;IA0FnC;;OAEG;IACH,OAAO,CAAC,yBAAyB;IAyFjC;;OAEG;IACH,OAAO,CAAC,uBAAuB;IAsB/B;;OAEG;IACH,OAAO,CAAC,sBAAsB;IA4B9B;;OAEG;IACH,OAAO,CAAC,qBAAqB;IA2C7B;;;OAGG;IACH,OAAO,CAAC,oBAAoB;IAoF5B;;OAEG;IACH,OAAO,CAAC,yBAAyB;IAyBjC;;OAEG;IACH,OAAO,CAAC,6BAA6B;CA0DtC"}
+{"version":3,"file":"MCPSpecComplianceAssessor.d.ts","sourceRoot":"","sources":["../../../../src/services/assessment/modules/MCPSpecComplianceAssessor.ts"],"names":[],"mappings":"AAAA;;;GAGG;AAEH,OAAO,EACL,2BAA2B,EAM3B,uBAAuB,EAGxB,MAAM,uBAAuB,CAAC;AAO/B,OAAO,EAAE,YAAY,EAAE,MAAM,gBAAgB,CAAC;AAC9C,OAAO,EAAE,iBAAiB,EAAE,MAAM,2BAA2B,CAAC;AAE9D,qBAAa,yBAA0B,SAAQ,YAAY;IACzD,OAAO,CAAC,GAAG,CAAc;gBAEb,MAAM,EAAE,uBAAuB;IAK3C;;;OAGG;IACG,MAAM,CACV,OAAO,EAAE,iBAAiB,GACzB,OAAO,CAAC,2BAA2B,CAAC;IAmHvC;;OAEG;IACH,OAAO,CAAC,sBAAsB;IAwB9B;;;OAGG;YACW,sBAAsB;IA6BpC;;OAEG;IACH,OAAO,CAAC,uBAAuB;IAyB/B;;OAEG;IACH,OAAO,CAAC,qBAAqB;IAyC7B;;;OAGG;YACW,mBAAmB;IAsCjC;;OAEG;IACH,OAAO,CAAC,4BAA4B;IAiBpC;;;OAGG;IACH,OAAO,CAAC,2BAA2B;IA0FnC;;OAEG;IACH,OAAO,CAAC,yBAAyB;IAyFjC;;OAEG;IACH,OAAO,CAAC,uBAAuB;IAsB/B;;OAEG;IACH,OAAO,CAAC,sBAAsB;IA4B9B;;OAEG;IACH,OAAO,CAAC,qBAAqB;IA2C7B;;;OAGG;IACH,OAAO,CAAC,oBAAoB;IAoF5B;;OAEG;IACH,OAAO,CAAC,yBAAyB;IAyBjC;;OAEG;IACH,OAAO,CAAC,6BAA6B;CA0DtC"}

package/lib/services/assessment/modules/MCPSpecComplianceAssessor.js

@@ -74,7 +74,10 @@ export class MCPSpecComplianceAssessor extends BaseAssessor {
         // Calculate score based ONLY on protocol checks (reliable)
         const checksArray = Object.values(protocolChecks);
         const passedCount = checksArray.filter((c) => c.passed).length;
-        const complianceScore = (passedCount / checksArray.length) * 100;
+        const totalChecks = checksArray.length;
+        const complianceScore = (passedCount / totalChecks) * 100;
+        // Log score/check consistency for debugging
+        this.log(`MCP Compliance: ${passedCount}/${totalChecks} checks passed (${complianceScore.toFixed(1)}%)`);
         // Determine status based on protocol checks only
         let status;
         if (!protocolChecks.serverInfoValidity.passed) {
@@ -133,18 +136,27 @@ export class MCPSpecComplianceAssessor extends BaseAssessor {
     }
     /**
      * Check JSON-RPC 2.0 compliance
+     * A proper JSON-RPC response should have the correct structure even for errors.
      */
     async checkJsonRpcCompliance(callTool) {
         try {
             // Test basic JSON-RPC structure by making a simple call
             // If we can call any tool, JSON-RPC is working
             const result = await callTool("list", {});
-            return { passed: result !== null, rawResponse: result };
+            // Check if result has valid structure (content array or isError flag)
+            const hasValidStructure = result !== null &&
+                (Array.isArray(result.content) || result.isError !== undefined);
+            return { passed: hasValidStructure, rawResponse: result };
         }
         catch (error) {
-            // If call fails, that's actually expected for many tools
-            // The fact that we got a structured response means JSON-RPC works
-            return { passed: true, rawResponse: error };
+            // If we get a structured error with proper JSON-RPC format, that's still valid
+            // But if it's a raw exception, JSON-RPC compliance failed
+            const errorMessage = error instanceof Error ? error.message : String(error);
+            // Structured MCP errors indicate JSON-RPC is working
+            const isStructuredError = errorMessage.includes("MCP error") ||
+                errorMessage.includes("jsonrpc") ||
+                errorMessage.includes("-32");
+            return { passed: isStructuredError, rawResponse: error };
         }
     }
     /**
@@ -208,6 +220,7 @@ export class MCPSpecComplianceAssessor extends BaseAssessor {
     }
     /**
      * Check error response compliance
+     * Validates that the server returns proper error responses for invalid inputs.
      */
     async checkErrorResponses(tools, callTool) {
         try {
@@ -217,10 +230,21 @@ export class MCPSpecComplianceAssessor extends BaseAssessor {
             const testTool = tools[0];
             try {
                 const result = await callTool(testTool.name, { invalid_param: "test" });
-                return { passed: true, rawResponse: result }; // Server handled gracefully
+                // Server returned a result - check if it's a proper error response
+                // or if it gracefully handled the invalid input
+                const isErrorResponse = result.isError === true;
+                const hasContent = Array.isArray(result.content);
+                // Pass if: it's marked as error with proper structure, OR it handled gracefully with content
+                const passed = (isErrorResponse && hasContent) || (!isErrorResponse && hasContent);
+                return { passed, rawResponse: result };
             }
             catch (error) {
-                return { passed: true, rawResponse: error }; // Server provided error response
+                // Check if the error is a structured MCP error (proper error handling)
+                const errorMessage = error instanceof Error ? error.message : String(error);
+                const isStructuredError = errorMessage.includes("MCP error") ||
+                    errorMessage.includes("-32") ||
+                    errorMessage.includes("jsonrpc");
+                return { passed: isStructuredError, rawResponse: error };
             }
         }
         catch (error) {

package/lib/services/assessment/modules/ToolAnnotationAssessor.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ToolAnnotationAssessor.d.ts","sourceRoot":"","sources":["../../../../src/services/assessment/modules/ToolAnnotationAssessor.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;GAWG;AAEH,OAAO,EAAE,YAAY,EAAE,MAAM,gBAAgB,CAAC;AAC9C,OAAO,EAAE,iBAAiB,EAAE,MAAM,2BAA2B,CAAC;AAC9D,OAAO,KAAK,EACV,wBAAwB,EACxB,oBAAoB,EAKpB,uBAAuB,EAExB,MAAM,uBAAuB,CAAC;AAE/B,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAChE,OAAO,EACL,KAAK,gBAAgB,EACrB,KAAK,wBAAwB,EAK9B,MAAM,8BAA8B,CAAC;AAmNtC;;GAEG;AACH,MAAM,WAAW,4BAA6B,SAAQ,oBAAoB;IACxE,eAAe,CAAC,EAAE;QAChB,gBAAgB,EAAE,OAAO,CAAC;QAC1B,mBAAmB,EAAE,OAAO,CAAC;QAC7B,UAAU,EAAE,MAAM,CAAC;QACnB,SAAS,EAAE,MAAM,CAAC;QAClB,oBAAoB,EAAE;YACpB,YAAY,CAAC,EAAE,OAAO,CAAC;YACvB,eAAe,CAAC,EAAE,OAAO,CAAC;YAC1B,cAAc,CAAC,EAAE,OAAO,CAAC;SAC1B,CAAC;QACF,oBAAoB,EAAE,OAAO,CAAC;QAC9B,mBAAmB,CAAC,EAAE,MAAM,CAAC;QAC7B,MAAM,EAAE,iBAAiB,GAAG,eAAe,CAAC;KAC7C,CAAC;CACH;AAED;;GAEG;AACH,MAAM,WAAW,gCAAiC,SAAQ,wBAAwB;IAChF,WAAW,EAAE,4BAA4B,EAAE,CAAC;IAC5C,cAAc,EAAE,OAAO,CAAC;IACxB,2BAA2B,EAAE,4BAA4B,EAAE,CAAC;CAC7D;AAKD,qBAAa,sBAAuB,SAAQ,YAAY;IACtD,OAAO,CAAC,YAAY,CAAC,CAAmB;IACxC,OAAO,CAAC,gBAAgB,CAAmB;IAC3C,OAAO,CAAC,kBAAkB,CAAC,CAA2B;gBAE1C,MAAM,EAAE,uBAAuB;IAM3C;;OAEG;IACH,qBAAqB,IAAI,wBAAwB,GAAG,SAAS;IAI7D;;OAEG;IACH,WAAW,CAAC,QAAQ,EAAE,gBAAgB,GAAG,IAAI;IAK7C;;OAEG;IACH,eAAe,CAAC,MAAM,EAAE,gBAAgB,GAAG,IAAI;IAK/C;;OAEG;IACH,eAAe,IAAI,OAAO;IAO1B;;OAEG;IACG,MAAM,CACV,OAAO,EAAE,iBAAiB,GACzB,OAAO,CAAC,wBAAwB,GAAG,gCAAgC,CAAC;IA4SvE;;OAEG;YACW,0BAA0B;IA+IxC;;OAEG;IACH,OAAO,CAAC,2BAA2B;IAiCnC;;OAEG;IACH,OAAO,CAAC,+BAA+B;IAoFvC;;;OAGG;IACH,OAAO,CAAC,UAAU;IA2HlB;;;OAGG;IACH,OAAO,CAAC,2BAA2B;IA2DnC;;;;;;;;;OASG;IACH,OAAO,CAAC,kBAAkB;IAyE1B;;OAEG;IACH,OAAO,CAAC,iBAAiB;IAuBzB;;;OAGG;IACH,OAAO,CAAC,aAAa;IAoJrB;;;OAGG;IACH,OAAO,CAAC,yBAAyB;IA0DjC;;OAEG;IACH,OAAO,CAAC,gBAAgB;IAiDxB;;OAEG;IACH,OAAO,CAAC,mBAAmB;IAmC3B;;OAEG;IACH,OAAO,CAAC,uBAAuB;CA2ChC"}
+{"version":3,"file":"ToolAnnotationAssessor.d.ts","sourceRoot":"","sources":["../../../../src/services/assessment/modules/ToolAnnotationAssessor.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;GAWG;AAEH,OAAO,EAAE,YAAY,EAAE,MAAM,gBAAgB,CAAC;AAC9C,OAAO,EAAE,iBAAiB,EAAE,MAAM,2BAA2B,CAAC;AAC9D,OAAO,KAAK,EACV,wBAAwB,EACxB,oBAAoB,EAKpB,uBAAuB,EAExB,MAAM,uBAAuB,CAAC;AAE/B,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAC;AAChE,OAAO,EACL,KAAK,gBAAgB,EACrB,KAAK,wBAAwB,EAK9B,MAAM,8BAA8B,CAAC;AAmNtC;;GAEG;AACH,MAAM,WAAW,4BAA6B,SAAQ,oBAAoB;IACxE,eAAe,CAAC,EAAE;QAChB,gBAAgB,EAAE,OAAO,CAAC;QAC1B,mBAAmB,EAAE,OAAO,CAAC;QAC7B,UAAU,EAAE,MAAM,CAAC;QACnB,SAAS,EAAE,MAAM,CAAC;QAClB,oBAAoB,EAAE;YACpB,YAAY,CAAC,EAAE,OAAO,CAAC;YACvB,eAAe,CAAC,EAAE,OAAO,CAAC;YAC1B,cAAc,CAAC,EAAE,OAAO,CAAC;SAC1B,CAAC;QACF,oBAAoB,EAAE,OAAO,CAAC;QAC9B,mBAAmB,CAAC,EAAE,MAAM,CAAC;QAC7B,MAAM,EAAE,iBAAiB,GAAG,eAAe,CAAC;KAC7C,CAAC;CACH;AAED;;GAEG;AACH,MAAM,WAAW,gCAAiC,SAAQ,wBAAwB;IAChF,WAAW,EAAE,4BAA4B,EAAE,CAAC;IAC5C,cAAc,EAAE,OAAO,CAAC;IACxB,2BAA2B,EAAE,4BAA4B,EAAE,CAAC;CAC7D;AAKD,qBAAa,sBAAuB,SAAQ,YAAY;IACtD,OAAO,CAAC,YAAY,CAAC,CAAmB;IACxC,OAAO,CAAC,gBAAgB,CAAmB;IAC3C,OAAO,CAAC,kBAAkB,CAAC,CAA2B;gBAE1C,MAAM,EAAE,uBAAuB;IAM3C;;OAEG;IACH,qBAAqB,IAAI,wBAAwB,GAAG,SAAS;IAI7D;;OAEG;IACH,WAAW,CAAC,QAAQ,EAAE,gBAAgB,GAAG,IAAI;IAK7C;;OAEG;IACH,eAAe,CAAC,MAAM,EAAE,gBAAgB,GAAG,IAAI;IAK/C;;OAEG;IACH,eAAe,IAAI,OAAO;IAO1B;;OAEG;IACG,MAAM,CACV,OAAO,EAAE,iBAAiB,GACzB,OAAO,CAAC,wBAAwB,GAAG,gCAAgC,CAAC;IA4SvE;;OAEG;YACW,0BAA0B;IA+IxC;;OAEG;IACH,OAAO,CAAC,2BAA2B;IAiCnC;;OAEG;IACH,OAAO,CAAC,+BAA+B;IAoFvC;;;OAGG;IACH,OAAO,CAAC,UAAU;IA2HlB;;;OAGG;IACH,OAAO,CAAC,2BAA2B;IA2DnC;;;;;;;;;OASG;IACH,OAAO,CAAC,kBAAkB;IAyE1B;;OAEG;IACH,OAAO,CAAC,iBAAiB;IAuBzB;;;OAGG;IACH,OAAO,CAAC,aAAa;IAkKrB;;;OAGG;IACH,OAAO,CAAC,yBAAyB;IA0DjC;;OAEG;IACH,OAAO,CAAC,gBAAgB;IAiDxB;;OAEG;IACH,OAAO,CAAC,mBAAmB;IAmC3B;;OAEG;IACH,OAAO,CAAC,uBAAuB;CA2ChC"}

package/lib/services/assessment/modules/ToolAnnotationAssessor.js

@@ -916,8 +916,20 @@ export class ToolAnnotationAssessor extends BaseAssessor {
                     isAmbiguous: false,
                 };
             case "write": {
-                // Three-Tier Classification: Check persistence model for write operations
-                // If immediate persistence detected, write operations should be marked destructive
+                // CREATE operations are NEVER destructive - they only ADD new data
+                // Only UPDATE/MODIFY operations can be considered destructive when they modify existing data
+                const isCreateOperation = /^(create|add|insert|new|generate)[_-]/i.test(toolName);
+                if (isCreateOperation) {
+                    return {
+                        expectedReadOnly: false,
+                        expectedDestructive: false,
+                        reason: `Tool name matches create pattern: ${patternMatch.pattern} - create operations only add data and are not destructive`,
+                        confidence: "high",
+                        isAmbiguous: false,
+                    };
+                }
+                // Three-Tier Classification: Check persistence model for UPDATE/MODIFY operations
+                // If immediate persistence detected, update operations should be marked destructive
                 const descriptionCheck = checkDescriptionForImmediatePersistence(description || "");
                 // Priority 1: Description explicitly indicates deferred persistence
                 if (descriptionCheck.indicatesDeferred) {

package/lib/utils/schemaUtils.d.ts

@@ -31,6 +31,19 @@ export declare function validateToolOutput(toolName: string, structuredContent:
  * @returns true if the tool has an output schema
  */
 export declare function hasOutputSchema(toolName: string): boolean;
+/**
+ * Attempts to extract JSON from content[] text blocks.
+ * Used as fallback when structuredContent is not present.
+ * MCP allows tools to return valid JSON in standard content blocks
+ * even when they define an outputSchema.
+ * @param content Array of content blocks from tool response
+ * @returns Parsed JSON object or null if no valid JSON found
+ */
+export declare function tryExtractJsonFromContent(content: Array<{
+    type: string;
+    text?: string;
+    [key: string]: unknown;
+}>): unknown | null;
 /**
  * Generates a default value based on a JSON schema type
  * @param schema The JSON schema definition

package/lib/utils/schemaUtils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"schemaUtils.d.ts","sourceRoot":"","sources":["../../src/utils/schemaUtils.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,SAAS,EAAE,cAAc,EAAc,MAAM,aAAa,CAAC;AAEzE,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,KAAK,CAAC;AAC5C,OAAO,KAAK,EAAE,IAAI,EAAE,cAAc,EAAE,MAAM,oCAAoC,CAAC;AAQ/E;;;;GAIG;AACH,wBAAgB,sBAAsB,CAAC,KAAK,EAAE,IAAI,EAAE,GAAG,IAAI,CAe1D;AAED;;;;;GAKG;AACH,wBAAgB,sBAAsB,CACpC,QAAQ,EAAE,MAAM,GACf,gBAAgB,GAAG,SAAS,CAE9B;AAED;;;;;;GAMG;AACH,wBAAgB,kBAAkB,CAChC,QAAQ,EAAE,MAAM,EAChB,iBAAiB,EAAE,OAAO,GACzB;IAAE,OAAO,EAAE,OAAO,CAAC;IAAC,KAAK,CAAC,EAAE,MAAM,CAAA;CAAE,CAetC;AAED;;;;GAIG;AACH,wBAAgB,eAAe,CAAC,QAAQ,EAAE,MAAM,GAAG,OAAO,CAEzD;AAED;;;;;;GAMG;AACH,wBAAgB,oBAAoB,CAClC,MAAM,EAAE,cAAc,EACtB,YAAY,CAAC,EAAE,MAAM,EACrB,YAAY,CAAC,EAAE,cAAc,GAC5B,SAAS,CAkDX;AAED;;;;;GAKG;AACH,wBAAgB,kBAAkB,CAChC,YAAY,EAAE,MAAM,EACpB,MAAM,EAAE,cAAc,GACrB,OAAO,CAET;AAED;;;;;GAKG;AACH,wBAAgB,UAAU,CACxB,MAAM,EAAE,cAAc,EACtB,UAAU,EAAE,cAAc,GACzB,cAAc,CAiChB;AAED;;;;GAIG;AACH,wBAAgB,kBAAkB,CAAC,MAAM,EAAE,cAAc,GAAG,cAAc,CA4FzE;AAED;;;;GAIG;AACH,wBAAgB,gBAAgB,CAAC,GAAG,EAAE,MAAM,GAAG,MAAM,CAKpD;AAED;;;;GAIG;AACH,wBAAgB,oBAAoB,CAAC,OAAO,EAAE,cAAc,GAAG,cAAc,CA+B5E"}
+{"version":3,"file":"schemaUtils.d.ts","sourceRoot":"","sources":["../../src/utils/schemaUtils.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,SAAS,EAAE,cAAc,EAAc,MAAM,aAAa,CAAC;AAEzE,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,KAAK,CAAC;AAC5C,OAAO,KAAK,EAAE,IAAI,EAAE,cAAc,EAAE,MAAM,oCAAoC,CAAC;AAQ/E;;;;GAIG;AACH,wBAAgB,sBAAsB,CAAC,KAAK,EAAE,IAAI,EAAE,GAAG,IAAI,CAe1D;AAED;;;;;GAKG;AACH,wBAAgB,sBAAsB,CACpC,QAAQ,EAAE,MAAM,GACf,gBAAgB,GAAG,SAAS,CAE9B;AAED;;;;;;GAMG;AACH,wBAAgB,kBAAkB,CAChC,QAAQ,EAAE,MAAM,EAChB,iBAAiB,EAAE,OAAO,GACzB;IAAE,OAAO,EAAE,OAAO,CAAC;IAAC,KAAK,CAAC,EAAE,MAAM,CAAA;CAAE,CAetC;AAED;;;;GAIG;AACH,wBAAgB,eAAe,CAAC,QAAQ,EAAE,MAAM,GAAG,OAAO,CAEzD;AAED;;;;;;;GAOG;AACH,wBAAgB,yBAAyB,CACvC,OAAO,EAAE,KAAK,CAAC;IAAE,IAAI,EAAE,MAAM,CAAC;IAAC,IAAI,CAAC,EAAE,MAAM,CAAC;IAAC,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAAA;CAAE,CAAC,GACtE,OAAO,GAAG,IAAI,CAgBhB;AAED;;;;;;GAMG;AACH,wBAAgB,oBAAoB,CAClC,MAAM,EAAE,cAAc,EACtB,YAAY,CAAC,EAAE,MAAM,EACrB,YAAY,CAAC,EAAE,cAAc,GAC5B,SAAS,CAkDX;AAED;;;;;GAKG;AACH,wBAAgB,kBAAkB,CAChC,YAAY,EAAE,MAAM,EACpB,MAAM,EAAE,cAAc,GACrB,OAAO,CAET;AAED;;;;;GAKG;AACH,wBAAgB,UAAU,CACxB,MAAM,EAAE,cAAc,EACtB,UAAU,EAAE,cAAc,GACzB,cAAc,CAiChB;AAED;;;;GAIG;AACH,wBAAgB,kBAAkB,CAAC,MAAM,EAAE,cAAc,GAAG,cAAc,CA4FzE;AAED;;;;GAIG;AACH,wBAAgB,gBAAgB,CAAC,GAAG,EAAE,MAAM,GAAG,MAAM,CAKpD;AAED;;;;GAIG;AACH,wBAAgB,oBAAoB,CAAC,OAAO,EAAE,cAAc,GAAG,cAAc,CA+B5E"}

package/lib/utils/schemaUtils.js

@@ -60,6 +60,31 @@ export function validateToolOutput(toolName, structuredContent) {
 export function hasOutputSchema(toolName) {
     return toolOutputValidators.has(toolName);
 }
+/**
+ * Attempts to extract JSON from content[] text blocks.
+ * Used as fallback when structuredContent is not present.
+ * MCP allows tools to return valid JSON in standard content blocks
+ * even when they define an outputSchema.
+ * @param content Array of content blocks from tool response
+ * @returns Parsed JSON object or null if no valid JSON found
+ */
+export function tryExtractJsonFromContent(content) {
+    if (!content || !Array.isArray(content)) {
+        return null;
+    }
+    const textBlocks = content.filter((block) => block.type === "text");
+    for (const block of textBlocks) {
+        if (!block.text)
+            continue;
+        try {
+            return JSON.parse(block.text);
+        }
+        catch {
+            continue;
+        }
+    }
+    return null;
+}
 /**
  * Generates a default value based on a JSON schema type
  * @param schema The JSON schema definition

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bryan-thompson/inspector-assessment-client",
-  "version": "1.19.3",
+  "version": "1.19.4",
   "description": "Client-side application for the Enhanced MCP Inspector with assessment capabilities",
   "license": "MIT",
   "author": "Bryan Thompson <bryan@triepod.ai>",