@bryan-thompson/inspector-assessment-client 1.12.0 → 1.13.0

package/lib/services/assessment/modules/ToolAnnotationAssessor.js

@@ -53,6 +53,13 @@ export class ToolAnnotationAssessor extends BaseAssessor {
         let annotatedCount = 0;
         let missingAnnotationsCount = 0;
         let misalignedAnnotationsCount = 0;
+        // Track annotation sources
+        const annotationSourceCounts = {
+            mcp: 0,
+            sourceCode: 0,
+            inferred: 0,
+            none: 0,
+        };
         const useClaudeInference = this.isClaudeEnabled();
         if (useClaudeInference) {
             this.log("Claude Code integration enabled - using semantic behavior inference");
@@ -106,7 +113,23 @@ export class ToolAnnotationAssessor extends BaseAssessor {
             }
             else {
                 missingAnnotationsCount++;
-                // Emit annotation_missing event with tool details
+            }
+            // Track annotation source
+            const source = latestResult.annotationSource;
+            if (source === "mcp") {
+                annotationSourceCounts.mcp++;
+            }
+            else if (source === "source-code") {
+                annotationSourceCounts.sourceCode++;
+            }
+            else if (source === "inferred") {
+                annotationSourceCounts.inferred++;
+            }
+            else {
+                annotationSourceCounts.none++;
+            }
+            // Emit annotation_missing event with tool details
+            if (!latestResult.hasAnnotations) {
                 if (context.onProgress && latestResult.inferredBehavior) {
                     const annotations = this.extractAnnotations(tool);
                     context.onProgress({
@@ -225,6 +248,7 @@ export class ToolAnnotationAssessor extends BaseAssessor {
                 recommendations: this.generateEnhancedRecommendations(toolResults),
                 metrics,
                 alignmentBreakdown,
+                annotationSources: annotationSourceCounts,
                 claudeEnhanced: true,
                 highConfidenceMisalignments,
             };
@@ -239,6 +263,7 @@ export class ToolAnnotationAssessor extends BaseAssessor {
             recommendations,
             metrics,
             alignmentBreakdown,
+            annotationSources: annotationSourceCounts,
         };
     }
     /**
@@ -495,6 +520,7 @@ export class ToolAnnotationAssessor extends BaseAssessor {
             toolName: tool.name,
             hasAnnotations,
             annotations: hasAnnotations ? annotations : undefined,
+            annotationSource: annotations.source,
             inferredBehavior,
             alignmentStatus,
             issues,
@@ -504,34 +530,65 @@ export class ToolAnnotationAssessor extends BaseAssessor {
     /**
      * Extract annotations from a tool
      * MCP SDK may have annotations in different locations
+     *
+     * Priority order:
+     * 1. tool.annotations (MCP 2024-11 spec) - "mcp" source
+     * 2. Direct properties on tool - "mcp" source
+     * 3. tool.metadata - "mcp" source
+     * 4. No annotations found - "none" source
      */
     extractAnnotations(tool) {
-        // Try to find annotations in various locations
         const toolAny = tool;
-        // Check direct properties
-        let readOnlyHint = toolAny.readOnlyHint;
-        let destructiveHint = toolAny.destructiveHint;
-        let idempotentHint = toolAny.idempotentHint;
-        let openWorldHint = toolAny.openWorldHint;
-        // Check annotations object (MCP 2024-11 spec)
+        // Priority 1: Check annotations object (MCP 2024-11 spec) - primary source
         if (toolAny.annotations) {
-            readOnlyHint = readOnlyHint ?? toolAny.annotations.readOnlyHint;
-            destructiveHint = destructiveHint ?? toolAny.annotations.destructiveHint;
-            idempotentHint = idempotentHint ?? toolAny.annotations.idempotentHint;
-            openWorldHint = openWorldHint ?? toolAny.annotations.openWorldHint;
+            const hasAnnotations = toolAny.annotations.readOnlyHint !== undefined ||
+                toolAny.annotations.destructiveHint !== undefined;
+            if (hasAnnotations) {
+                return {
+                    readOnlyHint: toolAny.annotations.readOnlyHint,
+                    destructiveHint: toolAny.annotations.destructiveHint,
+                    title: toolAny.annotations.title || toolAny.title,
+                    description: tool.description,
+                    idempotentHint: toolAny.annotations.idempotentHint,
+                    openWorldHint: toolAny.annotations.openWorldHint,
+                    source: "mcp",
+                };
+            }
+        }
+        // Priority 2: Check direct properties on tool object
+        if (toolAny.readOnlyHint !== undefined ||
+            toolAny.destructiveHint !== undefined) {
+            return {
+                readOnlyHint: toolAny.readOnlyHint,
+                destructiveHint: toolAny.destructiveHint,
+                title: toolAny.title,
+                description: tool.description,
+                idempotentHint: toolAny.idempotentHint,
+                openWorldHint: toolAny.openWorldHint,
+                source: "mcp",
+            };
         }
-        // Check metadata (some servers use this)
+        // Priority 3: Check metadata (some servers use this)
         if (toolAny.metadata) {
-            readOnlyHint = readOnlyHint ?? toolAny.metadata.readOnlyHint;
-            destructiveHint = destructiveHint ?? toolAny.metadata.destructiveHint;
+            const hasMetadataAnnotations = toolAny.metadata.readOnlyHint !== undefined ||
+                toolAny.metadata.destructiveHint !== undefined;
+            if (hasMetadataAnnotations) {
+                return {
+                    readOnlyHint: toolAny.metadata.readOnlyHint,
+                    destructiveHint: toolAny.metadata.destructiveHint,
+                    title: toolAny.metadata.title || toolAny.title,
+                    description: tool.description,
+                    idempotentHint: toolAny.metadata.idempotentHint,
+                    openWorldHint: toolAny.metadata.openWorldHint,
+                    source: "mcp",
+                };
+            }
         }
+        // No annotations found from MCP protocol
         return {
-            readOnlyHint,
-            destructiveHint,
-            title: toolAny.title || toolAny.annotations?.title,
+            title: toolAny.title,
             description: tool.description,
-            idempotentHint,
-            openWorldHint,
+            source: "none",
         };
     }
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bryan-thompson/inspector-assessment-client",
-  "version": "1.12.0",
+  "version": "1.13.0",
   "description": "Client-side application for the Enhanced MCP Inspector with assessment capabilities",
   "license": "MIT",
   "author": "Bryan Thompson <bryan@triepod.ai>",