@browserless/screenshot 13.8.3 → 13.9.2

package/README.md

@@ -25,7 +25,7 @@ npm install @browserless/screenshot --save
 
 This package provides **advanced screenshot capture** with smart defaults, browser frame overlays, gradient backgrounds, and automatic code syntax highlighting. It wraps Puppeteer's `page.screenshot()` with features optimized for production use.
 
-### What This Package Does
+### What this package does
 
 The `@browserless/screenshot` package allows you to:
 
@@ -323,7 +323,7 @@ const buffer = await browserless.screenshot('https://example.com', {
     └── index.js            → Tests
 ```
 
-### How It Fits in the Monorepo
+### How it fits in the monorepo
 
 This is a **core functionality package** for screenshot capture:
 
@@ -331,7 +331,7 @@ This is a **core functionality package** for screenshot capture:
 | -------------------- | ---------------------------------------------- |
 | `browserless` (core) | Provides the `.screenshot()` method            |
 | `@browserless/cli`   | Powers the `browserless screenshot` command    |
-| `@browserless/pdf`   | Uses `isWhiteScreenshot` for content detection |
+| `@browserless/pdf`   | Uses `waitForReady` and `isWhiteScreenshot` |
 
 ### Dependencies
 

package/package.json

@@ -2,7 +2,7 @@
   "name": "@browserless/screenshot",
   "description": "Capture high-quality screenshots of websites with overlay support, device emulation, and automated image optimization.",
   "homepage": "https://browserless.js.org/#/?id=screenshoturl-options",
-  "version": "13.8.3",
+  "version": "13.9.2",
   "main": "src/index.js",
   "author": {
     "email": "hello@microlink.io",
@@ -33,7 +33,7 @@
   ],
   "dependencies": {
     "@browserless/errors": "13.6.10",
-    "@browserless/goto": "13.8.3",
+    "@browserless/goto": "13.9.0",
     "@kikobeats/content-type": "~1.0.4",
     "@kikobeats/time-span": "~1.0.12",
     "automad-prism-themes": "~0.3.7",
@@ -70,5 +70,5 @@
     "timeout": "2m",
     "workerThreads": false
   },
-  "gitHead": "8914ca411458b6902e32f9c12f5780a7beea0e56"
+  "gitHead": "025ebb6f35fd65f3d92a36e1d5deaa7c080e404d"
 }

package/src/index.js

@@ -1,11 +1,11 @@
 'use strict'
 
 const debug = require('debug-logfmt')('browserless:screenshot')
-const { isContextDestroyed } = require('@browserless/errors')
 const createGoto = require('@browserless/goto')
 const { extname } = require('node:path')
 const pReflect = require('p-reflect')
 
+const isTransientContextLoss = require('./is-transient-context-loss')
 const isWhiteScreenshot = require('./is-white-screenshot')
 const waitForPrism = require('./pretty')
 const prettyTimeSpan = require('./time-span')
@@ -22,15 +22,22 @@ const {
 
 const timeSpan = require('@kikobeats/time-span')()
 
+// No pacing here on purpose: `waitUntilAuto` is a network-idle wait, which on a
+// live page costs at least its idle window (~500ms) and at most what is left of
+// the budget. The runaway case was never a fast loop — it was retrying a page
+// that was gone, where the wait returns instantly. Classify that and the loop
+// paces itself on real work.
 const captureWithNavigationRetry = async (capture, { page, goto, timeout }) => {
   const elapsed = timeSpan()
+  const remaining = () => timeout - elapsed()
   while (true) {
     try {
       return await capture()
     } catch (error) {
-      if (!isContextDestroyed(error) || elapsed() >= timeout) throw error
+      if (!isTransientContextLoss(page, error) || remaining() <= 0) throw error
       debug('captureWithNavigationRetry', { error: error.message })
-      await goto.waitUntilAuto(page, { timeout })
+      await goto.waitUntilAuto(page, { timeout: remaining() })
+      if (remaining() <= 0) throw error
     }
   }
 }

package/src/is-transient-context-loss.js

@@ -0,0 +1,17 @@
+'use strict'
+
+const { isContextDestroyed } = require('@browserless/errors')
+
+// Tells a frame torn down mid-flight (a client-side navigation, which settles
+// and retries fine) apart from a page we no longer have: once the page or its
+// session is closed — the request ended and its context was destroyed — nothing
+// it is waiting on can arrive, so waiting is spent on work nobody wants.
+//
+// `TargetCloseError` is puppeteer's own signal that the CDP session is detached
+// (`CdpSession.send` raises it the moment `detached` is set). Ask it as well as
+// the page: the session flips first, so between the two there is a window where
+// every call throws yet `isClosed()` still answers false.
+const isTransientContextLoss = (page, error) =>
+  isContextDestroyed(error) && error?.name !== 'TargetCloseError' && !page.isClosed()
+
+module.exports = isTransientContextLoss

package/src/prepare-full-document.js

@@ -95,6 +95,11 @@ const settleDom = async (page, { idle, timeout }, label) => {
   debug(label, { ...result, duration: Date.now() - started })
 }
 
+const isCompleteScroll = scroll =>
+  !!scroll?.hasOverflow &&
+  Number(scroll.pageHeight) > 0 &&
+  scroll.scrolledPx + (scroll.viewport || 0) >= scroll.pageHeight
+
 const scrollFullPageToLoadContent = async (page, timeout) => {
   const preQuiet = Math.min(PRE_QUIET_MS, Math.floor(timeout / 20))
   const postQuiet = Math.min(POST_QUIET_MS, Math.floor(timeout / 20))
@@ -183,7 +188,7 @@ const scrollFullPageToLoadContent = async (page, timeout) => {
     )
   }
 
-  const hydrated = !!(scroll?.hasOverflow && scroll.scrolledPx >= (scroll.viewport || 0))
+  const hydrated = isCompleteScroll(scroll)
   return { ...scroll, hydrated, duration: Date.now() - started }
 }
 
@@ -245,5 +250,6 @@ module.exports = {
   scrollFullPageToLoadContent,
   prepareFullDocument,
   resolveScrollTimeout,
-  tryHydrateScroll
+  tryHydrateScroll,
+  isCompleteScroll
 }

package/src/wait-for-ready.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const { setTimeout: sleep } = require('node:timers/promises')
-const { isContextDestroyed } = require('@browserless/errors')
+const isTransientContextLoss = require('./is-transient-context-loss')
 
 const DEFAULT_QUIET_MS = 300
 const DEFAULT_POLL_MS = 150
@@ -193,7 +193,7 @@ const waitForReady = async (
     try {
       signals = await page.evaluate(paintSignals)
     } catch (error) {
-      if (!isContextDestroyed(error)) throw error
+      if (!isTransientContextLoss(page, error)) throw error
       resets++
       lastHeight = -1
       quietSince = 0