@browserless/screenshot 10.1.13 → 10.1.14

package/package.json

@@ -2,7 +2,7 @@
   "name": "@browserless/screenshot",
   "description": "Take a clean screenshot of any website",
   "homepage": "https://browserless.js.org/#/?id=screenshoturl-options",
-  "version": "10.1.13",
+  "version": "10.1.14",
   "main": "src/index.js",
   "author": {
     "email": "hello@microlink.io",
@@ -28,7 +28,7 @@
     "screenshot"
   ],
   "dependencies": {
-    "@browserless/goto": "^10.1.13",
+    "@browserless/goto": "^10.1.14",
     "debug-logfmt": "~1.0.4",
     "got": "~11.8.6",
     "is-html-content": "~1.0.0",
@@ -44,7 +44,7 @@
     "time-span": "~4.0.0"
   },
   "devDependencies": {
-    "@browserless/test": "^10.1.13",
+    "@browserless/test": "^10.1.14",
     "ava": "latest",
     "cheerio": "latest"
   },
@@ -60,7 +60,7 @@
     "timeout": "2m",
     "workerThreads": false
   },
-  "gitHead": "fa7452351dd0afb48bccd6ca2a2712fd733a5d49",
+  "gitHead": "bd55f5fbe604d1eb925f6d192f12889baf9099cb",
   "scripts": {
     "coverage": "exit 0",
     "test": "ava"

package/src/index.js

@@ -19,18 +19,16 @@ const waitForImagesOnViewport = page =>
   page.$$eval('img[src]:not([aria-hidden="true"])', elements =>
     Promise.all(
       elements
-        .filter(
-          el => {
-            if (el.naturalHeight === 0 || el.naturalWeight === 0) return false
-            const { top, left, bottom, right } = el.getBoundingClientRect()
-            return (
-              top >= 0 &&
-              left >= 0 &&
-              bottom <= (window.innerHeight || document.documentElement.clientHeight) &&
-              right <= (window.innerWidth || document.documentElement.clientWidth)
-            )
-          }
-        )
+        .filter(el => {
+          if (el.naturalHeight === 0 || el.naturalWeight === 0) return false
+          const { top, left, bottom, right } = el.getBoundingClientRect()
+          return (
+            top >= 0 &&
+            left >= 0 &&
+            bottom <= (window.innerHeight || document.documentElement.clientHeight) &&
+            right <= (window.innerWidth || document.documentElement.clientWidth)
+          )
+        })
         .map(el => el.decode())
     )
   )
@@ -51,75 +49,76 @@ const waitForElement = async (page, element) => {
 module.exports = ({ goto, ...gotoOpts }) => {
   goto = goto || createGoto(gotoOpts)
 
-  return page => async (
-    url,
-    {
-      element,
-      codeScheme = 'atom-dark',
-      overlay: overlayOpts = {},
-      waitUntil = 'auto',
-      ...opts
-    } = {}
-  ) => {
-    let screenshot
-    let response
+  return page =>
+    async (
+      url,
+      {
+        element,
+        codeScheme = 'atom-dark',
+        overlay: overlayOpts = {},
+        waitUntil = 'auto',
+        ...opts
+      } = {}
+    ) => {
+      let screenshot
+      let response
 
-    const beforeScreenshot = response => {
-      const timeout = goto.timeouts.action(goto.timeouts.base(opts.timeout))
-      return Promise.all(
-        [
-          {
-            fn: () => page.evaluate('document.fonts.ready'),
-            debug: 'beforeScreenshot:fontsReady'
-          },
-          {
-            fn: () => waitForPrism(page, response, { codeScheme, ...opts }),
-            debug: 'beforeScreenshot:waitForPrism'
-          },
-          {
-            fn: () => waitForImagesOnViewport(page),
-            debug: 'beforeScreenshot:waitForImagesOnViewport'
-          }
-        ].map(({ fn, ...opts }) => goto.run({ fn: fn(), ...opts, timeout }))
-      )
-    }
+      const beforeScreenshot = response => {
+        const timeout = goto.timeouts.action(goto.timeouts.base(opts.timeout))
+        return Promise.all(
+          [
+            {
+              fn: () => page.evaluate('document.fonts.ready'),
+              debug: 'beforeScreenshot:fontsReady'
+            },
+            {
+              fn: () => waitForPrism(page, response, { codeScheme, ...opts }),
+              debug: 'beforeScreenshot:waitForPrism'
+            },
+            {
+              fn: () => waitForImagesOnViewport(page),
+              debug: 'beforeScreenshot:waitForImagesOnViewport'
+            }
+          ].map(({ fn, ...opts }) => goto.run({ fn: fn(), ...opts, timeout }))
+        )
+      }
 
-    const takeScreenshot = async opts => {
-      screenshot = await page.screenshot(opts)
-      const isWhite = await isWhiteScreenshot(screenshot)
-      if (isWhite) {
-        await goto.waitUntilAuto(page, opts)
+      const takeScreenshot = async opts => {
         screenshot = await page.screenshot(opts)
+        const isWhite = await isWhiteScreenshot(screenshot)
+        if (isWhite) {
+          await goto.waitUntilAuto(page, opts)
+          screenshot = await page.screenshot(opts)
+        }
+        return { isWhite }
       }
-      return { isWhite }
-    }
 
-    page.on('dialog', dialog => pReflect(dialog.dismiss()))
+      page.on('dialog', dialog => pReflect(dialog.dismiss()))
 
-    const timeScreenshot = timeSpan()
+      const timeScreenshot = timeSpan()
 
-    if (waitUntil !== 'auto') {
-      ;({ response } = await goto(page, { ...opts, url, waitUntil }))
-      const [screenshotOpts] = await Promise.all([
-        waitForElement(page, element),
-        beforeScreenshot(response)
-      ])
-      screenshot = await page.screenshot({ ...opts, ...screenshotOpts })
-      debug('screenshot', { waitUntil, duration: prettyMs(timeScreenshot()) })
-    } else {
-      ;({ response } = await goto(page, { ...opts, url, waitUntil, waitUntilAuto }))
-      async function waitUntilAuto (page, { response }) {
+      if (waitUntil !== 'auto') {
+        ;({ response } = await goto(page, { ...opts, url, waitUntil }))
         const [screenshotOpts] = await Promise.all([
           waitForElement(page, element),
           beforeScreenshot(response)
         ])
-        const { isWhite } = await takeScreenshot({ ...opts, ...screenshotOpts })
-        debug('screenshot', { waitUntil, isWhite, duration: prettyMs(timeScreenshot()) })
+        screenshot = await page.screenshot({ ...opts, ...screenshotOpts })
+        debug('screenshot', { waitUntil, duration: prettyMs(timeScreenshot()) })
+      } else {
+        ;({ response } = await goto(page, { ...opts, url, waitUntil, waitUntilAuto }))
+        async function waitUntilAuto (page, { response }) {
+          const [screenshotOpts] = await Promise.all([
+            waitForElement(page, element),
+            beforeScreenshot(response)
+          ])
+          const { isWhite } = await takeScreenshot({ ...opts, ...screenshotOpts })
+          debug('screenshot', { waitUntil, isWhite, duration: prettyMs(timeScreenshot()) })
+        }
       }
-    }
 
-    return Object.keys(overlayOpts).length === 0
-      ? screenshot
-      : overlay(screenshot, { ...opts, ...overlayOpts, viewport: page.viewport() })
-  }
+      return Object.keys(overlayOpts).length === 0
+        ? screenshot
+        : overlay(screenshot, { ...opts, ...overlayOpts, viewport: page.viewport() })
+    }
 }