@browserless/pdf 10.8.0-beta.2 → 10.8.0-beta.4

package/package.json

@@ -2,7 +2,7 @@
   "name": "@browserless/pdf",
   "description": "Sensible good defaults for exporting a website as PDF",
   "homepage": "https://browserless.js.org/#/?id=pdfurl-options",
-  "version": "10.8.0-beta.2",
+  "version": "10.8.0-beta.4",
   "main": "src",
   "repository": {
     "directory": "packages/pdf",
@@ -24,8 +24,8 @@
     "screen"
   ],
   "dependencies": {
-    "@browserless/goto": "^10.7.13",
-    "@browserless/screenshot": "^10.8.0-beta.0"
+    "@browserless/goto": "^10.8.0-beta.4",
+    "@browserless/screenshot": "^10.8.0-beta.4"
   },
   "engines": {
     "node": ">= 12"
@@ -38,5 +38,5 @@
     "test": "exit 0"
   },
   "license": "MIT",
-  "gitHead": "7f293ddfa791439d087ce5ee3d87eca4d1abb08c"
+  "gitHead": "1661cb17734e79e9b9b0e35b5e0ea5cda7df4f08"
 }

package/src/index.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const { takeScreenshot } = require('@browserless/screenshot')
+const { isWhiteScreenshot } = require('@browserless/screenshot')
 const debug = require('debug-logfmt')('browserless:pdf')
 const createGoto = require('@browserless/goto')
 const timeSpan = require('@kikobeats/time-span')({ format: require('pretty-ms') })
@@ -43,24 +43,22 @@ module.exports = ({ goto, ...gotoOpts } = {}) => {
       } else {
         await goto(page, { ...opts, url, waitUntil, waitUntilAuto })
         async function waitUntilAuto (page) {
+          const timeout = goto.timeouts.action(goto.timeouts.base(opts.timeout))
           let isWhite = false
-          let retryCount = 0
-          const maxRetries = 3
+          let retry = -1
 
           do {
-            const screenshotResult = await takeScreenshot({ page, goto, opts })
-            isWhite = screenshotResult.isWhite
-
-            if (isWhite && retryCount < maxRetries) {
-              retryCount++
-              debug('screenshot:retry', { waitUntil, isWhite, retryCount, maxRetries })
-              await setTimeout(500)
-              await goto.waitUntilAuto(page, { timeout: opts.timeout })
+            const screenshotTime = timeSpan()
+            isWhite = await isWhiteScreenshot(await page.screenshot(opts))
+            debug('screenshot', { waitUntil, isWhite, retry, duration: screenshotTime() })
+            if (++retry > 0) {
+              if (retry === 1) await goto.waitUntilAuto(page, { timeout: opts.timeout })
+              else await setTimeout(100)
             }
-          } while (isWhite && retryCount < maxRetries)
+          } while (isWhite && timePdf() < timeout)
 
           pdfBuffer = await generatePdf(page)
-          debug('screenshot', { waitUntil, isWhite, retryCount, duration: timePdf() })
+          debug({ waitUntil, isWhite, retry, duration: timePdf() })
         }
       }