@browserless/benchmark 9.2.10 → 9.3.14-alpha.0

package/package.json

@@ -2,7 +2,7 @@
   "name": "@browserless/benchmark",
   "description": "Benchmarking tool for testing different browserless configurations",
   "homepage": "https://browserless.js.org/#/?id=benchmark",
-  "version": "9.2.10",
+  "version": "9.3.14-alpha.0",
   "main": "src/index.js",
   "author": {
     "email": "josefrancisco.verdu@gmail.com",
@@ -29,7 +29,6 @@
     "puppeteer"
   ],
   "devDependencies": {
-    "@browserless/pool": "latest",
     "asciichart": "latest",
     "browserless": "latest",
     "debug-logfmt": "latest",
@@ -59,5 +58,5 @@
     "test": "exit 0"
   },
   "license": "MIT",
-  "gitHead": "e2a90a6be1671317809c97630ff489d9c9b7d55b"
+  "gitHead": "fe55af014debe242ee3823464a5e760afafca821"
 }

package/src/flags.js

@@ -16,8 +16,8 @@ const FLAGS = [
 ]
 
 const args = driver.args.reduce((acc, flag) => {
-  if (FLAGS.includes(flag)) return acc
-  return [...acc, flag]
+  if (!FLAGS.includes(flag)) acc.push(flag)
+  return acc
 }, [])
 
 const createBenchmark = ({ args }) => {

package/src/index.js

@@ -3,7 +3,6 @@
 process.setMaxListeners(Infinity)
 
 const createBrowserless = require('browserless')
-const createBrowserlessPool = require('@browserless/pool')
 const { includes, reduce } = require('lodash')
 const processStats = require('process-stats')
 const asciichart = require('asciichart')
@@ -20,10 +19,7 @@ const cli = meow(
 
     Flags
       --method         Choose what method to run (html, text, pdf, screenshot).
-      --pool           Enable pool mode.
       --iterations     Number of iterations.
-      --pool-min       Mininum of instances in pool mode.
-      --pool-max       Maximum of instances in pool mode.
       --concurrency    Define number of concurrent request.
       --firefox        Use Firefox browser.
 
@@ -56,14 +52,7 @@ const cli = meow(
   }
 )
 
-const benchmark = async ({
-  createBrowserless,
-  method,
-  url,
-  opts,
-  iterations,
-  concurrency
-}) => {
+const benchmark = async ({ createBrowserless, method, url, opts, iterations, concurrency }) => {
   const timer = new Measured.Timer()
   const promises = [...Array(iterations).keys()].map(n => {
     return async () => {
@@ -105,23 +94,11 @@ const main = async () => {
 
   if (!method) throw new TypeError('Need to provide a method to run.')
 
-  const puppeteer = firefox
-    ? require('puppeteer-firefox')
-    : require('puppeteer')
-
-  const _createBrowserless = isPool
-    ? () =>
-        createBrowserlessPool({
-          min: poolMin,
-          max: poolMax,
-          puppeteer,
-          ...opts
-        })
-    : () => createBrowserless({ puppeteer, ...opts })
+  const puppeteer = firefox ? require('puppeteer-firefox') : require('puppeteer')
 
   const { times, histogram } = await benchmark({
     concurrency,
-    createBrowserless: _createBrowserless,
+    createBrowserless: createBrowserless({ puppeteer, ...opts }),
     iterations,
     method,
     url,
@@ -132,7 +109,6 @@ const main = async () => {
     histogram,
     (acc, value, key) => {
       const newValue = !includes(['count'], key) ? prettyMs(value) : value
-
       return { ...acc, [key]: newValue }
     },
     {}