@browserless.io/browserless 2.29.0-beta-1 → 2.29.0-beta-3

package/build/browsers/browsers.playwright.js

@@ -33,7 +33,9 @@ class BasePlaywright extends EventEmitter {
     makeLaunchOptions(opts) {
         // Strip headless=old as it'll cause issues with newer Chromium
         const args = (opts.args ?? []).filter((a) => !a.includes('--headless=old'));
-        if (!args.some((a) => a.startsWith('--headless'))) {
+        const hasHeadless = args.some((a) => a.startsWith('--headless')) ||
+            opts.headless !== undefined; // check for undefinity, since it can be set to false as well
+        if (!hasHeadless) {
             args.push('--headless=new');
         }
         return {

package/build/routes/chrome/http/content.post.body.json

@@ -463,14 +463,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@14860": {
+                "__@toStringTag@29617": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@14860",
+                "__@toStringTag@29617",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -505,13 +505,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@14860": {
+        "__@toStringTag@29617": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@14860",
+        "__@toStringTag@29617",
         "byteLength"
       ]
     },
@@ -521,18 +521,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@14898": {
+        "__@species@29655": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@14860": {
+        "__@toStringTag@29617": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@14898",
-        "__@toStringTag@14860",
+        "__@species@29655",
+        "__@toStringTag@29617",
         "byteLength"
       ]
     },

package/build/routes/chrome/http/pdf.post.body.json

@@ -608,14 +608,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@118287": {
+                "__@toStringTag@74047": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@118287",
+                "__@toStringTag@74047",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -650,13 +650,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@118287": {
+        "__@toStringTag@74047": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@118287",
+        "__@toStringTag@74047",
         "byteLength"
       ]
     },
@@ -666,18 +666,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@118325": {
+        "__@species@74085": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@118287": {
+        "__@toStringTag@74047": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@118325",
-        "__@toStringTag@118287",
+        "__@species@74085",
+        "__@toStringTag@74047",
         "byteLength"
       ]
     },

package/build/routes/chrome/http/scrape.post.body.json

@@ -510,14 +510,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@192656": {
+                "__@toStringTag@162985": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@192656",
+                "__@toStringTag@162985",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -552,13 +552,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@192656": {
+        "__@toStringTag@162985": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@192656",
+        "__@toStringTag@162985",
         "byteLength"
       ]
     },
@@ -568,18 +568,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@192694": {
+        "__@species@163023": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@192656": {
+        "__@toStringTag@162985": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@192694",
-        "__@toStringTag@192656",
+        "__@species@163023",
+        "__@toStringTag@162985",
         "byteLength"
       ]
     },

package/build/routes/chrome/http/screenshot.post.body.json

@@ -553,14 +553,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@148000": {
+                "__@toStringTag@148030": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@148000",
+                "__@toStringTag@148030",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -595,13 +595,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@148000": {
+        "__@toStringTag@148030": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@148000",
+        "__@toStringTag@148030",
         "byteLength"
       ]
     },
@@ -611,18 +611,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@148038": {
+        "__@species@148068": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@148000": {
+        "__@toStringTag@148030": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@148038",
-        "__@toStringTag@148000",
+        "__@species@148068",
+        "__@toStringTag@148030",
         "byteLength"
       ]
     },

package/build/routes/chrome/tests/websocket.spec.js

@@ -383,4 +383,55 @@ describe('Chrome WebSocket API', function () {
         });
         await browser.disconnect();
     });
+    it('launches headless correctly', async () => {
+        const config = new Config();
+        config.setToken('browserless');
+        const metrics = new Metrics();
+        await start({ config, metrics });
+        const getVersion = () => {
+            return document.querySelector('#command_line')?.textContent;
+        };
+        const runPuppeteer = async (launch) => {
+            const browser = await puppeteer.connect({
+                browserWSEndpoint: `ws://localhost:3000/chrome?token=browserless&launch=${launch}`,
+            });
+            const page = await browser.newPage();
+            await page.goto('chrome://version/');
+            const command = await page.evaluate(getVersion);
+            await browser.close();
+            return command;
+        };
+        const runPlaywright = async (launch) => {
+            const browser = await chromium.connect(`ws://localhost:3000/chrome/playwright?token=browserless&launch=${launch}`);
+            const page = await browser.newPage();
+            await page.goto('chrome://version/');
+            const command = await page.evaluate(getVersion);
+            await browser.close();
+            return command;
+        };
+        // Test headless=new
+        let launch = JSON.stringify({
+            args: ['--headless=new'],
+        });
+        let pptrCommand = await runPuppeteer(launch);
+        let pwCommand = await runPlaywright(launch);
+        expect(pptrCommand).to.include('--headless=new');
+        expect(pwCommand).to.include('--headless=new');
+        // Test headless false
+        launch = JSON.stringify({
+            headless: false,
+        });
+        pptrCommand = await runPuppeteer(launch);
+        pwCommand = await runPlaywright(launch);
+        expect(pptrCommand).not.to.include('--headless');
+        expect(pwCommand).not.to.include('--headless');
+        // Test headless true (should default to headless=new for puppeteer and headless for playwright)
+        launch = JSON.stringify({
+            headless: true,
+        });
+        pptrCommand = await runPuppeteer(launch);
+        pwCommand = await runPlaywright(launch);
+        expect(pptrCommand).to.include('--headless=new');
+        expect(pwCommand).to.include('--headless');
+    });
 });

package/build/routes/chromium/http/content.post.body.json

@@ -463,14 +463,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@177687": {
+                "__@toStringTag@192744": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@177687",
+                "__@toStringTag@192744",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -505,13 +505,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@177687": {
+        "__@toStringTag@192744": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@177687",
+        "__@toStringTag@192744",
         "byteLength"
       ]
     },
@@ -521,18 +521,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@177725": {
+        "__@species@192782": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@177687": {
+        "__@toStringTag@192744": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@177725",
-        "__@toStringTag@177687",
+        "__@species@192782",
+        "__@toStringTag@192744",
         "byteLength"
       ]
     },

package/build/routes/chromium/http/pdf.post.body.json

@@ -608,14 +608,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@266612": {
+                "__@toStringTag@281458": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@266612",
+                "__@toStringTag@281458",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -650,13 +650,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@266612": {
+        "__@toStringTag@281458": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@266612",
+        "__@toStringTag@281458",
         "byteLength"
       ]
     },
@@ -666,18 +666,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@266650": {
+        "__@species@281496": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@266612": {
+        "__@toStringTag@281458": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@266650",
-        "__@toStringTag@266612",
+        "__@species@281496",
+        "__@toStringTag@281458",
         "byteLength"
       ]
     },

package/build/routes/chromium/http/scrape.post.body.json

@@ -510,14 +510,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@281561": {
+                "__@toStringTag@296410": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@281561",
+                "__@toStringTag@296410",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -552,13 +552,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@281561": {
+        "__@toStringTag@296410": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@281561",
+        "__@toStringTag@296410",
         "byteLength"
       ]
     },
@@ -568,18 +568,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@281599": {
+        "__@species@296448": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@281561": {
+        "__@toStringTag@296410": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@281599",
-        "__@toStringTag@281561",
+        "__@species@296448",
+        "__@toStringTag@296410",
         "byteLength"
       ]
     },

package/build/routes/chromium/http/screenshot.post.body.json

@@ -553,14 +553,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@311338": {
+                "__@toStringTag@326151": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@311338",
+                "__@toStringTag@326151",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -595,13 +595,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@311338": {
+        "__@toStringTag@326151": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@311338",
+        "__@toStringTag@326151",
         "byteLength"
       ]
     },
@@ -611,18 +611,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@311376": {
+        "__@species@326189": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@311338": {
+        "__@toStringTag@326151": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@311376",
-        "__@toStringTag@311338",
+        "__@species@326189",
+        "__@toStringTag@326151",
         "byteLength"
       ]
     },

package/build/routes/chromium/tests/pdf.spec.js

@@ -360,7 +360,6 @@ describe('/chromium/pdf API', function () {
             method: 'POST',
         }).then(async (res) => {
             const errorText = await res.text();
-            console.log(errorText);
             expect(res.status).to.equal(400);
             expect(errorText).to.include('Request payload size');
             expect(errorText).to.include('exceeds maximum allowed size');

package/build/routes/chromium/tests/websocket.spec.js

@@ -383,6 +383,57 @@ describe('Chromium WebSocket API', function () {
         });
         await browser.disconnect();
     });
+    it('launches headless correctly', async () => {
+        const config = new Config();
+        config.setToken('browserless');
+        const metrics = new Metrics();
+        await start({ config, metrics });
+        const getVersion = () => {
+            return document.querySelector('#command_line')?.textContent;
+        };
+        const runPuppeteer = async (launch) => {
+            const browser = await puppeteer.connect({
+                browserWSEndpoint: `ws://localhost:3000/chromium?token=browserless&launch=${launch}`,
+            });
+            const page = await browser.newPage();
+            await page.goto('chrome://version/');
+            const command = await page.evaluate(getVersion);
+            await browser.close();
+            return command;
+        };
+        const runPlaywright = async (launch) => {
+            const browser = await chromium.connect(`ws://localhost:3000/chromium/playwright?token=browserless&launch=${launch}`);
+            const page = await browser.newPage();
+            await page.goto('chrome://version/');
+            const command = await page.evaluate(getVersion);
+            await browser.close();
+            return command;
+        };
+        // Test headless=new
+        let launch = JSON.stringify({
+            args: ['--headless=new'],
+        });
+        let pptrCommand = await runPuppeteer(launch);
+        let pwCommand = await runPlaywright(launch);
+        expect(pptrCommand).to.include('--headless=new');
+        expect(pwCommand).to.include('--headless=new');
+        // Test headless false
+        launch = JSON.stringify({
+            headless: false,
+        });
+        pptrCommand = await runPuppeteer(launch);
+        pwCommand = await runPlaywright(launch);
+        expect(pptrCommand).not.to.include('--headless');
+        expect(pwCommand).not.to.include('--headless');
+        // Test headless true (should default to headless=new for puppeteer and headless for playwright)
+        launch = JSON.stringify({
+            headless: true,
+        });
+        pptrCommand = await runPuppeteer(launch);
+        pwCommand = await runPlaywright(launch);
+        expect(pptrCommand).to.include('--headless=new');
+        expect(pwCommand).to.include('--headless');
+    });
     it('Throws an error while creating a session with invalid trackingId', async () => {
         await start();
         const didError = await puppeteer

package/build/routes/edge/http/content.post.body.json

@@ -463,14 +463,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@341055": {
+                "__@toStringTag@385334": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@341055",
+                "__@toStringTag@385334",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -505,13 +505,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@341055": {
+        "__@toStringTag@385334": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@341055",
+        "__@toStringTag@385334",
         "byteLength"
       ]
     },
@@ -521,18 +521,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@341093": {
+        "__@species@385372": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@341055": {
+        "__@toStringTag@385334": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@341093",
-        "__@toStringTag@341055",
+        "__@species@385372",
+        "__@toStringTag@385334",
         "byteLength"
       ]
     },