@browserbridge/bbx 1.7.8 → 1.9.0

package/packages/protocol/src/summary.js

@@ -7,6 +7,7 @@ import {
   getProtocolVersion,
   serializeJsonPayload,
 } from './index.js';
+import { sanitizeIncidentalUrl } from './incidental-sanitizer.js';
 
 /** @typedef {import('./types.js').BridgeResponse} BridgeResponse */
 /** @typedef {import('./types.js').BridgeMethod} SummaryMethod */
@@ -68,16 +69,31 @@ const ACTION_SUMMARIES = {
   },
   closed: { text: (r) => `Tab ${r.tabId} closed.`, evidence: (r) => r },
   clicked: {
-    text: (r) => `Clicked ${r.elementRef ?? 'element'}.`,
-    evidence: (r) => ({ elementRef: r.elementRef }),
+    text: (r) => {
+      const mode = toRecord(r.execution).actualMode;
+      return `Clicked ${r.elementRef ?? 'element'}${typeof mode === 'string' ? ` via ${mode}` : ''}.`;
+    },
+    evidence: (r) => ({
+      elementRef: r.elementRef,
+      resolution: r.resolution,
+      execution: r.execution,
+    }),
   },
   focused: {
     text: (r) => `Focused ${r.elementRef ?? 'element'}.`,
-    evidence: (r) => ({ elementRef: r.elementRef }),
+    evidence: (r) => ({
+      elementRef: r.elementRef,
+      resolution: r.resolution,
+      execution: r.execution,
+    }),
   },
   typed: {
     text: (r) => `Typed into ${r.elementRef ?? 'element'}.`,
-    evidence: (r) => ({ elementRef: r.elementRef }),
+    evidence: (r) => ({
+      elementRef: r.elementRef,
+      resolution: r.resolution,
+      execution: r.execution,
+    }),
   },
   pressed: {
     text: (r) => `Key pressed${r.key ? ` (${r.key})` : ''}.`,
@@ -106,6 +122,7 @@ const ACTION_SUMMARIES = {
  * @returns {AnnotatedBridgeSummary}
  */
 export function annotateBridgeSummary(summary, response) {
+  const sensitiveRead = response.meta?.method === 'sensitive.read';
   const metaTransportBytes =
     getNumericMetaField(response.meta, 'transport_bytes') ??
     getNumericMetaField(response.meta, 'response_bytes');
@@ -113,13 +130,15 @@ export function annotateBridgeSummary(summary, response) {
     getNumericMetaField(response.meta, 'transport_approx_tokens') ??
     getNumericMetaField(response.meta, 'approx_tokens');
   const transportCost =
-    metaTransportBytes == null || metaTransportTokens == null
+    !sensitiveRead && (metaTransportBytes == null || metaTransportTokens == null)
       ? estimateSerializedPayloadCost(
           serializeJsonPayload(response.ok ? response.result : { error: response.error })
         )
       : null;
-  const transportBytes = metaTransportBytes ?? transportCost?.bytes ?? 0;
-  const transportTokens = metaTransportTokens ?? transportCost?.approxTokens ?? 0;
+  const transportBytes = sensitiveRead ? 0 : (metaTransportBytes ?? transportCost?.bytes ?? 0);
+  const transportTokens = sensitiveRead
+    ? 0
+    : (metaTransportTokens ?? transportCost?.approxTokens ?? 0);
   const summaryCost = estimateSerializedPayloadCost(serializeJsonPayload(summary));
 
   return {
@@ -179,6 +198,90 @@ export function summarizeBridgeResponse(response, method) {
   }
 
   const result = toRecord(response.result);
+  if (method === 'dom.baseline.compare') {
+    const counts = toRecord(result.counts);
+    const added = typeof counts.added === 'number' ? counts.added : 0;
+    const removed = typeof counts.removed === 'number' ? counts.removed : 0;
+    const changed = typeof counts.changed === 'number' ? counts.changed : 0;
+    const moved = typeof counts.moved === 'number' ? counts.moved : 0;
+    return {
+      ok: true,
+      summary: appendProtocolWarning(
+        result.equal === true
+          ? `DOM baseline ${result.baselineId ?? ''} matches the current DOM.`
+          : `DOM baseline ${result.baselineId ?? ''} differs: ${added} added, ${removed} removed, ${changed} changed, ${moved} moved${result.truncated === true ? `; ${result.omittedChanges ?? 0} omitted` : ''}.`,
+        protocolWarning
+      ),
+      evidence: result,
+    };
+  }
+  if (method === 'dom.baseline.release') {
+    return {
+      ok: true,
+      summary: appendProtocolWarning(
+        `DOM baseline ${result.baselineId ?? ''} ${result.released === true ? 'released' : 'was not released'}.`,
+        protocolWarning
+      ),
+      evidence: result,
+    };
+  }
+  if (method === 'dom.baseline.create' || method === 'dom.baseline.describe') {
+    const snapshot = toRecord(result.snapshot);
+    return {
+      ok: true,
+      summary: appendProtocolWarning(
+        `DOM baseline ${result.baselineId ?? ''} ${method === 'dom.baseline.create' ? 'created' : 'described'}: ${snapshot.nodeCount ?? 0} node(s), ${snapshot.byteLength ?? 0} bytes.`,
+        protocolWarning
+      ),
+      evidence: result,
+    };
+  }
+  if (method === 'page.handle_dialog') {
+    const action = typeof result.action === 'string' ? result.action : 'inspect';
+    return {
+      ok: true,
+      summary: appendProtocolWarning(
+        result.commandDispatched === true
+          ? `JavaScript dialog ${action} command dispatched to the current dialog; Chrome did not atomically bind it to the observation identifier.`
+          : `JavaScript ${result.type ?? 'unknown'} dialog is open.`,
+        protocolWarning
+      ),
+      evidence: result,
+    };
+  }
+  if (method === 'page.wait_for_load_state' && typeof result.finalUrl === 'string') {
+    return {
+      ok: true,
+      summary: appendProtocolWarning(
+        `URL matched via ${result.observedNavigationKind ?? 'unknown'} after ${result.elapsedMs ?? 0}ms.`,
+        protocolWarning
+      ),
+      evidence: result,
+    };
+  }
+  if (method === 'network.export_har') {
+    const delivery = result.delivery === 'artifact' ? 'artifact' : 'inline';
+    const entryCount = typeof result.entryCount === 'number' ? result.entryCount : 0;
+    const totalEntries = typeof result.totalEntries === 'number' ? result.totalEntries : entryCount;
+    const dropped = typeof result.dropped === 'number' ? result.dropped : 0;
+    const abandoned = typeof result.abandoned === 'number' ? result.abandoned : 0;
+    const inflight = typeof result.inflight === 'number' ? result.inflight : 0;
+    return {
+      ok: true,
+      summary: appendProtocolWarning(
+        `HAR export delivered ${delivery}: ${entryCount}/${totalEntries} entries (${dropped} dropped, ${abandoned} abandoned, ${inflight} inflight).`,
+        protocolWarning
+      ),
+      evidence: /** @type {import('./types.js').HarExportEvidence} */ ({
+        delivery,
+        entryCount,
+        totalEntries,
+        dropped,
+        abandoned,
+        inflight,
+      }),
+    };
+  }
   if (typeof result.daemon === 'string') {
     const access =
       result.access && typeof result.access === 'object'
@@ -232,6 +335,23 @@ export function summarizeBridgeResponse(response, method) {
       evidence: result,
     };
   }
+  if (typeof result.content === 'string' && typeof result.source === 'string') {
+    return {
+      ok: true,
+      summary: appendProtocolWarning(
+        `Extracted ${result.source} ${result.format ?? 'text'}: ${result.length ?? result.content.length} chars${result.truncated ? ' (truncated)' : ''}.`,
+        protocolWarning
+      ),
+      evidence: {
+        content: result.content.slice(0, 500),
+        format: result.format,
+        source: result.source,
+        length: result.length,
+        truncated: result.truncated,
+        settlement: result.settlement,
+      },
+    };
+  }
   if (
     typeof result.url === 'string' &&
     typeof result.title === 'string' &&
@@ -466,7 +586,9 @@ export function summarizeBridgeResponse(response, method) {
   if (
     Array.isArray(result.entries) &&
     (result.entries.length > 0
-      ? result.entries[0]?.type === 'fetch' || result.entries[0]?.type === 'xhr'
+      ? result.entries[0]?.type === 'fetch' ||
+        result.entries[0]?.type === 'xhr' ||
+        typeof result.entries[0]?.resourceType === 'string'
       : method === 'page.get_network')
   ) {
     const entries = /** @type {Array<Record<string, unknown>>} */ (result.entries);
@@ -481,9 +603,50 @@ export function summarizeBridgeResponse(response, method) {
         url: truncateUrl(/** @type {string} */ (e.url)),
         status: e.status,
         duration: e.duration,
+        ...(typeof e.resourceType === 'string' ? { resourceType: e.resourceType } : {}),
+        ...(typeof e.failureReason === 'string' && e.failureReason
+          ? { failureReason: e.failureReason }
+          : {}),
       })),
     };
   }
+  if (
+    result.exact === true &&
+    typeof result.source === 'string' &&
+    typeof result.value === 'string'
+  ) {
+    return {
+      ok: true,
+      summary: appendProtocolWarning('Sensitive storage value read exactly.', protocolWarning),
+      evidence: { source: result.source, exact: true },
+    };
+  }
+  if (typeof result.count === 'number' && typeof result.type === 'string' && result.entries) {
+    const entries = Array.isArray(result.entries)
+      ? result.entries.map((entry) => {
+          const candidate =
+            entry && typeof entry === 'object'
+              ? /** @type {Record<string, unknown>} */ (entry)
+              : {};
+          return {
+            key: typeof candidate.key === 'string' ? candidate.key : '',
+            present: candidate.present === true,
+          };
+        })
+      : [];
+    return {
+      ok: true,
+      summary: appendProtocolWarning(
+        `Storage (${result.type}): ${result.count} entries.`,
+        protocolWarning
+      ),
+      evidence: {
+        entries,
+        total: typeof result.total === 'number' ? result.total : result.count,
+        truncated: result.truncated === true,
+      },
+    };
+  }
   if (Array.isArray(result.entries)) {
     const consoleEntries = /** @type {Array<Record<string, unknown>>} */ (result.entries);
     return {
@@ -524,6 +687,27 @@ export function summarizeBridgeResponse(response, method) {
       };
     }
   }
+  if (method?.startsWith('input.') && result.execution && typeof result.execution === 'object') {
+    const execution = toRecord(result.execution);
+    return {
+      ok: true,
+      summary: appendProtocolWarning(
+        `${method} completed via ${execution.actualMode ?? 'dom'}${result.elementRef ? ` on ${result.elementRef}` : ''}.`,
+        protocolWarning
+      ),
+      evidence: {
+        elementRef: result.elementRef ?? null,
+        sourceRef: result.sourceRef ?? null,
+        destinationRef: result.destinationRef ?? null,
+        typed: result.typed,
+        checked: result.checked,
+        selectedValues: result.selectedValues,
+        mode: result.mode,
+        resolution: result.resolution,
+        execution: result.execution,
+      },
+    };
+  }
   if (typeof result.tabId === 'number' && typeof result.url === 'string') {
     const actionMethod = typeof result.method === 'string' ? result.method : method;
     if (actionMethod === 'navigation.navigate') {
@@ -549,30 +733,18 @@ export function summarizeBridgeResponse(response, method) {
   }
   if (typeof result.metrics === 'object' && result.metrics !== null) {
     const keys = Object.keys(result.metrics);
+    const measurement = toRecord(result.measurement);
+    const rawCdpCounters =
+      method === 'performance.get_metrics' || measurement.kind === 'raw_cdp_counters';
     return {
       ok: true,
       summary: appendProtocolWarning(
-        `Performance: ${keys.length} metrics collected.`,
-        protocolWarning
-      ),
-      evidence: result.metrics,
-    };
-  }
-  if (typeof result.count === 'number' && typeof result.type === 'string' && result.entries) {
-    const entries = /** @type {Record<string, unknown>} */ (result.entries);
-    /** @type {Record<string, string>} */
-    const safe = {};
-    for (const [k, v] of Object.entries(entries)) {
-      const s = typeof v === 'string' ? v : JSON.stringify(v);
-      safe[k] = s.length > 80 ? `${s.slice(0, 79)}…` : s;
-    }
-    return {
-      ok: true,
-      summary: appendProtocolWarning(
-        `Storage (${result.type}): ${result.count} entries.`,
+        rawCdpCounters
+          ? `Raw CDP performance counters: ${keys.length} collected in a browser-maintained point sample; Web Vitals not measured.`
+          : `Performance: ${keys.length} metrics collected.`,
         protocolWarning
       ),
-      evidence: safe,
+      evidence: rawCdpCounters ? { metrics: result.metrics, measurement } : result.metrics,
     };
   }
   if (
@@ -791,15 +963,16 @@ function appendProtocolWarning(summary, warning) {
  * @returns {string}
  */
 function truncateUrl(url) {
-  if (!url || url.length <= 120) return url;
+  const sanitized = sanitizeIncidentalUrl(url);
+  if (!sanitized || sanitized.length <= 120) return sanitized;
   try {
-    const u = new URL(url);
+    const u = new URL(sanitized);
     const base = `${u.origin}${u.pathname}`;
     if (base.length > 120) return `${base.slice(0, 119)}\u2026`;
     if (u.search) return `${base}?…`;
     return base;
   } catch {
-    return url.length > 120 ? `${url.slice(0, 119)}\u2026` : url;
+    return sanitized.length > 120 ? `${sanitized.slice(0, 119)}\u2026` : sanitized;
   }
 }