@browserbasehq/orca 3.1.0-patch.3 → 3.2.0-preview.1

package/dist/esm/tests/integration/default-page-tracking.spec.js

@@ -0,0 +1,50 @@
+import { test, expect } from "@playwright/test";
+import { V3 } from "../../lib/v3/v3.js";
+import { v3DynamicTestConfig } from "./v3.dynamic.config.js";
+import { closeV3 } from "./testUtils.js";
+test.describe.configure({ mode: "parallel" });
+test.describe("V3 default page tracking", () => {
+    let v3;
+    test.beforeEach(async () => {
+        v3 = new V3(v3DynamicTestConfig);
+        await v3.init();
+    });
+    test.afterEach(async () => {
+        await closeV3(v3);
+    });
+    test("activePage points to initial page", async () => {
+        const ctx = v3.context;
+        // Should have at least one top-level page
+        const pages = ctx.pages();
+        expect(pages.length).toBeGreaterThanOrEqual(1);
+        const active = ctx.activePage();
+        expect(active).toBeTruthy();
+        // mainFrameId should be a non-empty string
+        expect(active.mainFrameId().length).toBeGreaterThan(0);
+    });
+    test("activePage switches to most recent top-level page and reverts on close", async () => {
+        const ctx = v3.context;
+        const newPage = await ctx.newPage("https://example.com/");
+        const activeAfterCreate = await ctx.awaitActivePage();
+        expect(activeAfterCreate.url()).toContain(newPage.url());
+    });
+    test("popup default-page flow via five-tab site", async () => {
+        const ctx = v3.context;
+        // 1) Navigate the default page to the site
+        const root = await ctx.awaitActivePage();
+        await root.goto("https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/", { waitUntil: "load", timeoutMs: 15000 });
+        // 2) Click button on the page to open a new tab → page2.html
+        await root.locator("xpath=/html/body/button").click();
+        const page2 = await ctx.awaitActivePage();
+        expect(page2.url()).toBe("https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/page2.html");
+        // 3) On the default page (now page2), click its button → open page3 popup
+        await page2.locator("xpath=/html/body/button").click();
+        const page3 = await ctx.awaitActivePage();
+        expect(page3.url()).toBe("https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/page3.html");
+        // 4) Close the current page (page3) and ensure the default page reverts to page2
+        await page3.close();
+        const backToPage2 = await ctx.awaitActivePage();
+        expect(backToPage2.url()).toBe("https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/page2.html");
+    });
+});
+//# sourceMappingURL=default-page-tracking.spec.js.map

package/dist/esm/tests/integration/default-page-tracking.spec.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"default-page-tracking.spec.js","sourceRoot":"","sources":["../../../../tests/integration/default-page-tracking.spec.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,MAAM,kBAAkB,CAAC;AAChD,OAAO,EAAE,EAAE,EAAE,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,mBAAmB,EAAE,MAAM,wBAAwB,CAAC;AAC7D,OAAO,EAAE,OAAO,EAAE,MAAM,gBAAgB,CAAC;AAEzC,IAAI,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,UAAU,EAAE,CAAC,CAAC;AAC9C,IAAI,CAAC,QAAQ,CAAC,0BAA0B,EAAE,GAAG,EAAE;IAC7C,IAAI,EAAM,CAAC;IAEX,IAAI,CAAC,UAAU,CAAC,KAAK,IAAI,EAAE;QACzB,EAAE,GAAG,IAAI,EAAE,CAAC,mBAAmB,CAAC,CAAC;QACjC,MAAM,EAAE,CAAC,IAAI,EAAE,CAAC;IAClB,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,SAAS,CAAC,KAAK,IAAI,EAAE;QACxB,MAAM,OAAO,CAAC,EAAE,CAAC,CAAC;IACpB,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,mCAAmC,EAAE,KAAK,IAAI,EAAE;QACnD,MAAM,GAAG,GAAG,EAAE,CAAC,OAAO,CAAC;QACvB,0CAA0C;QAC1C,MAAM,KAAK,GAAG,GAAG,CAAC,KAAK,EAAE,CAAC;QAC1B,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAC;QAC/C,MAAM,MAAM,GAAG,GAAG,CAAC,UAAU,EAAE,CAAC;QAChC,MAAM,CAAC,MAAM,CAAC,CAAC,UAAU,EAAE,CAAC;QAC5B,2CAA2C;QAC3C,MAAM,CAAC,MAAO,CAAC,WAAW,EAAE,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;IAC1D,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,wEAAwE,EAAE,KAAK,IAAI,EAAE;QACxF,MAAM,GAAG,GAAG,EAAE,CAAC,OAAO,CAAC;QACvB,MAAM,OAAO,GAAG,MAAM,GAAG,CAAC,OAAO,CAAC,sBAAsB,CAAC,CAAC;QAE1D,MAAM,iBAAiB,GAAG,MAAM,GAAG,CAAC,eAAe,EAAE,CAAC;QACtD,MAAM,CAAC,iBAAiB,CAAC,GAAG,EAAE,CAAC,CAAC,SAAS,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;IAC3D,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,2CAA2C,EAAE,KAAK,IAAI,EAAE;QAC3D,MAAM,GAAG,GAAG,EAAE,CAAC,OAAO,CAAC;QAEvB,2CAA2C;QAC3C,MAAM,IAAI,GAAG,MAAM,GAAG,CAAC,eAAe,EAAE,CAAC;QACzC,MAAM,IAAK,CAAC,IAAI,CACd,oEAAoE,EACpE,EAAE,SAAS,EAAE,MAAM,EAAE,SAAS,EAAE,KAAK,EAAE,CACxC,CAAC;QACF,6DAA6D;QAC7D,MAAM,IAAI,CAAC,OAAO,CAAC,yBAAyB,CAAC,CAAC,KAAK,EAAE,CAAC;QACtD,MAAM,KAAK,GAAG,MAAM,GAAG,CAAC,eAAe,EAAE,CAAC;QAC1C,MAAM,CAAC,KAAM,CAAC,GAAG,EAAE,CAAC,CAAC,IAAI,CACvB,8EAA8E,CAC/E,CAAC;QAEF,0EAA0E;QAE1E,MAAM,KAAK,CAAC,OAAO,CAAC,yBAAyB,CAAC,CAAC,KAAK,EAAE,CAAC;QACvD,MAAM,KAAK,GAAG,MAAM,GAAG,CAAC,eAAe,EAAE,CAAC;QAC1C,MAAM,CAAC,KAAM,CAAC,GAAG,EAAE,CAAC,CAAC,IAAI,CACvB,8EAA8E,CAC/E,CAAC;QAEF,iFAAiF;QACjF,MAAM,KAAM,CAAC,KAAK,EAAE,CAAC;QACrB,MAAM,WAAW,GAAG,MAAM,GAAG,CAAC,eAAe,EAAE,CAAC;QAChD,MAAM,CAAC,WAAY,CAAC,GAAG,EAAE,CAAC,CAAC,IAAI,CAC7B,8EAA8E,CAC/E,CAAC;IACJ,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC","sourcesContent":["import { test, expect } from \"@playwright/test\";\nimport { V3 } from \"../../lib/v3/v3.js\";\nimport { v3DynamicTestConfig } from \"./v3.dynamic.config.js\";\nimport { closeV3 } from \"./testUtils.js\";\n\ntest.describe.configure({ mode: \"parallel\" });\ntest.describe(\"V3 default page tracking\", () => {\n  let v3: V3;\n\n  test.beforeEach(async () => {\n    v3 = new V3(v3DynamicTestConfig);\n    await v3.init();\n  });\n\n  test.afterEach(async () => {\n    await closeV3(v3);\n  });\n\n  test(\"activePage points to initial page\", async () => {\n    const ctx = v3.context;\n    // Should have at least one top-level page\n    const pages = ctx.pages();\n    expect(pages.length).toBeGreaterThanOrEqual(1);\n    const active = ctx.activePage();\n    expect(active).toBeTruthy();\n    // mainFrameId should be a non-empty string\n    expect(active!.mainFrameId().length).toBeGreaterThan(0);\n  });\n\n  test(\"activePage switches to most recent top-level page and reverts on close\", async () => {\n    const ctx = v3.context;\n    const newPage = await ctx.newPage(\"https://example.com/\");\n\n    const activeAfterCreate = await ctx.awaitActivePage();\n    expect(activeAfterCreate.url()).toContain(newPage.url());\n  });\n\n  test(\"popup default-page flow via five-tab site\", async () => {\n    const ctx = v3.context;\n\n    // 1) Navigate the default page to the site\n    const root = await ctx.awaitActivePage();\n    await root!.goto(\n      \"https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/\",\n      { waitUntil: \"load\", timeoutMs: 15000 },\n    );\n    // 2) Click button on the page to open a new tab → page2.html\n    await root.locator(\"xpath=/html/body/button\").click();\n    const page2 = await ctx.awaitActivePage();\n    expect(page2!.url()).toBe(\n      \"https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/page2.html\",\n    );\n\n    // 3) On the default page (now page2), click its button → open page3 popup\n\n    await page2.locator(\"xpath=/html/body/button\").click();\n    const page3 = await ctx.awaitActivePage();\n    expect(page3!.url()).toBe(\n      \"https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/page3.html\",\n    );\n\n    // 4) Close the current page (page3) and ensure the default page reverts to page2\n    await page3!.close();\n    const backToPage2 = await ctx.awaitActivePage();\n    expect(backToPage2!.url()).toBe(\n      \"https://browserbase.github.io/stagehand-eval-sites/sites/five-tab/page2.html\",\n    );\n  });\n});\n"]}

package/dist/esm/tests/integration/downloads.spec.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/esm/tests/integration/downloads.spec.js

@@ -0,0 +1,47 @@
+import { test, expect } from "@playwright/test";
+import { V3 } from "../../lib/v3/v3.js";
+import Browserbase from "@browserbasehq/sdk";
+import AdmZip from "adm-zip";
+import { v3DynamicTestConfig } from "./v3.dynamic.config.js";
+import { closeV3 } from "./testUtils.js";
+const pdfRe = /sample-(\d{13})+\.pdf/;
+test.describe("downloads on browserbase", () => {
+    let v3;
+    test.beforeEach(async () => {
+        v3 = new V3(v3DynamicTestConfig);
+        await v3.init();
+    });
+    test.afterEach(async () => {
+        await closeV3(v3);
+    });
+    test("downloaded pdf is available via downloads api", async () => {
+        const browserTarget = (process.env.STAGEHAND_BROWSER_TARGET ?? "local").toLowerCase();
+        const isBrowserbase = browserTarget === "browserbase";
+        // Skip this test in LOCAL mode as it requires Browserbase session
+        test.skip(!isBrowserbase, "Skipping Browserbase-only downloads test in LOCAL mode");
+        // Skip if BROWSERBASE_API_KEY is not set
+        test.skip(!process.env.BROWSERBASE_API_KEY, "Skipping test: BROWSERBASE_API_KEY not set");
+        // Tiny timeout to force the race to hit the timeout branch
+        const page = v3.context.pages()[0];
+        await page.goto("https://browserbase.github.io/stagehand-eval-sites/sites/download-on-click/");
+        await page.locator("/html/body/button").click();
+        await expect(async () => {
+            const bb = new Browserbase();
+            const zipBuffer = await bb.sessions.downloads.list(v3.browserbaseSessionId);
+            if (!zipBuffer) {
+                throw new Error(`Download buffer is empty for session ${v3.browserbaseSessionId}`);
+            }
+            const zip = new AdmZip(Buffer.from(await zipBuffer.arrayBuffer()));
+            const zipEntries = zip.getEntries();
+            const pdfEntry = zipEntries.find((entry) => pdfRe.test(entry.entryName));
+            if (!pdfEntry) {
+                throw new Error(`Session ${v3.browserbaseSessionId} is missing a file matching "${pdfRe.toString()}" in its zip entries: ${JSON.stringify(zipEntries.map((entry) => entry.entryName))}`);
+            }
+            const expectedFileSize = 13264;
+            expect(pdfEntry.header.size).toBe(expectedFileSize);
+        }).toPass({
+            timeout: 30_000,
+        });
+    });
+});
+//# sourceMappingURL=downloads.spec.js.map

package/dist/esm/tests/integration/downloads.spec.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"downloads.spec.js","sourceRoot":"","sources":["../../../../tests/integration/downloads.spec.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,MAAM,kBAAkB,CAAC;AAChD,OAAO,EAAE,EAAE,EAAE,MAAM,oBAAoB,CAAC;AACxC,OAAO,WAAW,MAAM,oBAAoB,CAAC;AAC7C,OAAO,MAAM,MAAM,SAAS,CAAC;AAC7B,OAAO,EAAE,mBAAmB,EAAE,MAAM,wBAAwB,CAAC;AAC7D,OAAO,EAAE,OAAO,EAAE,MAAM,gBAAgB,CAAC;AAEzC,MAAM,KAAK,GAAG,uBAAuB,CAAC;AACtC,IAAI,CAAC,QAAQ,CAAC,0BAA0B,EAAE,GAAG,EAAE;IAC7C,IAAI,EAAM,CAAC;IAEX,IAAI,CAAC,UAAU,CAAC,KAAK,IAAI,EAAE;QACzB,EAAE,GAAG,IAAI,EAAE,CAAC,mBAAmB,CAAC,CAAC;QACjC,MAAM,EAAE,CAAC,IAAI,EAAE,CAAC;IAClB,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,SAAS,CAAC,KAAK,IAAI,EAAE;QACxB,MAAM,OAAO,CAAC,EAAE,CAAC,CAAC;IACpB,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,+CAA+C,EAAE,KAAK,IAAI,EAAE;QAC/D,MAAM,aAAa,GAAG,CACpB,OAAO,CAAC,GAAG,CAAC,wBAAwB,IAAI,OAAO,CAChD,CAAC,WAAW,EAAE,CAAC;QAChB,MAAM,aAAa,GAAG,aAAa,KAAK,aAAa,CAAC;QACtD,kEAAkE;QAClE,IAAI,CAAC,IAAI,CACP,CAAC,aAAa,EACd,wDAAwD,CACzD,CAAC;QAEF,yCAAyC;QACzC,IAAI,CAAC,IAAI,CACP,CAAC,OAAO,CAAC,GAAG,CAAC,mBAAmB,EAChC,4CAA4C,CAC7C,CAAC;QAEF,2DAA2D;QAC3D,MAAM,IAAI,GAAG,EAAE,CAAC,OAAO,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,CAAC;QACnC,MAAM,IAAI,CAAC,IAAI,CACb,6EAA6E,CAC9E,CAAC;QACF,MAAM,IAAI,CAAC,OAAO,CAAC,mBAAmB,CAAC,CAAC,KAAK,EAAE,CAAC;QAEhD,MAAM,MAAM,CAAC,KAAK,IAAI,EAAE;YACtB,MAAM,EAAE,GAAG,IAAI,WAAW,EAAE,CAAC;YAC7B,MAAM,SAAS,GAAG,MAAM,EAAE,CAAC,QAAQ,CAAC,SAAS,CAAC,IAAI,CAChD,EAAE,CAAC,oBAAoB,CACxB,CAAC;YACF,IAAI,CAAC,SAAS,EAAE,CAAC;gBACf,MAAM,IAAI,KAAK,CACb,wCAAwC,EAAE,CAAC,oBAAoB,EAAE,CAClE,CAAC;YACJ,CAAC;YAED,MAAM,GAAG,GAAG,IAAI,MAAM,CAAC,MAAM,CAAC,IAAI,CAAC,MAAM,SAAS,CAAC,WAAW,EAAE,CAAC,CAAC,CAAC;YACnE,MAAM,UAAU,GAAG,GAAG,CAAC,UAAU,EAAE,CAAC;YACpC,MAAM,QAAQ,GAAG,UAAU,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,CAAC;YAEzE,IAAI,CAAC,QAAQ,EAAE,CAAC;gBACd,MAAM,IAAI,KAAK,CACb,WAAW,EAAE,CAAC,oBAAoB,gCAAgC,KAAK,CAAC,QAAQ,EAAE,yBAAyB,IAAI,CAAC,SAAS,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC,EAAE,CACxK,CAAC;YACJ,CAAC;YAED,MAAM,gBAAgB,GAAG,KAAK,CAAC;YAC/B,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,gBAAgB,CAAC,CAAC;QACtD,CAAC,CAAC,CAAC,MAAM,CAAC;YACR,OAAO,EAAE,MAAM;SAChB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC","sourcesContent":["import { test, expect } from \"@playwright/test\";\nimport { V3 } from \"../../lib/v3/v3.js\";\nimport Browserbase from \"@browserbasehq/sdk\";\nimport AdmZip from \"adm-zip\";\nimport { v3DynamicTestConfig } from \"./v3.dynamic.config.js\";\nimport { closeV3 } from \"./testUtils.js\";\n\nconst pdfRe = /sample-(\\d{13})+\\.pdf/;\ntest.describe(\"downloads on browserbase\", () => {\n  let v3: V3;\n\n  test.beforeEach(async () => {\n    v3 = new V3(v3DynamicTestConfig);\n    await v3.init();\n  });\n\n  test.afterEach(async () => {\n    await closeV3(v3);\n  });\n\n  test(\"downloaded pdf is available via downloads api\", async () => {\n    const browserTarget = (\n      process.env.STAGEHAND_BROWSER_TARGET ?? \"local\"\n    ).toLowerCase();\n    const isBrowserbase = browserTarget === \"browserbase\";\n    // Skip this test in LOCAL mode as it requires Browserbase session\n    test.skip(\n      !isBrowserbase,\n      \"Skipping Browserbase-only downloads test in LOCAL mode\",\n    );\n\n    // Skip if BROWSERBASE_API_KEY is not set\n    test.skip(\n      !process.env.BROWSERBASE_API_KEY,\n      \"Skipping test: BROWSERBASE_API_KEY not set\",\n    );\n\n    // Tiny timeout to force the race to hit the timeout branch\n    const page = v3.context.pages()[0];\n    await page.goto(\n      \"https://browserbase.github.io/stagehand-eval-sites/sites/download-on-click/\",\n    );\n    await page.locator(\"/html/body/button\").click();\n\n    await expect(async () => {\n      const bb = new Browserbase();\n      const zipBuffer = await bb.sessions.downloads.list(\n        v3.browserbaseSessionId,\n      );\n      if (!zipBuffer) {\n        throw new Error(\n          `Download buffer is empty for session ${v3.browserbaseSessionId}`,\n        );\n      }\n\n      const zip = new AdmZip(Buffer.from(await zipBuffer.arrayBuffer()));\n      const zipEntries = zip.getEntries();\n      const pdfEntry = zipEntries.find((entry) => pdfRe.test(entry.entryName));\n\n      if (!pdfEntry) {\n        throw new Error(\n          `Session ${v3.browserbaseSessionId} is missing a file matching \"${pdfRe.toString()}\" in its zip entries: ${JSON.stringify(zipEntries.map((entry) => entry.entryName))}`,\n        );\n      }\n\n      const expectedFileSize = 13264;\n      expect(pdfEntry.header.size).toBe(expectedFileSize);\n    }).toPass({\n      timeout: 30_000,\n    });\n  });\n});\n"]}

package/dist/esm/tests/integration/frame-get-location-and-click.spec.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/esm/tests/integration/frame-get-location-and-click.spec.js

@@ -0,0 +1,55 @@
+import { expect, test } from "@playwright/test";
+import { V3 } from "../../lib/v3/v3.js";
+import { v3TestConfig } from "./v3.config.js";
+test.describe("Coordinate-based clicking", () => {
+    let v3;
+    test.beforeEach(async () => {
+        v3 = new V3(v3TestConfig);
+        await v3.init();
+    });
+    test.afterEach(async () => {
+        await v3?.close?.().catch(() => { });
+    });
+    test("clicking by coordinates toggles a button state", async () => {
+        const page = v3.context.pages()[0];
+        await page.goto("data:text/html," +
+            encodeURIComponent(`<!doctype html><html><body>
+            <button id="btn" onclick="this.dataset.clicked = (this.dataset.clicked==='1'?'0':'1')">Click</button>
+            <div id="out"></div>
+            <script>
+              const btn = document.getElementById('btn');
+              const out = document.getElementById('out');
+              const update = () => { out.textContent = btn.dataset.clicked === '1' ? 'clicked' : 'idle'; };
+              update();
+              btn.addEventListener('click', update);
+            </script>
+          </body></html>`));
+        // Initial state should be idle
+        let state = await page.mainFrame().evaluate(() => {
+            const out = document.getElementById("out");
+            return out?.textContent || "";
+        });
+        expect(state).toBe("idle");
+        // Compute button location via Frame.getLocationForSelector
+        const { x, y, width, height } = await page
+            .mainFrame()
+            .getLocationForSelector("#btn");
+        // Click near the center of the button using Page.click coordinates
+        const cx = Math.round(x + width / 2);
+        const cy = Math.round(y + height / 2);
+        await page.click(cx, cy);
+        state = await page.mainFrame().evaluate(() => {
+            const out = document.getElementById("out");
+            return out?.textContent || "";
+        });
+        expect(state).toBe("clicked");
+        // Click again to toggle back to idle
+        await page.click(cx, cy);
+        state = await page.mainFrame().evaluate(() => {
+            const out = document.getElementById("out");
+            return out?.textContent || "";
+        });
+        expect(state).toBe("idle");
+    });
+});
+//# sourceMappingURL=frame-get-location-and-click.spec.js.map

package/dist/esm/tests/integration/frame-get-location-and-click.spec.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"frame-get-location-and-click.spec.js","sourceRoot":"","sources":["../../../../tests/integration/frame-get-location-and-click.spec.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,kBAAkB,CAAC;AAChD,OAAO,EAAE,EAAE,EAAE,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,YAAY,EAAE,MAAM,gBAAgB,CAAC;AAE9C,IAAI,CAAC,QAAQ,CAAC,2BAA2B,EAAE,GAAG,EAAE;IAC9C,IAAI,EAAM,CAAC;IAEX,IAAI,CAAC,UAAU,CAAC,KAAK,IAAI,EAAE;QACzB,EAAE,GAAG,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC;QAC1B,MAAM,EAAE,CAAC,IAAI,EAAE,CAAC;IAClB,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,SAAS,CAAC,KAAK,IAAI,EAAE;QACxB,MAAM,EAAE,EAAE,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;IACtC,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,gDAAgD,EAAE,KAAK,IAAI,EAAE;QAChE,MAAM,IAAI,GAAG,EAAE,CAAC,OAAO,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC,CAAC;QAEnC,MAAM,IAAI,CAAC,IAAI,CACb,iBAAiB;YACf,kBAAkB,CAChB;;;;;;;;;;yBAUe,CAChB,CACJ,CAAC;QAEF,+BAA+B;QAC/B,IAAI,KAAK,GAAG,MAAM,IAAI,CAAC,SAAS,EAAE,CAAC,QAAQ,CAAC,GAAG,EAAE;YAC/C,MAAM,GAAG,GAAG,QAAQ,CAAC,cAAc,CAAC,KAAK,CAAC,CAAC;YAC3C,OAAO,GAAG,EAAE,WAAW,IAAI,EAAE,CAAC;QAChC,CAAC,CAAC,CAAC;QACH,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QAE3B,2DAA2D;QAC3D,MAAM,EAAE,CAAC,EAAE,CAAC,EAAE,KAAK,EAAE,MAAM,EAAE,GAAG,MAAM,IAAI;aACvC,SAAS,EAAE;aACX,sBAAsB,CAAC,MAAM,CAAC,CAAC;QAElC,mEAAmE;QACnE,MAAM,EAAE,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,GAAG,KAAK,GAAG,CAAC,CAAC,CAAC;QACrC,MAAM,EAAE,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,GAAG,MAAM,GAAG,CAAC,CAAC,CAAC;QACtC,MAAM,IAAI,CAAC,KAAK,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;QAEzB,KAAK,GAAG,MAAM,IAAI,CAAC,SAAS,EAAE,CAAC,QAAQ,CAAC,GAAG,EAAE;YAC3C,MAAM,GAAG,GAAG,QAAQ,CAAC,cAAc,CAAC,KAAK,CAAC,CAAC;YAC3C,OAAO,GAAG,EAAE,WAAW,IAAI,EAAE,CAAC;QAChC,CAAC,CAAC,CAAC;QACH,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAE9B,qCAAqC;QACrC,MAAM,IAAI,CAAC,KAAK,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;QACzB,KAAK,GAAG,MAAM,IAAI,CAAC,SAAS,EAAE,CAAC,QAAQ,CAAC,GAAG,EAAE;YAC3C,MAAM,GAAG,GAAG,QAAQ,CAAC,cAAc,CAAC,KAAK,CAAC,CAAC;YAC3C,OAAO,GAAG,EAAE,WAAW,IAAI,EAAE,CAAC;QAChC,CAAC,CAAC,CAAC;QACH,MAAM,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IAC7B,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC","sourcesContent":["import { expect, test } from \"@playwright/test\";\nimport { V3 } from \"../../lib/v3/v3.js\";\nimport { v3TestConfig } from \"./v3.config.js\";\n\ntest.describe(\"Coordinate-based clicking\", () => {\n  let v3: V3;\n\n  test.beforeEach(async () => {\n    v3 = new V3(v3TestConfig);\n    await v3.init();\n  });\n\n  test.afterEach(async () => {\n    await v3?.close?.().catch(() => {});\n  });\n\n  test(\"clicking by coordinates toggles a button state\", async () => {\n    const page = v3.context.pages()[0];\n\n    await page.goto(\n      \"data:text/html,\" +\n        encodeURIComponent(\n          `<!doctype html><html><body>\n            <button id=\"btn\" onclick=\"this.dataset.clicked = (this.dataset.clicked==='1'?'0':'1')\">Click</button>\n            <div id=\"out\"></div>\n            <script>\n              const btn = document.getElementById('btn');\n              const out = document.getElementById('out');\n              const update = () => { out.textContent = btn.dataset.clicked === '1' ? 'clicked' : 'idle'; };\n              update();\n              btn.addEventListener('click', update);\n            </script>\n          </body></html>`,\n        ),\n    );\n\n    // Initial state should be idle\n    let state = await page.mainFrame().evaluate(() => {\n      const out = document.getElementById(\"out\");\n      return out?.textContent || \"\";\n    });\n    expect(state).toBe(\"idle\");\n\n    // Compute button location via Frame.getLocationForSelector\n    const { x, y, width, height } = await page\n      .mainFrame()\n      .getLocationForSelector(\"#btn\");\n\n    // Click near the center of the button using Page.click coordinates\n    const cx = Math.round(x + width / 2);\n    const cy = Math.round(y + height / 2);\n    await page.click(cx, cy);\n\n    state = await page.mainFrame().evaluate(() => {\n      const out = document.getElementById(\"out\");\n      return out?.textContent || \"\";\n    });\n    expect(state).toBe(\"clicked\");\n\n    // Click again to toggle back to idle\n    await page.click(cx, cy);\n    state = await page.mainFrame().evaluate(() => {\n      const out = document.getElementById(\"out\");\n      return out?.textContent || \"\";\n    });\n    expect(state).toBe(\"idle\");\n  });\n});\n"]}

package/dist/esm/tests/integration/iframe-ctx-addInitScript-race.spec.d.ts

@@ -0,0 +1 @@
+export {};

package/dist/esm/tests/integration/iframe-ctx-addInitScript-race.spec.js

@@ -0,0 +1,217 @@
+import { expect, test } from "@playwright/test";
+import { V3 } from "../../lib/v3/v3.js";
+import { v3TestConfig } from "./v3.config.js";
+const DEFAULT_INIT_SCRIPT_DELAY_MS = 250;
+const INIT_SCRIPT_DELAY_MS = (() => {
+    const rawValue = process.env.IFRAME_INIT_SCRIPT_SEND_DELAY_MS;
+    if (rawValue === undefined)
+        return DEFAULT_INIT_SCRIPT_DELAY_MS;
+    const parsed = Number(rawValue);
+    if (!Number.isFinite(parsed) || parsed <= 0)
+        return DEFAULT_INIT_SCRIPT_DELAY_MS;
+    return parsed;
+})();
+const POPUP_TIMEOUT_MS = 20_000;
+const RACE_INIT_SCRIPT_SENTINEL = "__stagehand_init_script_race_sentinel__";
+const INIT_SCRIPT_MARKER_KEY = "__stagehand_init_script_loaded__";
+const POPUP_URL = "https://example.com/";
+const POPUP_IFRAME_URL = "https://example.org/";
+const INIT_SCRIPT_SOURCE = `
+(() => {
+  /* ${RACE_INIT_SCRIPT_SENTINEL} */
+  window["${INIT_SCRIPT_MARKER_KEY}"] = true;
+})();
+`;
+async function closeAllPages(ctx) {
+    const pages = ctx.pages();
+    await Promise.allSettled(pages.map((page) => page.close()));
+}
+async function waitForPopupPage(ctx, knownTargetIds, timeoutMs = POPUP_TIMEOUT_MS) {
+    const deadline = Date.now() + timeoutMs;
+    while (Date.now() < deadline) {
+        const popup = ctx
+            .pages()
+            .find((candidate) => !knownTargetIds.has(candidate.targetId()));
+        if (popup)
+            return popup;
+        try {
+            const active = await ctx.awaitActivePage(500);
+            if (!knownTargetIds.has(active.targetId()))
+                return active;
+        }
+        catch {
+            // keep polling
+        }
+        await new Promise((resolve) => setTimeout(resolve, 50));
+    }
+    throw new Error("Timed out waiting for popup page");
+}
+async function waitForChildFrame(page, expectedUrl, timeoutMs = POPUP_TIMEOUT_MS) {
+    const mainFrameId = page.mainFrame().frameId;
+    const deadline = Date.now() + timeoutMs;
+    while (Date.now() < deadline) {
+        for (const frame of page.frames()) {
+            if (frame.frameId === mainFrameId)
+                continue;
+            try {
+                const href = await frame.evaluate(() => window.location.href);
+                if (href === expectedUrl)
+                    return frame;
+            }
+            catch {
+                // frame context may not be ready yet
+            }
+        }
+        await new Promise((resolve) => setTimeout(resolve, 50));
+    }
+    throw new Error("Timed out waiting for child frame");
+}
+async function prepareTargetBlankPopupOpener(opener) {
+    await opener.goto("about:blank", { waitUntil: "domcontentloaded" });
+    await opener.mainFrame().evaluate((popupUrl) => {
+        const link = document.createElement("a");
+        link.id = "open-popup";
+        link.target = "_blank";
+        link.href = popupUrl;
+        link.textContent = "open popup";
+        document.body.appendChild(link);
+    }, POPUP_URL);
+}
+async function prepareWindowOpenPopupOpener(opener) {
+    await opener.goto("about:blank", { waitUntil: "domcontentloaded" });
+    await opener.mainFrame().evaluate((popupUrl) => {
+        const button = document.createElement("button");
+        button.id = "open-popup";
+        button.textContent = "open popup";
+        button.addEventListener("click", () => {
+            window.open(popupUrl, "_blank");
+        });
+        document.body.appendChild(button);
+    }, POPUP_URL);
+}
+const POPUP_TRIGGER_CASES = [
+    {
+        name: 'target="_blank" link click',
+        prepare: prepareTargetBlankPopupOpener,
+    },
+    {
+        name: "window.open from click handler",
+        prepare: prepareWindowOpenPopupOpener,
+    },
+];
+test.describe("repro: popup iframe addInitScript race under delayed CDP send", () => {
+    test.describe.configure({ mode: "serial" });
+    let restoreSend;
+    let v3;
+    let ctx;
+    let sequence = 0;
+    let records = [];
+    test.beforeAll(async () => {
+        v3 = new V3(v3TestConfig);
+        await v3.init();
+        ctx = v3.context;
+        const conn = ctx.conn;
+        if (!conn || typeof conn._sendViaSession !== "function") {
+            throw new Error("Unable to access CDP connection for race repro patch");
+        }
+        const originalSendViaSession = conn._sendViaSession.bind(conn);
+        conn._sendViaSession = function patchedSendViaSession(sessionId, method, params) {
+            const source = typeof params?.source === "string"
+                ? params.source
+                : "";
+            const isRaceInitScript = method === "Page.addScriptToEvaluateOnNewDocument" &&
+                source.includes(RACE_INIT_SCRIPT_SENTINEL);
+            const sendNow = () => {
+                records.push({
+                    sequence: ++sequence,
+                    sessionId,
+                    method,
+                    isRaceInitScript,
+                });
+                return originalSendViaSession(sessionId, method, params);
+            };
+            if (isRaceInitScript && INIT_SCRIPT_DELAY_MS > 0) {
+                return new Promise((resolve, reject) => {
+                    setTimeout(() => {
+                        sendNow().then(resolve, reject);
+                    }, INIT_SCRIPT_DELAY_MS);
+                });
+            }
+            return sendNow();
+        };
+        restoreSend = () => {
+            conn._sendViaSession = originalSendViaSession;
+        };
+        await ctx.addInitScript(INIT_SCRIPT_SOURCE);
+    });
+    test.afterAll(async () => {
+        restoreSend?.();
+        await v3?.close?.().catch(() => { });
+    });
+    test.beforeEach(async () => {
+        records = [];
+        sequence = 0;
+        if (!ctx)
+            return;
+        await closeAllPages(ctx);
+    });
+    test.afterEach(async () => {
+        if (!ctx)
+            return;
+        await closeAllPages(ctx);
+    });
+    for (const popupCase of POPUP_TRIGGER_CASES) {
+        test(`should send addScript before resume for popup targets via ${popupCase.name}`, async () => {
+            if (!ctx)
+                throw new Error("Context not initialized");
+            const opener = await ctx.newPage();
+            await popupCase.prepare(opener);
+            const knownTargetIds = new Set(ctx.pages().map((p) => p.targetId()));
+            const knownSessionIds = new Set(records.map((record) => record.sessionId));
+            await opener.locator("#open-popup").click();
+            const popup = await waitForPopupPage(ctx, knownTargetIds);
+            await popup.waitForLoadState("load", POPUP_TIMEOUT_MS);
+            await popup.mainFrame().evaluate((iframeUrl) => {
+                const iframe = document.createElement("iframe");
+                iframe.id = "race-child-iframe";
+                iframe.src = iframeUrl;
+                document.body.appendChild(iframe);
+            }, POPUP_IFRAME_URL);
+            const iframe = await waitForChildFrame(popup, POPUP_IFRAME_URL, POPUP_TIMEOUT_MS);
+            const popupInitScriptMarker = await popup.mainFrame().evaluate((key) => {
+                return Boolean(Reflect.get(window, key));
+            }, INIT_SCRIPT_MARKER_KEY);
+            const iframeInitScriptMarker = await iframe.evaluate((key) => {
+                return Boolean(Reflect.get(window, key));
+            }, INIT_SCRIPT_MARKER_KEY);
+            const perSession = new Map();
+            for (const record of records) {
+                if (knownSessionIds.has(record.sessionId))
+                    continue;
+                const entry = perSession.get(record.sessionId) ?? {};
+                if (record.isRaceInitScript &&
+                    entry.raceInitScriptSequence === undefined) {
+                    entry.raceInitScriptSequence = record.sequence;
+                }
+                if (record.method === "Runtime.runIfWaitingForDebugger" &&
+                    entry.resumeSequence === undefined) {
+                    entry.resumeSequence = record.sequence;
+                }
+                perSession.set(record.sessionId, entry);
+            }
+            const comparableSessions = [...perSession.entries()]
+                .map(([sessionId, entry]) => ({ sessionId, ...entry }))
+                .filter((entry) => entry.raceInitScriptSequence !== undefined &&
+                entry.resumeSequence !== undefined);
+            expect(comparableSessions.length).toBeGreaterThan(0);
+            const orderingViolations = comparableSessions.filter((entry) => {
+                return (entry.raceInitScriptSequence >
+                    entry.resumeSequence);
+            });
+            expect(orderingViolations, `Expected addScript before resume for ${popupCase.name}. initScriptDelayMs=${INIT_SCRIPT_DELAY_MS}; comparableSessions=${JSON.stringify(comparableSessions)}`).toEqual([]);
+            expect(popupInitScriptMarker).toBe(true);
+            expect(iframeInitScriptMarker).toBe(true);
+        });
+    }
+});
+//# sourceMappingURL=iframe-ctx-addInitScript-race.spec.js.map

package/dist/esm/tests/integration/iframe-ctx-addInitScript-race.spec.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"iframe-ctx-addInitScript-race.spec.js","sourceRoot":"","sources":["../../../../tests/integration/iframe-ctx-addInitScript-race.spec.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,kBAAkB,CAAC;AAChD,OAAO,EAAE,EAAE,EAAE,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,YAAY,EAAE,MAAM,gBAAgB,CAAC;AAI9C,MAAM,4BAA4B,GAAG,GAAG,CAAC;AACzC,MAAM,oBAAoB,GAAG,CAAC,GAAG,EAAE;IACjC,MAAM,QAAQ,GAAG,OAAO,CAAC,GAAG,CAAC,gCAAgC,CAAC;IAC9D,IAAI,QAAQ,KAAK,SAAS;QAAE,OAAO,4BAA4B,CAAC;IAChE,MAAM,MAAM,GAAG,MAAM,CAAC,QAAQ,CAAC,CAAC;IAChC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,MAAM,IAAI,CAAC;QACzC,OAAO,4BAA4B,CAAC;IACtC,OAAO,MAAM,CAAC;AAChB,CAAC,CAAC,EAAE,CAAC;AAEL,MAAM,gBAAgB,GAAG,MAAM,CAAC;AAChC,MAAM,yBAAyB,GAAG,yCAAyC,CAAC;AAC5E,MAAM,sBAAsB,GAAG,kCAAkC,CAAC;AAClE,MAAM,SAAS,GAAG,sBAAsB,CAAC;AACzC,MAAM,gBAAgB,GAAG,sBAAsB,CAAC;AAEhD,MAAM,kBAAkB,GAAG;;OAEpB,yBAAyB;YACpB,sBAAsB;;CAEjC,CAAC;AAsBF,KAAK,UAAU,aAAa,CAAC,GAAc;IACzC,MAAM,KAAK,GAAG,GAAG,CAAC,KAAK,EAAE,CAAC;IAC1B,MAAM,OAAO,CAAC,UAAU,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,KAAK,EAAE,CAAC,CAAC,CAAC;AAC9D,CAAC;AAED,KAAK,UAAU,gBAAgB,CAC7B,GAAc,EACd,cAA2B,EAC3B,SAAS,GAAG,gBAAgB;IAE5B,MAAM,QAAQ,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS,CAAC;IAExC,OAAO,IAAI,CAAC,GAAG,EAAE,GAAG,QAAQ,EAAE,CAAC;QAC7B,MAAM,KAAK,GAAG,GAAG;aACd,KAAK,EAAE;aACP,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC,cAAc,CAAC,GAAG,CAAC,SAAS,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAC;QAClE,IAAI,KAAK;YAAE,OAAO,KAAK,CAAC;QACxB,IAAI,CAAC;YACH,MAAM,MAAM,GAAG,MAAM,GAAG,CAAC,eAAe,CAAC,GAAG,CAAC,CAAC;YAC9C,IAAI,CAAC,cAAc,CAAC,GAAG,CAAC,MAAM,CAAC,QAAQ,EAAE,CAAC;gBAAE,OAAO,MAAM,CAAC;QAC5D,CAAC;QAAC,MAAM,CAAC;YACP,eAAe;QACjB,CAAC;QACD,MAAM,IAAI,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,CAAC;IAC1D,CAAC;IAED,MAAM,IAAI,KAAK,CAAC,kCAAkC,CAAC,CAAC;AACtD,CAAC;AAED,KAAK,UAAU,iBAAiB,CAC9B,IAAU,EACV,WAAmB,EACnB,SAAS,GAAG,gBAAgB;IAE5B,MAAM,WAAW,GAAG,IAAI,CAAC,SAAS,EAAE,CAAC,OAAO,CAAC;IAC7C,MAAM,QAAQ,GAAG,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS,CAAC;IAExC,OAAO,IAAI,CAAC,GAAG,EAAE,GAAG,QAAQ,EAAE,CAAC;QAC7B,KAAK,MAAM,KAAK,IAAI,IAAI,CAAC,MAAM,EAAE,EAAE,CAAC;YAClC,IAAI,KAAK,CAAC,OAAO,KAAK,WAAW;gBAAE,SAAS;YAC5C,IAAI,CAAC;gBACH,MAAM,IAAI,GAAG,MAAM,KAAK,CAAC,QAAQ,CAAC,GAAG,EAAE,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC;gBAC9D,IAAI,IAAI,KAAK,WAAW;oBAAE,OAAO,KAAK,CAAC;YACzC,CAAC;YAAC,MAAM,CAAC;gBACP,qCAAqC;YACvC,CAAC;QACH,CAAC;QACD,MAAM,IAAI,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,CAAC;IAC1D,CAAC;IAED,MAAM,IAAI,KAAK,CAAC,mCAAmC,CAAC,CAAC;AACvD,CAAC;AAED,KAAK,UAAU,6BAA6B,CAAC,MAAY;IACvD,MAAM,MAAM,CAAC,IAAI,CAAC,aAAa,EAAE,EAAE,SAAS,EAAE,kBAAkB,EAAE,CAAC,CAAC;IACpE,MAAM,MAAM,CAAC,SAAS,EAAE,CAAC,QAAQ,CAAC,CAAC,QAAQ,EAAE,EAAE;QAC7C,MAAM,IAAI,GAAG,QAAQ,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC;QACzC,IAAI,CAAC,EAAE,GAAG,YAAY,CAAC;QACvB,IAAI,CAAC,MAAM,GAAG,QAAQ,CAAC;QACvB,IAAI,CAAC,IAAI,GAAG,QAAQ,CAAC;QACrB,IAAI,CAAC,WAAW,GAAG,YAAY,CAAC;QAChC,QAAQ,CAAC,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,CAAC;IAClC,CAAC,EAAE,SAAS,CAAC,CAAC;AAChB,CAAC;AAED,KAAK,UAAU,4BAA4B,CAAC,MAAY;IACtD,MAAM,MAAM,CAAC,IAAI,CAAC,aAAa,EAAE,EAAE,SAAS,EAAE,kBAAkB,EAAE,CAAC,CAAC;IACpE,MAAM,MAAM,CAAC,SAAS,EAAE,CAAC,QAAQ,CAAC,CAAC,QAAQ,EAAE,EAAE;QAC7C,MAAM,MAAM,GAAG,QAAQ,CAAC,aAAa,CAAC,QAAQ,CAAC,CAAC;QAChD,MAAM,CAAC,EAAE,GAAG,YAAY,CAAC;QACzB,MAAM,CAAC,WAAW,GAAG,YAAY,CAAC;QAClC,MAAM,CAAC,gBAAgB,CAAC,OAAO,EAAE,GAAG,EAAE;YACpC,MAAM,CAAC,IAAI,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;QAClC,CAAC,CAAC,CAAC;QACH,QAAQ,CAAC,IAAI,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC;IACpC,CAAC,EAAE,SAAS,CAAC,CAAC;AAChB,CAAC;AAED,MAAM,mBAAmB,GAAuB;IAC9C;QACE,IAAI,EAAE,4BAA4B;QAClC,OAAO,EAAE,6BAA6B;KACvC;IACD;QACE,IAAI,EAAE,gCAAgC;QACtC,OAAO,EAAE,4BAA4B;KACtC;CACF,CAAC;AAEF,IAAI,CAAC,QAAQ,CAAC,+DAA+D,EAAE,GAAG,EAAE;IAClF,IAAI,CAAC,QAAQ,CAAC,SAAS,CAAC,EAAE,IAAI,EAAE,QAAQ,EAAE,CAAC,CAAC;IAE5C,IAAI,WAAqC,CAAC;IAC1C,IAAI,EAAkB,CAAC;IACvB,IAAI,GAA0B,CAAC;IAC/B,IAAI,QAAQ,GAAG,CAAC,CAAC;IACjB,IAAI,OAAO,GAA2B,EAAE,CAAC;IAEzC,IAAI,CAAC,SAAS,CAAC,KAAK,IAAI,EAAE;QACxB,EAAE,GAAG,IAAI,EAAE,CAAC,YAAY,CAAC,CAAC;QAC1B,MAAM,EAAE,CAAC,IAAI,EAAE,CAAC;QAChB,GAAG,GAAG,EAAE,CAAC,OAAO,CAAC;QAEjB,MAAM,IAAI,GAAI,GAAyC,CAAC,IAAI,CAAC;QAC7D,IAAI,CAAC,IAAI,IAAI,OAAO,IAAI,CAAC,eAAe,KAAK,UAAU,EAAE,CAAC;YACxD,MAAM,IAAI,KAAK,CAAC,sDAAsD,CAAC,CAAC;QAC1E,CAAC;QAED,MAAM,sBAAsB,GAAG,IAAI,CAAC,eAAe,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC/D,IAAI,CAAC,eAAe,GAAG,SAAS,qBAAqB,CACnD,SAAiB,EACjB,MAAc,EACd,MAAe;YAEf,MAAM,MAAM,GACV,OAAQ,MAA2C,EAAE,MAAM,KAAK,QAAQ;gBACtE,CAAC,CAAE,MAA6B,CAAC,MAAM;gBACvC,CAAC,CAAC,EAAE,CAAC;YACT,MAAM,gBAAgB,GACpB,MAAM,KAAK,uCAAuC;gBAClD,MAAM,CAAC,QAAQ,CAAC,yBAAyB,CAAC,CAAC;YAE7C,MAAM,OAAO,GAAG,GAAG,EAAE;gBACnB,OAAO,CAAC,IAAI,CAAC;oBACX,QAAQ,EAAE,EAAE,QAAQ;oBACpB,SAAS;oBACT,MAAM;oBACN,gBAAgB;iBACjB,CAAC,CAAC;gBACH,OAAO,sBAAsB,CAAC,SAAS,EAAE,MAAM,EAAE,MAAM,CAAC,CAAC;YAC3D,CAAC,CAAC;YAEF,IAAI,gBAAgB,IAAI,oBAAoB,GAAG,CAAC,EAAE,CAAC;gBACjD,OAAO,IAAI,OAAO,CAAC,CAAC,OAAO,EAAE,MAAM,EAAE,EAAE;oBACrC,UAAU,CAAC,GAAG,EAAE;wBACd,OAAO,EAAE,CAAC,IAAI,CAAC,OAAO,EAAE,MAAM,CAAC,CAAC;oBAClC,CAAC,EAAE,oBAAoB,CAAC,CAAC;gBAC3B,CAAC,CAAC,CAAC;YACL,CAAC;YAED,OAAO,OAAO,EAAE,CAAC;QACnB,CAAC,CAAC;QAEF,WAAW,GAAG,GAAG,EAAE;YACjB,IAAI,CAAC,eAAe,GAAG,sBAAsB,CAAC;QAChD,CAAC,CAAC;QAEF,MAAM,GAAG,CAAC,aAAa,CAAC,kBAAkB,CAAC,CAAC;IAC9C,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,QAAQ,CAAC,KAAK,IAAI,EAAE;QACvB,WAAW,EAAE,EAAE,CAAC;QAChB,MAAM,EAAE,EAAE,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;IACtC,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,UAAU,CAAC,KAAK,IAAI,EAAE;QACzB,OAAO,GAAG,EAAE,CAAC;QACb,QAAQ,GAAG,CAAC,CAAC;QACb,IAAI,CAAC,GAAG;YAAE,OAAO;QACjB,MAAM,aAAa,CAAC,GAAG,CAAC,CAAC;IAC3B,CAAC,CAAC,CAAC;IAEH,IAAI,CAAC,SAAS,CAAC,KAAK,IAAI,EAAE;QACxB,IAAI,CAAC,GAAG;YAAE,OAAO;QACjB,MAAM,aAAa,CAAC,GAAG,CAAC,CAAC;IAC3B,CAAC,CAAC,CAAC;IAEH,KAAK,MAAM,SAAS,IAAI,mBAAmB,EAAE,CAAC;QAC5C,IAAI,CAAC,6DAA6D,SAAS,CAAC,IAAI,EAAE,EAAE,KAAK,IAAI,EAAE;YAC7F,IAAI,CAAC,GAAG;gBAAE,MAAM,IAAI,KAAK,CAAC,yBAAyB,CAAC,CAAC;YAErD,MAAM,MAAM,GAAG,MAAM,GAAG,CAAC,OAAO,EAAE,CAAC;YACnC,MAAM,SAAS,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC;YAEhC,MAAM,cAAc,GAAG,IAAI,GAAG,CAAC,GAAG,CAAC,KAAK,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAC;YACrE,MAAM,eAAe,GAAG,IAAI,GAAG,CAC7B,OAAO,CAAC,GAAG,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,SAAS,CAAC,CAC1C,CAAC;YAEF,MAAM,MAAM,CAAC,OAAO,CAAC,aAAa,CAAC,CAAC,KAAK,EAAE,CAAC;YAE5C,MAAM,KAAK,GAAG,MAAM,gBAAgB,CAAC,GAAG,EAAE,cAAc,CAAC,CAAC;YAC1D,MAAM,KAAK,CAAC,gBAAgB,CAAC,MAAM,EAAE,gBAAgB,CAAC,CAAC;YACvD,MAAM,KAAK,CAAC,SAAS,EAAE,CAAC,QAAQ,CAAC,CAAC,SAAS,EAAE,EAAE;gBAC7C,MAAM,MAAM,GAAG,QAAQ,CAAC,aAAa,CAAC,QAAQ,CAAC,CAAC;gBAChD,MAAM,CAAC,EAAE,GAAG,mBAAmB,CAAC;gBAChC,MAAM,CAAC,GAAG,GAAG,SAAS,CAAC;gBACvB,QAAQ,CAAC,IAAI,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC;YACpC,CAAC,EAAE,gBAAgB,CAAC,CAAC;YACrB,MAAM,MAAM,GAAG,MAAM,iBAAiB,CACpC,KAAK,EACL,gBAAgB,EAChB,gBAAgB,CACjB,CAAC;YAEF,MAAM,qBAAqB,GAAG,MAAM,KAAK,CAAC,SAAS,EAAE,CAAC,QAAQ,CAAC,CAAC,GAAG,EAAE,EAAE;gBACrE,OAAO,OAAO,CAAC,OAAO,CAAC,GAAG,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC,CAAC;YAC3C,CAAC,EAAE,sBAAsB,CAAC,CAAC;YAC3B,MAAM,sBAAsB,GAAG,MAAM,MAAM,CAAC,QAAQ,CAAC,CAAC,GAAG,EAAE,EAAE;gBAC3D,OAAO,OAAO,CAAC,OAAO,CAAC,GAAG,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC,CAAC;YAC3C,CAAC,EAAE,sBAAsB,CAAC,CAAC;YAE3B,MAAM,UAAU,GAAG,IAAI,GAAG,EAMvB,CAAC;YAEJ,KAAK,MAAM,MAAM,IAAI,OAAO,EAAE,CAAC;gBAC7B,IAAI,eAAe,CAAC,GAAG,CAAC,MAAM,CAAC,SAAS,CAAC;oBAAE,SAAS;gBACpD,MAAM,KAAK,GAAG,UAAU,CAAC,GAAG,CAAC,MAAM,CAAC,SAAS,CAAC,IAAI,EAAE,CAAC;gBACrD,IACE,MAAM,CAAC,gBAAgB;oBACvB,KAAK,CAAC,sBAAsB,KAAK,SAAS,EAC1C,CAAC;oBACD,KAAK,CAAC,sBAAsB,GAAG,MAAM,CAAC,QAAQ,CAAC;gBACjD,CAAC;gBACD,IACE,MAAM,CAAC,MAAM,KAAK,iCAAiC;oBACnD,KAAK,CAAC,cAAc,KAAK,SAAS,EAClC,CAAC;oBACD,KAAK,CAAC,cAAc,GAAG,MAAM,CAAC,QAAQ,CAAC;gBACzC,CAAC;gBACD,UAAU,CAAC,GAAG,CAAC,MAAM,CAAC,SAAS,EAAE,KAAK,CAAC,CAAC;YAC1C,CAAC;YAED,MAAM,kBAAkB,GAAG,CAAC,GAAG,UAAU,CAAC,OAAO,EAAE,CAAC;iBACjD,GAAG,CAAC,CAAC,CAAC,SAAS,EAAE,KAAK,CAAC,EAAE,EAAE,CAAC,CAAC,EAAE,SAAS,EAAE,GAAG,KAAK,EAAE,CAAC,CAAC;iBACtD,MAAM,CACL,CAAC,KAAK,EAAE,EAAE,CACR,KAAK,CAAC,sBAAsB,KAAK,SAAS;gBAC1C,KAAK,CAAC,cAAc,KAAK,SAAS,CACrC,CAAC;YACJ,MAAM,CAAC,kBAAkB,CAAC,MAAM,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC;YAErD,MAAM,kBAAkB,GAAG,kBAAkB,CAAC,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE;gBAC7D,OAAO,CACJ,KAAK,CAAC,sBAAiC;oBACvC,KAAK,CAAC,cAAyB,CACjC,CAAC;YACJ,CAAC,CAAC,CAAC;YAEH,MAAM,CACJ,kBAAkB,EAClB,wCAAwC,SAAS,CAAC,IAAI,uBAAuB,oBAAoB,wBAAwB,IAAI,CAAC,SAAS,CAAC,kBAAkB,CAAC,EAAE,CAC9J,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;YACd,MAAM,CAAC,qBAAqB,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACzC,MAAM,CAAC,sBAAsB,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC5C,CAAC,CAAC,CAAC;IACL,CAAC;AACH,CAAC,CAAC,CAAC","sourcesContent":["import { expect, test } from \"@playwright/test\";\nimport { V3 } from \"../../lib/v3/v3.js\";\nimport { v3TestConfig } from \"./v3.config.js\";\nimport type { V3Context } from \"../../lib/v3/understudy/context.js\";\nimport type { Page } from \"../../lib/v3/understudy/page.js\";\n\nconst DEFAULT_INIT_SCRIPT_DELAY_MS = 250;\nconst INIT_SCRIPT_DELAY_MS = (() => {\n  const rawValue = process.env.IFRAME_INIT_SCRIPT_SEND_DELAY_MS;\n  if (rawValue === undefined) return DEFAULT_INIT_SCRIPT_DELAY_MS;\n  const parsed = Number(rawValue);\n  if (!Number.isFinite(parsed) || parsed <= 0)\n    return DEFAULT_INIT_SCRIPT_DELAY_MS;\n  return parsed;\n})();\n\nconst POPUP_TIMEOUT_MS = 20_000;\nconst RACE_INIT_SCRIPT_SENTINEL = \"__stagehand_init_script_race_sentinel__\";\nconst INIT_SCRIPT_MARKER_KEY = \"__stagehand_init_script_loaded__\";\nconst POPUP_URL = \"https://example.com/\";\nconst POPUP_IFRAME_URL = \"https://example.org/\";\n\nconst INIT_SCRIPT_SOURCE = `\n(() => {\n  /* ${RACE_INIT_SCRIPT_SENTINEL} */\n  window[\"${INIT_SCRIPT_MARKER_KEY}\"] = true;\n})();\n`;\n\ntype PatchedConn = {\n  _sendViaSession: (\n    sessionId: string,\n    method: string,\n    params?: object,\n  ) => Promise<unknown>;\n};\n\ntype SessionCommandRecord = {\n  sequence: number;\n  sessionId: string;\n  method: string;\n  isRaceInitScript: boolean;\n};\n\ntype PopupTriggerCase = {\n  name: string;\n  prepare: (opener: Page) => Promise<void>;\n};\n\nasync function closeAllPages(ctx: V3Context): Promise<void> {\n  const pages = ctx.pages();\n  await Promise.allSettled(pages.map((page) => page.close()));\n}\n\nasync function waitForPopupPage(\n  ctx: V3Context,\n  knownTargetIds: Set<string>,\n  timeoutMs = POPUP_TIMEOUT_MS,\n): Promise<Page> {\n  const deadline = Date.now() + timeoutMs;\n\n  while (Date.now() < deadline) {\n    const popup = ctx\n      .pages()\n      .find((candidate) => !knownTargetIds.has(candidate.targetId()));\n    if (popup) return popup;\n    try {\n      const active = await ctx.awaitActivePage(500);\n      if (!knownTargetIds.has(active.targetId())) return active;\n    } catch {\n      // keep polling\n    }\n    await new Promise((resolve) => setTimeout(resolve, 50));\n  }\n\n  throw new Error(\"Timed out waiting for popup page\");\n}\n\nasync function waitForChildFrame(\n  page: Page,\n  expectedUrl: string,\n  timeoutMs = POPUP_TIMEOUT_MS,\n): Promise<ReturnType<Page[\"frames\"]>[number]> {\n  const mainFrameId = page.mainFrame().frameId;\n  const deadline = Date.now() + timeoutMs;\n\n  while (Date.now() < deadline) {\n    for (const frame of page.frames()) {\n      if (frame.frameId === mainFrameId) continue;\n      try {\n        const href = await frame.evaluate(() => window.location.href);\n        if (href === expectedUrl) return frame;\n      } catch {\n        // frame context may not be ready yet\n      }\n    }\n    await new Promise((resolve) => setTimeout(resolve, 50));\n  }\n\n  throw new Error(\"Timed out waiting for child frame\");\n}\n\nasync function prepareTargetBlankPopupOpener(opener: Page): Promise<void> {\n  await opener.goto(\"about:blank\", { waitUntil: \"domcontentloaded\" });\n  await opener.mainFrame().evaluate((popupUrl) => {\n    const link = document.createElement(\"a\");\n    link.id = \"open-popup\";\n    link.target = \"_blank\";\n    link.href = popupUrl;\n    link.textContent = \"open popup\";\n    document.body.appendChild(link);\n  }, POPUP_URL);\n}\n\nasync function prepareWindowOpenPopupOpener(opener: Page): Promise<void> {\n  await opener.goto(\"about:blank\", { waitUntil: \"domcontentloaded\" });\n  await opener.mainFrame().evaluate((popupUrl) => {\n    const button = document.createElement(\"button\");\n    button.id = \"open-popup\";\n    button.textContent = \"open popup\";\n    button.addEventListener(\"click\", () => {\n      window.open(popupUrl, \"_blank\");\n    });\n    document.body.appendChild(button);\n  }, POPUP_URL);\n}\n\nconst POPUP_TRIGGER_CASES: PopupTriggerCase[] = [\n  {\n    name: 'target=\"_blank\" link click',\n    prepare: prepareTargetBlankPopupOpener,\n  },\n  {\n    name: \"window.open from click handler\",\n    prepare: prepareWindowOpenPopupOpener,\n  },\n];\n\ntest.describe(\"repro: popup iframe addInitScript race under delayed CDP send\", () => {\n  test.describe.configure({ mode: \"serial\" });\n\n  let restoreSend: (() => void) | undefined;\n  let v3: V3 | undefined;\n  let ctx: V3Context | undefined;\n  let sequence = 0;\n  let records: SessionCommandRecord[] = [];\n\n  test.beforeAll(async () => {\n    v3 = new V3(v3TestConfig);\n    await v3.init();\n    ctx = v3.context;\n\n    const conn = (ctx as unknown as { conn?: PatchedConn }).conn;\n    if (!conn || typeof conn._sendViaSession !== \"function\") {\n      throw new Error(\"Unable to access CDP connection for race repro patch\");\n    }\n\n    const originalSendViaSession = conn._sendViaSession.bind(conn);\n    conn._sendViaSession = function patchedSendViaSession(\n      sessionId: string,\n      method: string,\n      params?: object,\n    ) {\n      const source =\n        typeof (params as { source?: unknown } | undefined)?.source === \"string\"\n          ? (params as { source: string }).source\n          : \"\";\n      const isRaceInitScript =\n        method === \"Page.addScriptToEvaluateOnNewDocument\" &&\n        source.includes(RACE_INIT_SCRIPT_SENTINEL);\n\n      const sendNow = () => {\n        records.push({\n          sequence: ++sequence,\n          sessionId,\n          method,\n          isRaceInitScript,\n        });\n        return originalSendViaSession(sessionId, method, params);\n      };\n\n      if (isRaceInitScript && INIT_SCRIPT_DELAY_MS > 0) {\n        return new Promise((resolve, reject) => {\n          setTimeout(() => {\n            sendNow().then(resolve, reject);\n          }, INIT_SCRIPT_DELAY_MS);\n        });\n      }\n\n      return sendNow();\n    };\n\n    restoreSend = () => {\n      conn._sendViaSession = originalSendViaSession;\n    };\n\n    await ctx.addInitScript(INIT_SCRIPT_SOURCE);\n  });\n\n  test.afterAll(async () => {\n    restoreSend?.();\n    await v3?.close?.().catch(() => {});\n  });\n\n  test.beforeEach(async () => {\n    records = [];\n    sequence = 0;\n    if (!ctx) return;\n    await closeAllPages(ctx);\n  });\n\n  test.afterEach(async () => {\n    if (!ctx) return;\n    await closeAllPages(ctx);\n  });\n\n  for (const popupCase of POPUP_TRIGGER_CASES) {\n    test(`should send addScript before resume for popup targets via ${popupCase.name}`, async () => {\n      if (!ctx) throw new Error(\"Context not initialized\");\n\n      const opener = await ctx.newPage();\n      await popupCase.prepare(opener);\n\n      const knownTargetIds = new Set(ctx.pages().map((p) => p.targetId()));\n      const knownSessionIds = new Set(\n        records.map((record) => record.sessionId),\n      );\n\n      await opener.locator(\"#open-popup\").click();\n\n      const popup = await waitForPopupPage(ctx, knownTargetIds);\n      await popup.waitForLoadState(\"load\", POPUP_TIMEOUT_MS);\n      await popup.mainFrame().evaluate((iframeUrl) => {\n        const iframe = document.createElement(\"iframe\");\n        iframe.id = \"race-child-iframe\";\n        iframe.src = iframeUrl;\n        document.body.appendChild(iframe);\n      }, POPUP_IFRAME_URL);\n      const iframe = await waitForChildFrame(\n        popup,\n        POPUP_IFRAME_URL,\n        POPUP_TIMEOUT_MS,\n      );\n\n      const popupInitScriptMarker = await popup.mainFrame().evaluate((key) => {\n        return Boolean(Reflect.get(window, key));\n      }, INIT_SCRIPT_MARKER_KEY);\n      const iframeInitScriptMarker = await iframe.evaluate((key) => {\n        return Boolean(Reflect.get(window, key));\n      }, INIT_SCRIPT_MARKER_KEY);\n\n      const perSession = new Map<\n        string,\n        {\n          raceInitScriptSequence?: number;\n          resumeSequence?: number;\n        }\n      >();\n\n      for (const record of records) {\n        if (knownSessionIds.has(record.sessionId)) continue;\n        const entry = perSession.get(record.sessionId) ?? {};\n        if (\n          record.isRaceInitScript &&\n          entry.raceInitScriptSequence === undefined\n        ) {\n          entry.raceInitScriptSequence = record.sequence;\n        }\n        if (\n          record.method === \"Runtime.runIfWaitingForDebugger\" &&\n          entry.resumeSequence === undefined\n        ) {\n          entry.resumeSequence = record.sequence;\n        }\n        perSession.set(record.sessionId, entry);\n      }\n\n      const comparableSessions = [...perSession.entries()]\n        .map(([sessionId, entry]) => ({ sessionId, ...entry }))\n        .filter(\n          (entry) =>\n            entry.raceInitScriptSequence !== undefined &&\n            entry.resumeSequence !== undefined,\n        );\n      expect(comparableSessions.length).toBeGreaterThan(0);\n\n      const orderingViolations = comparableSessions.filter((entry) => {\n        return (\n          (entry.raceInitScriptSequence as number) >\n          (entry.resumeSequence as number)\n        );\n      });\n\n      expect(\n        orderingViolations,\n        `Expected addScript before resume for ${popupCase.name}. initScriptDelayMs=${INIT_SCRIPT_DELAY_MS}; comparableSessions=${JSON.stringify(comparableSessions)}`,\n      ).toEqual([]);\n      expect(popupInitScriptMarker).toBe(true);\n      expect(iframeInitScriptMarker).toBe(true);\n    });\n  }\n});\n"]}

package/dist/esm/tests/integration/iframe-ctx-addInitScript.spec.d.ts

@@ -0,0 +1 @@
+export {};