@broberg/lens-daemon 0.1.34 → 0.1.36

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@broberg/lens-daemon",
-  "version": "0.1.34",
+  "version": "0.1.36",
   "description": "The Lens module of the cardmem daemon (flows, critic, coverage, capture sessions, the /lens/* routes and the cardmem-lens MCP) as a package. The daemon mounts createLensRouter(deps) + createLensMcpRouter(deps). Bun runtime.",
   "type": "module",
   "license": "MIT",

package/src/browser.ts

@@ -10,7 +10,7 @@
 // auth (F074.4) and concurrent captures never bleed into each other. The
 // context + page are always closed in a finally, even on capture error.
 
-import { bindProfileChannel, claimProfile, profileDir, type ProfileChannel } from './profiles.ts';
+import { bindProfileChannel, claimProfile, killOwnBrowsersOn, profileDir, type ProfileChannel } from './profiles.ts';
 import {
   chromium,
   webkit,
@@ -404,6 +404,9 @@ export function runBrowserLaunchOptions(b: RunBrowser) {
   return {
     channel: b.channel,
     headless: b.visible !== true,
+    // Playwright launches with --no-sandbox by default. This browser carries a real
+    // login (Google) and browses the open web, so Chrome's renderer sandbox stays ON.
+    chromiumSandbox: true,
     ignoreDefaultArgs: ['--enable-automation'],
     args: ['--disable-blink-features=AutomationControlled', '--disable-dev-shm-usage'],
   };
@@ -444,6 +447,7 @@ async function launchRunBrowser(opts: WithPageOptions, b: RunBrowser): Promise<{
     });
     return { context, userDataDir };
   } catch (err) {
+    killOwnBrowsersOn(userDataDir);
     if (!b.profile) await rm(userDataDir, { recursive: true, force: true }).catch(() => {});
     const msg = err instanceof Error ? err.message.split('\n')[0]! : String(err);
     throw new Error(`browser "${b.channel}" did not start: ${msg}${b.channel === 'chrome' ? ' — is Google Chrome installed on the daemon host?' : ''}`);

package/src/capture-session.ts

@@ -18,7 +18,7 @@
 // are confined to ~/.lens/state so a bad state_path can't clobber an arbitrary
 // file. The endpoint is loopback-only (127.0.0.1) behind the daemon's auth.
 
-import { bindProfileChannel, claimProfile, profileDir, type ProfileChannel } from './profiles.ts';
+import { bindProfileChannel, claimProfile, killOwnBrowsersOn, profileDir, type ProfileChannel } from './profiles.ts';
 import { EXTENSION_CHANNEL } from './browser.ts';
 import { chromium, type Browser, type BrowserContext, type Page } from 'playwright';
 import { z } from 'zod';
@@ -68,6 +68,9 @@ export function profileLaunchOptions(channel: ProfileChannel = EXTENSION_CHANNEL
     // F009.136 — 'chrome' when the runs that will use this profile run in Google
     // Chrome; the default stays the extension runs' build.
     channel,
+    // The login window holds the password + 2FA being typed: renderer sandbox ON
+    // (Playwright's default is --no-sandbox).
+    chromiumSandbox: true,
     ignoreDefaultArgs: ['--enable-automation'],
     args: ['--disable-blink-features=AutomationControlled'],
   };
@@ -418,6 +421,7 @@ export async function startCaptureSession(input: {
     try {
       context = await chromium.launchPersistentContext(dir, profileLaunchOptions(channel));
     } catch (err) {
+      killOwnBrowsersOn(dir);
       releaseProfile();
       throw err;
     }

package/src/profiles.ts

@@ -1,6 +1,7 @@
 // F009.132 — a fixed browser profile per site. Google binds its session to the
 // browser that holds it, so a login only survives if it happens in, and is reused
 // from, ONE profile of ONE browser build. The profile lives on the daemon host.
+import { execFileSync } from 'node:child_process';
 import { existsSync, mkdirSync, readFileSync, writeFileSync } from 'node:fs';
 import { homedir } from 'node:os';
 import { join } from 'node:path';
@@ -52,3 +53,31 @@ export function bindProfileChannel(name: string, channel: ProfileChannel): void
     );
   }
 }
+
+// F009.136 — when a launch on a profile fails, Playwright can leave the Chrome it
+// started running (measured twice on 25 Oct: a headless Chrome stayed up holding the
+// profile, so every retry hung on the lock it left). Kill only processes this
+// daemon started on this exact user-data dir.
+export function killOwnBrowsersOn(dir: string): number {
+  let out = '';
+  try {
+    out = execFileSync('ps', ['-eo', 'pid=,ppid=,args='], { encoding: 'utf8' });
+  } catch {
+    return 0;
+  }
+  let killed = 0;
+  for (const line of out.split('\n')) {
+    const m = /^\s*(\d+)\s+(\d+)\s+(.*)$/.exec(line);
+    // The EXACT dir: a plain substring test matched profile "a" inside "a-b" (measured).
+    const flag = `--user-data-dir=${dir}`;
+    const at = m ? (` ${m[3]!} `).indexOf(` ${flag} `) : -1;
+    if (!m || Number(m[2]) !== process.pid || at < 0) continue;
+    try {
+      process.kill(Number(m[1]), 'SIGKILL');
+      killed++;
+    } catch {
+      // already gone
+    }
+  }
+  return killed;
+}