@brimveyn/aimux 1.13.2 → 1.14.0

package/src/state/reducers/tab-state.ts

@@ -1,3 +1,5 @@
+import type { AppAction, AppState, TabSession } from '../types'
+
 import {
   allLeafIds,
   createGroupId,
@@ -15,13 +17,6 @@ import {
 import { normalizeGroupedTabOrder } from '../session-persistence'
 import { orderTabsByWorktree, withActiveWorktree } from '../session-worktrees'
 import { createDefaultTerminalModes } from '../terminal-modes'
-import {
-  type AppAction,
-  type AppState,
-  DEFAULT_SCROLL_INTENT,
-  deriveScrollIntent,
-  type TabSession,
-} from '../types'
 
 const MAX_BUFFER_LENGTH = 50_000
 
@@ -448,7 +443,6 @@ export function reduceTabState(state: AppState, action: AppAction): AppState | n
             buffer: '',
             errorMessage: undefined,
             exitCode: undefined,
-            scrollIntent: DEFAULT_SCROLL_INTENT,
             status: 'starting',
             terminalModes: createDefaultTerminalModes(),
             viewport: undefined,
@@ -470,23 +464,11 @@ export function reduceTabState(state: AppState, action: AppAction): AppState | n
         ...state,
         tabs: updateTab(state.tabs, action.tabId, (tab) => ({
           ...tab,
-          scrollIntent:
-            action.source === 'resize' || action.source === 'switch'
-              ? (tab.scrollIntent ?? DEFAULT_SCROLL_INTENT)
-              : deriveScrollIntent(action.viewport),
           status: tab.status === 'starting' ? 'running' : tab.status,
           terminalModes: action.terminalModes,
           viewport: action.viewport,
         })),
       }
-    case 'set-scroll-intent':
-      return {
-        ...state,
-        tabs: updateTab(state.tabs, action.tabId, (tab) => ({
-          ...tab,
-          scrollIntent: action.intent,
-        })),
-      }
     case 'set-tab-activity':
       return {
         ...state,

package/src/state/session-persistence.ts

@@ -1,12 +1,6 @@
+import type { AppState, TabSession, TabStatus, WorkspaceSnapshotV1 } from './types'
+
 import { allLeafIds, createGroupId, type LayoutNode, pruneLayoutTree } from './layout-tree'
-import {
-  type AppState,
-  DEFAULT_SCROLL_INTENT,
-  type ScrollIntent,
-  type TabSession,
-  type TabStatus,
-  type WorkspaceSnapshotV1,
-} from './types'
 
 export function createEmptyWorkspaceSnapshot(): WorkspaceSnapshotV1 {
   return {
@@ -47,7 +41,6 @@ export function serializeWorkspace(state: AppState): WorkspaceSnapshotV1 {
       errorMessage: tab.errorMessage,
       exitCode: tab.exitCode,
       id: tab.id,
-      scrollIntent: tab.scrollIntent,
       status: tab.status === 'disconnected' ? 'running' : tab.status,
       terminalModes: tab.terminalModes,
       title: tab.title,
@@ -76,7 +69,6 @@ export function restoreTabsFromWorkspace(snapshot: WorkspaceSnapshotV1 | undefin
       errorMessage: tab.errorMessage,
       exitCode: tab.exitCode,
       id: tab.id,
-      scrollIntent: tab.scrollIntent ?? DEFAULT_SCROLL_INTENT,
       status: getDisconnectedStatus(tab.status),
       terminalModes: tab.terminalModes,
       title: tab.title,
@@ -85,18 +77,6 @@ export function restoreTabsFromWorkspace(snapshot: WorkspaceSnapshotV1 | undefin
     }))
 }
 
-export function getSnapshotScrollIntents(
-  snapshot: WorkspaceSnapshotV1 | undefined
-): Map<string, ScrollIntent> {
-  if (!snapshot || snapshot.version !== 1) {
-    return new Map()
-  }
-
-  return new Map(
-    snapshot.tabs.map((tab) => [tab.id, tab.scrollIntent ?? DEFAULT_SCROLL_INTENT] as const)
-  )
-}
-
 export function restoreLayoutTrees(
   snapshot: WorkspaceSnapshotV1 | undefined,
   tabs: TabSession[]

package/src/state/types.ts

@@ -70,16 +70,11 @@ export interface TerminalSnapshot {
   cursorVisible: boolean
 }
 
+// The scroll position is owned end-to-end by the backend emulator; this type
+// only describes the re-anchor target the backend computes for itself across a
+// reflow. The frontend no longer derives, stores, or sends a scroll intent.
 export type ScrollIntent = { kind: 'bottom' } | { absoluteLine: number; kind: 'anchor' }
 
-export const DEFAULT_SCROLL_INTENT: ScrollIntent = { kind: 'bottom' }
-
-export function deriveScrollIntent(viewport: TerminalSnapshot): ScrollIntent {
-  return viewport.viewportY >= viewport.baseY
-    ? { kind: 'bottom' }
-    : { absoluteLine: viewport.viewportY, kind: 'anchor' }
-}
-
 export interface TerminalModeState {
   mouseTrackingMode: 'none' | 'x10' | 'vt200' | 'drag' | 'any'
   sendFocusMode: boolean
@@ -97,7 +92,6 @@ export interface PersistedTabSnapshot {
   buffer: string
   viewport?: TerminalSnapshot
   terminalModes: TerminalModeState
-  scrollIntent?: ScrollIntent
   errorMessage?: string
   exitCode?: number
   worktreeId?: string
@@ -163,7 +157,6 @@ export interface TabSession {
   buffer: string
   viewport?: TerminalSnapshot
   terminalModes: TerminalModeState
-  scrollIntent?: ScrollIntent
   command: string
   errorMessage?: string
   exitCode?: number
@@ -583,7 +576,6 @@ export type TabAction =
       terminalModes: TerminalModeState
       source?: 'resize' | 'scroll' | 'data' | 'switch'
     }
-  | { type: 'set-scroll-intent'; tabId: string; intent: ScrollIntent }
   | { type: 'set-tab-activity'; tabId: string; activity?: TabActivity }
   | { type: 'set-tab-error'; tabId: string; message: string }
 

package/src/state/validation.ts

@@ -56,13 +56,6 @@ function isTerminalSnapshot(value: unknown): value is TerminalSnapshot {
   )
 }
 
-function isScrollIntent(value: unknown): boolean {
-  if (!isObjectRecord(value)) return false
-  if (value.kind === 'bottom') return true
-  if (value.kind === 'anchor') return isFiniteNumber(value.absoluteLine)
-  return false
-}
-
 function isTerminalModeState(value: unknown): value is TerminalModeState {
   return (
     isObjectRecord(value) &&
@@ -149,7 +142,6 @@ export function isWorkspaceSnapshotV1(value: unknown): value is WorkspaceSnapsho
         isString(tab.buffer) &&
         isTerminalModeState(tab.terminalModes) &&
         (tab.viewport === undefined || isTerminalSnapshot(tab.viewport)) &&
-        (tab.scrollIntent === undefined || isScrollIntent(tab.scrollIntent)) &&
         (tab.errorMessage === undefined || isString(tab.errorMessage)) &&
         (tab.exitCode === undefined || isFiniteNumber(tab.exitCode)) &&
         (tab.worktreeId === undefined || isString(tab.worktreeId))

package/src/terminal-manager/manager-client.ts

@@ -1,12 +1,7 @@
 import { EventEmitter } from 'node:events'
 import { connect, type Socket } from 'node:net'
 
-import type {
-  ScrollIntent,
-  TerminalModeState,
-  TerminalSnapshot,
-  WorkspaceSnapshotV1,
-} from '../state/types'
+import type { TerminalModeState, TerminalSnapshot, WorkspaceSnapshotV1 } from '../state/types'
 
 import { getTerminalManagerSocketPath } from '../daemon/runtime-paths'
 import { logDebug } from '../debug/input-log'
@@ -306,29 +301,18 @@ export class TerminalManagerClient extends EventEmitter<ManagerClientEvents> {
     })
   }
 
-  async resize(
-    sessionId: string,
-    cols: number,
-    rows: number,
-    intents?: Record<string, ScrollIntent>
-  ): Promise<void> {
+  async resize(sessionId: string, cols: number, rows: number): Promise<void> {
     return this.sendExpectOk({
       id: crypto.randomUUID(),
-      payload: { cols, intents, rows, sessionId },
+      payload: { cols, rows, sessionId },
       type: 'resizeClient',
     })
   }
 
-  async resizeTab(
-    sessionId: string,
-    tabId: string,
-    cols: number,
-    rows: number,
-    intent?: ScrollIntent
-  ): Promise<void> {
+  async resizeTab(sessionId: string, tabId: string, cols: number, rows: number): Promise<void> {
     return this.sendExpectOk({
       id: crypto.randomUUID(),
-      payload: { cols, intent, rows, sessionId, tabId },
+      payload: { cols, rows, sessionId, tabId },
       type: 'resizeTab',
     })
   }
@@ -349,14 +333,6 @@ export class TerminalManagerClient extends EventEmitter<ManagerClientEvents> {
     })
   }
 
-  async reapplyScrollIntent(sessionId: string, tabId: string, intent: ScrollIntent): Promise<void> {
-    return this.sendExpectOk({
-      id: crypto.randomUUID(),
-      payload: { intent, sessionId, tabId },
-      type: 'reapplyScrollIntent',
-    })
-  }
-
   async setActiveTab(sessionId: string, tabId: string | null): Promise<void> {
     return this.sendExpectOk({
       id: crypto.randomUUID(),

package/src/terminal-manager/terminal-manager.ts

@@ -211,15 +211,10 @@ export async function runTerminalManager(): Promise<void> {
                 break
               case 'resizeClient': {
                 requireNegotiatedVersion(socket, negotiatedVersions)
-                const intentsRecord = message.payload.intents
-                const intentsMap = intentsRecord
-                  ? new Map(Object.entries(intentsRecord))
-                  : undefined
                 sessionManager.resize(
                   message.payload.sessionId,
                   message.payload.cols,
-                  message.payload.rows,
-                  intentsMap
+                  message.payload.rows
                 )
                 sendOk(socket, message.id)
                 break
@@ -230,8 +225,7 @@ export async function runTerminalManager(): Promise<void> {
                   message.payload.sessionId,
                   message.payload.tabId,
                   message.payload.cols,
-                  message.payload.rows,
-                  message.payload.intent
+                  message.payload.rows
                 )
                 sendOk(socket, message.id)
                 break
@@ -249,15 +243,6 @@ export async function runTerminalManager(): Promise<void> {
                 sessionManager.scrollToBottom(message.payload.sessionId, message.payload.tabId)
                 sendOk(socket, message.id)
                 break
-              case 'reapplyScrollIntent':
-                requireNegotiatedVersion(socket, negotiatedVersions)
-                sessionManager.reapplyScrollIntent(
-                  message.payload.sessionId,
-                  message.payload.tabId,
-                  message.payload.intent
-                )
-                sendOk(socket, message.id)
-                break
               case 'setActiveTab':
                 requireNegotiatedVersion(socket, negotiatedVersions)
                 sessionManager.setActiveTab(message.payload.sessionId, message.payload.tabId)