@brimveyn/aimux-config 0.5.9 → 0.5.12

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brimveyn/aimux-config",
-  "version": "0.5.9",
+  "version": "0.5.12",
   "description": "TypeScript configuration API for aimux — keymaps, themes, and backends with a fluent builder.",
   "keywords": [
     "aimux",

package/src/actions.ts

@@ -635,6 +635,12 @@ export const gitPush: ActionFn = (ctx: ModeContext) => {
   return r(clearPendingDelete(ctx), [{ type: 'git-push' }])
 }
 
+export const openSelectedGitFileInEditor: ActionFn = (ctx: ModeContext) => {
+  const file = selectedGitFile(ctx)
+  if (!file) return r([])
+  return r([], [{ path: file.path, type: 'open-file-in-editor' }])
+}
+
 // ---------------------------------------------------------------------------
 // Modal: git-commit
 // ---------------------------------------------------------------------------

package/src/defaults.ts

@@ -102,6 +102,7 @@ export function getDefaultKeymapConfig(): ResolvedKeymapConfig {
         .map('d', actions.gitDestructiveSelected, 'Unstage/delete')
         .map('D', actions.gitUnstageAll, 'Unstage all')
         .map('e', actions.gitToggleFoldAll, 'Expand/collapse all folds')
+        .map('o', actions.openSelectedGitFileInEditor, 'Open in editor')
         .map('c', actions.gitCommitOpen, 'Commit')
         .map('p', actions.gitPush, 'Push')
         .map('v', actions.toggleGitDiffView, 'Toggle split/stacked')

package/src/external-editor-runtime.ts

@@ -0,0 +1,78 @@
+import type { ExternalEditorConfig } from './types'
+
+/**
+ * Holds the resolved external-editor config so side effects (which run outside
+ * React) can read it synchronously. Set once at startup by the app.
+ */
+
+let current: ExternalEditorConfig = {}
+
+export function setExternalEditorConfig(value: ExternalEditorConfig): void {
+  current = value
+}
+
+export function getExternalEditorConfig(): ExternalEditorConfig {
+  return current
+}
+
+/** Editors known to be GUI — spawned detached so they don't claim aimux's TTY. */
+export const KNOWN_GUI_EDITORS: ReadonlySet<string> = new Set([
+  'appcode',
+  'atom',
+  'clion',
+  'code',
+  'code-insiders',
+  'codium',
+  'cursor',
+  'datagrip',
+  'fleet',
+  'gedit',
+  'goland',
+  'gvim',
+  'idea',
+  'kate',
+  'macvim',
+  'mate',
+  'mvim',
+  'phpstorm',
+  'pycharm',
+  'rider',
+  'rubymine',
+  'subl',
+  'sublime_text',
+  'vscodium',
+  'webstorm',
+  'windsurf',
+  'zed',
+])
+
+/** Per-editor default argv with `{file}` / `{line}` placeholders. */
+export const DEFAULT_EDITOR_ARGS: Record<string, string[]> = {
+  'clion': ['--line', '{line}', '{file}'],
+  'code': ['-g', '{file}:{line}'],
+  'code-insiders': ['-g', '{file}:{line}'],
+  'codium': ['-g', '{file}:{line}'],
+  'cursor': ['-g', '{file}:{line}'],
+  'emacs': ['+{line}', '{file}'],
+  'fleet': ['{file}:{line}'],
+  'goland': ['--line', '{line}', '{file}'],
+  'gvim': ['+{line}', '{file}'],
+  'helix': ['{file}:{line}'],
+  'hx': ['{file}:{line}'],
+  'idea': ['--line', '{line}', '{file}'],
+  'micro': ['{file}:{line}'],
+  'mvim': ['+{line}', '{file}'],
+  'nano': ['+{line}', '{file}'],
+  'nvim': ['+{line}', '{file}'],
+  'phpstorm': ['--line', '{line}', '{file}'],
+  'pycharm': ['--line', '{line}', '{file}'],
+  'rider': ['--line', '{line}', '{file}'],
+  'rubymine': ['--line', '{line}', '{file}'],
+  'subl': ['{file}:{line}'],
+  'sublime_text': ['{file}:{line}'],
+  'vim': ['+{line}', '{file}'],
+  'vscodium': ['-g', '{file}:{line}'],
+  'webstorm': ['--line', '{line}', '{file}'],
+  'windsurf': ['-g', '{file}:{line}'],
+  'zed': ['{file}:{line}'],
+}

package/src/index.ts

@@ -29,6 +29,12 @@ export { getDefaultKeymapConfig } from './defaults'
 export { resolveConfig } from './resolver'
 export { isAutoCommitEnabled, setAutoCommitEnabled } from './auto-commit-runtime'
 export { getMultiRepoConfig, setMultiRepoConfig } from './multi-repo-runtime'
+export {
+  DEFAULT_EDITOR_ARGS,
+  getExternalEditorConfig,
+  KNOWN_GUI_EDITORS,
+  setExternalEditorConfig,
+} from './external-editor-runtime'
 export { DEFAULT_MULTI_REPO_CONFIG } from './defaults'
 
 // User-facing config types (keymap/backends/sessions/etc.).
@@ -45,6 +51,7 @@ export type {
   BackendConfig,
   BindingDef,
   DiscoveredRepo,
+  ExternalEditorConfig,
   FocusMode,
   GitFileListMode,
   GitPaneConfig,

package/src/resolver.ts

@@ -36,6 +36,7 @@ export function resolveConfig(userConfig: AimuxUserConfig): ResolvedConfig {
   return {
     autoCommit,
     backends: userConfig.backends ?? {},
+    externalEditor: userConfig.externalEditor ?? {},
     gitPane: resolveGitPane(userConfig.gitPane),
     hooks: userConfig.hooks ?? {},
     keymaps,

package/src/types.ts

@@ -204,7 +204,7 @@ export interface GitPanelState {
   error: GitPanelError | null
 }
 
-export type DiffFileStatus = 'modified' | 'new' | 'deleted' | 'binary' | 'renamed'
+export type DiffFileStatus = 'modified' | 'new' | 'deleted' | 'binary' | 'renamed' | 'image'
 
 export interface DiffData {
   path: string
@@ -214,6 +214,10 @@ export interface DiffData {
   binarySizeBefore?: number
   binarySizeAfter?: number
   errorMessage?: string
+  imageBytesBefore?: Uint8Array
+  imageBytesAfter?: Uint8Array
+  imageMime?: string
+  imageFormatLabel?: string
 }
 
 export type GitDiffView = 'split' | 'stacked'
@@ -633,6 +637,7 @@ export type SideEffect =
   | { type: 'delete-session'; sessionId: string }
   | { type: 'toggle-transparent' }
   | { type: 'toggle-mode' }
+  | { type: 'open-file-in-editor'; path: string }
 
 // ─── Key input / KeyResult / ModeContext ──────────────────────────────────────
 
@@ -854,6 +859,29 @@ export interface StatusBarConfig {
   aiUsage?: AIUsageToolConfig
 }
 
+export interface ExternalEditorConfig {
+  /** Override `$VISUAL` / `$EDITOR`. */
+  command?: string
+  /**
+   * Force GUI (detached spawn — for vscode/cursor/etc.) or TUI (inline shellout
+   * that hands the TTY to the editor). Defaults: GUI for editors in a built-in
+   * allowlist (`code`, `cursor`, `subl`, JetBrains, …), TUI otherwise.
+   */
+  kind?: 'gui' | 'tui'
+  /** Argv passed to the editor. Placeholders: `{file}`, `{line}`. Sensible defaults per known editor. */
+  args?: string[]
+  /**
+   * Opt-in escape hatch for TUI editors only: when set, the TUI editor is
+   * launched in a new terminal window using this argv template instead of the
+   * default inline shellout. Ignored when `kind` resolves to `'gui'` — GUI
+   * editors always spawn detached into their own app window.
+   *
+   * Placeholders: `{cmd}` (shell-quoted `cd <cwd> && <editor> <args>`), `{cwd}`.
+   * Example: `['wezterm', 'start', '--cwd', '{cwd}', '--', 'sh', '-c', '{cmd}']`.
+   */
+  terminal?: string[]
+}
+
 export interface AimuxUserConfig {
   theme?: AimuxThemeConfig
   keymaps?: (k: KeymapBuilderApi) => KeymapBuilderApi
@@ -866,6 +894,7 @@ export interface AimuxUserConfig {
   autoCommit?: Partial<AutoCommitConfig>
   multiRepo?: Partial<MultiRepoConfig>
   statusBar?: StatusBarConfig
+  externalEditor?: ExternalEditorConfig
 }
 
 // ─── Resolved config (internal) ───────────────────────────────────────────────
@@ -938,4 +967,5 @@ export interface ResolvedConfig {
   autoCommit: AutoCommitConfig
   multiRepo: MultiRepoConfig
   statusBar: StatusBarConfig
+  externalEditor: ExternalEditorConfig
 }