@brillout/test-e2e 0.4.9 → 0.4.11

package/dist/runTests.js

@@ -16,10 +16,12 @@ const buildTs_1 = require("./buildTs");
 const findTestFiles_1 = require("./findTestFiles");
 const getConfig_1 = require("./getConfig");
 const logError_1 = require("./logError");
+let hasFailure = false;
 async function runTests(filter) {
     await (0, getConfig_1.loadConfig)();
     const testFiles = await (0, findTestFiles_1.findTestFiles)(filter);
     const browser = await (0, getBrowser_1.getBrowser)();
+    let hasFailedTest = false;
     for (const testFile of testFiles) {
         (0, utils_1.assert)(testFile.endsWith('.ts'));
         const testFileJs = testFile.replace('.ts', '.mjs');
@@ -31,11 +33,20 @@ async function runTests(filter) {
         finally {
             clean();
         }
-        await runTestFile(browser);
+        const success = await runTestFile(browser);
+        if (!success) {
+            hasFailedTest = true;
+        }
         (0, getCurrentTest_2.setCurrentTest)(null);
         (0, utils_1.assert)(testFileJs.endsWith('.mjs'));
     }
     await browser.close();
+    if (hasFailedTest || hasFailure) {
+        // hasFailedTest and hasFailure are redundant
+        //  - When assert.ts calls logFailure() this code block isn't run
+        (0, utils_1.assert)(hasFailedTest && hasFailure);
+        throw new Error('A test failed. See messages above.');
+    }
 }
 exports.runTests = runTests;
 async function runTestFile(browser) {
@@ -51,7 +62,7 @@ async function runTestFile(browser) {
         logTestStatus(false);
         (0, utils_1.assertUsage)(!testInfo.runInfo, 'You cannot call `run()` after calling `skip()`');
         (0, utils_1.assertUsage)(testInfo.tests === undefined, 'You cannot call `test()` after calling `skip()`');
-        return;
+        return true;
     }
     // Set when user calls `run()`
     (0, utils_1.assert)(testInfo.runInfo);
@@ -77,7 +88,7 @@ async function runTestFile(browser) {
         (0, logError_1.logError)(err);
         Logs_1.Logs.flushLogs();
         await abort();
-        return;
+        return false;
     }
     for (const { testDesc, testFn } of testInfo.tests) {
         Logs_1.Logs.add({
@@ -112,7 +123,7 @@ async function runTestFile(browser) {
                 Logs_1.Logs.logErrors(failOnWarning);
                 Logs_1.Logs.flushLogs();
                 await abort();
-                return;
+                return false;
             }
         }
         Logs_1.Logs.clearLogs();
@@ -128,11 +139,12 @@ async function runTestFile(browser) {
             Logs_1.Logs.logErrors(failOnWarning);
             Logs_1.Logs.flushLogs();
             await abort();
-            return;
+            return false;
         }
     }
     Logs_1.Logs.clearLogs();
     logTestStatus(true);
+    return true;
 }
 function getErrorType(failOnWarning) {
     return !failOnWarning ? 'error(s)' : 'error(s)/warning(s)';
@@ -178,6 +190,7 @@ function logTestStatus(success) {
     }
 }
 function logFailure(reason) {
+    hasFailure = true;
     logTestStatus(false);
     const { FAIL } = getStatusTags();
     const color = (s) => picocolors_1.default.red(picocolors_1.default.bold(s));

package/dist/setup.js

@@ -243,7 +243,7 @@ function stopProcess({ proc, cwd, cmd, force, }) {
         //     [15:36:10.626][\examples\react][npm run preview][stderr] ELIFECYCLE
         //     ```
         //     Because stderr isn't empty, runTests() believes that the termination failed.
-        //   - taskkill somtimes throws:
+        //   - taskkill sometimes throws:
         //     ```
         //     ERROR: The process with PID 6052 (child process of PID 3184) could not be terminated.
         //     Reason: There is no running instance of the task.
@@ -254,8 +254,13 @@ function stopProcess({ proc, cwd, cmd, force, }) {
         //     There doesn't seem to be an option to suppress these errors: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/taskkill#parameters
         (0, child_process_1.spawn)('taskkill', ['/pid', String(proc.pid), '/f', '/t'], {
             stdio: [
-                'inherit',
-                'inherit',
+                'ignore',
+                // Ignore:
+                // ```
+                // SUCCESS: The process with PID 6932 (child process of PID 2744) has been terminated.
+                // ```
+                // (Setting 'inherit' instead of 'ignore' attaches stdout to the root process and not to `proc` which is why the stdout of taskkill isn't intercepted by `proc.stdout.on('data', () => /* ... */)`.
+                'ignore',
                 // Ignoring stderr doesn't solve the problem that taskkill makes the process exit with code 1
                 'inherit', // stderr
             ],
@@ -318,7 +323,7 @@ function execRunScript({ onStdout, onFailure, onExit, }) {
             logSource: 'stdout',
             logText: data,
         });
-        /* These assertions sometimes fails, see comments in assertNotExited()
+        /* These assertions sometimes fail, see comments in assertNotExited()
         assertNotExited(data)
         assert(getRunInfo().cmd === cmd)
         /*/
@@ -333,7 +338,7 @@ function execRunScript({ onStdout, onFailure, onExit, }) {
             logSource: 'stderr',
             logText: data,
         });
-        /* These assertions sometimes fails, see comments in assertNotExited()
+        /* These assertions sometimes fail, see comments in assertNotExited()
         assertNotExited(data)
         assert(getRunInfo().cmd === cmd)
         /*/

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brillout/test-e2e",
-  "version": "0.4.9",
+  "version": "0.4.11",
   "bin": "./bin.js",
   "main": "./dist/index.js",
   "scripts": {