@brillout/test-e2e 0.4.2 → 0.4.4

package/dist/logSection.js

@@ -6,9 +6,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.logSection = void 0;
 const picocolors_1 = __importDefault(require("picocolors"));
 function logSection(sectionTitle) {
-    const title = `------ ${sectionTitle} ------`;
+    const title = `vvvvvv ${sectionTitle} vvvvvv`;
     const width = title.length;
-    console.log(picocolors_1.default.bold('='.repeat(width)));
+    console.log(picocolors_1.default.bold('v'.repeat(width)));
     console.log(picocolors_1.default.bold(title));
     console.log(picocolors_1.default.bold('v'.repeat(width)));
 }

package/dist/runTests.js

@@ -121,7 +121,9 @@ async function runTestFile(browser) {
     // Check whether stderr emitted during testInfo.terminateServer()
     {
         const failOnWarning = true;
-        if (Logs_1.Logs.hasErrorLogs(failOnWarning)) {
+        if (Logs_1.Logs.hasErrorLogs(failOnWarning) &&
+            // See comments about taskkill in src/setup.ts
+            !(0, utils_1.isWindows)()) {
             logFailureReason(`${getErrorType(failOnWarning)} occurred during server termination`);
             Logs_1.Logs.logErrors(failOnWarning);
             Logs_1.Logs.flushLogs();

package/dist/setup.js

@@ -231,30 +231,33 @@ function stopProcess({ proc, cwd, cmd, force, }) {
     if ((0, utils_1.isWindows)()) {
         // - https://github.com/nodejs/node/issues/3617#issuecomment-377731194
         // - https://stackoverflow.com/questions/23706055/why-can-i-not-kill-my-child-process-in-nodejs-on-windows/28163919#28163919
+        // - taskkill seems to be buggy in many ways:
+        //   - taskkill seems to make the process exit with code `1`
+        //   - Because process exits with code `1`, Node.js/npm complains:
+        //     ```
+        //     [15:36:10.626][\examples\react][npm run preview][stderr] npm
+        //     [15:36:10.626][\examples\react][npm run preview][stderr]
+        //     [15:36:10.626][\examples\react][npm run preview][stderr] ERR!
+        //     [15:36:10.626][\examples\react][npm run preview][stderr]
+        //     [15:36:10.626][\examples\react][npm run preview][stderr] code
+        //     [15:36:10.626][\examples\react][npm run preview][stderr] ELIFECYCLE
+        //     ```
+        //     Because stderr isn't empty, runTests() believes that the termination failed.
+        //   - taskkill somtimes throws:
+        //     ```
+        //     ERROR: The process with PID 6052 (child process of PID 3184) could not be terminated.
+        //     Reason: There is no running instance of the task.
+        //     ```
+        //     ```
+        //     ERROR: The process "6564" not found.
+        //     ```
+        //     There doesn't seem to be an option to suppress these errors: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/taskkill#parameters
         (0, child_process_1.spawn)('taskkill', ['/pid', String(proc.pid), '/f', '/t'], {
             stdio: [
-                'ignore',
-                'ignore',
-                // We ignore stderr because taskkill somtimes throws:
-                //   ```
-                //   ERROR: The process with PID 6052 (child process of PID 3184) could not be terminated.
-                //   Reason: There is no running instance of the task.
-                //   ```
-                //   ```
-                //   ERROR: The process "6564" not found.
-                //   ```
-                // There doesn't seem to be an option to suppress that error: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/taskkill#parameters
-                // The error propagates to Node.js's stderr.
-                //   ```
-                //   [15:36:10.626][\examples\react][npm run preview][stderr] npm
-                //   [15:36:10.626][\examples\react][npm run preview][stderr]
-                //   [15:36:10.626][\examples\react][npm run preview][stderr] ERR!
-                //   [15:36:10.626][\examples\react][npm run preview][stderr]
-                //   [15:36:10.626][\examples\react][npm run preview][stderr] code
-                //   [15:36:10.626][\examples\react][npm run preview][stderr] ELIFECYCLE
-                //   ```
-                // Because stderr isn't empty, runTests() believes that the termination failed.
-                'ignore', // stderr
+                'inherit',
+                'inherit',
+                // Ignoring stderr doesn't solve the problem that taskkill makes the process exit with code 1
+                'inherit', // stderr
             ],
         });
     }
@@ -309,7 +312,7 @@ function execRunScript({ onStdout, onFailure, onExit, }) {
         await exitAndFail(new Error(`Command is \`${cmd}\` (${cwd}) is invoking \`stdin\`: ${data}.`));
     });
     proc.stdout.on('data', (data) => {
-        (0, utils_2.assert)(!procExited);
+        assertNotExited(data);
         (0, utils_2.assert)(getRunInfo().cmd === cmd);
         data = data.toString();
         Logs_1.Logs.add({
@@ -319,7 +322,7 @@ function execRunScript({ onStdout, onFailure, onExit, }) {
         onStdout?.(data);
     });
     proc.stderr.on('data', async (data) => {
-        (0, utils_2.assert)(!procExited);
+        assertNotExited(data);
         (0, utils_2.assert)(getRunInfo().cmd === cmd);
         data = data.toString();
         Logs_1.Logs.add({
@@ -355,6 +358,17 @@ function execRunScript({ onStdout, onFailure, onExit, }) {
         exitPromiseResolve();
     });
     return { terminate, processHasExited };
+    function assertNotExited(data) {
+        if (!procExited)
+            return;
+        Logs_1.Logs.logErrors(true);
+        Logs_1.Logs.flushLogs();
+        console.log('getCurrentTest()', (0, getCurrentTest_1.getCurrentTest)());
+        console.log('data', data);
+        console.log('cmd', cmd);
+        console.log('process.platform', process.platform);
+        (0, utils_2.assert)(false);
+    }
     function processHasExited() {
         return procExited;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brillout/test-e2e",
-  "version": "0.4.2",
+  "version": "0.4.4",
   "bin": "./bin.js",
   "main": "./dist/index.js",
   "scripts": {