@brillout/test-e2e 0.4.1 → 0.4.3

package/dist/logSection.js

@@ -6,9 +6,10 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.logSection = void 0;
 const picocolors_1 = __importDefault(require("picocolors"));
 function logSection(sectionTitle) {
-    console.log();
-    console.log();
-    console.log();
-    console.log(picocolors_1.default.bold(`vvvvvv ${sectionTitle} vvvvvv`));
+    const title = `vvvvvv ${sectionTitle} vvvvvv`;
+    const width = title.length;
+    console.log(picocolors_1.default.bold('v'.repeat(width)));
+    console.log(picocolors_1.default.bold(title));
+    console.log(picocolors_1.default.bold('v'.repeat(width)));
 }
 exports.logSection = logSection;

package/dist/runTests.js

@@ -73,7 +73,6 @@ async function runTestFile(browser) {
         await testInfo.startServer();
     }
     catch (err) {
-        logResult(false);
         logFailureReason('an error occurred while starting the server');
         logError(err);
         Logs_1.Logs.flushLogs();
@@ -100,7 +99,6 @@ async function runTestFile(browser) {
             const hasErrorLog = Logs_1.Logs.hasErrorLogs(failOnWarning);
             const isFailure = err || hasErrorLog;
             if (isFailure) {
-                logResult(false);
                 if (err) {
                     logFailureReason(`the test "${testDesc}" threw an error`);
                     logError(err);
@@ -123,7 +121,9 @@ async function runTestFile(browser) {
     // Check whether stderr emitted during testInfo.terminateServer()
     {
         const failOnWarning = true;
-        if (Logs_1.Logs.hasErrorLogs(failOnWarning)) {
+        if (Logs_1.Logs.hasErrorLogs(failOnWarning) &&
+            // See comments about taskkill in src/setup.ts
+            !(0, utils_1.isWindows)()) {
             logFailureReason(`${getErrorType(failOnWarning)} occurred during server termination`);
             Logs_1.Logs.logErrors(failOnWarning);
             Logs_1.Logs.flushLogs();
@@ -178,10 +178,10 @@ function logResult(success) {
     }
 }
 function logFailureReason(reason) {
-    const testInfo = (0, getCurrentTest_1.getCurrentTest)();
+    logResult(false);
     const { FAIL } = getStatusTags();
     const color = (s) => picocolors_1.default.red(picocolors_1.default.bold(s));
-    const msg = `Test ${testInfo.testFile} ${FAIL} because ${reason}, see below.`;
+    const msg = `Test ${FAIL} because ${reason}, see below.`;
     console.log(color(msg));
 }
 function logError(err) {

package/dist/setup.js

@@ -26,7 +26,7 @@ Object.defineProperty(exports, "expectError", { enumerable: true, get: function
 const serverUrlDefault = 'http://localhost:3000';
 const TIMEOUT_NPM_SCRIPT = 2 * 60 * 1000 * (!(0, utils_1.isCI)() ? 1 : (0, utils_1.isWindows)() ? 2 : 1);
 const TIMEOUT_TEST_FUNCTION = 60 * 1000 * (!(0, utils_1.isCI)() ? 1 : (0, utils_1.isWindows)() ? 5 : 3);
-const TIMEOUT_PROCESS_TERMINATION = 10 * 1000 * (!(0, utils_1.isCI)() ? 1 : (0, utils_1.isWindows)() ? 10 : !(0, utils_1.isLinux)() ? 3 : 1);
+const TIMEOUT_PROCESS_TERMINATION = 10 * 1000 * (!(0, utils_1.isCI)() ? 1 : (0, utils_1.isWindows)() ? 3 : !(0, utils_1.isLinux)() ? 3 : 1);
 const TIMEOUT_AUTORETRY = TIMEOUT_TEST_FUNCTION / 2;
 const TIMEOUT_PLAYWRIGHT = TIMEOUT_TEST_FUNCTION / 2;
 function skip(reason) {
@@ -87,7 +87,7 @@ additionalTimeout = 0, serverIsReadyMessage, serverIsReadyDelay = 1000, inspect
         page_1.page.off('pageerror', onPageError);
         // `runProcess` is `undefined` if `start()` failed.
         if (runProcess) {
-            await runProcess.terminate('SIGINT');
+            await runProcess.terminate();
         }
     };
     return;
@@ -169,7 +169,7 @@ async function start() {
             logSource: 'run() failure',
             logText: errMsg,
         });
-        await terminate();
+        await terminate(true);
         rejectServerStart(new Error(errMsg));
     }, timeoutTotal);
     // Kill any process that listens to the server port
@@ -210,7 +210,7 @@ async function start() {
     });
     return promise;
 }
-function stopProcess({ proc, cwd, cmd, signal, }) {
+function stopProcess({ proc, cwd, cmd, force, }) {
     const prefix = `[Run Stop][${cwd}][${cmd}]`;
     let resolve;
     let reject;
@@ -231,16 +231,32 @@ function stopProcess({ proc, cwd, cmd, signal, }) {
     if ((0, utils_1.isWindows)()) {
         // - https://github.com/nodejs/node/issues/3617#issuecomment-377731194
         // - https://stackoverflow.com/questions/23706055/why-can-i-not-kill-my-child-process-in-nodejs-on-windows/28163919#28163919
+        // - taskkill seems to be buggy in many ways:
+        //   - taskkill seems to make the process exit with code `1`
+        //   - Because process exits with code `1`, Node.js/npm complains:
+        //     ```
+        //     [15:36:10.626][\examples\react][npm run preview][stderr] npm
+        //     [15:36:10.626][\examples\react][npm run preview][stderr]
+        //     [15:36:10.626][\examples\react][npm run preview][stderr] ERR!
+        //     [15:36:10.626][\examples\react][npm run preview][stderr]
+        //     [15:36:10.626][\examples\react][npm run preview][stderr] code
+        //     [15:36:10.626][\examples\react][npm run preview][stderr] ELIFECYCLE
+        //     ```
+        //     Because stderr isn't empty, runTests() believes that the termination failed.
+        //   - taskkill somtimes throws:
+        //     ```
+        //     ERROR: The process with PID 6052 (child process of PID 3184) could not be terminated.
+        //     Reason: There is no running instance of the task.
+        //     ```
+        //     ```
+        //     ERROR: The process "6564" not found.
+        //     ```
+        //     There doesn't seem to be an option to suppress these errors: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/taskkill#parameters
         (0, child_process_1.spawn)('taskkill', ['/pid', String(proc.pid), '/f', '/t'], {
             stdio: [
-                'ignore',
-                'ignore',
-                // Should we ignore `stderr`? Because `taskkill` somtimes throws:
-                // ```
-                // ERROR: The process with PID 6052 (child process of PID 3184) could not be terminated.
-                // Reason: There is no running instance of the task.
-                // ```
-                // There doesn't seem to be an option to suppress that error: https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/taskkill#parameters
+                'inherit',
+                'inherit',
+                // Ignoring stderr doesn't solve the problem that taskkill makes the process exit with code 1
                 'inherit', // stderr
             ],
         });
@@ -248,6 +264,7 @@ function stopProcess({ proc, cwd, cmd, signal, }) {
     else {
         (0, utils_2.assert)(proc.pid);
         const processGroup = -1 * proc.pid;
+        const signal = force ? 'SIGKILL' : 'SIGTERM';
         process.kill(processGroup, signal);
         /*
           try {
@@ -288,7 +305,7 @@ function execRunScript({ onStdout, onFailure, onExit, }) {
             logText: err.message,
             logSource: 'run() failure',
         });
-        await terminate();
+        await terminate(true);
         onFailure(err);
     };
     proc.stdin.on('data', async (data) => {
@@ -344,7 +361,7 @@ function execRunScript({ onStdout, onFailure, onExit, }) {
     function processHasExited() {
         return procExited;
     }
-    async function terminate(signal = 'SIGKILL') {
+    async function terminate(force) {
         let resolve;
         let reject;
         const promise = new Promise((_resolve, _reject) => {
@@ -368,7 +385,7 @@ function execRunScript({ onStdout, onFailure, onExit, }) {
                 proc,
                 cwd,
                 cmd,
-                signal,
+                force,
             });
         }
         catch (err) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brillout/test-e2e",
-  "version": "0.4.1",
+  "version": "0.4.3",
   "bin": "./bin.js",
   "main": "./dist/index.js",
   "scripts": {