@brightspace-ui/testing 1.39.0 → 1.39.2

package/package.json

@@ -2,7 +2,7 @@
   "name": "@brightspace-ui/testing",
   "description": "Utilities for testing front-end components and applications",
   "type": "module",
-  "version": "1.39.0",
+  "version": "1.39.2",
   "repository": "https://github.com/BrightspaceUI/testing.git",
   "scripts": {
     "lint": "npm run lint:eslint && npm run lint:style",

package/src/server/report/result.js

@@ -234,9 +234,9 @@ export function renderBrowserResults(browser, tests, options) {
 		let status = STATUS_TYPE.NORMAL;
 		if (resultData.info) {
 			status = STATUS_TYPE.WARNING;
-			if (resultData.duration > resultData.info.slowDuration) {
+			if (resultData.duration > resultData.slowDuration) {
 				status = STATUS_TYPE.ERROR;
-			} else if (resultData.duration < (resultData.info.slowDuration / 2)) {
+			} else if (resultData.duration < (resultData.slowDuration / 2)) {
 				status = STATUS_TYPE.NORMAL;
 			}
 		}

package/src/server/visual-diff-info.js

@@ -1,28 +1,28 @@
 const testInfoMap = new Map();
 
 export class TestInfoManager {
-	constructor(session, fullTitle) {
+	constructor(session, fullTitle, slowDuration) {
 		this.key = `${session.browser.name.toLowerCase()}|${session.testFile}|${fullTitle}`;
+		if (!testInfoMap.has(this.key)) testInfoMap.set(this.key, { slowDuration, tests: {} });
 	}
 	get() {
 		return testInfoMap.get(this.key);
 	}
 
 	set(testInfo, alt = 'default') {
-		if (testInfoMap.has(this.key)) {
-			const info = this.get()?.[alt] || {};
-			testInfo.slowDuration = info.slowDuration;
+		const tests = this.get().tests;
 
-			if (info.golden || testInfo.golden) {
-				testInfo.golden = { ...info.golden, ...testInfo.golden };
+		if (!(alt in tests)) {
+			tests[alt] = testInfo;
+		} else {
+			const info = tests[alt];
+			for (const prop in testInfo) {
+				if ((prop === 'golden' || prop === 'new') && prop in info) {
+					info[prop] = { ...info[prop], ...testInfo[prop] };
+				}
+				else info[prop] = testInfo[prop];
 			}
-			if (info.new || testInfo.new) {
-				testInfo.new = { ...info.new, ...testInfo.new };
-			}
-			testInfo.diff = testInfo.diff || info.diff;
 		}
-		const tests = testInfoMap.get(this.key) || {};
-		testInfoMap.set(this.key, { ...tests, [alt]: testInfo });
 	}
 }
 

package/src/server/visual-diff-plugin.js

@@ -185,7 +185,7 @@ export function visualDiff({ updateGoldens = false, runSubset = false } = {}) {
 			await clearAllDirs(updateGoldens, join(rootDir, PATHS.VDIFF_ROOT));
 		},
 		async executeCommand({ command, payload, session }) {
-			const infoManager = new TestInfoManager(session, payload.name);
+			const infoManager = new TestInfoManager(session, payload.name, payload.slowDuration);
 
 			if (session.browser.type !== 'playwright') {
 				throw new Error('Visual-diff is only supported for browser type Playwright.');
@@ -249,7 +249,6 @@ export function visualDiff({ updateGoldens = false, runSubset = false } = {}) {
 
 				const screenshotImage = PNG.sync.read(screenshotFileBuffers[alt]);
 				infoManager.set({
-					slowDuration: payload.slowDuration,
 					new: {
 						height: screenshotImage.height,
 						path: screenshotFileName.substring(rootLength),
@@ -303,7 +302,8 @@ export function visualDiff({ updateGoldens = false, runSubset = false } = {}) {
 							new: {
 								byteSize: screenshotSize
 							},
-							pixelsDiff
+							pixelsDiff,
+							byteSizeDiff: true
 						}, alt);
 						return { pass: false, message: 'Image diff is clean but the images do not have the same bytes.' };
 					}

package/src/server/visual-diff-reporter.js

@@ -92,8 +92,8 @@ function flattenResults(session, browserData, fileData) {
 			// tests missing info but with no error were skipped via grep, so exclude them
 			if (!allTestInfo && !t.error) return;
 
-			for (const test in allTestInfo) {
-				const info = allTestInfo[test];
+			for (const test in allTestInfo.tests) {
+				const info = allTestInfo.tests[test];
 				if (test !== 'default') testName = `${prefix}${t.name} (${test})`;
 				if (!fileData.tests.has(testName)) {
 					fileData.tests.set(testName, {
@@ -104,9 +104,9 @@ function flattenResults(session, browserData, fileData) {
 					});
 				}
 				const testData = fileData.tests.get(testName);
-				const bytediff = !t.passed && info?.diff === undefined && info?.pixelsDiff === 0;
-				if (!t.passed) {
-					if (bytediff) {
+				const passed = !!(info.golden) && !(info.pixelsDiff) && !(info.byteSizeDiff);
+				if (!passed) {
+					if (info.byteSizeDiff) {
 						browserData.numByteDiff++;
 						testData.numByteDiff++;
 					}
@@ -117,8 +117,9 @@ function flattenResults(session, browserData, fileData) {
 					name: browserData.name,
 					duration: t.duration,
 					error: t.error?.message,
-					passed: t.passed,
-					bytediff,
+					passed,
+					bytediff: info.byteSizeDiff,
+					slowDuration: allTestInfo.slowDuration,
 					info: info
 				});
 			}