@brightspace-ui/testing 1.39.0 → 1.39.1

package/package.json

@@ -2,7 +2,7 @@
   "name": "@brightspace-ui/testing",
   "description": "Utilities for testing front-end components and applications",
   "type": "module",
-  "version": "1.39.0",
+  "version": "1.39.1",
   "repository": "https://github.com/BrightspaceUI/testing.git",
   "scripts": {
     "lint": "npm run lint:eslint && npm run lint:style",

package/src/server/visual-diff-info.js

@@ -20,6 +20,7 @@ export class TestInfoManager {
 				testInfo.new = { ...info.new, ...testInfo.new };
 			}
 			testInfo.diff = testInfo.diff || info.diff;
+			testInfo.byteSizeDiff = testInfo.byteSizeDiff || info.byteSizeDiff;
 		}
 		const tests = testInfoMap.get(this.key) || {};
 		testInfoMap.set(this.key, { ...tests, [alt]: testInfo });

package/src/server/visual-diff-plugin.js

@@ -303,7 +303,8 @@ export function visualDiff({ updateGoldens = false, runSubset = false } = {}) {
 							new: {
 								byteSize: screenshotSize
 							},
-							pixelsDiff
+							pixelsDiff,
+							byteSizeDiff: true
 						}, alt);
 						return { pass: false, message: 'Image diff is clean but the images do not have the same bytes.' };
 					}

package/src/server/visual-diff-reporter.js

@@ -104,9 +104,9 @@ function flattenResults(session, browserData, fileData) {
 					});
 				}
 				const testData = fileData.tests.get(testName);
-				const bytediff = !t.passed && info?.diff === undefined && info?.pixelsDiff === 0;
-				if (!t.passed) {
-					if (bytediff) {
+				const passed = !!(info.golden) && !(info.pixelsDiff) && !(info.byteSizeDiff);
+				if (!passed) {
+					if (info.byteSizeDiff) {
 						browserData.numByteDiff++;
 						testData.numByteDiff++;
 					}
@@ -117,8 +117,8 @@ function flattenResults(session, browserData, fileData) {
 					name: browserData.name,
 					duration: t.duration,
 					error: t.error?.message,
-					passed: t.passed,
-					bytediff,
+					passed,
+					bytediff: info.byteSizeDiff,
 					info: info
 				});
 			}