@brightspace-ui/core 3.92.0 → 3.93.1

package/components/filter/demo/filter.html

@@ -31,7 +31,7 @@
 						<d2l-filter-dimension-set-value key="art" text="Art" count="12"></d2l-filter-dimension-set-value>
 						<d2l-filter-dimension-set-value key="astronomy" text="Astronomy" count="2" selected></d2l-filter-dimension-set-value>
 						<d2l-filter-dimension-set-value key="biology" text="Biology" count="15"></d2l-filter-dimension-set-value>
-						<d2l-filter-dimension-set-value key="chemistry" text="Chemistry" count="1"disabled></d2l-filter-dimension-set-value>
+						<d2l-filter-dimension-set-value key="chemistry" text="Chemistry" count="1" disabled selected></d2l-filter-dimension-set-value>
 						<d2l-filter-dimension-set-value key="drama" text="Drama" count="23" disabled></d2l-filter-dimension-set-value>
 						<d2l-filter-dimension-set-value key="english" text="English" count="100"></d2l-filter-dimension-set-value>
 						<d2l-filter-dimension-set-value key="how-to" text="How To Write a How To Article With a Flashy Title" count="100"></d2l-filter-dimension-set-value>

package/components/selection/selection-select-all.js

@@ -52,17 +52,31 @@ class SelectAll extends FocusMixin(LocalizeCoreElement(SelectionObserverMixin(Li
 		return html`
 			<d2l-input-checkbox
 				aria-label="${this.localize('components.selection.select-all')}"
-				@change="${this._handleCheckboxChange}"
-				?checked="${this.selectionInfo.state === SelectionInfo.states.all || this.selectionInfo.state === SelectionInfo.states.allPages}"
+				@change="${this.#handleCheckboxChange}"
+				?checked="${this.#getIsChecked()}"
 				?disabled="${this.disabled}"
 				description="${ifDefined(this.selectionInfo.state !== SelectionInfo.states.none ? summary : undefined)}"
-				?indeterminate="${this.selectionInfo.state === SelectionInfo.states.some}">
+				?indeterminate="${this.#getIsIndeterminate()}">
 			</d2l-input-checkbox>
 		`;
 	}
 
-	_handleCheckboxChange(e) {
-		if (this._provider) this._provider.setSelectionForAll(e.target.checked, false);
+	#getIsChecked() {
+		return this.selectionInfo.state === SelectionInfo.states.all || this.selectionInfo.state === SelectionInfo.states.allPages;
+	}
+
+	#getIsIndeterminate() {
+		return this.selectionInfo.state === SelectionInfo.states.some;
+	}
+
+	async #handleCheckboxChange(e) {
+		const checkbox = e.target;
+		if (this._provider) this._provider.setSelectionForAll(checkbox.checked, false);
+
+		// keep inner checkbox checked and indeterminate in sync with this.state
+		await this.updateComplete;
+		checkbox.checked = this.#getIsChecked();
+		checkbox.indeterminate = this.#getIsIndeterminate();
 	}
 
 }

package/components/tabs/demo/tabs.html

@@ -11,6 +11,7 @@
 			import '../../dropdown/dropdown-menu.js';
 			import '../../menu/menu.js';
 			import '../../menu/menu-item.js';
+			import '../tab.js';
 			import '../tabs.js';
 			import '../tab-panel.js';
 		</script>
@@ -35,35 +36,17 @@
 			</d2l-demo-snippet>
 
 			<h2>Tabs (paired d2l-tab with d2l-panel)</h2>
+			<div>This format is still a WIP. Please do not use yet.</div>
 
 			<d2l-demo-snippet>
-				<div>This format is not yet functional. Please do not use yet.</div>
 				<template>
 					<d2l-tabs>
 						<d2l-tab id="all" text="All" slot="tabs"></d2l-tab>
 						<d2l-tab id="biology" text="Biology" slot="tabs"></d2l-tab>
 						<d2l-tab id="chemistry" text="Chemistry" slot="tabs"></d2l-tab>
-						<d2l-tab id="earth" text="Earth &amp; Planetary Sciences" slot="tabs"></d2l-tab>
-						<d2l-tab id="physics" text="Physics" slot="tabs"></d2l-tab>
-						<d2l-tab id="math" text="Math" slot="tabs"></d2l-tab>
 						<d2l-tab-panel labelled-by="all" slot="panels">Tab content for All</d2l-tab-panel>
 						<d2l-tab-panel labelled-by="biology" slot="panels">Tab content for Biology</d2l-tab-panel>
 						<d2l-tab-panel labelled-by="chemistry" slot="panels">Tab content for Chemistry</d2l-tab-panel>
-						<d2l-tab-panel labelled-by="earth" slot="panels">Tab content for Earth &amp; Planetary Sciences</d2l-tab-panel>
-						<d2l-tab-panel labelled-by="physics" slot="panels">Tab content for physics</d2l-tab-panel>
-						<d2l-tab-panel labelled-by="math" slot="panels">Tab content for math</d2l-tab-panel>
-						<d2l-dropdown-button-subtle slot="ext" text="Explore Topics">
-							<d2l-dropdown-menu>
-								<d2l-menu label="Astronomy">
-									<d2l-menu-item text="Introduction"></d2l-menu-item>
-									<d2l-menu-item text="Searching for the Heavens "></d2l-menu-item>
-									<d2l-menu-item text="The Solar System"></d2l-menu-item>
-									<d2l-menu-item text="Stars &amp; Galaxies"></d2l-menu-item>
-									<d2l-menu-item text="The Night Sky"></d2l-menu-item>
-									<d2l-menu-item text="The Universe"></d2l-menu-item>
-								</d2l-menu>
-							</d2l-dropdown-menu>
-						</d2l-dropdown-button-subtle>
 					</d2l-tabs>
 				</template>
 			</d2l-demo-snippet>

package/components/tabs/tab-mixin.js

@@ -12,6 +12,8 @@ export const TabMixin = superclass => class extends SkeletonMixin(superclass) {
 	static get properties() {
 		return {
 			selected: { type: Boolean, reflect: true },
+			// eslint-disable-next-line lit/no-native-attributes
+			role: { type: String, reflect: true }
 		};
 	}
 
@@ -62,10 +64,8 @@ export const TabMixin = superclass => class extends SkeletonMixin(superclass) {
 
 	constructor() {
 		super();
-		this.ariaSelected = false;
 		this.role = 'tab';
 		this.selected = false;
-		this.tabIndex = -1;
 	}
 
 	connectedCallback() {

package/components/tabs/tabs.js

@@ -22,7 +22,6 @@ const scrollButtonWidth = 56;
  * A component for tabbed content. It supports the "d2l-tab-panel" component for the content, renders tabs responsively, and provides virtual scrolling for large tab lists.
  * @slot - Contains the tab panels (e.g., "d2l-tab-panel" components)
  * @slot ext - Additional content (e.g., a button) positioned at right
- * @fires d2l-tabs-initialized - Dispatched when the component is initialized
  */
 class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))) {
 
@@ -35,6 +34,7 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 			maxToShow: { type: Number, attribute: 'max-to-show' },
 			_allowScrollNext: { type: Boolean },
 			_allowScrollPrevious: { type: Boolean },
+			_defaultSlotBehavior: { state: true },
 			_maxWidth: { type: Number },
 			_scrollCollapsed: { type: Boolean },
 			_state: { type: String },
@@ -199,12 +199,13 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 		this.maxToShow = -1;
 		this._allowScrollNext = false;
 		this._allowScrollPrevious = false;
+		this._defaultSlotBehavior = true; // remove after d2l-tab/d2l-tab-panel backport
 		this._loadingCompleteResolve = undefined;
 		this._loadingCompletePromise = new Promise(resolve => this._loadingCompleteResolve = resolve);
 		this._maxWidth = null;
 		this._scrollCollapsed = false;
 		this._state = 'shown';
-		this._tabInfos = [];
+		this._tabInfos = []; // remove after d2l-tab/d2l-tab-panel backport
 		this._translationValue = 0;
 	}
 
@@ -315,6 +316,7 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 									text="${tabInfo.text}">
 								</d2l-tab-internal>
 							`)}
+							<slot name="tabs" @slotchange="${this._handleTabsSlotChange}"></slot>
 						</div>
 					`)}
 					<div class="d2l-tabs-scroll-next-container">
@@ -330,7 +332,8 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 			<div class="${classMap(panelContainerClasses)}"
 				@d2l-tab-panel-selected="${this._handlePanelSelected}"
 				@d2l-tab-panel-text-changed="${this._handlePanelTextChange}">
-				<slot @slotchange="${this._handlePanelsSlotChange}"></slot>
+				<slot @slotchange="${this._handleDefaultSlotChange}"></slot>
+				<slot name="panels"></slot>
 			</div>
 		`;
 	}
@@ -340,7 +343,7 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 	}
 
 	async getLoadingComplete() {
-		return this._loadingCompletePromise;
+		return this._defaultSlotBehavior ? this._loadingCompletePromise : true;
 	}
 
 	getTabListRect() {
@@ -495,6 +498,16 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 	}
 
 	_getPanel(id) {
+		if (this._defaultSlotBehavior) return this._getPanelDefaultSlotBehavior(id);
+
+		if (!this.shadowRoot) return;
+		const slot = this.shadowRoot.querySelector('slot[name="panels"]');
+		const panels = this._getPanels(slot);
+		return panels.find(panel => panel.labelledBy === id);
+	}
+
+	// remove after d2l-tab/d2l-tab-panel backport
+	_getPanelDefaultSlotBehavior(id) {
 		if (!this.shadowRoot) return;
 		// use simple selector for slot (Edge)
 		const slot = this.shadowRoot.querySelector('.d2l-panels-container').querySelector('slot');
@@ -508,30 +521,16 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 
 	_getPanels(slot) {
 		if (!slot) return;
-		return slot.assignedNodes({ flatten: true })
-			.filter((node) => node.nodeType === Node.ELEMENT_NODE && node.role === 'tabpanel');
+		return slot.assignedElements({ flatten: true }).filter((node) => node.role === 'tabpanel');
 	}
 
+	// remove after d2l-tab/d2l-tab-panel backport
 	_getTabInfo(id) {
 		return this._tabInfos.find((t) => t.id === id);
 	}
 
-	_handleFocusOut(e) {
-		if (e.relatedTarget && e.relatedTarget.role === 'tab') return;
-		this._resetFocusables();
-	}
-
-	_handlePanelSelected(e) {
-		const tabInfo = this._getTabInfo(e.target.id);
-		// event could be from nested tabs
-		if (!tabInfo) return;
-
-		this._setFocusable(tabInfo);
-		tabInfo.selected = true;
-		this.requestUpdate();
-	}
-
-	async _handlePanelsSlotChange(e) {
+	async _handleDefaultSlotChange(e) {
+		if (!this._defaultSlotBehavior) return;
 
 		const panels = this._getPanels(e.target);
 
@@ -611,10 +610,24 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 			});
 		}
 
-		this.dispatchEvent(new CustomEvent(
-			'd2l-tabs-initialized', { bubbles: true, composed: true }
-		));
+	}
 
+	_handleFocusOut(e) {
+		if (e.relatedTarget && e.relatedTarget.role === 'tab') return;
+		this._resetFocusables();
+	}
+
+	// remove after d2l-tab/d2l-tab-panel backport
+	_handlePanelSelected(e) {
+		if (!this._defaultSlotBehavior) return;
+
+		const tabInfo = this._getTabInfo(e.target.id);
+		// event could be from nested tabs
+		if (!tabInfo) return;
+
+		this._setFocusable(tabInfo);
+		tabInfo.selected = true;
+		this.requestUpdate();
 	}
 
 	async _handlePanelTextChange(e) {
@@ -713,6 +726,35 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 	}
 
 	async _handleTabSelected(e) {
+		if (this._defaultSlotBehavior) {
+			this._handleTabSelectedDefaultSlotBehavior(e);
+			return;
+		}
+
+		const selectedTab = e.target;
+		const selectedPanel = this._getPanel(e.target.id);
+		selectedTab.tabIndex = 0;
+
+		await this.updateComplete;
+
+		selectedPanel.selected = true;
+		this._tabs.forEach((tab) => {
+			if (tab.id !== selectedTab.id) {
+				if (tab.selected) {
+					tab.selected = false;
+					const panel = this._getPanel(tab.id);
+					// panel may not exist if it's being removed
+					if (panel) panel.selected = false;
+				}
+				if (tab.tabIndex === 0) tab.tabIndex = -1;
+			}
+		});
+
+		this.requestUpdate();
+	}
+
+	// remove after d2l-tab/d2l-tab-panel backport
+	async _handleTabSelectedDefaultSlotBehavior(e) {
 		e.stopPropagation();
 
 		const selectedTab = e.target;
@@ -739,6 +781,38 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 		this.requestUpdate();
 	}
 
+	async _handleTabsSlotChange(e) {
+		this._defaultSlotBehavior = false;
+
+		this._tabs = e.target.assignedElements({ flatten: true }).filter((node) => node.role === 'tab');
+
+		// handle case where there are less than two tabs initially
+		this._updateTabListVisibility(this._tabs);
+
+		if (!this._initialized && this._tabs.length === 0) return;
+
+		let selectedTab;
+		if (this._tabs.length > 0) {
+			selectedTab = this._tabs.find((tab) => tab.state !== 'removing');
+			if (selectedTab) {
+				selectedTab.selected = true;
+				selectedTab.tabIndex = 0;
+			}
+		}
+
+		await this.updateComplete;
+
+		if (!this._initialized && this._tabs.length > 0) {
+			this._initialized = true;
+		}
+
+		if (selectedTab) {
+			// set corresponding panel to selected
+			const selectedPanel = this._getPanel(selectedTab.id);
+			if (selectedPanel) selectedPanel.selected = true;
+		}
+	}
+
 	_isPositionInLeftScrollArea(position) {
 		return position > 0 && position < scrollButtonWidth;
 	}

package/custom-elements.json

@@ -12838,6 +12838,11 @@
           "description": "ACCESSIBILITY: REQUIRED: The text used for the tab, as well as labelling the panel.",
           "type": "string"
         },
+        {
+          "name": "role",
+          "type": "string",
+          "default": "\"tab\""
+        },
         {
           "name": "selected",
           "type": "boolean",
@@ -12856,13 +12861,9 @@
           "description": "ACCESSIBILITY: REQUIRED: The text used for the tab, as well as labelling the panel.",
           "type": "string"
         },
-        {
-          "name": "ariaSelected",
-          "type": "boolean",
-          "default": "false"
-        },
         {
           "name": "role",
+          "attribute": "role",
           "type": "string",
           "default": "\"tab\""
         },
@@ -12872,11 +12873,6 @@
           "type": "boolean",
           "default": "false"
         },
-        {
-          "name": "tabIndex",
-          "type": "number",
-          "default": "-1"
-        },
         {
           "name": "skeleton",
           "attribute": "skeleton",
@@ -12935,12 +12931,6 @@
           "type": "boolean"
         }
       ],
-      "events": [
-        {
-          "name": "d2l-tabs-initialized",
-          "description": "Dispatched when the component is initialized"
-        }
-      ],
       "slots": [
         {
           "name": "",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brightspace-ui/core",
-  "version": "3.92.0",
+  "version": "3.93.1",
   "description": "A collection of accessible, free, open-source web components for building Brightspace applications",
   "type": "module",
   "repository": "https://github.com/BrightspaceUI/core.git",