@brightspace-ui/core 3.66.0 → 3.66.2

package/components/button/button-toggle.js

@@ -2,7 +2,6 @@ import { css, html, LitElement } from 'lit';
 
 /**
  * A button container component for button toggles.
- * @fires click - Internal event
  */
 class ButtonToggle extends LitElement {
 
@@ -79,28 +78,17 @@ class ButtonToggle extends LitElement {
 		elem.focus();
 	}
 
-	_clickCancelled(e) {
-		e.stopPropagation();
-		const customClick = new CustomEvent('click', {
-			cancelable: true
-		});
-		e.target.dispatchEvent(customClick);
-		return customClick.defaultPrevented;
-	}
-
 	async _handleClick(pressed) {
 		this.pressed = pressed;
 		await this.updateComplete;
 		this.focus();
 	}
 
-	_handleNotPressedClick(e) {
-		if (this._clickCancelled(e)) return;
+	_handleNotPressedClick() {
 		this._handleClick(true);
 	}
 
-	_handlePressedClick(e) {
-		if (this._clickCancelled(e)) return;
+	_handlePressedClick() {
 		this._handleClick(false);
 	}
 

package/components/button/demo/button-toggle.html

@@ -54,30 +54,6 @@
 				</template>
 			</d2l-demo-snippet>
 
-			<h2>Toggle Button (consumer manages state)</h2>
-
-			<d2l-demo-snippet>
-				<template>
-					<d2l-button-toggle id="toggle-button-icon-consumer-manage-state">
-						<d2l-button-icon slot="not-pressed" icon="tier1:pin-hollow" text="Unpinned, click to pin." id="button-icon-not-pressed"></d2l-button-icon>
-						<d2l-button-icon slot="pressed" icon="tier1:pin-filled" text="Pinned, click to unpin." id="button-icon-pressed"></d2l-button-icon>
-					</d2l-button-toggle>
-					<script>
-						const buttonToggle = document.querySelector('#toggle-button-icon-consumer-manage-state');
-						buttonToggle.addEventListener('d2l-button-toggle-change', e => console.log(e));
-
-						document.querySelector('#button-icon-not-pressed').addEventListener('click', (e) => {
-							e.preventDefault();
-							buttonToggle.pressed = true;
-						});
-						document.querySelector('#button-icon-pressed').addEventListener('click', (e) => {
-							e.preventDefault();
-							buttonToggle.pressed = false;
-						});
-					</script>
-				</template>
-			</d2l-demo-snippet>
-
 		</d2l-demo-page>
 
 	</body>

package/components/inputs/input-text.js

@@ -486,7 +486,7 @@ class InputText extends InputInlineHelpMixin(PropertyRequiredMixin(FocusMixin(La
 		let tooltip = nothing;
 		if (!this.skeleton) {
 			if (this.validationError && !this.noValidate) {
-				// this tooltip is using "announced" since we don't want aria-describedby wire-up which would bury the message in VoiceOver's More Content Available menu
+				// this tooltip is using "announced" since we don't want aria-describedby wire-up - VoiceOver ignores our message when the input is invalid
 				tooltip = html`<d2l-tooltip state="error" announced align="start" class="vdiff-target">${this.validationError} <span class="d2l-offscreen">${this.description}</span></d2l-tooltip>`;
 			} else if (this.instructions) {
 				tooltip = html`<d2l-tooltip align="start" for="${this._inputId}" delay="1000" class="vdiff-target">${this.instructions}</d2l-tooltip>`;

package/components/tooltip/tooltip.js

@@ -730,9 +730,13 @@ class Tooltip extends RtlMixin(LitElement) {
 			target = ownerRoot.querySelector(targetSelector);
 			target = target || ownerRoot?.host?.querySelector(targetSelector);
 		} else {
-			console.warn('<d2l-tooltip>: missing required attribute "for"');
 			const parentNode = this.parentNode;
 			target = parentNode.nodeType === Node.DOCUMENT_FRAGMENT_NODE ? ownerRoot.host : parentNode;
+
+			// reduce console pollution since Safari + VO prevents inadequate SR experience for tooltips during form validation when using 'for'
+			if (!(target.tagName === 'D2L-INPUT-TEXT' && target?.invalid)) {
+				console.warn('<d2l-tooltip>: missing required attribute "for"');
+			}
 		}
 		return target;
 	}

package/custom-elements.json

@@ -739,10 +739,6 @@
         }
       ],
       "events": [
-        {
-          "name": "click",
-          "description": "Internal event"
-        },
         {
           "name": "d2l-button-toggle-change",
           "description": "Dispatched when the pressed state changes"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brightspace-ui/core",
-  "version": "3.66.0",
+  "version": "3.66.2",
   "description": "A collection of accessible, free, open-source web components for building Brightspace applications",
   "type": "module",
   "repository": "https://github.com/BrightspaceUI/core.git",