@brightspace-ui/core 3.317.0 → 3.317.1

package/components/tabs/tabs.js

@@ -217,13 +217,13 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 		this.maxToShow = -1;
 		this._allowScrollNext = false;
 		this._allowScrollPrevious = false;
-		this._loadingCompleteResolve = undefined;
-		this._loadingCompletePromise = new Promise(resolve => this._loadingCompleteResolve = resolve);
+		this.#loadingCompleteResolve = undefined;
+		this.#loadingCompletePromise = new Promise(resolve => this.#loadingCompleteResolve = resolve);
 		this._maxWidth = null;
 		this._scrollCollapsed = false;
 		this._state = 'shown';
-		this._tabIds = {};
-		this._tabs = [];
+		this.#tabIds = {};
+		this.#tabs = [];
 		this._translationValue = 0;
 	}
 
@@ -231,7 +231,7 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 		super.connectedCallback();
 
 		queueMicrotask(() => {
-			const bgColor = this._getComputedBackgroundColor();
+			const bgColor = this.#getComputedBackgroundColor();
 			if (bgColor && bgColor !== 'rgb(255, 255, 255)' && bgColor !== 'rgba(255, 255, 255, 1)') {
 				this.style.setProperty('--d2l-tabs-background-color', bgColor);
 			}
@@ -241,27 +241,27 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 
 	disconnectedCallback() {
 		super.disconnectedCallback();
-		if (this._resizeObserver) this._resizeObserver.disconnect();
+		if (this.#resizeObserver) this.#resizeObserver.disconnect();
 	}
 
 	firstUpdated(changedProperties) {
 		super.firstUpdated(changedProperties);
 
 		this.arrowKeysFocusablesProvider = async() => {
-			return this._tabs;
+			return this.#tabs;
 		};
 
 		this.arrowKeysOnBeforeFocus = async(tab) => {
-			this._setFocusable(tab);
+			this.#setFocusable(tab);
 
 			this.requestUpdate();
 			await this.updateComplete;
 
 			if (!this._scrollCollapsed) {
-				return this._updateScrollPosition(tab);
+				return this.#updateScrollPosition(tab);
 			} else {
-				const measures = this._getMeasures();
-				const newTranslationValue = this._calculateScrollPosition(tab, measures);
+				const measures = this.#getMeasures();
+				const newTranslationValue = this.#calculateScrollPosition(tab, measures);
 
 				if (!this.#isRTL()) {
 					if (newTranslationValue >= 0) return;
@@ -269,18 +269,17 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 					if (newTranslationValue <= 0) return;
 				}
 
-				const expanded = await this._tryExpandTabsContainer(measures);
+				const expanded = await this.#tryExpandTabsContainer(measures);
 				if (expanded) {
 					return;
 				} else {
-					return this._updateScrollPosition(tab);
+					return this.#updateScrollPosition(tab);
 				}
 			}
 		};
 
-		this._handleResize = this._handleResize.bind(this);
-		this._resizeObserver = new ResizeObserver(this._handleResize);
-		this._resizeObserver.observe(this.shadowRoot.querySelector('.d2l-tabs-container-list'));
+		this.#resizeObserver = new ResizeObserver(this.#handleResize);
+		this.#resizeObserver.observe(this.shadowRoot.querySelector('.d2l-tabs-container-list'));
 
 	}
 
@@ -313,27 +312,27 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 					style="${styleMap(tabsContainerStyles)}">
 					<div class="d2l-tabs-scroll-previous-container">
 						<button class="d2l-tabs-scroll-button"
-							@click="${this._handleScrollPrevious}"
+							@click="${this.#handleScrollPrevious}"
 							title="${this.localize('components.tabs.previous')}">
 							<d2l-icon icon="tier1:chevron-left"></d2l-icon>
 						</button>
 					</div>
 					${this.arrowKeysContainer(html`
 						<div class="d2l-tabs-container-list"
-							@d2l-tab-content-change="${this._handleTabContentChange}"
+							@d2l-tab-content-change="${this.#handleTabContentChange}"
 							@d2l-tab-hidden-change="${this.#handleTabHiddenChange}"
-							@d2l-tab-selected="${this._handleTabSelected}"
+							@d2l-tab-selected="${this.#handleTabSelected}"
 							@d2l-tab-deselected="${this.#handleTabDeselected}"
-							@focusout="${this._handleFocusOut}"
+							@focusout="${this.#handleFocusOut}"
 							aria-label="${ifDefined(this.text)}"
 							role="tablist"
 							style="${styleMap(tabsContainerListStyles)}">
-							<slot name="tabs" @slotchange="${this._handleTabsSlotChange}"></slot>
+							<slot name="tabs" @slotchange="${this.#handleTabsSlotChange}"></slot>
 						</div>
 					`)}
 					<div class="d2l-tabs-scroll-next-container">
 						<button class="d2l-tabs-scroll-button"
-							@click="${this._handleScrollNext}"
+							@click="${this.#handleScrollNext}"
 							title="${this.localize('components.tabs.next')}">
 							<d2l-icon icon="tier1:chevron-right"></d2l-icon>
 						</button>
@@ -342,17 +341,17 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 				<div class="d2l-tabs-container-ext"><slot name="ext"></slot></div>
 			</div>
 			<div class="${classMap(panelContainerClasses)}">
-				<slot name="panels" @slotchange="${this._handlePanelsSlotChange}"></slot>
+				<slot name="panels" @slotchange="${this.#handlePanelsSlotChange}"></slot>
 			</div>
 		`;
 	}
 
 	focus() {
-		return this._focusSelected();
+		return this.#focusSelected();
 	}
 
 	async getLoadingComplete() {
-		return this._loadingCompletePromise;
+		return this.#loadingCompletePromise;
 	}
 
 	getTabListRect() {
@@ -362,14 +361,28 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 
 	hideTab(tab) {
 		tab.setAttribute('data-state', 'removing');
-		return (Object.keys(this._tabIds).length > 1 && !reduceMotion) ? this._animateTabRemoval(tab) : Promise.resolve();
+		return (Object.keys(this.#tabIds).length > 1 && !reduceMotion) ? this.#animateTabRemoval(tab) : Promise.resolve();
 	}
 
 	#checkTabPanelMatchRequested;
+	#initialized;
+	#loadingCompletePromise;
+	#loadingCompleteResolve;
+	#measures;
 	#panels;
+	#resizeObserver;
+	#tabIds;
+	#tabs;
 	#updateAriaControlsRequested;
 
-	_animateTabAddition(tab) {
+	#handleResize = (entries) => {
+		const measures = this.#getMeasures();
+		if (entries.length === 1 && entries[0].contentRect.width === measures.tabsContainerListRect.width) return;
+		this.#updateMeasures();
+		this.#updateScrollVisibility(this.#getMeasures());
+	};
+
+	#animateTabAddition(tab) {
 		if (!tab || reduceMotion) {
 			return new Promise((resolve) => {
 				tab.setAttribute('data-state', '');
@@ -390,7 +403,7 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 		});
 	}
 
-	_animateTabRemoval(tab) {
+	#animateTabRemoval(tab) {
 		if (!tab || reduceMotion) return Promise.resolve();
 
 		return new Promise((resolve) => {
@@ -404,22 +417,120 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 		});
 	}
 
-	_calculateScrollPosition(selectedTab, measures) {
-		const tabs = this._tabs;
+	#calculateScrollPosition(selectedTab, measures) {
+		const tabs = this.#tabs;
 		const selectedTabIndex = tabs.indexOf(selectedTab);
 		return this.#calculateScrollPositionLogic(tabs, selectedTabIndex, measures);
 	}
 
-	async _focusSelected() {
-		const selectedTab = this._tabs.find(ti => ti.selected);
+	#calculateScrollPositionLogic(tabsDataStructure, selectedTabIndex, measures) {
+		if (!measures.tabRects[selectedTabIndex]) return 0;
+
+		const selectedTabMeasures = measures.tabRects[selectedTabIndex];
+
+		const isOverflowingLeft = (selectedTabMeasures.offsetLeft + this._translationValue < 0);
+		const isOverflowingRight = (selectedTabMeasures.offsetLeft + selectedTabMeasures.rect.width + this._translationValue > measures.tabsContainerRect.width);
+
+		const isRTL = this.#isRTL();
+
+		let getNewTranslationValue;
+		if (!isRTL) {
+			getNewTranslationValue = () => {
+				if (selectedTabIndex === 0) {
+					// position selected tab at beginning
+					return 0;
+				} else if (selectedTabIndex === (tabsDataStructure.length - 1)) {
+					// position selected tab at end
+					return -1 * (selectedTabMeasures.offsetLeft - measures.tabsContainerRect.width + selectedTabMeasures.rect.width);
+				} else {
+					// position selected tab in middle
+					return -1 * (selectedTabMeasures.offsetLeft - (measures.tabsContainerRect.width / 2) + (selectedTabMeasures.rect.width / 2));
+				}
+			};
+		} else {
+			getNewTranslationValue = () => {
+				if (selectedTabIndex === 0) {
+					// position selected tab at beginning
+					return 0;
+				} else if (selectedTabIndex === (tabsDataStructure.length - 1)) {
+					// position selected tab at end
+					return -1 * selectedTabMeasures.offsetLeft;
+				} else {
+					// position selected tab in middle
+					return (measures.tabsContainerRect.width / 2) - (selectedTabMeasures.offsetLeft + selectedTabMeasures.rect.width / 2) + (selectedTabMeasures.rect.width / 2);
+				}
+			};
+		}
+
+		let newTranslationValue = this._translationValue;
+		if (isOverflowingLeft || isOverflowingRight) {
+			newTranslationValue = getNewTranslationValue();
+		}
+
+		let expectedPosition;
+
+		// make sure the new position will not place selected tab behind left scroll button
+		if (!isRTL) {
+			expectedPosition = selectedTabMeasures.offsetLeft + newTranslationValue;
+			if (newTranslationValue < 0 && this.#isPositionInLeftScrollArea(expectedPosition)) {
+				newTranslationValue = getNewTranslationValue();
+			}
+		} else {
+			expectedPosition = selectedTabMeasures.offsetLeft + selectedTabMeasures.rect.width + newTranslationValue;
+			if (newTranslationValue > 0 && this.#isPositionInRightScrollArea(expectedPosition, measures)) {
+				newTranslationValue = getNewTranslationValue();
+			}
+		}
+
+		if (!isRTL) {
+			// make sure there will not be any empty space between left side of container and first tab
+			if (newTranslationValue > 0) newTranslationValue = 0;
+		} else {
+			// make sure there will not be any empty space between right side of container and first tab
+			if (newTranslationValue < 0) newTranslationValue = 0;
+		}
+
+		// make sure the new position will not place selected tab behind the right scroll button
+		if (!isRTL) {
+			expectedPosition = selectedTabMeasures.offsetLeft + selectedTabMeasures.rect.width + newTranslationValue;
+			if ((selectedTabIndex < tabsDataStructure.length - 1) && this.#isPositionInRightScrollArea(expectedPosition, measures)) {
+				newTranslationValue = getNewTranslationValue();
+			}
+		} else {
+			expectedPosition = selectedTabMeasures.offsetLeft + newTranslationValue;
+			if ((selectedTabIndex < tabsDataStructure.length - 1) && this.#isPositionInLeftScrollArea(expectedPosition)) {
+				newTranslationValue = getNewTranslationValue();
+			}
+		}
+
+		return newTranslationValue;
+	}
+
+	#checkTabPanelMatch() {
+		// debounce so only runs once when tabs/panels slots changing
+		if (this.#checkTabPanelMatchRequested) return;
+
+		this.#checkTabPanelMatchRequested = true;
+		setTimeout(() => {
+			if ((this.#tabs && !this.#panels) || (this.#panels && !this.#tabs)) {
+				console.warn('d2l-tabs: tabs and panels are not in sync');
+			} else if (this.#tabs.length !== this.#panels.length) {
+				console.warn('d2l-tabs: number of tabs and panels does not match');
+			}
+			this.#checkTabPanelMatchRequested = false;
+		}, 0);
+	}
+
+	async #focusSelected() {
+		const selectedTab = this.#tabs.find(ti => ti.selected);
 		if (!selectedTab) return;
 
-		await this._updateScrollPosition(selectedTab);
+		await this.#updateScrollPosition(selectedTab);
 
 		selectedTab.focus();
 	}
 
-	_getComputedBackgroundColor() {
+	#getComputedBackgroundColor() {
 		let bgColor = null;
 
 		findComposedAncestor(this, (node) => {
@@ -433,40 +544,33 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 		return bgColor;
 	}
 
-	_getMeasures() {
-		if (!this._measures) this._updateMeasures();
-		return this._measures;
+	#getMeasures() {
+		if (!this.#measures) this.#updateMeasures();
+		return this.#measures;
 	}
 
-	_getPanel(id) {
+	#getPanel(id) {
 		if (!this.#panels) return;
 		return this.#panels.find(panel => panel.labelledBy === id);
 	}
 
-	_handleFocusOut(e) {
+	#handleFocusOut(e) {
 		if (e.relatedTarget && e.relatedTarget.role === 'tab') return;
-		this._resetFocusables();
+		this.#resetFocusables();
 	}
 
-	_handlePanelsSlotChange(e) {
+	#handlePanelsSlotChange(e) {
 		this.#panels = e.target.assignedElements({ flatten: true }).filter((node) => node.role === 'tabpanel');
 		this.#checkTabPanelMatch();
 		this.#setAriaControls();
 	}
 
-	_handleResize(entries) {
-		const measures = this._getMeasures();
-		if (entries.length === 1 && entries[0].contentRect.width === measures.tabsContainerListRect.width) return;
-		this._updateMeasures();
-		this._updateScrollVisibility(this._getMeasures());
-	}
-
-	async _handleScrollNext() {
+	async #handleScrollNext() {
 
-		const measures = this._getMeasures();
+		const measures = this.#getMeasures();
 
-		const expanded = await this._tryExpandTabsContainer(measures);
-		const newMeasures = expanded ? this._getMeasures() : measures;
+		const expanded = await this.#tryExpandTabsContainer(measures);
+		const newMeasures = expanded ? this.#getMeasures() : measures;
 
 		let newTranslationValue;
 		const lastTabMeasures = measures.tabRects[measures.tabRects.length - 1];
@@ -496,8 +600,8 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 
 		}
 
-		await this._scrollToPosition(newTranslationValue);
-		await this._updateScrollVisibility(newMeasures);
+		await this.#scrollToPosition(newTranslationValue);
+		await this.#updateScrollVisibility(newMeasures);
 
 		if (!isOverflowingNext && this.shadowRoot) {
 			this.shadowRoot.querySelector('.d2l-tabs-scroll-previous-container button').focus();
@@ -505,12 +609,12 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 
 	}
 
-	async _handleScrollPrevious() {
+	async #handleScrollPrevious() {
 
-		const measures = this._getMeasures();
+		const measures = this.#getMeasures();
 
-		const expanded = await this._tryExpandTabsContainer(measures);
-		const newMeasures = expanded ? this._getMeasures() : measures;
+		const expanded = await this.#tryExpandTabsContainer(measures);
+		const newMeasures = expanded ? this.#getMeasures() : measures;
 
 		let newTranslationValue;
 		let isOverflowingPrevious;
@@ -529,8 +633,8 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 
 		}
 
-		await this._scrollToPosition(newTranslationValue);
-		await this._updateScrollVisibility(newMeasures);
+		await this.#scrollToPosition(newTranslationValue);
+		await this.#updateScrollVisibility(newMeasures);
 
 		if (!isOverflowingPrevious && this.shadowRoot) {
 			this.shadowRoot.querySelector('.d2l-tabs-scroll-next-container button').focus();
@@ -538,33 +642,50 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 
 	}
 
-	async _handleTabContentChange() {
-		this._updateMeasures();
-		await this._updateScrollVisibility(this._getMeasures());
+	async #handleTabContentChange() {
+		this.#updateMeasures();
+		await this.#updateScrollVisibility(this.#getMeasures());
+	}
+
+	#handleTabDeselected(e) {
+		const panel = this.#getPanel(e.target.id);
+		if (panel) panel._selected = false;
 	}
 
-	async _handleTabSelected(e) {
+	#handleTabHiddenChange() {
+		if (!this.#tabs || this.#tabs.length <= 1) return;
+
+		let visibleTabCount = 0;
+		this.#tabs.forEach((tab) => {
+			if (!tab.hidden) visibleTabCount++;
+		});
+
+		if (visibleTabCount > 1 && this._state === 'hidden') this.#showTabsList();
+		else if (visibleTabCount <= 1 && this._state === 'shown') this.#hideTabsList();
+	}
+
+	async #handleTabSelected(e) {
 		const selectedTab = e.target;
 		this.#updateSelectedTab(selectedTab);
 		await this.updateComplete;
-		this._updateScrollPosition(selectedTab);
+		this.#updateScrollPosition(selectedTab);
 	}
 
-	async _handleTabsSlotChange(e) {
-		this._tabs = e.target.assignedElements({ flatten: true }).filter((node) => node.role === 'tab');
+	async #handleTabsSlotChange(e) {
+		this.#tabs = e.target.assignedElements({ flatten: true }).filter((node) => node.role === 'tab');
 
 		// handle case where there are less than two tabs initially
-		this._updateTabListVisibility(this._tabs);
+		this.#updateTabListVisibility(this.#tabs);
 
-		if (!this._initialized && this._tabs.length === 0) return;
+		if (!this.#initialized && this.#tabs.length === 0) return;
 
 		let selectedTab = null;
 		const newTabIds = {};
-		this._tabs?.forEach((tab) => {
-			const isNew = this._initialized && !this._tabIds[tab.id];
-			if (isNew && !reduceMotion && this._tabs.length !== Object.keys(this._tabIds).length) {
+		this.#tabs?.forEach((tab) => {
+			const isNew = this.#initialized && !this.#tabIds[tab.id];
+			if (isNew && !reduceMotion && this.#tabs.length !== Object.keys(this.#tabIds).length) {
 				// if it's a new tab, update state to animate addition
-				this._tabIds[tab.id] = true;
+				this.#tabIds[tab.id] = true;
 				tab.setAttribute('data-state', 'adding');
 			}
 			if (tab.selected && tab.getAttribute('data-state') !== 'removing') {
@@ -574,10 +695,10 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 			newTabIds[tab.id] = true;
 		});
 
-		this._tabIds = newTabIds;
+		this.#tabIds = newTabIds;
 
 		if (!selectedTab) {
-			selectedTab = this._tabs.find((tab) => tab.getAttribute('data-state') !== 'removing');
+			selectedTab = this.#tabs.find((tab) => tab.getAttribute('data-state') !== 'removing');
 			if (selectedTab) selectedTab.selected = true;
 		}
 		if (selectedTab) {
@@ -590,42 +711,62 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 
 		const animPromises = [];
 
-		if (!this._initialized && this._tabs.length > 0) {
-			this._initialized = true;
-			await this._updateTabsContainerWidth(selectedTab);
+		if (!this.#initialized && this.#tabs.length > 0) {
+			this.#initialized = true;
+			await this.#updateTabsContainerWidth(selectedTab);
 		} else {
-			if (this._tabs.length > 1) {
-				this._tabs.forEach((tab) => {
-					if (tab.getAttribute('data-state') === 'adding') animPromises.push(this._animateTabAddition(tab));
+			if (this.#tabs.length > 1) {
+				this.#tabs.forEach((tab) => {
+					if (tab.getAttribute('data-state') === 'adding') animPromises.push(this.#animateTabAddition(tab));
 				});
 			}
-			this._updateMeasures();
+			this.#updateMeasures();
 		}
 
 		if (selectedTab) {
 			Promise.all(animPromises).then(async() => {
 				await new Promise(resolve => requestAnimationFrame(resolve));
-				this._updateMeasures();
-				this._updateScrollPosition(selectedTab);
+				this.#updateMeasures();
+				this.#updateScrollPosition(selectedTab);
 			});
 		}
 	}
 
-	_isPositionInLeftScrollArea(position) {
+	#hideTabsList() {
+		// don't animate the tabs list visibility if it's the inital render
+		if (reduceMotion || !this.#initialized || !isVisible(this)) {
+			this._state = 'hidden';
+		} else if (this.shadowRoot) {
+			const layout = this.shadowRoot.querySelector('.d2l-tabs-layout');
+			const handleTransitionEnd = (e) => {
+				if (e.propertyName !== 'max-height') return;
+				layout.removeEventListener('transitionend', handleTransitionEnd);
+				this._state = 'hidden';
+			};
+			layout.addEventListener('transitionend', handleTransitionEnd);
+			this._state = 'anim';
+		}
+	}
+
+	#isPositionInLeftScrollArea(position) {
 		return position > 0 && position < scrollButtonWidth;
 	}
 
-	_isPositionInRightScrollArea(position, measures) {
+	#isPositionInRightScrollArea(position, measures) {
 		return (position > measures.tabsContainerRect.width - scrollButtonWidth) && (position < measures.tabsContainerRect.width);
 	}
 
-	_resetFocusables() {
-		const selectedTab = this._tabs.find(ti => ti.selected);
-		if (selectedTab) this._setFocusable(selectedTab);
+	#isRTL() {
+		return document.documentElement.getAttribute('dir') === 'rtl';
+	}
+
+	#resetFocusables() {
+		const selectedTab = this.#tabs.find(ti => ti.selected);
+		if (selectedTab) this.#setFocusable(selectedTab);
 		this.requestUpdate();
 	}
 
-	_scrollToPosition(translationValue) {
+	#scrollToPosition(translationValue) {
 		if (translationValue === this._translationValue) {
 			return Promise.resolve();
 		}
@@ -646,14 +787,44 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 		});
 	}
 
-	_setFocusable(tab) {
-		const currentFocusable = this._tabs.find(tab => tab.tabIndex === 0);
+	#setAriaControls() {
+		// debounce so only runs once when tabs/panels slots changing
+		if (this.#updateAriaControlsRequested) return;
+
+		this.#updateAriaControlsRequested = true;
+		setTimeout(() => {
+			this.#tabs?.forEach((tab) => {
+				const panel = this.#getPanel(tab.id);
+				if (!panel) {
+					console.warn('d2l-tabs: tab without matching panel');
+					return;
+				}
+				tab.setAttribute('aria-controls', `${panel.id}`);
+			});
+			this.#updateAriaControlsRequested = false;
+		}, 0);
+	}
+
+	#setFocusable(tab) {
+		const currentFocusable = this.#tabs.find(tab => tab.tabIndex === 0);
 		if (currentFocusable) currentFocusable.tabIndex = -1;
 
 		tab.tabIndex = 0;
 	}
 
-	async _tryExpandTabsContainer(measures) {
+	#showTabsList() {
+		// don't animate the tabs list visibility if it's the inital render
+		if (reduceMotion || !this.#initialized) {
+			this._state = 'shown';
+		} else {
+			this._state = 'anim';
+			requestAnimationFrame(() => {
+				this._state = 'shown';
+			});
+		}
+	}
+
+	async #tryExpandTabsContainer(measures) {
 
 		if (!this._scrollCollapsed) return false;
 
@@ -680,14 +851,14 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 
 		await expandedPromise;
 
-		this._measures = null;
+		this.#measures = null;
 
-		await this._updateScrollVisibility(this._getMeasures());
+		await this.#updateScrollVisibility(this.#getMeasures());
 		this._maxWidth = null;
 
 		if (!this._allowScrollNext) {
 			if (!this._allowScrollPrevious) {
-				this._focusSelected();
+				this.#focusSelected();
 			} else {
 				if (this.shadowRoot) this.shadowRoot.querySelector('.d2l-tabs-scroll-previous-container button').focus();
 			}
@@ -697,10 +868,10 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 		return true;
 	}
 
-	_updateMeasures() {
+	#updateMeasures() {
 		let totalTabsWidth = 0;
 		if (!this.shadowRoot) return;
-		const tabs = this._tabs;
+		const tabs = this.#tabs;
 
 		const tabRects = tabs.map((tab) => {
 			const tabRect = tab.getBoundingClientRect();
@@ -714,7 +885,7 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 			return measures;
 		});
 
-		this._measures = {
+		this.#measures = {
 			tabsContainerRect: this.shadowRoot.querySelector('.d2l-tabs-container').getBoundingClientRect(),
 			tabsContainerListRect: this.shadowRoot.querySelector('.d2l-tabs-container-list').getBoundingClientRect(),
 			tabRects: tabRects,
@@ -722,13 +893,29 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 		};
 	}
 
-	_updateScrollPosition(selectedTab) {
-		const measures = this._getMeasures();
-		const newTranslationValue = this._calculateScrollPosition(selectedTab, measures);
+	#updateScrollPosition(selectedTab) {
+		const measures = this.#getMeasures();
+		const newTranslationValue = this.#calculateScrollPosition(selectedTab, measures);
 		return this.#updateScrollPositionLogic(measures, newTranslationValue);
 	}
 
-	_updateScrollVisibility(measures) {
+	#updateScrollPositionLogic(measures, newTranslationValue) {
+		const scrollToPromise = this.#scrollToPosition(newTranslationValue);
+		const scrollVisibilityPromise = this.#updateScrollVisibility(measures);
+		const p = Promise.all([
+			scrollVisibilityPromise,
+			scrollToPromise
+		]);
+		p.then(() => {
+			if (this.#loadingCompleteResolve) {
+				this.#loadingCompleteResolve();
+				this.#loadingCompleteResolve = undefined;
+			}
+		});
+		return p;
+	}
+
+	#updateScrollVisibility(measures) {
 
 		const lastTabMeasures = measures.tabRects[measures.tabRects.length - 1];
 		if (!lastTabMeasures) {
@@ -748,219 +935,19 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 		return this.updateComplete;
 	}
 
-	_updateTabListVisibility(tabs) {
-		const visibleCount = tabs.filter(tab => !tab.hidden).length;
-		if (this._state === 'shown' && visibleCount < 2) {
-			this.#hideTabsList();
-		} else if (this._state === 'hidden' && visibleCount > 1) {
-			this.#showTabsList();
-		} else if (this._state === 'shown' && visibleCount > 1) {
-			// check if there are hidden tabs and tab list container should actually be hidden
-			this.#handleTabHiddenChange();
-		}
-	}
-
-	_updateTabsContainerWidth(selectedTab) {
-		const tabs = this._tabs;
-		if (!this.maxToShow || this.maxToShow <= 0 || this.maxToShow >= tabs.length) return;
-		if (tabs.indexOf(selectedTab) > this.maxToShow - 1) return;
-		return this.#updateTabsContainerWidthLogic();
-	}
-
-	#calculateScrollPositionLogic(tabsDataStructure, selectedTabIndex, measures) {
-		if (!measures.tabRects[selectedTabIndex]) return 0;
-
-		const selectedTabMeasures = measures.tabRects[selectedTabIndex];
-
-		const isOverflowingLeft = (selectedTabMeasures.offsetLeft + this._translationValue < 0);
-		const isOverflowingRight = (selectedTabMeasures.offsetLeft + selectedTabMeasures.rect.width + this._translationValue > measures.tabsContainerRect.width);
-
-		const isRTL = this.#isRTL();
-
-		let getNewTranslationValue;
-		if (!isRTL) {
-			getNewTranslationValue = () => {
-				if (selectedTabIndex === 0) {
-					// position selected tab at beginning
-					return 0;
-				} else if (selectedTabIndex === (tabsDataStructure.length - 1)) {
-					// position selected tab at end
-					return -1 * (selectedTabMeasures.offsetLeft - measures.tabsContainerRect.width + selectedTabMeasures.rect.width);
-				} else {
-					// position selected tab in middle
-					return -1 * (selectedTabMeasures.offsetLeft - (measures.tabsContainerRect.width / 2) + (selectedTabMeasures.rect.width / 2));
-				}
-			};
-		} else {
-			getNewTranslationValue = () => {
-				if (selectedTabIndex === 0) {
-					// position selected tab at beginning
-					return 0;
-				} else if (selectedTabIndex === (tabsDataStructure.length - 1)) {
-					// position selected tab at end
-					return -1 * selectedTabMeasures.offsetLeft;
-				} else {
-					// position selected tab in middle
-					return (measures.tabsContainerRect.width / 2) - (selectedTabMeasures.offsetLeft + selectedTabMeasures.rect.width / 2) + (selectedTabMeasures.rect.width / 2);
-				}
-			};
-		}
-
-		let newTranslationValue = this._translationValue;
-		if (isOverflowingLeft || isOverflowingRight) {
-			newTranslationValue = getNewTranslationValue();
-		}
-
-		let expectedPosition;
-
-		// make sure the new position will not place selected tab behind left scroll button
-		if (!isRTL) {
-			expectedPosition = selectedTabMeasures.offsetLeft + newTranslationValue;
-			if (newTranslationValue < 0 && this._isPositionInLeftScrollArea(expectedPosition)) {
-				newTranslationValue = getNewTranslationValue();
-			}
-		} else {
-			expectedPosition = selectedTabMeasures.offsetLeft + selectedTabMeasures.rect.width + newTranslationValue;
-			if (newTranslationValue > 0 && this._isPositionInRightScrollArea(expectedPosition, measures)) {
-				newTranslationValue = getNewTranslationValue();
-			}
-		}
-
-		if (!isRTL) {
-			// make sure there will not be any empty space between left side of container and first tab
-			if (newTranslationValue > 0) newTranslationValue = 0;
-		} else {
-			// make sure there will not be any empty space between right side of container and first tab
-			if (newTranslationValue < 0) newTranslationValue = 0;
-		}
-
-		// make sure the new position will not place selected tab behind the right scroll button
-		if (!isRTL) {
-			expectedPosition = selectedTabMeasures.offsetLeft + selectedTabMeasures.rect.width + newTranslationValue;
-			if ((selectedTabIndex < tabsDataStructure.length - 1) && this._isPositionInRightScrollArea(expectedPosition, measures)) {
-				newTranslationValue = getNewTranslationValue();
-			}
-		} else {
-			expectedPosition = selectedTabMeasures.offsetLeft + newTranslationValue;
-			if ((selectedTabIndex < tabsDataStructure.length - 1) && this._isPositionInLeftScrollArea(expectedPosition)) {
-				newTranslationValue = getNewTranslationValue();
-			}
-		}
-
-		return newTranslationValue;
-	}
-
-	#checkTabPanelMatch() {
-		// debounce so only runs once when tabs/panels slots changing
-		if (this.#checkTabPanelMatchRequested) return;
-
-		this.#checkTabPanelMatchRequested = true;
-		setTimeout(() => {
-			if ((this._tabs && !this.#panels) || (this.#panels && !this._tabs)) {
-				console.warn('d2l-tabs: tabs and panels are not in sync');
-			} else if (this._tabs.length !== this.#panels.length) {
-				console.warn('d2l-tabs: number of tabs and panels does not match');
-			}
-			this.#checkTabPanelMatchRequested = false;
-		}, 0);
-	}
-
-	#handleTabDeselected(e) {
-		const panel = this._getPanel(e.target.id);
-		if (panel) panel._selected = false;
-	}
-
-	#handleTabHiddenChange() {
-		if (!this._tabs || this._tabs.length <= 1) return;
-
-		let visibleTabCount = 0;
-		this._tabs.forEach((tab) => {
-			if (!tab.hidden) visibleTabCount++;
-		});
-
-		if (visibleTabCount > 1 && this._state === 'hidden') this.#showTabsList();
-		else if (visibleTabCount <= 1 && this._state === 'shown') this.#hideTabsList();
-	}
-
-	#hideTabsList() {
-		// don't animate the tabs list visibility if it's the inital render
-		if (reduceMotion || !this._initialized || !isVisible(this)) {
-			this._state = 'hidden';
-		} else if (this.shadowRoot) {
-			const layout = this.shadowRoot.querySelector('.d2l-tabs-layout');
-			const handleTransitionEnd = (e) => {
-				if (e.propertyName !== 'max-height') return;
-				layout.removeEventListener('transitionend', handleTransitionEnd);
-				this._state = 'hidden';
-			};
-			layout.addEventListener('transitionend', handleTransitionEnd);
-			this._state = 'anim';
-		}
-	}
-
-	#isRTL() {
-		return document.documentElement.getAttribute('dir') === 'rtl';
-	}
-
-	#setAriaControls() {
-		// debounce so only runs once when tabs/panels slots changing
-		if (this.#updateAriaControlsRequested) return;
-
-		this.#updateAriaControlsRequested = true;
-		setTimeout(() => {
-			this._tabs?.forEach((tab) => {
-				const panel = this._getPanel(tab.id);
-				if (!panel) {
-					console.warn('d2l-tabs: tab without matching panel');
-					return;
-				}
-				tab.setAttribute('aria-controls', `${panel.id}`);
-			});
-			this.#updateAriaControlsRequested = false;
-		}, 0);
-	}
-
-	#showTabsList() {
-		// don't animate the tabs list visibility if it's the inital render
-		if (reduceMotion || !this._initialized) {
-			this._state = 'shown';
-		} else {
-			this._state = 'anim';
-			requestAnimationFrame(() => {
-				this._state = 'shown';
-			});
-		}
-	}
-
-	#updateScrollPositionLogic(measures, newTranslationValue) {
-		const scrollToPromise = this._scrollToPosition(newTranslationValue);
-		const scrollVisibilityPromise = this._updateScrollVisibility(measures);
-		const p = Promise.all([
-			scrollVisibilityPromise,
-			scrollToPromise
-		]);
-		p.then(() => {
-			if (this._loadingCompleteResolve) {
-				this._loadingCompleteResolve();
-				this._loadingCompleteResolve = undefined;
-			}
-		});
-		return p;
-	}
-
 	async #updateSelectedTab(selectedTab) {
 		await this.updateComplete;
 
 		selectedTab.selected = true;
 		selectedTab.tabIndex = 0;
 
-		const selectedPanel = this._getPanel(selectedTab.id);
+		const selectedPanel = this.#getPanel(selectedTab.id);
 		if (selectedPanel) selectedPanel._selected = true;
-		this._tabs.forEach((tab) => {
+		this.#tabs.forEach((tab) => {
 			if (tab.id !== selectedTab.id) {
 				if (tab.selected) {
 					tab.selected = false;
-					const panel = this._getPanel(tab.id);
+					const panel = this.#getPanel(tab.id);
 					// panel may not exist if it's being removed
 					if (panel) panel._selected = false;
 				}
@@ -969,8 +956,27 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 		});
 	}
 
+	#updateTabListVisibility(tabs) {
+		const visibleCount = tabs.filter(tab => !tab.hidden).length;
+		if (this._state === 'shown' && visibleCount < 2) {
+			this.#hideTabsList();
+		} else if (this._state === 'hidden' && visibleCount > 1) {
+			this.#showTabsList();
+		} else if (this._state === 'shown' && visibleCount > 1) {
+			// check if there are hidden tabs and tab list container should actually be hidden
+			this.#handleTabHiddenChange();
+		}
+	}
+
+	#updateTabsContainerWidth(selectedTab) {
+		const tabs = this.#tabs;
+		if (!this.maxToShow || this.maxToShow <= 0 || this.maxToShow >= tabs.length) return;
+		if (tabs.indexOf(selectedTab) > this.maxToShow - 1) return;
+		return this.#updateTabsContainerWidthLogic();
+	}
+
 	#updateTabsContainerWidthLogic() {
-		const measures = this._getMeasures();
+		const measures = this.#getMeasures();
 
 		let maxWidth = 4; // initial value to allow for padding hack
 		for (let i = 0; i < this.maxToShow; i++) {
@@ -985,7 +991,7 @@ class Tabs extends LocalizeCoreElement(ArrowKeysMixin(SkeletonMixin(LitElement))
 
 		this._maxWidth = maxWidth;
 		this._scrollCollapsed = true;
-		this._measures = null;
+		this.#measures = null;
 
 		return this.updateComplete;
 	}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@brightspace-ui/core",
-  "version": "3.317.0",
+  "version": "3.317.1",
   "description": "A collection of accessible, free, open-source web components for building Brightspace applications",
   "type": "module",
   "repository": "https://github.com/BrightspaceUI/core.git",